Re: [Intel-gfx] ctx->engines[rcs0, rcs0]

2019-03-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-25 10:52:07) > > On 25/03/2019 09:03, Chris Wilson wrote: > > The headline change is the wholehearted decision to allow the user to > > establish an ctx->engines mapping of [rcs0, rcs0] to mean two logically > > distinct pipelines to the same engine. An example of t

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Introduce concept of a sub-platform

2019-03-26 Thread Jani Nikula
On Tue, 26 Mar 2019, Jani Nikula wrote: > On Tue, 26 Mar 2019, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin >> >> Concept of a sub-platform already exist in our code (like ULX and ULT >> platform variants and similar),implemented via the macros which check a >> list of device ids to determine a

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix an IS_ERR() vs NULL check

2019-03-26 Thread Mika Kuoppala
Dan Carpenter writes: > The live_context() function returns error pointers. It never returns > NULL. > > Fixes: 9c1477e83e62 ("drm/i915/selftests: Exercise adding requests to a full > GGTT") > Signed-off-by: Dan Carpenter Reviewed-by: Mika Kuoppala i915_request.c has another :) -Mika > --

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 03/24] i915/gem_exec_schedule: Measure semaphore power consumption

2019-03-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-26 08:46:34) > > On 22/03/2019 09:21, Chris Wilson wrote: > > +static void measure_semaphore_power(int i915) > > +{ > > + struct gpu_power power; > > + unsigned int engine, signaler; > > + > > + igt_require(gpu_power_open(&power) == 0); > > + > > + f

Re: [Intel-gfx] [PATCH 6/9] drm/i915: switch intel_uncore_forcewake_for_reg to intel_uncore

2019-03-26 Thread kbuild test robot
Hi Daniele, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on next-20190326] [cannot apply to v5.1-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 05/24] i915/gem_exec_schedule: Verify that using HW semaphores doesn't block

2019-03-26 Thread Tvrtko Ursulin
On 22/03/2019 09:21, Chris Wilson wrote: We may use HW semaphores to schedule nearly-ready work such that they are already spinning on the GPU waiting for the completion on another engine. However, we don't want for that spinning task to actually block any real work should it be scheduled. Sign

[Intel-gfx] [PATCH i-g-t v2] lib: Add GPU power measurement

2019-03-26 Thread Chris Wilson
Read the RAPL power metrics courtesy of perf. Or your local HW equivalent? v2: uselocale() v3: Use gpu_power_s(), gpu_power_J(), gpu_power_W() to try and make the scale factors self-consistent. v4: Use igt_sysfs Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- lib/Makefile.am | 1 + li

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Sanity check mmap length against object size

2019-03-26 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.0.3, v4.19.30, v4.14.107, v4.9.164, v4.4.176, v3.18.136. v5.0.3: Failed to appl

Re: [Intel-gfx] [PATCH] drm/i915: Sanity check mmap length against object size

2019-03-26 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.0.3, v4.19.30, v4.14.107, v4.9.164, v4.4.176, v3.18.136. v5.0.3: Failed to appl

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 02/24] lib: Add GPU power measurement

2019-03-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-26 08:36:18) > > On 22/03/2019 09:21, Chris Wilson wrote: > > Read the RAPL power metrics courtesy of perf. Or your local HW > > equivalent? > > > > v2: uselocale() > > > > Signed-off-by: Chris Wilson > > --- > > lib/Makefile.am | 1 + > > lib/Makefile.

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 04/24] i915/gem_exec_whisper: Measure total power consumed

2019-03-26 Thread Tvrtko Ursulin
On 22/03/2019 09:21, Chris Wilson wrote: Show the total power consumed across all the whispers. Signed-off-by: Chris Wilson --- tests/i915/gem_exec_whisper.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/i915/gem_exec_whisper.c b/tests/i915/gem_exec_w

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 03/24] i915/gem_exec_schedule: Measure semaphore power consumption

2019-03-26 Thread Tvrtko Ursulin
On 22/03/2019 09:21, Chris Wilson wrote: How much energy does spinning on a semaphore consume relative to plain old spinning? Signed-off-by: Chris Wilson --- tests/i915/gem_exec_schedule.c | 72 +- 1 file changed, 71 insertions(+), 1 deletion(-) diff --git a

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 02/24] lib: Add GPU power measurement

2019-03-26 Thread Tvrtko Ursulin
On 22/03/2019 09:21, Chris Wilson wrote: Read the RAPL power metrics courtesy of perf. Or your local HW equivalent? v2: uselocale() Signed-off-by: Chris Wilson --- lib/Makefile.am | 1 + lib/Makefile.sources | 2 + lib/igt_gpu_power.c | 114 ++

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Introduce concept of a sub-platform

2019-03-26 Thread Jani Nikula
On Tue, 26 Mar 2019, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Concept of a sub-platform already exist in our code (like ULX and ULT > platform variants and similar),implemented via the macros which check a > list of device ids to determine a match. > > With this patch we consolidate devic

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm: connector firmware nodes

2019-03-26 Thread Heikki Krogerus
On Mon, Mar 25, 2019 at 08:57:44PM -, Patchwork wrote: > == Series Details == > > Series: drm: connector firmware nodes > URL : https://patchwork.freedesktop.org/series/58531/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5810_full -> Patchwork_12592_full > =

[Intel-gfx] [PATCH 3/4] drm/i915: Split some PCI ids into separate groups

2019-03-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This will enable the following patch to consolidate most device ids into i915_pciids.h. While cross-referencing the ids listed in i915_drv.h, with the ones listed in i915_pciids.h, and also the comments in the latter, a bug for bug approach was used. This means two things:

[Intel-gfx] [PATCH 4/4] drm/i915: Introduce concept of a sub-platform

2019-03-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Concept of a sub-platform already exist in our code (like ULX and ULT platform variants and similar),implemented via the macros which check a list of device ids to determine a match. With this patch we consolidate device ids checking into a single function called during earl

[Intel-gfx] [PATCH 2/4] drm/i915: Remove redundant device id from IS_IRONLAKE_M macro

2019-03-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin IS_IRONLAKE_M can use the already defined intel_device_info.is_mobile for this platform, so remove the instance of Ironlake's mobile device id from the header file and replace it with an IS_MOBILE check. v2: * Improved commit text. (Chris) v3: * Rebased for EHL. Signed-o

[Intel-gfx] [PATCH 0/4] Device id consolidation

2019-03-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Series removes device id checks from i915_drv.h macros and consolidates them to i915_pciids.h as the main "database", while making intel_device_info.c reference the former, expanding the existing concept of a platform mask by a few low bits reserved for sub-platform mask. Th

[Intel-gfx] [PATCH 1/4] drm/i915: Split Pineview device info into desktop and mobile

2019-03-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This allows the IS_PINEVIEW_ macros to be removed and avoid duplication of device ids already defined in i915_pciids.h. !IS_MOBILE check can be used in place of existing IS_PINEVIEW_G call sites. Signed-off-by: Tvrtko Ursulin Suggested-by: Ville Syrjälä Cc: Ville Syrjälä

Re: [Intel-gfx] [PATCH 2/3] iris: Create a composite context for both compute and render pipelines

2019-03-26 Thread Chris Wilson
Quoting Kenneth Graunke (2019-03-26 05:52:10) > On Monday, March 25, 2019 3:58:59 AM PDT Chris Wilson wrote: > > iris currently uses two distinct GEM contexts to have distinct logical > > HW contexts for the compute and render pipelines. However, using two > > distinct GEM contexts implies that the

<    1   2   3