Re: [Intel-gfx] [PATCH 1/4] drm/i915/dsi: Fix pipe_bpp for handling for 6 bpc pixel-formats

2019-04-04 Thread Saarinen, Jani
Hi, > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Jani > Nikula > Sent: perjantai 5. huhtikuuta 2019 9.35 > To: Hans de Goede ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Ville > Syrjälä > Cc: intel-gfx ; > dri-de...@lists.freedeskto

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev4)

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev4) URL : https://patchwork.freedesktop.org/series/58912/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5877 -> Patchwork_12690 ===

Re: [Intel-gfx] [PATCH 1/4] drm/i915/dsi: Fix pipe_bpp for handling for 6 bpc pixel-formats

2019-04-04 Thread Jani Nikula
On Sat, 01 Dec 2018, Hans de Goede wrote: > There are 3 problems with the dsi code's pipe_bpp handling for 6 bpc > pixel-formats which this commit addresses: > > 1) It assumes that the pipe_bpp is the same as the bpp going over the dsi > lanes. This assumption is not valid for MIPI_DSI_FMT_RGB666,

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Add N & CTS values for 10/12 bit deep color

2019-04-04 Thread Aditya Swarup
On Tue, Apr 02, 2019 at 05:14:40AM -0700, Aditya Swarup wrote: > Adding N & CTS values for 10/12 bit deep color from Appendix C > table in HDMI 2.0 spec. The correct values for N is not chosen > automatically by hardware for deep color modes. > > v2: Remove redundant code and make it generic.(Jani

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-04-04 Thread Stephen Rothwell
Hi Dave, On Fri, 5 Apr 2019 15:55:50 +1100 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > kernel/dma/contiguous.c:19:10: fatal error: asm/dma-contiguous.h: No such > file or directory > #include >

[Intel-gfx] [PATCH v6] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color

2019-04-04 Thread Aditya Swarup
From: Clinton Taylor v2: Fix commit msg to reflect why issue occurs(Jani) Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color. Changing settings from 10/12 bit deep color to 8 bit(& vice versa) doesn't work correctly using xrandr max bpc property. When we connect a monitor which suppo

[Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-04-04 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (powerpc allyesconfig) failed like this: kernel/dma/contiguous.c:19:10: fatal error: asm/dma-contiguous.h: No such file or directory #include ^~ Caused by commit 4f2a8f5898ec ("drm: Add ASPEED G

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Add support for DPLL4 (v2)

2019-04-04 Thread kbuild test robot
Hi Vivek, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20190404] [cannot apply to v5.1-rc3] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [Intel-gfx] [PATCH 3/7] drm/i915/psr: Initialize PSR mutex even when sink is not reliable

2019-04-04 Thread Dhinakaran Pandiyan
On Thu, 2019-04-04 at 17:32 -0700, Souza, Jose wrote: > On Thu, 2019-04-04 at 17:22 -0700, Dhinakaran Pandiyan wrote: > > On Wed, 2019-04-03 at 16:35 -0700, José Roberto de Souza wrote: > > > Even when driver is reloaded and hits this scenario the PSR mutex > > > should be initialized, otherwise re

Re: [Intel-gfx] [PATCH 3/9] drm/i915/ehl: ehl and icl are both gen11

2019-04-04 Thread Lucas De Marchi
On Thu, Mar 14, 2019 at 2:11 PM Souza, Jose wrote: > > Maybe rename the commit message to "drm/i915/ehl: Inherit ICELAKE > conditional code"? > > Also there a few important places that this patch and this series is > missing: > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c > b/drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH 5/7] drm/i915/bdw+: Move misc display IRQ handling to it own function

2019-04-04 Thread Dhinakaran Pandiyan
On Wed, 2019-04-03 at 16:35 -0700, José Roberto de Souza wrote: > Just moving it to reduce the tabs and avoid break code lines. > No behavior changes intended here. > > Signed-off-by: José Roberto de Souza > --- > drivers/gpu/drm/i915/i915_irq.c | 63 +++-- > 1 file c

Re: [Intel-gfx] [PATCH 3/7] drm/i915/psr: Initialize PSR mutex even when sink is not reliable

2019-04-04 Thread Souza, Jose
On Thu, 2019-04-04 at 17:22 -0700, Dhinakaran Pandiyan wrote: > On Wed, 2019-04-03 at 16:35 -0700, José Roberto de Souza wrote: > > Even when driver is reloaded and hits this scenario the PSR mutex > > should be initialized, otherwise reading PSR debugfs status will > > execute mutex_lock() over a

Re: [Intel-gfx] [PATCH 3/7] drm/i915/psr: Initialize PSR mutex even when sink is not reliable

2019-04-04 Thread Dhinakaran Pandiyan
On Wed, 2019-04-03 at 16:35 -0700, José Roberto de Souza wrote: > Even when driver is reloaded and hits this scenario the PSR mutex > should be initialized, otherwise reading PSR debugfs status will > execute mutex_lock() over a mutex that was not initialized. > > Cc: Dhinakaran Pandiyan > Cc: Ro

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/ehl: Add support for DPLL4 (v2)

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Add support for DPLL4 (v2) URL : https://patchwork.freedesktop.org/series/59029/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h CC [M]

[Intel-gfx] ✓ Fi.CI.BAT: success for Trivial comments and small changes

2019-04-04 Thread Patchwork
== Series Details == Series: Trivial comments and small changes URL : https://patchwork.freedesktop.org/series/59027/ State : success == Summary == CI Bug Log - changes from CI_DRM_5875 -> Patchwork_12688 Summary --- **SUCCESS** N

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add "10.6" LUT mode for i965+

2019-04-04 Thread Sripada, Radhakrishna
On Thu, 2019-03-28 at 23:05 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > i965+ have an interpolate 10bit LUT mode. Let's expose that so > that we can actually enjoy real 10bpc. > > Signed-off-by: Ville Syrjälä LGTM Reviewed-by: Radhakrishna Sripada > --- > drivers/gpu/drm/i915/i915_p

[Intel-gfx] [PATCH] drm/i915/ehl: Add support for DPLL4 (v2)

2019-04-04 Thread Vivek Kasireddy
This patch adds support for DPLL4 on EHL that include the following restrictions: - DPLL4 cannot be used with DDIA (combo port A internal eDP usage). DPLL4 can be used with other DDIs, including DDID (combo port A external usage). - DPLL4 cannot be enabled when DC5 or DC6 are enabled. - The

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fixup kerneldoc for intel_cdclk_needs_cd2x_update

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915: Fixup kerneldoc for intel_cdclk_needs_cd2x_update URL : https://patchwork.freedesktop.org/series/58988/ State : success == Summary == CI Bug Log - changes from CI_DRM_5869_full -> Patchwork_12681_full

Re: [Intel-gfx] [PATCH 3/7] drm/i915/psr: Initialize PSR mutex even when sink is not reliable

2019-04-04 Thread Rodrigo Vivi
On Thu, Apr 04, 2019 at 12:25:56PM -0700, Souza, Jose wrote: > On Wed, 2019-04-03 at 17:27 -0700, Rodrigo Vivi wrote: > > On Wed, Apr 03, 2019 at 04:35:35PM -0700, José Roberto de Souza > > wrote: > > > Even when driver is reloaded and hits this scenario the PSR mutex > > > should be initialized, o

[Intel-gfx] [PATCH 1/3] drm/i915/icl: fix step numbers in icl_display_core_init()

2019-04-04 Thread Lucas De Marchi
At some point the spec was changed and we never updated the numbers to match it. Let's try once more to keep them in sync. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_runtime_pm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i91

[Intel-gfx] [PATCH 0/3] Trivial comments and small changes

2019-04-04 Thread Lucas De Marchi
I was fixing a pm thing that ended up not being needed. So, just get the small/trivial changes out. No change in behavior. Lucas De Marchi (3): drm/i915/icl: fix step numbers in icl_display_core_init() drm/i915: reorder if chain to have last gen first drm/i915: do not mix workaround with no

[Intel-gfx] [PATCH 3/3] drm/i915: do not mix workaround with normal flow

2019-04-04 Thread Lucas De Marchi
Separate the two comments: one is a workaround and the other is a sanity check. We could just compare != 1, but let's treat them differently due to having different meaning. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_pm.c | 10 ++ 1 file changed, 6 insertions(+), 4 del

[Intel-gfx] [PATCH 2/3] drm/i915: reorder if chain to have last gen first

2019-04-04 Thread Lucas De Marchi
Reorder if/else so we check for gen >= 11 first, similar to most of other checks in the driver. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_pm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i91

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gvt: Prevent use-after-free in ppgtt_free_all_spt()

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Prevent use-after-free in ppgtt_free_all_spt() URL : https://patchwork.freedesktop.org/series/58985/ State : success == Summary == CI Bug Log - changes from CI_DRM_5869_full -> Patchwork_12680_full

Re: [Intel-gfx] [PATCH 6/7] drm/i915/psr: Remove partial PSR support on multiple transcoders

2019-04-04 Thread Souza, Jose
On Thu, 2019-04-04 at 14:51 -0700, Rodrigo Vivi wrote: > On Thu, Apr 04, 2019 at 02:41:26PM -0700, Pandiyan, Dhinakaran wrote: > > On Thu, 2019-04-04 at 14:20 -0700, Rodrigo Vivi wrote: > > > On Thu, Apr 04, 2019 at 12:40:34PM -0700, Souza, Jose wrote: > > > > On Wed, 2019-04-03 at 17:31 -0700, Rod

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: the great header refactoring, part one

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915: the great header refactoring, part one URL : https://patchwork.freedesktop.org/series/59022/ State : success == Summary == CI Bug Log - changes from CI_DRM_5875 -> Patchwork_12687 Summary --- **

Re: [Intel-gfx] [PATCH 6/7] drm/i915/psr: Remove partial PSR support on multiple transcoders

2019-04-04 Thread Dhinakaran Pandiyan
On Thu, 2019-04-04 at 14:41 -0700, Dhinakaran Pandiyan wrote: > On Thu, 2019-04-04 at 14:20 -0700, Rodrigo Vivi wrote: > > On Thu, Apr 04, 2019 at 12:40:34PM -0700, Souza, Jose wrote: > > > On Wed, 2019-04-03 at 17:31 -0700, Rodrigo Vivi wrote: > > > > On Wed, Apr 03, 2019 at 04:35:38PM -0700, José

Re: [Intel-gfx] [PATCH 4/7] drm/i915/psr: Do not enable PSR in interlaced mode for all GENs

2019-04-04 Thread Dhinakaran Pandiyan
On Wed, 2019-04-03 at 17:29 -0700, Rodrigo Vivi wrote: > On Wed, Apr 03, 2019 at 04:35:36PM -0700, José Roberto de Souza wrote: > > This interlaced restriction applies to all gens, not only to Haswell. > > I believe this came from VLV times and I doubt we would be > impacted by it ever, but better

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: the great header refactoring, part one

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915: the great header refactoring, part one URL : https://patchwork.freedesktop.org/series/59022/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: make intel_frontbuffer.h self-contained -drivers/gpu/drm/i915/s

Re: [Intel-gfx] [PATCH 6/7] drm/i915/psr: Remove partial PSR support on multiple transcoders

2019-04-04 Thread Rodrigo Vivi
On Thu, Apr 04, 2019 at 02:41:26PM -0700, Pandiyan, Dhinakaran wrote: > On Thu, 2019-04-04 at 14:20 -0700, Rodrigo Vivi wrote: > > On Thu, Apr 04, 2019 at 12:40:34PM -0700, Souza, Jose wrote: > > > On Wed, 2019-04-03 at 17:31 -0700, Rodrigo Vivi wrote: > > > > On Wed, Apr 03, 2019 at 04:35:38PM -07

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: the great header refactoring, part one

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915: the great header refactoring, part one URL : https://patchwork.freedesktop.org/series/59022/ State : warning == Summary == $ dim checkpatch origin/drm-tip e3273176ce64 drm/i915: make intel_frontbuffer.h self-contained 9173569bc454 drm/i915: extract intel_

Re: [Intel-gfx] [PATCH 6/7] drm/i915/psr: Remove partial PSR support on multiple transcoders

2019-04-04 Thread Pandiyan, Dhinakaran
On Thu, 2019-04-04 at 14:20 -0700, Rodrigo Vivi wrote: > On Thu, Apr 04, 2019 at 12:40:34PM -0700, Souza, Jose wrote: > > On Wed, 2019-04-03 at 17:31 -0700, Rodrigo Vivi wrote: > > > On Wed, Apr 03, 2019 at 04:35:38PM -0700, José Roberto de Souza > > > wrote: > > > > PSR is only supported in eDP tr

Re: [Intel-gfx] [PATCH 00/25] drm/i915: the great header refactoring, part one

2019-04-04 Thread Chris Wilson
Quoting Jani Nikula (2019-04-04 22:14:24) > intel_drv.h has grown out of proportions, and turned into a dumping > ground. Way back when it was useful to have only a handful of headers, > but we're long past that. > > Start splitting off per-module headers. The basic principles: > > * Make the new

Re: [Intel-gfx] [PATCH 07/25] drm/i915: extract intel_fbc.h from intel_drv.h

2019-04-04 Thread Chris Wilson
Quoting Jani Nikula (2019-04-04 22:14:31) > diff --git a/drivers/gpu/drm/i915/i915_suspend.c > b/drivers/gpu/drm/i915/i915_suspend.c > index d2f2a9c2fabd..eec48d856adb 100644 > --- a/drivers/gpu/drm/i915/i915_suspend.c > +++ b/drivers/gpu/drm/i915/i915_suspend.c > @@ -24,9 +24,12 @@ > * SOFTWARE

Re: [Intel-gfx] [PATCH 03/25] drm/i915: extract intel_crt.h from intel_drv.h

2019-04-04 Thread Jani Nikula
On Fri, 05 Apr 2019, Jani Nikula wrote: > It used to be handy that we only had a couple of headers, but over time > intel_drv.h has become unwieldy. Extract declarations to a separate > header file corresponding to the implementation module, clarifying the > modularity of the dri

Re: [Intel-gfx] [PATCH 6/7] drm/i915/psr: Remove partial PSR support on multiple transcoders

2019-04-04 Thread Rodrigo Vivi
On Thu, Apr 04, 2019 at 12:40:34PM -0700, Souza, Jose wrote: > On Wed, 2019-04-03 at 17:31 -0700, Rodrigo Vivi wrote: > > On Wed, Apr 03, 2019 at 04:35:38PM -0700, José Roberto de Souza > > wrote: > > > PSR is only supported in eDP transcoder and there is only one > > > instance of it, so lets drop

[Intel-gfx] [PATCH 20/25] drm/i915: extract intel_tv.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 11/25] drm/i915: extract intel_sdvo.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 12/25] drm/i915: extract intel_hdcp.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 16/25] drm/i915: extract intel_dp.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 08/25] drm/i915: extract intel_psr.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 14/25] drm/i915: extract intel_pm.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 24/25] drm/i915: extract intel_cdclk.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 23/25] drm/i915: extract intel_sprite.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 25/25] drm/i915/cdclk: have only one init/uninit function

2019-04-04 Thread Jani Nikula
While transitioning to having better clarity between the modules, it's desirable to have the function name prefixes reflect the module. Functions in intel_foo.c should be prefixed intel_foo_. Expose only one CDCLK init/uninit function from intel_cdclk.c instead of one per platform. Obviously this

[Intel-gfx] [PATCH 17/25] drm/i915: extract intel_hdmi.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 09/25] drm/i915: extract intel_color.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 22/25] drm/i915: extract intel_dvo.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 10/25] drm/i915: extract intel_lspcon.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 07/25] drm/i915: extract intel_fbc.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 15/25] drm/i915: extract intel_fbdev.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 19/25] drm/i915: extract intel_pipe_crc.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 13/25] drm/i915: extract intel_panel.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 18/25] drm/i915: extract intel_atomic_plane.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 21/25] drm/i915: extract intel_lvds.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 05/25] drm/i915: extract intel_connector.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 06/25] drm/i915: extract intel_csr.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 04/25] drm/i915: extract intel_ddi.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 03/25] drm/i915: extract intel_crt.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 02/25] drm/i915: extract intel_audio.h from intel_drv.h

2019-04-04 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 00/25] drm/i915: the great header refactoring, part one

2019-04-04 Thread Jani Nikula
intel_drv.h has grown out of proportions, and turned into a dumping ground. Way back when it was useful to have only a handful of headers, but we're long past that. Start splitting off per-module headers. The basic principles: * Make the new headers self-contained (i.e. can be compiled without

[Intel-gfx] [PATCH 01/25] drm/i915: make intel_frontbuffer.h self-contained

2019-04-04 Thread Jani Nikula
This will be helpful in the follow-up work. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/i915_drv.h | 11 ++- drivers/gpu/drm/i915/intel_frontbuffer.h | 10 ++ 3 files changed, 13 insertion

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/i915/gem_madvise.c: Add more mappings

2019-04-04 Thread Patchwork
== Series Details == Series: tests/i915/gem_madvise.c: Add more mappings URL : https://patchwork.freedesktop.org/series/59021/ State : success == Summary == CI Bug Log - changes from CI_DRM_5875 -> IGTPW_2790 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915/psr: Update PSR2 SU corruption workaround comment (rev2)

2019-04-04 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915/psr: Update PSR2 SU corruption workaround comment (rev2) URL : https://patchwork.freedesktop.org/series/58974/ State : success == Summary == CI Bug Log - changes from CI_DRM_5875 -> Patchwork_12686 ==

Re: [Intel-gfx] [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color

2019-04-04 Thread Ville Syrjälä
On Tue, Apr 02, 2019 at 11:22:22PM -0700, Aditya Swarup wrote: > From: Clinton Taylor > > v2: Fix commit msg to reflect why issue occurs(Jani) > Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color. > > Changing settings from 10/12 bit deep color to 8 bit(& vice versa) > doesn't work c

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/7] drm/i915/psr: Update PSR2 SU corruption workaround comment (rev2)

2019-04-04 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915/psr: Update PSR2 SU corruption workaround comment (rev2) URL : https://patchwork.freedesktop.org/series/58974/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/psr: Update PSR2 SU

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915/psr: Update PSR2 SU corruption workaround comment (rev2)

2019-04-04 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915/psr: Update PSR2 SU corruption workaround comment (rev2) URL : https://patchwork.freedesktop.org/series/58974/ State : warning == Summary == $ dim checkpatch origin/drm-tip 73fa7ed439e6 drm/i915/psr: Update PSR2 SU corruption wo

Re: [Intel-gfx] [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color

2019-04-04 Thread Ville Syrjälä
On Tue, Apr 02, 2019 at 11:22:22PM -0700, Aditya Swarup wrote: > From: Clinton Taylor > > v2: Fix commit msg to reflect why issue occurs(Jani) > Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color. > > Changing settings from 10/12 bit deep color to 8 bit(& vice versa) > doesn't work c

[Intel-gfx] [PATCH i-g-t] tests/i915/gem_madvise.c: Add more mappings

2019-04-04 Thread Antonio Argenziano
Check madvise versus more memory mappings. Suggested-by: Chris Wilson Signed-off-by: Antonio Argenziano --- tests/i915/gem_madvise.c | 115 ++- 1 file changed, 76 insertions(+), 39 deletions(-) diff --git a/tests/i915/gem_madvise.c b/tests/i915/gem_madvise.c

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix pipe config timing mismatch warnings

2019-04-04 Thread Ville Syrjälä
On Thu, Apr 04, 2019 at 01:36:25PM +0530, Vandita Kulkarni wrote: > Mipi dsi programs the transcoder timings as part of > encoder enable sequence, with dual link or single link > in consideration. Hence add get transcoder timings as > part of the encoder's get_config function. > > Signed-off-by: V

[Intel-gfx] [PULL] drm-misc-next

2019-04-04 Thread Sean Paul
Hi Da.*, So this one is a blockbuster! We've got 1 new gpu, 1 new display controller, 2 new panels, 4 new ioctls, and 1 new encoder. Everything seems to check out on my side of the world, please pull. drm-misc-next-2019-04-04: drm-misc-next for 5.2: UAPI Changes: -syncobj: Add TIMELINE_WAIT|QU

Re: [Intel-gfx] [PATCH 6/7] drm/i915/psr: Remove partial PSR support on multiple transcoders

2019-04-04 Thread Souza, Jose
On Wed, 2019-04-03 at 17:31 -0700, Rodrigo Vivi wrote: > On Wed, Apr 03, 2019 at 04:35:38PM -0700, José Roberto de Souza > wrote: > > PSR is only supported in eDP transcoder and there is only one > > instance of it, so lets drop all of this code. > > Is this sentence true? I mean, in the way it is

Re: [Intel-gfx] [PATCH 3/7] drm/i915/psr: Initialize PSR mutex even when sink is not reliable

2019-04-04 Thread Souza, Jose
On Wed, 2019-04-03 at 17:27 -0700, Rodrigo Vivi wrote: > On Wed, Apr 03, 2019 at 04:35:35PM -0700, José Roberto de Souza > wrote: > > Even when driver is reloaded and hits this scenario the PSR mutex > > should be initialized, otherwise reading PSR debugfs status will > > execute mutex_lock() over

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: On link train failure on eDP, retry with max params first (rev2)

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915/dp: On link train failure on eDP, retry with max params first (rev2) URL : https://patchwork.freedesktop.org/series/58975/ State : success == Summary == CI Bug Log - changes from CI_DRM_5874 -> Patchwork_12685 =

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: On link train failure on eDP, retry with max params first (rev2)

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915/dp: On link train failure on eDP, retry with max params first (rev2) URL : https://patchwork.freedesktop.org/series/58975/ State : warning == Summary == $ dim checkpatch origin/drm-tip 58de6f859ee4 drm/i915/dp: On link train failure on eDP, retry with max

[Intel-gfx] ✗ Fi.CI.BAT: failure for Fix mipi dsi pipe_config mismatch for icl (rev2)

2019-04-04 Thread Patchwork
== Series Details == Series: Fix mipi dsi pipe_config mismatch for icl (rev2) URL : https://patchwork.freedesktop.org/series/58990/ State : failure == Summary == Applying: drm/i915: Fix pipe config timing mismatch warnings Applying: drm/i915: gen11_dsi_get_pixel_fmt can be static error: sha1 i

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: add Makefile magic for testing headers are self-contained (rev4)

2019-04-04 Thread Jani Nikula
On Thu, 04 Apr 2019, Patchwork wrote: > == Series Details == > > Series: drm/i915: add Makefile magic for testing headers are self-contained > (rev4) > URL : https://patchwork.freedesktop.org/series/58938/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5863_full -> Pat

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix context IDs not released on driver hot unbind URL : https://patchwork.freedesktop.org/series/58996/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5871 -> Patchwork_12683 Summary --

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Expose the legacy LUT via the GAMMA_LUT/GAMMA_LUT_SIZE props on gen2/3

2019-04-04 Thread Sripada, Radhakrishna
On Thu, 2019-03-28 at 23:05 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Just so we don't leave gen2/3 out in the cold let's advertize the > legacy LUT via the GAMMA_LUT/GAMMA_LUT_SIZE props. Without the > GAMMA_LUT prop we can't actually load a LUT using the atomic ioctl > (in preparati

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Be precise in types for i915_gem_busy (rev2)

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915: Be precise in types for i915_gem_busy (rev2) URL : https://patchwork.freedesktop.org/series/58993/ State : success == Summary == CI Bug Log - changes from CI_DRM_5871 -> Patchwork_12682 Summary ---

[Intel-gfx] [PULL] drm-intel-fixes

2019-04-04 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2019-04-04: Only one fix for DSC (backoff after drm_modeset_lock deadlock) and GVT's fixes including vGPU display plane size calculation, shadow mm pin count, error recovery path for workload create and one kerneldoc fix. Thanks, Rodrigo. The follow

[Intel-gfx] [PATCH v2] drm/i915/dp: On link train failure on eDP, retry with max params first

2019-04-04 Thread Manasi Navare
Certain eDP panels fail to link train with optimized settings for link rate and lane count and need the max link parameters to be used for link training to pass. So in on link training failure for eDP, retry the link training with max link parameters first since this tends to fix link failures on m

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix pipe config mismatch for bpp, output format

2019-04-04 Thread kbuild test robot
Hi Vandita, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on v5.1-rc3 next-20190404] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[Intel-gfx] [RFC PATCH] drm/i915: gen11_dsi_get_pixel_fmt can be static

2019-04-04 Thread kbuild test robot
Fixes: bab7d9431d53 ("drm/i915: Fix pipe config mismatch for bpp, output format") Signed-off-by: kbuild test robot --- icl_dsi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/icl_dsi.c b/drivers/gpu/drm/i915/icl_dsi.c index 69cd6b2..163dc54 100644 -

Re: [Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Jani Nikula
On Thu, 04 Apr 2019, Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-04-04 11:50:14) >> On Thu, 2019-04-04 at 11:43 +0100, Chris Wilson wrote: >> > Quoting Janusz Krzysztofik (2019-04-04 11:40:24) >> > > On Thu, 2019-04-04 at 11:28 +0100, Chris Wilson wrote: >> > > > Quoting Janusz Krzyszto

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: add Makefile magic for testing headers are self-contained

2019-04-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: add Makefile magic for testing headers are self-contained URL : https://patchwork.freedesktop.org/series/58963/ State : success == Summary == CI Bug Log - changes from CI_DRM_5865_full -> Patchwork_12676_full ==

Re: [Intel-gfx] [PATCH] drm/i915: Fixup kerneldoc for intel_cdclk_needs_cd2x_update

2019-04-04 Thread Ville Syrjälä
On Thu, Apr 04, 2019 at 08:33:57AM +0100, Chris Wilson wrote: > drivers/gpu/drm/i915/intel_cdclk.c:2116: warning: Function parameter or > member 'dev_priv' not described in 'intel_cdclk_needs_cd2x_update' > > Signed-off-by: Chris Wilson > Cc: Ville Syrjälä > Cc: Abhay Kumar > Cc: Imre Deak R

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: add immutable zpos plane properties (rev2)

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915: add immutable zpos plane properties (rev2) URL : https://patchwork.freedesktop.org/series/58761/ State : success == Summary == CI Bug Log - changes from CI_DRM_5865_full -> Patchwork_12675_full Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: add immutable zpos plane properties (rev2)

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915: add immutable zpos plane properties (rev2) URL : https://patchwork.freedesktop.org/series/58761/ State : success == Summary == CI Bug Log - changes from CI_DRM_5865_full -> Patchwork_12675_full Summary

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Only warn for the first sign of a pagefault

2019-04-04 Thread Tvrtko Ursulin
On 28/03/2019 11:49, Chris Wilson wrote: We only need the warning once, not for the several thousand relocations we try. The current execbuf implementation will set all presumed_offset to -1 so this loop should quit on the first entry if we hit the pagefault, but for the sake of completeness che

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fixup kerneldoc for intel_cdclk_needs_cd2x_update

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915: Fixup kerneldoc for intel_cdclk_needs_cd2x_update URL : https://patchwork.freedesktop.org/series/58988/ State : success == Summary == CI Bug Log - changes from CI_DRM_5869 -> Patchwork_12681 Summary --

Re: [Intel-gfx] [PATCH v2] drm/i915: Be precise in types for i915_gem_busy

2019-04-04 Thread Tvrtko Ursulin
On 04/04/2019 11:19, Chris Wilson wrote: Mixing u8 and -1u together leads to zero-extended integer expansion, and comparing 0x00ff against 0x, causing us to report a mixed uabi-class request as not busy. The input flag is a u8, and we want to generate a u32 uABI response, mark our f

Re: [Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-04-04 11:50:14) > On Thu, 2019-04-04 at 11:43 +0100, Chris Wilson wrote: > > Quoting Janusz Krzysztofik (2019-04-04 11:40:24) > > > On Thu, 2019-04-04 at 11:28 +0100, Chris Wilson wrote: > > > > Quoting Janusz Krzysztofik (2019-04-04 11:24:45) > > > > > From: Janusz

Re: [Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Janusz Krzysztofik
On Thu, 2019-04-04 at 11:43 +0100, Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-04-04 11:40:24) > > On Thu, 2019-04-04 at 11:28 +0100, Chris Wilson wrote: > > > Quoting Janusz Krzysztofik (2019-04-04 11:24:45) > > > > From: Janusz Krzysztofik > > > > > > > > In case the driver gets unbo

Re: [Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-04-04 11:40:24) > On Thu, 2019-04-04 at 11:28 +0100, Chris Wilson wrote: > > Quoting Janusz Krzysztofik (2019-04-04 11:24:45) > > > From: Janusz Krzysztofik > > > > > > In case the driver gets unbound while a device is open, kernel > > > panic > > > may be forced

Re: [Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Janusz Krzysztofik
On Thu, 2019-04-04 at 11:28 +0100, Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-04-04 11:24:45) > > From: Janusz Krzysztofik > > > > In case the driver gets unbound while a device is open, kernel > > panic > > may be forced if a list of allocated context IDs is not empty. > > > > When

Re: [Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-04-04 11:24:45) > From: Janusz Krzysztofik > > In case the driver gets unbound while a device is open, kernel panic > may be forced if a list of allocated context IDs is not empty. > > When a device is open, the list may happen to be not empty because a > context

[Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Janusz Krzysztofik
From: Janusz Krzysztofik In case the driver gets unbound while a device is open, kernel panic may be forced if a list of allocated context IDs is not empty. When a device is open, the list may happen to be not empty because a context ID, once allocated by a context ID allocator to a context asso

[Intel-gfx] [PATCH v2] drm/i915: Be precise in types for i915_gem_busy

2019-04-04 Thread Chris Wilson
Mixing u8 and -1u together leads to zero-extended integer expansion, and comparing 0x00ff against 0x, causing us to report a mixed uabi-class request as not busy. The input flag is a u8, and we want to generate a u32 uABI response, mark our functions so. Fixes: c8b502422bfe ("drm/i915

[Intel-gfx] [PATCH] drm/i915: Be precise in types for i915_gem_busy

2019-04-04 Thread Chris Wilson
Mixing u8 and -1u together leads to zero-extended integer expansion, and comparing 0x00ff against 0x, causing us to report a mixed uabi-class request as not busy. The input flag is a u8, and we want to generate a u32 uABI response, mark our functions so. Fixes: c8b502422bfe ("drm/i915

  1   2   >