On Sat, 2019-06-08 at 13:10 +0800, Paul Wise wrote:
> I've tested these two patches on top of Linux v5.2-rc3 and the EDID
> override works correctly on an Intel Ironlake GPU with a monitor that
> lost its EDID a while ago.
While testing I noticed a couple of things:
While everything the GUI is
On Fri, 2019-06-07 at 17:10 +0200, Daniel Vetter wrote:
> As discussed on irc, we need tested-by here from the reporters since
> there's way too many losing and frustrangingly few winning moves here.
Tested-by: Paul Wise
I've tested these two patches on top of Linux v5.2-rc3 and the EDID
On Fri, 2019-06-07 at 17:10 +0200, Daniel Vetter wrote:
> As discussed on irc, we need tested-by here from the reporters since
> there's way too many losing and frustrangingly few winning moves here.
I'm building it now, hopefully will be done today.
--
bye,
pabs
https://bonedaddy.net/pabs3/
== Series Details ==
Series: drm/i915/ehl: Add support for DPLL4 (v5) (rev2)
URL : https://patchwork.freedesktop.org/series/61684/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6222 -> Patchwork_13210
Summary
---
On Fri, 2019-06-07 at 17:13 -0700, José Roberto de Souza wrote:
> On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> > Lane reversal happens only in the FIA module for TBT-alt/DP-alt
> > mode,
> > so
> > WARN if lane reversal is attempted at a different level. See the
> > BSpec DDI_BUF_CTL
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> Disconnecting the TypeC PHY when the port is in legacy mode is not
> necessary:
> - BSpec doesn't specify a disconnect sequence for legacy mode.
> - The use of the PHY is dedicated for the display in legacy mode.
> - We keep the PHY always
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> Lane reversal happens only in the FIA module for TBT-alt/DP-alt mode,
> so
> WARN if lane reversal is attempted at a different level. See the
> BSpec DDI_BUF_CTL register description.
Reviewed-by: José Roberto de Souza
>
> Cc: Manasi Navare
This patch adds support for DPLL4 on EHL that include the
following restrictions:
- DPLL4 cannot be used with DDIA (combo port A internal eDP usage).
DPLL4 can be used with other DDIs, including DDID
(combo port A external usage).
- DPLL4 cannot be enabled when DC5 or DC6 are enabled.
- The
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> Use hex numbers, since that makes more sense when decoding a bit
> pattern.
>
> No functional change.
Reviewed-by: José Roberto de Souza
>
> Suggested-by: Ville Syrjälä
> Cc: Animesh Manna
> Cc: Ville Syrjälä
> Signed-off-by: Imre Deak
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> For using the correct AUX power domains we have to sanitize the TypeC
> port mode early, so move that before encoder sanitization. To do this
> properly read out the actual port mode instead of just relying on the
> VBT legacy port flag (which
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> Make the order during detection more consistent: first reset the
> TypeC
> port mode if needed (adding new helpers for this), then detect any
> connected sink.
>
> To check if a port mode reset is needed determine first the target
> port
>
== Series Details ==
Series: drm/i915/icl: Enable SSC for ICL using panel_use_ssc
URL : https://patchwork.freedesktop.org/series/61692/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6199_full -> Patchwork_13186_full
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> Based on a recent BSpec update (Index/21750) we must handle the
> TCCOLD
> event associated with the DP-alt mode. We can detect this event by
> reading an invalid all-1s value from FIA registers.
>
> After detecting TCCOLD we will:
> - fall
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> The PHY satus complete flag normally clears when disconnecting the
s/satus/status
> PHY
> in DP-alt mode (achieved by switching to safe mode), so wait for the
> flag to clear.
>
> Cc: José Roberto de Souza
> Cc: Rodrigo Vivi
>
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> Factor out helpers reading/parsing the TypeC specific registers,
> making
> current users of them clearer and letting us use them later.
>
> While at it also:
> - Simplify icl_tc_phy_connect() with an early return in legacy mode.
> - Simplify
On Tue, 2019-06-04 at 23:16 +0300, Ville Syrjälä wrote:
> On Tue, Jun 04, 2019 at 12:44:48PM -0700, Manasi Navare wrote:
> > On Tue, Jun 04, 2019 at 03:51:58PM +0300, Ville Syrjälä wrote:
> > > On Mon, Jun 03, 2019 at 02:49:40PM -0700,
> > > matthew.s.atw...@intel.com wrote:
> > > > From: Matt
On Fri, Jun 07, 2019 at 11:42:31PM +0300, Imre Deak wrote:
> On Fri, Jun 07, 2019 at 11:21:51PM +0300, Souza, Jose wrote:
> > On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> > > Unify the TypeC port notation in log messages, so that it matches the
> > > spec. For instance the first ICL TypeC
On Fri, 2019-06-07 at 23:42 +0300, Imre Deak wrote:
> On Fri, Jun 07, 2019 at 11:21:51PM +0300, Souza, Jose wrote:
> > On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> > > Unify the TypeC port notation in log messages, so that it matches
> > > the
> > > spec. For instance the first ICL TypeC
On Fri, Jun 07, 2019 at 11:21:51PM +0300, Souza, Jose wrote:
> On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> > Unify the TypeC port notation in log messages, so that it matches the
> > spec. For instance the first ICL TypeC port will read as 'Port
> > C/TC#1'.
> >
> > Cc: José Roberto de
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> Unify the TypeC port notation in log messages, so that it matches the
> spec. For instance the first ICL TypeC port will read as 'Port
> C/TC#1'.
>
> Cc: José Roberto de Souza
> Cc: Rodrigo Vivi
> Cc: Paulo Zanoni
> Signed-off-by: Imre Deak
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> In the TypeC TBT-alt port mode we must use the TBT AUX power domain,
> fix that.
>
> Cc: Manasi Navare
> Cc: Anusha Srivatsa
> Signed-off-by: Imre Deak
> ---
> drivers/gpu/drm/i915/intel_display.c | 19 +++
> 1 file
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> Fix the mapping from a TBT AUX power well index to the DP_AUX_CH_CTL
> register.
>
> Fixes: c7375d9542f1 ("drm/i915: Configure AUX_CH_CTL when enabling
> the AUX power domain")
> Cc: José Roberto de Souza
> Cc: Rodrigo Vivi
> Signed-off-by:
== Series Details ==
Series: drm/i915/ehl: Support HBR3 on EHL combo PHY
URL : https://patchwork.freedesktop.org/series/61690/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6198_full -> Patchwork_13185_full
Summary
---
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> According to the spec we should not enable the DDI-IO power domain if
> the TypeC port is in the TBT-alt mode, so do that only in the other
> TypeC modes or for non-TypeC ports.
With:
BSpec: 22243
Reviewed-by: José Roberto de Souza
>
> Cc:
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> The TypeC port mode can switch dynamically, to reflect that better
> call
> the port's mode as 'mode' rather than 'type'.
>
> While at it:
> - s/TC_PORT_TBT/TC_PORT_TBT_ALT/ and s/TC_PORT_TYPEC/TC_PORT_DP_ALT/.
> 'TYPEC' is ambiguous,
On Fri, Jun 07, 2019 at 07:26:11PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Respect the user's choice of depth/bpp for the fbdev framebuffer
> and throw out the fb we inherited from the BIOS if it doesn't
> match.
>
> Signed-off-by: Ville Syrjälä
I guess we're going boom right
On Fri, Jun 07, 2019 at 07:26:10PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> i915 will now refuse to enable a C8 plane unless the gamma_lut
> is already enabled (to avoid scanning out whatever garbage got
> left in the hw LUT previously). So in order to make the fbdev
> code work
== Series Details ==
Series: drm/i915: Fix TypeC port mode switching (rev2)
URL : https://patchwork.freedesktop.org/series/61590/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6221 -> Patchwork_13209
Summary
---
On Fri, Jun 07, 2019 at 07:26:09PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> If the user specifies zero width/height cmdline mode i915 will
> blow up as the fbdev path will bypass the regular fb sanity
> check that would otherwise have refused to create a framebuffer
> with zero
On Fri, Jun 07, 2019 at 07:26:08PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> drm_mode_create_from_cmdline_mode() can return NULL, so the caller
> should check for that.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Daniel Vetter
Aside I noticed that we can drop a few
== Series Details ==
Series: drm/i915: Fix TypeC port mode switching (rev2)
URL : https://patchwork.freedesktop.org/series/61590/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/icl: Add support to read out the TBT PLL HW state
Okay!
Commit:
== Series Details ==
Series: drm/i915: Fix TypeC port mode switching (rev2)
URL : https://patchwork.freedesktop.org/series/61590/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
429dfd1e1b32 drm/i915/icl: Add support to read out the TBT PLL HW state
8ceef23351d2 drm/i915: Tune
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> Move the TypeC port handling functions to a new file for clarity.
>
> While at it:
> - s/icl_tc_port_connected()/intel_tc_port_connected()/
> icl_tc_phy_disconnect(), will be unexported later.
>
> -
>
== Series Details ==
Series: series starting with [1/4] drm/fb-helper: Do not assume
drm_mode_create_from_cmdline_mode() can't fail
URL : https://patchwork.freedesktop.org/series/61781/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6221 -> Patchwork_13208
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> The HW completion flag for the TBT AUX power well enabling/disabling
> gets stuck if the firmware tears down the TBT DP tunnel before the
> completion.
>
> We shouldn't complain about the timeout, since it's expected to
> happen
> and doesn't
When enabling a TypeC port we need to reserve all the required PLLs for
it, the TBT PLL for TBT-alt and the MG PHY PLL for DP-alt/legacy sinks.
We can select the proper PLL for the current port mode from the reserved
PLLs only once we selected and locked down the port mode for the whole
duration
On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote:
> Add support to read out the TBT PLL HW state.
Reviewed-by: José Roberto de Souza
>
> Cc: Vandita Kulkarni
> Cc: Paulo Zanoni
> Cc: Lucas De Marchi
> Signed-off-by: Imre Deak
> ---
> drivers/gpu/drm/i915/intel_display.c | 11 +--
== Series Details ==
Series: series starting with [1/4] drm/fb-helper: Do not assume
drm_mode_create_from_cmdline_mode() can't fail
URL : https://patchwork.freedesktop.org/series/61781/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
33c52564377d drm/fb-helper: Do not assume
From: Ville Syrjälä
drm_mode_create_from_cmdline_mode() can return NULL, so the caller
should check for that.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_fb_helper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c
From: Ville Syrjälä
i915 will now refuse to enable a C8 plane unless the gamma_lut
is already enabled (to avoid scanning out whatever garbage got
left in the hw LUT previously). So in order to make the fbdev
code work with C8 we need to program the gamma_lut already
during
From: Ville Syrjälä
Respect the user's choice of depth/bpp for the fbdev framebuffer
and throw out the fb we inherited from the BIOS if it doesn't
match.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_fbdev.c | 11 +++
1 file changed, 11 insertions(+)
diff --git
From: Ville Syrjälä
If the user specifies zero width/height cmdline mode i915 will
blow up as the fbdev path will bypass the regular fb sanity
check that would otherwise have refused to create a framebuffer
with zero width/height.
The reason I thought to try this is so that I can force a
== Series Details ==
Series: drm/crc-debugfs: User irqsafe spinlock in drm_crtc_add_crc_entry
URL : https://patchwork.freedesktop.org/series/61687/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6197_full -> Patchwork_13184_full
== Series Details ==
Series: series starting with [1/6] dma-buf: add dynamic DMA-buf handling v9
URL : https://patchwork.freedesktop.org/series/61774/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6221 -> Patchwork_13207
== Series Details ==
Series: series starting with [1/6] dma-buf: add dynamic DMA-buf handling v9
URL : https://patchwork.freedesktop.org/series/61774/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: dma-buf: add dynamic DMA-buf handling v9
Okay!
== Series Details ==
Series: series starting with [1/6] dma-buf: add dynamic DMA-buf handling v9
URL : https://patchwork.freedesktop.org/series/61774/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a7793d675adb dma-buf: add dynamic DMA-buf handling v9
-:11:
On Fri, Jun 07, 2019 at 02:05:13PM +0300, Jani Nikula wrote:
> We've moved the override and firmware EDID (simply "override EDID" from
> now on) handling to the low level drm_do_get_edid() function in order to
> transparently use the override throughout the stack. The idea is that
> you get the
== Series Details ==
Series: Legacy mmio accessor macro pruning
URL : https://patchwork.freedesktop.org/series/61772/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6220 -> Patchwork_13206
Summary
---
**SUCCESS**
== Series Details ==
Series: drm/i915: Move i915_check_and_clear_faults to intel_reset.c
URL : https://patchwork.freedesktop.org/series/61771/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6220 -> Patchwork_13205
Summary
On Fri, Jun 07, 2019 at 01:14:57PM +0200, Benjamin Gaignard wrote:
> Le ven. 7 juin 2019 à 12:07, Emil Velikov a écrit :
> >
> > On Thu, 6 Jun 2019 at 22:15, Daniel Vetter wrote:
> > >
> > > I. was. blind.
> > >
> > > Caught with vkms, which has some really slow crc computation function.
> > >
>
On Thu, 2019-06-06 at 15:42 -0700, Daniele Ceraolo Spurio wrote:
> The size has been increased to 2MB starting from Gen11. GuC and HuC
> FWs
> fit in 1MB so we were fine even with the legacy define, but let's
> still
> move to the correct one before the blobs grow to avoid being caught
> off
>
On Fri, Jun 7, 2019 at 12:07 PM Bartlomiej Zolnierkiewicz
wrote:
>
>
> On 6/6/19 9:38 AM, Daniel Vetter wrote:
> > Hi Bart,
>
> Hi Daniel,
>
> > On Tue, May 28, 2019 at 11:02:31AM +0200, Daniel Vetter wrote:
> >> Hi all,
> >>
> >> I think we're slowly getting there. Previous cover letters with
== Series Details ==
Series: Legacy mmio accessor macro pruning
URL : https://patchwork.freedesktop.org/series/61772/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
043c61153db4 drm/i915: Eliminate unused mmio accessors
103768ba0c26 drm/i915: Convert i915_reg_read_ioctl to use
== Series Details ==
Series: drm/i915: Move i915_check_and_clear_faults to intel_reset.c
URL : https://patchwork.freedesktop.org/series/61771/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Move i915_check_and_clear_faults to intel_reset.c
On Tue, Jun 04, 2019 at 12:36:46PM -0700, Manasi Navare wrote:
> On Tue, Jun 04, 2019 at 05:02:14PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > intel_dp_link_down() is static and it's only called from the pre-ddi
> > DP functions, so having a WARN_ON(HAS_DDI) in there is quite
On Fri, Jun 07, 2019 at 10:03:17AM +0200, Heinrich Fink wrote:
> On Mon, 3 Jun 2019 at 16:25, Ville Syrjala
> wrote:
> >
> > From: Ville Syrjälä
> >
> > We forgot to set .has_alpha=true for the A+CCS formats when the code
> > started to consult .has_alpha. This manifests as A+CCS being treated
>
On Fri, 07 Jun 2019, Tvrtko Ursulin wrote:
> On 07/06/2019 14:11, Jani Nikula wrote:
>> On Fri, 07 Jun 2019, Tvrtko Ursulin wrote:
>>> From: Tvrtko Ursulin
>>>
>>> Only a few call sites remain which have been converted to uncore mmio
>>> accessors and so the macro can be removed.
>>>
>>>
On Thu, 06 Jun 2019, Daniele Ceraolo Spurio
wrote:
> uncore_sanitize performs no action on the uncore structure and just
> calls intel_sanitize_gt_powersave, so we can just call the latter
> directly.
>
> Signed-off-by: Daniele Ceraolo Spurio
Reviewed-by: Jani Nikula
> ---
>
On 07/06/2019 14:11, Jani Nikula wrote:
On Fri, 07 Jun 2019, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Only a few call sites remain which have been converted to uncore mmio
accessors and so the macro can be removed.
Signed-off-by: Tvrtko Ursulin
I have some reservations about this one
== Series Details ==
Series: drm/i915: Grammar s/the its/its/
URL : https://patchwork.freedesktop.org/series/61768/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6217 -> Patchwork_13204
Summary
---
**SUCCESS**
No
== Series Details ==
Series: series starting with [1/3] drm/i915/dsi: Move logging of DSI VBT
parameters to a helper function
URL : https://patchwork.freedesktop.org/series/61679/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6196_full -> Patchwork_13182_full
On Fri, 07 Jun 2019, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Only a few call sites remain which have been converted to uncore mmio
> accessors and so the macro can be removed.
>
> Signed-off-by: Tvrtko Ursulin
I have some reservations about this one and patch 11. Again, I'm fine
with
On Fri, 07 Jun 2019, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Remove call sites in favour of uncore mmio accessors and remove the old
> macros.
>
> Signed-off-by: Tvrtko Ursulin
This patch really starts to show the ugly side of switching to
intel_uncore_* functions, with one-liners
On the exporter side we add optional explicit pinning callbacks. If those
callbacks are implemented the framework no longer caches sg tables and the
map/unmap callbacks are always called with the lock of the reservation object
held.
On the importer side we add an optional invalidate callback.
Avoid that we ping/pong the buffers when we stop to pin DMA-buf
exports by using the allowed domains for exported buffers.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
The caching of SGT's is actually quite harmful and should probably removed
altogether when all drivers are audited.
Start by providing a separate DMA-buf export implementation in amdgpu. This is
also a prerequisite of unpinned DMA-buf handling.
v2: fix unintended recursion, remove debugging
Instead of relying on the DRM functions just implement our own import
functions. This prepares support for taking care of unpinned DMA-buf.
v2: enable for all exporters, not just amdgpu, fix invalidation
handling, lock reservation object while setting callback
v3: change to new dma_buf attach
Pipeline removal of the BOs backing store when no placement is given
during validation.
Signed-off-by: Christian König
---
drivers/gpu/drm/ttm/ttm_bo.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index
This way we can even pipeline imported BO evictions.
v2: Limit this to only cases when the parent object uses a separate reservation
object as well. This fixes another OOM problem.
Signed-off-by: Christian König
---
drivers/gpu/drm/ttm/ttm_bo_util.c | 20 +++-
1 file
On Fri, 07 Jun 2019, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Only a few call sites remain which have been converted to uncore mmio
> accessors and so the macro can be removed.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/i915_drv.h| 1
== Series Details ==
Series: drm/i915: Grammar s/the its/its/
URL : https://patchwork.freedesktop.org/series/61768/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
fd7e4a2e6acc drm/i915: Grammar s/the its/its/
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an
On Fri, 07 Jun 2019, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Only a few call sites remain which have been converted to uncore mmio
> accessors and so the macro can be removed.
>
> ENGINE_POSTING_READ16 is added to replace one engine->mmio_base relative
> call site.
>
> Signed-off-by:
On Fri, 07 Jun 2019, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Only a few call sites remain which have been converted to uncore mmio
> accessors and so the macro can be removed.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/i915_drv.h
On Fri, 07 Jun 2019, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Now that all their users are gone we can remove the macros and
> accompanying duplicated comment.
>
> Signed-off-by: Tvrtko Ursulin
> Suggested-by: Jani Nikula
On patches 1-6,
Reviewed-by: Jani Nikula
> ---
>
On Thu, Jun 06, 2019 at 08:49:19PM -0700, Lucas De Marchi wrote:
> Spec shows voltage level 0 as 307.2, 312, or lower and suggests to use
> range checks. Prepare for having other frequencies in these ranges by
> not comparing the exact frequency.
>
> Signed-off-by: Lucas De Marchi
> ---
>
Quoting Tvrtko Ursulin (2019-06-07 12:59:32)
> From: Tvrtko Ursulin
>
> The code is logically about reset so it makes sense.
>
> It also enables making i915_clear_error_registers static.
>
> Signed-off-by: Tvrtko Ursulin
> Suggested-by: Chris Wilson
Yup, looks like a step in the right
From: Tvrtko Ursulin
Remove call sites in favour of uncore mmio accessors and remove the old
macros.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/gt/intel_ringbuffer.c | 6 +-
drivers/gpu/drm/i915/i915_debugfs.c| 37
drivers/gpu/drm/i915/i915_drv.h|
From: Tvrtko Ursulin
More implicit dev_priv removal.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/intel_pm.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 8f82cb72d3a6..d7272d4ff258
From: Tvrtko Ursulin
Only a few call sites remain which have been converted to uncore mmio
accessors and so the macro can be removed.
ENGINE_POSTING_READ16 is added to replace one engine->mmio_base relative
call site.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/gt/intel_engine.h
From: Tvrtko Ursulin
More implicit dev_priv removal.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_gpu_error.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c
b/drivers/gpu/drm/i915/i915_gpu_error.c
index
From: Tvrtko Ursulin
Only a few call sites remain which have been converted to uncore mmio
accessors and so the macro can be removed.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/gvt/debugfs.c | 4 +--
drivers/gpu/drm/i915/gvt/firmware.c | 5 ++--
drivers/gpu/drm/i915/i915_drv.c
From: Tvrtko Ursulin
Only a few call sites remain which have been converted to uncore mmio
accessors and so the macro can be removed.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 1 -
drivers/gpu/drm/i915/i915_gem.c | 9 +++---
== Series Details ==
Series: series starting with [1/2] drm/edid: abstract override/firmware EDID
retrieval
URL : https://patchwork.freedesktop.org/series/61764/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6216 -> Patchwork_13203
From: Tvrtko Ursulin
Only a few call sites remain which have been converted to uncore mmio
accessors and so the macro can be removed.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 2 --
drivers/gpu/drm/i915/intel_crt.c | 41 ++--
From: Tvrtko Ursulin
Now that all their users are gone we can remove the macros and
accompanying duplicated comment.
Signed-off-by: Tvrtko Ursulin
Suggested-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 18 --
1 file changed, 18 deletions(-)
diff --git
From: Tvrtko Ursulin
Only a few call sites remain which have been converted to uncore mmio
accessors and so the macro can be removed.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h| 1 -
drivers/gpu/drm/i915/intel_gmbus.c | 42 +++---
2 files
From: Tvrtko Ursulin
More removal of implicit dev_priv.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
From: Tvrtko Ursulin
No excuse for code located in intel_uncore.c to not use intel_uncore_
helpers.
Signed-off-by: Tvrtko Ursulin
Suggested-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_uncore.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git
From: Tvrtko Ursulin
Since we want to stop using the legacy mmio accessors (the ones which create a
hidden dependency to having a dev_priv local) this series removes all of the
more exotic ones by converting the call sites to use the new uncore accessors.
The ones left are only the standard
From: Tvrtko Ursulin
On the path of removing mmio accessors with implicit dev_priv, easy first
step is to remove all such unused macros.
Signed-off-by: Tvrtko Ursulin
Suggested-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 4
1 file changed, 4 deletions(-)
diff --git
From: Tvrtko Ursulin
The code is logically about reset so it makes sense.
It also enables making i915_clear_error_registers static.
Signed-off-by: Tvrtko Ursulin
Suggested-by: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_reset.c | 69 +--
From: Janusz Krzysztofik
There is a test which verifies unloading of i915 driver module but no test
exists that checks how a driver behaves when it gets unbound from a device
or when the device gets unplugged. Provide such test using sysfs
interface.
Two minimalistic subtests - "unbind-rebind"
The test should help resolving driver bugs which exhibit themselves
when a device is unplugged / driver unbind from a device while the
device is busy (different from simple module unload which requires
device references being put first).
A kernel patch resolving kernel panics on driver hot
== Series Details ==
Series: series starting with [1/2] drm/edid: abstract override/firmware EDID
retrieval
URL : https://patchwork.freedesktop.org/series/61764/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
b8887b8817bc drm/edid: abstract override/firmware EDID retrieval
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/i915/intel_dpll_mgr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.h
b/drivers/gpu/drm/i915/intel_dpll_mgr.h
index 8835dd20f1d27e05..79a53c5439a8e6db 100644
---
Quoting Matthew Auld (2019-06-07 12:02:45)
> On Mon, 3 Jun 2019 at 18:49, Chris Wilson wrote:
> >
> > Keeping the _hw_ in there does not help to distinguish it from its
> > brethren i915_ggtt, so drop it.
> >
> > Signed-off-by: Chris Wilson
> > ---
> >
Le ven. 7 juin 2019 à 12:07, Emil Velikov a écrit :
>
> On Thu, 6 Jun 2019 at 22:15, Daniel Vetter wrote:
> >
> > I. was. blind.
> >
> > Caught with vkms, which has some really slow crc computation function.
> >
> > Fixes: 1882018a70e0 ("drm/crc-debugfs: User irqsafe spinlock in
> >
== Series Details ==
Series: series starting with [CI,1/5] drm/i915: Reset only affected engines
when handling error capture (rev3)
URL : https://patchwork.freedesktop.org/series/61758/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6216 -> Patchwork_13202
On Mon, 3 Jun 2019 at 18:49, Chris Wilson wrote:
>
> Keeping the _hw_ in there does not help to distinguish it from its
> brethren i915_ggtt, so drop it.
>
> Signed-off-by: Chris Wilson
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.c | 8 +-
> .../gpu/drm/i915/gem/selftests/huge_pages.c
We've moved the override and firmware EDID (simply "override EDID" from
now on) handling to the low level drm_do_get_edid() function in order to
transparently use the override throughout the stack. The idea is that
you get the override EDID via the ->get_modes() hook.
Unfortunately, there are
1 - 100 of 139 matches
Mail list logo
