[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Refine eDP aux backlight enable/disable sequence

2019-06-20 Thread Patchwork
== Series Details == Series: drm/i915: Refine eDP aux backlight enable/disable sequence URL : https://patchwork.freedesktop.org/series/62494/ State : success == Summary == CI Bug Log - changes from CI_DRM_6319 -> Patchwork_13380 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for EHL port programming

2019-06-20 Thread Patchwork
== Series Details == Series: EHL port programming URL : https://patchwork.freedesktop.org/series/62492/ State : success == Summary == CI Bug Log - changes from CI_DRM_6319 -> Patchwork_13379 Summary --- **SUCCESS** No regressions

[Intel-gfx] [PATCH] drm/i915: Refine eDP aux backlight enable/disable sequence

2019-06-20 Thread Lee Shawn C
Modify aux backlight enable/disable sequence just like what we did for genernal eDP panel. 1. Setup PWM freq and brightness level before enable display backlight. 2. Set PWM to 0 after backlight enable was off. Cc: Ville Syrjälä Cc: Jani Nikula Cc: Jose Roberto de Souza Cc: Cooper Chiou Signe

Re: [Intel-gfx] [PATCH v2] drm/i915: Refine eDP aux backlight enable/disable sequence

2019-06-20 Thread Lee, Shawn C
On Fri, 21 Jun 2019, Lee Shawn C wrote: > >Modify aux backlight enable/disable sequence just like what we did for >genernal eDP panel. >1. Setup PWM freq and brightness level before enable display backlight. >2. Set PWM to 0 after backlight enable was off. > >v2: Code structure was changed. Modif

[Intel-gfx] [PATCH v2] drm/i915: Refine eDP aux backlight enable/disable sequence

2019-06-20 Thread Lee Shawn C
Modify aux backlight enable/disable sequence just like what we did for genernal eDP panel. 1. Setup PWM freq and brightness level before enable display backlight. 2. Set PWM to 0 after backlight enable was off. v2: Code structure was changed. Modify this patch to align the latest. Cc: Ville Syrjä

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for EHL port programming

2019-06-20 Thread Patchwork
== Series Details == Series: EHL port programming URL : https://patchwork.freedesktop.org/series/62492/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/icl: Drop port parameter to icl_get_combo_buf_trans() Okay! Commit: drm/i915/ehl: Add third

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for EHL port programming

2019-06-20 Thread Patchwork
== Series Details == Series: EHL port programming URL : https://patchwork.freedesktop.org/series/62492/ State : warning == Summary == $ dim checkpatch origin/drm-tip e8826f32a876 drm/i915/icl: Drop port parameter to icl_get_combo_buf_trans() -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapp

[Intel-gfx] [PATCH 5/5] drm/i915/ehl: Enable DDI-D

2019-06-20 Thread Matt Roper
EHL has four DDI's (DDI-A and DDI-D share combo PHY A). Cc: José Roberto de Souza Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_dis

[Intel-gfx] [PATCH 0/5] EHL port programming

2019-06-20 Thread Matt Roper
EHL is a bit unique because it's the only platform where multiple DDI's can share the same PHY. This makes some of the output programming a bit confusing given that we tend to use the term 'port' today when talking about both DDI's and PHY's. The fourth patch here starts to try to separate those

[Intel-gfx] [PATCH 1/5] drm/i915/icl: Drop port parameter to icl_get_combo_buf_trans()

2019-06-20 Thread Matt Roper
The port parameter hasn't been used since the last bspec phy programming update. Drop it to make some upcoming changes simpler. References: 9659c1af451a ("drm/i915/icl: combo port vswing programming changes per BSPEC") Cc: Clint Taylor Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/displa

[Intel-gfx] [PATCH 2/5] drm/i915/ehl: Add third combo PHY offset

2019-06-20 Thread Matt Roper
Cc: José Roberto de Souza Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_reg.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 7e6009cefb18..7e748bb3f324 100644 --- a/drivers/gpu/drm/i915/i915

[Intel-gfx] [PATCH 3/5] drm/i915/ehl: Don't program PHY_MISC on EHL PHY C

2019-06-20 Thread Matt Roper
Although EHL added a third combo PHY, no PHY_MISC register was added for PHY C. The bspec indicates that there's no need to program the "DE to IO Comp Pwr Down" setting for this PHY that we usually need to set in PHY_MISC. Bspec: 33148 Cc: José Roberto de Souza Signed-off-by: Matt Roper --- ..

[Intel-gfx] [PATCH 4/5] drm/i915/gen11: Start distinguishing 'phy' from 'port'

2019-06-20 Thread Matt Roper
Our past DDI-based Intel platforms have had a fixed DDI<->PHY mapping. Because of this, both the bspec documentation and our i915 code has used the term "port" when talking about either DDI's or PHY's; it was always easy to tell what terms like "Port A" were referring to from the context. Unfortun

Re: [Intel-gfx] [PATCH 3/5] drm/panel: Add attach/detach callbacks

2019-06-20 Thread dbasehore .
If we want to query the device tree outside of the panel code in helper functions, we can do this with the struct as is. There's already a device struct pointer in drm_panel, so I think we can pull from that. On Tue, Jun 11, 2019 at 5:25 PM dbasehore . wrote: > > On Tue, Jun 11, 2019 at 1:57 AM D

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915/icl: Add new supported CD clocks

2019-06-20 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915/icl: Add new supported CD clocks URL : https://patchwork.freedesktop.org/series/62490/ State : success == Summary == CI Bug Log - changes from CI_DRM_6318 -> Patchwork_13378

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/3] drm/i915/icl: Add new supported CD clocks

2019-06-20 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915/icl: Add new supported CD clocks URL : https://patchwork.freedesktop.org/series/62490/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/icl: Add new supported CD clocks Okay! C

[Intel-gfx] [PATCH v2 3/3] drm/i915/ehl: Add voltage level requirement table

2019-06-20 Thread José Roberto de Souza
EHL has it own voltage level requirement depending on cd clock. BSpec: 21809 Cc: Clint Taylor Cc: Matt Roper Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_cdclk.c | 35 ++ 1 file changed, 23 insertions(+), 12 deletions(-) di

[Intel-gfx] [PATCH v2 1/3] drm/i915/icl: Add new supported CD clocks

2019-06-20 Thread José Roberto de Souza
Now 180, 172.8 and 192 MHz are supported. 180 and 172.8 MHz CD clocks will only be used when audio is not enabled as state by BSpec and implemented in intel_crtc_compute_min_cdclk(), CD clock must be at least twice of Azalia BCLK and BCLK by default is 96 MHz, it could be set to 48 MHz but we are

[Intel-gfx] [PATCH v2 2/3] drm/i915/ehl: Remove unsupported cd clocks

2019-06-20 Thread José Roberto de Souza
EHL do not support 648 and 652.8 MHz. v2: - Limiting maximum CD clock by max_cdclk_freq instead of remove it from icl_calc_cdclk()(Ville and Jani) BSpec: 20598 Cc: Clint Taylor Cc: Matt Roper Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/dis

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Aspect ratio fixes

2019-06-20 Thread Patchwork
== Series Details == Series: drm: Aspect ratio fixes URL : https://patchwork.freedesktop.org/series/62462/ State : success == Summary == CI Bug Log - changes from CI_DRM_6314_full -> Patchwork_13368_full Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.BAT: failure for Split hw and drm state.

2019-06-20 Thread Patchwork
== Series Details == Series: Split hw and drm state. URL : https://patchwork.freedesktop.org/series/62485/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6318 -> Patchwork_13377 Summary --- **FAILURE** Serious unkn

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Split hw and drm state.

2019-06-20 Thread Patchwork
== Series Details == Series: Split hw and drm state. URL : https://patchwork.freedesktop.org/series/62485/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Pass intel_crtc_state to needs_modeset() Okay! Commit: drm/i915: Convert most of atomic

Re: [Intel-gfx] [PATCH 1/3] drm/i915/icl: Add new supported CD clocks

2019-06-20 Thread Souza, Jose
On Wed, 2019-06-19 at 20:47 +0300, Ville Syrjälä wrote: > On Tue, Jun 18, 2019 at 03:50:33PM -0700, José Roberto de Souza > wrote: > > Now 180, 172.8 and 192 MHz are supported. > > > > 180 and 172.8 MHz CD clocks will only be used when audio is not > > enabled as state by BSpec and implemented in

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915/execlists: Preempt-to-busy

2019-06-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/execlists: Preempt-to-busy URL : https://patchwork.freedesktop.org/series/62461/ State : success == Summary == CI Bug Log - changes from CI_DRM_6314_full -> Patchwork_13367_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Split hw and drm state.

2019-06-20 Thread Patchwork
== Series Details == Series: Split hw and drm state. URL : https://patchwork.freedesktop.org/series/62485/ State : warning == Summary == $ dim checkpatch origin/drm-tip 43159ab9270f drm/i915: Pass intel_crtc_state to needs_modeset() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Remove defunct i915_timeline.requests

2019-06-20 Thread Patchwork
== Series Details == Series: drm/i915: Remove defunct i915_timeline.requests URL : https://patchwork.freedesktop.org/series/62481/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6318 -> Patchwork_13375 Summary --- **F

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,01/33] drm/i915: Convert intel_vgt_(de)balloon to uncore

2019-06-20 Thread Patchwork
== Series Details == Series: series starting with [CI,01/33] drm/i915: Convert intel_vgt_(de)balloon to uncore URL : https://patchwork.freedesktop.org/series/62482/ State : failure == Summary == Applying: drm/i915: Convert intel_vgt_(de)balloon to uncore Applying: drm/i915: Introduce struct i

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix TypeC port mode switching (rev3)

2019-06-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix TypeC port mode switching (rev3) URL : https://patchwork.freedesktop.org/series/61590/ State : success == Summary == CI Bug Log - changes from CI_DRM_6314_full -> Patchwork_13366_full Summary -

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm: Pretty print mode flags

2019-06-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm: Pretty print mode flags URL : https://patchwork.freedesktop.org/series/62475/ State : success == Summary == CI Bug Log - changes from CI_DRM_6318 -> Patchwork_13374 Summary --

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm: Pretty print mode flags

2019-06-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm: Pretty print mode flags URL : https://patchwork.freedesktop.org/series/62475/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm: Pretty print mode flags -drivers/gpu/drm/drm_modes.c:1910:29:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm: Pretty print mode flags

2019-06-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm: Pretty print mode flags URL : https://patchwork.freedesktop.org/series/62475/ State : warning == Summary == $ dim checkpatch origin/drm-tip fb5a6b111c59 drm: Pretty print mode flags -:119: ERROR:BRACKET_SPACE: space prohibited before

[Intel-gfx] [PATCH 8/9] drm/i915: Handle a few more cases for hw/sw split

2019-06-20 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_display.c | 38 ++-- drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- drivers/gpu/drm/i915/display/intel_psr.c | 4 +-- 3 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/dr

[Intel-gfx] [PATCH 5/9] drm/i915: Pass intel state to plane functions as well

2019-06-20 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- .../gpu/drm/i915/display/intel_atomic_plane.c | 39 +++-- .../gpu/drm/i915/display/intel_atomic_plane.h | 5 +- drivers/gpu/drm/i915/display/intel_display.c | 58 +-- 3 files changed, 49 insertions(+), 53 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH 3/9] drm/i915: Convert hw state verifier to take more intel state

2019-06-20 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_display.c | 154 +-- 1 file changed, 74 insertions(+), 80 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 855f90a81396..a518d74f898

[Intel-gfx] [PATCH 4/9] drm/i915: Use intel_crtc_state in sanitize_watermarks() too

2019-06-20 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_display.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index a518d74f898f..baa0e1957ffe 100644

[Intel-gfx] [PATCH 9/9] drm/i915: Complete sw/hw split

2019-06-20 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_atomic.c | 16 +++ drivers/gpu/drm/i915/display/intel_atomic.h | 1 + drivers/gpu/drm/i915/display/intel_display.c | 46 +--- drivers/gpu/drm/i915/intel_drv.h | 8 ++-- 4 files changed, 63

[Intel-gfx] [PATCH 6/9] drm/i915: Use intel state as much as possible in wm code

2019-06-20 Thread Maarten Lankhorst
Instead of directly referencing drm_crtc_state, convert to intel_ctc_state and use the base struct. This is useful when we're making the split between uapi and hw state, and also makes the code slightly more readable. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_pm.c | 112 +++

[Intel-gfx] [PATCH 0/9] Split hw and drm state.

2019-06-20 Thread Maarten Lankhorst
Fourth try, with load detect fixed. Maarten Lankhorst (9): drm/i915: Pass intel_crtc_state to needs_modeset() drm/i915: Convert most of atomic commit to take more intel state drm/i915: Convert hw state verifier to take more intel state drm/i915: Use intel_crtc_state in sanitize_watermarks(

[Intel-gfx] [PATCH 1/9] drm/i915: Pass intel_crtc_state to needs_modeset()

2019-06-20 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_display.c | 68 ++-- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 8592a7d422de..02565e97995

[Intel-gfx] [PATCH 2/9] drm/i915: Convert most of atomic commit to take more intel state

2019-06-20 Thread Maarten Lankhorst
Instead of passing along drm_crtc_state and drm_atomic_state, pass along more intel_atomic_state and intel_crtc_state. This will make the code more readable by not casting between drm state and intel state all the time. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_disp

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gtt: Defer address space cleanup to an RCU worker (rev2)

2019-06-20 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Defer address space cleanup to an RCU worker (rev2) URL : https://patchwork.freedesktop.org/series/62356/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6316 -> Patchwork_13373 Summ

[Intel-gfx] [CI 25/33] drm/i915: Compartmentalize timeline_init/park/fini

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Continuing on the theme of better logical organization of our code, make the first step towards making the timeline code better isolated from wider struct drm_i915_private. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_timeline.c |

[Intel-gfx] [CI 29/33] drm/i915: Compartmentalize ring buffer creation

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Continuing on the theme of compartmentalizing the code better to make future split between gt and display in global i915 clearer. v2: * Pass in ggtt instead of gt. (Chris) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_ringbuff

[Intel-gfx] [CI 20/33] drm/i915: Make ggtt invalidation work on ggtt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It is more logical for ggtt invalidation to take ggtt as input parameter. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 51 ++--- drivers/gpu/drm/i915/i915_gem_gtt.h | 2 +- 2 files changed, 26 i

[Intel-gfx] [CI 28/33] drm/i915: Store ggtt pointer in intel_gt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This will become useful in the following patch. v2: * Assign the pointer through a helper on the top level to work around the layering violation. (Chris) v3: * Handle selftests. v4: * Move call to intel_gt_init_hw into mock_init_ggtt. (Chris) Signed-off-by: Tvrtko U

[Intel-gfx] [CI 14/33] drm/i915: Consolidate some open coded mmio rmw

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Replace some gen6/7 open coded rmw with intel_uncore_rmw. Signed-off-by: Tvrtko Ursulin Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_gem_gtt.c | 41 + 1 file changed, 18 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Dump mode picture aspect ratio

2019-06-20 Thread Patchwork
== Series Details == Series: drm: Dump mode picture aspect ratio URL : https://patchwork.freedesktop.org/series/62467/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6316 -> Patchwork_13372 Summary --- **FAILURE**

[Intel-gfx] [CI 15/33] drm/i915: Convert i915_gem_init_hw to intel_gt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More removal of implicit dev_priv from using old mmio accessors. Actually the top level function remains but is split into a part which writes to i915 and part which operates on intel_gt in order to initialize the hardware. GuC and engines are the only odd ones out remainin

[Intel-gfx] [CI 32/33] drm/i915: Rename i915_timeline to intel_timeline and move under gt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Move all timeline code under gt and rename to intel_gt prefix. Signed-off-by: Tvrtko Ursulin Suggested-by: Chris Wilson Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/Makefile.header-test | 1 - drivers/gp

[Intel-gfx] [CI 19/33] drm/i915: Compartmentalize i915_ggtt_init_hw

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having made start to better code compartmentalization by introducing struct intel_gt, continue the theme elsewhere in code by making functions take parameters take what logically makes most sense for them instead of the global struct drm_i915_private. Signed-off-by: Tvrtko U

[Intel-gfx] [CI 11/33] drm/i915: Store backpointer to intel_gt in the engine

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It will come useful in the next patch. v2: * Do mock_engine as well. v3: * And the virtual engine... Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_engine_cs.c| 1 + drivers/gpu/drm/i915/gt/intel_engine_types.h | 2 ++ dr

[Intel-gfx] [CI 30/33] drm/i915: Save trip via top-level i915 in a few more places

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin For gt related operations it makes more logical sense to stay in the realm of gt instead of dereferencing via driver i915. This patch handles a few of the easy ones with work requiring more refactoring still outstanding. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wil

[Intel-gfx] [CI 03/33] drm/i915: Move intel_gt initialization to a separate file

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As it will grow in a following patch make a new home for it. v2: * Convert mock_gem_device as well. (Chris) v3: * Rename to intel_gt_init_early and move call site to i915_drv.c. (Chris) v4: * Adjust SPDX tags. * No need to gt/ path when including intel_gt_types.h. (Chr

[Intel-gfx] [CI 18/33] drm/i915: Compartmentalize i915_ggtt_probe_hw

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having made start to better code compartmentalization by introducing struct intel_gt, continue the theme elsewhere in code by making functions take parameters take what logically makes most sense for them instead of the global struct drm_i915_private. Signed-off-by: Tvrtko U

[Intel-gfx] [CI 33/33] drm/i915: Eliminate dual personality of i915_scratch_offset

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Scratch vma lives under gt but the API used to work on i915. Make this consistent by renaming the function to intel_gt_scratch_offset and make it take struct intel_gt. v2: * Move to intel_gt. (Chris) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gp

[Intel-gfx] [CI 27/33] drm/i915: Compartmentalize i915_gem_init_ggtt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Continuing on the theme of better logical organization of our code, make the first step towards making the ggtt code better isolated from wider struct drm_i915_private. v2: * Bring the ickle onion unwind back. (Chris) * Rename to i915_init_ggtt. (Chris) Signed-off-by: Tvr

[Intel-gfx] [CI 26/33] drm/i915: Compartmentalize i915_ggtt_cleanup_hw

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Continuing on the theme of better logical organization of our code, make the first step towards making the ggtt code better isolated from wider struct drm_i915_private. v2: * Cleanup of mm.wc_stash does not need struct_mutex. (Chris) Signed-off-by: Tvrtko Ursulin Reviewed

[Intel-gfx] [CI 24/33] drm/i915: Move i915_gem_chipset_flush to intel_gt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This aligns better with the rest of restructuring. v2: * Move call out of line. (Chris) Signed-off-by: Tvrtko Ursulin Suggested-by: Chris Wilson Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 +++-- drivers/gpu/drm/i915/gem/i915_gem_

[Intel-gfx] [CI 12/33] drm/i915: Convert intel_mocs_init_l3cc_table to intel_gt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More removal of implicit dev_priv from using old mmio accessors. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_mocs.c | 52 +--- drivers/gpu/drm/i915/gt/intel_mocs.h | 3 +- drivers/gpu/drm/i915/i915_gem

[Intel-gfx] [CI 22/33] drm/i915: Compartmentalize i915_gem_suspend/restore_gtt_mappings

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having made start to better code compartmentalization by introducing struct intel_gt, continue the theme elsewhere in code by making functions take parameters take what logically makes most sense for them instead of the global struct drm_i915_private. Signed-off-by: Tvrtko U

[Intel-gfx] [CI 21/33] drm/i915: Store intel_gt backpointer in vm

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This will come useful in the following patch. v2: * Handle mock ggtt. Signed-off-by: Tvrtko Ursulin Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_gem_gtt.c | 16 ++-- drivers/gpu/drm/i915/i915_gem_gtt.h | 1 + drivers/gpu/drm/i915/self

[Intel-gfx] [CI 05/33] drm/i915: Move intel_gt_pm_init under intel_gt_init_early

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin And also rename to intel_gt_pm_init_early and make it operate on gt. Signed-off-by: Tvrtko Ursulin Suggested-by: Chris Wilson Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_gt.c | 3 +++ drivers/gpu/drm/i915/gt/intel_gt_pm.c| 6 +++-

[Intel-gfx] [CI 16/33] drm/i915: Move intel_engines_resume into common init

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Since this part still operates on i915 and not intel_gt, move it to the common (top-level) function. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 29 ++--- 1 file changed, 22 insertions(+), 7 deletio

[Intel-gfx] [CI 04/33] drm/i915: Store some backpointers in struct intel_gt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We need an easy way to get back to i915 and uncore. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_gt.c | 7 ++- drivers/gpu/drm/i915/gt/intel_gt.h | 4 +++- drivers/gpu/drm/i915/gt/intel_gt_types.

[Intel-gfx] [CI 23/33] drm/i915: Convert i915_gem_flush_ggtt_writes to intel_gt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having introduced struct intel_gt (named the anonymous structure in i915) we can start using it to compartmentalize our code better. It makes more sense logically to have the code internally like this and it will also help with future split between gt and display in i915. v2

[Intel-gfx] [CI 31/33] drm/i915: Make timelines gt centric

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Our timelines are stored inside intel_gt so we can convert the interface to take exactly that and not i915. At the same time re-order the params to our more typical layout and replace the backpointer to the new containing structure. Signed-off-by: Tvrtko Ursulin Reviewed-b

[Intel-gfx] [CI 17/33] drm/i915: Stop using I915_READ/WRITE in intel_wopcm_init_hw

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More legacy mmio accessor removal. We pass in intel_gt explicitly allowing code to use new intel_uncore_read/write helpers. Signed-off-by: Tvrtko Ursulin Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_gem.c| 2 +- drivers/gpu/drm/i915/intel_wopcm.c | 31

[Intel-gfx] [CI 13/33] drm/i915: Convert i915_ppgtt_init_hw to intel_gt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More removal of implicit dev_priv from using old mmio accessors. v2: * Rebase for uncore_to_i915 removal. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/i915_gem_gtt.c | 101

[Intel-gfx] [CI 07/33] drm/i915: Convert i915_gem_init_swizzling to intel_gt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Start using the newly introduced struct intel_gt to fuse together correct logical init flow with uncore for more removal of implicit dev_priv in mmio access. v2: * Move code to i915_gem_fence_reg. (Chris) Signed-off-by: Tvrtko Ursulin Reviewed-by: Rodrigo Vivi --- drive

[Intel-gfx] [CI 02/33] drm/i915: Introduce struct intel_gt as replacement for anonymous i915->gt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We have long been slighlty annoyed by the anonymous i915->gt. Promote it to a separate structure and give it its own header. This is a first step towards cleaning up the separation between i915 and gt. v2: * Adjust SPDX header. Signed-off-by: Tvrtko Ursulin Reviewed-by:

[Intel-gfx] [CI 01/33] drm/i915: Convert intel_vgt_(de)balloon to uncore

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More removal of implicit dev_priv from using old mmio accessors. Furthermore these calls really operate on ggtt so it logically makes sense if they take it as parameter. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 4

[Intel-gfx] [CI 10/33] drm/i915: Convert gt workarounds to intel_gt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More conversion of i915_gem_init_hw to uncore. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 10 +- drivers/gpu/drm/i915/gt/intel_workarounds.h | 6 +++--- drivers/gpu/drm/i915/i915_gem.c |

[Intel-gfx] [CI 06/33] drm/i915: Make i915_check_and_clear_faults take intel_gt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Continuing the conversion and elimination of implicit dev_priv. Signed-off-by: Tvrtko Ursulin Suggested-by: Rodrigo Vivi Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 4 +- drivers/gpu/drm/i915/gt/intel_gt.c| 130

[Intel-gfx] [CI 09/33] drm/i915: Convert init_unused_rings to intel_gt

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More removal of implicit dev_priv from using old mmio accessors. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 42 ++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [CI 08/33] drm/i915: Use intel_uncore_rmw in intel_gt_init_swizzling

2019-06-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Two easy opportunities to compact the code by using the existing helper. Signed-off-by: Tvrtko Ursulin Suggested-by: Rodrigo Vivi Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_fence_reg.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff

Re: [Intel-gfx] [PATCH 1/2] drm: Pretty print mode flags

2019-06-20 Thread Sam Ravnborg
Hi Ville. On Thu, Jun 20, 2019 at 09:50:48PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Decode the mode flags when printing the modeline so that I > no longer have to decode the hex number myself. You are extending the current way to print mode flags, but I would anyway like to point

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915/ehl/dsi: Set lane latency optimization for DW1

2019-06-20 Thread Souza, Jose
On Thu, 2019-06-20 at 15:08 +, Patchwork wrote: > == Series Details == > > Series: series starting with [v2,1/2] drm/i915/ehl/dsi: Set lane > latency optimization for DW1 > URL : https://patchwork.freedesktop.org/series/62417/ > State : success > > == Summary == > > CI Bug Log - changes fr

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gtt: Defer address space cleanup to an RCU worker (rev2)

2019-06-20 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Defer address space cleanup to an RCU worker (rev2) URL : https://patchwork.freedesktop.org/series/62356/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/gtt: Defer address space cleanup to an RCU work

Re: [Intel-gfx] [PATCH] docs: fix some broken references due to txt->rst renames

2019-06-20 Thread Jonathan Corbet
On Tue, 18 Jun 2019 10:33:58 -0300 Mauro Carvalho Chehab wrote: > here are three left-overs from the recent file renames, > probably due to some other conflicting patch. > > Fix them. > > Signed-off-by: Mauro Carvalho Chehab > --- > > This patch is against today's next-20190617 branch. Not su

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Add missing VECS engine

2019-06-20 Thread Souza, Jose
On Fri, 2019-06-14 at 15:17 -0700, Matt Roper wrote: > On Fri, Jun 14, 2019 at 02:37:49PM -0700, José Roberto de Souza > wrote: > > EHL can have up to one VECS(video enhancement) engine, so add it to > > the device_info. > > Bspec 29150 has a footnote on VEbox that indicates "Pass-through > only,

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,01/33] drm/i915: Convert intel_vgt_(de)balloon to uncore (rev3)

2019-06-20 Thread Patchwork
== Series Details == Series: series starting with [CI,01/33] drm/i915: Convert intel_vgt_(de)balloon to uncore (rev3) URL : https://patchwork.freedesktop.org/series/62411/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objto

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev3)

2019-06-20 Thread Patchwork
== Series Details == Series: drm/i915: Check backlight type while doing eDP backlight initializaiton (rev3) URL : https://patchwork.freedesktop.org/series/62362/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6316 -> Patchwork_13370

[Intel-gfx] [PATCH] drm/i915: Remove defunct i915_timeline.requests

2019-06-20 Thread Chris Wilson
As no one is currently inspecting the list of i915_timeline.requests, let's remove it (and the corresponding i915_request.link). Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_request.c| 3 --- drivers/gpu/drm/i915/i915_request.h| 3 --- dri

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev3)

2019-06-20 Thread Patchwork
== Series Details == Series: drm/i915: Check backlight type while doing eDP backlight initializaiton (rev3) URL : https://patchwork.freedesktop.org/series/62362/ State : warning == Summary == $ dim checkpatch origin/drm-tip cddef96419ec drm/i915: Check backlight type while doing eDP backlight

[Intel-gfx] ✗ Fi.CI.BAT: failure for br_netfilter: prevent UAF in brnf_exit_net()

2019-06-20 Thread Patchwork
== Series Details == Series: br_netfilter: prevent UAF in brnf_exit_net() URL : https://patchwork.freedesktop.org/series/62465/ State : failure == Summary == Applying: br_netfilter: prevent UAF in brnf_exit_net() error: sha1 information is lacking or useless (net/bridge/br_netfilter_hooks.c).

Re: [Intel-gfx] [PATCH] drm/i915: Engine relative MMIO

2019-06-20 Thread Rodrigo Vivi
On Thu, Jun 20, 2019 at 05:33:12PM +0100, Tvrtko Ursulin wrote: > > [fixed Chris' email] > > On 20/06/2019 08:24, Matthew Brost wrote: > > On Mon, May 13, 2019 at 12:45:52PM -0700, john.c.harri...@intel.com wrote: > > > From: John Harrison > > > > > > With virtual engines, it is no longer possi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Aspect ratio fixes

2019-06-20 Thread Patchwork
== Series Details == Series: drm: Aspect ratio fixes URL : https://patchwork.freedesktop.org/series/62462/ State : success == Summary == CI Bug Log - changes from CI_DRM_6314 -> Patchwork_13368 Summary --- **SUCCESS** No regressio

[Intel-gfx] [PATCH v2 2/2] drm: Dump mode picture aspect ratio

2019-06-20 Thread Ville Syrjala
From: Ville Syrjälä Currently the logs show nothing about the mode's aspect ratio. Include that information in the normal mode dump. v2: Don't print anything for NONE (Ilia) Cc: Ilia Mirkin Signed-off-by: Ville Syrjälä --- drivers/video/hdmi.c| 3 ++- include/drm/drm_modes.h | 6 --

[Intel-gfx] [PATCH 1/2] drm: Pretty print mode flags

2019-06-20 Thread Ville Syrjala
From: Ville Syrjälä Decode the mode flags when printing the modeline so that I no longer have to decode the hex number myself. To do this neatly I made the caller provide a temporary on stack buffer where we can produce the results. I choce 64 bytes as a reasonable size for this. The worst case

[Intel-gfx] [CI] drm/i915/gtt: Defer address space cleanup to an RCU worker

2019-06-20 Thread Chris Wilson
Enable RCU protection of i915_address_space and its ppgtt superclasses, and defer its cleanup into a worker executed after an RCU grace period. In the future we will be able to use the RCU protection to reduce the locking around VM lookups, but the immediate benefit is being able to defer the rele

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/execlists: Preempt-to-busy

2019-06-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/execlists: Preempt-to-busy URL : https://patchwork.freedesktop.org/series/62461/ State : success == Summary == CI Bug Log - changes from CI_DRM_6314 -> Patchwork_13367 Summ

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix TypeC port mode switching (rev3)

2019-06-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix TypeC port mode switching (rev3) URL : https://patchwork.freedesktop.org/series/61590/ State : success == Summary == CI Bug Log - changes from CI_DRM_6314 -> Patchwork_13366 Summary --- **WA

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT

2019-06-20 Thread Anuj Phogat
On Thu, Jun 20, 2019 at 2:27 AM Lionel Landwerlin wrote: > > The same tests failing on CFL+ platforms are also failing on ICL. > Documentation doesn't list the > WaAllowPMDepthAndInvocationCountAccessFromUMD workaround for ICL but > applying it fixes the same tests as CFL. > > Signed-off-by: Lione

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: handle GuC messages received with CTB disabled

2019-06-20 Thread Daniele Ceraolo Spurio
On 6/20/19 6:48 AM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-06-19 22:43:51) +/* + * Events triggered while CT buffers are disabled are logged in the SCRATCH_15 + * register using the same bits used in the CT message payload. Since our + * communication channel with guc is turn

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] drm/i915/execlists: Preempt-to-busy

2019-06-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/execlists: Preempt-to-busy URL : https://patchwork.freedesktop.org/series/62461/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/execlists: Preempt-to-busy -drivers/gpu/drm/i91

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/execlists: Preempt-to-busy

2019-06-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/execlists: Preempt-to-busy URL : https://patchwork.freedesktop.org/series/62461/ State : warning == Summary == $ dim checkpatch origin/drm-tip 513105220a80 drm/i915/execlists: Preempt-to-busy -:393: WARNING:MEMORY_BARRIER: mem

Re: [Intel-gfx] [PATCH v6 3/4] drm/i915/psr: Make PSR registers relative to transcoders

2019-06-20 Thread Souza, Jose
On Thu, 2019-06-20 at 11:13 +0300, Jani Nikula wrote: > On Wed, 19 Jun 2019, José Roberto de Souza > wrote: > > diff --git a/drivers/gpu/drm/i915/i915_reg.h > > b/drivers/gpu/drm/i915/i915_reg.h > > index 4fc8dc083766..31fb4de5081c 100644 > > --- a/drivers/gpu/drm/i915/i915_reg.h > > +++ b/drivers

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix TypeC port mode switching (rev3)

2019-06-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix TypeC port mode switching (rev3) URL : https://patchwork.freedesktop.org/series/61590/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/icl: Add support to read out the TBT PLL HW state Okay! Commit: d

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix TypeC port mode switching (rev3)

2019-06-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix TypeC port mode switching (rev3) URL : https://patchwork.freedesktop.org/series/61590/ State : warning == Summary == $ dim checkpatch origin/drm-tip e23fdc6d149d drm/i915/icl: Add support to read out the TBT PLL HW state cbfff715e9c9 drm/i915: Tune do

[Intel-gfx] ✗ Fi.CI.BAT: failure for prime doc polish and ... a few cleanups (rev7)

2019-06-20 Thread Patchwork
== Series Details == Series: prime doc polish and ... a few cleanups (rev7) URL : https://patchwork.freedesktop.org/series/62135/ State : failure == Summary == Applying: drm/todo: Update drm_gem_object_funcs todo even more Using index info to reconstruct a base tree... M Documentation/gp

  1   2   3   >