[Intel-gfx] ✓ Fi.CI.BAT: success for Support mipi dsi video mode on TGL

2019-07-01 Thread Patchwork
== Series Details == Series: Support mipi dsi video mode on TGL URL : https://patchwork.freedesktop.org/series/63058/ State : success == Summary == CI Bug Log - changes from CI_DRM_6394 -> Patchwork_13486 Summary --- **SUCCESS** N

[Intel-gfx] [PATCH 0/4] Support mipi dsi video mode on TGL

2019-07-01 Thread Vandita Kulkarni
This series doesn't include the patch to add dsi init in setup_outputs. Waiting for the platform enablemnet patches to be merged. Vandita Kulkarni (4): drm/i915/tgl/dsi: Program TRANS_VBLANK register drm/i915/tgl/dsi: Set latency PCS_DW1 for tgl drm/i915/tgl/dsi: Do not override TA_SURE dr

[Intel-gfx] [PATCH 3/4] drm/i915/tgl/dsi: Do not override TA_SURE

2019-07-01 Thread Vandita Kulkarni
Do not override TA_SURE timing parameter to zero for DSI 8X frequency 800MHz or below on TGL. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/display/i

[Intel-gfx] [PATCH 2/4] drm/i915/tgl/dsi: Set latency PCS_DW1 for tgl

2019-07-01 Thread Vandita Kulkarni
Rest of the latency programming remains same as that of ICL. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c index 5

[Intel-gfx] [PATCH 1/4] drm/i915/tgl/dsi: Program TRANS_VBLANK register

2019-07-01 Thread Vandita Kulkarni
Program vblank register for mipi dsi in video mode on TGL. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c index b8673debf932..

[Intel-gfx] [PATCH 4/4] drm/i915/tgl/dsi: Gate the ddi clocks after pll mapping

2019-07-01 Thread Vandita Kulkarni
No need to keep it on till IO enabling. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c index d1c50a4186f0..

[Intel-gfx] Fedora 30 drm error

2019-07-01 Thread Chunyu Hu
Hi Rodrigo, Joonas and Jani, I'm meeting some drm issues when using Fedora 30. I'm using a Lenovo box, and I met some error message in dmesg, (not panic). Could you take a look at the warning, and do we have already fixes for this? Thanks! [43401.062181] [drm:intel_cpu_fifo_underrun_irq_h

Re: [Intel-gfx] [PATCH v3 3/4] drm/connector: Split out orientation quirk detection

2019-07-01 Thread dbasehore .
On Mon, Jun 24, 2019 at 6:24 AM Ville Syrjälä wrote: > > On Fri, Jun 21, 2019 at 08:41:04PM -0700, Derek Basehore wrote: > > Not every platform needs quirk detection for panel orientation, so > > split the drm_connector_init_panel_orientation_property into two > > functions. One for platforms with

Re: [Intel-gfx] [PATCH v6 3/4] drm/i915/psr: Make PSR registers relative to transcoders

2019-07-01 Thread Souza, Jose
On Mon, 2019-07-01 at 22:26 +, Souza, Jose wrote: > On Fri, 2019-06-28 at 19:25 -0700, Dhinakaran Pandiyan wrote: > > On Mon, 2019-06-24 at 14:11 -0700, Souza, Jose wrote: > > > > > > +#define _HSW_EDP_PSR_BASE0x64800 > > > > > > +#define _SRD_CTL_A

[Intel-gfx] XDC 2019: Final week to submit your talks!

2019-07-01 Thread Mark Filion
Hi! It's the final week to submit your talks, workshops or demos for #XDC2019!! CfP ends this coming Sunday, July 7! Have some new developments to share? Facing some challenges with you projects? If it's related to open source graphics, please send it in! http://xdc2019.x.org Best, Mark

Re: [Intel-gfx] [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro

2019-07-01 Thread Alexey Dobriyan
On Tue, Jun 11, 2019 at 03:00:10PM -0600, Andreas Dilger wrote: > On Jun 11, 2019, at 2:48 PM, Andrew Morton wrote: > > > > On Wed, 12 Jun 2019 01:08:36 +0530 Shyam Saini > > wrote: > I did a check, and FIELD_SIZEOF() is used about 350x, while sizeof_field() > is about 30x, and SIZEOF_FIELD()

Re: [Intel-gfx] [PATCH v6 3/4] drm/i915/psr: Make PSR registers relative to transcoders

2019-07-01 Thread Souza, Jose
On Fri, 2019-06-28 at 19:25 -0700, Dhinakaran Pandiyan wrote: > On Mon, 2019-06-24 at 14:11 -0700, Souza, Jose wrote: > > > > > +#define _HSW_EDP_PSR_BASE0x64800 > > > > > +#define _SRD_CTL_A 0x60800 > > > > > +#define _SRD_CTL_EDP

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Remove preemption support for current fw (rev2)

2019-07-01 Thread Patchwork
== Series Details == Series: drm/i915/guc: Remove preemption support for current fw (rev2) URL : https://patchwork.freedesktop.org/series/56767/ State : success == Summary == CI Bug Log - changes from CI_DRM_6394 -> Patchwork_13485 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc: Remove preemption support for current fw (rev2)

2019-07-01 Thread Patchwork
== Series Details == Series: drm/i915/guc: Remove preemption support for current fw (rev2) URL : https://patchwork.freedesktop.org/series/56767/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/guc: Remove preemption support for current fw -./dr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Free pages before rcu-freeing the object (rev2)

2019-07-01 Thread Patchwork
== Series Details == Series: drm/i915/gem: Free pages before rcu-freeing the object (rev2) URL : https://patchwork.freedesktop.org/series/63042/ State : success == Summary == CI Bug Log - changes from CI_DRM_6394 -> Patchwork_13484 Summary

[Intel-gfx] [PATCH v2] drm/i915/guc: Remove preemption support for current fw

2019-07-01 Thread Daniele Ceraolo Spurio
From: Chris Wilson Preemption via GuC submission is not being supported with its current legacy incarnation. The current FW does support a similar pre-emption flow via H2G, but it is class-based instead of being instance-based, which doesn't fit well with the i915 tracking. To fix this, the firmw

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add helper to compare edids.

2019-07-01 Thread Lyude Paul
Sorry for the late response! I like the idea here and I've brought up edid comparison a couple times. Hopefully this isn't overkill, but I had a little more in mind then just a helper like this (and I've had this on my mind for a while! When it comes to suspend/resume reprobing, I think there's mo

[Intel-gfx] [PATCH v2] drm/i915/gem: Free pages before rcu-freeing the object

2019-07-01 Thread Chris Wilson
As we have dropped the final reference to the object, we do not need to wait until after the rcu grace period to drop its pages. We still require struct_mutex to completely unbind the object to release the pages, so we still need a free-worker to manage that from process context. By scheduling the

Re: [Intel-gfx] [PATCH 04/12] drm/i915/execlists: Refactor CSB state machine

2019-07-01 Thread Daniele Ceraolo Spurio
On 7/1/19 3:04 AM, Chris Wilson wrote: Daniele pointed out that the CSB status information will change with Tigerlake and suggested that we could rearrange our state machine to hide the differences in generation. gcc also prefers the explicit state machine, so make it so: process_csb

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use the "display core" power domain in vlv/chv set_cdclk()

2019-07-01 Thread Patchwork
== Series Details == Series: drm/i915: Use the "display core" power domain in vlv/chv set_cdclk() URL : https://patchwork.freedesktop.org/series/63045/ State : success == Summary == CI Bug Log - changes from CI_DRM_6394 -> Patchwork_13483 S

Re: [Intel-gfx] [PATCH 01/12] drm/i915/guc: Avoid reclaim locks during reset

2019-07-01 Thread Daniele Ceraolo Spurio
On 7/1/19 3:04 AM, Chris Wilson wrote: During reset, we must be very selective in which locks we take as most are tainted by being held across a wait or reclaim (kmalloc) which implicitly waits. Inside the guc reset path, we reset the ADS to sane defaults, but must keep it pinned from initialis

Re: [Intel-gfx] [PATCH 11/28] drm/i915/tgl: Add power well to support 4th pipe

2019-07-01 Thread Ville Syrjälä
On Tue, Jun 25, 2019 at 10:54:20AM -0700, Lucas De Marchi wrote: > From: Mika Kahola > > Add power well 5 to support 4th pipe and transcoder on TGL. > > Cc: James Ausmus > Cc: Imre Deak > Signed-off-by: Mika Kahola > Signed-off-by: Lucas De Marchi > --- > .../drm/i915/display/intel_display_

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Check crtc_state->wm.need_postvbl_update before grabbing wm.mutex

2019-07-01 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Check crtc_state->wm.need_postvbl_update before grabbing wm.mutex URL : https://patchwork.freedesktop.org/series/63044/ State : success == Summary == CI Bug Log - changes from CI_DRM_6394 -> Patchwork_13482

Re: [Intel-gfx] [PATCH 12/28] drm/i915/tgl: Add TRANSCODER_A_VDSC power domain

2019-07-01 Thread Ville Syrjälä
On Mon, Jul 01, 2019 at 08:32:59PM +0300, Ville Syrjälä wrote: > On Fri, Jun 28, 2019 at 09:31:04AM -0700, Lucas De Marchi wrote: > > On Fri, Jun 28, 2019 at 12:55:17PM +0300, Ville Syrjälä wrote: > > >On Tue, Jun 25, 2019 at 10:54:21AM -0700, Lucas De Marchi wrote: > > >> From: José Roberto de Sou

Re: [Intel-gfx] [PATCH 12/28] drm/i915/tgl: Add TRANSCODER_A_VDSC power domain

2019-07-01 Thread Ville Syrjälä
On Fri, Jun 28, 2019 at 09:31:04AM -0700, Lucas De Marchi wrote: > On Fri, Jun 28, 2019 at 12:55:17PM +0300, Ville Syrjälä wrote: > >On Tue, Jun 25, 2019 at 10:54:21AM -0700, Lucas De Marchi wrote: > >> From: José Roberto de Souza > >> > >> On TGL the special EDP transcoder is gone and it should b

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Free pages before rcu-freeing the object

2019-07-01 Thread Patchwork
== Series Details == Series: drm/i915/gem: Free pages before rcu-freeing the object URL : https://patchwork.freedesktop.org/series/63042/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6393 -> Patchwork_13481 Summary ---

[Intel-gfx] [PATCH] drm/i915: Use the "display core" power domain in vlv/chv set_cdclk()

2019-07-01 Thread Ville Syrjala
From: Ville Syrjälä The PFI credit programming performed during cdclk change on vlv/chv requires access to a register in the disp2d power well. So far we've abused pipe-A power domain for this, but now we have the more appropriate "display core" domain so let's make use of it. Signed-off-by: Vil

[Intel-gfx] [PATCH 3/6] drm/i915: Polish intel_shared_dpll_swap_state()

2019-07-01 Thread Ville Syrjala
From: Ville Syrjälä Use swap() instead of hand rolling it in intel_shared_dpll_swap_state(), and pass in the intel_atomic_state instead of drm_atomic_state. Makes the code less convoluted. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i

[Intel-gfx] [PATCH 5/6] drm/i915: Use intel_ types in intel_{lock, modeset}_all_pipes()

2019-07-01 Thread Ville Syrjala
From: Ville Syrjälä Streamline the code a bit by using intel_ types instead of the drm_ types. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 38 +++- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/i915/display/i

[Intel-gfx] [PATCH 1/6] drm/i915: Check crtc_state->wm.need_postvbl_update before grabbing wm.mutex

2019-07-01 Thread Ville Syrjala
From: Ville Syrjälä wm.mutex does not protect the crtc state so no point in grabbing it to check crtc_state->wm.need_postvbl_update. Also do a bit of s/intel_crtc/crtc/ while at it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_pm.c | 23 --- 1 file changed,

[Intel-gfx] [PATCH 4/6] drm/i915: Polish intel_atomic_track_fbs()

2019-07-01 Thread Ville Syrjala
From: Ville Syrjälä Streamline the code a bit by using intel_ types instead of drm_ types in intel_atomic_track_fbs(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 2/6] drm/i915: Simplify modeset_get_crtc_power_domains() arguments

2019-07-01 Thread Ville Syrjala
From: Ville Syrjälä Pass just the crtc state to modeset_get_crtc_power_domains(). We can get the crtc from therein. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 21 ++-- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/g

[Intel-gfx] [PATCH 6/6] drm/i915: Use intel_ types in intel_atomic_commit()

2019-07-01 Thread Ville Syrjala
From: Ville Syrjälä Make life less annoying by favoring the intel_ types over the drm_ types in intel_atomic_commit(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 76 ++-- 1 file changed, 37 insertions(+), 39 deletions(-) diff --git a/driver

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for EHL port programming (rev3)

2019-07-01 Thread Matt Roper
On Wed, Jun 26, 2019 at 11:05:08AM +, Patchwork wrote: > == Series Details == > > Series: EHL port programming (rev3) > URL : https://patchwork.freedesktop.org/series/62492/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_6351_full -> Patchwork_13432_full > ===

Re: [Intel-gfx] [PATCH v6 06/11] drm/i915: introduce a mechanism to extend execbuf2

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:32) > We're planning to use this for a couple of new feature where we need > to provide additional parameters to execbuf. > > Signed-off-by: Lionel Landwerlin Looks ok, are you convinced by I915_EXEC_EXT? It doesn't roll off the tongue too well for me,

[Intel-gfx] [PATCH] drm/i915/gem: Free pages before rcu-freeing the object

2019-07-01 Thread Chris Wilson
As we have dropped the final reference to the object, we do not need to wait until after the rcu grace period to drop its pages. We still require struct_mutex to completely unbind the object to release the pages, so we still need a free-worker to manage that from process context. By scheduling the

Re: [Intel-gfx] [PATCH v6 03/11] drm/i915/perf: allow for CS OA configs to be created lazily

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:29) > struct i915_oa_config { > + struct drm_i915_private *i915; > + > char uuid[UUID_STRING_LEN + 1]; > int id; > > @@ -1110,6 +1112,10 @@ struct i915_oa_config { > struct attribute *attrs[2]; > struct device_attr

Re: [Intel-gfx] Graphics issue after upgrade from Fedora 28 to 29 - multiple mouse cursor icons

2019-07-01 Thread Ville Syrjälä
On Mon, Jul 01, 2019 at 04:20:45PM +0200, Hans de Goede wrote: > Hi, > > On 01-07-19 15:32, Ville Syrjälä wrote: > > On Sun, Jun 30, 2019 at 04:23:47PM +0200, Przemysław Hołubowski wrote: > >> Hello, > >> > >> immediately after I have upgraded my system from Fedora 28 x64 to 29 > >> graphics' issu

Re: [Intel-gfx] [PATCH v3 3/5] drm/i915/ehl: Don't program PHY_MISC on EHL PHY C

2019-07-01 Thread Matt Roper
On Fri, Jun 28, 2019 at 04:52:31PM -0700, Souza, Jose wrote: > On Tue, 2019-06-25 at 17:03 -0700, Matt Roper wrote: > > Although EHL added a third combo PHY, no PHY_MISC register was added > > for > > PHY C. The bspec indicates that there's no need to program the "DE > > to > > IO Comp Pwr Down" s

Re: [Intel-gfx] [PATCH v6 09/11] drm/i915/perf: allow holding preemption on filtered ctx

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 13:10:53) > On 01/07/2019 15:03, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2019-07-01 12:34:35) > >> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > >> b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > >> index f92bace9caff..012d6d7f54e

Re: [Intel-gfx] Graphics issue after upgrade from Fedora 28 to 29 - multiple mouse cursor icons

2019-07-01 Thread Hans de Goede
Hi, On 01-07-19 15:32, Ville Syrjälä wrote: On Sun, Jun 30, 2019 at 04:23:47PM +0200, Przemysław Hołubowski wrote: Hello, immediately after I have upgraded my system from Fedora 28 x64 to 29 graphics' issue started. Mouse leaves a trail composed of multiple blinking cursors and sometimes recta

Re: [Intel-gfx] [PATCH 04/12] drm/i915/execlists: Refactor CSB state machine

2019-07-01 Thread Chris Wilson
Quoting Mika Kuoppala (2019-07-01 12:49:48) > Chris Wilson writes: > > > Daniele pointed out that the CSB status information will change with > > Tigerlake and suggested that we could rearrange our state machine to > > hide the differences in generation. gcc also prefers the explicit state > > ma

Re: [Intel-gfx] [PATCH 01/12] drm/i915/guc: Avoid reclaim locks during reset

2019-07-01 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-07-01 13:36:28) > On Mon, 01 Jul 2019 12:04:51 +0200, Chris Wilson > wrote: > > > During reset, we must be very selective in which locks we take as most > > are tainted by being held across a wait or reclaim (kmalloc) which > > implicitly waits. Inside the guc res

Re: [Intel-gfx] [PATCH v6 03/11] drm/i915/perf: allow for CS OA configs to be created lazily

2019-07-01 Thread Lionel Landwerlin
On 01/07/2019 16:06, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:29) @@ -2535,9 +2635,21 @@ static int i915_perf_release(struct inode *inode, struct file *file) { struct i915_perf_stream *stream = file->private_data; struct drm_i915_private *dev_priv = st

Re: [Intel-gfx] [PATCH v6 10/11] drm/i915/perf: execute OA configuration from command stream

2019-07-01 Thread Lionel Landwerlin
On 01/07/2019 16:32, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:36) @@ -1860,23 +1893,55 @@ static int alloc_noa_wait(struct drm_i915_private *i915) return ret; } -static void config_oa_regs(struct drm_i915_private *dev_priv, - const s

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Vulkan performance query support (rev6)

2019-07-01 Thread Patchwork
== Series Details == Series: drm/i915: Vulkan performance query support (rev6) URL : https://patchwork.freedesktop.org/series/60916/ State : success == Summary == CI Bug Log - changes from CI_DRM_6390 -> Patchwork_13480 Summary --- *

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix TypeC port mode switching (rev8)

2019-07-01 Thread Imre Deak
On Sat, Jun 29, 2019 at 07:03:11AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix TypeC port mode switching (rev8) > URL : https://patchwork.freedesktop.org/series/61590/ > State : success Thanks for the reviews, pushed to -dinq, resolving minor conflicts in intel_mode

[Intel-gfx] ✓ Fi.CI.BAT: success for Extend BT2020 support in iCSC and fixes (rev5)

2019-07-01 Thread Patchwork
== Series Details == Series: Extend BT2020 support in iCSC and fixes (rev5) URL : https://patchwork.freedesktop.org/series/60480/ State : success == Summary == CI Bug Log - changes from CI_DRM_6379 -> Patchwork_13466 Summary --- **SU

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Extend BT2020 support in iCSC and fixes (rev5)

2019-07-01 Thread Peres, Martin
On 28/06/2019 18:06, Shankar, Uma wrote: > > >> -Original Message- >> From: Patchwork [mailto:patchw...@emeril.freedesktop.org] >> Sent: Friday, June 28, 2019 8:34 PM >> To: Shankar, Uma >> Cc: intel-gfx@lists.freedesktop.org >> Subject: ✗ Fi.CI.BAT: failure for Extend BT2020 support in

Re: [Intel-gfx] [PATCH v6 10/11] drm/i915/perf: execute OA configuration from command stream

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:36) > @@ -1860,23 +1893,55 @@ static int alloc_noa_wait(struct drm_i915_private > *i915) > return ret; > } > > -static void config_oa_regs(struct drm_i915_private *dev_priv, > - const struct i915_oa_reg *regs, > -

Re: [Intel-gfx] Graphics issue after upgrade from Fedora 28 to 29 - multiple mouse cursor icons

2019-07-01 Thread Ville Syrjälä
On Sun, Jun 30, 2019 at 04:23:47PM +0200, Przemysław Hołubowski wrote: > Hello, > > immediately after I have upgraded my system from Fedora 28 x64 to 29 > graphics' issue started. Mouse leaves a trail composed of multiple > blinking cursors and sometimes rectangular not-refreshed parts. The more

Re: [Intel-gfx] [PATCH v6 07/11] drm/i915: add syncobj timeline support

2019-07-01 Thread Lionel Landwerlin
On 01/07/2019 16:18, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:33) + /* +* For timeline syncobjs we need to preallocate chains for +* later signaling. +*/ + if (point != 0 && user_fence.flags & I915

Re: [Intel-gfx] [PATCH v6 07/11] drm/i915: add syncobj timeline support

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:33) > + /* > +* For timeline syncobjs we need to preallocate chains for > +* later signaling. > +*/ > + if (point != 0 && user_fence.flags & I915_EXEC_FENCE_SIGNAL) { > +

Re: [Intel-gfx] [PATCH v6 07/11] drm/i915: add syncobj timeline support

2019-07-01 Thread Lionel Landwerlin
On 01/07/2019 16:13, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:33) struct i915_execbuffer { struct drm_i915_private *i915; /** i915 backpointer */ struct drm_file *file; /** per-file lookup tables and limits */ @@ -275,6 +282,7 @@ struct i915_execbuffer

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Vulkan performance query support (rev6)

2019-07-01 Thread Patchwork
== Series Details == Series: drm/i915: Vulkan performance query support (rev6) URL : https://patchwork.freedesktop.org/series/60916/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/perf: add missing delay for OA muxes configuration Okay! Commi

Re: [Intel-gfx] [PATCH v6 07/11] drm/i915: add syncobj timeline support

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:33) > struct i915_execbuffer { > struct drm_i915_private *i915; /** i915 backpointer */ > struct drm_file *file; /** per-file lookup tables and limits */ > @@ -275,6 +282,7 @@ struct i915_execbuffer { > > struct { >

Re: [Intel-gfx] [PATCH v6 05/11] drm/i915/perf: implement active wait for noa configurations

2019-07-01 Thread Lionel Landwerlin
On 01/07/2019 15:43, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:31) NOA configuration take some amount of time to apply. That amount of time depends on the size of the GT. There is no documented time for this. For example, past experimentations with powergating configuration

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Vulkan performance query support (rev6)

2019-07-01 Thread Patchwork
== Series Details == Series: drm/i915: Vulkan performance query support (rev6) URL : https://patchwork.freedesktop.org/series/60916/ State : warning == Summary == $ dim checkpatch origin/drm-tip 063d9e6a602f drm/i915/perf: add missing delay for OA muxes configuration -:7: WARNING:COMMIT_MESSAG

Re: [Intel-gfx] [PATCH v6 03/11] drm/i915/perf: allow for CS OA configs to be created lazily

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:29) > @@ -2535,9 +2635,21 @@ static int i915_perf_release(struct inode *inode, > struct file *file) > { > struct i915_perf_stream *stream = file->private_data; > struct drm_i915_private *dev_priv = stream->dev_priv; > + struct i915

Re: [Intel-gfx] [PATCH v6 02/11] drm/i915/perf: introduce a versioning of the i915-perf uapi

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:28) > Reporting this version will help application figure out what level of > the support the running kernel provides. > > Signed-off-by: Lionel Landwerlin > --- > drivers/gpu/drm/i915/i915_drv.c | 3 +++ > include/uapi/drm/i915_drm.h | 21 +++

Re: [Intel-gfx] [PATCH v6 05/11] drm/i915/perf: implement active wait for noa configurations

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:31) > NOA configuration take some amount of time to apply. That amount of > time depends on the size of the GT. There is no documented time for > this. For example, past experimentations with powergating > configuration changes seem to indicate a 60~70us

Re: [Intel-gfx] [PATCH 01/12] drm/i915/guc: Avoid reclaim locks during reset

2019-07-01 Thread Michal Wajdeczko
On Mon, 01 Jul 2019 12:04:51 +0200, Chris Wilson wrote: During reset, we must be very selective in which locks we take as most are tainted by being held across a wait or reclaim (kmalloc) which implicitly waits. Inside the guc reset path, we reset the ADS to sane defaults, but must keep it pi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix memleak in runtime wakeref tracking

2019-07-01 Thread Patchwork
== Series Details == Series: drm/i915: Fix memleak in runtime wakeref tracking URL : https://patchwork.freedesktop.org/series/63031/ State : success == Summary == CI Bug Log - changes from CI_DRM_6390 -> Patchwork_13479 Summary --- *

Re: [Intel-gfx] [PATCH] drm/i915/guc: Define GuC firmware version for Comet Lake

2019-07-01 Thread Michal Wajdeczko
On Sat, 29 Jun 2019 02:37:09 +0200, Anusha Srivatsa wrote: Load GuC for Comet Lake. Depending on the REVID, we load either the KBL firmware or the CML firmware. Cc: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_guc_fw.c | 17 +++

Re: [Intel-gfx] [PATCH v6 08/11] drm/i915: add a new perf configuration execbuf parameter

2019-07-01 Thread Lionel Landwerlin
On 01/07/2019 15:05, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:34) +static int eb_oa_config(struct i915_execbuffer *eb) +{ + int err; + + if (!eb->oa_config) + return 0; + + err = i915_active_request_set(&eb->engine->last_oa_config, +

Re: [Intel-gfx] [PATCH v6 09/11] drm/i915/perf: allow holding preemption on filtered ctx

2019-07-01 Thread Lionel Landwerlin
On 01/07/2019 15:03, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:35) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index f92bace9caff..012d6d7f54e2 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++

Re: [Intel-gfx] [PATCH v6 04/11] drm/i915: enumerate scratch fields

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:30) > We have a bunch of offsets in the scratch buffer. As we're about to > add some more, let's group all of the offsets in a common location. > > Signed-off-by: Lionel Landwerlin Reviewed-by: Chris Wilson -Chris __

Re: [Intel-gfx] [PATCH v6 08/11] drm/i915: add a new perf configuration execbuf parameter

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:34) > +static int eb_oa_config(struct i915_execbuffer *eb) > +{ > + int err; > + > + if (!eb->oa_config) > + return 0; > + > + err = i915_active_request_set(&eb->engine->last_oa_config, > +

Re: [Intel-gfx] [PATCH v6 09/11] drm/i915/perf: allow holding preemption on filtered ctx

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:35) > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > index f92bace9caff..012d6d7f54e2 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > +++ b/drivers/gpu/drm/i915/gem/i915_ge

Re: [Intel-gfx] [PATCH 04/12] drm/i915/execlists: Refactor CSB state machine

2019-07-01 Thread Mika Kuoppala
Chris Wilson writes: > Daniele pointed out that the CSB status information will change with > Tigerlake and suggested that we could rearrange our state machine to > hide the differences in generation. gcc also prefers the explicit state > machine, so make it so: > > process_csb

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/12] drm/i915/guc: Avoid reclaim locks during reset

2019-07-01 Thread Patchwork
== Series Details == Series: series starting with [01/12] drm/i915/guc: Avoid reclaim locks during reset URL : https://patchwork.freedesktop.org/series/63029/ State : success == Summary == CI Bug Log - changes from CI_DRM_6390 -> Patchwork_13478 ===

[Intel-gfx] [PATCH v6 02/11] drm/i915/perf: introduce a versioning of the i915-perf uapi

2019-07-01 Thread Lionel Landwerlin
Reporting this version will help application figure out what level of the support the running kernel provides. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_drv.c | 3 +++ include/uapi/drm/i915_drm.h | 21 + 2 files changed, 24 insertions(+) diff --git

[Intel-gfx] [PATCH v6 07/11] drm/i915: add syncobj timeline support

2019-07-01 Thread Lionel Landwerlin
Introduces a new parameters to execbuf so that we can specify syncobj handles as well as timeline points. v2: Reuse i915_user_extension_fn v3: Check that the chained extension is only present once (Chris) v4: Check that dma_fence_chain_find_seqno returns a non NULL fence (Lionel) Signed-off-by:

[Intel-gfx] [PATCH v6 10/11] drm/i915/perf: execute OA configuration from command stream

2019-07-01 Thread Lionel Landwerlin
We haven't run into issues with programming the global OA/NOA registers configuration from CPU so far, but HW engineers actually recommend doing this from the command streamer. Since we have a command buffer prepared for the execbuffer side of things, we can reuse that approach here too. This als

[Intel-gfx] [PATCH v6 01/11] drm/i915/perf: add missing delay for OA muxes configuration

2019-07-01 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Fixes: 19f81df2859eb1 ("drm/i915/perf: Add OA unit support for Gen 8+") --- drivers/gpu/drm/i915/i915_perf.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index 357e

[Intel-gfx] [PATCH v6 00/11] drm/i915: Vulkan performance query support

2019-07-01 Thread Lionel Landwerlin
Hi all, Here are a number of fixes and improvement over v5. Here is a summary : * Name offsets/fields used in the scratch buffer * Save/restore used CS_GPR registers for perf delay * Limiting taking of global lock now that we have configuration happening on CS * Pre

[Intel-gfx] [PATCH v6 04/11] drm/i915: enumerate scratch fields

2019-07-01 Thread Lionel Landwerlin
We have a bunch of offsets in the scratch buffer. As we're about to add some more, let's group all of the offsets in a common location. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/gt/intel_gt.h | 6 +++-- drivers/gpu/drm/i915/gt/intel_gt_types.h | 15 +++ drivers

[Intel-gfx] [PATCH v6 09/11] drm/i915/perf: allow holding preemption on filtered ctx

2019-07-01 Thread Lionel Landwerlin
We would like to make use of perf in Vulkan. The Vulkan API is much lower level than OpenGL, with applications directly exposed to the concept of command buffers (pretty much equivalent to our batch buffers). In Vulkan, queries are always limited in scope to a command buffer. In OpenGL, the lack of

[Intel-gfx] [PATCH v6 11/11] drm/i915: add support for perf configuration queries

2019-07-01 Thread Lionel Landwerlin
Listing configurations at the moment is supported only through sysfs. This might cause issues for applications wanting to list configurations from a container where sysfs isn't available. This change adds a way to query the number of configurations and their content through the i915 query uAPI. v

[Intel-gfx] [PATCH v6 08/11] drm/i915: add a new perf configuration execbuf parameter

2019-07-01 Thread Lionel Landwerlin
We want the ability to dispatch a set of command buffer to the hardware, each with a different OA configuration. To achieve this, we reuse a couple of fields from the execbuf2 struct (I CAN HAZ execbuf3?) to notify what OA configuration should be used for a batch buffer. This requires the process m

[Intel-gfx] [PATCH v6 03/11] drm/i915/perf: allow for CS OA configs to be created lazily

2019-07-01 Thread Lionel Landwerlin
Here we introduce a mechanism by which the execbuf part of the i915 driver will be able to request that a batch buffer containing the programming for a particular OA config be created. We'll execute these OA configuration buffers right before executing a set of userspace commands so that a particu

[Intel-gfx] [PATCH v6 05/11] drm/i915/perf: implement active wait for noa configurations

2019-07-01 Thread Lionel Landwerlin
NOA configuration take some amount of time to apply. That amount of time depends on the size of the GT. There is no documented time for this. For example, past experimentations with powergating configuration changes seem to indicate a 60~70us delay. We go with 500us as default for now which should

[Intel-gfx] [PATCH v6 06/11] drm/i915: introduce a mechanism to extend execbuf2

2019-07-01 Thread Lionel Landwerlin
We're planning to use this for a couple of new feature where we need to provide additional parameters to execbuf. Signed-off-by: Lionel Landwerlin --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 32 ++- include/uapi/drm/i915_drm.h | 25 +-- 2 fil

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/12] drm/i915/guc: Avoid reclaim locks during reset

2019-07-01 Thread Patchwork
== Series Details == Series: series starting with [01/12] drm/i915/guc: Avoid reclaim locks during reset URL : https://patchwork.freedesktop.org/series/63029/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/guc: Avoid reclaim locks during rese

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/12] drm/i915/guc: Avoid reclaim locks during reset

2019-07-01 Thread Patchwork
== Series Details == Series: series starting with [01/12] drm/i915/guc: Avoid reclaim locks during reset URL : https://patchwork.freedesktop.org/series/63029/ State : warning == Summary == $ dim checkpatch origin/drm-tip d4ea6c6d576e drm/i915/guc: Avoid reclaim locks during reset 2bd81633bf02

[Intel-gfx] [CI] drm/i915: Fix memleak in runtime wakeref tracking

2019-07-01 Thread Mika Kuoppala
If we untrack wakerefs, the actual count may reach zero. However the krealloced owners array is still there and needs to be taken care of. Free the owners unconditionally to fix the leak. Fixes: bd780f37a361 ("drm/i915: Track all held rpm wakerefs") Reported-by: Juha-Pekka Heikkila Cc: Juha-Pekka

Re: [Intel-gfx] [PATCH i-g-t] tests/i915/gem_ctx_switch: Fix I915_EXEC_DEFAULT testing

2019-07-01 Thread Ramalingam C
On 2019-07-01 at 08:52:05 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Commit ad129d2a583689765eaef31ff57e8cdd219f1d05 > ("tests/i915/gem_ctx_switch: Update with engine discovery") broke testing > of I915_EXEC_DEFAULT. Bring it back. > > Signed-off-by: Tvrtko Ursulin > Reported-by: C

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm: report dp downstream port type as a subconnector property

2019-07-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm: report dp downstream port type as a subconnector property URL : https://patchwork.freedesktop.org/series/63026/ State : success == Summary == CI Bug Log - changes from CI_DRM_6389 -> Patchwork_13477 =

[Intel-gfx] [PATCH 06/12] drm/i915/selftests: Lock the drm_mm while modifying

2019-07-01 Thread Chris Wilson
Remember to lock the drm_mm as we modify it, lest it be modified in the background by retire/free workers! Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c

[Intel-gfx] [PATCH 05/12] drm/i915/execlists: Hesitate before slicing

2019-07-01 Thread Chris Wilson
Be a little more hesitant before injecting a timeslice, and try to take into account any change in priority that is due for the running task before switching to another task. This will allow us to arbitrarily prevent switching away from a request if we deem it necessarily to disable preemption, for

[Intel-gfx] [PATCH 08/12] drm/i915/gt: Track timeline activeness in enter/exit

2019-07-01 Thread Chris Wilson
Lift moving the timeline to/from the active_list on enter/exit in order to shorten the active tracking span in comparison to the existing pin/unpin. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_pm.c| 1 - drivers/gpu/drm/i915/gt/intel_context.c | 2 + drivers

[Intel-gfx] [PATCH 01/12] drm/i915/guc: Avoid reclaim locks during reset

2019-07-01 Thread Chris Wilson
During reset, we must be very selective in which locks we take as most are tainted by being held across a wait or reclaim (kmalloc) which implicitly waits. Inside the guc reset path, we reset the ADS to sane defaults, but must keep it pinned from initialisation to avoid having to pin it during rese

[Intel-gfx] [PATCH 07/12] drm/i915: Teach execbuffer to take the engine wakeref not GT

2019-07-01 Thread Chris Wilson
In the next patch, we would like to couple into the engine wakeref to free the batch pool on idling. The caveat here is that we therefore want to track the engine wakeref more precisely and to hold it instead of the broader GT wakeref as we process the ioctl. Signed-off-by: Chris Wilson --- .../

[Intel-gfx] [PATCH 10/12] drm/i915/gt: Guard timeline pinning with its own mutex

2019-07-01 Thread Chris Wilson
In preparation for removing struct_mutex from around context retirement, we need to make timeline pinning safe. Since multiple engines/contexts can share a single timeline, it needs to be protected by a mutex. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_timeline.c | 27 +++

[Intel-gfx] [PATCH 11/12] drm/i915: Protect request retirement with timeline->mutex

2019-07-01 Thread Chris Wilson
Forgo the struct_mutex requirement for request retirement as we have been transitioning over to only using the timeline->mutex for controlling the lifetime of a request on that timeline. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 192 ++ drive

[Intel-gfx] [PATCH 12/12] drm/i915: Replace struct_mutex for batch pool serialisation

2019-07-01 Thread Chris Wilson
Switch to tracking activity via i915_active on individual nodes, only keeping a list of retired objects in the cache, and reaping the cache when the engine itself idles. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 2 +- .../gpu/drm

[Intel-gfx] [PATCH 02/12] drm/i915: Markup potential lock for i915_active

2019-07-01 Thread Chris Wilson
Make the lockchains more deterministic via i915_active by flagging the potential lock. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_active.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_active.c b/drivers/gpu/drm/i915/i915_active.c index cb6a1eadf

[Intel-gfx] [PATCH 03/12] drm/i915: Mark up vma->active as safe for use inside shrinkers

2019-07-01 Thread Chris Wilson
Since a shrinker may be forced to wait on GPU activity, i915_active_wait(&vma->active) must be safe for use inside a shrinker, and so let's mark up the lock as being acquired by the shrinker to avoid any nasty surprises creeping in. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_vma.c

[Intel-gfx] [PATCH 04/12] drm/i915/execlists: Refactor CSB state machine

2019-07-01 Thread Chris Wilson
Daniele pointed out that the CSB status information will change with Tigerlake and suggested that we could rearrange our state machine to hide the differences in generation. gcc also prefers the explicit state machine, so make it so: process_csb 19801967 -13

[Intel-gfx] [PATCH 09/12] drm/i915/gt: Convert timeline tracking to spinlock

2019-07-01 Thread Chris Wilson
Convert the list manipulation of active to use spinlocks so that we can perform the updates from underneath a quick interrupt callback. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_gt_types.h | 2 +- drivers/gpu/drm/i915/gt/intel_reset.c| 13 ++--- drivers/gpu/drm/i

  1   2   >