[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Hide unshrinkable context objects from the shrinker (rev3)

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915: Hide unshrinkable context objects from the shrinker (rev3) URL : https://patchwork.freedesktop.org/series/63943/ State : success == Summary == CI Bug Log - changes from CI_DRM_6514_full -> Patchwork_13708_full =

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/vblank: Document and fix vblank count barrier semantics

2019-07-19 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/vblank: Document and fix vblank count barrier semantics URL : https://patchwork.freedesktop.org/series/63949/ State : success == Summary == CI Bug Log - changes from CI_DRM_6511_full -> Patchwork_13705_full ==

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Flush all user surfaces prior to first use

2019-07-19 Thread Jason Ekstrand
Just to be clear, is this just adding a CLFLUSH or is it actually changing the default caching state of buffers from CACHED to NONE? If it's actually changing the default state, that's going to break userspace badly. --Jason On Fri, Jul 19, 2019 at 5:21 AM Chris Wilson wrote: > Quoting Lionel

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Fix GEN8_MCR_SELECTOR programming

2019-07-19 Thread Summers, Stuart
On Thu, 2019-07-18 at 06:58 +0100, Tvrtko Ursulin wrote: > On 17/07/2019 22:25, Summers, Stuart wrote: > > On Wed, 2019-07-17 at 19:06 +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > Not opposed to this exactly, but do we really need this patch if > > we're > > just getting rid of

Re: [Intel-gfx] [PATCH v1 0/11] drm: header maintenance

2019-07-19 Thread Sam Ravnborg
On Thu, Jul 18, 2019 at 06:14:56PM +0200, Sam Ravnborg wrote: > First patch from Jani fixes so drm_print.h is self-contained. > Next two patches are trivial removal of uapi dependencies. > > ati_pcigart is fixed to drop use of drm_os_linux.h > > drm_vblank is likewise fixed to drop use of drm_os_

Re: [Intel-gfx] [PATCH 08/22] drm/i915/tgl: Add DKL phy pll registers

2019-07-19 Thread Atwood, Matthew S
On Fri, 2019-07-12 at 18:09 -0700, Lucas De Marchi wrote: > From: Vandita Kulkarni > > These are the registers needed to program Dekel PHY. Some register > definitions reuse the MG PHY definitions. Add a comment on those so > we > don't need to duplicate the functions for programming them. > Rev

Re: [Intel-gfx] [PATCH 21/24] drm/i915: Remove logical HW ID

2019-07-19 Thread Kumar Valsan, Prathap
On Mon, Jul 15, 2019 at 09:09:43AM +0100, Chris Wilson wrote: > We only need to keep a unique tag for the active lifetime of the > context, and for as long as we need to identify that context. The HW > uses the tag to determine if it should use a lite-restore (why not the > LRCA?) and passes the ta

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/uc: Acknowledge successful firmware load to the user

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915/uc: Acknowledge successful firmware load to the user URL : https://patchwork.freedesktop.org/series/63946/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6511_full -> Patchwork_13704_full

Re: [Intel-gfx] [PATCH 19/22] drm/i915/tgl: Tigerlake only has global MOCS registers

2019-07-19 Thread Lucas De Marchi
On Thu, Jul 18, 2019 at 10:40:43AM -0700, Daniele Ceraolo Spurio wrote: On 7/12/19 6:09 PM, Lucas De Marchi wrote: From: Michel Thierry Until Icelake, each engine had its own set of 64 MOCS registers. In order to simplify, Tigerlake moves to only 64 Global MOCS registers, which are no longer

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gtt: Correct unshifted 'from' for gen8_ppgtt_alloc errors

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Correct unshifted 'from' for gen8_ppgtt_alloc errors URL : https://patchwork.freedesktop.org/series/63945/ State : success == Summary == CI Bug Log - changes from CI_DRM_6511_full -> Patchwork_13703_full ===

Re: [Intel-gfx] [PATCH 1/3] drm/vblank: Document and fix vblank count barrier semantics

2019-07-19 Thread Ville Syrjälä
On Fri, Jul 19, 2019 at 08:33:49PM +0200, Daniel Vetter wrote: > On Fri, Jul 19, 2019 at 7:06 PM Ville Syrjälä > wrote: > > > > On Fri, Jul 19, 2019 at 05:23:12PM +0200, Daniel Vetter wrote: > > > Noticed while reviewing code. I'm not sure whether this might or might > > > not explain some of the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gtt: Fix rounding for 36b

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Fix rounding for 36b URL : https://patchwork.freedesktop.org/series/63944/ State : success == Summary == CI Bug Log - changes from CI_DRM_6511_full -> Patchwork_13702_full Summary --- **SUCC

Re: [Intel-gfx] [PATCH 21/22] drm/i915/tgl: Add and use new DC5 and DC6 residency counter registers

2019-07-19 Thread Lucas De Marchi
On Thu, Jul 18, 2019 at 11:17:03AM +0530, Anshuman Gupta wrote: On 2019-07-12 at 18:09:39 -0700, Lucas De Marchi wrote: From: José Roberto de Souza Tiger Lask has a new register offset for DC5 and DC6 residency counters. Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi --

Re: [Intel-gfx] [PATCH 1/3] drm/vblank: Document and fix vblank count barrier semantics

2019-07-19 Thread Daniel Vetter
On Fri, Jul 19, 2019 at 7:06 PM Ville Syrjälä wrote: > > On Fri, Jul 19, 2019 at 05:23:12PM +0200, Daniel Vetter wrote: > > Noticed while reviewing code. I'm not sure whether this might or might > > not explain some of the missed vblank hilarity we've been seeing. I > > think those all go through

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Hide unshrinkable context objects from the shrinker (rev3)

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915: Hide unshrinkable context objects from the shrinker (rev3) URL : https://patchwork.freedesktop.org/series/63943/ State : success == Summary == CI Bug Log - changes from CI_DRM_6514 -> Patchwork_13708 S

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Hide unshrinkable context objects from the shrinker

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915: Hide unshrinkable context objects from the shrinker URL : https://patchwork.freedesktop.org/series/63943/ State : success == Summary == CI Bug Log - changes from CI_DRM_6511_full -> Patchwork_13701_full

Re: [Intel-gfx] [PATCH 16/22] drm/i915/tgl: Implement Wa_1604555607

2019-07-19 Thread Lucas De Marchi
On Thu, Jul 18, 2019 at 07:03:26AM +0100, Tvrtko Ursulin wrote: On 13/07/2019 02:09, Lucas De Marchi wrote: From: Michel Thierry Implement Wa_1604555607 (set the DS pairing timer to 128 cycles). FF_MODE2 is part of the register state context, that's why it is implemented here. Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Fix rounding for 36b

2019-07-19 Thread Souza, Jose
On Fri, 2019-07-19 at 14:07 +0100, Chris Wilson wrote: > The top-level page directory for 36b is a single entry, not multiple > like 32b. Fix up the rounding on the calculation of the size of the > top > level so that we populate the 4th level correctly for 36b. > It fixed the bug, thanks Tested

Re: [Intel-gfx] [PATCH 04/22] drm/i915/tgl: Add hpd interrupt handling

2019-07-19 Thread Lucas De Marchi
On Fri, Jul 19, 2019 at 08:14:40PM +0300, Ville Syrjälä wrote: On Fri, Jul 19, 2019 at 08:08:47PM +0300, Ville Syrjälä wrote: On Fri, Jul 19, 2019 at 09:45:16AM -0700, Lucas De Marchi wrote: > On Fri, Jul 19, 2019 at 04:47:45PM +0300, Ville Syrjälä wrote: > >On Fri, Jul 12, 2019 at 06:09:22PM -0

Re: [Intel-gfx] [PATCH -next] drm/i915/dsi: remove set but not used variable 'hfront_porch'

2019-07-19 Thread Ville Syrjälä
On Fri, Jul 19, 2019 at 01:51:36AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/i915/display/icl_dsi.c: In function > 'gen11_dsi_set_transcoder_timings': > drivers/gpu/drm/i915/display/icl_dsi.c:768:6: warning: > variable 'hfront_porch' set but no

[Intel-gfx] [PATCH] drm/i915: Hide unshrinkable context objects from the shrinker

2019-07-19 Thread Chris Wilson
The shrinker cannot touch objects used by the contexts (logical state and ring). Currently we mark those as "pin_global" to let the shrinker skip over them, however, if we remove them from the shrinker lists entirely, we don't event have to include them in our shrink accounting. By keeping the uns

Re: [Intel-gfx] [PATCH 04/22] drm/i915/tgl: Add hpd interrupt handling

2019-07-19 Thread Ville Syrjälä
On Fri, Jul 19, 2019 at 08:08:47PM +0300, Ville Syrjälä wrote: > On Fri, Jul 19, 2019 at 09:45:16AM -0700, Lucas De Marchi wrote: > > On Fri, Jul 19, 2019 at 04:47:45PM +0300, Ville Syrjälä wrote: > > >On Fri, Jul 12, 2019 at 06:09:22PM -0700, Lucas De Marchi wrote: > > >> Add hotdplug detection fo

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Hide unshrinkable context objects from the shrinker (rev2)

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915: Hide unshrinkable context objects from the shrinker (rev2) URL : https://patchwork.freedesktop.org/series/63943/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6513 -> Patchwork_13707 S

Re: [Intel-gfx] [PATCH 04/22] drm/i915/tgl: Add hpd interrupt handling

2019-07-19 Thread Ville Syrjälä
On Fri, Jul 19, 2019 at 09:45:16AM -0700, Lucas De Marchi wrote: > On Fri, Jul 19, 2019 at 04:47:45PM +0300, Ville Syrjälä wrote: > >On Fri, Jul 12, 2019 at 06:09:22PM -0700, Lucas De Marchi wrote: > >> Add hotdplug detection for all ports on TGP. icp_hpd_detection_setup() > >> is refactored to be

Re: [Intel-gfx] [PATCH 1/3] drm/vblank: Document and fix vblank count barrier semantics

2019-07-19 Thread Ville Syrjälä
On Fri, Jul 19, 2019 at 05:23:12PM +0200, Daniel Vetter wrote: > Noticed while reviewing code. I'm not sure whether this might or might > not explain some of the missed vblank hilarity we've been seeing. I > think those all go through the vblank completion event, which has > unconditional barriers

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gtt: Don't try to clear failed empty pd allocation

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Don't try to clear failed empty pd allocation URL : https://patchwork.freedesktop.org/series/63950/ State : failure == Summary == Applying: drm/i915/gtt: Don't try to clear failed empty pd allocation Using index info to reconstruct a base tree... M

Re: [Intel-gfx] [PATCH 04/22] drm/i915/tgl: Add hpd interrupt handling

2019-07-19 Thread Lucas De Marchi
On Fri, Jul 19, 2019 at 04:47:45PM +0300, Ville Syrjälä wrote: On Fri, Jul 12, 2019 at 06:09:22PM -0700, Lucas De Marchi wrote: Add hotdplug detection for all ports on TGP. icp_hpd_detection_setup() is refactored to be shared with TGP. While we increase the number of pins, add a BUILD_BUG_ON()

[Intel-gfx] [PATCH] drm/i915: Hide unshrinkable context objects from the shrinker

2019-07-19 Thread Chris Wilson
The shrinker cannot touch objects used by the contexts (logical state and ring). Currently we mark those as "pin_global" to let the shrinker skip over them, however, if we remove them from the shrinker lists entirely, we don't event have to include them in our shrink accounting. By keeping the uns

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/vblank: Document and fix vblank count barrier semantics

2019-07-19 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/vblank: Document and fix vblank count barrier semantics URL : https://patchwork.freedesktop.org/series/63949/ State : success == Summary == CI Bug Log - changes from CI_DRM_6511 -> Patchwork_13705

Re: [Intel-gfx] [PATCH 07/22] drm/i915/dmc: Load DMC on TGL

2019-07-19 Thread Atwood, Matthew S
On Fri, 2019-07-12 at 18:09 -0700, Lucas De Marchi wrote: > From: Anusha Srivatsa > > Add Support to load DMC v2.02 on TGL. > Reviewed-by: Matt Atwood > Signed-off-by: Anusha Srivatsa > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/intel_csr.c | 7 +++ > 1 file changed, 7 i

Re: [Intel-gfx] [PATCH 21/22] drm/i915/tgl: Add and use new DC5 and DC6 residency counter registers

2019-07-19 Thread Atwood, Matthew S
On Thu, 2019-07-18 at 11:17 +0530, Anshuman Gupta wrote: > On 2019-07-12 at 18:09:39 -0700, Lucas De Marchi wrote: > > From: José Roberto de Souza > > > > Tiger Lask has a new register offset for DC5 and DC6 residency > > counters. nit: Tiger Lake > > > > Signed-off-by: José Roberto de Souza >

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915/guc: Turn on GuC/HuC auto mode"

2019-07-19 Thread Tvrtko Ursulin
On 19/07/2019 16:50, Daniele Ceraolo Spurio wrote: On 7/19/19 2:48 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin This reverts commit f774f09649192f326fa030564afd3f8f5d82c1e4. If GuC firmware is not present on the filesystem driver crashes the machine on boot. Do you have a log? I can't

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915/guc: Turn on GuC/HuC auto mode"

2019-07-19 Thread Daniele Ceraolo Spurio
On 7/19/19 8:50 AM, Daniele Ceraolo Spurio wrote: On 7/19/19 2:48 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin This reverts commit f774f09649192f326fa030564afd3f8f5d82c1e4. If GuC firmware is not present on the filesystem driver crashes the machine on boot. Do you have a log? I can't

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915/guc: Turn on GuC/HuC auto mode"

2019-07-19 Thread Daniele Ceraolo Spurio
On 7/19/19 2:48 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin This reverts commit f774f09649192f326fa030564afd3f8f5d82c1e4. If GuC firmware is not present on the filesystem driver crashes the machine on boot. Do you have a log? I can't reproduce this on a SKL, I'm just getting: [55667.0

Re: [Intel-gfx] [PATCH] drm/i915: Hide unshrinkable context objects from the shrinker

2019-07-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-19 16:38:28) > > On 19/07/2019 14:04, Chris Wilson wrote: > > +void i915_gem_object_make_unshrinkable(struct drm_i915_gem_object *obj) > > +{ > > + if (!list_empty(&obj->mm.link)) { > > Which lock protects this list head? Hmm, I was thinking this would be nice

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/vblank: Document and fix vblank count barrier semantics

2019-07-19 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/vblank: Document and fix vblank count barrier semantics URL : https://patchwork.freedesktop.org/series/63949/ State : warning == Summary == $ dim checkpatch origin/drm-tip f2d502a922df drm/vblank: Document and fix vblank count barrie

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Don't try to clear failed empty pd allocation

2019-07-19 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-07-19 16:33:22) > When __gen8_ppgtt_alloc fails without allocating anything > we should not try to call __gen8_ppgtt_clear as there is > nothing to clear and underlying code will complain with: > > [ 157.861645] gen8_pd_range:881 GEM_BUG_ON(start >= end) > > Signed

Re: [Intel-gfx] [PATCH] drm/i915: Hide unshrinkable context objects from the shrinker

2019-07-19 Thread Tvrtko Ursulin
On 19/07/2019 14:04, Chris Wilson wrote: The shrinker cannot touch objects used by the contexts (logical state and ring). Currently we mark those as "pin_global" to let the shrinker skip over them, however, if we remove them from the shrinker lists entirely, we don't event have to include them i

Re: [Intel-gfx] [PATCH 07/22] drm/i915/dmc: Load DMC on TGL

2019-07-19 Thread Lucas De Marchi
On Fri, Jul 19, 2019 at 04:14:27PM +0530, Anshuman Gupta wrote: On 2019-07-12 at 18:09:25 -0700, Lucas De Marchi wrote: From: Anusha Srivatsa Add Support to load DMC v2.02 on TGL. Signed-off-by: Anusha Srivatsa Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_csr.c | 7 +++

[Intel-gfx] [PATCH] drm/i915/gtt: Don't try to clear failed empty pd allocation

2019-07-19 Thread Michal Wajdeczko
When __gen8_ppgtt_alloc fails without allocating anything we should not try to call __gen8_ppgtt_clear as there is nothing to clear and underlying code will complain with: [ 157.861645] gen8_pd_range:881 GEM_BUG_ON(start >= end) Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Tvrtko Ursul

[Intel-gfx] [PATCH 3/3] drm/vkms: Reduce critical section in vblank_simulate

2019-07-19 Thread Daniel Vetter
We can reduce the critical section in vkms_vblank_simulate under output->lock quite a lot: - hrtimer_forward_now just needs to be ordered correctly wrt drm_crtc_handle_vblank. We already access the hrtimer timestamp without locks. While auditing that I noticed that we don't correctly annotat

[Intel-gfx] [PATCH 2/3] drm/vkms: Use wait_for_flip_done

2019-07-19 Thread Daniel Vetter
It's the recommended version, wait_for_vblanks is a bit a hacky interim thing that predates all the flip_done tracking. It's unfortunately still the default ... Signed-off-by: Daniel Vetter Cc: Rodrigo Siqueira Cc: Haneen Mohammed Cc: Daniel Vetter --- drivers/gpu/drm/vkms/vkms_drv.c | 2 +-

[Intel-gfx] [PATCH 1/3] drm/vblank: Document and fix vblank count barrier semantics

2019-07-19 Thread Daniel Vetter
Noticed while reviewing code. I'm not sure whether this might or might not explain some of the missed vblank hilarity we've been seeing. I think those all go through the vblank completion event, which has unconditional barriers - it always takes the spinlock. Therefore no cc stable. v2: - Barrrier

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/uc: Acknowledge successful firmware load to the user

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915/uc: Acknowledge successful firmware load to the user URL : https://patchwork.freedesktop.org/series/63946/ State : success == Summary == CI Bug Log - changes from CI_DRM_6511 -> Patchwork_13704 Summary

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Correct unshifted 'from' for gen8_ppgtt_alloc errors

2019-07-19 Thread Michal Wajdeczko
On Fri, 19 Jul 2019 15:15:24 +0200, Chris Wilson wrote: Since the underlying __gen8_ppgtt_clear takes the shifted address, we must remember to provide it with the preshifted original start address. Reported-by: Tvrtko Ursulin Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Abdiel Janul

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for MCR fixes and more

2019-07-19 Thread Tvrtko Ursulin
On 17/07/2019 20:18, Patchwork wrote: == Series Details == Series: MCR fixes and more URL : https://patchwork.freedesktop.org/series/63831/ State : success == Summary == CI Bug Log - changes from CI_DRM_6502 -> Patchwork_13676 Summary --

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for Revert GuC by default

2019-07-19 Thread Tvrtko Ursulin
On 19/07/2019 12:09, Patchwork wrote: == Series Details == Series: Revert GuC by default URL : https://patchwork.freedesktop.org/series/63934/ State : success == Summary == CI Bug Log - changes from CI_DRM_6509 -> Patchwork_13700 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: Correct unshifted 'from' for gen8_ppgtt_alloc errors

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Correct unshifted 'from' for gen8_ppgtt_alloc errors URL : https://patchwork.freedesktop.org/series/63945/ State : success == Summary == CI Bug Log - changes from CI_DRM_6511 -> Patchwork_13703 Sum

Re: [Intel-gfx] [PATCH] drm/i915/uc: Acknowledge successful firmware load to the user

2019-07-19 Thread Michal Wajdeczko
On Fri, 19 Jul 2019 16:14:27 +0200, Chris Wilson wrote: Let the user know that we have successfully loaded the firmware from the filesystem and downloaded it to the uC, with a info-level message. In the process, we can replace the random pointer print out and uninteresting debug events. Sign

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: Fix rounding for 36b

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Fix rounding for 36b URL : https://patchwork.freedesktop.org/series/63944/ State : success == Summary == CI Bug Log - changes from CI_DRM_6511 -> Patchwork_13702 Summary --- **SUCCESS** N

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Hide unshrinkable context objects from the shrinker

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915: Hide unshrinkable context objects from the shrinker URL : https://patchwork.freedesktop.org/series/63943/ State : success == Summary == CI Bug Log - changes from CI_DRM_6511 -> Patchwork_13701 Summary

[Intel-gfx] [PATCH] drm/i915/uc: Acknowledge successful firmware load to the user

2019-07-19 Thread Chris Wilson
Let the user know that we have successfully loaded the firmware from the filesystem and downloaded it to the uC, with a info-level message. In the process, we can replace the random pointer print out and uninteresting debug events. Signed-off-by: Chris Wilson Cc: Michal Wajdeczko Cc: Daniele Cer

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gtt: Fix rounding for 36b

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Fix rounding for 36b URL : https://patchwork.freedesktop.org/series/63944/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2262925a2845 drm/i915/gtt: Fix rounding for 36b -:27: WARNING:LINE_SPACING: Missing a blank line after declaration

Re: [Intel-gfx] [PATCH 04/22] drm/i915/tgl: Add hpd interrupt handling

2019-07-19 Thread Ville Syrjälä
On Fri, Jul 12, 2019 at 06:09:22PM -0700, Lucas De Marchi wrote: > Add hotdplug detection for all ports on TGP. icp_hpd_detection_setup() > is refactored to be shared with TGP. > > While we increase the number of pins, add a BUILD_BUG_ON() to avoid > going over the number of bits allowed. > > Cc:

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v13

2019-07-19 Thread Daniel Vetter
On Fri, Jul 19, 2019 at 12:05:36PM +, Koenig, Christian wrote: > Am 19.07.19 um 11:31 schrieb Daniel Vetter: > > On Fri, Jul 19, 2019 at 09:14:05AM +, Koenig, Christian wrote: > >> Am 19.07.19 um 10:57 schrieb Daniel Vetter: > >>> On Tue, Jul 16, 2019 at 04:21:53PM +0200, Christian König wr

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Correct unshifted 'from' for gen8_ppgtt_alloc errors

2019-07-19 Thread Tvrtko Ursulin
On 19/07/2019 14:15, Chris Wilson wrote: Since the underlying __gen8_ppgtt_clear takes the shifted address, we must remember to provide it with the preshifted original start address. Reported-by: Tvrtko Ursulin Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Abdiel Janulgue --- drivers

[Intel-gfx] [PATCH] drm/i915/gtt: Correct unshifted 'from' for gen8_ppgtt_alloc errors

2019-07-19 Thread Chris Wilson
Since the underlying __gen8_ppgtt_clear takes the shifted address, we must remember to provide it with the preshifted original start address. Reported-by: Tvrtko Ursulin Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Abdiel Janulgue --- drivers/gpu/drm/i915/i915_gem_gtt.c | 3 ++- 1 file

[Intel-gfx] [PATCH] drm/i915/gtt: Fix rounding for 36b

2019-07-19 Thread Chris Wilson
The top-level page directory for 36b is a single entry, not multiple like 32b. Fix up the rounding on the calculation of the size of the top level so that we populate the 4th level correctly for 36b. Reported-by: Jose Souza Signed-off-by: Chris Wilson Fixes: 1eda701eace2 ("drm/i915/gtt: Recursiv

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert GuC by default

2019-07-19 Thread Patchwork
== Series Details == Series: Revert GuC by default URL : https://patchwork.freedesktop.org/series/63934/ State : success == Summary == CI Bug Log - changes from CI_DRM_6509_full -> Patchwork_13700_full Summary --- **SUCCESS** No r

[Intel-gfx] [PATCH] drm/i915: Hide unshrinkable context objects from the shrinker

2019-07-19 Thread Chris Wilson
The shrinker cannot touch objects used by the contexts (logical state and ring). Currently we mark those as "pin_global" to let the shrinker skip over them, however, if we remove them from the shrinker lists entirely, we don't event have to include them in our shrink accounting. By keeping the uns

Re: [Intel-gfx] [PATCH -next] drm/i915/icl: Remove set but not used variable 'src_y'

2019-07-19 Thread Ville Syrjälä
On Fri, Jul 19, 2019 at 02:41:00AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/i915/display/intel_sprite.c: In function > 'g4x_sprite_check_scaling': > drivers/gpu/drm/i915/display/intel_sprite.c:1494:13: warning: > variable 'src_y' set but not u

Re: [Intel-gfx] [PATCH v2 2/5] drm/edid: Abstract away cea_edid_modes[]

2019-07-19 Thread Ville Syrjälä
On Fri, Jul 19, 2019 at 02:57:51PM +0300, Ville Syrjälä wrote: > On Fri, Jul 19, 2019 at 02:15:34PM +0530, Sharma, Shashank wrote: > > Hi Ville, > > > > On 7/11/2019 4:02 PM, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > We're going to need two cea mode tables (on for VICs < 128, > >

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v13

2019-07-19 Thread Koenig, Christian
Am 19.07.19 um 11:31 schrieb Daniel Vetter: > On Fri, Jul 19, 2019 at 09:14:05AM +, Koenig, Christian wrote: >> Am 19.07.19 um 10:57 schrieb Daniel Vetter: >>> On Tue, Jul 16, 2019 at 04:21:53PM +0200, Christian König wrote: Am 26.06.19 um 14:29 schrieb Daniel Vetter: [SNIP] >>> Well

Re: [Intel-gfx] [PATCH v2 2/5] drm/edid: Abstract away cea_edid_modes[]

2019-07-19 Thread Ville Syrjälä
On Fri, Jul 19, 2019 at 02:15:34PM +0530, Sharma, Shashank wrote: > Hi Ville, > > On 7/11/2019 4:02 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We're going to need two cea mode tables (on for VICs < 128, > > another one for VICs >= 193). To that end replace the direct > > edid_cea_mo

Re: [Intel-gfx] [PATCH 4/5] drm/i915/execlists: Cancel breadcrumb on preempting the virtual engine

2019-07-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 14:40:24) > > On 16/07/2019 13:49, Chris Wilson wrote: > > As we unwind the requests for a preemption event, we return a virtual > > request back to its original virtual engine (so that it is available for > > execution on any of its siblings). In the process, th

Re: [Intel-gfx] [PATCH] drm/i915: Flush all user surfaces prior to first use

2019-07-19 Thread kbuild test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20190719] [cannot apply to v5.2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [Intel-gfx] [PATCH 1/1] drm/vblank: drop use of DRM_WAIT_ON()

2019-07-19 Thread Sam Ravnborg
Hi Daniel. On Fri, Jul 19, 2019 at 11:39:26AM +0200, Daniel Vetter wrote: > On Thu, Jul 18, 2019 at 09:47:09PM +0200, Sam Ravnborg wrote: > > From e6f70cb90e0c3c90d45017a8257353652b7e0dcc Mon Sep 17 00:00:00 2001 > > From: Sam Ravnborg > > Date: Thu, 30 May 2019 09:38:47 +0200 > > Subject: [PATCH

Re: [Intel-gfx] [PATCH 0/2] Revert GuC by default

2019-07-19 Thread Michal Wajdeczko
On Fri, 19 Jul 2019 11:48:43 +0200, Tvrtko Ursulin wrote: From: Tvrtko Ursulin It seems absence of GuC fimrware breaks the boot in a bad way: https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/? https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/fi-icl-u2/boot0.log Hmm, for me looks

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert GuC by default

2019-07-19 Thread Patchwork
== Series Details == Series: Revert GuC by default URL : https://patchwork.freedesktop.org/series/63934/ State : success == Summary == CI Bug Log - changes from CI_DRM_6509 -> Patchwork_13700 Summary --- **SUCCESS** No regressions

Re: [Intel-gfx] [PATCH v1 11/11] drm: drop uapi dependency from drm_file.h

2019-07-19 Thread Sam Ravnborg
Hi Christian. Thanks for your comments and very valid question. On Fri, Jul 19, 2019 at 06:56:47AM +, Koenig, Christian wrote: > Am 18.07.19 um 18:15 schrieb Sam Ravnborg: > > drm_file used drm_magic_t from uapi/drm/drm.h. > > This is a simple unsigned int. > > Just opencode it as such to bre

Re: [Intel-gfx] [PATCH 07/22] drm/i915/dmc: Load DMC on TGL

2019-07-19 Thread Anshuman Gupta
On 2019-07-12 at 18:09:25 -0700, Lucas De Marchi wrote: > From: Anusha Srivatsa > > Add Support to load DMC v2.02 on TGL. > > Signed-off-by: Anusha Srivatsa > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/intel_csr.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Revert GuC by default

2019-07-19 Thread Patchwork
== Series Details == Series: Revert GuC by default URL : https://patchwork.freedesktop.org/series/63934/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5e4d613993b4 Revert "drm/i915/guc: Turn on GuC/HuC auto mode" -:33: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) tot

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Flush all user surfaces prior to first use

2019-07-19 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-19 11:18:42) > On 18/07/2019 17:54, Chris Wilson wrote: > > Since userspace has the ability to bypass the CPU cache from within its > > unprivileged command stream, we have to flush the CPU cache to memory > > in order to overwrite the previous contents on creatio

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Flush all user surfaces prior to first use

2019-07-19 Thread Lionel Landwerlin
On 18/07/2019 17:54, Chris Wilson wrote: Since userspace has the ability to bypass the CPU cache from within its unprivileged command stream, we have to flush the CPU cache to memory in order to overwrite the previous contents on creation. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: st

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Flush stale cachelines on set-cache-level

2019-07-19 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-07-18 17:54:07) > Ensure that we flush any cache dirt out to main memory before the user > changes the cache-level as they may elect to bypass the cache (even after > declaring their access cache-coherent) via use of unprivileged MOCS. > > Signed-off-by: Chris Wilson >

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Flush all user surfaces prior to first use

2019-07-19 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-07-18 17:54:06) > Since userspace has the ability to bypass the CPU cache from within its > unprivileged command stream, we have to flush the CPU cache to memory > in order to overwrite the previous contents on creation. > > Signed-off-by: Chris Wilson > Cc: Joonas Laht

Re: [Intel-gfx] [PATCH 0/2] Revert GuC by default

2019-07-19 Thread Joonas Lahtinen
Acked-by: Joonas Lahtinen Regards, Joonas Quoting Tvrtko Ursulin (2019-07-19 12:48:43) > From: Tvrtko Ursulin > > It seems absence of GuC fimrware breaks the boot in a bad way: > > https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/? > https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/fi

[Intel-gfx] [PATCH 0/2] Revert GuC by default

2019-07-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It seems absence of GuC fimrware breaks the boot in a bad way: https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/? https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/fi-icl-u2/boot0.log Tvrtko Ursulin (2): Revert "drm/i915/guc: Turn on GuC/HuC auto mode" Revert "dr

[Intel-gfx] [PATCH 1/2] Revert "drm/i915/guc: Turn on GuC/HuC auto mode"

2019-07-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This reverts commit f774f09649192f326fa030564afd3f8f5d82c1e4. If GuC firmware is not present on the filesystem driver crashes the machine on boot. Fixes: f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode") Cc: Michal Wajdeczko Cc: Jani Nikula Cc: Joonas Lahtinen Cc:

[Intel-gfx] [PATCH 2/2] Revert "drm/i915: Update description of i915.enable_guc modparam"

2019-07-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This reverts commit 0629d4da1f159778063767fb0ac1c951034c5477. If GuC firmware is not present on the filesystem driver crashes the machine on boot. Fixes: 0629d4da1f15 ("drm/i915: Update description of i915.enable_guc modparam") Cc: Tvrtko Ursulin Cc: Michal Wajdeczko Cc:

Re: [Intel-gfx] [PATCH 1/1] drm/vblank: drop use of DRM_WAIT_ON()

2019-07-19 Thread Daniel Vetter
On Thu, Jul 18, 2019 at 09:47:09PM +0200, Sam Ravnborg wrote: > From e6f70cb90e0c3c90d45017a8257353652b7e0dcc Mon Sep 17 00:00:00 2001 > From: Sam Ravnborg > Date: Thu, 30 May 2019 09:38:47 +0200 > Subject: [PATCH] drm/vblank: drop use of DRM_WAIT_ON() > > DRM_WAIT_ON() is from the deprecated drm

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v13

2019-07-19 Thread Daniel Vetter
On Fri, Jul 19, 2019 at 09:14:05AM +, Koenig, Christian wrote: > Am 19.07.19 um 10:57 schrieb Daniel Vetter: > > On Tue, Jul 16, 2019 at 04:21:53PM +0200, Christian König wrote: > >> Am 26.06.19 um 14:29 schrieb Daniel Vetter: > >>> On Wed, Jun 26, 2019 at 02:23:05PM +0200, Christian König wrot

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v13

2019-07-19 Thread Koenig, Christian
Am 19.07.19 um 10:57 schrieb Daniel Vetter: > On Tue, Jul 16, 2019 at 04:21:53PM +0200, Christian König wrote: >> Am 26.06.19 um 14:29 schrieb Daniel Vetter: >>> On Wed, Jun 26, 2019 at 02:23:05PM +0200, Christian König wrote: >>> [SNIP] >>> Also I looked at CI results and stuff, I guess you indeed

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add HDCP capability info to i915_display_info. (rev3)

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915: Add HDCP capability info to i915_display_info. (rev3) URL : https://patchwork.freedesktop.org/series/63819/ State : success == Summary == CI Bug Log - changes from CI_DRM_6508_full -> Patchwork_13699_full ==

Re: [Intel-gfx] [PATCH v3 3/3] drm/vgem: use normal cached mmap'ings

2019-07-19 Thread Daniel Vetter
On Tue, Jul 16, 2019 at 05:13:10PM -0700, Rob Clark wrote: > On Tue, Jul 16, 2019 at 4:39 PM Eric Anholt wrote: > > > > Rob Clark writes: > > > > > From: Rob Clark > > > > > > Since there is no real device associated with VGEM, it is impossible to > > > end up with appropriate dev->dma_ops, mean

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v13

2019-07-19 Thread Daniel Vetter
On Tue, Jul 16, 2019 at 04:21:53PM +0200, Christian König wrote: > Am 26.06.19 um 14:29 schrieb Daniel Vetter: > > On Wed, Jun 26, 2019 at 02:23:05PM +0200, Christian König wrote: > > > On the exporter side we add optional explicit pinning callbacks. If those > > > callbacks are implemented the fra

Re: [Intel-gfx] [PATCH v2 2/5] drm/edid: Abstract away cea_edid_modes[]

2019-07-19 Thread Sharma, Shashank
Hi Ville, On 7/11/2019 4:02 PM, Ville Syrjala wrote: From: Ville Syrjälä We're going to need two cea mode tables (on for VICs < 128, another one for VICs >= 193). To that end replace the direct edid_cea_modes[] lookups with a function call. And we'll rename the array to edid_cea_modes_0[] to i

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: Remove set but not used variable 'src_y'

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915/icl: Remove set but not used variable 'src_y' URL : https://patchwork.freedesktop.org/series/63923/ State : success == Summary == CI Bug Log - changes from CI_DRM_6508_full -> Patchwork_13698_full Summa

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dsi: remove set but not used variable 'hfront_porch'

2019-07-19 Thread Patchwork
== Series Details == Series: drm/i915/dsi: remove set but not used variable 'hfront_porch' URL : https://patchwork.freedesktop.org/series/63922/ State : success == Summary == CI Bug Log - changes from CI_DRM_6508_full -> Patchwork_13697_full