[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pmu: Atomically acquire the gt_pm wakeref (rev4)

2019-08-02 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Atomically acquire the gt_pm wakeref (rev4) URL : https://patchwork.freedesktop.org/series/64543/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6610_full -> Patchwork_13845_full Su

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: create a subfolder for GT debugfs

2019-08-02 Thread Patchwork
== Series Details == Series: drm/i915/gt: create a subfolder for GT debugfs URL : https://patchwork.freedesktop.org/series/64643/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h

[Intel-gfx] [RFC] drm/i915/gt: create a subfolder for GT debugfs

2019-08-02 Thread Daniele Ceraolo Spurio
The idea is to better organize our debugfs entries by moving the GT-related ones into their own subfolder, similarly to what we did for the kernel code. As an example, this patch moves the GuC/HuC and user_forcewake debugfs, but a few more files can be moved if we decide to go this way (engine sta

Re: [Intel-gfx] [PATCH 03/10] drm/i915: Use local variable for subslice_mask on HSW

2019-08-02 Thread Stuart Summers
On Fri, 2019-08-02 at 23:54 +0100, Chris Wilson wrote: > Quoting Stuart Summers (2019-08-02 23:47:00) > > On Fri, 2019-08-02 at 22:28 +0100, Chris Wilson wrote: > > > Quoting Stuart Summers (2019-08-02 21:51:27) > > > > Instead of assuming a single slice on HSW when defining > > > > subslices for t

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Get transcoder power domain before reading its register (rev2)

2019-08-02 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: Get transcoder power domain before reading its register (rev2) URL : https://patchwork.freedesktop.org/series/64639/ State : success == Summary == CI Bug Log - changes from CI_DRM_6619 -> Patchwork_13860

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Get transcoder power domain before reading its register

2019-08-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Get transcoder power domain before reading its register URL : https://patchwork.freedesktop.org/series/64571/ State : success == Summary == CI Bug Log - changes from CI_DRM_6608_full -> Patchwork_13844_full

Re: [Intel-gfx] [PATCH 03/10] drm/i915: Use local variable for subslice_mask on HSW

2019-08-02 Thread Chris Wilson
Quoting Stuart Summers (2019-08-02 23:47:00) > On Fri, 2019-08-02 at 22:28 +0100, Chris Wilson wrote: > > Quoting Stuart Summers (2019-08-02 21:51:27) > > > Instead of assuming a single slice on HSW when defining > > > subslices for the platform, use a local variable to set > > > the maximum subsli

Re: [Intel-gfx] [PATCH 01/10] drm/i915: Use variable for debugfs device status

2019-08-02 Thread Stuart Summers
On Fri, 2019-08-02 at 22:24 +0100, Chris Wilson wrote: > Quoting Stuart Summers (2019-08-02 21:51:25) > > Use a local variable to find SSEU runtime information > > in various debugfs functions. > > > > Signed-off-by: Stuart Summers > > --- > > @@ -3969,10 +3969,10 @@ static void > > broadwell_sse

Re: [Intel-gfx] [PATCH 03/10] drm/i915: Use local variable for subslice_mask on HSW

2019-08-02 Thread Stuart Summers
On Fri, 2019-08-02 at 22:28 +0100, Chris Wilson wrote: > Quoting Stuart Summers (2019-08-02 21:51:27) > > Instead of assuming a single slice on HSW when defining > > subslices for the platform, use a local variable to set > > the maximum subslices per slice. > > > > Signed-off-by: Stuart Summers

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915: Get transcoder power domain before reading its register (rev2)

2019-08-02 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: Get transcoder power domain before reading its register (rev2) URL : https://patchwork.freedesktop.org/series/64639/ State : warning == Summary == $ dim checkpatch origin/drm-tip e06ec8bb92f0 drm/i915: Get transcoder power d

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Hide unshrinkable context objects from the shrinker

2019-08-02 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Hide unshrinkable context objects from the shrinker URL : https://patchwork.freedesktop.org/series/64638/ State : success == Summary == CI Bug Log - changes from CI_DRM_6619 -> Patchwork_13859 ===

Re: [Intel-gfx] [PATCH v3 3/5] drm/i915/tgl: Define MOCS entries for Tigerlake

2019-08-02 Thread Atwood, Matthew S
On Tue, 2019-07-30 at 11:04 -0700, Lucas De Marchi wrote: > From: Tomasz Lis > > The MOCS table is published as part of bspec, and versioned. Entries > are supposed to never be modified, but new ones can be added. Adding > entries increases table version. The patch includes version 1 > entries. >

[Intel-gfx] [PATCH v3 2/2] drm/i915/tgl: Fix the read of the DDI that transcoder is attached to

2019-08-02 Thread José Roberto de Souza
On TGL this register do not map directly to port, it was already handled when setting it(TGL_TRANS_DDI_SELECT_PORT()) but not when reading it. v2: Adding TGL_PORT_TRANS_DDI_SELECT() so all future users can reuse it (Lucas) v3: Missed parentheses arround val (Jose) Cc: Lucas De Marchi Signed-off

[Intel-gfx] [PATCH v2 1/2] drm/i915: Get transcoder power domain before reading its register

2019-08-02 Thread José Roberto de Souza
When getting the pipes attached to encoder if it is not a eDP encoder it iterates over all pipes and read a transcoder register. But it should not read a transcoder register before get its power domain. It was not a issue in gens older than 12 because if it only had port A connected it would be at

[Intel-gfx] [PATCH v2 2/2] drm/i915/tgl: Fix the read of the DDI that transcoder is attached to

2019-08-02 Thread José Roberto de Souza
On TGL this register do not map directly to port, it was already handled when setting it(TGL_TRANS_DDI_SELECT_PORT()) but not when reading it. v2: Adding TGL_PORT_TRANS_DDI_SELECT() so all future users can reuse it (Lucas) Cc: Lucas De Marchi Signed-off-by: José Roberto de Souza --- drivers/gp

Re: [Intel-gfx] [PATCH 03/10] drm/i915: Use local variable for subslice_mask on HSW

2019-08-02 Thread Chris Wilson
Quoting Stuart Summers (2019-08-02 21:51:27) > Instead of assuming a single slice on HSW when defining > subslices for the platform, use a local variable to set > the maximum subslices per slice. > > Signed-off-by: Stuart Summers > --- > drivers/gpu/drm/i915/intel_device_info.c | 11 ++-

Re: [Intel-gfx] [PATCH 01/10] drm/i915: Use variable for debugfs device status

2019-08-02 Thread Chris Wilson
Quoting Stuart Summers (2019-08-02 21:51:25) > Use a local variable to find SSEU runtime information > in various debugfs functions. > > Signed-off-by: Stuart Summers > --- > @@ -3969,10 +3969,10 @@ static void broadwell_sseu_device_status(struct > drm_i915_private *dev_priv, > > if (s

[Intel-gfx] [CI 1/2] drm/i915: Hide unshrinkable context objects from the shrinker

2019-08-02 Thread Chris Wilson
The shrinker cannot touch objects used by the contexts (logical state and ring). Currently we mark those as "pin_global" to let the shrinker skip over them, however, if we remove them from the shrinker lists entirely, we don't event have to include them in our shrink accounting. By keeping the uns

[Intel-gfx] [CI 2/2] drm/i915: Flush the freed object list on file close

2019-08-02 Thread Chris Wilson
As we increase the number of RCU objects, it becomes easier for us to have several hundred thousand objects in the deferred RCU free queues. An example is gem_ctx_create/files which continually creates active contexts, which are not immediately freed upon close as they are kept alive by outstanding

[Intel-gfx] ✓ Fi.CI.BAT: success for Refactor to expand subslice mask (rev 2)

2019-08-02 Thread Patchwork
== Series Details == Series: Refactor to expand subslice mask (rev 2) URL : https://patchwork.freedesktop.org/series/64636/ State : success == Summary == CI Bug Log - changes from CI_DRM_6618 -> Patchwork_13858 Summary --- **SUCCESS*

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Refactor to expand subslice mask (rev 2)

2019-08-02 Thread Patchwork
== Series Details == Series: Refactor to expand subslice mask (rev 2) URL : https://patchwork.freedesktop.org/series/64636/ State : warning == Summary == $ dim checkpatch origin/drm-tip b6ccbffe3ad2 drm/i915: Use variable for debugfs device status 2caf5e999b9f drm/i915: Add function to set SSE

[Intel-gfx] [PATCH 02/10] drm/i915: Add function to set SSEU info per platform

2019-08-02 Thread Stuart Summers
Add a new function to allow each platform to set maximum slice, subslice, and EU information to reduce code duplication. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_sseu.c | 8 + drivers/gpu/drm/i915/gt/intel_sseu.h | 3 ++ drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [PATCH 00/10] Refactor to expand subslice mask (rev 2)

2019-08-02 Thread Stuart Summers
Currently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is then calculated: slice * subslice stride + subslice i

[Intel-gfx] [PATCH 09/10] drm/i915: Add new function to copy subslices for a slice

2019-08-02 Thread Stuart Summers
Add a new function to copy subslices for a specified slice between intel_sseu structures for the purpose of determining power-gate status. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/i915_debugfs.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --gi

[Intel-gfx] [PATCH 06/10] drm/i915: Add function to set subslices

2019-08-02 Thread Stuart Summers
Add a new function to set a range of subslices for a specified slice based on a given mask. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_sseu.c | 10 ++ drivers/gpu/drm/i915/gt/intel_sseu.h | 3 ++ drivers/gpu/drm/i915/intel_device_info.c | 46 ++--

[Intel-gfx] [PATCH 01/10] drm/i915: Use variable for debugfs device status

2019-08-02 Thread Stuart Summers
Use a local variable to find SSEU runtime information in various debugfs functions. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/i915_debugfs.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/

[Intel-gfx] [PATCH 10/10] drm/i915: Expand subslice mask

2019-08-02 Thread Stuart Summers
Currently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is then calculated: slice * subslice stride + subslice i

[Intel-gfx] [PATCH 07/10] drm/i915: Add function to determine if a slice has a subslice

2019-08-02 Thread Stuart Summers
Add a new function to determine whether a particular slice has a given subslice. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_sseu.h | 10 ++ drivers/gpu/drm/i915/intel_device_info.c | 9 - 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH 03/10] drm/i915: Use local variable for subslice_mask on HSW

2019-08-02 Thread Stuart Summers
Instead of assuming a single slice on HSW when defining subslices for the platform, use a local variable to set the maximum subslices per slice. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/intel_device_info.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --gi

[Intel-gfx] [PATCH 05/10] drm/i915: Add EU stride runtime parameter

2019-08-02 Thread Stuart Summers
Add a new SSEU runtime parameter, eu_stride, which is used to mirror the userspace concept of a range of EUs per subslice. This patch simply adds the parameter and updates usage in the QUERY_TOPOLOGY_INFO handler. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_sseu.c | 1 +

[Intel-gfx] [PATCH 08/10] drm/i915: Refactor instdone loops on new subslice functions

2019-08-02 Thread Stuart Summers
Refactor instdone loops to use the new intel_sseu_has_subslice function. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_engine_cs.c| 3 +- drivers/gpu/drm/i915/gt/intel_engine_types.h | 31 ++-- drivers/gpu/drm/i915/gt/intel_hangcheck.c| 3 +- drivers/g

[Intel-gfx] [PATCH 04/10] drm/i915: Add subslice stride runtime parameter

2019-08-02 Thread Stuart Summers
Add a new parameter, ss_stride, to the runtime info structure. This is used to mirror the userspace concept of subslice stride, which is a range of subslices per slice. This patch simply adds the definition and updates usage in the QUERY_TOPOLOGY_INFO handler. Signed-off-by: Stuart Summers ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Separate pinning of pages from i915_vma_insert()

2019-08-02 Thread Patchwork
== Series Details == Series: drm/i915: Separate pinning of pages from i915_vma_insert() URL : https://patchwork.freedesktop.org/series/64635/ State : success == Summary == CI Bug Log - changes from CI_DRM_6618 -> Patchwork_13857 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Separate pinning of pages from i915_vma_insert()

2019-08-02 Thread Chris Wilson
Quoting Prathap Kumar Valsan (2019-08-02 21:41:11) > Currently i915_vma_insert() is responsible for allocating drm mm node > and also allocating or gathering physical pages. Move the latter to a > separate function for better readability. Close but if you look at the mutex patches, you'll see why

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for add more probe failures

2019-08-02 Thread Chris Wilson
Quoting Patchwork (2019-08-02 20:37:52) > == Series Details == > > Series: add more probe failures > URL : https://patchwork.freedesktop.org/series/64629/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_6618 -> Patchwork_13856 >

[Intel-gfx] [PATCH] drm/i915: Separate pinning of pages from i915_vma_insert()

2019-08-02 Thread Prathap Kumar Valsan
Currently i915_vma_insert() is responsible for allocating drm mm node and also allocating or gathering physical pages. Move the latter to a separate function for better readability. Signed-off-by: Prathap Kumar Valsan --- drivers/gpu/drm/i915/i915_vma.c | 76 +++-- dr

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/pmu: Atomically acquire the gt_pm wakeref

2019-08-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pmu: Atomically acquire the gt_pm wakeref URL : https://patchwork.freedesktop.org/series/64562/ State : success == Summary == CI Bug Log - changes from CI_DRM_6607_full -> Patchwork_13842_full ===

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on TGL

2019-08-02 Thread Souza, Jose
On Fri, 2019-08-02 at 11:38 -0700, Lucas De Marchi wrote: > From: Anusha Srivatsa > > Add Support to load DMC v2.03 on TGL. > > v2: Use version 2.03 that is already available since that works with > PSR2 Still not available on https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-

Re: [Intel-gfx] [PATCH 15/17] drm/i915: Flush the freed object list on file close

2019-08-02 Thread Chris Wilson
Quoting Matthew Auld (2019-08-02 18:00:51) > On Tue, 30 Jul 2019 at 14:48, Chris Wilson wrote: > > > > Signed-off-by: Chris Wilson > > In need of a proper commit message. 'Twas brillig, and the slithy toves Did gyre and grimble in the wable: All mimsy were the borogoves... The problem that we

Re: [Intel-gfx] [PATCH v7 4/6] drm/i915/uc: Move GuC error log to uc and release it on fini

2019-08-02 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-02 19:40:53) > When we fail to load GuC and want to abort probe, we hit: > > <7> [229.915779] i915 :00:02.0: [drm:intel_uc_init_hw [i915]] GuC > initialization failed -6 > <7> [229.915813] i915 :00:02.0: [drm:i915_gem_init_hw [i915]] Enabling uc > failed

Re: [Intel-gfx] [PATCH v7 3/6] drm/i915/uc: Reorder firmware status codes

2019-08-02 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-02 19:40:52) > On Gen9 when we try to reload HuC due to GuC upload error, we hit: > > <7> [232.025927] [drm:intel_uc_init_hw [i915]] GuC fw load failed: -8; will > reset and retry 2 more time(s) > <7> [232.026004] [drm:intel_uc_fw_upload [i915]] HuC fw load > i9

[Intel-gfx] ✓ Fi.CI.BAT: success for add more probe failures

2019-08-02 Thread Patchwork
== Series Details == Series: add more probe failures URL : https://patchwork.freedesktop.org/series/64629/ State : success == Summary == CI Bug Log - changes from CI_DRM_6618 -> Patchwork_13856 Summary --- **SUCCESS** No regressio

Re: [Intel-gfx] [PATCH v7 2/6] drm/i915/uc: Do full sanitize instead of pure reset

2019-08-02 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-02 19:40:51) > On Gen9 when we try to reload HuC due to GuC upload error, we hit: > > <7> [229.656688] [drm:intel_uc_init_hw [i915]] GuC fw load failed: -8; will > reset and retry 2 more time(s) > <7> [229.656739] [drm:intel_uc_fw_upload [i915]] HuC fw load > i9

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Load DMC on TGL

2019-08-02 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Load DMC on TGL URL : https://patchwork.freedesktop.org/series/64628/ State : success == Summary == CI Bug Log - changes from CI_DRM_6618 -> Patchwork_13855 Summary --- **SUCCESS** No reg

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for add more probe failures

2019-08-02 Thread Patchwork
== Series Details == Series: add more probe failures URL : https://patchwork.freedesktop.org/series/64629/ State : warning == Summary == $ dim checkpatch origin/drm-tip 75b2500aa733 drm/i915: Add i915 to i915_inject_probe_failure 8314c03ba836 drm/i915/uc: Do full sanitize instead of pure reset

Re: [Intel-gfx] [PATCH] drm/i915: Report resv_obj allocation failure

2019-08-02 Thread Daniel Vetter
On Fri, Aug 2, 2019 at 5:06 PM Chris Wilson wrote: > > Quoting Matthew Auld (2019-08-02 16:00:18) > > On Tue, 30 Jul 2019 at 21:58, Chris Wilson wrote: > > > > > > Since commit 64d6c500a384 ("drm/i915: Generalise GPU activity > > > tracking"), we have been prepared for i915_vma_move_to_active() t

[Intel-gfx] [PATCH v7 0/6] add more probe failures

2019-08-02 Thread Michal Wajdeczko
v3: fix Gen9 issue discovered by the v2 v4: rebased v5: more injected errors and more fixes v7: hot fixes moved to separate patches Michal Wajdeczko (6): drm/i915: Add i915 to i915_inject_probe_failure drm/i915/uc: Do full sanitize instead of pure reset drm/i915/uc: Reorder firmware status c

[Intel-gfx] [PATCH v7 5/6] drm/i915/uc: Inject probe errors into intel_uc_init_hw

2019-08-02 Thread Michal Wajdeczko
Inject probe errors into intel_uc_init_hw to make sure we correctly handle any uC initialization failure. To avoid complains from CI about injected errors use i915_probe_error to lower message level. v4: rebased after moving hot fixes moved to separate patches Signed-off-by: Michal Wajdeczko Cc

[Intel-gfx] [PATCH v7 4/6] drm/i915/uc: Move GuC error log to uc and release it on fini

2019-08-02 Thread Michal Wajdeczko
When we fail to load GuC and want to abort probe, we hit: <7> [229.915779] i915 :00:02.0: [drm:intel_uc_init_hw [i915]] GuC initialization failed -6 <7> [229.915813] i915 :00:02.0: [drm:i915_gem_init_hw [i915]] Enabling uc failed (-6) <4> [229.953354] [ cut here ]

[Intel-gfx] [PATCH v7 6/6] drm/i915/wopcm: Don't fail on WOPCM partitioning failure

2019-08-02 Thread Michal Wajdeczko
We don't have to immediately fail on WOPCM partitioning, we can wait until we will start programming WOPCM registers. This should give us more options if we decide to restore fallback in case of GuC failures. v3: rebased Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Chris Wilso

[Intel-gfx] [PATCH v7 2/6] drm/i915/uc: Do full sanitize instead of pure reset

2019-08-02 Thread Michal Wajdeczko
On Gen9 when we try to reload HuC due to GuC upload error, we hit: <7> [229.656688] [drm:intel_uc_init_hw [i915]] GuC fw load failed: -8; will reset and retry 2 more time(s) <7> [229.656739] [drm:intel_uc_fw_upload [i915]] HuC fw load i915/kbl_huc_ver02_00_1810.bin <3> [229.656740] intel_uc_fw_u

[Intel-gfx] [PATCH v7 1/6] drm/i915: Add i915 to i915_inject_probe_failure

2019-08-02 Thread Michal Wajdeczko
With i915 added to i915_inject_probe_failure we can use dedicated printk when injecting artificial load failure. Also make this function look like other i915 functions that return error code and make it more flexible to return any provided error code instead of previously assumed -ENODEV. Signed-

[Intel-gfx] [PATCH v7 3/6] drm/i915/uc: Reorder firmware status codes

2019-08-02 Thread Michal Wajdeczko
On Gen9 when we try to reload HuC due to GuC upload error, we hit: <7> [232.025927] [drm:intel_uc_init_hw [i915]] GuC fw load failed: -8; will reset and retry 2 more time(s) <7> [232.026004] [drm:intel_uc_fw_upload [i915]] HuC fw load i915/kbl_huc_ver02_00_1810.bin <7> [232.026686] [drm:intel_uc

[Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on TGL

2019-08-02 Thread Lucas De Marchi
From: Anusha Srivatsa Add Support to load DMC v2.03 on TGL. v2: Use version 2.03 that is already available since that works with PSR2 Signed-off-by: Anusha Srivatsa Signed-off-by: Lucas De Marchi Reviewed-by: Matt Atwood --- drivers/gpu/drm/i915/intel_csr.c | 7 +++ 1 file changed,

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for add more probe failures (rev6)

2019-08-02 Thread Michal Wajdeczko
On Fri, 02 Aug 2019 20:07:22 +0200, Daniele Ceraolo Spurio wrote: On 8/2/19 10:02 AM, Michal Wajdeczko wrote: On Fri, 02 Aug 2019 15:30:19 +0200, Chris Wilson wrote: Quoting Patchwork (2019-08-02 14:12:38) == Series Details == Series: add more probe failures (rev6) URL : https://p

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for add more probe failures (rev6)

2019-08-02 Thread Daniele Ceraolo Spurio
On 8/2/19 10:02 AM, Michal Wajdeczko wrote: On Fri, 02 Aug 2019 15:30:19 +0200, Chris Wilson wrote: Quoting Patchwork (2019-08-02 14:12:38) == Series Details == Series: add more probe failures (rev6) URL   : https://patchwork.freedesktop.org/series/64390/ State : failure == Summary == C

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/4] drm/i915/pmu: Make more struct i915_pmu centric

2019-08-02 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915/pmu: Make more struct i915_pmu centric URL : https://patchwork.freedesktop.org/series/64557/ State : success == Summary == CI Bug Log - changes from CI_DRM_6606_full -> Patchwork_13841_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/syncobj: Convert syncobj_idr to XArray

2019-08-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/syncobj: Convert syncobj_idr to XArray URL : https://patchwork.freedesktop.org/series/64620/ State : success == Summary == CI Bug Log - changes from CI_DRM_6618 -> Patchwork_13854

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for add more probe failures (rev6)

2019-08-02 Thread Michal Wajdeczko
On Fri, 02 Aug 2019 15:30:19 +0200, Chris Wilson wrote: Quoting Patchwork (2019-08-02 14:12:38) == Series Details == Series: add more probe failures (rev6) URL : https://patchwork.freedesktop.org/series/64390/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6614 -> Patchw

Re: [Intel-gfx] [PATCH 15/17] drm/i915: Flush the freed object list on file close

2019-08-02 Thread Matthew Auld
On Tue, 30 Jul 2019 at 14:48, Chris Wilson wrote: > > Signed-off-by: Chris Wilson In need of a proper commit message. Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/

[Intel-gfx] [PATCH 2/2] drm/syncobj: Lookup the syncobj with RCU protection

2019-08-02 Thread Chris Wilson
Relax the spinlock used for looking up the handle in the XArray and acquiring a reference to it to an RCU protected critical section. This incurs the requirement that we protect the syncobj struct itself using RCU, which we achieve by simply calling kfree_rcu() and being more careful in acquiring o

[Intel-gfx] [PATCH 1/2] drm/syncobj: Convert syncobj_idr to XArray

2019-08-02 Thread Chris Wilson
Prior to making the syncobj lookup lockless, update the idr to the new XArray API. Based on a patch by Matthew Wilcox Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_syncobj.c | 64 ++- include/drm/drm_file.h| 7 ++-- 2 files changed, 21 insertions(+

Re: [Intel-gfx] [PATCH 20/34] xen: convert put_page() to put_user_page*()

2019-08-02 Thread Weiny, Ira
> > On 02.08.19 07:48, John Hubbard wrote: > > On 8/1/19 9:36 PM, Juergen Gross wrote: > >> On 02.08.19 04:19, john.hubb...@gmail.com wrote: > >>> From: John Hubbard > > ... > >>> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index > >>> 2f5ce7230a43..29e461dbee2d 100644 > >>> --- a/

Re: [Intel-gfx] [PATCH 10/17] drm/i915: Hide unshrinkable context objects from the shrinker

2019-08-02 Thread Matthew Auld
On Tue, 30 Jul 2019 at 14:31, Chris Wilson wrote: > > The shrinker cannot touch objects used by the contexts (logical state > and ring). Currently we mark those as "pin_global" to let the shrinker > skip over them, however, if we remove them from the shrinker lists > entirely, we don't event have

[Intel-gfx] ✓ Fi.CI.IGT: success for Don't sanitize enable_guc (rev4)

2019-08-02 Thread Patchwork
== Series Details == Series: Don't sanitize enable_guc (rev4) URL : https://patchwork.freedesktop.org/series/64446/ State : success == Summary == CI Bug Log - changes from CI_DRM_6605_full -> Patchwork_13837_full Summary --- **SUCCES

Re: [Intel-gfx] [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h

2019-08-02 Thread Sam Ravnborg
Hi Jani. > >> I mean is it useful to have this extra printing subsystem in DRM while > >> the standard Linux one actually does a better job? > > The added functionality of drm_xxx_err would be to keep the current > > drm.debug=0x1f filtering on the command-line. > > I do not think we can do this

Re: [Intel-gfx] [PULL] drm-misc-fixes

2019-08-02 Thread Daniel Vetter
On Fri, Aug 02, 2019 at 03:43:48PM +0200, Maarten Lankhorst wrote: > Hey, > > Bit late, but fixes for v5.3-rc3. :) Yes, please try to prep and send out -fixes pull on Thu latest. Otherwise there's no time to fix things up and it eats into w/e ... > > drm-misc-fixes-2019-08-02: > drm-misc-fixes

Re: [Intel-gfx] [PATCH] Revert "drm/vgem: fix cache synchronization on arm/arm64"

2019-08-02 Thread Daniel Vetter
On Fri, Aug 02, 2019 at 10:18:10AM -0400, Sean Paul wrote: > On Thu, Aug 01, 2019 at 01:44:58PM +0100, Chris Wilson wrote: > > commit 7e9e5ead55be ("drm/vgem: fix cache synchronization on arm/arm64") > > broke all of the !llc i915-vgem coherency tests in CI, and left the HW > > very, very unhappy (

Re: [Intel-gfx] [PATCH] drm/i915: Report resv_obj allocation failure

2019-08-02 Thread Chris Wilson
Quoting Matthew Auld (2019-08-02 16:00:18) > On Tue, 30 Jul 2019 at 21:58, Chris Wilson wrote: > > > > Since commit 64d6c500a384 ("drm/i915: Generalise GPU activity > > tracking"), we have been prepared for i915_vma_move_to_active() to fail. > > We can take advantage of this to report the failure

Re: [Intel-gfx] [PATCH] drm/i915: Report resv_obj allocation failure

2019-08-02 Thread Matthew Auld
On Tue, 30 Jul 2019 at 21:58, Chris Wilson wrote: > > Since commit 64d6c500a384 ("drm/i915: Generalise GPU activity > tracking"), we have been prepared for i915_vma_move_to_active() to fail. > We can take advantage of this to report the failure for allocating the > shared-fence slot in the reserva

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Drop the fudge warning on ring restart for ctg/elk

2019-08-02 Thread Patchwork
== Series Details == Series: drm/i915: Drop the fudge warning on ring restart for ctg/elk URL : https://patchwork.freedesktop.org/series/64546/ State : success == Summary == CI Bug Log - changes from CI_DRM_6605_full -> Patchwork_13836_full

Re: [Intel-gfx] [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-02 Thread Jan Kara
On Fri 02-08-19 07:24:43, Matthew Wilcox wrote: > On Fri, Aug 02, 2019 at 02:41:46PM +0200, Jan Kara wrote: > > On Fri 02-08-19 11:12:44, Michal Hocko wrote: > > > On Thu 01-08-19 19:19:31, john.hubb...@gmail.com wrote: > > > [...] > > > > 2) Convert all of the call sites for get_user_pages*(), to

Re: [Intel-gfx] [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-02 Thread Matthew Wilcox
On Fri, Aug 02, 2019 at 02:41:46PM +0200, Jan Kara wrote: > On Fri 02-08-19 11:12:44, Michal Hocko wrote: > > On Thu 01-08-19 19:19:31, john.hubb...@gmail.com wrote: > > [...] > > > 2) Convert all of the call sites for get_user_pages*(), to > > > invoke put_user_page*(), instead of put_page(). This

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Flush any deferred RCU cleanup before switching off GEM (rev2)

2019-08-02 Thread Patchwork
== Series Details == Series: drm/i915: Flush any deferred RCU cleanup before switching off GEM (rev2) URL : https://patchwork.freedesktop.org/series/64612/ State : success == Summary == CI Bug Log - changes from CI_DRM_6615 -> Patchwork_13852 ===

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] i915: convert to new mount API (rev2)

2019-08-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] i915: convert to new mount API (rev2) URL : https://patchwork.freedesktop.org/series/64607/ State : failure == Summary == Applying: i915: convert to new mount API Applying: i915: do not leak module ref counter Using index info to reconstr

Re: [Intel-gfx] [PATCH 26/34] mm/gup_benchmark.c: convert put_page() to put_user_page*()

2019-08-02 Thread Keith Busch
On Thu, Aug 01, 2019 at 07:19:57PM -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversio

Re: [Intel-gfx] [PATCH] Revert "drm/vgem: fix cache synchronization on arm/arm64"

2019-08-02 Thread Sean Paul
On Thu, Aug 01, 2019 at 01:44:58PM +0100, Chris Wilson wrote: > commit 7e9e5ead55be ("drm/vgem: fix cache synchronization on arm/arm64") > broke all of the !llc i915-vgem coherency tests in CI, and left the HW > very, very unhappy (which is even more scary). > > Fixes: 7e9e5ead55be ("drm/vgem: fix

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "drm/vgem: fix cache synchronization on arm/arm64"

2019-08-02 Thread Patchwork
== Series Details == Series: Revert "drm/vgem: fix cache synchronization on arm/arm64" URL : https://patchwork.freedesktop.org/series/64544/ State : success == Summary == CI Bug Log - changes from CI_DRM_6605_full -> Patchwork_13835_full Su

Re: [Intel-gfx] [PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Chris Wilson
Quoting Sergey Senozhatsky (2019-08-02 14:49:55) > On (08/02/19 14:41), Chris Wilson wrote: > [..] > > struct vfsmount *kern_mount(struct file_system_type *type) > > { > > struct vfsmount *mnt; > > mnt = vfs_kern_mount(type, SB_KERNMOUNT, type->name, NULL); > > if (!IS_ERR(m

Re: [Intel-gfx] [PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Sergey Senozhatsky
On (08/02/19 14:41), Chris Wilson wrote: [..] > struct vfsmount *kern_mount(struct file_system_type *type) > { > struct vfsmount *mnt; > mnt = vfs_kern_mount(type, SB_KERNMOUNT, type->name, NULL); > if (!IS_ERR(mnt)) { > /* > * it is a longte

Re: [Intel-gfx] [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h

2019-08-02 Thread Jani Nikula
On Mon, 29 Jul 2019, Sam Ravnborg wrote: > Hi Christian. > > On Mon, Jul 29, 2019 at 03:28:15PM +, Koenig, Christian wrote: >> Am 29.07.19 um 16:35 schrieb Sam Ravnborg: >> Even then it so useless (which drm driver is this message for???) that I >> want to remove them all :( >> >>> Y

[Intel-gfx] [PULL] drm-misc-fixes

2019-08-02 Thread Maarten Lankhorst
Hey, Bit late, but fixes for v5.3-rc3. :) drm-misc-fixes-2019-08-02: drm-misc-fixes for v5.3-rc3: - Fix some build errors in drm/bridge. - Do not build i810 on CONFIG_PREEMPTION. - Fix cache sync on arm in vgem. - Allow mapping fb in drm_client only when required, and use it to fix bochs fbdev.

Re: [Intel-gfx] [PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Chris Wilson
Quoting Sergey Senozhatsky (2019-08-02 14:35:03) > On (08/02/19 22:15), Sergey Senozhatsky wrote: > [..] > > > > Looking around, it looks like we always need to drop type after > > > > mounting. Should the > > > > put_filesystem(type); > > > > be here instead? > > > > > > > > Anyway, nice

Re: [Intel-gfx] [PULL] drm-intel-fixes

2019-08-02 Thread Gerd Hoffmann
Hi, > I apologize for not having fixes for a couple of weeks, and then showing > up late with a bunch of them. I saw Dave make the fixes pull to Linus > for -rc3 already, but I must humbly ask you to accommodate an extra > fixes pull. If there is an extra -rc3 fixes pull anyway it would be nice

[Intel-gfx] [PATCH] drm/i915: Flush any deferred RCU cleanup before switching off GEM

2019-08-02 Thread Chris Wilson
On module load, if we fail to initialise GEM, we will try to keep the module alive (so that we can bring KMS up to keep the system usable). However, if we outright fail to load and choose to abort the module, we have to flush the GEM deferred cleanup before reporting that failure. Signed-off-by: C

Re: [Intel-gfx] [PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Sergey Senozhatsky
On (08/02/19 22:15), Sergey Senozhatsky wrote: [..] > > > Looking around, it looks like we always need to drop type after > > > mounting. Should the > > > put_filesystem(type); > > > be here instead? > > > > > > Anyway, nice catch. > > > > Sigh. put_filesystem() is part of fs internals. I

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Flush any deferred RCU cleanup before switching off GEM

2019-08-02 Thread Patchwork
== Series Details == Series: drm/i915: Flush any deferred RCU cleanup before switching off GEM URL : https://patchwork.freedesktop.org/series/64612/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/gen

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for add more probe failures (rev6)

2019-08-02 Thread Chris Wilson
Quoting Patchwork (2019-08-02 14:12:38) > == Series Details == > > Series: add more probe failures (rev6) > URL : https://patchwork.freedesktop.org/series/64390/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_6614 -> Patchwork_13848 > =

[Intel-gfx] [PATCH] drm/i915: Flush any deferred RCU cleanup before switching off GEM

2019-08-02 Thread Chris Wilson
On module load, if we fail to initialise GEM, we will try to keep the module alive (so that we can bring KMS up to keep the system usable). However, if we outright fail to load and choose to abort the module, we have to flush the GEM deferred cleanup before reporting that failure. Signed-off-by: C

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix documentation for __intel_wait_for_register_fw*

2019-08-02 Thread Patchwork
== Series Details == Series: drm/i915: Fix documentation for __intel_wait_for_register_fw* URL : https://patchwork.freedesktop.org/series/64608/ State : success == Summary == CI Bug Log - changes from CI_DRM_6614 -> Patchwork_13850 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for PMU update for more than one card

2019-08-02 Thread Patchwork
== Series Details == Series: PMU update for more than one card URL : https://patchwork.freedesktop.org/series/64530/ State : success == Summary == CI Bug Log - changes from CI_DRM_6605_full -> Patchwork_13833_full Summary --- **SUCCE

Re: [Intel-gfx] [PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Sergey Senozhatsky
On (08/02/19 14:10), Chris Wilson wrote: > > > drivers/gpu/drm/i915/gem/i915_gemfs.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c > > > b/drivers/gpu/drm/i915/gem/i915_gemfs.c > > > index cf05ba72df9d..d437188d1736

[Intel-gfx] ✗ Fi.CI.BAT: failure for add more probe failures (rev6)

2019-08-02 Thread Patchwork
== Series Details == Series: add more probe failures (rev6) URL : https://patchwork.freedesktop.org/series/64390/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6614 -> Patchwork_13848 Summary --- **FAILURE** Serio

Re: [Intel-gfx] [PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Chris Wilson
Quoting Chris Wilson (2019-08-02 13:58:36) > Quoting Sergey Senozhatsky (2019-08-02 13:39:56) > > put_filesystem() before i915_gemfs_init() deals with > > kern_mount() error. > > > > Signed-off-by: Sergey Senozhatsky > > --- > > drivers/gpu/drm/i915/gem/i915_gemfs.c | 4 +++- > > 1 file changed,

Re: [Intel-gfx] [PATCH 1/2] i915: convert to new mount API

2019-08-02 Thread Sergey Senozhatsky
On (08/02/19 13:54), Chris Wilson wrote: [..] > > int i915_gemfs_init(struct drm_i915_private *i915) > > { > > + struct fs_context *fc = NULL; > > struct file_system_type *type; > > struct vfsmount *gemfs; > > + bool ok = true; > > Start with ok = false, we only need

Re: [Intel-gfx] [PATCH] drm/i915: Fix documentation for __intel_wait_for_register_fw*

2019-08-02 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-02 13:47:39) > Use section name "Return" and proper error code -ETIMEDOUT Quicker way is use a gray:gray colorscheme for comments :-p > Signed-off-by: Michal Wajdeczko Reviewed-by: Chris Wilson -Chris ___ Intel-gfx ma

Re: [Intel-gfx] [PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Chris Wilson
Quoting Sergey Senozhatsky (2019-08-02 13:39:56) > put_filesystem() before i915_gemfs_init() deals with > kern_mount() error. > > Signed-off-by: Sergey Senozhatsky > --- > drivers/gpu/drm/i915/gem/i915_gemfs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/g

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] i915: convert to new mount API

2019-08-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] i915: convert to new mount API URL : https://patchwork.freedesktop.org/series/64607/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/c

Re: [Intel-gfx] [PATCH 1/2] i915: convert to new mount API

2019-08-02 Thread Chris Wilson
Quoting Sergey Senozhatsky (2019-08-02 13:39:55) > tmpfs does not set ->remount_fs() anymore and its users need > to be converted to new mount API. > > BUG: kernel NULL pointer dereference, address: > PF: supervisor instruction fetch in kernel mode > PF: error_code(0x0010) - no

[Intel-gfx] [PATCH] drm/i915: Fix documentation for __intel_wait_for_register_fw*

2019-08-02 Thread Michal Wajdeczko
Use section name "Return" and proper error code -ETIMEDOUT Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/intel_uncore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index 2b839acfa0f6

  1   2   >