[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Check for a second VCS engine more carefully

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Check for a second VCS engine more carefully URL : https://patchwork.freedesktop.org/series/64938/ State : success == Summary == CI Bug Log - changes from CI_DRM_6660 -> Patchwork_13930 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for convert i915 to new mount API (rev2)

2019-08-08 Thread Patchwork
== Series Details == Series: convert i915 to new mount API (rev2) URL : https://patchwork.freedesktop.org/series/64720/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6657_full -> Patchwork_13921_full Summary ---

[Intel-gfx] [PATCH] drm/i915: Check for a second VCS engine more carefully

2019-08-08 Thread Chris Wilson
To use the legacy BSD selector, you must have a second VCS engine, or else the ABI simply maps the request for another engine onto VCS0. However, we only checked a single VCS1 location and overlooking the possibility of a sparse VCS set being mapped to the dense ABI. Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+

2019-08-08 Thread Jason Ekstrand
Also, I think we can provide a better commit message. I'll type something in the morning when I can actually look stuff up and provide correct references. On August 8, 2019 12:33:15 Jason Ekstrand wrote: Note: This doesn't actually fix 110998. I can still get a hard-hang with a slightly

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Defer final intel_wakeref_put to process context

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Defer final intel_wakeref_put to process context URL : https://patchwork.freedesktop.org/series/64916/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6657_full -> Patchwork_13920_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Only include active engines in the capture state

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Only include active engines in the capture state URL : https://patchwork.freedesktop.org/series/64914/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6657_full -> Patchwork_13919_full

Re: [Intel-gfx] [PATCH] drm/i915: Use after free in error path in intel_vgpu_create_workload()

2019-08-08 Thread Zhenyu Wang
On 2019.08.08 11:44:21 +0100, Chris Wilson wrote: > Quoting Dan Carpenter (2019-08-08 11:32:36) > > We can't free "workload" until after the printk or it's a use after > > free. > > > > Fixes: 2089a76ade90 ("drm/i915/gvt: Checking workload's gma earlier") > > Signed-off-by: Dan Carpenter > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: header cleanup of the day

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: header cleanup of the day URL : https://patchwork.freedesktop.org/series/64910/ State : success == Summary == CI Bug Log - changes from CI_DRM_6656_full -> Patchwork_13918_full Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Defer final intel_wakeref_put to process context (rev2)

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Defer final intel_wakeref_put to process context (rev2) URL : https://patchwork.freedesktop.org/series/64916/ State : failure == Summary == Applying: drm/i915: Defer final intel_wakeref_put to process context Using index info to reconstruct a base

Re: [Intel-gfx] [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-08-08 Thread Nick Desaulniers
On Thu, Aug 8, 2019 at 1:22 PM Thomas Gleixner wrote: > > tglx just picked up 2 other patches of mine, bumping just in case he's > > not picking up patches while on vacation. ;) > > I'm only half on vacation :) > > So I can pick it up. Thanks, will send half margaritas. -- Thanks, ~Nick

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Stop reconfiguring our shmemfs mountpoint

2019-08-08 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Stop reconfiguring our shmemfs mountpoint URL : https://patchwork.freedesktop.org/series/64927/ State : success == Summary == CI Bug Log - changes from CI_DRM_6660 -> Patchwork_13928

[Intel-gfx] [PATCH i-g-t 2/3] Force spin-batch to cause a hang as required

2019-08-08 Thread Chris Wilson
When using a spinner to trigger a hang, make it unpreemptable so that it appears like a true hang. References: https://bugs.freedesktop.org/show_bug.cgi?id=109661 Signed-off-by: Chris Wilson --- tests/i915/gem_eio.c| 4 +++- tests/i915/gem_exec_fence.c | 3 ++- tests/kms_busy.c

[Intel-gfx] [PATCH i-g-t 3/3] i915/gem_ctx_engine: Drip feed requests into 'independent'

2019-08-08 Thread Chris Wilson
The intent of the test is to exercise that each channel in the engine[] is an independent context/ring/timeline. It setups 64 channels pointing to rcs0 and then submits one request to each in turn waiting on a timeline that will force them to run out of submission order. They can only run in fence

[Intel-gfx] [PATCH i-g-t 1/3] i915/gem_exec_schedule: Check timeslice

2019-08-08 Thread Chris Wilson
Check that we can run a second request even if an equal priority spinner is hogging the engine. Signed-off-by: Chris Wilson Cc: Lionel Landwerlin Cc: Tvrtko Ursulin --- tests/i915/gem_exec_schedule.c | 36 ++ 1 file changed, 36 insertions(+) diff --git

[Intel-gfx] ✗ Fi.CI.BAT: failure for DC3CO Support for TGL

2019-08-08 Thread Patchwork
== Series Details == Series: DC3CO Support for TGL URL : https://patchwork.freedesktop.org/series/64923/ State : failure == Summary == Applying: drm/i915/tgl: Add DC3CO required register and bits Applying: drm/i915/tgl: Add DC3CO mask to allowed_dc_mask and gen9_dc_mask Applying:

Re: [Intel-gfx] [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint

2019-08-08 Thread Hugh Dickins
On Thu, 8 Aug 2019, Chris Wilson wrote: > + * By creating our own shmemfs mountpoint, we can pass in > + * mount flags that better match our usecase. > + * > + * One example, although it is probably better with a per-file > + * control, is selecting huge page allocations

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Stop reconfiguring our shmemfs mountpoint

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Stop reconfiguring our shmemfs mountpoint URL : https://patchwork.freedesktop.org/series/64922/ State : success == Summary == CI Bug Log - changes from CI_DRM_6658 -> Patchwork_13926 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Fixup a missing legacy_idx

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fixup a missing legacy_idx URL : https://patchwork.freedesktop.org/series/64921/ State : success == Summary == CI Bug Log - changes from CI_DRM_6658 -> Patchwork_13925 Summary ---

[Intel-gfx] [PATCH] drm/i915: Defer final intel_wakeref_put to process context

2019-08-08 Thread Chris Wilson
As we need to acquire a mutex to serialise the final intel_wakeref_put, we need to ensure that we are in process context at that time. However, we want to allow operation on the intel_wakeref from inside timer and other hardirq context, which means that need to defer that final put to a workqueue.

Re: [Intel-gfx] [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-08-08 Thread Thomas Gleixner
On Thu, 8 Aug 2019, Nick Desaulniers wrote: > On Tue, Aug 6, 2019 at 5:59 AM Josh Poimboeuf wrote: > > > Gentle ping... > > > Thomas and Chris: Will someone of you pick this up? > > > As "objtool: Improve UACCESS coverage" [1] went trough tip tree I > > > highly appreciate to do so with this one.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Pass intel_context to mock_request (rev2)

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Pass intel_context to mock_request (rev2) URL : https://patchwork.freedesktop.org/series/64439/ State : success == Summary == CI Bug Log - changes from CI_DRM_6654_full -> Patchwork_13916_full

Re: [Intel-gfx] [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-08-08 Thread Nick Desaulniers
On Tue, Aug 6, 2019 at 5:59 AM Josh Poimboeuf wrote: > > On Mon, Aug 05, 2019 at 09:29:53PM +0200, Sedat Dilek wrote: > > On Wed, Jul 31, 2019 at 2:25 PM Sedat Dilek wrote: > > > > > > On Fri, Jul 26, 2019 at 9:30 PM Chris Wilson > > > wrote: > > > > > > > > Quoting Thomas Gleixner (2019-07-26

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ URL : https://patchwork.freedesktop.org/series/64920/ State : success == Summary == CI Bug Log - changes from CI_DRM_6657 -> Patchwork_13924

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v4,1/2] drm/i915: Get transcoder power domain before reading its register

2019-08-08 Thread Souza, Jose
On Thu, 2019-08-08 at 18:56 +, Souza, Jose wrote: > On Thu, 2019-08-08 at 13:49 +, Patchwork wrote: > > == Series Details == > > > > Series: series starting with [v4,1/2] drm/i915: Get transcoder > > power > > domain before reading its register > > URL :

[Intel-gfx] [CI 1/2] drm/i915: Stop reconfiguring our shmemfs mountpoint

2019-08-08 Thread Chris Wilson
The filesystem reconfigure API is undergoing a transition, breaking our current code. As we only set the default options, we can simply remove the call to s_op->remount_fs(). In the future, when HW permits, we can try re-enabling huge page support, albeit as suggested with new per-file controls.

[Intel-gfx] [CI 2/2] drm/i915/selftests: Fixup a missing legacy_idx

2019-08-08 Thread Chris Wilson
Grr, missed one*. For using the legacy engine map, we should use engine->legacy_idx. Ideally, we should know the intel_context in the selftest and avoid all the fiddling around with unwanted GEM contexts. * In my defence, the conflict was added in another patch after it was tested by CI. v2:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix HW readout for crtc_clock in HDMI mode (rev2)

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Fix HW readout for crtc_clock in HDMI mode (rev2) URL : https://patchwork.freedesktop.org/series/64909/ State : success == Summary == CI Bug Log - changes from CI_DRM_6657 -> Patchwork_13923 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Allocate kernel_contexts directly

2019-08-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Allocate kernel_contexts directly URL : https://patchwork.freedesktop.org/series/64902/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6654_full -> Patchwork_13915_full

Re: [Intel-gfx] [PATCH] dma-buf: make dma_fence structure a bit smaller v2

2019-08-08 Thread Daniel Vetter
On Thu, Aug 08, 2019 at 04:41:39PM +0200, Christian König wrote: > Daniel any more comments on this one? It's not kerneldoc, but then all the dma-* docs need some serious love anyway, so all good with me. -Daniel > > If not I'm going to push it. > > Christian. > > Am 08.08.19 um 15:22 schrieb

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v4,1/2] drm/i915: Get transcoder power domain before reading its register

2019-08-08 Thread Souza, Jose
On Thu, 2019-08-08 at 13:49 +, Patchwork wrote: > == Series Details == > > Series: series starting with [v4,1/2] drm/i915: Get transcoder power > domain before reading its register > URL : https://patchwork.freedesktop.org/series/64877/ > State : failure > > == Summary == > > CI Bug Log -

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make debugfs/per_file_stats scale better

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Make debugfs/per_file_stats scale better URL : https://patchwork.freedesktop.org/series/64919/ State : success == Summary == CI Bug Log - changes from CI_DRM_6657 -> Patchwork_13922 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Use after free in error path in intel_vgpu_create_workload()

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Use after free in error path in intel_vgpu_create_workload() URL : https://patchwork.freedesktop.org/series/64899/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6654_full -> Patchwork_13914_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Make debugfs/per_file_stats scale better

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Make debugfs/per_file_stats scale better URL : https://patchwork.freedesktop.org/series/64919/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1cf3be24fb68 drm/i915: Make debugfs/per_file_stats scale better -:102: WARNING:LONG_LINE: line

[Intel-gfx] ✓ Fi.CI.BAT: success for convert i915 to new mount API (rev2)

2019-08-08 Thread Patchwork
== Series Details == Series: convert i915 to new mount API (rev2) URL : https://patchwork.freedesktop.org/series/64720/ State : success == Summary == CI Bug Log - changes from CI_DRM_6657 -> Patchwork_13921 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Defer final intel_wakeref_put to process context

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Defer final intel_wakeref_put to process context URL : https://patchwork.freedesktop.org/series/64916/ State : success == Summary == CI Bug Log - changes from CI_DRM_6657 -> Patchwork_13920 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for convert i915 to new mount API (rev2)

2019-08-08 Thread Patchwork
== Series Details == Series: convert i915 to new mount API (rev2) URL : https://patchwork.freedesktop.org/series/64720/ State : warning == Summary == $ dim checkpatch origin/drm-tip e099d8c4e87d fs: export put_filesystem() fe79bda9adc6 i915: convert to new mount API -:79:

Re: [Intel-gfx] [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+

2019-08-08 Thread Jason Ekstrand
Note: This doesn't actually fix 110998. I can still get a hard-hang with a slightly different version of the reproducer example. However, it does fix the original and I suspect it will fix the UE4 editor hang in 110228 On Thu, Aug 8, 2019 at 12:30 PM Jason Ekstrand wrote: > This is consistent

Re: [Intel-gfx] [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+

2019-08-08 Thread Jason Ekstrand
This is consistent with what the Windows driver does and what I've heard from HW people. Reviewed-by: Jason Ekstrand On Thu, Aug 8, 2019 at 11:36 AM Chris Wilson wrote: > This bit was fliped on for "syncing dependencies between camera and > graphics". BSpec has no recollection why, and it is

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Only include active engines in the capture state

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Only include active engines in the capture state URL : https://patchwork.freedesktop.org/series/64914/ State : success == Summary == CI Bug Log - changes from CI_DRM_6657 -> Patchwork_13919 Summary

[Intel-gfx] [PATCH v4 8/9] drm/i915/tgl: switch between dc3co and dc5 based on display idleness

2019-08-08 Thread Anshuman Gupta
DC3CO is useful power state, when DMC detects PSR2 idle frame while an active video playback, playing 30fps video on 60hz panel is the classic example of this use case. DC5 and DC6 saves more power, but can't be entered during video playback because there are not enough idle frames in a row to

[Intel-gfx] [PATCH v4 9/9] drm/i915/tgl: Add DC3CO counter in i915_dmc_info

2019-08-08 Thread Anshuman Gupta
Adding DC3CO counter in i915_dmc_info debugfs will be useful for DC3CO validation. DMC firmware uses DMC_DEBUG3 register as DC3CO counter register on TGL, as per B.Specs DMC_DEBUG3 is general purpose register. Cc: Jani Nikula Cc: Imre Deak Cc: Animesh Manna Signed-off-by: Anshuman Gupta ---

[Intel-gfx] [PATCH v4 5/9] drm/i915/tgl: Add helper function to prefer dc3co over dc5

2019-08-08 Thread Anshuman Gupta
We need to have a S/W flag based upon which driver can switch to DC3CO. If it is only edp display connected and it has psr2 capability, then set a prefer_dc3co flag to true, which will be used to switch to dc3co as well as to program DC3CO PSR2 transcoder early exitline event. Cc: Jani Nikula

[Intel-gfx] [PATCH v4 6/9] drm/i915/tgl: Add VIDEO power domain

2019-08-08 Thread Anshuman Gupta
The Power domain name VIDEO is inspired from the fact that DC3CO should be enabled only during VIDEO playback. POWER_DOMAIN_VIDEO is a hook to "DC5 Off" power well, which can disallow DC5/6 and allow DC3CO. Cc: Jani Nikula Cc: Imre Deak Cc: Animesh Manna Signed-off-by: Anshuman Gupta ---

[Intel-gfx] [PATCH v4 7/9] drm/i915/tgl: DC3CO PSR2 helper

2019-08-08 Thread Anshuman Gupta
Add dc3co helper functions to enable/disable psr2 deep sleep. Disallow DC3CO state before PSR2 exit, it essentially does that by putting a reference to POWER_DOMAIN_VIDEO before PSR2 exit. Cc: Jani Nikula Cc: Imre Deak Cc: Animesh Manna Cc: José Roberto de Souza Signed-off-by: Anshuman Gupta

[Intel-gfx] [PATCH v4 3/9] drm/i915/tgl: Add power well to enable DC3CO state

2019-08-08 Thread Anshuman Gupta
"DC3CO Off" power well inherits its power domains from "DC Off" power well, these power domains will disallow DC3CO when any external displays are connected and at time of modeset and aux programming. Renaming "DC Off" power well to "DC5 Off" power well. v2: commit log improvement. v3: Used

[Intel-gfx] [PATCH v4 2/9] drm/i915/tgl: Add DC3CO mask to allowed_dc_mask and gen9_dc_mask

2019-08-08 Thread Anshuman Gupta
Enable dc3co state in enable_dc module param and add dc3co enable mask to allowed_dc_mask and gen9_dc_mask. v1: Adding enable_dc=3,4 options to enable DC3CO with DC5 and DC6 independently. Cc: Jani Nikula Cc: Imre Deak Cc: Animesh Manna Signed-off-by: Anshuman Gupta ---

[Intel-gfx] [PATCH v4 1/9] drm/i915/tgl: Add DC3CO required register and bits

2019-08-08 Thread Anshuman Gupta
Adding following definition to i915_reg.h 1. DC_STATE_EN register DC3CO bit fields and masks. 2. Transcoder EXITLINE register and its bit fields and mask. Cc: Jani Nikula Cc: Imre Deak Cc: Animesh Manna Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_reg.h | 8 1 file

[Intel-gfx] [PATCH v4 4/9] drm/i915/tgl: mutual exclusive handling for DC3CO and DC5/6

2019-08-08 Thread Anshuman Gupta
As per B.Specs DC5 and DC6 not allowed when DC3CO is enabled and DC3CO should be enabled only during VIDEO playback. Which essentially means both can DC5 and DC3CO can not be enabled at same time, it makes DC3CO and DC5 mutual exclusive. Cc: Jani Nikula Cc: Imre Deak Cc: Animesh Manna Cc:

[Intel-gfx] [PATCH v4 0/9] DC3CO Support for TGL

2019-08-08 Thread Anshuman Gupta
This revision is a rebased and has addressed few review comment provided by Animesh and has some other fixes in dc3 disallow sequence. one patch of this series "tgl-DC3CO-PSR2-helper" will require rebase after https://patchwork.freedesktop.org/series/62416/ series will merged to drm-tip. TGL

[PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint

2019-08-08 Thread Chris Wilson
The filesystem reconfigure API is undergoing a transition, breaking our current code. As we only set the default options, we can simply remove the call to s_op->remount_fs(). In the future, when HW permits, we can try re-enabling huge page support, albeit as suggested with new per-file controls.

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Defer final intel_wakeref_put to process context

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Defer final intel_wakeref_put to process context URL : https://patchwork.freedesktop.org/series/64916/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Defer final intel_wakeref_put to process context

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fixup a missing legacy_idx

2019-08-08 Thread Matthew Auld
On 08/08/2019 17:53, Chris Wilson wrote: Grr, missed one. For using the legacy engine map, we should use engine->legacy_idx. Ideally, we should know the intel_context in the selftest and avoid all the fiddling around with unwanted GEM contexts. Fixes: f1c4d157ab9b ("drm/i915: Fix up the inverse

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Defer final intel_wakeref_put to process context

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Defer final intel_wakeref_put to process context URL : https://patchwork.freedesktop.org/series/64916/ State : warning == Summary == $ dim checkpatch origin/drm-tip 486eb2d99387 drm/i915: Defer final intel_wakeref_put to process context -:315:

Re: [Intel-gfx] [RFC 0/3] Display uncore

2019-08-08 Thread Lucas De Marchi
On Thu, Aug 08, 2019 at 09:47:56AM -0700, Daniele Ceraolo Spurio wrote: On 8/8/19 6:58 AM, Jani Nikula wrote: On Thu, 08 Aug 2019, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-08-08 02:44:20) I've been trying to identify MMIO ranges to clearly define what belongs to

Re: [Intel-gfx] [PATCHv2 2/3] i915: convert to new mount API

2019-08-08 Thread Matthew Auld
On 08/08/2019 17:23, Chris Wilson wrote: Quoting Hugh Dickins (2019-08-08 16:54:16) On Thu, 8 Aug 2019, Al Viro wrote: On Wed, Aug 07, 2019 at 08:30:02AM +0200, Christoph Hellwig wrote: On Tue, Aug 06, 2019 at 12:50:10AM -0700, Hugh Dickins wrote: Though personally I'm averse to managing

Re: [Intel-gfx] [RFC 1/3] drm/i915: split out uncore_mmio_debug

2019-08-08 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-08-08 02:44:21) > Multiple uncore structures will share the debug infrastructure, so > move it to a common place and add extra locking around it. > Also, since we now have a separate object, it is cleaner to have > dedicated functions working on the object to

[Intel-gfx] [PATCH] drm/i915/selftests: Fixup a missing legacy_idx

2019-08-08 Thread Chris Wilson
Grr, missed one. For using the legacy engine map, we should use engine->legacy_idx. Ideally, we should know the intel_context in the selftest and avoid all the fiddling around with unwanted GEM contexts. Fixes: f1c4d157ab9b ("drm/i915: Fix up the inverse mapping for default ctx->engines[]")

Re: [Intel-gfx] [RFC 0/3] Display uncore

2019-08-08 Thread Daniele Ceraolo Spurio
On 8/8/19 6:58 AM, Jani Nikula wrote: On Thu, 08 Aug 2019, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-08-08 02:44:20) I've been trying to identify MMIO ranges to clearly define what belongs to display_uncore to do a check on access, but there are lots of exceptions and

Re: [Intel-gfx] [RFC 1/3] drm/i915: split out uncore_mmio_debug

2019-08-08 Thread Daniele Ceraolo Spurio
On 8/8/19 6:08 AM, Mika Kuoppala wrote: Daniele Ceraolo Spurio writes: Multiple uncore structures will share the debug infrastructure, so move it to a common place and add extra locking around it. Also, since we now have a separate object, it is cleaner to have dedicated functions working

[Intel-gfx] [PATCH] drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+

2019-08-08 Thread Chris Wilson
This bit was fliped on for "syncing dependencies between camera and graphics". BSpec has no recollection why, and it is causing unrecoverable GPU hangs with Vulkan compute workloads. From BSpec, setting bit5 to 0 enables relaxed padding requiremets for buffers, 1D and 2D non-array, non-MSAA,

[Intel-gfx] [PATCH v2] drm/i915: Fix HW readout for crtc_clock in HDMI mode

2019-08-08 Thread Imre Deak
The conversion during HDMI HW readout from port_clock to crtc_clock was missed when HDMI 10bpc support was added, so fix that. v2: - Unscrew the non-HDMI case. Fixes: cd9e11a8bf25 ("drm/i915/icl: Add 10-bit support for hdmi") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109593 Cc:

Re: [Intel-gfx] [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-08 Thread Weiny, Ira
> > On 8/7/19 7:36 PM, Ira Weiny wrote: > > On Wed, Aug 07, 2019 at 10:46:49AM +0200, Michal Hocko wrote: > >> On Wed 07-08-19 10:37:26, Jan Kara wrote: > >>> On Fri 02-08-19 12:14:09, John Hubbard wrote: > On 8/2/19 7:52 AM, Jan Kara wrote: > > On Fri 02-08-19 07:24:43, Matthew Wilcox

[Intel-gfx] [CI] drm/i915: Make debugfs/per_file_stats scale better

2019-08-08 Thread Chris Wilson
Currently we walk the entire list of obj->vma for each obj within a file to find the matching vma of this context. Since we know we are searching for a particular vma bound to a user context, we can use the rbtree to search for it rather than repeatedly walk everything. Signed-off-by: Chris

Re: [Intel-gfx] [PATCHv2 2/3] i915: convert to new mount API

2019-08-08 Thread Chris Wilson
Quoting Hugh Dickins (2019-08-08 16:54:16) > On Thu, 8 Aug 2019, Al Viro wrote: > > On Wed, Aug 07, 2019 at 08:30:02AM +0200, Christoph Hellwig wrote: > > > On Tue, Aug 06, 2019 at 12:50:10AM -0700, Hugh Dickins wrote: > > > > Though personally I'm averse to managing "f"objects through > > > >

Re: [Intel-gfx] [PATCHv2 2/3] i915: convert to new mount API

2019-08-08 Thread Hugh Dickins
On Thu, 8 Aug 2019, Al Viro wrote: > On Wed, Aug 07, 2019 at 08:30:02AM +0200, Christoph Hellwig wrote: > > On Tue, Aug 06, 2019 at 12:50:10AM -0700, Hugh Dickins wrote: > > > Though personally I'm averse to managing "f"objects through > > > "m"interfaces, which can get ridiculous (notably,

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_persistent_relocs: Don't call DROP_IDLE in the middle of submitting

2019-08-08 Thread Chris Wilson
Quoting Mika Kuoppala (2019-08-08 16:26:35) > Chris Wilson writes: > > > To actually DROP_IDLE means that we have to wait for ongoing submission, > > and any new concurrently submitted, i.e. it should only be called during > > single-threaded submission to ensure the GPU is idle before the new >

Re: [Intel-gfx] [PULL] drm-misc-next

2019-08-08 Thread Maxime Ripard
Hi, On Wed, Aug 07, 2019 at 02:30:25PM +0200, Daniel Vetter wrote: > On Wed, Aug 7, 2019 at 2:02 PM Maxime Ripard > wrote: > > On Tue, Aug 06, 2019 at 06:11:32PM +0200, Daniel Vetter wrote: > > > On Tue, Aug 06, 2019 at 06:01:46PM +0200, Maxime Ripard wrote: > > > > On Tue, Aug 06, 2019 at

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_persistent_relocs: Don't call DROP_IDLE in the middle of submitting

2019-08-08 Thread Mika Kuoppala
Chris Wilson writes: > To actually DROP_IDLE means that we have to wait for ongoing submission, > and any new concurrently submitted, i.e. it should only be called during > single-threaded submission to ensure the GPU is idle before the new > action. > > v2: Also include SHRINK for

Re: [Intel-gfx] [PATCH 10/19] drm/i915: Make debugfs/per_file_stats scale better

2019-08-08 Thread Matthew Auld
On Thu, 8 Aug 2019 at 09:03, Chris Wilson wrote: > > Currently we walk the entire list of obj->vma for each obj within a file > to find the matching vma of this context. Since we know we are searching > for a particular vma bound to a user context, we can use the rbtree to > search for it rather

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: header cleanup of the day

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: header cleanup of the day URL : https://patchwork.freedesktop.org/series/64910/ State : success == Summary == CI Bug Log - changes from CI_DRM_6656 -> Patchwork_13918 Summary --- **SUCCESS**

[Intel-gfx] [CI] drm/i915: Defer final intel_wakeref_put to process context

2019-08-08 Thread Chris Wilson
As we need to acquire a mutex to serialise the final intel_wakeref_put, we need to ensure that we are in process context at that time. However, we want to allow operation on the intel_wakeref from inside timer and other hardirq context, which means that need to defer that final put to a workqueue.

Re: [Intel-gfx] [PATCH 02/19] drm/i915: Defer final intel_wakeref_put to process context

2019-08-08 Thread Chris Wilson
Quoting Mika Kuoppala (2019-08-08 15:47:07) > Chris Wilson writes: > > > As we need to acquire a mutex to serialise the final > > intel_wakeref_put, we need to ensure that we are in process context at > > that time. However, we want to allow operation on the intel_wakeref from > > inside timer

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: header cleanup of the day

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: header cleanup of the day URL : https://patchwork.freedesktop.org/series/64910/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: remove unused dev_priv->no_aux_handshake Okay! Commit: drm/i915: move

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: header cleanup of the day

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: header cleanup of the day URL : https://patchwork.freedesktop.org/series/64910/ State : warning == Summary == $ dim checkpatch origin/drm-tip 263e77d0ad54 drm/i915: remove unused dev_priv->no_aux_handshake -:7: ERROR:GIT_COMMIT_ID: Please use git commit

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix HW readout for crtc_clock in HDMI mode

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Fix HW readout for crtc_clock in HDMI mode URL : https://patchwork.freedesktop.org/series/64909/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6656 -> Patchwork_13917 Summary ---

Re: [Intel-gfx] [PATCH 02/19] drm/i915: Defer final intel_wakeref_put to process context

2019-08-08 Thread Mika Kuoppala
Chris Wilson writes: > As we need to acquire a mutex to serialise the final > intel_wakeref_put, we need to ensure that we are in process context at > that time. However, we want to allow operation on the intel_wakeref from > inside timer and other hardirq context, which means that need to defer

[Intel-gfx] [CI] drm/i915: Only include active engines in the capture state

2019-08-08 Thread Chris Wilson
Skip printing out idle engines that did not contribute to the GPU hang. As the number of engines gets ever larger, we have increasing noise in the error state where typically there is only one guilty request on one engine that we need to inspect. Signed-off-by: Chris Wilson Reviewed-by: Matthew

Re: [Intel-gfx] [PATCH 09/19] drm/i915: Only include active engines in the capture state

2019-08-08 Thread Matthew Auld
On Thu, 8 Aug 2019 at 09:04, Chris Wilson wrote: > > Skip printing out idle engines that did not contribute to the GPU hang. > As the number of engines gets ever larger, we have increasing noise in > the error state where typically there is only one guilty request on one > engine that we need to

[Intel-gfx] ✗ Fi.CI.IGT: failure for Display uncore (rev3)

2019-08-08 Thread Patchwork
== Series Details == Series: Display uncore (rev3) URL : https://patchwork.freedesktop.org/series/61735/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6652_full -> Patchwork_13910_full Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Return true by default in mocs settings

2019-08-08 Thread Kumar Valsan, Prathap
On Wed, Aug 07, 2019 at 01:55:56PM -0700, Stuart Summers wrote: > Reduce code by defaulting to true in the MOCS settings > initialization function. Set to false for unexpected > platforms. > > Signed-off-by: Stuart Summers Reviewed-by:Prathap Kumar Valsan > --- >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix HW readout for crtc_clock in HDMI mode

2019-08-08 Thread Patchwork
== Series Details == Series: drm/i915: Fix HW readout for crtc_clock in HDMI mode URL : https://patchwork.freedesktop.org/series/64909/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Fix HW readout for crtc_clock in HDMI mode

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Defer final intel_wakeref_put to process context

2019-08-08 Thread Chris Wilson
Quoting Mika Kuoppala (2019-08-08 14:49:40) > Chris Wilson writes: > > > Quoting Mika Kuoppala (2019-08-07 16:04:56) > >> Chris Wilson writes: > >> > if (flags & I915_WAIT_LOCKED) { > >> > - int err; > >> > - > >> > lockdep_assert_held(>drm.struct_mutex); > >> >

Re: [Intel-gfx] [PATCH 08/19] drm/i915: Lift timeline into intel_context

2019-08-08 Thread Matthew Auld
On Thu, 8 Aug 2019 at 09:03, Chris Wilson wrote: > > Move the timeline from being inside the intel_ring to intel_context > itself. This saves much pointer dancing and makes the relations of the > context to its timeline much clearer. > > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld

Re: [Intel-gfx] [RFC 0/3] Display uncore

2019-08-08 Thread Jani Nikula
On Thu, 08 Aug 2019, Chris Wilson wrote: > Quoting Daniele Ceraolo Spurio (2019-08-08 02:44:20) >> I've been trying to identify MMIO ranges to clearly define what belongs >> to display_uncore to do a check on access, but there are lots of >> exceptions and differences across gens (with a few more

Re: [Intel-gfx] [PATCH 00/10] drm/i915: header cleanup of the day

2019-08-08 Thread Chris Wilson
Quoting Jani Nikula (2019-08-08 14:42:39) > The daily dose of header cleanup. I think I'll settle down for a while after > this one. ;) > > BR, > Jani. > > Jani Nikula (10): > drm/i915: remove unused dev_priv->no_aux_handshake > drm/i915: move add_taint_for_CI() to i915_utils.h > drm/i915:

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Defer final intel_wakeref_put to process context

2019-08-08 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-08-07 16:04:56) >> Chris Wilson writes: >> > -static int intel_gt_park(struct intel_wakeref *wf) >> > +static int __gt_park(struct intel_wakeref *wf) >> > { >> > struct drm_i915_private *i915 = >> > container_of(wf,

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v4,1/2] drm/i915: Get transcoder power domain before reading its register

2019-08-08 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915: Get transcoder power domain before reading its register URL : https://patchwork.freedesktop.org/series/64877/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6652_full -> Patchwork_13909_full

Re: [Intel-gfx] [PATCH 01/10] drm/i915: remove unused dev_priv->no_aux_handshake

2019-08-08 Thread Chris Wilson
Quoting Jani Nikula (2019-08-08 14:42:40) > The last user of dev_priv->no_aux_handshake was removed in commit > 3cf2efb1a7c6 ("Revert "drm/i915/dp: use VBT provided eDP params if > available""). Finally remove the leftovers. History checks out. It was introduced as part of the dpcd cache, which

[Intel-gfx] [PATCH 09/10] drm/i915: extract gem/i915_gem_stolen.h from i915_drv.h

2019-08-08 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time i915_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with

[Intel-gfx] [PATCH 01/10] drm/i915: remove unused dev_priv->no_aux_handshake

2019-08-08 Thread Jani Nikula
The last user of dev_priv->no_aux_handshake was removed in commit 3cf2efb1a7c6 ("Revert "drm/i915/dp: use VBT provided eDP params if available""). Finally remove the leftovers. Cc: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 4

[Intel-gfx] [PATCH 10/10] drm/i915: extract i915_gem_shrinker.h from i915_drv.h

2019-08-08 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time i915_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with

[Intel-gfx] [PATCH 03/10] drm/i915: move I915_STATE_WARN() and _ON() to intel_display.h

2019-08-08 Thread Jani Nikula
It's for display. Seems like a better fit. Reduce clutter in i915_drv.h. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.h | 18 ++ drivers/gpu/drm/i915/i915_drv.h | 18 -- 2 files changed, 18 insertions(+), 18 deletions(-)

[Intel-gfx] [PATCH 07/10] drm/i915: extract i915_suspend.h from i915_drv.h

2019-08-08 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time i915_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with

[Intel-gfx] [PATCH 02/10] drm/i915: move add_taint_for_CI() to i915_utils.h

2019-08-08 Thread Jani Nikula
Seems like a better fit. Reduce clutter in i915_drv.h. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 11 --- drivers/gpu/drm/i915/i915_utils.h | 11 +++ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 00/10] drm/i915: header cleanup of the day

2019-08-08 Thread Jani Nikula
The daily dose of header cleanup. I think I'll settle down for a while after this one. ;) BR, Jani. Jani Nikula (10): drm/i915: remove unused dev_priv->no_aux_handshake drm/i915: move add_taint_for_CI() to i915_utils.h drm/i915: move I915_STATE_WARN() and _ON() to intel_display.h

[Intel-gfx] [PATCH 05/10] drm/i915: extract i915_perf.h from i915_drv.h

2019-08-08 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time i915_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with

[Intel-gfx] [PATCH 06/10] drm/i915: extract i915_sysfs.h from i915_drv.h

2019-08-08 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time i915_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with

[Intel-gfx] [PATCH 04/10] drm/i915: move printing and load error inject to i915_utils.[ch]

2019-08-08 Thread Jani Nikula
Seems like a better fit. Reduce clutter in i915_drv.[ch]. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_drv.c | 69 --- drivers/gpu/drm/i915/i915_drv.h | 28 --- drivers/gpu/drm/i915/i915_utils.c | 78

[Intel-gfx] [PATCH 08/10] drm/i915: extract i915_memcpy.h from i915_drv.h

2019-08-08 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time i915_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with

[Intel-gfx] [PATCH] drm/i915: Fix HW readout for crtc_clock in HDMI mode

2019-08-08 Thread Imre Deak
The conversion during HDMI HW readout from port_clock to crtc_clock was missed when HDMI 10bpc support was added, so fix that. Fixes: cd9e11a8bf25 ("drm/i915/icl: Add 10-bit support for hdmi") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109593 Cc: Radhakrishna Sripada Cc: Ville

  1   2   >