[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: use DRM_ERROR() instead of drm_err()

2019-10-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: use DRM_ERROR() instead of drm_err() URL : https://patchwork.freedesktop.org/series/67500/ State : success == Summary == CI Bug Log - changes from CI_DRM_6992_full -> Patchwork_14635_full

[Intel-gfx] [PULL] drm-misc-fixes

2019-10-02 Thread Maxime Ripard
Hi Dave, Daniel, I hope that you enjoy XDC if you could make it this year :) Here's the first round of fixes for drm-misc Maxime drm-misc-fixes-2019-10-02: - One include fix for tilcdc - A memory leak fix for Komeda - Some fixes for resources cleanups with writeback The following changes

[Intel-gfx] [PATCH tip/core/rcu 3/9] drivers/gpu: Replace rcu_swap_protected() with rcu_replace()

2019-10-02 Thread paulmck
From: "Paul E. McKenney" This commit replaces the use of rcu_swap_protected() with the more intuitively appealing rcu_replace() as a step towards removing rcu_swap_protected(). Link: https://lore.kernel.org/lkml/CAHk-=wiAsJLw1egFEE=z7-ggtm6wcvtyytxza1+bhqta4gg...@mail.gmail.com/ Reported-by:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/drm_vblank: Change EINVAL by the correct errno (rev6)

2019-10-02 Thread Patchwork
== Series Details == Series: drm/drm_vblank: Change EINVAL by the correct errno (rev6) URL : https://patchwork.freedesktop.org/series/51147/ State : success == Summary == CI Bug Log - changes from CI_DRM_6991_full -> Patchwork_14631_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/debugfs: Only wedge if we have reset available

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/debugfs: Only wedge if we have reset available URL : https://patchwork.freedesktop.org/series/67492/ State : success == Summary == CI Bug Log - changes from CI_DRM_6991_full -> Patchwork_14628_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/tgl: Add the Thunderbolt PLL divider values (rev2)

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add the Thunderbolt PLL divider values (rev2) URL : https://patchwork.freedesktop.org/series/67498/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6993 -> Patchwork_14640 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Add the Thunderbolt PLL divider values (rev2)

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add the Thunderbolt PLL divider values (rev2) URL : https://patchwork.freedesktop.org/series/67498/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1b4f080f283b drm/i915/tgl: Add the Thunderbolt PLL divider values -:33: CHECK:CAMELCASE:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/vbt: Child device size remains unchanged through VBT 229

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/vbt: Child device size remains unchanged through VBT 229 URL : https://patchwork.freedesktop.org/series/67510/ State : success == Summary == CI Bug Log - changes from CI_DRM_6992 -> Patchwork_14639

Re: [Intel-gfx] [Bug 205065] New: workqueue: PF_MEMALLOC task 173(kswapd0) is flushing !WQ_MEM_RECLAIM events:gen6_pm_rps_work [i915]

2019-10-02 Thread Chris Wilson
Quoting Joonas Lahtinen (2019-10-03 00:28:43) > + Chris and Tvrtko It's a trivial warning, that's already fixed. In this case by separating out the poweroff into process context. c7302f204490 ("drm/i915: Defer final intel_wakeref_put to process context") -Chris

Re: [Intel-gfx] [Bug 205065] New: workqueue: PF_MEMALLOC task 173(kswapd0) is flushing !WQ_MEM_RECLAIM events:gen6_pm_rps_work [i915]

2019-10-02 Thread Joonas Lahtinen
+ Chris and Tvrtko Quoting Andrew Morton (2019-10-03 00:57:21) > > (switched to email. Please respond via emailed reply-to-all, not via the > bugzilla web interface). > > On Tue, 01 Oct 2019 17:06:35 + bugzilla-dae...@bugzilla.kernel.org wrote: > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Exercise potential false lite-restore (rev9)

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Exercise potential false lite-restore (rev9) URL : https://patchwork.freedesktop.org/series/67438/ State : success == Summary == CI Bug Log - changes from CI_DRM_6992 -> Patchwork_14638

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Polish possible_clones setup

2019-10-02 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Polish possible_clones setup URL : https://patchwork.freedesktop.org/series/67504/ State : success == Summary == CI Bug Log - changes from CI_DRM_6992 -> Patchwork_14637

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Warn CI about an unrecoverable wedge

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/gt: Warn CI about an unrecoverable wedge URL : https://patchwork.freedesktop.org/series/67502/ State : success == Summary == CI Bug Log - changes from CI_DRM_6992 -> Patchwork_14636 Summary ---

Re: [Intel-gfx] [RFC v3 4/9] drm/i915/tgl: Gen-12 render decompression

2019-10-02 Thread Matt Roper
On Mon, Sep 23, 2019 at 03:29:30AM -0700, Dhinakaran Pandiyan wrote: > Gen-12 display decompression operates on Y-tiled compressed main surface. > The CCS is linear I'd mention in the commit message that we opt to to treat the CCS as if it were a bunch of 64x1 tiles. There are a handful of

Re: [Intel-gfx] [RFC v3 3/9] drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignment

2019-10-02 Thread Matt Roper
On Mon, Sep 23, 2019 at 03:29:29AM -0700, Dhinakaran Pandiyan wrote: > Easier to read if all the alignment changes are in one place and contained > within a function. > > Cc: Ville Syrjälä > Cc: Matt Roper > Signed-off-by: Dhinakaran Pandiyan > --- >

Re: [Intel-gfx] [RFC v3 2/9] drm/i915: Use intel_tile_height() instead of re-implementing

2019-10-02 Thread Matt Roper
On Mon, Sep 23, 2019 at 03:29:28AM -0700, Dhinakaran Pandiyan wrote: > intel_tile_dims() computes tile height using size and width, when there > is already a function to do just that - intel_tile_height() > > Cc: Ville Syrjälä > Cc: Matt Roper > Signed-off-by: Dhinakaran Pandiyan Reviewed-by:

Re: [Intel-gfx] [Bug 205065] New: workqueue: PF_MEMALLOC task 173(kswapd0) is flushing !WQ_MEM_RECLAIM events:gen6_pm_rps_work [i915]

2019-10-02 Thread Andrew Morton
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Tue, 01 Oct 2019 17:06:35 + bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=205065 > > Bug ID: 205065 >Summary: workqueue:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: use DRM_ERROR() instead of drm_err()

2019-10-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: use DRM_ERROR() instead of drm_err() URL : https://patchwork.freedesktop.org/series/67500/ State : success == Summary == CI Bug Log - changes from CI_DRM_6992 -> Patchwork_14635

[Intel-gfx] [drm-intel:drm-intel-next-queued 4/4] include/linux/spinlock.h:393:9: sparse: sparse: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block

2019-10-02 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: cf82d9ddd3b5203dea5561dfabd1216b8159af37 commit: cf82d9ddd3b5203dea5561dfabd1216b8159af37 [4/4] drm/i915/tgl: Introduce gen12 forcewake ranges reproduce: # apt-get install sparse # sparse version:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: remove static variable for aux last status

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/dp: remove static variable for aux last status URL : https://patchwork.freedesktop.org/series/67499/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6992 -> Patchwork_14634 Summary

[Intel-gfx] [PATCH v2] drm/i915/tgl: Add the Thunderbolt PLL divider values

2019-10-02 Thread Imre Deak
The Thunderbolt PLL divider values on TGL differ from the ICL ones, update the PLL parameter calculation function accordingly. Bspec: 49204 v2: - Remove unused refclk config. (José) Cc: Jose Souza Cc: Clinton A Taylor Cc: Lucas De Marchi Cc: Mika Westerberg Tested-by: Mika Westerberg

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore (rev2)

2019-10-02 Thread Patchwork
== Series Details == Series: series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore (rev2) URL : https://patchwork.freedesktop.org/series/67483/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6992 -> Patchwork_14633

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Extract random_offset() for use with a prng

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Extract random_offset() for use with a prng URL : https://patchwork.freedesktop.org/series/67489/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6988_full -> Patchwork_14626_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore (rev2)

2019-10-02 Thread Patchwork
== Series Details == Series: series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore (rev2) URL : https://patchwork.freedesktop.org/series/67483/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/selftests:

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add the Thunderbolt PLL divider values

2019-10-02 Thread Imre Deak
On Wed, Oct 02, 2019 at 11:07:21PM +0300, Souza, Jose wrote: > On Wed, 2019-10-02 at 17:08 +0300, Imre Deak wrote: > > The Thunderbolt PLL divider values on TGL differ from the ICL ones, > > update the PLL parameter calculation function accordingly. > > > > Bspec: 49204 > > > > Cc: Jose Souza >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore (rev2)

2019-10-02 Thread Patchwork
== Series Details == Series: series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore (rev2) URL : https://patchwork.freedesktop.org/series/67483/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5ab21c1fa058 drm/i915/selftests: Exercise potential

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Add the Thunderbolt PLL divider values

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add the Thunderbolt PLL divider values URL : https://patchwork.freedesktop.org/series/67498/ State : success == Summary == CI Bug Log - changes from CI_DRM_6992 -> Patchwork_14632 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add the Thunderbolt PLL divider values

2019-10-02 Thread Souza, Jose
On Wed, 2019-10-02 at 17:08 +0300, Imre Deak wrote: > The Thunderbolt PLL divider values on TGL differ from the ICL ones, > update the PLL parameter calculation function accordingly. > > Bspec: 49204 > > Cc: Jose Souza > Cc: Clinton A Taylor > Cc: Lucas De Marchi > Cc: Mika Westerberg >

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915/gem_exec_schedule: Replace vgem fence with sync_file

2019-10-02 Thread Patchwork
== Series Details == Series: i915/gem_exec_schedule: Replace vgem fence with sync_file URL : https://patchwork.freedesktop.org/series/67486/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6988_full -> IGTPW_3528_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Add the Thunderbolt PLL divider values

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add the Thunderbolt PLL divider values URL : https://patchwork.freedesktop.org/series/67498/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8dc00b06f596 drm/i915/tgl: Add the Thunderbolt PLL divider values -:26: CHECK:CAMELCASE: Avoid

[Intel-gfx] [PATCH] drm/i915/vbt: Child device size remains unchanged through VBT 229

2019-10-02 Thread Matt Roper
The latest documented version of the VBT is 229, but no further data has been added to the child device definition in block 2. Update the child device version test to eliminate the "Expected child device config size for VBT version XXX not known; assuming 39" debug messages from the logs. Bspec:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/drm_vblank: Change EINVAL by the correct errno (rev6)

2019-10-02 Thread Patchwork
== Series Details == Series: drm/drm_vblank: Change EINVAL by the correct errno (rev6) URL : https://patchwork.freedesktop.org/series/51147/ State : success == Summary == CI Bug Log - changes from CI_DRM_6991 -> Patchwork_14631 Summary

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mg: Use tc_port instead of port parameter to MG registers

2019-10-02 Thread Souza, Jose
On Wed, 2019-10-02 at 10:23 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/mg: Use tc_port instead of port parameter to MG > registers > URL : https://patchwork.freedesktop.org/series/67467/ > State : success > > == Summary == > > CI Bug Log - changes from

[Intel-gfx] [PATCH v3] drm/i915/selftests: Exercise potential false lite-restore

2019-10-02 Thread Chris Wilson
If execlists's lite-restore is based on the common GEM context tag rather than the per-intel_context LRCA, then a context switch between two intel_contexts on the same engine derived from the same GEM context will perform a lite-restore instead of a full context switch. We can exploit this by

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Exercise potential false lite-restore (rev8)

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Exercise potential false lite-restore (rev8) URL : https://patchwork.freedesktop.org/series/67438/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6991 -> Patchwork_14630

Re: [Intel-gfx] [PATCH 3/6] drm/i915: s/crtc_mask/pipe_mask/

2019-10-02 Thread Lucas De Marchi
On Wed, Oct 2, 2019 at 9:25 AM Ville Syrjala wrote: > > From: Ville Syrjälä > > Rename the encoder->crtc_mask to encoder->pipe_mask to better > reflect what it actually contains. > > Signed-off-by: Ville Syrjälä Reviewed-by: Lucas De Marchi but... aren't they synonym? Like crtc means nothing

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem()

2019-10-02 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() URL : https://patchwork.freedesktop.org/series/67493/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6991 -> Patchwork_14629

Re: [Intel-gfx] [PATCH -next] treewide: remove unused argument in lock_release()

2019-10-02 Thread Qian Cai
On Mon, 2019-09-30 at 09:29 +0200, Peter Zijlstra wrote: > On Thu, Sep 19, 2019 at 12:09:40PM -0400, Qian Cai wrote: > > Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument > > in __lock_release"), @nested is no longer used in lock_release(), so > > remove it from all

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for DC3CO Support for TGL (rev15)

2019-10-02 Thread Anshuman Gupta
On 2019-10-02 at 16:21:59 +, Patchwork wrote: > == Series Details == > > Series: DC3CO Support for TGL (rev15) > URL : https://patchwork.freedesktop.org/series/64923/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_6987_full -> Patchwork_14624_full >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem()

2019-10-02 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() URL : https://patchwork.freedesktop.org/series/67493/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2436f7c1a72f drm/i915/vga: rename

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/debugfs: Only wedge if we have reset available

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/debugfs: Only wedge if we have reset available URL : https://patchwork.freedesktop.org/series/67492/ State : success == Summary == CI Bug Log - changes from CI_DRM_6991 -> Patchwork_14628 Summary

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix audio power up sequence for gen10/11

2019-10-02 Thread Kai Vehmanen
Hey, On Wed, 2 Oct 2019, Imre Deak wrote: > On Tue, Oct 01, 2019 at 07:35:54PM +0300, Kai Vehmanen wrote: > > On gen10/11 platforms, driver must set the enable bit of AUD_PIN_BUF_CTL > > as part of audio power up sequence. > > Good catch, seems to match bspec 21352 (and 49280 for GEN12+). > >

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Allow ICL+ DSI on any pipe

2019-10-02 Thread Lucas De Marchi
On Wed, Oct 02, 2019 at 07:25:03PM +0300, Ville Syrjälä wrote: From: Ville Syrjälä There are no longer any pipe<->DSI port limitations on icl+. Populate the pipe_mask accordingly. Cc: José Roberto de Souza Cc: Lucas De Marchi Signed-off-by: Ville Syrjälä ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Refactor tests on obj->ops->flags

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/gem: Refactor tests on obj->ops->flags URL : https://patchwork.freedesktop.org/series/67491/ State : failure == Summary == Applying: drm/i915/gem: Refactor tests on obj->ops->flags Using index info to reconstruct a base tree... M

[Intel-gfx] [PATCH 6/6] drm/i915/mst: Document the userspace fail with possible_crtcs

2019-10-02 Thread Ville Syrjala
From: Ville Syrjälä To avoid accidentally breaking things in the future add a comment explaining why we misconfigure the pipe_mask. Also toss in a TODO for investigating a single encoder approach as opposed to the encoder-per-pipe approach. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH 1/6] drm/i915: Polish possible_clones setup

2019-10-02 Thread Ville Syrjala
From: Ville Syrjälä Replace the hand rolled stuff with drm_encoder_mask() when populating possible_clones, and rename the function to intel_encoder_possible_clones() to make it clear what it's used for. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 13

[Intel-gfx] [PATCH 2/6] drm/i915: Simplfy LVDS crtc_mask setup

2019-10-02 Thread Ville Syrjala
From: Ville Syrjälä We don't need to special case PCH vs. gen4 when setting up the LVDS crtc_mask. Just claim pipes A|B|C work and intel_encoder_possible_crtcs() will drop out any crtc that doesn't exist. v2: Put the special case first to match what most other encoders do Signed-off-by: Ville

[Intel-gfx] [PATCH 3/6] drm/i915: s/crtc_mask/pipe_mask/

2019-10-02 Thread Ville Syrjala
From: Ville Syrjälä Rename the encoder->crtc_mask to encoder->pipe_mask to better reflect what it actually contains. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 2 +- drivers/gpu/drm/i915/display/intel_crt.c | 4 ++--

[Intel-gfx] [PATCH 5/6] drm/i915: Simplify pipe_mask setup even further

2019-10-02 Thread Ville Syrjala
From: Ville Syrjälä Just set pipe_mask=~0 for the non-special cases where any pipe will do. intel_encoder_possible_crtcs() will anyway drop out anything that doesn't exist. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 4 +---

[Intel-gfx] [PATCH 4/6] drm/i915: Allow ICL+ DSI on any pipe

2019-10-02 Thread Ville Syrjala
From: Ville Syrjälä There are no longer any pipe<->DSI port limitations on icl+. Populate the pipe_mask accordingly. Cc: José Roberto de Souza Cc: Lucas De Marchi Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[Intel-gfx] ✗ Fi.CI.IGT: failure for DC3CO Support for TGL (rev15)

2019-10-02 Thread Patchwork
== Series Details == Series: DC3CO Support for TGL (rev15) URL : https://patchwork.freedesktop.org/series/64923/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6987_full -> Patchwork_14624_full Summary ---

Re: [Intel-gfx] [PATCH v2 00/21] drm/dp: Various helper improvements and cleanups

2019-10-02 Thread Thierry Reding
On Mon, Sep 23, 2019 at 04:52:02PM +0200, Thierry Reding wrote: > On Mon, Sep 23, 2019 at 04:52:50PM +0300, Jani Nikula wrote: > > On Fri, 20 Sep 2019, Thierry Reding wrote: > > > On Mon, Sep 02, 2019 at 01:31:00PM +0200, Thierry Reding wrote: > > >> From: Thierry Reding > > >> > > >> Hi, > >

Re: [Intel-gfx] [PATCH 21/27] drm/i915: Move context management under GEM

2019-10-02 Thread Tvrtko Ursulin
Ping on some comments from the previous round: On 26/09/2019 14:57, Tvrtko Ursulin wrote: On 25/09/2019 11:01, Chris Wilson wrote: Keep track of the GEM contexts underneath i915->gem.contexts and assign them their own lock for the purposes of list management. Signed-off-by: Chris Wilson Cc:

Re: [Intel-gfx] [PATCH 22/30] drm/i915: Remove logical HW ID

2019-10-02 Thread Tvrtko Ursulin
On 02/10/2019 12:19, Chris Wilson wrote: With the introduction of ctx->engines[] we allow multiple logical contexts to be used on the same engine (e.g. with virtual engines). According to bspec, aach logical context requires a unique tag in order for context-switching to occur correctly between

[Intel-gfx] [PATCH] drm/i915/gt: Warn CI about an unrecoverable wedge

2019-10-02 Thread Chris Wilson
If we have a wedged GPU that we need to recover, but fail, add a taint for CI to pickup and schedule a reboot. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Petri Latvala --- drivers/gpu/drm/i915/gt/intel_reset.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [RFC PATCH] drm/i915/debugfs: Only wedge if we have reset available

2019-10-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-02 16:45:18) > > On 02/10/2019 13:48, Janusz Krzysztofik wrote: > > If we process DROP_RESET_ACTIVE and cancel all outstanding requests by > > forcing a GPU reset on a hardware with reset capabilities disabled or > > not supported, we certainly end up with a

Re: [Intel-gfx] [PATCH 14/30] drm/i915: Move request runtime management onto gt

2019-10-02 Thread Tvrtko Ursulin
On 02/10/2019 12:19, Chris Wilson wrote: Requests are run from the gt and are tided into the gt runtime power management, so pull the runtime request management under gt/ Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Makefile | 1 +

Re: [Intel-gfx] [PATCH 13/30] drm/i915/gem: Retire directly for mmap-offset shrinking

2019-10-02 Thread Tvrtko Ursulin
On 02/10/2019 12:19, Chris Wilson wrote: Now that we can retire without taking struct_mutex, we can do so to handle shrinking the mmap-offset space after an allocation failure. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_mman.c |

Re: [Intel-gfx] [PATCH 08/30] drm/i915: Coordinate i915_active with its own mutex

2019-10-02 Thread Tvrtko Ursulin
On 02/10/2019 12:19, Chris Wilson wrote: Forgo the struct_mutex serialisation for i915_active, and interpose its own mutex handling for active/retire. This is a multi-layered sleight-of-hand. First, we had to ensure that no active/retire callbacks accidentally inverted the mutex ordering

Re: [Intel-gfx] [PATCH 05/30] drm/i915: Mark up address spaces that may need to allocate

2019-10-02 Thread Tvrtko Ursulin
On 02/10/2019 12:19, Chris Wilson wrote: Since we cannot allocate underneath the vm->mutex (it is used in the direct-reclaim paths), we need to shift the allocations off into a mutexless worker with fence recursion prevention. To know when we need this protection, we mark up the address spaces

Re: [Intel-gfx] [RFC PATCH] drm/i915/debugfs: Only wedge if we have reset available

2019-10-02 Thread Tvrtko Ursulin
On 02/10/2019 13:48, Janusz Krzysztofik wrote: If we process DROP_RESET_ACTIVE and cancel all outstanding requests by forcing a GPU reset on a hardware with reset capabilities disabled or not supported, we certainly end up with a terminally wedged GPU, impossible to recover. That's probably

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_eio: Relax timeout for forced resets

2019-10-02 Thread Tvrtko Ursulin
On 02/10/2019 12:19, Chris Wilson wrote: It appears we cannot consistently hit our self-imposed QoS target of 2s for performing the reset (my theory is that is some RCU scheduling quirk), so relax the assertion to a measly 10s. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105957

Re: [Intel-gfx] [PATCH 4/4] drm/i915: move gmbus setup down to intel_modeset_init()

2019-10-02 Thread Ville Syrjälä
On Wed, Oct 02, 2019 at 04:18:00PM +0300, Jani Nikula wrote: > Pair the gmbus setup and teardown in the same layer. This also fixes the > double gmbus teardown on the i915_driver_modeset_probe() error path. > > Move the gmbus setup a bit later in the sequence to make the follow-up > refactoring

Re: [Intel-gfx] [PATCH 2/4] drm/i915: split out i915_switcheroo.[ch] from i915_drv.c

2019-10-02 Thread Ville Syrjälä
On Wed, Oct 02, 2019 at 04:17:58PM +0300, Jani Nikula wrote: > Split out code related to vga switcheroo register/unregister and state > handling from i915_drv.c into new i915_switcheroo.[ch] files. > > It's a bit difficult to draw the line how much to move to the new file > from i915_drv.c, but

Re: [Intel-gfx] [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem()

2019-10-02 Thread Ville Syrjälä
On Wed, Oct 02, 2019 at 04:17:57PM +0300, Jani Nikula wrote: > Rename the function per Ville's suggestion. No functional changes. > > Cc: Ville Syrjälä > Suggested-by: Ville Syrjälä > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: use DRM_ERROR() instead of drm_err()

2019-10-02 Thread Ville Syrjälä
On Wed, Oct 02, 2019 at 05:54:04PM +0300, Jani Nikula wrote: > Unify on current common usage to allow repurposing drm_err() later. Fix > newlines while at it. > > Signed-off-by: Jani Nikula Series is Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_display.c | 8

[Intel-gfx] [PATCH 2/2] drm/i915: use DRM_DEBUG_KMS() instead of drm_dbg(DRM_UT_KMS, ...)

2019-10-02 Thread Jani Nikula
Unify on current common usage to allow repurposing drm_dbg() later. Fix newlines while at it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c

[Intel-gfx] [PATCH 1/2] drm/i915: use DRM_ERROR() instead of drm_err()

2019-10-02 Thread Jani Nikula
Unify on current common usage to allow repurposing drm_err() later. Fix newlines while at it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c

Re: [Intel-gfx] [PATCH] drm/i915/dp: remove static variable for aux last status

2019-10-02 Thread Ville Syrjälä
On Wed, Oct 02, 2019 at 05:41:38PM +0300, Jani Nikula wrote: > Add aux_busy_last_status to intel_dp. Don't bother with initializing to > all ones; the only difference is potentially missing logging for one > error case if the readout is all zeros. > > Signed-off-by: Jani Nikula a Reviewed-by:

[Intel-gfx] [PATCH] drm/i915/dp: remove static variable for aux last status

2019-10-02 Thread Jani Nikula
Add aux_busy_last_status to intel_dp. Don't bother with initializing to all ones; the only difference is potentially missing logging for one error case if the readout is all zeros. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_types.h | 1 +

Re: [Intel-gfx] [PATCH 20/30] drm/i915: Cancel non-persistent contexts on close

2019-10-02 Thread Bloomfield, Jon
> -Original Message- > From: Chris Wilson > Sent: Wednesday, October 2, 2019 7:24 AM > To: Bloomfield, Jon ; intel- > g...@lists.freedesktop.org > Cc: Joonas Lahtinen ; Winiarski, Michal > > Subject: RE: [PATCH 20/30] drm/i915: Cancel non-persistent contexts on close > > Quoting

Re: [Intel-gfx] [PATCH v2] drm/i915: Cancel non-persistent contexts on close

2019-10-02 Thread Bloomfield, Jon
> -Original Message- > From: Chris Wilson > Sent: Wednesday, October 2, 2019 7:23 AM > To: intel-gfx@lists.freedesktop.org > Cc: Chris Wilson ; Joonas Lahtinen > ; Winiarski, Michal > ; Bloomfield, Jon > Subject: [PATCH v2] drm/i915: Cancel non-persistent contexts on close > > Normally,

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix audio power up sequence for gen10/11

2019-10-02 Thread Jani Nikula
On Tue, 01 Oct 2019, Kai Vehmanen wrote: > On gen10/11 platforms, driver must set the enable bit of AUD_PIN_BUF_CTL > as part of audio power up sequence. > > Failing to do this resulted in errors during display audio codec probe, > and failures during resume from suspend. > > Bugzilla:

Re: [Intel-gfx] [PATCH 21/30] drm/i915: Replace hangcheck by heartbeats

2019-10-02 Thread Chris Wilson
Quoting Bloomfield, Jon (2019-10-02 14:55:32) > > -Original Message- > > From: Chris Wilson > > Sent: Wednesday, October 2, 2019 4:20 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Chris Wilson ; Joonas Lahtinen > > ; Ursulin, Tvrtko > > ; > > Bloomfield, Jon > > Subject: [PATCH

[Intel-gfx] [PATCH v2] drm/i915: Cancel non-persistent contexts on close

2019-10-02 Thread Chris Wilson
Normally, we rely on our hangcheck to prevent persistent batches from hogging the GPU. However, if the user disables hangcheck, this mechanism breaks down. Despite our insistence that this is unsafe, the users are equally insistent that they want to use endless batches and will disable the

Re: [Intel-gfx] [PATCH 20/30] drm/i915: Cancel non-persistent contexts on close

2019-10-02 Thread Chris Wilson
Quoting Bloomfield, Jon (2019-10-02 14:52:32) > > > > -Original Message- > > From: Chris Wilson > > Sent: Wednesday, October 2, 2019 4:20 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Chris Wilson ; Joonas Lahtinen > > ; Winiarski, Michal > > ; Bloomfield, Jon > > Subject: [PATCH

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Extract random_offset() for use with a prng

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Extract random_offset() for use with a prng URL : https://patchwork.freedesktop.org/series/67489/ State : success == Summary == CI Bug Log - changes from CI_DRM_6988 -> Patchwork_14626

Re: [Intel-gfx] [PATCH v2 0/9] drm/print: add and use drm_debug_enabled()

2019-10-02 Thread Jani Nikula
On Tue, 24 Sep 2019, Jani Nikula wrote: > drm/print: move drm_debug variable to drm_print.[ch] > drm/print: add drm_debug_enabled() > drm/etnaviv: use drm_debug_enabled() to check for debug categories > drm/i2c/sil164: use drm_debug_enabled() to check for debug categories > drm/msm: use

[Intel-gfx] [PATCH] drm/i915/tgl: Add the Thunderbolt PLL divider values

2019-10-02 Thread Imre Deak
The Thunderbolt PLL divider values on TGL differ from the ICL ones, update the PLL parameter calculation function accordingly. Bspec: 49204 Cc: Jose Souza Cc: Clinton A Taylor Cc: Lucas De Marchi Cc: Mika Westerberg Tested-by: Mika Westerberg Signed-off-by: Imre Deak ---

Re: [Intel-gfx] [PATCH 20/30] drm/i915: Cancel non-persistent contexts on close

2019-10-02 Thread Chris Wilson
Quoting Bloomfield, Jon (2019-10-02 14:52:32) > > > > -Original Message- > > From: Chris Wilson > > Sent: Wednesday, October 2, 2019 4:20 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Chris Wilson ; Joonas Lahtinen > > ; Winiarski, Michal > > ; Bloomfield, Jon > > Subject: [PATCH

[Intel-gfx] [PATCH V6] drm/drm_vblank: Change EINVAL by the correct errno

2019-10-02 Thread Rodrigo Siqueira
For historical reasons, the function drm_wait_vblank_ioctl always return -EINVAL if something gets wrong. This scenario limits the flexibility for the userspace to make detailed verification of any problem and take some action. In particular, the validation of “if (!dev->irq_enabled)” in the

[Intel-gfx] [PATCH v3] drm/i915/selftests: Exercise potential false lite-restore

2019-10-02 Thread Chris Wilson
If execlists's lite-restore is based on the common GEM context tag rather than the per-intel_context LRCA, then a context switch between two intel_contexts on the same engine derived from the same GEM context will perform a lite-restore instead of a full context switch. We can exploit this by

Re: [Intel-gfx] [PATCH 21/30] drm/i915: Replace hangcheck by heartbeats

2019-10-02 Thread Bloomfield, Jon
> -Original Message- > From: Chris Wilson > Sent: Wednesday, October 2, 2019 4:20 AM > To: intel-gfx@lists.freedesktop.org > Cc: Chris Wilson ; Joonas Lahtinen > ; Ursulin, Tvrtko ; > Bloomfield, Jon > Subject: [PATCH 21/30] drm/i915: Replace hangcheck by heartbeats > > Replace sampling

Re: [Intel-gfx] [PATCH] drm/i915/display: abstract all vgaarb access to intel_vga.[ch]

2019-10-02 Thread Jani Nikula
On Tue, 01 Oct 2019, Ville Syrjälä wrote: > On Tue, Oct 01, 2019 at 06:25:06PM +0300, Jani Nikula wrote: >> Split out the code related to vga client and vgaarb all over the place >> into new intel_vga.[ch]. No functional changes. >> >> Cc: Ville Syrjälä >> Cc: Chris Wilson >> Signed-off-by:

Re: [Intel-gfx] [PATCH 20/30] drm/i915: Cancel non-persistent contexts on close

2019-10-02 Thread Bloomfield, Jon
> -Original Message- > From: Chris Wilson > Sent: Wednesday, October 2, 2019 4:20 AM > To: intel-gfx@lists.freedesktop.org > Cc: Chris Wilson ; Joonas Lahtinen > ; Winiarski, Michal > ; Bloomfield, Jon > Subject: [PATCH 20/30] drm/i915: Cancel non-persistent contexts on close > >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Extract random_offset() for use with a prng

2019-10-02 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Extract random_offset() for use with a prng URL : https://patchwork.freedesktop.org/series/67489/ State : warning == Summary == $ dim checkpatch origin/drm-tip 62126230edd7 drm/i915/selftests: Extract random_offset() for use with a prng -:37:

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore

2019-10-02 Thread Chris Wilson
Quoting Patchwork (2019-10-02 14:46:05) > == Series Details == > > Series: series starting with [01/30] drm/i915/selftests: Exercise potential > false lite-restore > URL : https://patchwork.freedesktop.org/series/67483/ > State : failure > > == Summary == > > CI Bug Log - changes from

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore

2019-10-02 Thread Patchwork
== Series Details == Series: series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore URL : https://patchwork.freedesktop.org/series/67483/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6988 -> Patchwork_14625

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore

2019-10-02 Thread Patchwork
== Series Details == Series: series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore URL : https://patchwork.freedesktop.org/series/67483/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/selftests: Exercise

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore

2019-10-02 Thread Patchwork
== Series Details == Series: series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore URL : https://patchwork.freedesktop.org/series/67483/ State : warning == Summary == $ dim checkpatch origin/drm-tip 099f6ae3c72d drm/i915/selftests: Exercise potential false

[Intel-gfx] [PATCH 3/4] drm/i915: register vga switcheroo later, unregister earlier

2019-10-02 Thread Jani Nikula
Move vga switcheroo and dsm handler register later in i915_driver_register(), and unregister in i915_driver_unregister(). The dsm handler unregister is a nop, and is only added for completeness. My unsubstantiated suspicion is that the vga switcheroo state change would not work as early as we

[Intel-gfx] [PATCH 4/4] drm/i915: move gmbus setup down to intel_modeset_init()

2019-10-02 Thread Jani Nikula
Pair the gmbus setup and teardown in the same layer. This also fixes the double gmbus teardown on the i915_driver_modeset_probe() error path. Move the gmbus setup a bit later in the sequence to make the follow-up refactoring easier, and to pinpoint any unexpected consequences of this change right

[Intel-gfx] [PATCH 2/4] drm/i915: split out i915_switcheroo.[ch] from i915_drv.c

2019-10-02 Thread Jani Nikula
Split out code related to vga switcheroo register/unregister and state handling from i915_drv.c into new i915_switcheroo.[ch] files. It's a bit difficult to draw the line how much to move to the new file from i915_drv.c, but it seemed to me keeping i915_suspend_switcheroo() and

[Intel-gfx] [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem()

2019-10-02 Thread Jani Nikula
Rename the function per Ville's suggestion. No functional changes. Cc: Ville Syrjälä Suggested-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- drivers/gpu/drm/i915/display/intel_vga.c | 2 +-

[Intel-gfx] ✓ Fi.CI.BAT: success for i915/gem_exec_schedule: Replace vgem fence with sync_file

2019-10-02 Thread Patchwork
== Series Details == Series: i915/gem_exec_schedule: Replace vgem fence with sync_file URL : https://patchwork.freedesktop.org/series/67486/ State : success == Summary == CI Bug Log - changes from CI_DRM_6988 -> IGTPW_3528 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/gem: Refactor tests on obj->ops->flags

2019-10-02 Thread Matthew Auld
On 02/10/2019 13:30, Chris Wilson wrote: We repeat obj->ops->flags in our object checks, so pull that into its own little helper for clarity. Signed-off-by: Chris Wilson Cc: Matthew Auld Reviewed-by: Matthew Auld ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Extract random_offset() for use with a prng

2019-10-02 Thread Matthew Auld
On 02/10/2019 13:24, Chris Wilson wrote: For selftests, we desire repeatability and so prefer using a prng with known seed over true randomness. Extract random_offset() as a selftest utility that can take the prng state. Suggested-by: Matthew Auld Signed-off-by: Chris Wilson Cc: Matthew Auld

[Intel-gfx] [RFC PATCH] drm/i915/debugfs: Only wedge if we have reset available

2019-10-02 Thread Janusz Krzysztofik
If we process DROP_RESET_ACTIVE and cancel all outstanding requests by forcing a GPU reset on a hardware with reset capabilities disabled or not supported, we certainly end up with a terminally wedged GPU, impossible to recover. That's probably not what we want. Before setting the GPU wedged,

[Intel-gfx] [PATCH] drm/i915/gem: Refactor tests on obj->ops->flags

2019-10-02 Thread Chris Wilson
We repeat obj->ops->flags in our object checks, so pull that into its own little helper for clarity. Signed-off-by: Chris Wilson Cc: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_object.h | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915/selftests: Extract random_offset() for use with a prng

2019-10-02 Thread Chris Wilson
For selftests, we desire repeatability and so prefer using a prng with known seed over true randomness. Extract random_offset() as a selftest utility that can take the prng state. Suggested-by: Matthew Auld Signed-off-by: Chris Wilson Cc: Matthew Auld ---

  1   2   >