Re: [Intel-gfx] Reconfigurable OA queries

2019-10-08 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-10-09 07:40:54) > On 09/10/2019 02:26, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2019-10-09 00:14:41) > >> If we start reusing it for extended parameters, we need to make fences > >> the first extended param. > > Why? > > > How do we pass a reconfigure of OA

[Intel-gfx] [PATCH v2 3/9] drm/i915/perf: allow for CS OA configs to be created lazily

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin Here we introduce a mechanism by which the execbuf part of the i915 driver will be able to request that a batch buffer containing the programming for a particular OA config be created. We'll execute these OA configuration buffers right before executing a set of userspace

[Intel-gfx] [PATCH v2 6/9] drm/i915/perf: execute OA configuration from command stream

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin We haven't run into issues with programming the global OA/NOA registers configuration from CPU so far, but HW engineers actually recommend doing this from the command streamer. On TGL in particular one of the clock domain in which some of that programming goes might not be

[Intel-gfx] [PATCH v2 5/9] drm/i915/perf: implement active wait for noa configurations

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin NOA configuration take some amount of time to apply. That amount of time depends on the size of the GT. There is no documented time for this. For example, past experimentations with powergating configuration changes seem to indicate a 60~70us delay. We go with 500us as def

[Intel-gfx] [PATCH v2 2/9] drm/i915/perf: introduce a versioning of the i915-perf uapi

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin Reporting this version will help application figure out what level of the support the running kernel provides. v2: Add i915_perf_ioctl_version() (Chris) Signed-off-by: Lionel Landwerlin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_getparam.c | 4 driv

[Intel-gfx] [PATCH v2 9/9] drm/i915/perf: allow holding preemption on filtered ctx

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin We would like to make use of perf in Vulkan. The Vulkan API is much lower level than OpenGL, with applications directly exposed to the concept of command buffers (pretty much equivalent to our batch buffers). In Vulkan, queries are always limited in scope to a command buff

Re: [Intel-gfx] Reconfigurable OA queries

2019-10-08 Thread Lionel Landwerlin
On 09/10/2019 02:26, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-10-09 00:14:41) On 09/10/2019 00:40, Chris Wilson wrote: This is Lionel's work to enable OA for Vulkan, greatly bastardised on top of the struct_mutex removal. It claims to be doing the right thing... -Chris Thanks a lo

[Intel-gfx] [PATCH v2 8/9] drm/i915: add a new perf configuration execbuf parameter

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin We want the ability to dispatch a set of command buffer to the hardware, each with a different OA configuration. To achieve this, we reuse a couple of fields from the execbuf2 struct (I CAN HAZ execbuf3?) to notify what OA configuration should be used for a batch buffer. T

[Intel-gfx] [PATCH v2 4/9] drm/i915: add support for perf configuration queries

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin Listing configurations at the moment is supported only through sysfs. This might cause issues for applications wanting to list configurations from a container where sysfs isn't available. This change adds a way to query the number of configurations and their content throu

[Intel-gfx] [PATCH v2 1/9] drm/i915/perf: store the associated engine of a stream

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin We'll use this information later to verify that a client trying to reconfigure the stream does so on the right engine. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_perf.c | 29 +++--- drivers/gpu/drm/i915/i915_perf_types.h |

[Intel-gfx] [PATCH v2 7/9] drm/i915: introduce a mechanism to extend execbuf2

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin We're planning to use this for a couple of new feature where we need to provide additional parameters to execbuf. v2: Check for invalid flags in execbuffer2 (Lionel) v3: Rename I915_EXEC_EXT -> I915_EXEC_USE_EXTENSIONS (Chris) Signed-off-by: Lionel Landwerlin Reviewed-

Re: [Intel-gfx] Reconfigurable OA queries

2019-10-08 Thread Lionel Landwerlin
On 09/10/2019 02:26, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-10-09 00:14:41) On 09/10/2019 00:40, Chris Wilson wrote: This is Lionel's work to enable OA for Vulkan, greatly bastardised on top of the struct_mutex removal. It claims to be doing the right thing... -Chris Thanks a lo

[Intel-gfx] [PATCH] drm/i915/selftests: Hold request reference over waits

2019-10-08 Thread Chris Wilson
Take a reference on the request before submitting it to the HW and then waiting on it for selftest_workarounds. Once submitted, the request may be freed by a background worker, unless we take an extra reference for ourselves. References: https://bugs.freedesktop.org/show_bug.cgi?id=111926 Signed-o

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/9] drm/i915/perf: store the associated engine of a stream

2019-10-08 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915/perf: store the associated engine of a stream URL : https://patchwork.freedesktop.org/series/67754/ State : success == Summary == CI Bug Log - changes from CI_DRM_7036_full -> Patchwork_14711_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Select DPLL's via mask (rev3)

2019-10-08 Thread Patchwork
== Series Details == Series: drm/i915: Select DPLL's via mask (rev3) URL : https://patchwork.freedesktop.org/series/67740/ State : success == Summary == CI Bug Log - changes from CI_DRM_7035_full -> Patchwork_14709_full Summary --- *

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Give engine->kernel_context distinct timeline lock classes

2019-10-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Give engine->kernel_context distinct timeline lock classes URL : https://patchwork.freedesktop.org/series/67748/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7035_full -> Patchwork_14708_full ==

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,v3,1/2] drm/i915: Move SAGV block time to dev_priv

2019-10-08 Thread Patchwork
== Series Details == Series: series starting with [CI,v3,1/2] drm/i915: Move SAGV block time to dev_priv URL : https://patchwork.freedesktop.org/series/67743/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7035_full -> Patchwork_14706_full =

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Hold request reference over waits

2019-10-08 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Hold request reference over waits URL : https://patchwork.freedesktop.org/series/67757/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7037 -> Patchwork_14714 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/9] drm/i915: Expose 10:10:10 XRGB formats on SNB-BDW sprites

2019-10-08 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915: Expose 10:10:10 XRGB formats on SNB-BDW sprites URL : https://patchwork.freedesktop.org/series/67741/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7035_full -> Patchwork_14705_full

[Intel-gfx] ✗ Fi.CI.BUILD: failure for linux-next: build failure after merge of the drm-misc tree

2019-10-08 Thread Patchwork
== Series Details == Series: linux-next: build failure after merge of the drm-misc tree URL : https://patchwork.freedesktop.org/series/67759/ State : failure == Summary == Applying: linux-next: build failure after merge of the drm-misc tree error: sha1 information is lacking or useless (drive

[Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-10-08 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_module.c:25: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_priv.h:40:10: fatal error: drm/drmP.h: No such file or directory 40 |

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Catch GTT fault errors for gen11+ planes (rev2)

2019-10-08 Thread Patchwork
== Series Details == Series: drm/i915: Catch GTT fault errors for gen11+ planes (rev2) URL : https://patchwork.freedesktop.org/series/67752/ State : success == Summary == CI Bug Log - changes from CI_DRM_7037 -> Patchwork_14713 Summary

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm tree

2019-10-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/i915/i915_gem_gtt.c between commit: 1e0a96e50882 ("drm/i915: export color_differs") from the drm tree and commit: 71724f708997 ("drm/mm: Use helpers for drm_mm_node booleans") from the drm-misc tre

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm tree

2019-10-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/i915/i915_vma.c between commits: 1e0a96e50882 ("drm/i915: export color_differs") 33dd88992313 ("drm/i915: cleanup cache-coloring") b290a78b5c3d ("drm/i915: Use helpers for drm_mm_node booleans") 5

[Intel-gfx] [PATCH] drm/i915/selftests: Hold request reference over waits

2019-10-08 Thread Chris Wilson
Take a reference on the request before submitting it to the HW and then waiting on it for selftest_workarounds. Once submitted, the request may be freed by a background worker, unless we take an extra reference for ourselves. References: https://bugs.freedesktop.org/show_bug.cgi?id=111926 Signed-o

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Enable DDI/Port G

2019-10-08 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Enable DDI/Port G URL : https://patchwork.freedesktop.org/series/67755/ State : success == Summary == CI Bug Log - changes from CI_DRM_7037 -> Patchwork_14712 Summary --- **SUCCESS** No r

[Intel-gfx] ✓ Fi.CI.IGT: success for intel_memory_region bits

2019-10-08 Thread Patchwork
== Series Details == Series: intel_memory_region bits URL : https://patchwork.freedesktop.org/series/67738/ State : success == Summary == CI Bug Log - changes from CI_DRM_7035_full -> Patchwork_14704_full Summary --- **SUCCESS** N

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm tree

2019-10-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/i915/i915_gem.c between commits: b290a78b5c3d ("drm/i915: Use helpers for drm_mm_node booleans") 2850748ef876 ("drm/i915: Pull i915_vma_pin under the vm->mutex") from the drm tree and commit: 7172

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm tree

2019-10-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/i915/i915_drv.c between commit: 2d6f6f359fd8 ("drm/i915: add i915_driver_modeset_remove()") from the drm tree and commit: f2521f7731ed ("drm/i915: switch to drm_fb_helper_remove_conflicting_pci_fra

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Catch GTT fault errors for gen11+ planes

2019-10-08 Thread Matt Roper
On Tue, Oct 08, 2019 at 10:34:48PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Catch GTT fault errors for gen11+ planes > URL : https://patchwork.freedesktop.org/series/67752/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7036 -> Patchwork_14

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm tree

2019-10-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c between commit: 8a9a982767b7 ("drm/i915: use a separate context for gpu relocs") from the drm tree and commit: 4ee92c7149da ("drm/mm: Convert drm_mm_node booleans to b

Re: [Intel-gfx] Reconfigurable OA queries

2019-10-08 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-10-09 00:14:41) > On 09/10/2019 00:40, Chris Wilson wrote: > > This is Lionel's work to enable OA for Vulkan, greatly bastardised on > > top of the struct_mutex removal. It claims to be doing the right > > thing... > > -Chris > > > > > Thanks a lot of picking this up

Re: [Intel-gfx] [PATCH v2 10/11] drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color

2019-10-08 Thread Sripada, Radhakrishna
HI, > -Original Message- > From: Pandiyan, Dhinakaran > Sent: Friday, October 4, 2019 5:08 PM > To: Sripada, Radhakrishna ; intel- > g...@lists.freedesktop.org > Cc: Syrjala, Ville ; Sharma, Shashank > ; Antognolli, Rafael > ; Roper, Matthew D > ; Chery, Nanley G > ; Ville Syrjala ; > Kond

Re: [Intel-gfx] [PATCH v3 11/11] drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression

2019-10-08 Thread Sripada, Radhakrishna
Hi Matt, > -Original Message- > From: Roper, Matthew D > Sent: Friday, October 4, 2019 4:53 PM > To: Sripada, Radhakrishna > Cc: intel-gfx@lists.freedesktop.org; Pandiyan, Dhinakaran > ; Syrjala, Ville ; > Sharma, Shashank ; Antognolli, Rafael > ; Chery, Nanley G > Subject: Re: [PATCH v3

Re: [Intel-gfx] Reconfigurable OA queries

2019-10-08 Thread Lionel Landwerlin
On 09/10/2019 00:40, Chris Wilson wrote: This is Lionel's work to enable OA for Vulkan, greatly bastardised on top of the struct_mutex removal. It claims to be doing the right thing... -Chris Thanks a lot of picking this up. I'm aware of an issue with patch 9 as I can see requests with perf

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/9] drm/i915/perf: store the associated engine of a stream

2019-10-08 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915/perf: store the associated engine of a stream URL : https://patchwork.freedesktop.org/series/67754/ State : success == Summary == CI Bug Log - changes from CI_DRM_7036 -> Patchwork_14711 =

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/9] drm/i915/perf: store the associated engine of a stream

2019-10-08 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915/perf: store the associated engine of a stream URL : https://patchwork.freedesktop.org/series/67754/ State : warning == Summary == $ dim checkpatch origin/drm-tip f9a4f9fef858 drm/i915/perf: store the associated engine of a strea

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Catch GTT fault errors for gen11+ planes

2019-10-08 Thread Patchwork
== Series Details == Series: drm/i915: Catch GTT fault errors for gen11+ planes URL : https://patchwork.freedesktop.org/series/67752/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7036 -> Patchwork_14710 Summary ---

[Intel-gfx] [PATCH] drm/i915/tgl: Enable DDI/Port G

2019-10-08 Thread Khaled Almahallawy
In TGL there we are missing the initialization of port G. Do the same as for other ports. Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/i915/display/intel_bios.c | 4 drivers/gpu/drm/i915/display/intel_display.c | 6 ++ drivers/gpu/drm/i915/display/intel_display.h | 1 + d

[Intel-gfx] [PATCH 8/9] drm/i915: add a new perf configuration execbuf parameter

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin We want the ability to dispatch a set of command buffer to the hardware, each with a different OA configuration. To achieve this, we reuse a couple of fields from the execbuf2 struct (I CAN HAZ execbuf3?) to notify what OA configuration should be used for a batch buffer. T

[Intel-gfx] [PATCH 7/9] drm/i915: introduce a mechanism to extend execbuf2

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin We're planning to use this for a couple of new feature where we need to provide additional parameters to execbuf. v2: Check for invalid flags in execbuffer2 (Lionel) v3: Rename I915_EXEC_EXT -> I915_EXEC_USE_EXTENSIONS (Chris) Signed-off-by: Lionel Landwerlin Reviewed-

[Intel-gfx] [PATCH 5/9] drm/i915/perf: implement active wait for noa configurations

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin NOA configuration take some amount of time to apply. That amount of time depends on the size of the GT. There is no documented time for this. For example, past experimentations with powergating configuration changes seem to indicate a 60~70us delay. We go with 500us as def

[Intel-gfx] [PATCH 2/9] drm/i915/perf: introduce a versioning of the i915-perf uapi

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin Reporting this version will help application figure out what level of the support the running kernel provides. v2: Add i915_perf_ioctl_version() (Chris) Signed-off-by: Lionel Landwerlin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_getparam.c | 4 driv

[Intel-gfx] [PATCH 1/9] drm/i915/perf: store the associated engine of a stream

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin We'll use this information later to verify that a client trying to reconfigure the stream does so on the right engine. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_perf.c | 29 +++--- drivers/gpu/drm/i915/i915_perf_types.h |

[Intel-gfx] [PATCH 6/9] drm/i915/perf: execute OA configuration from command stream

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin We haven't run into issues with programming the global OA/NOA registers configuration from CPU so far, but HW engineers actually recommend doing this from the command streamer. On TGL in particular one of the clock domain in which some of that programming goes might not be

[Intel-gfx] Reconfigurable OA queries

2019-10-08 Thread Chris Wilson
This is Lionel's work to enable OA for Vulkan, greatly bastardised on top of the struct_mutex removal. It claims to be doing the right thing... -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listi

[Intel-gfx] [PATCH 4/9] drm/i915: add support for perf configuration queries

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin Listing configurations at the moment is supported only through sysfs. This might cause issues for applications wanting to list configurations from a container where sysfs isn't available. This change adds a way to query the number of configurations and their content throu

[Intel-gfx] [PATCH 9/9] drm/i915/perf: allow holding preemption on filtered ctx

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin We would like to make use of perf in Vulkan. The Vulkan API is much lower level than OpenGL, with applications directly exposed to the concept of command buffers (pretty much equivalent to our batch buffers). In Vulkan, queries are always limited in scope to a command buff

[Intel-gfx] [PATCH 3/9] drm/i915/perf: allow for CS OA configs to be created lazily

2019-10-08 Thread Chris Wilson
From: Lionel Landwerlin Here we introduce a mechanism by which the execbuf part of the i915 driver will be able to request that a batch buffer containing the programming for a particular OA config be created. We'll execute these OA configuration buffers right before executing a set of userspace

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for intel_memory_region bits

2019-10-08 Thread Chris Wilson
Quoting Patchwork (2019-10-08 19:17:44) > == Series Details == > > Series: intel_memory_region bits > URL : https://patchwork.freedesktop.org/series/67738/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_7035 -> Patchwork_14704 > ===

[Intel-gfx] [PATCH] drm/i915: Catch GTT fault errors for gen11+ planes

2019-10-08 Thread Matt Roper
Gen11+ has more hardware planes than gen9 so we need to test additional pipe interrupt register bits to recognize any GTT faults that happen on these extra planes. Bspec: 50335 Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_irq.c | 4 +++- drivers/gpu/drm/i915/i915_reg.h | 8 2

Re: [Intel-gfx] [PATCH] drm/i915/gt: Give engine->kernel_context distinct timeline lock classes

2019-10-08 Thread Matthew Auld
On Tue, 8 Oct 2019 at 19:59, Chris Wilson wrote: > > Assign a separate lockclass to the perma-pinned timelines of the > kernel_context, such that we can use them from within the user timelines > should we ever need to inject GPU operations to fixup faults during > request construction. > > Signed-

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Select DPLL's via mask (rev3)

2019-10-08 Thread Patchwork
== Series Details == Series: drm/i915: Select DPLL's via mask (rev3) URL : https://patchwork.freedesktop.org/series/67740/ State : success == Summary == CI Bug Log - changes from CI_DRM_7035 -> Patchwork_14709 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Give engine->kernel_context distinct timeline lock classes

2019-10-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Give engine->kernel_context distinct timeline lock classes URL : https://patchwork.freedesktop.org/series/67748/ State : success == Summary == CI Bug Log - changes from CI_DRM_7035 -> Patchwork_14708

Re: [Intel-gfx] [PATCH -next] treewide: remove unused argument in lock_release()

2019-10-08 Thread Peter Zijlstra
On Tue, Oct 08, 2019 at 06:33:51PM +0200, Daniel Vetter wrote: > On Thu, Sep 19, 2019 at 12:09:40PM -0400, Qian Cai wrote: > > Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument > > in __lock_release"), @nested is no longer used in lock_release(), so > > remove it from all lock

Re: [Intel-gfx] [PATCH 15/24] drm/i915: Try to make bigjoiner work in atomic check, v2.

2019-10-08 Thread Ville Syrjälä
On Fri, Oct 04, 2019 at 01:35:05PM +0200, Maarten Lankhorst wrote: > When the clock is higher than the dotclock, try with 2 pipes enabled. > If we can enable 2, then we will go into big joiner mode, and steal > the adjacent crtc. > > This only links the crtc's in software, no hardware or plane > p

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Assign the intel_runtime_pm pointer for mock_uncore

2019-10-08 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Assign the intel_runtime_pm pointer for mock_uncore URL : https://patchwork.freedesktop.org/series/67736/ State : success == Summary == CI Bug Log - changes from CI_DRM_7033_full -> Patchwork_14703_full ==

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Select DPLL's via mask (rev2)

2019-10-08 Thread Patchwork
== Series Details == Series: drm/i915: Select DPLL's via mask (rev2) URL : https://patchwork.freedesktop.org/series/67740/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7035 -> Patchwork_14707 Summary --- **FAILURE**

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,v3,1/2] drm/i915: Move SAGV block time to dev_priv

2019-10-08 Thread Patchwork
== Series Details == Series: series starting with [CI,v3,1/2] drm/i915: Move SAGV block time to dev_priv URL : https://patchwork.freedesktop.org/series/67743/ State : success == Summary == CI Bug Log - changes from CI_DRM_7035 -> Patchwork_14706 ===

[Intel-gfx] [PATCH] drm/i915/gt: Give engine->kernel_context distinct timeline lock classes

2019-10-08 Thread Chris Wilson
Assign a separate lockclass to the perma-pinned timelines of the kernel_context, such that we can use them from within the user timelines should we ever need to inject GPU operations to fixup faults during request construction. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Matthew Auld ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,v3,1/2] drm/i915: Move SAGV block time to dev_priv

2019-10-08 Thread Patchwork
== Series Details == Series: series starting with [CI,v3,1/2] drm/i915: Move SAGV block time to dev_priv URL : https://patchwork.freedesktop.org/series/67743/ State : warning == Summary == $ dim checkpatch origin/drm-tip b44bcf0ca073 drm/i915: Move SAGV block time to dev_priv -:61: WARNING:UN

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/9] drm/i915: Expose 10:10:10 XRGB formats on SNB-BDW sprites

2019-10-08 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915: Expose 10:10:10 XRGB formats on SNB-BDW sprites URL : https://patchwork.freedesktop.org/series/67741/ State : success == Summary == CI Bug Log - changes from CI_DRM_7035 -> Patchwork_14705 ==

[Intel-gfx] ✓ Fi.CI.BAT: success for intel_memory_region bits

2019-10-08 Thread Patchwork
== Series Details == Series: intel_memory_region bits URL : https://patchwork.freedesktop.org/series/67738/ State : success == Summary == CI Bug Log - changes from CI_DRM_7035 -> Patchwork_14704 Summary --- **SUCCESS** No regressi

Re: [Intel-gfx] [PATCH 14/24] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v2.

2019-10-08 Thread Ville Syrjälä
On Fri, Oct 04, 2019 at 01:35:04PM +0200, Maarten Lankhorst wrote: > Small changes to intel_dp_mode_valid(), allow listing modes that > can only be supported in the bigjoiner configuration, which is > not supported yet. > > eDP does not support bigjoiner, so do not expose bigjoiner only > modes on

Re: [Intel-gfx] [PATCH 12/24] drm/i915: Split plane hw and uapi state

2019-10-08 Thread Ville Syrjälä
On Fri, Oct 04, 2019 at 01:35:02PM +0200, Maarten Lankhorst wrote: > Splitting plane state is easier than splitting crtc_state, > before plane check we copy the drm properties to hw so we can > do the same in bigjoiner later on. > > We copy the state after we did all the modeset handling, but fort

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for intel_memory_region bits

2019-10-08 Thread Patchwork
== Series Details == Series: intel_memory_region bits URL : https://patchwork.freedesktop.org/series/67738/ State : warning == Summary == $ dim checkpatch origin/drm-tip 46562367c0c6 drm/i915: introduce intel_memory_region -:60: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does

[Intel-gfx] [CI] drm/i915: Select DPLL's via mask

2019-10-08 Thread Matt Roper
This slightly simplifies the EHL DPLL4 handling and also gives us more flexibility in the future in case we need to skip the use of specific PLL's (e.g., due to hardware workarounds and such). v2: - Replace GENMASK() with or'd BIT()'s to make the specific DPLLs more explicit. (Ville) - s/uns

[Intel-gfx] [CI v3 2/2] drm/i915/tgl: Read SAGV block time from PCODE

2019-10-08 Thread James Ausmus
Starting from TGL, we now need to read the SAGV block time via a PCODE mailbox, rather than having a static value. BSpec: 49326 v2: Fix up pcode val data type (Ville), tighten variable scope (Ville) Cc: Ville Syrjälä Cc: Stanislav Lisovskiy Cc: Lucas De Marchi Signed-off-by: James Ausmus Rev

[Intel-gfx] [CI v3 1/2] drm/i915: Move SAGV block time to dev_priv

2019-10-08 Thread James Ausmus
In prep for newer platforms having more complicated ways to determine the SAGV block time, move the variable to dev_priv, and extract the setting to an initial setup function. While we're at it, update the if ladder to follow the new gen -> old gen order preference, and warn on any non-specified ge

Re: [Intel-gfx] [PATCH 07/24] drm/i915: Introduce intel_atomic_get_plane_state_after_check()

2019-10-08 Thread Ville Syrjälä
On Fri, Oct 04, 2019 at 01:34:57PM +0200, Maarten Lankhorst wrote: > Use this in all the places where we try to acquire planes after the planes > atomic_check(). > > In case of intel_modeset_all_pipes() this is not yet done after atomic_check, > but seems like it will be in the future. To add some

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Flush submission tasklet before waiting/retiring

2019-10-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Flush submission tasklet before waiting/retiring URL : https://patchwork.freedesktop.org/series/67732/ State : success == Summary == CI Bug Log - changes from CI_DRM_7032_full -> Patchwork_14701_full

Re: [Intel-gfx] [PATCH] drm/i915: Select DPLL's via mask

2019-10-08 Thread Lucas De Marchi
On Tue, Oct 08, 2019 at 07:28:45PM +0300, Ville Syrjälä wrote: On Tue, Oct 08, 2019 at 09:12:52AM -0700, Matt Roper wrote: This slightly simplifies the EHL DPLL4 handling and also gives us more flexibility in the future in case we need to skip the use of specific PLL's (e.g., due to hardware wor

Re: [Intel-gfx] [PATCH -next] treewide: remove unused argument in lock_release()

2019-10-08 Thread Daniel Vetter
On Thu, Sep 19, 2019 at 12:09:40PM -0400, Qian Cai wrote: > Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument > in __lock_release"), @nested is no longer used in lock_release(), so > remove it from all lock_release() calls and friends. > > Signed-off-by: Qian Cai Ack on the

Re: [Intel-gfx] [PATCH] drm/i915: Select DPLL's via mask

2019-10-08 Thread Ville Syrjälä
On Tue, Oct 08, 2019 at 09:12:52AM -0700, Matt Roper wrote: > This slightly simplifies the EHL DPLL4 handling and also gives us more > flexibility in the future in case we need to skip the use of specific > PLL's (e.g., due to hardware workarounds and such). > > Cc: Lucas De Marchi > Signed-off-b

Re: [Intel-gfx] [PATCH] drm/i915: Select DPLL's via mask

2019-10-08 Thread Lucas De Marchi
On Tue, Oct 08, 2019 at 09:12:52AM -0700, Matt Roper wrote: This slightly simplifies the EHL DPLL4 handling and also gives us more flexibility in the future in case we need to skip the use of specific PLL's (e.g., due to hardware workarounds and such). Cc: Lucas De Marchi Signed-off-by: Matt Ro

[Intel-gfx] [PATCH 7/9] drm/i915: Reject ckey+fp16 on skl+

2019-10-08 Thread Ville Syrjala
From: Ville Syrjälä According to the spec color keying is not supported with fp16 pixel formats on skl+. Reject that combo. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sprite.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 6/9] drm/i915: Sort format arrays consistently

2019-10-08 Thread Ville Syrjala
From: Ville Syrjälä Let's try to keep the pixel format arrays somewhat sorted: 1. RGB before YUV 2. smaller bpp before larger bpp 3. X before A 4. RGB before BGR Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_sprite.c

[Intel-gfx] [PATCH 1/9] drm/i915: Expose 10:10:10 XRGB formats on SNB-BDW sprites

2019-10-08 Thread Ville Syrjala
From: Ville Syrjälä SNB-BDW support 10:10:10 formats on the sprite planes. Let's expose them. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sprite.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/driver

[Intel-gfx] [PATCH 2/9] drm/i915: Expose alpha formats on VLV/CHV primary planes

2019-10-08 Thread Ville Syrjala
From: Ville Syrjälä Currently we expose VLV/CHV alpha blending only on the sprite planes, but the primary planes can do it as well. Let's flip it on. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 57 +++- drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 3/9] drm/i915: Add missing 10bpc formats for pipe B sprites on CHV

2019-10-08 Thread Ville Syrjala
From: Ville Syrjälä CHV pipe B sprites gained support for the 10bpc X/ARGB pixel formats. On VLV and CHV pipe A/C these are only supported by the the primary plane. Add the require bits to expose the new formats. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sprite.c | 33

[Intel-gfx] [PATCH 5/9] drm/i915: Add 10bpc formats with alpha for icl+

2019-10-08 Thread Ville Syrjala
From: Ville Syrjälä ICL+ again supports alpha blending with 10bpc pixel formats. Expose them. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sprite.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i9

[Intel-gfx] [PATCH 9/9] drm/i915: Eliminate redundancy in intel_primary_plane_create()

2019-10-08 Thread Ville Syrjala
From: Ville Syrjälä Lots of redundant assignments inside intel_primary_plane_create(). Get rid of them. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 43 +++- 1 file changed, 14 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 8/9] drm/i915: Do not enable HDR mode when color keying is active

2019-10-08 Thread Ville Syrjala
From: Ville Syrjälä The spec says that color keying and HDR mode are mutually exclusive. So let's not enable HDR mode when color keying is active. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 5 + drivers/gpu/drm/i915/display/intel_display.c

[Intel-gfx] [PATCH 4/9] drm/i915: Expose C8 on VLV/CHV sprite planes

2019-10-08 Thread Ville Syrjala
From: Ville Syrjälä VLV/CHV sprite planes also support the C8 format. Let's expose that. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sprite.c | 6 ++ drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH] drm/i915: Select DPLL's via mask

2019-10-08 Thread Matt Roper
This slightly simplifies the EHL DPLL4 handling and also gives us more flexibility in the future in case we need to skip the use of specific PLL's (e.g., due to hardware workarounds and such). Cc: Lucas De Marchi Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 42 +

Re: [Intel-gfx] [PATCH 2/3] drm/i915/region: support contiguous allocations

2019-10-08 Thread Chris Wilson
Quoting Matthew Auld (2019-10-08 17:01:15) > Some kernel internal objects may need to be allocated as a contiguous > block, also thinking ahead the various kernel io_mapping interfaces seem > to expect it, although this is purely a limitation in the kernel > API...so perhaps something to be improve

Re: [Intel-gfx] [PATCH 1/3] drm/i915: introduce intel_memory_region

2019-10-08 Thread Chris Wilson
Quoting Matthew Auld (2019-10-08 17:01:14) > +static void close_objects(struct intel_memory_region *mem, > + struct list_head *objects) > +{ > + struct drm_i915_private *i915 = mem->i915; > + struct drm_i915_gem_object *obj, *on; > + > + list_for_each_entry

[Intel-gfx] [PATCH 3/3] drm/i915/region: support volatile objects

2019-10-08 Thread Matthew Auld
Volatile objects are marked as DONTNEED while pinned, therefore once unpinned the backing store can be discarded. This is limited to kernel internal objects. Signed-off-by: Matthew Auld Signed-off-by: CQ Tang Cc: Joonas Lahtinen Cc: Abdiel Janulgue Reviewed-by: Chris Wilson --- drivers/gpu/d

[Intel-gfx] [PATCH 0/3] intel_memory_region bits

2019-10-08 Thread Matthew Auld
First block of patches from the 'LMEM basics' series. Matthew Auld (3): drm/i915: introduce intel_memory_region drm/i915/region: support contiguous allocations drm/i915/region: support volatile objects drivers/gpu/drm/i915/Makefile | 2 + drivers/gpu/drm/i915/gem/i915_gem

[Intel-gfx] [PATCH 2/3] drm/i915/region: support contiguous allocations

2019-10-08 Thread Matthew Auld
Some kernel internal objects may need to be allocated as a contiguous block, also thinking ahead the various kernel io_mapping interfaces seem to expect it, although this is purely a limitation in the kernel API...so perhaps something to be improved. Signed-off-by: Matthew Auld Cc: Joonas Lahtine

[Intel-gfx] [PATCH 1/3] drm/i915: introduce intel_memory_region

2019-10-08 Thread Matthew Auld
Support memory regions, as defined by a given (start, end), and allow creating GEM objects which are backed by said region. The immediate goal here is to have something to represent our device memory, but later on we also want to represent every memory domain with a region, so stolen, shmem, and of

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Assign the intel_runtime_pm pointer for mock_uncore

2019-10-08 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Assign the intel_runtime_pm pointer for mock_uncore URL : https://patchwork.freedesktop.org/series/67736/ State : success == Summary == CI Bug Log - changes from CI_DRM_7033 -> Patchwork_14703

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use a modparam to restrict exposed engines

2019-10-08 Thread Summers, Stuart
On Tue, 2019-10-01 at 14:54 +0100, Chris Wilson wrote: > Allow the user to restrict the available set of engines via a module > parameter. > > Signed-off-by: Chris Wilson > Cc: Stuart Summers > Cc: Andi Shyti > Cc: Mika Kuoppala > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen > Cc: Martin Peres

Re: [Intel-gfx] [PATCH 2/2] drm/i915/tgl: Restrict availables engines to rcs0 by default

2019-10-08 Thread Summers, Stuart
On Tue, 2019-10-01 at 14:54 +0100, Chris Wilson wrote: > CI is still unstable whenever we enable more than one engine, and we > have not yet found a better hack than restricting it to using just > rcs0. > > However, to allow testing to continue on the other engines by > developers, we allow the av

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Assign the intel_runtime_pm pointer for mock_uncore

2019-10-08 Thread Matthew Auld
On Tue, 8 Oct 2019 at 15:50, Chris Wilson wrote: > > Couple up our mock_uncore to know about the fake global device and its > runtime powermanagement. > > Signed-off-by: Chris Wilson > Cc: Matthew Auld Thanks, Reviewed-by: Matthew Auld ___ Intel-gfx

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/perf: drop list of streams

2019-10-08 Thread Patchwork
== Series Details == Series: drm/i915/perf: drop list of streams URL : https://patchwork.freedesktop.org/series/67734/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7033 -> Patchwork_14702 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH] drm/i915/gt: Flush submission tasklet before waiting/retiring

2019-10-08 Thread Summers, Stuart
On Tue, 2019-10-08 at 15:56 +0100, Chris Wilson wrote: > Quoting Summers, Stuart (2019-10-08 15:52:15) > > On Tue, 2019-10-08 at 11:56 +0100, Chris Wilson wrote: > > > A common bane of ours is arbitrary delays in ksoftirqd processing > > > our > > > submission tasklet. Give the submission tasklet a

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Describe structure member in documentation (rev2)

2019-10-08 Thread Patchwork
== Series Details == Series: drm/i915: Describe structure member in documentation (rev2) URL : https://patchwork.freedesktop.org/series/67102/ State : success == Summary == CI Bug Log - changes from CI_DRM_7032_full -> Patchwork_14700_full

Re: [Intel-gfx] [PATCH] drm/i915/gt: Flush submission tasklet before waiting/retiring

2019-10-08 Thread Chris Wilson
Quoting Summers, Stuart (2019-10-08 15:52:15) > On Tue, 2019-10-08 at 11:56 +0100, Chris Wilson wrote: > > A common bane of ours is arbitrary delays in ksoftirqd processing our > > submission tasklet. Give the submission tasklet a kick before we wait > > to > > avoid those delays eating into a tigh

Re: [Intel-gfx] [v8, 2/4] drm/panel: set display info in panel attach

2019-10-08 Thread Sean Paul
/snip > > > > > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > > > > > index d16158deacdc..f3587a54b8ac 100644 > > > > > --- a/include/drm/drm_panel.h > > > > > +++ b/include/drm/drm_panel.h > > > > > @@ -141,6 +141,56 @@ struct drm_panel { > > > > >*/ > > > > > con

  1   2   >