[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm/i915/display: Handle fused off display correctly

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/display: Handle fused off display correctly URL : https://patchwork.freedesktop.org/series/68247/ State : success == Summary == CI Bug Log - changes from CI_DRM_7133_full -> Patchwork_14891_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915/display: Handle fused off display correctly

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/display: Handle fused off display correctly URL : https://patchwork.freedesktop.org/series/68247/ State : success == Summary == CI Bug Log - changes from CI_DRM_7133 -> Patchwork_14891

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/5] drm/i915: simplify setting of ddi_io_power_domain (rev4)

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [CI,1/5] drm/i915: simplify setting of ddi_io_power_domain (rev4) URL : https://patchwork.freedesktop.org/series/68069/ State : success == Summary == CI Bug Log - changes from CI_DRM_7132_full -> Patchwork_14890_full

[Intel-gfx] [PATCH 1/5] drm/i915/display: Handle fused off display correctly

2019-10-18 Thread José Roberto de Souza
If all pipes are fused off it means that display is disabled, similar like we handle for GEN 7 and 8 right above but for GEN9+ spec says that hardware will override the pipe output to a solid color, so some display is there and maybe we would need to shutdown display to save power, so setting

[Intel-gfx] [PATCH 4/5] drm/i915/display/icl+: Check if DMC is fused off

2019-10-18 Thread José Roberto de Souza
Check if DMC is fused off and handle it. Cc: Ville Syrjälä Cc: Martin Peres Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_device_info.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 2/5] drm/i915/display: Handle fused off HDCP

2019-10-18 Thread José Roberto de Souza
HDCP could be fused off, so not all GEN9+ platforms will support it. Cc: Ville Syrjälä Cc: Martin Peres Reviewed-by: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915/i915_pci.c | 2 ++

[Intel-gfx] [PATCH 5/5] drm/i915/display/cnl+: Handle fused off DSC

2019-10-18 Thread José Roberto de Souza
DSC could be fused off, so not all GEN10+ platforms will support it. Cc: Manasi Navare Cc: Martin Peres Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_dp.c | 3 +++ drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 1 +

[Intel-gfx] [PATCH 3/5] drm/i915/display: Check if FBC is fused off

2019-10-18 Thread José Roberto de Souza
Check if FBC is fused off and handle it. Cc: Ville Syrjälä Cc: Martin Peres Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_device_info.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h

Re: [Intel-gfx] [PATCH] drm/i915/tc: Implement the TC cold exit sequence

2019-10-18 Thread Souza, Jose
On Thu, 2019-10-03 at 17:50 +0300, Imre Deak wrote: > On Mon, Sep 30, 2019 at 05:55:36PM -0700, José Roberto de Souza > wrote: > > This is required for legacy/static TC ports as IOM is not aware of > > the connection and will not trigger the TC cold exit. > > > > BSpec: 21750 > > BSpsc: 49294 > >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/5] drm/i915: simplify setting of ddi_io_power_domain (rev4)

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [CI,1/5] drm/i915: simplify setting of ddi_io_power_domain (rev4) URL : https://patchwork.freedesktop.org/series/68069/ State : success == Summary == CI Bug Log - changes from CI_DRM_7132 -> Patchwork_14890

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/perf: enable OAR context save/restore of performance counters

2019-10-18 Thread Chris Wilson
Quoting Umesh Nerlige Ramappa (2019-10-18 01:50:27) > From: Lionel Landwerlin > > We want this so we can preempt performance queries and keep the system > responsive even when long running queries are ongoing. We avoid doing > it for all contexts. > > v2: use LRI to modify context control

Re: [Intel-gfx] [PATCH 02/13] drm/i915/selftests: Add coverage of mocs registers

2019-10-18 Thread Chris Wilson
Quoting Kumar Valsan, Prathap (2019-10-19 00:24:13) > On Fri, Oct 18, 2019 at 11:14:39PM +0100, Chris Wilson wrote: > > +static int check_l3cc_table(struct intel_engine_cs *engine, > > + const struct drm_i915_mocs_table *table, > > + const u32

Re: [Intel-gfx] [CI v12 5/6] drm/i915/display/icl: Disable transcoder port sync as part of crtc_disable() sequence

2019-10-18 Thread Manasi Navare
Pushed to dinq thanks for the reviews Manasi On Fri, Oct 18, 2019 at 10:27:24AM -0700, Manasi Navare wrote: > This clears the transcoder port sync bits of the TRANS_DDI_FUNC_CTL2 > register during crtc_disable(). > > v3: > * Rebase on maarten's patches > v2: > * Directly write the

Re: [Intel-gfx] [CI v12 6/6] drm/i915/display/icl: In port sync mode disable slaves first then master

2019-10-18 Thread Manasi Navare
Pushed to dinq, thanks for reviews manasi On Fri, Oct 18, 2019 at 10:27:25AM -0700, Manasi Navare wrote: > In the transcoder port sync mode, the slave transcoders mask their vblanks > until master transcoder's vblank so while disabling them, make > sure slaves are disabled first and then the

Re: [Intel-gfx] [CI v12 4/6] drm/i915/display/icl: Enable master-slaves in trans port sync

2019-10-18 Thread Manasi Navare
Pushed to dinq, thanks for the reviews manasi On Fri, Oct 18, 2019 at 10:27:23AM -0700, Manasi Navare wrote: > As per the display enable sequence, we need to follow the enable sequence > for slaves first with DP_TP_CTL set to Idle and configure the transcoder > port sync register to select the

Re: [Intel-gfx] [CI v12 3/6] drm/i915/display/icl: HW state readout for transcoder port sync config

2019-10-18 Thread Manasi Navare
Pushed to dinq, thanks for reviews Manasi On Fri, Oct 18, 2019 at 10:27:22AM -0700, Manasi Navare wrote: > After the state is committed, we readout the HW registers and compare > the HW state with the SW state that we just committed. > For Transcdoer port sync, we add master_transcoder and the >

Re: [Intel-gfx] [CI v12 2/6] drm/i915/display/icl: Enable TRANSCODER PORT SYNC for tiled displays across separate ports

2019-10-18 Thread Manasi Navare
Pushed to dinq, thanks for reviews Manasi On Fri, Oct 18, 2019 at 10:27:21AM -0700, Manasi Navare wrote: > In case of tiled displays where different tiles are displayed across > different ports, we need to synchronize the transcoders involved. > This patch implements the transcoder port sync

Re: [Intel-gfx] [CI v12 1/6] drm/i915/display/icl: Save Master transcoder in slave's crtc_state for Transcoder Port Sync

2019-10-18 Thread Manasi Navare
Pushed to dinq, thank you all for reviews! Manasi On Fri, Oct 18, 2019 at 10:27:20AM -0700, Manasi Navare wrote: > In case of tiled displays when the two tiles are sent across two CRTCs > over two separate DP SST connectors, we need a mechanism to synchronize > the two CRTCs and their

Re: [Intel-gfx] [PATCH 02/13] drm/i915/selftests: Add coverage of mocs registers

2019-10-18 Thread Kumar Valsan, Prathap
On Fri, Oct 18, 2019 at 11:14:39PM +0100, Chris Wilson wrote: > Probe the mocs registers for new contexts and across GPU resets. Similar > to intel_workarounds, we have tables of what register values we expect > to see, so verify that user contexts are affected by them. In the > future, we should

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/5] drm/i915: simplify setting of ddi_io_power_domain (rev4)

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [CI,1/5] drm/i915: simplify setting of ddi_io_power_domain (rev4) URL : https://patchwork.freedesktop.org/series/68069/ State : warning == Summary == $ dim checkpatch origin/drm-tip f64128fd71f7 drm/i915: simplify setting of

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/13] drm/i915: Don't set queue_priority_hint if we don't kick the submission

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [01/13] drm/i915: Don't set queue_priority_hint if we don't kick the submission URL : https://patchwork.freedesktop.org/series/68243/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7132 -> Patchwork_14889

Re: [Intel-gfx] [PATCH 2/6] drm/i915: setup io-mapping for LMEM

2019-10-18 Thread Chris Wilson
Quoting Matthew Auld (2019-10-18 17:55:54) > From: Abdiel Janulgue > > Signed-off-by: Abdiel Janulgue > Cc: Matthew Auld Looks reasonable, Reviewed-by: Chris Wilson -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH 3/6] drm/i915/lmem: support kernel mapping

2019-10-18 Thread Chris Wilson
Quoting Matthew Auld (2019-10-18 17:55:55) > From: Abdiel Janulgue > > We can create LMEM objects, but we also need to support mapping them > into kernel space for internal use. > > Signed-off-by: Abdiel Janulgue > Signed-off-by: Matthew Auld > Signed-off-by: Steve Hampson > Cc: Joonas

Re: [Intel-gfx] [PATCH 4/6] drm/i915/selftests: add write-dword test for LMEM

2019-10-18 Thread Chris Wilson
Quoting Matthew Auld (2019-10-18 17:55:56) > Simple test writing to dwords across an object, using various engines in > a randomized order, checking that our writes land from the cpu. > > Signed-off-by: Matthew Auld Looks like a good base to build upon, and gives a useful sanity check.

Re: [Intel-gfx] [PATCH 5/6] drm/i915/selftests: extend coverage to include LMEM huge-pages

2019-10-18 Thread Chris Wilson
Quoting Matthew Auld (2019-10-18 17:55:57) > Add LMEM objects to list of backends we test for huge-GTT-pages. > > Signed-off-by: Matthew Auld Looks consistent with our current test strategy and useful, Reviewed-by: Chris Wilson -Chris ___ Intel-gfx

Re: [Intel-gfx] [PATCH 6/6] drm/i915/selftests: prefer random sizes for the huge-GTT-page smoke tests

2019-10-18 Thread Chris Wilson
Quoting Matthew Auld (2019-10-18 17:55:58) > Ditch the dubious static list of sizes to enumerate, in favour of > choosing a random size within the limits of each backing store. With > repeated CI runs this should give us a wider range of object sizes, and > in turn more page-size combinations,

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/13] drm/i915: Don't set queue_priority_hint if we don't kick the submission

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [01/13] drm/i915: Don't set queue_priority_hint if we don't kick the submission URL : https://patchwork.freedesktop.org/series/68243/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: Don't set

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/13] drm/i915: Don't set queue_priority_hint if we don't kick the submission

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [01/13] drm/i915: Don't set queue_priority_hint if we don't kick the submission URL : https://patchwork.freedesktop.org/series/68243/ State : warning == Summary == $ dim checkpatch origin/drm-tip f1bf3e6b4d69 drm/i915: Don't set

[Intel-gfx] [PATCH 03/13] drm/i915/selftests: Teach igt_flush_test and igt_live_test to take intel_gt

2019-10-18 Thread Chris Wilson
Both routines operate local to the intel_gt, so pass it along as the object to work on. Signed-off-by: Chris Wilson --- .../drm/i915/gem/selftests/i915_gem_context.c | 30 +++-- .../drm/i915/gem/selftests/i915_gem_mman.c| 2 +- drivers/gpu/drm/i915/gt/selftest_context.c| 4 +-

[Intel-gfx] [PATCH 07/13] drm/i915/gt: Introduce barrier pulses along engines

2019-10-18 Thread Chris Wilson
To flush idle barriers, and even inflight requests, we want to send a preemptive 'pulse' along an engine. We use a no-op request along the pinned kernel_context at high priority so that it should run or else kick off the stuck requests. We can use this to ensure idle barriers are immediately

[Intel-gfx] [PATCH 10/13] drm/i915: Replace hangcheck by heartbeats

2019-10-18 Thread Chris Wilson
Replace sampling the engine state every so often with a periodic heartbeat request to measure the health of an engine. This is coupled with the forced-preemption to allow long running requests to survive so long as they do not block other users. The heartbeat interval can be adjusted per-engine

[Intel-gfx] [PATCH 02/13] drm/i915/selftests: Add coverage of mocs registers

2019-10-18 Thread Chris Wilson
Probe the mocs registers for new contexts and across GPU resets. Similar to intel_workarounds, we have tables of what register values we expect to see, so verify that user contexts are affected by them. In the future, we should add tests similar to intel_sseu to cover dynamic reconfigurations.

[Intel-gfx] [PATCH 12/13] drm/i915/gem: Distinguish each object type

2019-10-18 Thread Chris Wilson
Separate each object class into a separate lock type to avoid lockdep cross-contamination between paths (i.e. userptr!). Signed-off-by: Chris Wilson Cc: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 3 ++- drivers/gpu/drm/i915/gem/i915_gem_internal.c | 3 ++-

[Intel-gfx] [PATCH 13/13] drm/i915: Flush idle barriers when waiting

2019-10-18 Thread Chris Wilson
If we do find ourselves with an idle barrier inside our active while waiting, attempt to flush it by emitting a pulse using the kernel context. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gt/intel_engine_heartbeat.c | 14 + .../gpu/drm/i915/gt/intel_engine_heartbeat.h | 1 +

[Intel-gfx] [PATCH 08/13] drm/i915/execlists: Cancel banned contexts on schedule-out

2019-10-18 Thread Chris Wilson
On schedule-out (CS completion) of a banned context, scrub the context image so that we do not replay the active payload. The intent is that we skip banned payloads on request submission so that the timeline advancement continues on in the background. However, if we are returning to a preempted

[Intel-gfx] [PATCH 05/13] drm/i915: Expose timeslice duration to sysfs

2019-10-18 Thread Chris Wilson
Execlists uses a scheduling quantum (a timeslice) to alternate execution between ready-to-run contexts of equal priority. This ensures that all users (though only if they of equal importance) the opportunity to run and prevents livelocks were contexts may have implicit ordering due to userspace

[Intel-gfx] [PATCH 11/13] drm/i915/gem: Make context persistence optional

2019-10-18 Thread Chris Wilson
Our existing behaviour is to allow contexts and their GPU requests to persist past the point of closure until the requests are complete. This allows clients to operate in a 'fire-and-forget' manner where they can setup a rendering pipeline and hand it over to the display server and immediately

[Intel-gfx] [PATCH 01/13] drm/i915: Don't set queue_priority_hint if we don't kick the submission

2019-10-18 Thread Chris Wilson
If we change the priority of the active context, then it has no impact on the decision of whether to preempt the active context -- we don't preempt the context with itself. In this situation, we elide the tasklet rescheduling and should *not* be marking up the queue_priority_hint as that may mask

[Intel-gfx] [PATCH 06/13] drm/i915/execlists: Force preemption

2019-10-18 Thread Chris Wilson
If the preempted context takes too long to relinquish control, e.g. it is stuck inside a shader with arbitration disabled, evict that context with an engine reset. This ensures that preemptions are reasonably responsive, providing a tighter QoS for the more important context at the cost of

[Intel-gfx] [PATCH 09/13] drm/i915/gem: Cancel contexts when hangchecking is disabled

2019-10-18 Thread Chris Wilson
Normally, we rely on our hangcheck to prevent persistent batches from hogging the GPU. However, if the user disables hangcheck, this mechanism breaks down. Despite our insistence that this is unsafe, the users are equally insistent that they want to use endless batches and will disable the

[Intel-gfx] [PATCH 04/13] drm/i915: Expose engine properties via sysfs

2019-10-18 Thread Chris Wilson
Preliminary stub to add engines underneath /sys/class/drm/cardN/, so that we can expose properties on each engine to the sysadmin. To start with we have basic analogues of the i915_query ioctl so that we can pretty print engine discovery from the shell, and flesh out the directory structure.

Re: [Intel-gfx] [PATCH 1/6] drm/i915: support creating LMEM objects

2019-10-18 Thread Chris Wilson
Quoting Matthew Auld (2019-10-18 17:55:53) > diff --git a/drivers/gpu/drm/i915/intel_region_lmem.c > b/drivers/gpu/drm/i915/intel_region_lmem.c > new file mode 100644 > index ..7a3f96e1f766 > --- /dev/null > +++ b/drivers/gpu/drm/i915/intel_region_lmem.c > @@ -0,0 +1,43 @@ > +//

Re: [Intel-gfx] [RFC PATCH] drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove

2019-10-18 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-10-18 16:52:26) > On Fri, 18 Oct 2019 12:07:10 +0200, Janusz Krzysztofik > wrote: > > > Commit 2d6f6f359fd8 ("drm/i915: add i915_driver_modeset_remove()") > > claimed removal of asymmetry in probe() and remove() calls, however, it > > didn't take care of calling

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,v12,1/6] drm/i915/display/icl: Save Master transcoder in slave's crtc_state for Transcoder Port Sync

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [CI,v12,1/6] drm/i915/display/icl: Save Master transcoder in slave's crtc_state for Transcoder Port Sync URL : https://patchwork.freedesktop.org/series/68218/ State : success == Summary == CI Bug Log - changes from CI_DRM_7130_full ->

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/6] drm/i915: support creating LMEM objects

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: support creating LMEM objects URL : https://patchwork.freedesktop.org/series/68216/ State : success == Summary == CI Bug Log - changes from CI_DRM_7130_full -> Patchwork_14887_full

Re: [Intel-gfx] [PULL] drm-misc-next

2019-10-18 Thread Sean Paul
On Fri, Oct 18, 2019 at 9:46 AM Tomi Valkeinen wrote: > > Hi Sean, > > On 17/10/2019 22:26, Sean Paul wrote: > > > concern for those. The omap OMAP_BO_MEM_* changes though I don't think have > > really reached non-TI eyes. There's no link in the commit message to a UAPI > > implementation and the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Don't set queue_priority_hint if we don't kick the submission

2019-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Don't set queue_priority_hint if we don't kick the submission URL : https://patchwork.freedesktop.org/series/68215/ State : success == Summary == CI Bug Log - changes from CI_DRM_7130_full -> Patchwork_14886_full

Re: [Intel-gfx] [2/2] drm/i915: Check some transcoder timing minimum limits

2019-10-18 Thread Manasi Navare
On Fri, Oct 18, 2019 at 12:43:56PM -0700, Manasi Navare wrote: > From: Ville Syrjala > > From: Ville Syrjälä > > On ILK+ the documented min hdisplay is 64, min hblank is 32, and min > vblank is 5. On earlier platforms min hblank is also 32, and min > vblank is 3. Make sure the mode satisfies

[Intel-gfx] [2/2] drm/i915: Check some transcoder timing minimum limits

2019-10-18 Thread Manasi Navare
From: Ville Syrjala From: Ville Syrjälä On ILK+ the documented min hdisplay is 64, min hblank is 32, and min vblank is 5. On earlier platforms min hblank is also 32, and min vblank is 3. Make sure the mode satisfies those limits. There are further limits for HDMI and pfit use cases, but we'll

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,v12,1/6] drm/i915/display/icl: Save Master transcoder in slave's crtc_state for Transcoder Port Sync

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [CI,v12,1/6] drm/i915/display/icl: Save Master transcoder in slave's crtc_state for Transcoder Port Sync URL : https://patchwork.freedesktop.org/series/68218/ State : success == Summary == CI Bug Log - changes from CI_DRM_7130 ->

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: support creating LMEM objects

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: support creating LMEM objects URL : https://patchwork.freedesktop.org/series/68216/ State : success == Summary == CI Bug Log - changes from CI_DRM_7130 -> Patchwork_14887

Re: [Intel-gfx] Intel-gfx Digest, Vol 141, Issue 541

2019-10-18 Thread Vudum, Lakshminarayana
-Original Message- From: Intel-gfx On Behalf Of intel-gfx-requ...@lists.freedesktop.org Sent: Friday, October 18, 2019 7:30 PM To: intel-gfx@lists.freedesktop.org Subject: Intel-gfx Digest, Vol 141, Issue 541 Send Intel-gfx mailing list submissions to

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/6] drm/i915: support creating LMEM objects

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: support creating LMEM objects URL : https://patchwork.freedesktop.org/series/68216/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: support creating LMEM objects Okay! Commit:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] drm/i915: support creating LMEM objects

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: support creating LMEM objects URL : https://patchwork.freedesktop.org/series/68216/ State : warning == Summary == $ dim checkpatch origin/drm-tip 69e50fdbd4bb drm/i915: support creating LMEM objects -:35:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't set queue_priority_hint if we don't kick the submission

2019-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Don't set queue_priority_hint if we don't kick the submission URL : https://patchwork.freedesktop.org/series/68215/ State : success == Summary == CI Bug Log - changes from CI_DRM_7130 -> Patchwork_14886

[Intel-gfx] [CI v12 3/6] drm/i915/display/icl: HW state readout for transcoder port sync config

2019-10-18 Thread Manasi Navare
After the state is committed, we readout the HW registers and compare the HW state with the SW state that we just committed. For Transcdoer port sync, we add master_transcoder and the salves bitmask to the crtc_state, hence we need to read those during the HW state readout to avoid pipe state

[Intel-gfx] [CI v12 5/6] drm/i915/display/icl: Disable transcoder port sync as part of crtc_disable() sequence

2019-10-18 Thread Manasi Navare
This clears the transcoder port sync bits of the TRANS_DDI_FUNC_CTL2 register during crtc_disable(). v3: * Rebase on maarten's patches v2: * Directly write the trans_port_sync reg value (Maarten) Cc: Ville Syrjälä Cc: Maarten Lankhorst Cc: Matt Roper Cc: Jani Nikula Signed-off-by: Manasi

[Intel-gfx] [CI v12 2/6] drm/i915/display/icl: Enable TRANSCODER PORT SYNC for tiled displays across separate ports

2019-10-18 Thread Manasi Navare
In case of tiled displays where different tiles are displayed across different ports, we need to synchronize the transcoders involved. This patch implements the transcoder port sync feature for synchronizing one master transcoder with one or more slave transcoders. This is only enbaled in slave

[Intel-gfx] [CI v12 1/6] drm/i915/display/icl: Save Master transcoder in slave's crtc_state for Transcoder Port Sync

2019-10-18 Thread Manasi Navare
In case of tiled displays when the two tiles are sent across two CRTCs over two separate DP SST connectors, we need a mechanism to synchronize the two CRTCs and their corresponding transcoders. So use the master-slave mode where there is one master corresponding to last horizontal and vertical

[Intel-gfx] [CI v12 6/6] drm/i915/display/icl: In port sync mode disable slaves first then master

2019-10-18 Thread Manasi Navare
In the transcoder port sync mode, the slave transcoders mask their vblanks until master transcoder's vblank so while disabling them, make sure slaves are disabled first and then the masters. v5: * Dont pass dev priv to get_slave_crtc (Ville) v4: * Obtain slave state from master (Maarten) v3: *

[Intel-gfx] [CI v12 4/6] drm/i915/display/icl: Enable master-slaves in trans port sync

2019-10-18 Thread Manasi Navare
As per the display enable sequence, we need to follow the enable sequence for slaves first with DP_TP_CTL set to Idle and configure the transcoder port sync register to select the corersponding master, then follow the enable sequence for master leaving DP_TP_CTL to idle. At this point the

[Intel-gfx] [PATCH 6/6] drm/i915/selftests: prefer random sizes for the huge-GTT-page smoke tests

2019-10-18 Thread Matthew Auld
Ditch the dubious static list of sizes to enumerate, in favour of choosing a random size within the limits of each backing store. With repeated CI runs this should give us a wider range of object sizes, and in turn more page-size combinations, while using less machine time. Signed-off-by: Matthew

[Intel-gfx] [PATCH 5/6] drm/i915/selftests: extend coverage to include LMEM huge-pages

2019-10-18 Thread Matthew Auld
Add LMEM objects to list of backends we test for huge-GTT-pages. Signed-off-by: Matthew Auld --- .../gpu/drm/i915/gem/selftests/huge_pages.c | 121 +- 1 file changed, 120 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c

[Intel-gfx] [PATCH 2/6] drm/i915: setup io-mapping for LMEM

2019-10-18 Thread Matthew Auld
From: Abdiel Janulgue Signed-off-by: Abdiel Janulgue Cc: Matthew Auld --- drivers/gpu/drm/i915/intel_region_lmem.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_region_lmem.c b/drivers/gpu/drm/i915/intel_region_lmem.c

[Intel-gfx] [PATCH 4/6] drm/i915/selftests: add write-dword test for LMEM

2019-10-18 Thread Matthew Auld
Simple test writing to dwords across an object, using various engines in a randomized order, checking that our writes land from the cpu. Signed-off-by: Matthew Auld --- .../drm/i915/selftests/intel_memory_region.c | 167 ++ 1 file changed, 167 insertions(+) diff --git

[Intel-gfx] [PATCH 1/6] drm/i915: support creating LMEM objects

2019-10-18 Thread Matthew Auld
We currently define LMEM, or local memory, as just another memory region, like system memory or stolen, which we can expose to userspace and can be mapped to the CPU via some BAR. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Abdiel Janulgue --- drivers/gpu/drm/i915/Makefile

[Intel-gfx] [PATCH 3/6] drm/i915/lmem: support kernel mapping

2019-10-18 Thread Matthew Auld
From: Abdiel Janulgue We can create LMEM objects, but we also need to support mapping them into kernel space for internal use. Signed-off-by: Abdiel Janulgue Signed-off-by: Matthew Auld Signed-off-by: Steve Hampson Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 36

[Intel-gfx] [PATCH] drm/i915: Don't set queue_priority_hint if we don't kick the submission

2019-10-18 Thread Chris Wilson
If we change the priority of the active context, then it has no impact on the decision of whether to preempt the active context -- we don't preempt the context with itself. In this situation, we elide the tasklet rescheduling and should *not* be marking up the queue_priority_hint as that may mask

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Split memory_region initialisation into its own file

2019-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Split memory_region initialisation into its own file URL : https://patchwork.freedesktop.org/series/68200/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7129 -> Patchwork_14884

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Correct the PCH type in irq postinstall (rev2)

2019-10-18 Thread Matt Roper
On Fri, Oct 18, 2019 at 04:01:56AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Correct the PCH type in irq postinstall (rev2) > URL : https://patchwork.freedesktop.org/series/68116/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7122_full ->

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Add the mock engine to the gt->engine[]

2019-10-18 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add the mock engine to the gt->engine[] URL : https://patchwork.freedesktop.org/series/68201/ State : failure == Summary == Applying: drm/i915/selftests: Add the mock engine to the gt->engine[] Using index info to reconstruct a base tree... M

Re: [Intel-gfx] [PATCH] drm/i915: Split memory_region initialisation into its own file

2019-10-18 Thread Matthew Auld
On Fri, 18 Oct 2019 at 13:48, Chris Wilson wrote: > > Pull the memory region bookkeeping into its file. Let's start clean and > see how long it lasts! > > Signed-off-by: Chris Wilson > Cc: Matthew Auld Much better, Reviewed-by: Matthew Auld ___

Re: [Intel-gfx] [PATCH 3/4] drm/edid: Fix HDMI VIC handling

2019-10-18 Thread Shankar, Uma
>-Original Message- >From: Intel-gfx On Behalf Of Ville >Syrjala >Sent: Friday, October 4, 2019 7:49 PM >To: dri-de...@lists.freedesktop.org >Cc: intel-gfx@lists.freedesktop.org; Wayne Lin >Subject: [Intel-gfx] [PATCH 3/4] drm/edid: Fix HDMI VIC handling > >From: Ville Syrjälä >

Re: [Intel-gfx] [RFC PATCH] drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove

2019-10-18 Thread Michal Wajdeczko
On Fri, 18 Oct 2019 12:07:10 +0200, Janusz Krzysztofik wrote: Commit 2d6f6f359fd8 ("drm/i915: add i915_driver_modeset_remove()") claimed removal of asymmetry in probe() and remove() calls, however, it didn't take care of calling intel_irq_uninstall() on driver remove. That doesn't hurt as

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Split memory_region initialisation into its own file

2019-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Split memory_region initialisation into its own file URL : https://patchwork.freedesktop.org/series/68200/ State : warning == Summary == $ dim checkpatch origin/drm-tip 36c94b0bae3b drm/i915: Split memory_region initialisation into its own file -:202:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object VMA (rev2)

2019-10-18 Thread Patchwork
== Series Details == Series: drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object VMA (rev2) URL : https://patchwork.freedesktop.org/series/68162/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7129 -> Patchwork_14883

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/3] drm/i915: enumerate and init each supported region

2019-10-18 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: enumerate and init each supported region URL : https://patchwork.freedesktop.org/series/68187/ State : success == Summary == CI Bug Log - changes from CI_DRM_7127_full -> Patchwork_14877_full

Re: [Intel-gfx] [PATCH 14/14] drm/i915: Remove special case slave handling during hw programming, v2.

2019-10-18 Thread Maarten Lankhorst
Op 17-10-2019 om 15:21 schreef Maarten Lankhorst: > Now that we split plane_state which I didn't want to do yet, we can > program the slave plane without requiring the master plane. > > This is useful for programming bigjoiner slave planes as well. We > will no longer need the master's

Re: [Intel-gfx] [PATCH] drm/i915: Do not end i915 batch buffers prematurely

2019-10-18 Thread Summers, Stuart
On Thu, 2019-10-17 at 14:42 -0700, Daniele Ceraolo Spurio wrote: > > On 10/17/19 12:37 PM, Stuart Summers wrote: > > During engine initialization in i915 load, the batch buffers > > being used to set up the initial context are being prematurely > > ended. In most scenarios, this does not cause a

Re: [Intel-gfx] [PATCH V4 5/6] virtio: introduce a mdev based transport

2019-10-18 Thread Cornelia Huck
On Thu, 17 Oct 2019 18:48:35 +0800 Jason Wang wrote: > This patch introduces a new mdev transport for virtio. This is used to > use kernel virtio driver to drive the mediated device that is capable > of populating virtqueue directly. > > A new virtio-mdev driver will be registered to the mdev

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Add coverage of mocs registers (rev5)

2019-10-18 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add coverage of mocs registers (rev5) URL : https://patchwork.freedesktop.org/series/68135/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7128 -> Patchwork_14882 Summary

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915: Exercise preemption timeout controls in sysfs

2019-10-18 Thread Petri Latvala
On Fri, Oct 18, 2019 at 01:39:37PM +0100, Tvrtko Ursulin wrote: > > On 18/10/2019 13:35, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-10-18 13:23:53) > > > > > > On 17/10/2019 15:30, Chris Wilson wrote: > > > > Dynamic subtests! > > > > > > Ouch! :) > > > > > > > Signed-off-by: Chris

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/14] drm/i915: Rework watermark readout to use plane api (rev2)

2019-10-18 Thread Maarten Lankhorst
Op 18-10-2019 om 12:57 schreef Patchwork: > == Series Details == > > Series: series starting with [01/14] drm/i915: Rework watermark readout to > use plane api (rev2) > URL : https://patchwork.freedesktop.org/series/68154/ > State : failure > > == Summary == > > CI Bug Log - changes from

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Convert the leftover for_each_engine(gt) (rev2)

2019-10-18 Thread Patchwork
== Series Details == Series: drm/i915/gt: Convert the leftover for_each_engine(gt) (rev2) URL : https://patchwork.freedesktop.org/series/68194/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7128 -> Patchwork_14881 Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for adding gamma state checker for icl+ platforms (rev6)

2019-10-18 Thread Patchwork
== Series Details == Series: adding gamma state checker for icl+ platforms (rev6) URL : https://patchwork.freedesktop.org/series/66811/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7128 -> Patchwork_14880 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Add coverage of mocs registers

2019-10-18 Thread Kumar Valsan, Prathap
On Fri, Oct 18, 2019 at 01:06:39PM +0100, Chris Wilson wrote: > Probe the mocs registers for new contexts and across GPU resets. Similar > to intel_workarounds, we have tables of what register values we expect > to see, so verify that user contexts are affected by them. In the > future, we should

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Add coverage of mocs registers (rev5)

2019-10-18 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add coverage of mocs registers (rev5) URL : https://patchwork.freedesktop.org/series/68135/ State : warning == Summary == $ dim checkpatch origin/drm-tip 221d3a170a43 drm/i915/selftests: Add coverage of mocs registers -:29:

Re: [Intel-gfx] [PULL] drm-misc-next

2019-10-18 Thread Tomi Valkeinen
Hi Sean, On 17/10/2019 22:26, Sean Paul wrote: concern for those. The omap OMAP_BO_MEM_* changes though I don't think have really reached non-TI eyes. There's no link in the commit message to a UAPI implementation and the only reference I could find is libkmsxx which can set them through the

[Intel-gfx] [PATCH i-g-t 2/3] i915: Exercise sysfs heartbeat controls

2019-10-18 Thread Chris Wilson
Signed-off-by: Chris Wilson --- tests/Makefile.sources| 1 + tests/i915/sysfs_heartbeat_interval.c | 430 ++ tests/meson.build | 1 + 3 files changed, 432 insertions(+) create mode 100644 tests/i915/sysfs_heartbeat_interval.c diff

[Intel-gfx] [PATCH i-g-t 3/3] i915: Exercise timeslice sysfs property

2019-10-18 Thread Chris Wilson
Signed-off-by: Chris Wilson --- tests/Makefile.sources| 1 + tests/i915/sysfs_timeslice_duration.c | 304 ++ tests/meson.build | 1 + 3 files changed, 306 insertions(+) create mode 100644 tests/i915/sysfs_timeslice_duration.c diff

[Intel-gfx] sysfs property tests

2019-10-18 Thread Chris Wilson
Just a status update on the igt having fleshed them out some more. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t 1/3] i915: Exercise preemption timeout controls in sysfs

2019-10-18 Thread Chris Wilson
Dynamic subtests! Signed-off-by: Chris Wilson --- lib/i915/gem_context.c| 41 lib/i915/gem_context.h| 2 + tests/Makefile.sources| 1 + tests/i915/sysfs_preemption_timeout.c | 310 ++ tests/meson.build

Re: [Intel-gfx] [PATCH V4 4/6] mdev: introduce virtio device and its device ops

2019-10-18 Thread Cornelia Huck
On Fri, 18 Oct 2019 18:55:02 +0800 Jason Wang wrote: > On 2019/10/18 下午5:46, Cornelia Huck wrote: > > On Thu, 17 Oct 2019 18:48:34 +0800 > > Jason Wang wrote: > >> + * @get_vendor_id:Get virtio vendor id > >> + *@mdev: mediated device > >> + *

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Add the mock engine to the gt->engine[]

2019-10-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-18 14:22:39) > > On 18/10/2019 14:07, Chris Wilson wrote: > > Remember to include the newly created mock engine in the list of > > available engines inside the gt. > > > > Fixes: a50134b1983b ("drm/i915: Make for_each_engine_masked work on > > intel_gt") > >

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Add the mock engine to the gt->engine[]

2019-10-18 Thread Tvrtko Ursulin
On 18/10/2019 14:07, Chris Wilson wrote: Remember to include the newly created mock engine in the list of available engines inside the gt. Fixes: a50134b1983b ("drm/i915: Make for_each_engine_masked work on intel_gt") Signed-off-by: Chris Wilson Cc: Chris Wilson Reviewed-by: Chris Wi..oh

[Intel-gfx] ✗ Fi.CI.BAT: failure for adding gamma state checker for icl+ platforms (rev6)

2019-10-18 Thread Patchwork
== Series Details == Series: adding gamma state checker for icl+ platforms (rev6) URL : https://patchwork.freedesktop.org/series/66811/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7128 -> Patchwork_14880 Summary ---

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Add aliases for uapi and hw to crtc_state

2019-10-18 Thread Ville Syrjälä
On Fri, Oct 18, 2019 at 02:09:17PM +0200, Maarten Lankhorst wrote: > Op 18-10-2019 om 12:36 schreef Ville Syrjälä: > > On Thu, Oct 17, 2019 at 03:20:55PM +0200, Maarten Lankhorst wrote: > >> Prepare to split up hw and uapi machinally, by adding a uapi and > >> hw alias. We will remove the base in

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove

2019-10-18 Thread Janusz Krzysztofik
On Friday, October 18, 2019 2:13:18 PM CEST Patchwork wrote: > == Series Details == > > Series: drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove > URL : https://patchwork.freedesktop.org/series/68188/ > State : failure > > == Summary == > > CI Bug Log - changes from

[Intel-gfx] [PATCH] drm/i915/selftests: Add the mock engine to the gt->engine[]

2019-10-18 Thread Chris Wilson
Remember to include the newly created mock engine in the list of available engines inside the gt. Fixes: a50134b1983b ("drm/i915: Make for_each_engine_masked work on intel_gt") Signed-off-by: Chris Wilson Cc: Chris Wilson --- drivers/gpu/drm/i915/gt/mock_engine.c | 4 1 file changed, 4

Re: [Intel-gfx] [PATCH 06/14] drm/i915: Perform automated conversions for crtc uapi/hw split, base -> hw.

2019-10-18 Thread Ville Syrjälä
On Thu, Oct 17, 2019 at 03:20:57PM +0200, Maarten Lankhorst wrote: > Split up crtc_state->base to hw where appropriate. This is done using the > following patch: > > @@ > struct intel_crtc_state *T; > identifier x =~ > "^(active|enable|degamma_lut|gamma_lut|ctm|mode|adjusted_mode)$"; > @@ >

  1   2   >