On Mon, 04 Nov 2019, Ville Syrjälä wrote:
> On Fri, Nov 01, 2019 at 04:20:24PM +0200, Jani Nikula wrote:
>> Since CNP it's possible for rawclk to have two different values, 19.2
>> and 24 MHz. If the value indicated by SFUSE_STRAP register is different
>> from the power on default for
== Series Details ==
Series: series starting with [1/3] drm/i915: Switch obj->mm.lock lockdep
annotations on its head
URL : https://patchwork.freedesktop.org/series/68956/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7258_full -> Patchwork_15123_full
On Mon, 04 Nov 2019, Manasi Navare wrote:
> On Mon, Nov 04, 2019 at 04:14:39PM +0200, Jani Nikula wrote:
>> Use intel_dsc_ prefix. No functional changes.
>>
>> Cc: Manasi Navare
>> Signed-off-by: Jani Nikula
>> ---
>> drivers/gpu/drm/i915/display/intel_vdsc.c | 12 ++--
>> 1 file
On 2019/11/5 下午12:39, Alex Williamson wrote:
On Tue, 5 Nov 2019 11:52:41 +0800
Jason Wang wrote:
On 2019/11/5 上午5:50, Alex Williamson wrote:
On Mon, 4 Nov 2019 20:39:50 +0800
Jason Wang wrote:
This patch implements basic support for mdev driver that supports
virtio transport for
On Tue, 5 Nov 2019 11:52:41 +0800
Jason Wang wrote:
> On 2019/11/5 上午5:50, Alex Williamson wrote:
> > On Mon, 4 Nov 2019 20:39:50 +0800
> > Jason Wang wrote:
> >
> >> This patch implements basic support for mdev driver that supports
> >> virtio transport for kernel virtio driver.
> >>
> >>
On 2019/11/5 上午5:50, Alex Williamson wrote:
On Mon, 4 Nov 2019 20:39:50 +0800
Jason Wang wrote:
This patch implements basic support for mdev driver that supports
virtio transport for kernel virtio driver.
Signed-off-by: Jason Wang
---
drivers/vfio/mdev/mdev_core.c| 20
On 2019/11/5 上午5:50, Alex Williamson wrote:
EXPORT_SYMBOL(mdev_set_drvdata);
+
Extra whitespace
/* Specify the class for the mdev device, this must be called during
- * create() callback.
- */
+ * create() callback explicitly or implicity through the helpers
s/implicity/implicitly/
On 2019/11/5 上午5:50, Alex Williamson wrote:
On Mon, 4 Nov 2019 20:39:47 +0800
Jason Wang wrote:
Mdev bus only supports vfio driver right now, so it doesn't implement
match method. But in the future, we may add drivers other than vfio,
the first driver could be virtio-mdev. This means we
On Mon, Nov 04, 2019 at 04:14:37PM +0200, Jani Nikula wrote:
> Use a simple pointer to the relevant element instead of duplicating the
> array subscription. No functional changes.
>
> Cc: Manasi Navare
> Signed-off-by: Jani Nikula
Thank you for the cleanup and optimizations in this patch,
On Mon, Nov 04, 2019 at 04:14:38PM +0200, Jani Nikula wrote:
> Split out the DP specific parts, making it easier to add DSI specific
> configuration. Also move the encoder specific parts towards the end, to
> allow overriding generic configuration if needed. This also improves
> clarity by making
On Mon, Nov 04, 2019 at 04:14:39PM +0200, Jani Nikula wrote:
> Use intel_dsc_ prefix. No functional changes.
>
> Cc: Manasi Navare
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_vdsc.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git
On Mon, Nov 04, 2019 at 04:14:36PM +0200, Jani Nikula wrote:
> No need for them to be mutable.
>
> Cc: Manasi Navare
> Signed-off-by: Jani Nikula
Agree that these params are constants
Reviewed-by: Manasi Navare
Manasi
> ---
> drivers/gpu/drm/i915/display/intel_vdsc.c | 4 ++--
> 1 file
On Mon, 4 Nov 2019 20:39:49 +0800
Jason Wang wrote:
> Currently, except for the create and remove, the rest of
> mdev_parent_ops is designed for vfio-mdev driver only and may not help
> for kernel mdev driver. With the help of class id, this patch
> introduces device specific callbacks inside
On Mon, 4 Nov 2019 20:39:50 +0800
Jason Wang wrote:
> This patch implements basic support for mdev driver that supports
> virtio transport for kernel virtio driver.
>
> Signed-off-by: Jason Wang
> ---
> drivers/vfio/mdev/mdev_core.c| 20
> drivers/vfio/mdev/mdev_private.h | 2 +
>
On Mon, 4 Nov 2019 20:39:47 +0800
Jason Wang wrote:
> Mdev bus only supports vfio driver right now, so it doesn't implement
> match method. But in the future, we may add drivers other than vfio,
> the first driver could be virtio-mdev. This means we need to add
> device class id support in bus
== Series Details ==
Series: series starting with [1/3] dma_resv: prime lockdep annotations
URL : https://patchwork.freedesktop.org/series/68958/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7258 -> Patchwork_15124
On Mon, Nov 04, 2019 at 07:48:26PM +1000, David Airlie wrote:
> On Mon, Nov 4, 2019 at 7:18 PM Daniel Vetter wrote:
> >
> > On Thu, Oct 31, 2019 at 02:48:39PM -0700, Manasi Navare wrote:
> > > In case of tiled displays, if we hotplug just one connector,
> > > fbcon currently just selects the
== Series Details ==
Series: series starting with [1/3] dma_resv: prime lockdep annotations
URL : https://patchwork.freedesktop.org/series/68958/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
294603555e6b dma_resv: prime lockdep annotations
-:77: WARNING:BAD_SIGN_OFF:
On Mon, Nov 04, 2019 at 08:01:09PM +, Koenig, Christian wrote:
> Am 04.11.19 um 18:37 schrieb Daniel Vetter:
> > Full audit of everyone:
> >
> > - i915, radeon, amdgpu should be clean per their maintainers.
> >
> > - vram helpers should be fine, they don't do command submission, so
> >
On Mon, Nov 04, 2019 at 06:13:30PM +0100, Janusz Krzysztofik wrote:
exec-shared-gtt-* subtests use hardcoded values for object size and
softpin offset, based on 4kB GTT alignment assumption. That may result
in those subtests failing when run on future backing stores with
possibly larger minimum
On Mon, Nov 04, 2019 at 06:13:29PM +0100, Janusz Krzysztofik wrote:
The basic-range subtest assumes 4kB alignment while calculating softpin
offsets. On future backends with possibly larger minimum page sizes
the test will fail as a half of calculated offsets to be tested will be
incorrectly
On Mon, Nov 04, 2019 at 06:13:28PM +0100, Janusz Krzysztofik wrote:
Commit a355b2d6eb42 ("igt/gem_exec_reloc: Filter out unavailable
addresses for !ppgtt") introduced filtering of addresses possibly
occupied by other users of shared GTT. Unfortunately, that filtering
doesn't distinguish between
== Series Details ==
Series: series starting with [1/3] drm/i915: Switch obj->mm.lock lockdep
annotations on its head
URL : https://patchwork.freedesktop.org/series/68956/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7258 -> Patchwork_15123
As the scratch buf is shared between the two requests on both engines,
we need to wait for both to finish using the buffer before we reset it.
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
Cc: Tvrtko Ursulin
---
tests/i915/gem_exec_balancer.c | 2 +-
1 file changed, 1 insertion(+), 1
== Series Details ==
Series: series starting with [1/3] drm/i915: Switch obj->mm.lock lockdep
annotations on its head
URL : https://patchwork.freedesktop.org/series/68956/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c495bd921770 drm/i915: Switch obj->mm.lock lockdep
Am 04.11.19 um 18:37 schrieb Daniel Vetter:
> Full audit of everyone:
>
> - i915, radeon, amdgpu should be clean per their maintainers.
>
> - vram helpers should be fine, they don't do command submission, so
>really no business holding struct_mutex while doing copy_*_user. But
>I haven't
On 4.11.2019 18.32, Matt Roper wrote:
On Mon, Nov 04, 2019 at 01:50:09PM +0200, Juha-Pekka Heikkila wrote:
WA2006604312 is listed for devices from Icelake onward.
The "Project" column on bspec #33450 does list EHL, however I don't see
it actually listed on the dedicated EHL WA page (bspec
On Mon, Nov 04, 2019 at 07:48:26PM +1000, David Airlie wrote:
> On Mon, Nov 4, 2019 at 7:18 PM Daniel Vetter wrote:
> >
> > On Thu, Oct 31, 2019 at 02:48:39PM -0700, Manasi Navare wrote:
> > > In case of tiled displays, if we hotplug just one connector,
> > > fbcon currently just selects the
On Tue, Oct 22, 2019 at 03:30:13PM +0100, Matthew Auld wrote:
> On Mon, 21 Oct 2019 at 09:03, Chris Wilson wrote:
> >
> > Separate each object class into a separate lock type to avoid lockdep
> > cross-contamination between paths (i.e. userptr!).
> >
> > Signed-off-by: Chris Wilson
> > Cc:
On Mon, Nov 04, 2019 at 06:37:59PM +0100, Daniel Vetter wrote:
> Full audit of everyone:
>
> - i915, radeon, amdgpu should be clean per their maintainers.
>
> - vram helpers should be fine, they don't do command submission, so
> really no business holding struct_mutex while doing copy_*_user.
With nouveau fixed all ttm-using drives have the correct nesting of
mmap_sem vs dma_resv, and we can just lock the buffer.
Assuming I didn't screw up anything with my audit of course.
v2:
- Dont forget wu_mutex (Christian König)
- Keep the mmap_sem-less wait optimization (Thomas)
- Use
We can't copy_*_user while holding reservations, that will (soon even
for nouveau) lead to deadlocks. And it breaks the cross-driver
contract around dma_resv.
Fix this by adding a slowpath for when we need relocations, and by
pushing the writeback of the new presumed offsets to the very end.
Full audit of everyone:
- i915, radeon, amdgpu should be clean per their maintainers.
- vram helpers should be fine, they don't do command submission, so
really no business holding struct_mutex while doing copy_*_user. But
I haven't checked them all.
- panfrost seems to dma_resv_lock only
So strictly speaking the existing annotation is also ok, because we
have a chain of
obj->mm.lock#I915_MM_GET_PAGES -> fs_reclaim -> obj->mm.lock
(the shrinker cannot get at an object while we're in get_pages, hence
this is safe). But it's confusing, so try to take the right subclass
of the lock.
The trouble with having a plain nesting flag for locks which do not
naturally nest (unlike block devices and their partitions, which is
the original motivation for nesting levels) is that lockdep will
never spot a true deadlock if you screw up.
This patch is an attempt at trying better, by
Necessary to annotate functions where we might acquire a
mutex_lock_nested() or similar. Needed by i915.
Acked-by: Peter Zijlstra (Intel)
Signed-off-by: Daniel Vetter
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Will Deacon
Cc: linux-ker...@vger.kernel.org
---
include/linux/lockdep.h | 8
Hi Paul,
On Mon, Nov 04, 2019 at 01:57:54PM +0100, Paul Menzel wrote:
> On the Dell XPS 13 9380 with Debian Sid/unstable with Linux 5.3.7
> resuming0with Dell’s Thunderbolt TB16 dock connected, Linux spews
> the errors below.
>
> ```
> [0.00] Linux version 5.3.0-1-amd64
Commit a355b2d6eb42 ("igt/gem_exec_reloc: Filter out unavailable
addresses for !ppgtt") introduced filtering of addresses possibly
occupied by other users of shared GTT. Unfortunately, that filtering
doesn't distinguish between actually occupied addresses and otherwise
invalid softpin offsets.
Some tests assume 4kB page size while using softpin. That assumption
may be wrong on future GEM backends with possibly larger minimum page
sizes. As a result, those tests may either fail on softpin at offsets
which are incorrectly aligned, may silently skip such incorrectly
aligned addresses
exec-shared-gtt-* subtests use hardcoded values for object size and
softpin offset, based on 4kB GTT alignment assumption. That may result
in those subtests failing when run on future backing stores with
possibly larger minimum page sizes.
Replace hardcoded constants with values calculated from
The basic-range subtest assumes 4kB alignment while calculating softpin
offsets. On future backends with possibly larger minimum page sizes
the test will fail as a half of calculated offsets to be tested will be
incorrectly aligned.
Replace hardcoded constants corresponding to the assumed 4kB
Some tests assume 4kB offset alignment while using softpin. That
assumption may be wrong on future GEM backends with possibly larger
minimum page sizes. As a result, those tests may either fail on
softpin at offsets which are incorrectly aligned, may silently skip
such incorrectly aligned
On Thu, Oct 24, 2019 at 12:35:52PM +0200, Thierry Reding wrote:
> On Wed, Oct 23, 2019 at 04:49:53PM +0200, Daniel Vetter wrote:
> > They're midlayer, broken, and because of the old gunk, we can't fix
> > them. For examples see the various checks in drm_mode_object.c against
> > dev->registered,
On Mon, Nov 04, 2019 at 01:50:09PM +0200, Juha-Pekka Heikkila wrote:
> WA2006604312 is listed for devices from Icelake onward.
The "Project" column on bspec #33450 does list EHL, however I don't see
it actually listed on the dedicated EHL WA page (bspec #33451) or the
TGL WA page (bspec #52890).
== Series Details ==
Series: series starting with [v2,1/4] drm/i915/dsc: make parameter arrays const
URL : https://patchwork.freedesktop.org/series/68947/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7252 -> Patchwork_15122
On Mon, Oct 21, 2019 at 09:54:48PM -0300, Rodrigo Siqueira wrote:
> Hi,
Hi Rodrigo,
The whole series looks good to me, you can add my Reviewed-by tag if you want.
Do you plan to push the patches into igt?
Best regards,
Liviu
>
> A couple of months ago, I updated and re-submitted a patchset
Chris Wilson writes:
> Allow the subtests that want to limit the test to a single engine, to
> limit the test to a single engine.
>
> Signed-off-by: Chris Wilson
> Cc: Mika Kuoppala
Reviewed-by: Mika Kuoppala
> ---
> tests/i915/gem_ctx_shared.c | 8 ++--
> 1 file changed, 6
== Series Details ==
Series: drm/i915/execlists: Reset CSB pointers by mmio as well
URL : https://patchwork.freedesktop.org/series/68945/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7252 -> Patchwork_15121
Summary
On Fri, Nov 01, 2019 at 04:20:24PM +0200, Jani Nikula wrote:
> Since CNP it's possible for rawclk to have two different values, 19.2
> and 24 MHz. If the value indicated by SFUSE_STRAP register is different
> from the power on default for PCH_RAWCLK_FREQ, we'll end up having a
> mismatch between
Allow the subtests that want to limit the test to a single engine, to
limit the test to a single engine.
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
---
tests/i915/gem_ctx_shared.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/i915/gem_ctx_shared.c
On Mon, Oct 28, 2019 at 05:00:45PM +0200, Jani Nikula wrote:
> Update from the DCS specification.
>
> Cc: Vandita Kulkarni
> Signed-off-by: Jani Nikula
> ---
> include/video/mipi_display.h | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/include/video/mipi_display.h
On Mon, Oct 28, 2019 at 05:00:44PM +0200, Jani Nikula wrote:
> Add execute queue and compressed pixel stream packet data types for
> completeness.
>
> Cc: Vandita Kulkarni
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/drm_mipi_dsi.c | 2 ++
> include/video/mipi_display.h | 2 ++
> 2
On Mon, Oct 28, 2019 at 05:00:43PM +0200, Jani Nikula wrote:
> Rename picture parameter set (it's a long packet, not a long write) and
> compression mode (it's not a DCS command) enumerations according to the
> DSI specification. Order the types according to the spec. Use tabs
> instead of spaces
On Mon, 04 Nov 2019 15:58:25 +0100,
Mika Westerberg wrote:
>
> On Mon, Nov 04, 2019 at 02:19:21PM +0100, Takashi Iwai wrote:
> > On Mon, 04 Nov 2019 14:10:24 +0100,
> > Mika Westerberg wrote:
> > >
> > > Hi,
> > >
> > > On Mon, Nov 04, 2019 at 01:57:54PM +0100, Paul Menzel wrote:
> > > > Dear
== Series Details ==
Series: drm/i915/execlists: Reset CSB pointers by mmio as well
URL : https://patchwork.freedesktop.org/series/68945/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
238a6baf4572 drm/i915/execlists: Reset CSB pointers by mmio as well
-:9:
On Mon, Nov 04, 2019 at 02:19:21PM +0100, Takashi Iwai wrote:
> On Mon, 04 Nov 2019 14:10:24 +0100,
> Mika Westerberg wrote:
> >
> > Hi,
> >
> > On Mon, Nov 04, 2019 at 01:57:54PM +0100, Paul Menzel wrote:
> > > Dear Linux folks,
> > >
> > >
> > > On the Dell XPS 13 9380 with Debian
Hi Vanshi,
On Thursday, October 31, 2019 5:58:31 PM CET Vanshidhar Konda wrote:
> On Thu, Oct 31, 2019 at 04:28:55PM +0100, Janusz Krzysztofik wrote:
> >Some tests assume 4kB offset alignment while using softpin. That
> >assumption may be wrong on future GEM backends with possibly larger
>
Quoting Mika Kuoppala (2019-11-04 14:27:21)
> Chris Wilson writes:
>
> > Sometimes Icelake forgets to reset the CSB pointers on a GPU reset,
> > leading to carry on updating the old tail of the buffer.
> >
> > <0>[ 618.138490] i915_sel-56363d..1 673425465us : trace_ports: vecs0:
> > submit
Chris Wilson writes:
> Sometimes Icelake forgets to reset the CSB pointers on a GPU reset,
> leading to carry on updating the old tail of the buffer.
>
> <0>[ 618.138490] i915_sel-56363d..1 673425465us : trace_ports: vecs0:
> submit { 14de2:504, 0:0 }
> <0>[ 618.138490] i915_sel-5636
== Series Details ==
Series: drm/i915: Display WA2006604312 is needed from ICL onwards
URL : https://patchwork.freedesktop.org/series/68932/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7252 -> Patchwork_15120
Summary
Use a simple pointer to the relevant element instead of duplicating the
array subscription. No functional changes.
Cc: Manasi Navare
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_vdsc.c | 55 ---
1 file changed, 30 insertions(+), 25 deletions(-)
diff
No need for them to be mutable.
Cc: Manasi Navare
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_vdsc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c
b/drivers/gpu/drm/i915/display/intel_vdsc.c
index
Use intel_dsc_ prefix. No functional changes.
Cc: Manasi Navare
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_vdsc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c
Split out the DP specific parts, making it easier to add DSI specific
configuration. Also move the encoder specific parts towards the end, to
allow overriding generic configuration if needed. This also improves
clarity by making it clear the encoder independent configuration does
not depend on the
Hi all, I'd really appreciate some (non-Intel) acks or reviews on this
series. Don't feel comfortable merging it otherwise. It should be fairly
straightforward stuff as long as you have some DSI specs handy.
BR,
Jani.
On Mon, 28 Oct 2019, Jani Nikula wrote:
> Rename picture parameter set
Sometimes Icelake forgets to reset the CSB pointers on a GPU reset,
leading to carry on updating the old tail of the buffer.
<0>[ 618.138490] i915_sel-56363d..1 673425465us : trace_ports: vecs0:
submit { 14de2:504, 0:0 }
<0>[ 618.138490] i915_sel-56363 673425493us :
== Series Details ==
Series: drm/i915/gt: Drop false assertion on user_forcewake
URL : https://patchwork.freedesktop.org/series/68922/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7247 -> Patchwork_15119
Summary
---
On Fri, 01 Nov 2019, Ville Syrjälä wrote:
> On Fri, Nov 01, 2019 at 03:43:33PM +0200, Jani Nikula wrote:
>> Add another for_each style macro to the pile of custom looping macros.
>>
>> Signed-off-by: Jani Nikula
>
> Reviewed-by: Ville Syrjälä
Thanks, pushed.
BR,
Jani.
>
>> ---
>>
On Mon, 04 Nov 2019 14:10:24 +0100,
Mika Westerberg wrote:
>
> Hi,
>
> On Mon, Nov 04, 2019 at 01:57:54PM +0100, Paul Menzel wrote:
> > Dear Linux folks,
> >
> >
> > On the Dell XPS 13 9380 with Debian Sid/unstable with Linux 5.3.7
> > resuming0with Dell’s Thunderbolt TB16 dock connected,
Hi,
On Mon, Nov 04, 2019 at 01:57:54PM +0100, Paul Menzel wrote:
> Dear Linux folks,
>
>
> On the Dell XPS 13 9380 with Debian Sid/unstable with Linux 5.3.7
> resuming0with Dell’s Thunderbolt TB16 dock connected, Linux spews
> the errors below.
I have this machine here so can try to reproduce
Dear Linux folks,
On the Dell XPS 13 9380 with Debian Sid/unstable with Linux 5.3.7
resuming0with Dell’s Thunderbolt TB16 dock connected, Linux spews
the errors below.
```
[0.00] Linux version 5.3.0-1-amd64 (debian-ker...@lists.debian.org)
(gcc version 9.2.1 20191008 (Debian 9.2.1-9))
This sample driver creates mdev device that simulate virtio net device
over virtio mdev transport. The device is implemented through vringh
and workqueue. A device specific dma ops is to make sure HVA is used
directly as the IOVA. This should be sufficient for kernel virtio
driver to work.
Only
== Series Details ==
Series: drm/i915/gt: Drop false assertion on user_forcewake
URL : https://patchwork.freedesktop.org/series/68922/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7247_full -> Patchwork_15119_full
Summary
This patch introduces a new mdev transport for virtio. This is used to
use kernel virtio driver to drive the mediated device that is capable
of populating virtqueue directly.
A new virtio-mdev driver will be registered to the mdev bus, when a
new virtio-mdev device is probed, it will register the
Hi all:
There are hardwares that can do virtio datapath offloading while
having its own control path. This path tries to implement a mdev based
unified API to support using kernel virtio driver to drive those
devices. This is done by introducing a new mdev transport for virtio
(virtio_mdev) and
Add support to parse mdev class id table.
Reviewed-by: Parav Pandit
Signed-off-by: Jason Wang
---
drivers/vfio/mdev/vfio_mdev.c | 2 ++
scripts/mod/devicetable-offsets.c | 3 +++
scripts/mod/file2alias.c | 11 +++
3 files changed, 16 insertions(+)
diff --git
Mdev bus only supports vfio driver right now, so it doesn't implement
match method. But in the future, we may add drivers other than vfio,
the first driver could be virtio-mdev. This means we need to add
device class id support in bus match method to pair the mdev device
and mdev driver correctly.
WA2006604312 is listed for devices from Icelake onward.
Signed-off-by: Juha-Pekka Heikkila
---
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c
Hi Chris,
On Friday, November 1, 2019 11:02:45 AM CET Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2019-10-31 15:28:54)
> > Commit a355b2d6eb42 ("igt/gem_exec_reloc: Filter out unavailable
> > addresses for !ppgtt") introduced filtering of addresses possibly
> > occupied by other users of
On Monday, November 4, 2019 10:28:37 AM CET Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2019-11-04 09:23:12)
> > Hi Chris,
> >
> > On Friday, November 1, 2019 11:08:45 AM CET Chris Wilson wrote:
> > > Quoting Janusz Krzysztofik (2019-10-31 15:28:55)
> > > > Some tests assume 4kB offset
Chris Wilson writes:
> Since the execlists_active() is no longer protected by the
> engine->active.lock, we need to protect the request pointer with RCU to
> prevent it being freed as we evaluate whether or not we need to preempt.
>
> Fixes: df403069029d ("drm/i915/execlists: Lift process_csb()
Quoting Janusz Krzysztofik (2019-11-04 09:39:32)
> Hi Chris,
>
> On Friday, November 1, 2019 10:42:18 AM CET Chris Wilson wrote:
> > Quoting Janusz Krzysztofik (2019-10-31 15:28:57)
> > > exec-shared-gtt-* subtests use hardcoded values for object size and
> > > softpin offset, based on 4kB GTT
Hi Chris,
On Friday, November 1, 2019 10:42:18 AM CET Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2019-10-31 15:28:57)
> > exec-shared-gtt-* subtests use hardcoded values for object size and
> > softpin offset, based on 4kB GTT alignment assumption. That may result
> > in those subtests
Chris Wilson writes:
> The counter is removed from the pm wakeref count, but it remains intact
> so that we can restore it upon resume. Ergo inside suspend, it may have
> a value.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Mika Kuoppala
oh, user_forcewake needs a better name with a verb...
Quoting Janusz Krzysztofik (2019-11-04 09:23:12)
> Hi Chris,
>
> On Friday, November 1, 2019 11:08:45 AM CET Chris Wilson wrote:
> > Quoting Janusz Krzysztofik (2019-10-31 15:28:55)
> > > Some tests assume 4kB offset alignment while using softpin. That
> > > assumption may be wrong on future GEM
Hi Chris,
On Friday, November 1, 2019 11:08:45 AM CET Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2019-10-31 15:28:55)
> > Some tests assume 4kB offset alignment while using softpin. That
> > assumption may be wrong on future GEM backends with possibly larger
> > minimum page sizes. As a
On Thu, Oct 31, 2019 at 02:48:39PM -0700, Manasi Navare wrote:
> In case of tiled displays, if we hotplug just one connector,
> fbcon currently just selects the preferred mode and if it is
> tiled mode then that becomes a problem if rest of the tiles are
> not present.
> So in the fbdev driver on
Quoting Janusz Krzysztofik (2019-11-04 09:13:28)
> Hi Chris,
>
> On Friday, November 1, 2019 11:02:45 AM CET Chris Wilson wrote:
> > Quoting Janusz Krzysztofik (2019-10-31 15:28:54)
> > > Commit a355b2d6eb42 ("igt/gem_exec_reloc: Filter out unavailable
> > > addresses for !ppgtt") introduced
Hi Vanshi,
On Thursday, October 31, 2019 5:59:50 PM CET Vanshidhar Konda wrote:
> May be this patch can just be merged with the other patch in this series
> that changes gem_exec_reloc.
Even if both patches are closely related to possibly incorrect alignment in
use, I think each one resolves it
The counter is removed from the pm wakeref count, but it remains intact
so that we can restore it upon resume. Ergo inside suspend, it may have
a value.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_gt_pm.c | 1 -
1 file changed, 1 deletion(-)
diff --git
Since the execlists_active() is no longer protected by the
engine->active.lock, we need to protect the request pointer with RCU to
prevent it being freed as we evaluate whether or not we need to preempt.
Fixes: df403069029d ("drm/i915/execlists: Lift process_csb() out of the irq-off
spinlock")
91 matches
Mail list logo
