Re: [Intel-gfx] [PATCH] drm/i915/gt: Cleanup heartbeat systole first

Chris Wilson writes: > Before we grab the engine wakeref, tidy up the previous heartbeat > request. If we then abort because the engine powerwell is off, we ensure > the request is freed as we know we will not have freed it when > cancelling the work (as the work is running!). > > Fixes: 841e8672

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Safely acquire the ctx->vm when copying

== Series Details == Series: drm/i915/gem: Safely acquire the ctx->vm when copying URL : https://patchwork.freedesktop.org/series/69044/ State : success == Summary == CI Bug Log - changes from CI_DRM_7266_full -> Patchwork_15148_full Summar

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Implement Wa_1604555607

On 2019-10-01 at 13:16:11 -0700, Lucas De Marchi wrote: > On Tue, Oct 1, 2019 at 10:36 AM Chris Wilson wrote: > > > > Quoting Ramalingam C (2019-10-01 18:26:23) > > > From: Michel Thierry > > > > > > Implement Wa_1604555607 (set the DS pairing timer to 128 cycles). > > > FF_MODE2 is part of the r

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use rcu_dereference for rcu protected pointer

On Wed, Nov 06, 2019 at 08:52:58AM +, Chris Wilson wrote: Quoting Niranjan Vishwanathapura (2019-11-06 02:16:42) On Wed, Nov 06, 2019 at 12:36:47AM +, Chris Wilson wrote: >Quoting Niranjana Vishwanathapura (2019-11-06 00:02:05) >> 'ctx\->vm' is rcu protected, so use rcu_dereference insid

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Wrap vm_mmap() around GEM objects (rev2)

== Series Details == Series: drm/i915/selftests: Wrap vm_mmap() around GEM objects (rev2) URL : https://patchwork.freedesktop.org/series/69024/ State : success == Summary == CI Bug Log - changes from CI_DRM_7264_full -> Patchwork_15147_full

Re: [Intel-gfx] [PATCH V8 0/6] mdev based hardware virtio offloading support

On 2019/11/7 上午5:13, Alex Williamson wrote: On Wed, 6 Nov 2019 14:25:23 -0500 "Michael S. Tsirkin" wrote: On Wed, Nov 06, 2019 at 12:03:12PM -0700, Alex Williamson wrote: On Wed, 6 Nov 2019 11:56:46 +0800 Jason Wang wrote: On 2019/11/6 上午1:58, Alex Williamson wrote: On Tue, 5 Nov 201

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/userptr: Try to acquire the page lock around set_page_dirty()

== Series Details == Series: drm/i915/userptr: Try to acquire the page lock around set_page_dirty() URL : https://patchwork.freedesktop.org/series/69037/ State : success == Summary == CI Bug Log - changes from CI_DRM_7264_full -> Patchwork_15146_full ===

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: switch intel_ddi_init() to intel types (rev2)

== Series Details == Series: drm/i915: switch intel_ddi_init() to intel types (rev2) URL : https://patchwork.freedesktop.org/series/69031/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7264_full -> Patchwork_15145_full Summ

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Cleanup heartbeat systole first

== Series Details == Series: drm/i915/gt: Cleanup heartbeat systole first URL : https://patchwork.freedesktop.org/series/69095/ State : success == Summary == CI Bug Log - changes from CI_DRM_7277 -> Patchwork_15167 Summary --- **SUCC

[Intel-gfx] ✗ Fi.CI.BUILD: failure for mdev based hardware virtio offloading support (rev2)

== Series Details == Series: mdev based hardware virtio offloading support (rev2) URL : https://patchwork.freedesktop.org/series/69035/ State : failure == Summary == Applying: mdev: class id support Applying: modpost: add support for mdev class id Applying: mdev: introduce device specific ops

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Cleanup heartbeat systole first

== Series Details == Series: drm/i915/gt: Cleanup heartbeat systole first URL : https://patchwork.freedesktop.org/series/69095/ State : warning == Summary == $ dim checkpatch origin/drm-tip 90a9ff0de7f7 drm/i915/gt: Cleanup heartbeat systole first -:12: ERROR:GIT_COMMIT_ID: Please use git comm

[Intel-gfx] ✓ Fi.CI.BAT: success for Start removing legacy guc code

== Series Details == Series: Start removing legacy guc code URL : https://patchwork.freedesktop.org/series/69094/ State : success == Summary == CI Bug Log - changes from CI_DRM_7277 -> Patchwork_15166 Summary --- **SUCCESS** No re

[Intel-gfx] ✓ Fi.CI.IGT: success for mdev based hardware virtio offloading support

== Series Details == Series: mdev based hardware virtio offloading support URL : https://patchwork.freedesktop.org/series/69035/ State : success == Summary == CI Bug Log - changes from CI_DRM_7264_full -> Patchwork_15144_full Summary --

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Start removing legacy guc code

== Series Details == Series: Start removing legacy guc code URL : https://patchwork.freedesktop.org/series/69094/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:1: warning: no structured comments found __

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add second TGL PCH ID

On Wed, Nov 06, 2019 at 04:25:27PM -0800, Lucas De Marchi wrote: > On Tue, Nov 05, 2019 at 05:13:29PM -0800, Jose Souza wrote: > >On Tue, 2019-11-05 at 16:55 -0800, James Ausmus wrote: > >> Another TGP ID has shown up, so let's add it to avoid South Display > >> breakage on systems that have this I

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Start removing legacy guc code

== Series Details == Series: Start removing legacy guc code URL : https://patchwork.freedesktop.org/series/69094/ State : warning == Summary == $ dim checkpatch origin/drm-tip f79d5075618e drm/i915/guc: Drop leftover preemption code a49c4957f9d6 drm/i915/guc: add a helper to allocate and map g

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add second TGL PCH ID

On Tue, Nov 05, 2019 at 05:13:29PM -0800, Jose Souza wrote: On Tue, 2019-11-05 at 16:55 -0800, James Ausmus wrote: Another TGP ID has shown up, so let's add it to avoid South Display breakage on systems that have this ID. Reviewed-by: José Roberto de Souza and pushed, thanks Lucas De Marc

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Leave the aliasing-ppgtt size alone

== Series Details == Series: drm/i915: Leave the aliasing-ppgtt size alone URL : https://patchwork.freedesktop.org/series/69093/ State : success == Summary == CI Bug Log - changes from CI_DRM_7276 -> Patchwork_15165 Summary --- **SUC

Re: [Intel-gfx] [PATCH] drm/i915: switch intel_ddi_init() to intel types

On Wed, Nov 06, 2019 at 03:31:04PM +0200, Ville Syrjälä wrote: On Tue, Nov 05, 2019 at 11:17:17PM -0800, Lucas De Marchi wrote: Prefer using intel_encoder and pass the base where needed rather than keeping both encoder and intel_encoder variables around. v2: actually add all changes to the patc

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Add GuC method to determine if submission is active.

On 11/6/19 9:40 AM, don.hi...@intel.com wrote: From: Don Hiatt Add intel_guc_submission_is_enabled() function to determine if GuC submission is active. Based on code by Michal Wajdeczko. Signed-off-by: Don Hiatt --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +- drivers/gpu/d

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Split a setting of MSA to MST and SST

== Series Details == Series: drm/i915: Split a setting of MSA to MST and SST URL : https://patchwork.freedesktop.org/series/69092/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7276 -> Patchwork_15164 Summary --- **F

Re: [Intel-gfx] [PATCH] drm/fbdev: Fallback to non tiled mode if all tiles not present

On Wed, Nov 06, 2019 at 12:50:21PM +1000, Dave Airlie wrote: > On Tue, 5 Nov 2019 at 07:00, Manasi Navare wrote: > > > > On Mon, Nov 04, 2019 at 07:48:26PM +1000, David Airlie wrote: > > > On Mon, Nov 4, 2019 at 7:18 PM Daniel Vetter wrote: > > > > > > > > On Thu, Oct 31, 2019 at 02:48:39PM -0700

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/guc: Add GuC method to determine if submission is active.

== Series Details == Series: series starting with [1/2] drm/i915/guc: Add GuC method to determine if submission is active. URL : https://patchwork.freedesktop.org/series/69086/ State : success == Summary == CI Bug Log - changes from CI_DRM_7276 -> Patchwork_15163 =

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm/i915/psr: Add bits per pixel limitation

== Series Details == Series: series starting with [1/5] drm/i915/psr: Add bits per pixel limitation URL : https://patchwork.freedesktop.org/series/69025/ State : success == Summary == CI Bug Log - changes from CI_DRM_7264_full -> Patchwork_15142_full ===

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Add second TGL PCH ID

On Wed, Nov 06, 2019 at 10:26:10PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/tgl: Add second TGL PCH ID > URL : https://patchwork.freedesktop.org/series/69023/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_7264_full -> Patchwork_15140_full >

Re: [Intel-gfx] [PATCH V9 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

On Wed, 6 Nov 2019 14:50:30 -0800 Randy Dunlap wrote: > On 11/5/19 11:05 PM, Jason Wang wrote: > > diff --git a/samples/Kconfig b/samples/Kconfig > > index c8dacb4dda80..13a2443e18e0 100644 > > --- a/samples/Kconfig > > +++ b/samples/Kconfig > > @@ -131,6 +131,16 @@ config SAMPLE_VFIO_MDEV_MDPY >

Re: [Intel-gfx] [PATCH V9 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

On 11/5/19 11:05 PM, Jason Wang wrote: > diff --git a/samples/Kconfig b/samples/Kconfig > index c8dacb4dda80..13a2443e18e0 100644 > --- a/samples/Kconfig > +++ b/samples/Kconfig > @@ -131,6 +131,16 @@ config SAMPLE_VFIO_MDEV_MDPY > mediated device. It is a simple framebuffer and supports >

[Intel-gfx] [PATCH] drm/i915/gt: Cleanup heartbeat systole first

Before we grab the engine wakeref, tidy up the previous heartbeat request. If we then abort because the engine powerwell is off, we ensure the request is freed as we know we will not have freed it when cancelling the work (as the work is running!). Fixes: 841e86728615 ("drm/i915/gt: Only drop hear

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: fix dropping obj reference twice

== Series Details == Series: drm/i915/gvt: fix dropping obj reference twice URL : https://patchwork.freedesktop.org/series/69084/ State : success == Summary == CI Bug Log - changes from CI_DRM_7275 -> Patchwork_15162 Summary --- **SU

[Intel-gfx] [PATCH 4/4] drm/i915/guc: kill the GuC client

We now only use 1 client without any plan to add more. The client is also only holding information about the WQ and the process desc, so we can just move those in the intel_guc structure and always use stage_id 0. Signed-off-by: Daniele Ceraolo Spurio Cc: Michal Wajdeczko Cc: John Harrison Cc:

[Intel-gfx] [PATCH 2/4] drm/i915/guc: add a helper to allocate and map guc vma

We already have a couple of use-cases in the code and another one will come in one of the later patches in the series. Signed-off-by: Daniele Ceraolo Spurio Cc: Michal Wajdeczko Cc: John Harrison Cc: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/intel_guc.c| 34 +++ dri

[Intel-gfx] [PATCH 1/4] drm/i915/guc: Drop leftover preemption code

Remove unused enums and ctx_save_restore_disabled() function, leftover from the legacy preemption removal. Signed-off-by: Daniele Ceraolo Spurio Cc: Michal Wajdeczko Cc: John Harrison Cc: Matthew Brost --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 22 --- 1 file changed,

[Intel-gfx] [PATCH 3/4] drm/i915/guc: kill doorbell code and selftests

Instead of relying on the workqueue, the upcoming reworked GuC submission flow will offer the host driver indipendent control over the execution status of each context submitted to GuC. As part of this, the doorbell usage model has been reworked, with each doorbell being paired to a single lrc and

[Intel-gfx] [PATCH 0/4] Start removing legacy guc code

Now that we have a clearer picture of what the new GuC submission flow is going to look like, we can start removing the code that we know we won't use in the future. As a starter, we can get rid of the doorbells and the GuC client code, because the former will be replaced by an H2G notification to

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Add second TGL PCH ID

== Series Details == Series: drm/i915/tgl: Add second TGL PCH ID URL : https://patchwork.freedesktop.org/series/69023/ State : success == Summary == CI Bug Log - changes from CI_DRM_7264_full -> Patchwork_15140_full Summary --- **SUC

[Intel-gfx] PR - i915 firmware updates (GuC and HuC for EHL and TGL)

Hi, Kindly add the below i915 changes to linux-firmware.git The following changes since commit 11bdc578ec861c7797ec614d60737a0448b68195: rtw88: RTL8723D: add firmware file v48 (2019-11-04 06:37:16 -0500) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware

[Intel-gfx] [PATCH] drm/i915: Leave the aliasing-ppgtt size alone

The hidden aliasing-ppgtt's size is never revealed, as we only inspect the front GTT when engaged. However, we were "fixing" the hidden ppgtt to match, with the net result that we ended up leaking the unused portion (on Braswell were we preallocated the entire range). [ 26.025364] DMA-API: pci 0

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Remove unwanted rcu_read_lock/unlock

== Series Details == Series: drm/i915: Remove unwanted rcu_read_lock/unlock URL : https://patchwork.freedesktop.org/series/69082/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7275 -> Patchwork_15161 Summary --- **FA

[Intel-gfx] [PULL] drm-intel-fixes

Hi Dave and Daniel, Here goes drm-intel-fixes-2019-11-06: - Fix HPD poll to avoid kworker consuming a lot of cpu cycles. - Do not use TBT type for non Type-C ports. Thanks, Rodrigo. The following changes since commit a99d8080aaf358d5d23581244e5da23b35e340b9: Linux 5.4-rc6 (2019-11-03 14:07:2

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't oops in dumb_create ioctl if we have no crtcs

== Series Details == Series: drm/i915: Don't oops in dumb_create ioctl if we have no crtcs URL : https://patchwork.freedesktop.org/series/69081/ State : success == Summary == CI Bug Log - changes from CI_DRM_7275 -> Patchwork_15160 Summary

Re: [Intel-gfx] [PATCH] drm/i915/lmem: fixup fake lmem teardown

On Wed, Nov 06, 2019 at 12:31:35PM +, Matthew Auld wrote: We should not be unconditionally calling release_fake_lmem_bar. Signed-off-by: Matthew Auld Cc: Lucas De Marchi Cc: Chris Wilson Reviewed-by: Lucas De Marchi Unbinding the module is now working again, thanks. Lucas De Marchi

[Intel-gfx] [PATCH] drm/i915: Split a setting of MSA to MST and SST

The setting of MSA is done by the DDI .pre_enable() hook. And when we are using MST, the MSA is only set to first mst stream by calling of DDI .pre_eanble() hook. It raies issues to non-first mst streams. Wrong MSA or missed MSA packets might show scrambled screen or wrong screen. This splits a se

Re: [Intel-gfx] [PATCH V8 0/6] mdev based hardware virtio offloading support

On Wed, 6 Nov 2019 14:25:23 -0500 "Michael S. Tsirkin" wrote: > On Wed, Nov 06, 2019 at 12:03:12PM -0700, Alex Williamson wrote: > > On Wed, 6 Nov 2019 11:56:46 +0800 > > Jason Wang wrote: > > > > > On 2019/11/6 上午1:58, Alex Williamson wrote: > > > > On Tue, 5 Nov 2019 17:32:34 +0800 > > >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: store child devices in a list

== Series Details == Series: drm/i915/bios: store child devices in a list URL : https://patchwork.freedesktop.org/series/69077/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7274 -> Patchwork_15159 Summary --- **FAIL

Re: [Intel-gfx] [PATCH] drm/i915/bios: store child devices in a list

On Wed, Nov 06, 2019 at 06:45:31PM +0200, Jani Nikula wrote: > Using the array is getting clumsy. Make things a bit more dynamic. > > In code, start migrating towards calling the new struct child_device > "child" and the VBT-originating struct child_device_config "config". > > Remove early return

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Properly capture & release GuC interrupts on Gen11+

== Series Details == Series: drm/i915/guc: Properly capture & release GuC interrupts on Gen11+ URL : https://patchwork.freedesktop.org/series/69019/ State : success == Summary == CI Bug Log - changes from CI_DRM_7264_full -> Patchwork_15139_full

Re: [Intel-gfx] [PATCH] drm/fbdev: Fallback to non tiled mode if all tiles not present

On Wed, Nov 06, 2019 at 12:47:16PM +1000, Dave Airlie wrote: > On Fri, 1 Nov 2019 at 07:46, Manasi Navare wrote: > > > > In case of tiled displays, if we hotplug just one connector, > > fbcon currently just selects the preferred mode and if it is > > tiled mode then that becomes a problem if rest

[Intel-gfx] [PULL] drm-misc-next-fixes

Hi Dave & Daniel, drm-misc-next-fixes is open and just a couple of patches this week. drm-misc-next-fixes-2019-11-06: -msm: Fix up a6xx debugbus register names (Sharat) -mst: Avoid u64 division (Sean) Cc: Sharat Masetty Cc: Sean Paul Cheers, Sean The following changes since commit cea35f5ad

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/bios: store child devices in a list

== Series Details == Series: drm/i915/bios: store child devices in a list URL : https://patchwork.freedesktop.org/series/69077/ State : warning == Summary == $ dim checkpatch origin/drm-tip b08607b14961 drm/i915/bios: store child devices in a list -:388: CHECK:CAMELCASE: Avoid CamelCase: #388

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/2] drm/i915: lookup for mem_region of a mem_type

== Series Details == Series: series starting with [v4,1/2] drm/i915: lookup for mem_region of a mem_type URL : https://patchwork.freedesktop.org/series/69075/ State : success == Summary == CI Bug Log - changes from CI_DRM_7274 -> Patchwork_15158 ===

Re: [Intel-gfx] [PATCH V8 0/6] mdev based hardware virtio offloading support

On Wed, Nov 06, 2019 at 12:03:12PM -0700, Alex Williamson wrote: > On Wed, 6 Nov 2019 11:56:46 +0800 > Jason Wang wrote: > > > On 2019/11/6 上午1:58, Alex Williamson wrote: > > > On Tue, 5 Nov 2019 17:32:34 +0800 > > > Jason Wang wrote: > > > > > >> Hi all: > > >> > > >> There are hardwares tha

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Handle i915_active_fence_set() with the same fence

== Series Details == Series: series starting with [1/3] drm/i915: Handle i915_active_fence_set() with the same fence URL : https://patchwork.freedesktop.org/series/69074/ State : success == Summary == CI Bug Log - changes from CI_DRM_7273 -> Patchwork_15157 ===

Re: [Intel-gfx] [PATCH V8 0/6] mdev based hardware virtio offloading support

On Wed, 6 Nov 2019 11:56:46 +0800 Jason Wang wrote: > On 2019/11/6 上午1:58, Alex Williamson wrote: > > On Tue, 5 Nov 2019 17:32:34 +0800 > > Jason Wang wrote: > > > >> Hi all: > >> > >> There are hardwares that can do virtio datapath offloading while > >> having its own control path. This path

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,1/5] drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY under a separate Kconfig

== Series Details == Series: series starting with [v3,1/5] drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY under a separate Kconfig URL : https://patchwork.freedesktop.org/series/69068/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7273 -> Patchwork_15155 =

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Fix error path to unlock if the GEM context is closed

== Series Details == Series: drm/i915/gem: Fix error path to unlock if the GEM context is closed URL : https://patchwork.freedesktop.org/series/69070/ State : failure == Summary == Applying: drm/i915/gem: Fix error path to unlock if the GEM context is closed Using index info to reconstruct a b

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/5] drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY under a separate Kconfig

== Series Details == Series: series starting with [v3,1/5] drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY under a separate Kconfig URL : https://patchwork.freedesktop.org/series/69068/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7737267b3477 drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY un

[Intel-gfx] [PATCH 1/2] drm/i915/guc: Add GuC method to determine if submission is active.

From: Don Hiatt Add intel_guc_submission_is_enabled() function to determine if GuC submission is active. Based on code by Michal Wajdeczko. Signed-off-by: Don Hiatt --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 1 + drivers/

[Intel-gfx] [PATCH 2/2] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

From: Don Hiatt On some platforms (e.g. KBL) that do not support GuC submission, but the user enabled the GuC communication (e.g for HuC authentication) calling the GuC EXIT_S_STATE action results in lose of ability to enter RC6. We can remove the GuC suspend/resume entirely as we do not need to

Re: [Intel-gfx] [PATCH] drm/i915: Don't oops in dumb_create ioctl if we have no crtcs

Quoting Ville Syrjala (2019-11-06 17:23:49) > From: Ville Syrjälä > > Make sure we have a crtc before probing its primary plane's > max stride. Initially I thought we can't get this far without > crtcs, but looks like we can via the dumb_create ioctl. > > Not sure if we shouldn't disable dumb bu

[Intel-gfx] [PATCH] drm/i915/gvt: fix dropping obj reference twice

The reference count of obj will be decremented twice if error occurs in dma_buf_fd(). Additionally, attempting to read the reference count of obj after dropping reference may lead to a use after free bug. Here, we drop obj's reference until it is not used. Signed-off-by: Pan Bian --- drivers/gpu

[Intel-gfx] [PATCH] drm/i915: Don't oops in dumb_create ioctl if we have no crtcs

From: Ville Syrjälä Make sure we have a crtc before probing its primary plane's max stride. Initially I thought we can't get this far without crtcs, but looks like we can via the dumb_create ioctl. Not sure if we shouldn't disable dumb buffer support entirely when we have no crtcs, but that woul

[Intel-gfx] [CI] drm/i915: Remove unwanted rcu_read_lock/unlock

From: Niranjana Vishwanathapura We don't need rcu read side critical section to call pid_nr(), remove it. Signed-off-by: Niranjana Vishwanathapura Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gpu_error.c | 3 --- 1 file changed, 3 deletions(-) diff --g

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/4] drm: Expose a method for creating anonymous struct file around drm_minor

== Series Details == Series: series starting with [v2,1/4] drm: Expose a method for creating anonymous struct file around drm_minor URL : https://patchwork.freedesktop.org/series/69064/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7270 -> Patchwork_15154

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/4] drm: Expose a method for creating anonymous struct file around drm_minor

== Series Details == Series: series starting with [v2,1/4] drm: Expose a method for creating anonymous struct file around drm_minor URL : https://patchwork.freedesktop.org/series/69064/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3a38f9e9be4b drm: Expose a method for creatin

[Intel-gfx] ✓ Fi.CI.BAT: success for mdev based hardware virtio offloading support

== Series Details == Series: mdev based hardware virtio offloading support URL : https://patchwork.freedesktop.org/series/69063/ State : success == Summary == CI Bug Log - changes from CI_DRM_7270 -> Patchwork_15153 Summary --- **SUC

[Intel-gfx] [PATCH] drm/i915/bios: store child devices in a list

Using the array is getting clumsy. Make things a bit more dynamic. In code, start migrating towards calling the new struct child_device "child" and the VBT-originating struct child_device_config "config". Remove early returns on not having child devices when the end result after "iterating" the e

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for mdev based hardware virtio offloading support

== Series Details == Series: mdev based hardware virtio offloading support URL : https://patchwork.freedesktop.org/series/69063/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2e15c56da9d0 mdev: class id support aa81f6ab1bbe modpost: add support for mdev class id 94e6d607158c md

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Only drop heartbeat.systole if the sole owner

== Series Details == Series: drm/i915/gt: Only drop heartbeat.systole if the sole owner URL : https://patchwork.freedesktop.org/series/69060/ State : success == Summary == CI Bug Log - changes from CI_DRM_7270 -> Patchwork_15152 Summary ---

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915: lookup for mem_region of a mem_type

On 2019-11-06 at 21:45:44 +0530, Tang, CQ wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of > > Ramalingam C > > Sent: Wednesday, November 6, 2019 8:08 AM > > To: intel-gfx ; Chris Wilson > wilson.co.uk> > > Cc: Auld, Matthew > > Subject: [Intel-gfx] [PATCH v4 1/2] drm

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915: lookup for mem_region of a mem_type

> -Original Message- > From: Intel-gfx On Behalf Of > Ramalingam C > Sent: Wednesday, November 6, 2019 8:08 AM > To: intel-gfx ; Chris Wilson wilson.co.uk> > Cc: Auld, Matthew > Subject: [Intel-gfx] [PATCH v4 1/2] drm/i915: lookup for mem_region of a > mem_type > > Lookup function to

[Intel-gfx] [PATCH v4 2/2] drm/i915: Create dumb buffer from LMEM

When LMEM is supported, dumb buffer preferred to be created from LMEM. v2: Parameters are reshuffled. [Chris] v3: s/region_id/mem_type v4: use the i915_gem_object_create_region [chris] Signed-off-by: Ramalingam C cc: Matthew Auld --- drivers/gpu/drm/i915/i915_gem.c | 15 ---

[Intel-gfx] [PATCH v4 1/2] drm/i915: lookup for mem_region of a mem_type

Lookup function to retrieve the pointer to a memory region of a mem_type. Signed-off-by: Ramalingam C cc: Matthew Auld --- drivers/gpu/drm/i915/intel_memory_region.c | 12 drivers/gpu/drm/i915/intel_memory_region.h | 3 +++ 2 files changed, 15 insertions(+) diff --git a/drivers/g

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm: Expose a method for creating anonymous struct file around drm_minor

== Series Details == Series: series starting with [1/4] drm: Expose a method for creating anonymous struct file around drm_minor URL : https://patchwork.freedesktop.org/series/69059/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7270 -> Patchwork_15151 ===

Re: [Intel-gfx] [PATCH RESEND 07/14] drm/msm/hdmi: Provide ddc symlink in hdmi connector sysfs directory

On Mon, Aug 26, 2019 at 3:27 PM Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > Acked-by: Sam Ravnborg > Reviewed-by: Emil Velikov Acked-by: Sean Paul > --- > drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 6 +++

[Intel-gfx] [PATCH 2/3] drm/i915: Drop inspection of execbuf flags during evict

With the goal of removing the serialisation from around execbuf, we will no longer have the privilege of there being a single execbuf in flight at any time and so will only be able to inspect the user's flags within the carefully controlled execbuf context. i915_gem_evict_for_node() is the only use

[Intel-gfx] [PATCH 1/3] drm/i915: Handle i915_active_fence_set() with the same fence

If the caller wants to overwrite the currently tracked fence, with itself, as far as the tracking is concerned it is a no-op, so simply allow it. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_active.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[Intel-gfx] [PATCH 3/3] drm/i915/gem: Extract transient execbuf flags from i915_vma

For our convenience, and to avoid frequent allocations, we placed some lists we use for execbuf inside the common i915_vma struct. As we look to parallelise execbuf, such fields guarded by the struct_mutex BKL must be pulled under local control. Instead of using the i915_vma as our primary means of

Re: [Intel-gfx] [PATCH] drm/i915/gem: Fix error path to unlock if the GEM context is closed

On 06/11/2019 14:41, Chris Wilson wrote: When inside the lock, remember to unlock even if you want to leave early. Reported-by: Dan Carpenter Fixes: a4e7ccdac38e ("drm/i915: Move context management under GEM") Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm: Expose a method for creating anonymous struct file around drm_minor

== Series Details == Series: series starting with [1/4] drm: Expose a method for creating anonymous struct file around drm_minor URL : https://patchwork.freedesktop.org/series/69059/ State : warning == Summary == $ dim checkpatch origin/drm-tip d7aa94bb3f9e drm: Expose a method for creating a

Re: [Intel-gfx] [bug report] drm/i915: Move context management under GEM

Quoting Dan Carpenter (2019-11-06 13:48:14) > Hello Chris Wilson, > > The patch a4e7ccdac38e: "drm/i915: Move context management under GEM" > from Oct 4, 2019, leads to the following static checker warning: > > drivers/gpu/drm/i915/gem/i915_gem_context.c:980 set_ppgtt() > warn: 'c

[Intel-gfx] [PATCH] drm/i915/gem: Fix error path to unlock if the GEM context is closed

When inside the lock, remember to unlock even if you want to leave early. Reported-by: Dan Carpenter Fixes: a4e7ccdac38e ("drm/i915: Move context management under GEM") Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- 1 file changed, 1 inse

Re: [Intel-gfx] [PATCH] drm/i915/gt: Only drop heartbeat.systole if the sole owner

Chris Wilson writes: > Mika spotted that only using cancel_delayed_work() could mean that we > attempted to clear the heartbeat.systole while the worker was still > running. Rectify the situation by only touching the systole from outside > the worker if we suceeded in cancelling the worker before

[Intel-gfx] [PATCH v3 1/5] drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY under a separate Kconfig

Currently, we only export symbols for drm-selftests which are either compiled as modules or into the main drm builtin. However, if we want to export symbols from drm.ko for the drivers' selftests, we require a means of controlling that export separately. So we add a new Kconfig to determine whether

[Intel-gfx] [PATCH v3 5/5] drm/i915/selftests: Verify mmap_gtt revocation on unbinding

Whenever, we unbind (or change fence registers) on an object, we must revoke any and all mmap_gtt using the previous bindings. Those user PTEs point at the GGTT which know points into a new object, the wrong object. Ergo, those PTEs must be cleared so that any user access provokes a new page fault.

[Intel-gfx] [PATCH v3 2/5] drm: Expose a method for creating anonymous struct file around drm_minor

Sometimes we need to create a struct file to wrap a drm_device, as it the user were to have opened /dev/dri/card0 but to do so anonymously (i.e. for internal use). Provide a utility method to create a struct file with the drm_device->driver.fops, that wrap the drm_device. v2: Restrict usage to sel

[Intel-gfx] [PATCH v3 4/5] drm/i915/selftests: Wrap vm_mmap() around GEM objects

Provide a utility function to create a vma corresponding to an mmap() of our device. And use it to exercise the equivalent of userspace performing a GTT mmap of our objects. Signed-off-by: Chris Wilson Cc: Abdiel Janulgue --- drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/ge

[Intel-gfx] mock_drm_getfile(), take three

Like v2, but with more Kconfig hackery so that i915.ko can request builtin-drm (and drm-selftests) export the symbols it requires for its selftests. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/

[Intel-gfx] [PATCH v3 3/5] drm/i915/selftests: Replace mock_file hackery with drm's true fake

As drm now exports a method to create an anonymous struct file around a drm_device for internal use, make use of it to avoid our horrible hacks. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Kconfig.debug| 2 + .../gpu/drm/i915/gem/selftests/huge_pages.c | 2 +- .../drm/i9

Re: [Intel-gfx] [PATCH v2 1/4] drm: Expose a method for creating anonymous struct file around drm_minor

On Wed, Nov 06, 2019 at 01:57:36PM +, Chris Wilson wrote: > Sometimes we need to create a struct file to wrap a drm_device, as it > the user were to have opened /dev/dri/card0 but to do so anonymously > (i.e. for internal use). Provide a utility method to create a struct > file with the drm_dev

Re: [Intel-gfx] [PATCH V10 0/6] mdev based hardware virtio offloading support

On Wed, 6 Nov 2019 21:35:25 +0800 Jason Wang wrote: > Hi all: > > There are hardwares that can do virtio datapath offloading while > having its own control path. This path tries to implement a mdev based > unified API to support using kernel virtio driver to drive those > devices. This is done

Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region

On Wed, Nov 06, 2019 at 11:17:29AM +, Chris Wilson wrote: > Quoting Arkadiusz Hiler (2019-11-06 08:30:37) > > On Tue, Nov 05, 2019 at 01:05:20PM +, Matthew Auld wrote: > > > On Thu, 31 Oct 2019 at 20:40, Chris Wilson > > > wrote: > > > > > > > > Quoting Arkadiusz Hiler (2019-10-31 12:40:3

[Intel-gfx] [PATCH v2 3/4] drm/i915/selftests: Wrap vm_mmap() around GEM objects

Provide a utility function to create a vma corresponding to an mmap() of our device. And use it to exercise the equivalent of userspace performing a GTT mmap of our objects. Signed-off-by: Chris Wilson Cc: Abdiel Janulgue --- drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/ge

[Intel-gfx] [PATCH v2 4/4] drm/i915/selftests: Verify mmap_gtt revocation on unbinding

Whenever, we unbind (or change fence registers) on an object, we must revoke any and all mmap_gtt using the previous bindings. Those user PTEs point at the GGTT which know points into a new object, the wrong object. Ergo, those PTEs must be cleared so that any user access provokes a new page fault.

[Intel-gfx] [PATCH v2 2/4] drm/i915/selftests: Replace mock_file hackery with drm's true fake

As drm now exports a method to create an anonymous struct file around a drm_device for internal use, make use of it to avoid our horrible hacks. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Kconfig.debug| 2 + .../gpu/drm/i915/gem/selftests/huge_pages.c | 2 +- .../drm/i9

[Intel-gfx] [PATCH v2 1/4] drm: Expose a method for creating anonymous struct file around drm_minor

Sometimes we need to create a struct file to wrap a drm_device, as it the user were to have opened /dev/dri/card0 but to do so anonymously (i.e. for internal use). Provide a utility method to create a struct file with the drm_device->driver.fops, that wrap the drm_device. v2: Restrict usage to sel

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lmem: fixup fake lmem teardown

== Series Details == Series: drm/i915/lmem: fixup fake lmem teardown URL : https://patchwork.freedesktop.org/series/69057/ State : success == Summary == CI Bug Log - changes from CI_DRM_7267 -> Patchwork_15150 Summary --- **SUCCESS**

[Intel-gfx] [bug report] drm/i915: Move context management under GEM

Hello Chris Wilson, The patch a4e7ccdac38e: "drm/i915: Move context management under GEM" from Oct 4, 2019, leads to the following static checker warning: drivers/gpu/drm/i915/gem/i915_gem_context.c:980 set_ppgtt() warn: 'ctx->mutex' both locked and unlocked. drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Frob the correct crtc state in intel_crtc_disable_noatomic()

On Wed, Nov 06, 2019 at 12:53:45PM +0100, Maarten Lankhorst wrote: > Op 05-11-2019 om 18:14 schreef Ville Syrjala: > > From: Ville Syrjälä > > > > The uapi vs. hw state split introduced a bug in > > intel_crtc_disable_noatomic() where it's not frobbing an already s/not/now/ and pushed to dinq. Th

[Intel-gfx] [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

This sample driver creates mdev device that simulate virtio net device over virtio mdev transport. The device is implemented through vringh and workqueue. A device specific dma ops is to make sure HVA is used directly as the IOVA. This should be sufficient for kernel virtio driver to work. Only 'v

[Intel-gfx] [PATCH V10 5/6] virtio: introduce a mdev based transport

This patch introduces a new mdev transport for virtio. This is used to use kernel virtio driver to drive the mediated device that is capable of populating virtqueue directly. A new virtio-mdev driver will be registered to the mdev bus, when a new virtio-mdev device is probed, it will register the

  1   2   >