> From: Chery, Nanley G
> Sent: Tuesday, November 12, 2019 9:40 AM
> To: Sripada, Radhakrishna; intel-gfx@lists.freedesktop.org
> Cc: Pandiyan, Dhinakaran; Syrjala, Ville; Sharma, Shashank; Antognolli,
> Rafael; Ville Syrjala; Ekstrand, Jason
> Subject: RE: [PATCH v6 09/10] drm/framebuffer/tgl: Fo
With GPU relocations we avoid blocking inside execbuf and prevent
priority inversions where a low priority client can cause a denial of
service to higher priority clients.
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
---
tests/i915/gem_exec_reloc.c | 45 +
1
below is the call trace when this issue is hit
<3> [113.316247] BUG: sleeping function called from invalid context at
mm/page_alloc.c:4653
<3> [113.318190] in_atomic(): 1, irqs_disabled(): 0, pid: 678, name:
debugfs_test
<4> [113.319900] no locks held by debugfs_test/678.
<3> [113.321002] Preemp
== Series Details ==
Series: igt: Use COND_BBEND for busy spinning on gen9
URL : https://patchwork.freedesktop.org/series/69423/
State : warning
== Summary ==
Did not get list of undocumented tests for this run, something is wrong!
Other than that, pipeline status: FAILED.
see https://gitlab
On Wed, 2019-11-13 at 18:04 +0530, Anshuamn Gupta wrote:
> Looks good to me, there is a minor comment see below.
> On 2019-10-31 at 17:14:20 -0700, José Roberto de Souza wrote:
> > Both activate functions and the dc3co disable function were doing
> > the
> > same thing, so better move to a function
Extend disabling SAMPLER_STATE prefetch workaround to gen12.
v2: Limit the WA to TGL A0 and update the WA no(Chris)
BSpec: 52890
Cc: Chris Wilson
Cc: Mika Kuoppala
Signed-off-by: Radhakrishna Sripada
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 15 ++-
1 file changed, 10 inse
Quoting Bruce Chang (2019-11-13 23:11:04)
> below is the call trace when this issue is hit
>
> <3> [113.316247] BUG: sleeping function called from invalid context at
> mm/page_alloc.c:4653
> <3> [113.318190] in_atomic(): 1, irqs_disabled(): 0, pid: 678, name:
> debugfs_test
> <4> [113.319900] no
below is the call trace when this issue is hit
<3> [113.316247] BUG: sleeping function called from invalid context at
mm/page_alloc.c:4653
<3> [113.318190] in_atomic(): 1, irqs_disabled(): 0, pid: 678, name:
debugfs_test
<4> [113.319900] no locks held by debugfs_test/678.
<3> [113.321002] Preemp
Quoting Radhakrishna Sripada (2019-11-13 23:19:53)
> Extend disabling SAMPLER_STATE prefetch workaround to gen12.
>
> v2: Limit the WA to TGL A0 and update the WA no(Chris)
>
> BSpec: 52890
> Cc: Chris Wilson
> Cc: Mika Kuoppala
> Signed-off-by: Radhakrishna Sripada
Reviewed-by: Chris Wilson
Quoting Mika Kuoppala (2019-11-13 15:49:09)
> From: "Kuoppala, Mika"
>
> If cmd parser is mandatory, batch can't be modified post execbuf.
> Some tests rely on modifying batch post execbuf. Give those
> tests a method to query if those modifications ever reach
> the actual engine command stream.
On Tue, Nov 12, 2019 at 04:14:54PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Just pass the atomic state and the crtc to intel_encoders_enable() & co.
> Make life simpler when you don't have to think which state (old vs. new)
> you have to pass in. Also constify the states while at it.
On Tue, Nov 12, 2019 at 04:14:55PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> We already have intel_crtc_vblank_on(). Add a counterpart so we
> don't have to inline the disable+assert all over.
>
> Signed-off-by: Ville Syrjälä
LGTM,
Reviewed-by: Manasi Navare
Manasi
> ---
> dri
Quoting Mika Kuoppala (2019-11-13 15:49:09)
> diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
> index 5c15f177..ca6bef6a 100644
> --- a/tests/i915/gem_exec_schedule.c
> +++ b/tests/i915/gem_exec_schedule.c
> @@ -652,7 +652,8 @@ static void semaphore_noskip(int i915)
>
On Tue, Nov 12, 2019 at 04:14:56PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Move the assert_vblank_disabled() into intel_crtc_vblank_on()
> so that we don't have to inline it all over.
>
> This does mean we now assert_vblank_disabled() during readout as well
> but that is totally fi
On Tue, Nov 12, 2019 at 04:14:57PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> intel_modeset_setup_hw_state() doesn't need the crtc_state at the
> top level scope. Move it to where it's needed.
>
> Signed-off-by: Ville Syrjälä
Looks good even though it does add to the code size since
On Tue, Nov 12, 2019 at 04:14:58PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Switch to intel_crtc from drm_crtc.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Manasi Navare
Manasi
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 10 --
> 1 file changed, 4 insertio
On Tue, Nov 12, 2019 at 04:14:59PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Just pass the atomic_state+crtc to the watermarks hooks. Eeasier
> time for the caller when it doesn't have to think what to pass.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/display/inte
On Tue, Nov 12, 2019 at 04:15:00PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Get rid of the last 'dev' usage in ironlake_crtc_enable() by
> passing dev_priv to cpt_verify_modeset().
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Manasi Navare
Manasi
> ---
> drivers/gpu/drm/i915/
On Tue, Nov 12, 2019 at 04:15:01PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Get rid of the horrible aliasing drm_crtc and intel_crtc variables
> in the crtc enable/disable hooks.
>
> Signed-off-by: Ville Syrjälä
Great this addresses my concern on intel_crtc vs crtc on the previous
On Tue, Nov 12, 2019 at 04:15:02PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Rename pipe_config to new_crtc_state in the .crtc_enable() hooks.
> The 'pipe_config' name is a zombie that we need to finally put down.
So basically use pipe_config only in atomic check functions
like compu
On Tue, Nov 12, 2019 at 04:15:03PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Just pass the atomic state+crtc to the .crtc_enable()
> .crtc_disable(). Life is easier when you don't have to think
> whether to pass the old or the new crtc state.
>
> Signed-off-by: Ville Syrjälä
makes
The landing of the i915 CVE fixes into Linus tree has created a bit of
a mess in linux-next and downstream in drm-next trees.
I talked to Daniel and he had talked to Joonas a bit, and I decided to
go with what Daniel describes as the YOLO merge, where I just solve it
and pray, and everyone else ve
== Series Details ==
Series: drm/fbdev: Fallback to non tiled mode if all tiles not present (rev3)
URL : https://patchwork.freedesktop.org/series/68838/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7340 -> Patchwork_15254
== Series Details ==
Series: drm/i915: Fix a bug calling sleep function in atomic context (rev4)
URL : https://patchwork.freedesktop.org/series/69385/
State : failure
== Summary ==
Applying: drm/i915: Fix a bug calling sleep function in atomic context
Using index info to reconstruct a base tre
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/tgl: Wa_1606679103 (rev2)
URL : https://patchwork.freedesktop.org/series/69420/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7341 -> Patchwork_15255
Summa
Hi Dave and Daniel,
Here goes drm-intel-fixes-2019-11-13:
- MOCS table fixes for EHL and TGL
- Update Display's rawclock on resume
- GVT's dmabuf reference drop fix
Thanks,
Rodrigo.
The following changes since commit 31f4f5b495a62c9a8b15b1c3581acd5efeb9af8c:
Linux 5.4-rc7 (2019-11-10 16:17:1
== Series Details ==
Series: drm/i915/gt: Invalidate as we write the gen7 breadcrumb
URL : https://patchwork.freedesktop.org/series/69408/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7331_full -> Patchwork_15249_full
Summ
== Series Details ==
Series: drm/i915/perf: don't forget noa wait after oa config
URL : https://patchwork.freedesktop.org/series/69409/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7331_full -> Patchwork_15250_full
Summary
Hello Chris Wilson,
The patch f40a7b7558ef: "drm/i915: Initial selftests for exercising
eviction" from Feb 13, 2017, leads to the following static checker
warning:
drivers/gpu/drm/i915/selftests/i915_gem_evict.c:202 igt_overcommit()
warn: passing zero to 'PTR_ERR'
drivers/gpu/drm
Quoting Dan Carpenter (2019-11-14 06:54:37)
> Hello Chris Wilson,
>
> The patch f40a7b7558ef: "drm/i915: Initial selftests for exercising
> eviction" from Feb 13, 2017, leads to the following static checker
> warning:
>
> drivers/gpu/drm/i915/selftests/i915_gem_evict.c:202 igt_overcommit(
Quoting Lionel Landwerlin (2019-11-13 18:33:59)
> On 13/11/2019 20:11, Chris Wilson wrote:
> > Quoting Chris Wilson (2019-11-13 18:10:22)
> >> Quoting Lionel Landwerlin (2019-11-13 18:07:59)
> >>> On 13/11/2019 18:35, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2019-11-13 15:46:39)
>
101 - 131 of 131 matches
Mail list logo
