[Intel-gfx] [PATCH i-g-t v2] i915/pm_rps: install SIGTERM handler for load_helper process

2019-11-19 Thread Chuansheng Liu
Reference: https://bugs.freedesktop.org/show_bug.cgi?id=112126 The issue we hit is the GPU keeps very high load after running the subtest min-max-config-loaded. Some background of the issue: Currently the rps is not fully enabled yet on TGL, and running the subtest min-max-config-loaded will hit

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Do not initialize display BW when display not available

2019-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Do not initialize display BW when display not available URL : https://patchwork.freedesktop.org/series/69714/ State : success == Summary == CI Bug Log - changes from CI_DRM_7380 -> Patchwork_15339 Summ

Re: [Intel-gfx] [PATCH V13 4/6] mdev: introduce mediated virtio bus

2019-11-19 Thread Jason Wang
On 2019/11/19 下午10:14, Jason Gunthorpe wrote: On Tue, Nov 19, 2019 at 10:02:08PM +0800, Jason Wang wrote: On 2019/11/19 下午8:38, Jason Gunthorpe wrote: On Tue, Nov 19, 2019 at 10:41:31AM +0800, Jason Wang wrote: On 2019/11/19 上午4:28, Jason Gunthorpe wrote: On Mon, Nov 18, 2019 at 03:27:13PM -

Re: [Intel-gfx] [PATCH 3/3] drm/msm: Don't init ww_mutec acquire ctx before needed

2019-11-19 Thread Rob Clark
On Tue, Nov 19, 2019 at 1:08 PM Daniel Vetter wrote: > > For locking semantics it really doesn't matter when we grab the > ticket. But for lockdep validation it does: the acquire ctx is a fake > lockdep. Since other drivers might want to do a full multi-lock dance > in their fault-handler, not jus

[Intel-gfx] ✓ Fi.CI.BAT: success for Skip MCHBAR queries when display is not available

2019-11-19 Thread Patchwork
== Series Details == Series: Skip MCHBAR queries when display is not available URL : https://patchwork.freedesktop.org/series/69712/ State : success == Summary == CI Bug Log - changes from CI_DRM_7380 -> Patchwork_15338 Summary --- *

[Intel-gfx] [PATCH] drm/i915: Do not initialize display BW when display not available

2019-11-19 Thread Stuart Summers
When display is not available, finding the memory bandwidth available for display is not useful. Skip this sequence here. References: HSDES 1209978255 Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/display/intel_bw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: re-init the GT in live_gt_pm

2019-11-19 Thread Patchwork
== Series Details == Series: drm/i915/selftests: re-init the GT in live_gt_pm URL : https://patchwork.freedesktop.org/series/69710/ State : success == Summary == CI Bug Log - changes from CI_DRM_7380 -> Patchwork_15337 Summary --- **

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: make pool objects read-only

2019-11-19 Thread Patchwork
== Series Details == Series: drm/i915: make pool objects read-only URL : https://patchwork.freedesktop.org/series/69684/ State : success == Summary == CI Bug Log - changes from CI_DRM_7371_full -> Patchwork_15330_full Summary --- **S

[Intel-gfx] [PATCH] Skip MCHBAR queries when display is not available

2019-11-19 Thread Stuart Summers
Platforms without display do not map the MCHBAR MMIO into the GFX device BAR. Skip this sequence when display is not available. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/i915_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/

Re: [Intel-gfx] [PATCH] drm/i915/selftests: re-init the GT in live_gt_pm

2019-11-19 Thread Daniele Ceraolo Spurio
On 11/19/19 4:21 PM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-11-20 00:04:25) When GuC is in use we need to make sure it is re-loaded before the call to gt_resume, otherwise communication from the engines to the GuC will not be processed, which blocks the engines from ctx switc

Re: [Intel-gfx] [PATCH] drm/i915/selftests: re-init the GT in live_gt_pm

2019-11-19 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-11-20 00:04:25) > When GuC is in use we need to make sure it is re-loaded before the call > to gt_resume, otherwise communication from the engines to the GuC will > not be processed, which blocks the engines from ctx switching and from > being reset. > > Bugzil

Re: [Intel-gfx] [PATCH v12 2/2] drm/i915: Restrict qgv points which don't have enough bandwidth.

2019-11-19 Thread Matt Roper
On Fri, Nov 15, 2019 at 04:54:01PM +0200, Stanislav Lisovskiy wrote: > According to BSpec 53998, we should try to > restrict qgv points, which can't provide > enough bandwidth for desired display configuration. > > Currently we are just comparing against all of > those and take minimum(worst case)

Re: [Intel-gfx] [CI 4/5] drm/i915/guc: kill the GuC client

2019-11-19 Thread Daniele Ceraolo Spurio
@@ -220,7 +200,7 @@ static void guc_wq_item_append(struct intel_guc_client *client, GEM_BUG_ON(wq_off & (wqi_size - 1)); /* WQ starts from the page after process_desc */ Just realized that I stupidly forgot to actually commit the fix... I'll send the fixed (for real) version a

[Intel-gfx] [PATCH] drm/i915/selftests: re-init the GT in live_gt_pm

2019-11-19 Thread Daniele Ceraolo Spurio
When GuC is in use we need to make sure it is re-loaded before the call to gt_resume, otherwise communication from the engines to the GuC will not be processed, which blocks the engines from ctx switching and from being reset. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112205 Cc: Andi

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Cleanups around .crtc_enable/disable() (rev4)

2019-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Cleanups around .crtc_enable/disable() (rev4) URL : https://patchwork.freedesktop.org/series/69352/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7371_full -> Patchwork_15329_full Summ

Re: [Intel-gfx] [PATCH v12 1/2] drm/i915: Refactor intel_can_enable_sagv

2019-11-19 Thread Matt Roper
On Fri, Nov 15, 2019 at 04:54:00PM +0200, Stanislav Lisovskiy wrote: > Currently intel_can_enable_sagv function contains > a mix of workarounds for different platforms > some of them are not valid for gens >= 11 already, > so lets split it into separate functions. > > v2: > - Rework watermark

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915/gem_mmap_gtt: Exercise many, many mappings of the same objects

2019-11-19 Thread Patchwork
== Series Details == Series: i915/gem_mmap_gtt: Exercise many, many mappings of the same objects URL : https://patchwork.freedesktop.org/series/69678/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7371_full -> IGTPW_3727_full ===

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gem: Ensure aperture exists before setting domain to GTT

2019-11-19 Thread Summers, Stuart
On Tue, 2019-11-19 at 22:57 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/gem: Ensure aperture exists before setting domain to > GTT > URL : https://patchwork.freedesktop.org/series/69698/ > State : failure > > == Summary == > > CALLscripts/checksyscalls.sh > CALL

Re: [Intel-gfx] [PATCH] drm/i915/gem: Ensure aperture exists before setting domain to GTT

2019-11-19 Thread Chris Wilson
Quoting Summers, Stuart (2019-11-19 22:58:38) > On Tue, 2019-11-19 at 22:08 +, Chris Wilson wrote: > > Quoting Stuart Summers (2019-11-19 21:30:32) > > > mmap_gtt is already covered by a check for aperture presence. > > > Also add the case to the gem_set_domain IOCTL to avoid this > > > path fo

Re: [Intel-gfx] [PATCH] drm/i915/gem: Ensure aperture exists before setting domain to GTT

2019-11-19 Thread Summers, Stuart
On Tue, 2019-11-19 at 22:08 +, Chris Wilson wrote: > Quoting Stuart Summers (2019-11-19 21:30:32) > > mmap_gtt is already covered by a check for aperture presence. > > Also add the case to the gem_set_domain IOCTL to avoid this > > path for unsupported platforms. > > It doesn't harm either, it

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gem: Ensure aperture exists before setting domain to GTT

2019-11-19 Thread Patchwork
== Series Details == Series: drm/i915/gem: Ensure aperture exists before setting domain to GTT URL : https://patchwork.freedesktop.org/series/69698/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/gen

[Intel-gfx] ✓ Fi.CI.BAT: success for more dma-buf lockdep priming

2019-11-19 Thread Patchwork
== Series Details == Series: more dma-buf lockdep priming URL : https://patchwork.freedesktop.org/series/69695/ State : success == Summary == CI Bug Log - changes from CI_DRM_7380 -> Patchwork_15335 Summary --- **SUCCESS** No regr

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for more dma-buf lockdep priming

2019-11-19 Thread Patchwork
== Series Details == Series: more dma-buf lockdep priming URL : https://patchwork.freedesktop.org/series/69695/ State : warning == Summary == $ dim checkpatch origin/drm-tip 877e4edf1ff5 drm/modeset: Prime modeset lock vs dma_resv -:68: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line b

Re: [Intel-gfx] [PATCH] drm/i915/gem: Ensure aperture exists before setting domain to GTT

2019-11-19 Thread Chris Wilson
Quoting Stuart Summers (2019-11-19 21:30:32) > mmap_gtt is already covered by a check for aperture presence. > Also add the case to the gem_set_domain IOCTL to avoid this > path for unsupported platforms. It doesn't harm either, it will just mean in a place where it is neither in the GPU nor in th

Re: [Intel-gfx] [V3 8/8] drm/i915/dsi: Initiate fame request in cmd mode

2019-11-19 Thread kbuild test robot
Hi Vandita, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [cannot apply to v5.4-rc8 next-20191118] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' optio

[Intel-gfx] [PATCH] drm/i915/gem: Ensure aperture exists before setting domain to GTT

2019-11-19 Thread Stuart Summers
mmap_gtt is already covered by a check for aperture presence. Also add the case to the gem_set_domain IOCTL to avoid this path for unsupported platforms. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gem/i915_gem_domain.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gp

Re: [Intel-gfx] [PATCH 6/8] drm/xen: Simplify fb_create

2019-11-19 Thread Daniel Vetter
On Fri, Nov 15, 2019 at 10:33:24AM +, Oleksandr Andrushchenko wrote: > On 11/15/19 11:21 AM, Daniel Vetter wrote: > > The current code is a pretty good wtf moment, since we drop the > > reference before we use it. It's not a big deal, because a) we only > > use the pointer, so doesn't blow up a

Re: [Intel-gfx] [PATCH 5/8] drm/tilcdc: Drop drm_gem_fb_create wrapper

2019-11-19 Thread Daniel Vetter
On Fri, Nov 15, 2019 at 03:21:20PM +0200, Jyri Sarha wrote: > On 15/11/2019 11:21, Daniel Vetter wrote: > > Doesn't do anything. > > > > Signed-off-by: Daniel Vetter > > Cc: Jyri Sarha > > Cc: Tomi Valkeinen > > Acked-by: Jyri Sarha Thanks for taking a look, pushed to drm-misc-next. -Daniel

Re: [Intel-gfx] [PATCH 2/8] drm/atmel: ditch fb_create wrapper

2019-11-19 Thread Daniel Vetter
On Fri, Nov 15, 2019 at 10:33:24AM +0100, Boris Brezillon wrote: > On Fri, 15 Nov 2019 10:21:14 +0100 > Daniel Vetter wrote: > > > Spotted while looking through them all. > > > > Signed-off-by: Daniel Vetter > > Cc: Sam Ravnborg > > Cc: Boris Brezillon > > Acked-by: Boris Brezillon Merged,

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT

2019-11-19 Thread Hans de Goede
Hi, On 19-11-2019 20:33, Patchwork wrote: == Series Details == Series: drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT URL : https://patchwork.freedesktop.org/series/69686/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7377 -> Patchwork_15332 ==

[Intel-gfx] [PATCH 3/3] drm/msm: Don't init ww_mutec acquire ctx before needed

2019-11-19 Thread Daniel Vetter
For locking semantics it really doesn't matter when we grab the ticket. But for lockdep validation it does: the acquire ctx is a fake lockdep. Since other drivers might want to do a full multi-lock dance in their fault-handler, not just lock a single dma_resv. Therefore we must init the acquire_ctx

[Intel-gfx] [PATCH 1/3] drm/modeset: Prime modeset lock vs dma_resv

2019-11-19 Thread Daniel Vetter
It's kinda really hard to get this wrong on a driver with both display and dma_resv locking. But who ever knows, so better to make sure that really all drivers nest these the same way. For actual lock semantics the acquire context nesting doesn't matter. But to teach lockdep what's going on with w

[Intel-gfx] [PATCH 2/3] dma-resv: Also prime acquire ctx for lockdep

2019-11-19 Thread Daniel Vetter
Semnatically it really doesn't matter where we grab the ticket. But since the ticket is a fake lockdep lock, it matters for lockdep validation purposes. This means stuff like grabbing a ticket and then doing copy_from/to_user isn't allowed anymore. This is a changed compared to the current ttm fau

[Intel-gfx] [PATCH 0/3] more dma-buf lockdep priming

2019-11-19 Thread Daniel Vetter
Hi all, While looking at (dynamic) dma-buf issues and ideas I've spotted a bit more room for locking down the cross-driver dma_resv rules. Only functional fallout is a tiny patch for msm, assuming I didn't botch anything in the auditing of all relevant code. Comments, review and testing very muc

Re: [Intel-gfx] [V3 7/8] drm/i915/dsi: Add TE handler for dsi cmd mode.

2019-11-19 Thread kbuild test robot
Hi Vandita, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [cannot apply to v5.4-rc8 next-20191118] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' optio

Re: [Intel-gfx] [V3 6/8] drm/i915/dsi: Configure TE interrupt for cmd mode

2019-11-19 Thread kbuild test robot
Hi Vandita, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [cannot apply to v5.4-rc8 next-20191118] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' optio

Re: [Intel-gfx] [V3 4/8] drm/i915/dsi: Add check for periodic command mode

2019-11-19 Thread kbuild test robot
Hi Vandita, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [cannot apply to v5.4-rc8 next-20191118] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base'

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Exercise rc6 w/a handling

2019-11-19 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Exercise rc6 w/a handling URL : https://patchwork.freedesktop.org/series/69687/ State : success == Summary == CI Bug Log - changes from CI_DRM_7377 -> Patchwork_15333 Summary --- **SUC

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915/gt: Move new timelines to the end of active_list

2019-11-19 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Move new timelines to the end of active_list URL : https://patchwork.freedesktop.org/series/69690/ State : failure == Summary == Applying: drm/i915/gt: Move new timelines to the end of active_list Using index info to reco

Re: [Intel-gfx] [V3 1/8] drm/i915/dsi: Configure transcoder operation for command mode.

2019-11-19 Thread kbuild test robot
Hi Vandita, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [cannot apply to v5.4-rc8 next-20191118] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' optio

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Exercise rc6 w/a handling

2019-11-19 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Exercise rc6 w/a handling URL : https://patchwork.freedesktop.org/series/69687/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2337a2988c7f drm/i915/selftests: Exercise rc6 w/a handling -:61: WARNING:FILE_PATH_CHANGES: added, move

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT

2019-11-19 Thread Patchwork
== Series Details == Series: drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT URL : https://patchwork.freedesktop.org/series/69686/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7377 -> Patchwork_15332 ===

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add support for mipi dsi cmd mode (rev2)

2019-11-19 Thread Patchwork
== Series Details == Series: Add support for mipi dsi cmd mode (rev2) URL : https://patchwork.freedesktop.org/series/69290/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7370_full -> Patchwork_15328_full Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT

2019-11-19 Thread Patchwork
== Series Details == Series: drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT URL : https://patchwork.freedesktop.org/series/69686/ State : warning == Summary == $ dim checkpatch origin/drm-tip 076ee6713181 ACPI / LPSS: Rename pwm_backlight pwm-lookup to pwm_soc_backlig

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [01/19] drm/i915/selftests: Force bonded submission to overlap (rev2)

2019-11-19 Thread Patchwork
== Series Details == Series: series starting with [01/19] drm/i915/selftests: Force bonded submission to overlap (rev2) URL : https://patchwork.freedesktop.org/series/69647/ State : failure == Summary == Applying: drm/i915/selftests: Force bonded submission to overlap Applying: drm/i915/gem:

Re: [Intel-gfx] [PATCH 06/19] drm/i915/gt: Schedule request retirement when submission idles

2019-11-19 Thread Chris Wilson
Quoting Chris Wilson (2019-11-19 16:42:28) > Quoting Tvrtko Ursulin (2019-11-19 16:33:18) > > I also wonder if the current flush_submission wasn't the reason for > > performance regression you were seeing with this? It makes this tasklet > > wait for all other engines, if they are busy. But not s

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Track ggtt writes from userspace on the bound vma

2019-11-19 Thread Patchwork
== Series Details == Series: drm/i915/gem: Track ggtt writes from userspace on the bound vma URL : https://patchwork.freedesktop.org/series/69672/ State : success == Summary == CI Bug Log - changes from CI_DRM_7370_full -> Patchwork_15326_full ==

Re: [Intel-gfx] [PATCH 15/19] drm/i915/gt: Flush the requests after wedging on suspend

2019-11-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-19 16:12:18) > > On 18/11/2019 23:02, Chris Wilson wrote: > > Retire all requests if we resort to wedged the driver on suspend. They > > will now be idle, so we might as we free them before shutting down. > > > > Signed-off-by: Chris Wilson > > --- > > drivers/g

Re: [Intel-gfx] [PATCH 3/3] drm/i915: DSI: select correct PWM controller to use based on the VBT

2019-11-19 Thread Hans de Goede
Hi, On 19-11-2019 16:47, Ville Syrjälä wrote: On Tue, Nov 19, 2019 at 04:18:18PM +0100, Hans de Goede wrote: At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 different PWM controllers for controlling the LCD's backlight brightness. Either the one integrated into the PMIC o

Re: [Intel-gfx] [PATCH 04/17] drm/i915/gt: Make intel_ring_unpin() safe for concurrent pint

2019-11-19 Thread Mika Kuoppala
Chris Wilson writes: concurrent pint? Sure, thirsty already. But I am afraid you just mean concurrent pin :O > In order to avoid some nasty mutex inversions, commit 09c5ab384f6f > ("drm/i915: Keep rings pinned while the context is active") allowed the > intel_ring unpinning to be run concurrent

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Add DKL PHY vswing table for HDMI

2019-11-19 Thread Matt Roper
On Tue, Nov 19, 2019 at 05:25:31AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/tgl: Add DKL PHY vswing table for HDMI > URL : https://patchwork.freedesktop.org/series/69639/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_7365_full -> Patchwork_

Re: [Intel-gfx] [PATCH 06/19] drm/i915/gt: Schedule request retirement when submission idles

2019-11-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-19 16:33:18) > > On 19/11/2019 16:20, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-11-19 15:04:46) > >> > >> On 18/11/2019 23:02, Chris Wilson wrote: > >>> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c > >>> b/drivers/gpu/drm/i915/gt/intel_lrc.c > >>> in

Re: [Intel-gfx] [PATCH V13 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-19 Thread Jason Gunthorpe
On Tue, Nov 19, 2019 at 10:07:18PM +0800, Jason Wang wrote: > > On 2019/11/19 下午8:40, Jason Gunthorpe wrote: > > On Tue, Nov 19, 2019 at 11:03:39AM +0800, Jason Wang wrote: > > > > Also, see the other conversations we are having about a "virtual" bus > > > > and devices. I do not want to have two

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Wait until the intel_wakeref idle callback is complete

2019-11-19 Thread Chris Wilson
Quoting Mika Kuoppala (2019-11-19 16:12:18) > Chris Wilson writes: > > > When waiting for idle, serialise with any ongoing callback so that it > > will have completed before completing the wait. > > Might be come apparent and evident when reading the patch > that introduce the intel_wakeref_unlo

Re: [Intel-gfx] [PATCH 06/19] drm/i915/gt: Schedule request retirement when submission idles

2019-11-19 Thread Tvrtko Ursulin
On 19/11/2019 16:20, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-11-19 15:04:46) On 18/11/2019 23:02, Chris Wilson wrote: diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index 33ce258d484f..f7c8fec436a9 100644 --- a/drivers/gpu/drm/i915/gt/intel_lr

Re: [Intel-gfx] [PATCH 0/3] drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT

2019-11-19 Thread Andy Shevchenko
On Tue, Nov 19, 2019 at 04:18:15PM +0100, Hans de Goede wrote: > Hi All, > > This series needs to be merged through a single tree, to keep things > bisectable. I have even considered just squashing all 3 patches into 1, > but having separate commits seems better, but that does lead to an > interme

[Intel-gfx] [CI 1/2] drm/i915/gt: Move new timelines to the end of active_list

2019-11-19 Thread Chris Wilson
When adding a new active timeline, place it at the end of the list. This allows for intel_gt_retire_requests() to pick up the newcomer more quickly and hopefully complete the retirement sooner. A miniscule optimisation. References: 7936a22dd466 ("drm/i915/gt: Wait for new requests in intel_gt_ret

[Intel-gfx] [CI 2/2] drm/i915/gt: Schedule next retirement worker first

2019-11-19 Thread Chris Wilson
As we may park the gt during request retirement, we may then cancel the retirement worker only to then program the delayed worker once more. If we schedule the next delayed retirement worker first, if we then park the gt, the work remain cancelled [until we unpark]. Signed-off-by: Chris Wilson R

Re: [Intel-gfx] [PATCH 01/17] drm/i915/gem: Manually dump the debug trace on GEM_BUG_ON

2019-11-19 Thread Mika Kuoppala
Chris Wilson writes: > Since igt now defaults to not enabling ftrace-on-oops, we need to > manually invoke GEM_TRACE_DUMP() to see the debug log prior to a > GEM_BUG_ON panicking. > > Signed-off-by: Chris Wilson Acked-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_gem.h | 3 +++ > 1 fil

Re: [Intel-gfx] [PATCH 06/19] drm/i915/gt: Schedule request retirement when submission idles

2019-11-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-19 15:04:46) > > On 18/11/2019 23:02, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c > > b/drivers/gpu/drm/i915/gt/intel_lrc.c > > index 33ce258d484f..f7c8fec436a9 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > > +++ b/drivers/gpu/

Re: [Intel-gfx] [PATCH 11/19] drm/i915: Wait until the intel_wakeref idle callback is complete

2019-11-19 Thread Tvrtko Ursulin
On 18/11/2019 23:02, Chris Wilson wrote: When waiting for idle, serialise with any ongoing callback so that it will have completed before completing the wait. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_wakeref.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Wait until the intel_wakeref idle callback is complete

2019-11-19 Thread Mika Kuoppala
Chris Wilson writes: > When waiting for idle, serialise with any ongoing callback so that it > will have completed before completing the wait. Might be come apparent and evident when reading the patch that introduce the intel_wakeref_unlock_wait(), but reader is yearning for a why part. The 'wa

Re: [Intel-gfx] [PATCH 15/19] drm/i915/gt: Flush the requests after wedging on suspend

2019-11-19 Thread Tvrtko Ursulin
On 18/11/2019 23:02, Chris Wilson wrote: Retire all requests if we resort to wedged the driver on suspend. They will now be idle, so we might as we free them before shutting down. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 1 + 1 file changed, 1 insertion(+) di

Re: [Intel-gfx] [PATCH 07/19] drm/i915: Mark up the calling context for intel_wakeref_put()

2019-11-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-19 15:57:24) > > On 18/11/2019 23:02, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c > > b/drivers/gpu/drm/i915/gt/intel_lrc.c > > index f7c8fec436a9..fec46afb9264 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > > +++ b/drivers/gpu/

Re: [Intel-gfx] [PATCH 14/19] drm/i915/gt: Schedule next retirement worker first

2019-11-19 Thread Tvrtko Ursulin
On 18/11/2019 23:02, Chris Wilson wrote: As we may park the gt during request retirement, we may then cancel the retirement worker only to then program the delayed worker once more. If we schedule the next delayed retirement worker first, if we then park the gt, the work remain cancelled [until

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: make pool objects read-only

2019-11-19 Thread Patchwork
== Series Details == Series: drm/i915: make pool objects read-only URL : https://patchwork.freedesktop.org/series/69684/ State : success == Summary == CI Bug Log - changes from CI_DRM_7371 -> Patchwork_15330 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 13/19] drm/i915/gt: Move new timelines to the end of active_list

2019-11-19 Thread Tvrtko Ursulin
On 18/11/2019 23:02, Chris Wilson wrote: When adding a new active timeline, place it at the end of the list. This allows for intel_gt_retire_requests() to pick up the newcomer more quickly and hopefully complete the retirement sooner. References: 7936a22dd466 ("drm/i915/gt: Wait for new request

Re: [Intel-gfx] [PATCH 12/19] drm/i915/gt: Declare timeline.lock to be irq-free

2019-11-19 Thread Tvrtko Ursulin
On 18/11/2019 23:02, Chris Wilson wrote: Now that we never allow the intel_wakeref callbacks to be invoked from interrupt context, we do not need the irqsafe spinlock for the timeline. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_gt_requests.c | 9 - drivers/gpu/dr

Re: [Intel-gfx] [PATCH 07/19] drm/i915: Mark up the calling context for intel_wakeref_put()

2019-11-19 Thread Tvrtko Ursulin
On 18/11/2019 23:02, Chris Wilson wrote: Previously, we assumed we could use mutex_trylock() within an atomic context, falling back to a working if contended. However, such trickery is illegal inside interrupt context, and so we need to always use a worker under such circumstances. As we normall

Re: [Intel-gfx] [PATCH] drm/i915/dsi: Do not read the transcoder register.

2019-11-19 Thread Jani Nikula
On Tue, 19 Nov 2019, Vandita Kulkarni wrote: > As per the Bspec, port mapping is fixed for mipi dsi. > > v2: Reuse the existing function (Jani) > > Signed-off-by: Vandita Kulkarni Pushed, thanks for the patch. BR, Jani. > --- > drivers/gpu/drm/i915/display/intel_display.c | 17 +++

[Intel-gfx] [CI] drm/i915/selftests: Exercise rc6 w/a handling

2019-11-19 Thread Chris Wilson
Reading from CTX_INFO upsets rc6, requiring us to detect and prevent possible rc6 context corruption. Poke at the bear! Signed-off-by: Chris Wilson Cc: Imre Deak Cc: Mika Kuoppala Reviewed-by: Andi Shyti Tested-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_rc6.c | 4 + drivers

Re: [Intel-gfx] [PATCH 3/3] drm/i915: DSI: select correct PWM controller to use based on the VBT

2019-11-19 Thread Ville Syrjälä
On Tue, Nov 19, 2019 at 04:18:18PM +0100, Hans de Goede wrote: > At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 > different PWM controllers for controlling the LCD's backlight brightness. > Either the one integrated into the PMIC or the one integrated into the > SoC (the 1st

Re: [Intel-gfx] [PATCH 0/3] drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT

2019-11-19 Thread Jani Nikula
On Tue, 19 Nov 2019, Hans de Goede wrote: > Hi All, > > This series needs to be merged through a single tree, to keep things > bisectable. I have even considered just squashing all 3 patches into 1, > but having separate commits seems better, but that does lead to an > intermediate state where the

Re: [Intel-gfx] linux-next: Tree for Nov 19 (i915)

2019-11-19 Thread Randy Dunlap
On 11/19/19 12:46 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20191118: on x86_64: ERROR: "pm_suspend_target_state" [drivers/gpu/drm/i915/i915.ko] undefined! # CONFIG_SUSPEND is not set -- ~Randy Reported-by: Randy Dunlap ___ Intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/gt: Schedule request retirement when submission idles

2019-11-19 Thread kbuild test robot
also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-gt-Schedule-request-retirement-when-submission-idles/20191119-023819 b

Re: [Intel-gfx] [PATCH 17/17] drm/i915/selftests: Exercise rc6 handling

2019-11-19 Thread Chris Wilson
Quoting Andi Shyti (2019-11-19 15:24:59) > Hi Chris, > > On Tue, Nov 19, 2019 at 10:09:29AM +, Chris Wilson wrote: > > Reading from CTX_INFO upsets rc6, requiring us to detect and prevent > > possible rc6 context corruption. Poke at the bear! > > > > Signed-off-by: Chris Wilson > > Cc: Imre

Re: [Intel-gfx] [PATCH 17/17] drm/i915/selftests: Exercise rc6 handling

2019-11-19 Thread Andi Shyti
Hi Chris, On Tue, Nov 19, 2019 at 10:09:29AM +, Chris Wilson wrote: > Reading from CTX_INFO upsets rc6, requiring us to detect and prevent > possible rc6 context corruption. Poke at the bear! > > Signed-off-by: Chris Wilson > Cc: Imre Deak > Cc: Mika Kuoppala it looks good, Reviewed-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Cleanups around .crtc_enable/disable() (rev4)

2019-11-19 Thread Patchwork
== Series Details == Series: drm/i915: Cleanups around .crtc_enable/disable() (rev4) URL : https://patchwork.freedesktop.org/series/69352/ State : success == Summary == CI Bug Log - changes from CI_DRM_7371 -> Patchwork_15329 Summary --

[Intel-gfx] [PATCH 3/3] drm/i915: DSI: select correct PWM controller to use based on the VBT

2019-11-19 Thread Hans de Goede
At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 different PWM controllers for controlling the LCD's backlight brightness. Either the one integrated into the PMIC or the one integrated into the SoC (the 1st LPSS PWM controller). So far in the LPSS code on BYT we have skipped

[Intel-gfx] [PATCH 0/3] drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT

2019-11-19 Thread Hans de Goede
Hi All, This series needs to be merged through a single tree, to keep things bisectable. I have even considered just squashing all 3 patches into 1, but having separate commits seems better, but that does lead to an intermediate state where the backlight sysfs interface will be broken (and fixed 2

[Intel-gfx] [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-11-19 Thread Hans de Goede
At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 different PWM controllers for controlling the LCD's backlight brightness. Either the one integrated into the PMIC or the one integrated into the SoC (the 1st LPSS PWM controller). So far in the LPSS code on BYT we have skipped

[Intel-gfx] [PATCH 1/3] ACPI / LPSS: Rename pwm_backlight pwm-lookup to pwm_soc_backlight

2019-11-19 Thread Hans de Goede
At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 different PWM controllers for controlling the LCD's backlight brightness. Either the one integrated into the PMIC or the one integrated into the SoC (the 1st LPSS PWM controller). So far in the LPSS code on BYT we have skipped

Re: [Intel-gfx] [PATCH] drm/i915: make pool objects read-only

2019-11-19 Thread Chris Wilson
Quoting Matthew Auld (2019-11-19 15:01:54) > For our current users we don't expect pool objects to be writable from > the gpu. > Fixes: 4f7af1948abc ("drm/i915: Support ro ppgtt mapped cmdparser shadow buffers") > Signed-off-by: Matthew Auld > Cc: Chris Wilson Reviewed-by: Chris Wilson -Chris

Re: [Intel-gfx] [PATCH 06/19] drm/i915/gt: Schedule request retirement when submission idles

2019-11-19 Thread Tvrtko Ursulin
On 18/11/2019 23:02, Chris Wilson wrote: The major drawback of commit 7e34f4e4aad3 ("drm/i915/gen8+: Add RC6 CTX corruption WA") is that it disables RC6 while Skylake (and friends) is active, and we do not consider the GPU idle until all outstanding requests have been retired and the engine swit

[Intel-gfx] [PATCH] drm/i915/gt: Unlock engine-pm after queuing the kernel context switch

2019-11-19 Thread Chris Wilson
In commit a79ca656b648 ("drm/i915: Push the wakeref->count deferral to the backend"), I erroneously concluded that we last modify the engine inside __i915_request_commit() meaning that we could enable concurrent submission for userspace as we enqueued this request. However, this falls into a trap w

[Intel-gfx] [PATCH] drm/i915: make pool objects read-only

2019-11-19 Thread Matthew Auld
For our current users we don't expect pool objects to be writable from the gpu. Signed-off-by: Matthew Auld Cc: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_engine_pool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_pool.c b/drivers/gpu/drm/i915/

[Intel-gfx] ✓ Fi.CI.BAT: success for i915/gem_mmap_gtt: Exercise many, many mappings of the same objects

2019-11-19 Thread Patchwork
== Series Details == Series: i915/gem_mmap_gtt: Exercise many, many mappings of the same objects URL : https://patchwork.freedesktop.org/series/69678/ State : success == Summary == CI Bug Log - changes from CI_DRM_7371 -> IGTPW_3727 Summary

Re: [Intel-gfx] [PATCH] drm/i915/gem: Track ggtt writes from userspace on the bound vma

2019-11-19 Thread Mika Kuoppala
Chris Wilson writes: > When userspace writes into the GTT itself, it is supposed to call > set-domain to let the kernel keep track and so manage the CPU/GPU > caches. As we track writes on the individual i915_vma, we should also be > sure to mark them as dirty. > > Signed-off-by: Chris Wilson >

Re: [Intel-gfx] [PATCH 05/19] drm/i915/gt: Make intel_ring_unpin() safe for concurrent pint

2019-11-19 Thread Tvrtko Ursulin
On 18/11/2019 23:02, Chris Wilson wrote: In order to avoid some nasty mutex inversions, commit 09c5ab384f6f ("drm/i915: Keep rings pinned while the context is active") allowed the intel_ring unpinning to be run concurrently with the next context pinning it. Thus each step in intel_ring_unpin() n

Re: [Intel-gfx] [PATCH 04/19] drm/i915/gt: Unlock engine-pm after queuing the kernel context switch

2019-11-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-19 14:35:04) > > On 18/11/2019 23:02, Chris Wilson wrote: > > In commit a79ca656b648 ("drm/i915: Push the wakeref->count deferral to > > the backend"), I erroneously concluded that we last modify the engine > > inside __i915_request_commit() meaning that we could en

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/17] drm/i915/gem: Manually dump the debug trace on GEM_BUG_ON

2019-11-19 Thread Patchwork
== Series Details == Series: series starting with [01/17] drm/i915/gem: Manually dump the debug trace on GEM_BUG_ON URL : https://patchwork.freedesktop.org/series/69669/ State : success == Summary == CI Bug Log - changes from CI_DRM_7370_full -> Patchwork_15325_full ==

[Intel-gfx] ✗ GitLab.Pipeline: warning for i915/gem_mmap_gtt: Exercise many, many mappings of the same objects

2019-11-19 Thread Patchwork
== Series Details == Series: i915/gem_mmap_gtt: Exercise many, many mappings of the same objects URL : https://patchwork.freedesktop.org/series/69678/ State : warning == Summary == Did not get list of undocumented tests for this run, something is wrong! Other than that, pipeline status: FAILE

Re: [Intel-gfx] [PATCH 03/19] drm/i915/gt: Close race between engine_park and intel_gt_retire_requests

2019-11-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-19 14:15:49) > > On 18/11/2019 23:02, Chris Wilson wrote: > > The general concept was that intel_timeline.active_count was locked by > > the intel_timeline.mutex. The exception was for power management, where > > the engine->kernel_context->timeline could be manipul

Re: [Intel-gfx] [PATCH 04/19] drm/i915/gt: Unlock engine-pm after queuing the kernel context switch

2019-11-19 Thread Tvrtko Ursulin
On 18/11/2019 23:02, Chris Wilson wrote: In commit a79ca656b648 ("drm/i915: Push the wakeref->count deferral to the backend"), I erroneously concluded that we last modify the engine inside __i915_request_commit() meaning that we could enable concurrent submission for userspace as we enqueued thi

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Cleanups around .crtc_enable/disable() (rev3)

2019-11-19 Thread Ville Syrjälä
On Mon, Nov 18, 2019 at 08:00:07PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Cleanups around .crtc_enable/disable() (rev3) > URL : https://patchwork.freedesktop.org/series/69352/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7365 -> Patchwo

[Intel-gfx] [PATCH i-g-t] i915/gem_mmap_gtt: Exercise many, many mappings of the same objects

2019-11-19 Thread Chris Wilson
Fork and remap the same object into a new process space under a new file descriptor. Principally to check list management and find scaling issues in using such lists. Signed-off-by: Chris Wilson Cc: Abdiel Janulgue --- tests/i915/gem_mmap_gtt.c | 72 ++- 1 fi

Re: [Intel-gfx] [PATCH 03/19] drm/i915/gt: Close race between engine_park and intel_gt_retire_requests

2019-11-19 Thread Tvrtko Ursulin
On 18/11/2019 23:02, Chris Wilson wrote: The general concept was that intel_timeline.active_count was locked by the intel_timeline.mutex. The exception was for power management, where the engine->kernel_context->timeline could be manipulated under the global wakeref.mutex. This was quite solid,

Re: [Intel-gfx] [PATCH V13 4/6] mdev: introduce mediated virtio bus

2019-11-19 Thread Jason Gunthorpe
On Tue, Nov 19, 2019 at 10:02:08PM +0800, Jason Wang wrote: > > On 2019/11/19 下午8:38, Jason Gunthorpe wrote: > > On Tue, Nov 19, 2019 at 10:41:31AM +0800, Jason Wang wrote: > > > On 2019/11/19 上午4:28, Jason Gunthorpe wrote: > > > > On Mon, Nov 18, 2019 at 03:27:13PM -0500, Michael S. Tsirkin wrote

Re: [Intel-gfx] [PATCH V13 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-19 Thread Jason Wang
On 2019/11/19 下午8:40, Jason Gunthorpe wrote: On Tue, Nov 19, 2019 at 11:03:39AM +0800, Jason Wang wrote: Also, see the other conversations we are having about a "virtual" bus and devices. I do not want to have two different ways of doing the same thing in the kernel at the same time please. P

Re: [Intel-gfx] [PATCH V13 4/6] mdev: introduce mediated virtio bus

2019-11-19 Thread Jason Wang
On 2019/11/19 下午8:38, Jason Gunthorpe wrote: On Tue, Nov 19, 2019 at 10:41:31AM +0800, Jason Wang wrote: On 2019/11/19 上午4:28, Jason Gunthorpe wrote: On Mon, Nov 18, 2019 at 03:27:13PM -0500, Michael S. Tsirkin wrote: On Mon, Nov 18, 2019 at 01:41:00PM +, Jason Gunthorpe wrote: On Mon, N

  1   2   >