[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Check we are the Ironlake IPS provider before deregistering

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Check we are the Ironlake IPS provider before deregistering URL : https://patchwork.freedesktop.org/series/70700/ State : success == Summary == CI Bug Log - changes from CI_DRM_7534_full -> Patchwork_15674_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add lmem fault handler (rev2)

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Add lmem fault handler (rev2) URL : https://patchwork.freedesktop.org/series/70485/ State : warning == Summary == $ dim checkpatch origin/drm-tip 391e63451f37 drm/i915: Add lmem fault handler -:151: WARNING:LEADING_SPACE: please, no spaces at the start

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v2,01/11] drm: Add __drm_atomic_helper_crtc_state_reset() & co.

2019-12-10 Thread Patchwork
== Series Details == Series: series starting with [v2,01/11] drm: Add __drm_atomic_helper_crtc_state_reset() & co. URL : https://patchwork.freedesktop.org/series/70730/ State : failure == Summary == Applying: drm: Add __drm_atomic_helper_crtc_state_reset() & co. Applying: drm/i915:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: timeline semaphore support

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915: timeline semaphore support URL : https://patchwork.freedesktop.org/series/70728/ State : success == Summary == CI Bug Log - changes from CI_DRM_7534 -> Patchwork_15683 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH] drm/i915/display: cleanup intel_bw_state on i915 module removal

2019-12-10 Thread Bharadiya,Pankaj
On Tue, Dec 10, 2019 at 09:57:39PM -0800, Lucas De Marchi wrote: > On Mon, Dec 09, 2019 at 08:09:02PM +0530, Pankaj Bharadiya wrote: > >intel_bw_state allocated memory is not getting freed even after > >module removal. > > > >kmemleak reported backtrace: > > > > [<79019739>]

Re: [Intel-gfx] [PATCH 04/10] drm/i915: add display engine uncore helpers

2019-12-10 Thread Jani Nikula
On Tue, 10 Dec 2019, Joonas Lahtinen wrote: > Quoting Jani Nikula (2019-12-02 18:00:52) >> Add convenience helpers for the most common uncore operations with >> struct drm_i915_private * as context rather than struct intel_uncore *. >> >> The goal is to replace all instances of I915_READ(), >>

Re: [Intel-gfx] [v4.1 16/16] drm/i915/dsi: add support for DSC

2019-12-10 Thread Jani Nikula
On Wed, 11 Dec 2019, "Kulkarni, Vandita" wrote: >> -Original Message- >> From: Jani Nikula >> Sent: Tuesday, December 10, 2019 4:21 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Kulkarni, Vandita ; >> ville.syrj...@linux.intel.com; Nikula, Jani >> Subject: [v4.1 16/16] drm/i915/dsi:

Re: [Intel-gfx] [v4.1 08/16] drm/i915/dsc: add basic hardware state readout support

2019-12-10 Thread Jani Nikula
On Tue, 10 Dec 2019, Manasi Navare wrote: > On Tue, Dec 10, 2019 at 12:50:52PM +0200, Jani Nikula wrote: >> Add basic hardware state readout for DSC, and check the most relevant >> details in the state checker. >> >> v2: >> - check for DSC power before reading its state >> - check if source

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: timeline semaphore support

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915: timeline semaphore support URL : https://patchwork.freedesktop.org/series/70728/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0a6c609da1ff drm/i915: introduce a mechanism to extend execbuf2 -:141: CHECK:SPACING: spaces preferred around

[Intel-gfx] ✗ Fi.CI.BAT: failure for DRM and i915 fixes to handle hotplug/unplug for 8K tiled displays

2019-12-10 Thread Patchwork
== Series Details == Series: DRM and i915 fixes to handle hotplug/unplug for 8K tiled displays URL : https://patchwork.freedesktop.org/series/70722/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7534 -> Patchwork_15682

[Intel-gfx] [PATCH] drm/i915: Add lmem fault handler

2019-12-10 Thread Abdiel Janulgue
Fault handler to handle missing pages for lmem objects. v2: Handle ENXIO in fault error, account for offset in region start for fake lmem (Matt). Add selftest (Chris). Signed-off-by: Abdiel Janulgue Signed-off-by: Matthew Auld Cc: Chris Wilson Cc: Joonas Lahtinen ---

Re: [Intel-gfx] [v4.1 16/16] drm/i915/dsi: add support for DSC

2019-12-10 Thread Kulkarni, Vandita
> -Original Message- > From: Jani Nikula > Sent: Tuesday, December 10, 2019 4:21 PM > To: intel-gfx@lists.freedesktop.org > Cc: Kulkarni, Vandita ; > ville.syrj...@linux.intel.com; Nikula, Jani > Subject: [v4.1 16/16] drm/i915/dsi: add support for DSC > > Enable DSC for DSI, if

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DRM and i915 fixes to handle hotplug/unplug for 8K tiled displays

2019-12-10 Thread Patchwork
== Series Details == Series: DRM and i915 fixes to handle hotplug/unplug for 8K tiled displays URL : https://patchwork.freedesktop.org/series/70722/ State : warning == Summary == $ dim checkpatch origin/drm-tip e95624b467dd drm: Handle connector tile support only for modes that match tile

Re: [Intel-gfx] [PATCH] drm/i915/display: cleanup intel_bw_state on i915 module removal

2019-12-10 Thread Lucas De Marchi
On Mon, Dec 09, 2019 at 08:09:02PM +0530, Pankaj Bharadiya wrote: intel_bw_state allocated memory is not getting freed even after module removal. kmemleak reported backtrace: [<79019739>] kmemdup+0x17/0x40 [] intel_bw_duplicate_state+0x1b/0x40 [i915]

[Intel-gfx] ✓ Fi.CI.BAT: success for Simplify GuC communication handling

2019-12-10 Thread Patchwork
== Series Details == Series: Simplify GuC communication handling URL : https://patchwork.freedesktop.org/series/70717/ State : success == Summary == CI Bug Log - changes from CI_DRM_7534 -> Patchwork_15681 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: remove redundant checks for a null fb pointer

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915: remove redundant checks for a null fb pointer URL : https://patchwork.freedesktop.org/series/70693/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7533_full -> Patchwork_15670_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Simplify GuC communication handling

2019-12-10 Thread Patchwork
== Series Details == Series: Simplify GuC communication handling URL : https://patchwork.freedesktop.org/series/70717/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3f4d1cd323a6 drm/i915/guc: Merge communication_stop and communication_disable 6a2cdf54548f drm/i915/guc/ct: stop

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add ops to intel_uc

2019-12-10 Thread Patchwork
== Series Details == Series: Add ops to intel_uc URL : https://patchwork.freedesktop.org/series/70716/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7534 -> Patchwork_15680 Summary --- **FAILURE** Serious unknown

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add ops to intel_uc

2019-12-10 Thread Patchwork
== Series Details == Series: Add ops to intel_uc URL : https://patchwork.freedesktop.org/series/70716/ State : warning == Summary == $ dim checkpatch origin/drm-tip 954921ae8651 drm/i915/uc: Add ops to intel_uc -:27: WARNING:AVOID_EXTERNS: externs should be avoided in .c files #27: FILE:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Disable manual rc6 for Braswell/Baytrail

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Disable manual rc6 for Braswell/Baytrail URL : https://patchwork.freedesktop.org/series/70706/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7534 -> Patchwork_15678 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/userptr: Try to acquire the page lock around set_page_dirty() (rev2)

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/userptr: Try to acquire the page lock around set_page_dirty() (rev2) URL : https://patchwork.freedesktop.org/series/69037/ State : failure == Summary == Applying: drm/i915/userptr: Try to acquire the page lock around set_page_dirty() error: sha1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Improve execbuf debug (rev3)

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Improve execbuf debug (rev3) URL : https://patchwork.freedesktop.org/series/70625/ State : success == Summary == CI Bug Log - changes from CI_DRM_7534 -> Patchwork_15677 Summary --- **SUCCESS**

[Intel-gfx] [PATCH v3] drm/i915/uc: More useful FW version mis-match notice

2019-12-10 Thread John . C . Harrison
From: John Harrison If a FW override is present then a version mis-match is actually ignored. The warning notice was still being printed, though. Which could confuse people by implying that the load had failed when it had actually succeeded. So add an extra tag to the notice to say whether the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add DPCD quirk for AUO PSR2 panel

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Add DPCD quirk for AUO PSR2 panel URL : https://patchwork.freedesktop.org/series/70702/ State : success == Summary == CI Bug Log - changes from CI_DRM_7534 -> Patchwork_15676 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/execbuf: Add support for parallel execbuf submission. (rev2)

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/execbuf: Add support for parallel execbuf submission. (rev2) URL : https://patchwork.freedesktop.org/series/70680/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Check we are the Ironlake IPS provider before deregistering

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Check we are the Ironlake IPS provider before deregistering URL : https://patchwork.freedesktop.org/series/70700/ State : success == Summary == CI Bug Log - changes from CI_DRM_7534 -> Patchwork_15674

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Show the i915_active on failure

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Show the i915_active on failure URL : https://patchwork.freedesktop.org/series/70683/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7532_full -> Patchwork_15666_full Summary

[Intel-gfx] [PATCH v2 06/11] drm/i915/display: Share intel_connector_needs_modeset()

2019-12-10 Thread José Roberto de Souza
intel_connector_needs_modeset() will be used outside of intel_display.c in a future patch so it would only be necessary to remove the state and add the prototype to the header file. But while at it, I simplified the arguments and changed to intel types and moved it to a better place

[Intel-gfx] [PATCH v2 04/11] drm/i915: Introduce intel_crtc_state_reset()

2019-12-10 Thread José Roberto de Souza
From: Ville Syrjälä We have a few places where we want to reset a crtc state to its default values. Let's add a helper for that. We'll need the new __drm_atomic_helper_crtc_state_reset() helper for this to allow us to just reset the state itself without clobbering the crtc->state pointer. And

[Intel-gfx] [PATCH v2 07/11] drm/i915/tgl: Select master transcoder for MST stream

2019-12-10 Thread José Roberto de Souza
On TGL the blending of all the streams have moved from DDI to transcoder, so now every transcoder working over the same MST port must send its stream to a master transcoder and master will send to DDI respecting the time slots. So here adding all the CRTCs that shares the same MST stream if

[Intel-gfx] [PATCH v2 11/11] drm/i915/display: Add comment to a function that probably can be removed

2019-12-10 Thread José Roberto de Souza
This function is only called from port sync and it is identical to what will be executed again in intel_update_crtc() over port sync pipes. If it is really necessary it at least deserves a better name and a comment, leaving it to people working on port sync. Cc: Ville Syrjälä Cc: Maarten

[Intel-gfx] [PATCH v2 03/11] drm/i915: Introduce intel_crtc_{alloc, free}()

2019-12-10 Thread José Roberto de Souza
From: Ville Syrjälä We already have alloc/free helpers for planes, add the same for crtcs. The main benefit is we get to move all the annoying state initialization out of the main crtc_init() flow. Reviewed-by: José Roberto de Souza Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 08/11] drm/i915/display: Always enables MST master pipe first

2019-12-10 Thread José Roberto de Souza
Due to DDB overlaps the pipe enabling sequence is not always crescent. As the previous patch selects the smallest pipe/transcoder in the MST stream to be master and it needs to be enabled first this changes were needed to guarantee that. So first lets enable all pipes that did not needed a

[Intel-gfx] [PATCH v2 10/11] drm/i915/display: Check if pipe fastset is allowed by external dependencies

2019-12-10 Thread José Roberto de Souza
Check if fastset is allowed by external dependencies like other pipes and transcoders. Right now it only forces a fullmodeset when the MST master transcoder did not changed but the pipe of the master transcoder needs a fullmodeset so all slaves also needs to do a fullmodeset. But it will probably

[Intel-gfx] [PATCH v2 01/11] drm: Add __drm_atomic_helper_crtc_state_reset() & co.

2019-12-10 Thread José Roberto de Souza
From: Ville Syrjälä Annoyingly __drm_atomic_helper_crtc_reset() does two totally separate things: a) reset the state to defaults values b) assign the crtc->state pointer I just want a) without the b) so let's split out part a) into __drm_atomic_helper_crtc_state_reset(). And of course we'll do

[Intel-gfx] [PATCH v2 09/11] drm/i915/dp: Fix MST disable sequences

2019-12-10 Thread José Roberto de Souza
The disable sequence after wait for transcoder off was not correctly implemented. The MST disable sequence is basically the same for HSW, SKL, ICL and TGL, with just minor changes for TGL. So here calling a new MST function to do the MST sequences, most of the steps just moved from the post

[Intel-gfx] [PATCH v2 05/11] drm/i915: Introduce intel_plane_state_reset()

2019-12-10 Thread José Roberto de Souza
From: Ville Syrjälä For the sake of symmetry with the crtc stuff let's add a helper to reset the plane state to sane default values. For the moment this only gets caller from the plane init. Reviewed-by: José Roberto de Souza Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 02/11] drm/i915: s/intel_crtc/crtc/ in intel_crtc_init()

2019-12-10 Thread José Roberto de Souza
From: Ville Syrjälä Let's get rid of the redundant intel_ prefix on our variables. Reviewed-by: José Roberto de Souza Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 32 ++-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git

Re: [Intel-gfx] [PATCH 3/4] drm/i915/dp: Fix MST disable sequences

2019-12-10 Thread Souza, Jose
On Tue, 2019-12-10 at 16:30 -0800, James Ausmus wrote: > On Tue, Dec 10, 2019 at 11:38:50PM +0200, Ville Syrjälä wrote: > > On Fri, Dec 06, 2019 at 05:18:31PM -0800, José Roberto de Souza > > wrote: > > > The disable sequence after wait for transcoder off was not > > > correctly > > > implemented.

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: Check we are the Ironlake IPS provider before deregistering

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Check we are the Ironlake IPS provider before deregistering URL : https://patchwork.freedesktop.org/series/70700/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/gt: Check we are the Ironlake IPS

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Copy across scheduler behaviour flags across submit fences (rev5)

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Copy across scheduler behaviour flags across submit fences (rev5) URL : https://patchwork.freedesktop.org/series/70107/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7534 -> Patchwork_15673

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dsi: enable DSC (rev7)

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/dsi: enable DSC (rev7) URL : https://patchwork.freedesktop.org/series/69540/ State : success == Summary == CI Bug Log - changes from CI_DRM_7532_full -> Patchwork_15665_full Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Some cleanup near the SKL wm/ddb area (rev3)

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Some cleanup near the SKL wm/ddb area (rev3) URL : https://patchwork.freedesktop.org/series/67930/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7533 -> Patchwork_15672 Summary

Re: [Intel-gfx] [PATCH] drm/i915: Add DPCD quirk for AUO PSR2 panel

2019-12-10 Thread kbuild test robot
Hi Gaurav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip linus/master v5.5-rc1 next-20191210] [if your patch is applied to the wrong git tree, please drop us a note to help improve

Re: [Intel-gfx] [PATCH 3/4] drm/i915/dp: Fix MST disable sequences

2019-12-10 Thread James Ausmus
On Tue, Dec 10, 2019 at 11:38:50PM +0200, Ville Syrjälä wrote: > On Fri, Dec 06, 2019 at 05:18:31PM -0800, José Roberto de Souza wrote: > > The disable sequence after wait for transcoder off was not correctly > > implemented. > > The MST disable sequence is basically the same for HSW, SKL, ICL and

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-12-10 Thread Linus Walleij
On Mon, Dec 2, 2019 at 4:49 PM Hans de Goede wrote: > There is only one problem, currently is is not possible to > unregister a mapping added with pinctrl_register_mappings > and the i915 driver is typically a module which can be unloaded > and I believe actually is unloaded as part of the i915

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: remove duplicated assignment to pointer crtc_state

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/display: remove duplicated assignment to pointer crtc_state URL : https://patchwork.freedesktop.org/series/70695/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7533 -> Patchwork_15671

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: remove redundant checks for a null fb pointer

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915: remove redundant checks for a null fb pointer URL : https://patchwork.freedesktop.org/series/70693/ State : success == Summary == CI Bug Log - changes from CI_DRM_7533 -> Patchwork_15670 Summary

[Intel-gfx] [PATCH v6 2/3] drm/i915: add syncobj timeline support

2019-12-10 Thread Lionel Landwerlin
Introduces a new parameters to execbuf so that we can specify syncobj handles as well as timeline points. v2: Reuse i915_user_extension_fn v3: Check that the chained extension is only present once (Chris) v4: Check that dma_fence_chain_find_seqno returns a non NULL fence (Lionel) v5: Use

[Intel-gfx] [PATCH v6 1/3] drm/i915: introduce a mechanism to extend execbuf2

2019-12-10 Thread Lionel Landwerlin
We're planning to use this for a couple of new feature where we need to provide additional parameters to execbuf. v2: Check for invalid flags in execbuffer2 (Lionel) v3: Rename I915_EXEC_EXT -> I915_EXEC_USE_EXTENSIONS (Chris) Signed-off-by: Lionel Landwerlin Reviewed-by: Chris Wilson (v1)

[Intel-gfx] [PATCH v6 0/3] drm/i915: timeline semaphore support

2019-12-10 Thread Lionel Landwerlin
Hi all, Following the last set of IGT tests on the mailing list, Chris made an interesting comment about engine to engine synchronization. Indeed with dma-fence-chain, i915 is unable to detect i915 fences given as wait dependencies to the execbuf, because those are now wrapped into a

[Intel-gfx] [PATCH v6 3/3] drm/i915: peel dma-fence-chains wait fences

2019-12-10 Thread Lionel Landwerlin
To allow faster engine to engine synchronization, peel the layer of dma-fence-chain to expose potential i915 fences so that the i915-request code can emit HW semaphore wait/signal operations in the ring which is faster than waking up the host to submit unblocked workloads after interrupt

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: fix uninitialized variable sum when summing up values

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix uninitialized variable sum when summing up values URL : https://patchwork.freedesktop.org/series/70689/ State : failure == Summary == Applying: drm/i915/selftests: fix uninitialized variable sum when summing up values Using index info to

Re: [Intel-gfx] [v4.1 08/16] drm/i915/dsc: add basic hardware state readout support

2019-12-10 Thread Manasi Navare
On Tue, Dec 10, 2019 at 12:50:52PM +0200, Jani Nikula wrote: > Add basic hardware state readout for DSC, and check the most relevant > details in the state checker. > > v2: > - check for DSC power before reading its state > - check if source supports DSC at all > > As a side effect, this should

Re: [Intel-gfx] [v4.1 07/16] drm/i915/dsc: make DSC source support helper generic

2019-12-10 Thread Manasi Navare
On Tue, Dec 10, 2019 at 12:50:51PM +0200, Jani Nikula wrote: > Move intel_dp_source_supports_dsc() from intel_dp.c as > intel_dsc_source_support() in intel_vdsc.c. The DSC source support is > more about DSC than about DP, and will be needed for DP independent > code. > > Cc: Manasi Navare > Cc:

[Intel-gfx] [PATCH 1/5] drm: Handle connector tile support only for modes that match tile size

2019-12-10 Thread Manasi Navare
DRM Fb driver expects multiple CRTCs if it sees connector->has_tile is set, but we need to handle tile support and look for multiple CRTCs only for the modes that match the tile size. The other modes should be able to be displayed without tile support or uisng single CRTC. This patch adds the

[Intel-gfx] [PATCH 3/5] drm/i915/dp: Make sure all tiled connectors get added to the state with full modeset

2019-12-10 Thread Manasi Navare
In case of tiled displays, all the tiles are linke dto each other for transcoder port sync. So in intel_atomic_check() we need to make sure that we add all the tiles to the modeset and if one of the tiles needs a full modeset then mark all other tiles for a full modeset. Suggested-by: Ville

[Intel-gfx] [PATCH 2/5] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-12-10 Thread Manasi Navare
In case of tiled displays, if we hotplug just one connector, fbcon currently just selects the preferred mode and if it is tiled mode then that becomes a problem if rest of the tiles are not present. So in the fbdev driver on hotplug when we probe the client modeset, if we dont find all the

[Intel-gfx] [PATCH 0/5] DRM and i915 fixes to handle hotplug/unplug for 8K tiled displays

2019-12-10 Thread Manasi Navare
With these patches now DRM and i915 gracefully handles hotplugging and unplugging of either the master or slave connectors in case of tiled displays. These patches ensure proper handling of just 1 tile connected and also fixes the teardown (disable sequence) Case1: Boot with single port

[Intel-gfx] [PATCH 4/5] drm/i915/dp: Make port sync mode assignments only if all tiles present

2019-12-10 Thread Manasi Navare
Add an extra check before making master slave assignments for tiled displays to make sure we make these assignments only if all tiled connectors are present. If not then initialize the state to defaults so it does a normal non tiled modeset without transcoder port sync. Bugzilla:

[Intel-gfx] [PATCH 5/5] drm/i915/dp: Disable Port sync mode correctly on teardown

2019-12-10 Thread Manasi Navare
While clearing the Ports ync mode enable and master select bits we need to make sure that we perform a RMW for disable else it sets the other bits casuing unwanted sideeffects. Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/5 Cc: Ville Syrjälä Cc: Jani Nikula Fixes: 51528afe7c5e

Re: [Intel-gfx] [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-10 Thread Daniel Vetter
On Tue, Dec 10, 2019 at 02:34:33PM +0200, Jani Nikula wrote: > On Tue, 10 Dec 2019, Jani Nikula wrote: > > Add new struct drm_device based logging macros modeled after the core > > kernel device based logging macros. These would be preferred over the > > drm printk and struct device based macros

Re: [Intel-gfx] [PATCH 3/4] drm/i915/dp: Fix MST disable sequences

2019-12-10 Thread Ville Syrjälä
On Fri, Dec 06, 2019 at 05:18:31PM -0800, José Roberto de Souza wrote: > The disable sequence after wait for transcoder off was not correctly > implemented. > The MST disable sequence is basically the same for HSW, SKL, ICL and > TGL, with just minor changes for TGL. > > So here calling a new MST

[Intel-gfx] [PATCH 1/5] drm/i915/guc: Merge communication_stop and communication_disable

2019-12-10 Thread Daniele Ceraolo Spurio
The only difference from the GuC POV between guc_communication_stop and guc_communication_disable is that the former can be called after GuC has been reset. Instead of having two separate paths, we can just skip the call into GuC in the disabling path and re-use that. Note that by using the

[Intel-gfx] [PATCH 3/5] drm/i915/guc: remove function pointers for send/receive calls

2019-12-10 Thread Daniele Ceraolo Spurio
Since we started using CT buffers on all gens, the function pointers can only be set to either the _nop() or the _ct() functions. Since the _nop() case applies to when the CT are disabled, we can just handle that case in the _ct() functions and call them directly. Signed-off-by: Daniele Ceraolo

[Intel-gfx] [PATCH 4/5] drm/i915/guc: unify notify() functions

2019-12-10 Thread Daniele Ceraolo Spurio
The Gen11+ and the legacy function differ in the register and value written to interrupt the GuC. However, while on older gen the value matches a bit on the register, on Gen11+ the value is a SW defined payload that is sent to the FW. Since the FW behaves the same no matter what value we pass to

[Intel-gfx] [PATCH 0/5] Simplify GuC communication handling

2019-12-10 Thread Daniele Ceraolo Spurio
Since H2G communication will be in the hot path of GuC submission, the main aim of this series is to get rid of the function pointers to speed things up and avoid retpolines (in case the compiler decides they're required). While at it, simplify the general communication enabling/disabling by

[Intel-gfx] [PATCH 2/5] drm/i915/guc/ct: stop expecting multiple CT channels

2019-12-10 Thread Daniele Ceraolo Spurio
The GuC supports having multiple CT buffer pairs and we designed our implementation with that in mind. However, the different channels are not processed in parallel within the GuC, so there is very little advantage in having multiple channels (independent locks?), compared to the drawbacks (one

[Intel-gfx] [PATCH 5/5] HAX: force enable_guc=2 and WA i915#571

2019-12-10 Thread Daniele Ceraolo Spurio
To get a full run with GuC loading and HuC auth enabled. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/selftest_gt_pm.c | 9 + drivers/gpu/drm/i915/i915_params.h | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [RFC 1/4] drm/i915/uc: Add ops to intel_uc

2019-12-10 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-12-10 21:02:30) > On Tue, 10 Dec 2019 21:55:13 +0100, Chris Wilson > wrote: > > > Quoting Michal Wajdeczko (2019-12-10 20:47:41) > >> @@ -628,3 +651,15 @@ int intel_uc_runtime_resume(struct intel_uc *uc) > >> */ > >> return __uc_resume(uc, true);

Re: [Intel-gfx] [RFC 1/4] drm/i915/uc: Add ops to intel_uc

2019-12-10 Thread Michal Wajdeczko
On Tue, 10 Dec 2019 21:55:13 +0100, Chris Wilson wrote: Quoting Michal Wajdeczko (2019-12-10 20:47:41) @@ -628,3 +651,15 @@ int intel_uc_runtime_resume(struct intel_uc *uc) */ return __uc_resume(uc, true); } + +const struct intel_uc_ops uc_ops_none = { +}; + +const struct

Re: [Intel-gfx] [RFC 4/4] drm/i915/uc: Add sanitize to to intel_uc_ops

2019-12-10 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-12-10 20:47:44) > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.h > b/drivers/gpu/drm/i915/gt/uc/intel_uc.h > index 2bd8326130f1..3410d35f8b0c 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.h > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.h > @@ -19,6 +19,7 @@

Re: [Intel-gfx] [RFC 1/4] drm/i915/uc: Add ops to intel_uc

2019-12-10 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-12-10 20:47:41) > @@ -628,3 +651,15 @@ int intel_uc_runtime_resume(struct intel_uc *uc) > */ > return __uc_resume(uc, true); > } > + > +const struct intel_uc_ops uc_ops_none = { > +}; > + > +const struct intel_uc_ops uc_ops_off = { > +

[Intel-gfx] [RFC 2/4] drm/i915/uc: Add init_fw/fini_fw to to intel_uc_ops

2019-12-10 Thread Michal Wajdeczko
Firmware fetching and cleanup steps are only meaningful if we are running with uC enabled. Make these functions part of the uc_ops. Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 12 ++--

[Intel-gfx] [RFC 3/4] drm/i915/uc: Add init/fini to to intel_uc_ops

2019-12-10 Thread Michal Wajdeczko
uC preparation and cleanup steps are only meaningful if we are running with uC enabled. Make these functions part of the uc_ops. Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 12 ++--

[Intel-gfx] [RFC 0/4] Add ops to intel_uc

2019-12-10 Thread Michal Wajdeczko
Instead of spreading multiple conditionals across the uC code to find out current mode of uC operation, start using predefined set of function pointers that reflect that mode. Michal Wajdeczko (4): drm/i915/uc: Add ops to intel_uc drm/i915/uc: Add init_fw/fini_fw to to intel_uc_ops

[Intel-gfx] [RFC 1/4] drm/i915/uc: Add ops to intel_uc

2019-12-10 Thread Michal Wajdeczko
Instead of spreading multiple conditionals across the uC code to find out current mode of uC operation, start using predefined set of function pointers that reflect that mode. Begin with pair of init_hw/fini_hw functions that are responsible for uC hardware initialization and cleanup.

[Intel-gfx] [RFC 4/4] drm/i915/uc: Add sanitize to to intel_uc_ops

2019-12-10 Thread Michal Wajdeczko
uC sanitization is only meaningful if we are running with uC present or enabled. Make this function part of the uc_ops. Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 10 ++

Re: [Intel-gfx] [RFC 2/4] drm/i915/uc: Add init_fw/fini_fw to to intel_uc_ops

2019-12-10 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-12-10 20:47:42) > const struct intel_uc_ops uc_ops_on = { > + .init_fw = __uc_fetch_firmwares, > + .fini_fw = __uc_cleanup_firmwares, Whitespace between the pairs, or fullname _firmware? > .init_hw = __uc_init_hw, > .fini_hw =

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Wait on unbind barriers when invalidating userptr

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/gem: Wait on unbind barriers when invalidating userptr URL : https://patchwork.freedesktop.org/series/70688/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7532 -> Patchwork_15668

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Pass cpu transcoder to assert_pipe()

2019-12-10 Thread Souza, Jose
On Tue, 2019-12-10 at 21:58 +0200, Ville Syrjälä wrote: > On Tue, Dec 10, 2019 at 06:23:36PM +, Souza, Jose wrote: > > On Tue, 2019-11-12 at 18:38 +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > In order to eliminate intel_pipe_to_cpu_transcoder() (and its > > >

Re: [Intel-gfx] [PATCH 3/4] drm/i915: ELiminate intel_pipe_to_cpu_transcoder() from assert_fdi_tx()

2019-12-10 Thread Souza, Jose
On Tue, 2019-12-10 at 21:55 +0200, Ville Syrjälä wrote: > On Tue, Dec 10, 2019 at 06:19:24PM +, Souza, Jose wrote: > > On Tue, 2019-11-12 at 18:38 +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Let's start to eliminate intel_pipe_to_cpu_transcoder() so that > > > we can

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Wait on unbind barriers when invalidating userptr

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/gem: Wait on unbind barriers when invalidating userptr URL : https://patchwork.freedesktop.org/series/70688/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8d48a1b7cd45 drm/i915/gem: Wait on unbind barriers when invalidating userptr -:10:

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Pass cpu transcoder to assert_pipe()

2019-12-10 Thread Ville Syrjälä
On Tue, Dec 10, 2019 at 06:23:36PM +, Souza, Jose wrote: > On Tue, 2019-11-12 at 18:38 +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > In order to eliminate intel_pipe_to_cpu_transcoder() (and its > > crtc->config usage) let's pass the cpu transcoder to > > assert_pipe() so we

Re: [Intel-gfx] [PATCH 3/4] drm/i915: ELiminate intel_pipe_to_cpu_transcoder() from assert_fdi_tx()

2019-12-10 Thread Ville Syrjälä
On Tue, Dec 10, 2019 at 06:19:24PM +, Souza, Jose wrote: > On Tue, 2019-11-12 at 18:38 +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Let's start to eliminate intel_pipe_to_cpu_transcoder() so that > > we can get rid of one more crtc->config usage (which we will want > > to nuke

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-10 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/print: introduce new struct drm_device based logging macros URL : https://patchwork.freedesktop.org/series/70685/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7532 -> Patchwork_15667

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-10 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/print: introduce new struct drm_device based logging macros URL : https://patchwork.freedesktop.org/series/70685/ State : warning == Summary == $ dim checkpatch origin/drm-tip e36a486e7bb8 drm/print: introduce new struct drm_device

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Show the i915_active on failure

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Show the i915_active on failure URL : https://patchwork.freedesktop.org/series/70683/ State : success == Summary == CI Bug Log - changes from CI_DRM_7532 -> Patchwork_15666 Summary ---

[Intel-gfx] [PATCH] drm/i915/userptr: Try to acquire the page lock around set_page_dirty()

2019-12-10 Thread fei . yang
From: Fei Yang This is a backport of cee7fb437edcdb2f9f8affa959e274997f5dca4d to linux-4.4.y set_page_dirty says: For pages with a mapping this should be done under the page lock for the benefit of asynchronous memory errors who prefer a consistent dirty state. This

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: enable DSC (rev7)

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/dsi: enable DSC (rev7) URL : https://patchwork.freedesktop.org/series/69540/ State : success == Summary == CI Bug Log - changes from CI_DRM_7532 -> Patchwork_15665 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Pass cpu transcoder to assert_pipe()

2019-12-10 Thread Souza, Jose
On Tue, 2019-11-12 at 18:38 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > In order to eliminate intel_pipe_to_cpu_transcoder() (and its > crtc->config usage) let's pass the cpu transcoder to > assert_pipe() so we don't have to do the pipe->cpu transcoder > lookup on HSW+. > > On VLV/CHV

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: enable DSC (rev7)

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915/dsi: enable DSC (rev7) URL : https://patchwork.freedesktop.org/series/69540/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6f76029d9c5d drm/i915/bios: pass devdata to parse_ddi_port 5f29128c3cd0 drm/i915/bios: parse compression parameters

Re: [Intel-gfx] [PATCH 3/4] drm/i915: ELiminate intel_pipe_to_cpu_transcoder() from assert_fdi_tx()

2019-12-10 Thread Souza, Jose
On Tue, 2019-11-12 at 18:38 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Let's start to eliminate intel_pipe_to_cpu_transcoder() so that > we can get rid of one more crtc->config usage (which we will want > to nuke as well). > > In the case of assert_fdi_tx() we know that we're never >

[Intel-gfx] [PATCH] drm/i915/gt: Disable manual rc6 for Braswell/Baytrail

2019-12-10 Thread Chris Wilson
The initial investigated showed that while the PCU on Braswell/Baytrail controlled RC6 itself. setting the software RC6 request made no difference. Further testing reveals though that it causes a delay in the PCU on enabling RC6. Closes: https://gitlab.freedesktop.org/drm/intel/issues/763 Fixes:

Re: [Intel-gfx] [PATCH] drm/i915/gt: Check we are the Ironlake IPS provider before deregistering

2019-12-10 Thread Venkata Sandeep Dhanalakota
On 19/12/10 03:36, Chris Wilson wrote: > Check that we own the global pointer before deregistering. > > Reported-by: Venkata Sandeep Dhanalakota > Signed-off-by: Chris Wilson > Cc: Venkata Sandeep Dhanalakota > Cc: Andi Shyti > --- > drivers/gpu/drm/i915/gt/intel_rps.c | 4 +++- > 1 file

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Improve execbuf debug (rev2)

2019-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Improve execbuf debug (rev2) URL : https://patchwork.freedesktop.org/series/70625/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7530 -> Patchwork_15664 Summary --- **FAILURE**

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/tgl: Program BW_BUDDY registers during display init (rev3)

2019-12-10 Thread Matt Roper
On Fri, Dec 06, 2019 at 01:20:07PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/tgl: Program BW_BUDDY registers during display init (rev3) > URL : https://patchwork.freedesktop.org/series/70461/ > State : failure > > == Summary == > > CI Bug Log - changes from

[Intel-gfx] [PATCH i-g-t v2] lib/sysfs: Add support for getting boolean module parameters

2019-12-10 Thread Janusz Krzysztofik
Boolean module parameters are exposed as "Y"/"N" strings, not 0/1. Make igt_sysfs_get_boolean() helper useful for getting their values. v2: Use case insensitive string compare and more compact style (Chris) Signed-off-by: Janusz Krzysztofik Reviewed-by: Chris Wilson --- I've made it still more

[Intel-gfx] [PATCH] drm/i915: Add DPCD quirk for AUO PSR2 panel

2019-12-10 Thread Gaurav K Singh
Currently on AUO PSR2 panel on Gen9 chromebook, we are observing below issues: (i) The display will show garbage after pressing sign out icon in log in screen when wallpaper is one of Solid colors & PSR2 is enabled (ii) The characters of display is not clear when switch OS mode to dev mode.

[Intel-gfx] [PATCH] drm/i915: Use per object locking in execbuf on top of struct_mutex, v2.

2019-12-10 Thread Maarten Lankhorst
Now that we changed execbuf submission slightly to allow us to do all pinning in one place, we can now simply add ww versions on top of struct_mutex. All we have to do is a separate path for -EDEADLK handling, which needs to unpin all gem bo's before dropping the lock, then starting over. This

  1   2   >