[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v4,rebased,1/2] drm/i915/display/icl+: Do not program clockgating

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [v4,rebased,1/2] drm/i915/display/icl+: Do not program clockgating URL : https://patchwork.freedesktop.org/series/71058/ State : success == Summary == CI Bug Log - changes from CI_DRM_7585_full -> Patchwork_15817_full

Re: [Intel-gfx] [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-17 Thread Jani Nikula
On Tue, 17 Dec 2019, Lee Jones wrote: > Hans was making the case that this was impractical for DRM, due to the > amount of churn you guys receive, hence the discussion. I'm very > pleased that this is not the case. Heh, well, it is the case, but the point is that should be our problem, not

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pmu: Ensure monotonic rc6 (rev2)

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Ensure monotonic rc6 (rev2) URL : https://patchwork.freedesktop.org/series/70998/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7585_full -> Patchwork_15816_full Summary ---

Re: [Intel-gfx] [PATCH 0/5] display: prefer 3-letter acronym

2019-12-17 Thread Jani Nikula
On Tue, 17 Dec 2019, Lucas De Marchi wrote: > This bothered me for a while so I decided to give it a try: let's > normalize on using the platform acronym for function prefixes. The mixed use has always bothered me too. Acked-by: Jani Nikula (Up next, IS_BROADWELL vs. IS_BDW_ULT etc... ;) >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Force the state compute phase once to enable PSR (rev3)

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/display: Force the state compute phase once to enable PSR (rev3) URL : https://patchwork.freedesktop.org/series/7/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7585_full -> Patchwork_15815_full

[Intel-gfx] [PULL] gvt-fixes

2019-12-17 Thread Zhenyu Wang
Hi, Here's current gvt fixes which has fix for vGPU display dmabuf, one guest reset warning and one locking issue. Details below. Thanks -- The following changes since commit f26a9e959a7b1588c59f7a919b41b67175b211d8: drm/i915/gt: Detect if we miss WaIdleLiteRestore (2019-12-10 12:37:53

Re: [Intel-gfx] [PATCH] drm/i915: Fix vGPU kernel context kmemleak

2019-12-17 Thread Zhenyu Wang
On 2019.12.17 08:26:16 +, Chris Wilson wrote: > Quoting Zhenyu Wang (2019-12-17 07:13:54) > > Current GVT allocates kernel context as vGPU submission context. > > For vGPU destroy, the kernel context needs to be close then released, > > otherwise context's vm ppgtt resource would cause memleak

[Intel-gfx] ✓ Fi.CI.BAT: success for display: prefer 3-letter acronym

2019-12-17 Thread Patchwork
== Series Details == Series: display: prefer 3-letter acronym URL : https://patchwork.freedesktop.org/series/71079/ State : success == Summary == CI Bug Log - changes from CI_DRM_7591 -> Patchwork_15822 Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Skip sampling engines if gt is asleep

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Skip sampling engines if gt is asleep URL : https://patchwork.freedesktop.org/series/71075/ State : success == Summary == CI Bug Log - changes from CI_DRM_7591 -> Patchwork_15821 Summary ---

[Intel-gfx] [PATCH 2/5] drm/i915/display: prefer 3-letter acronym for skylake

2019-12-17 Thread Lucas De Marchi
We are currently using a mix of platform name and acronym to name the functions. Let's prefer the acronym as it should be clear what platform it's about and it's shorter, so it doesn't go over 80 columns in a few cases. This converts skylake to skl where appropriate. Signed-off-by: Lucas De

[Intel-gfx] [PATCH 5/5] drm/i915/display: prefer 3-letter acronym for ironlake

2019-12-17 Thread Lucas De Marchi
We are currently using a mix of platform name and acronym to name the functions. Let's prefer the acronym as it should be clear what platform it's about and it's shorter, so it doesn't go over 80 columns in a few cases. This converts ironlake to ilk where appropriate. Signed-off-by: Lucas De

[Intel-gfx] [PATCH 4/5] drm/i915/display: prefer 3-letter acronym for icelake

2019-12-17 Thread Lucas De Marchi
We are currently using a mix of platform name and acronym to name the functions. Let's prefer the acronym as it should be clear what platform it's about and it's shorter, so it doesn't go over 80 columns in a few cases. This converts icelake to icl where appropriate. Signed-off-by: Lucas De

[Intel-gfx] [PATCH 3/5] drm/i915/display: prefer 3-letter acronym for cannonlake

2019-12-17 Thread Lucas De Marchi
We are currently using a mix of platform name and acronym to name the functions. Let's prefer the acronym as it should be clear what platform it's about and it's shorter, so it doesn't go over 80 columns in a few cases. This converts cannonlake to cnl where appropriate. Signed-off-by: Lucas De

[Intel-gfx] [PATCH 0/5] display: prefer 3-letter acronym

2019-12-17 Thread Lucas De Marchi
This bothered me for a while so I decided to give it a try: let's normalize on using the platform acronym for function prefixes. This does the conversion for some platforms. There are others missing, but I'm sending this early for the case the idea is shot down. Lucas De Marchi (5):

[Intel-gfx] [PATCH 1/5] drm/i915/display: prefer 3-letter acronym for haswell

2019-12-17 Thread Lucas De Marchi
We are currently using a mix of platform name and acronym to name the functions. Let's prefer the acronym as it should be clear what platform it's about and it's shorter, so it doesn't go over 80 columns in a few cases. This converts haswell to hsw where appropriate. Signed-off-by: Lucas De

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with drm/i915: Ratelimit i915_globals_park (rev3)

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with drm/i915: Ratelimit i915_globals_park (rev3) URL : https://patchwork.freedesktop.org/series/71074/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7591 -> Patchwork_15820

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915/display: move clk off sanitize to its own function

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/display: move clk off sanitize to its own function URL : https://patchwork.freedesktop.org/series/71073/ State : success == Summary == CI Bug Log - changes from CI_DRM_7590 -> Patchwork_15819

[Intel-gfx] [PATCH] drm/i915/pmu: Skip sampling engines if gt is asleep

2019-12-17 Thread Chris Wilson
If the whole GT is asleep, we know that each engine must also be asleep and so we can quickly return without checking them all. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_pmu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Intel-gfx] [PATCH] drm/i915: Ratelimit i915_globals_park

2019-12-17 Thread Chris Wilson
When doing our global park, we like to be a good citizen and shrink our slab caches (of which we have quite a few now), but each kmem_cache_shrink() incurs a stop_machine() and so ends up being quite expensive, causing machine-wide stalls. While ideally we would like to throw away unused pages in

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/7] drm/i915/guc: Merge communication_stop and communication_disable

2019-12-17 Thread Daniele Ceraolo Spurio
On 12/17/19 5:31 AM, Patchwork wrote: == Series Details == Series: series starting with [v2,1/7] drm/i915/guc: Merge communication_stop and communication_disable URL : https://patchwork.freedesktop.org/series/71020/ State : success == Summary == CI Bug Log - changes from

Re: [Intel-gfx] [PATCH v2 5/7] drm/i915/guc: Remove function pointers for send/receive calls

2019-12-17 Thread Daniele Ceraolo Spurio
On 12/17/19 1:49 PM, Michal Wajdeczko wrote: On Tue, 17 Dec 2019 02:23:14 +0100, Daniele Ceraolo Spurio wrote: Since we started using CT buffers on all gens, the function pointers can only be set to either the _nop() or the _ct() functions. Since the _nop() case applies to when the CT are

Re: [Intel-gfx] [PATCH v2 4/7] drm/i915/guc/ct: Group request-related variables in a sub-structure

2019-12-17 Thread Daniele Ceraolo Spurio
On 12/17/19 1:42 PM, Michal Wajdeczko wrote: On Tue, 17 Dec 2019 02:23:13 +0100, Daniele Ceraolo Spurio wrote: For better isolation of the request tracking from the rest of the CT-related data. v2: split to separate patch, move next_fence to substructure (Michal) Signed-off-by: Daniele

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Keep request alive while attaching fences

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/gem: Keep request alive while attaching fences URL : https://patchwork.freedesktop.org/series/71053/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7581_full -> Patchwork_15814_full

[Intel-gfx] [PATCH] drm/i915: Ratelimit i915_globals_park

2019-12-17 Thread Chris Wilson
When doing our global park, we like to be a good citizen and shrink our slab caches (of which we have quite a few now), but each kmem_cache_shrink() incurs a stop_machine() and so ends up being quite expensive, causing machine-wide stalls. While ideally we would like to throw away unused pages in

[Intel-gfx] [PATCH 1/2] drm/i915: Ratelimit i915_global_park

2019-12-17 Thread Chris Wilson
When doing our global park, we like to be a good citizen and shrink our slab caches (of which we have quite a few now), but each kmem_cache_shrink() incurs a stop_machine() and so ends up being quite expensive, causing machine-wide stalls. While ideally we would like to throw away unused pages in

[Intel-gfx] [PATCH 2/2] drm/i915/gt: Ratelimit display power w/a

2019-12-17 Thread Chris Wilson
For very light workloads that frequently park, acquiring the display power well (required to prevent the dmc from trashing the system) takes longer than the execution. A good example is the igt_coherency selftest, which is slowed down by an order of magnitude in the worst case with powerwell

[Intel-gfx] [CI 1/3] drm/i915/display: move clk off sanitize to its own function

2019-12-17 Thread Lucas De Marchi
This allows us to isolate reading and writing to the ICL_DPCLKA_CFGCR0 during the sanitize phase. Signed-off-by: Lucas De Marchi Reviewed-by: Clinton Taylor --- drivers/gpu/drm/i915/display/intel_ddi.c | 57 +--- 1 file changed, 32 insertions(+), 25 deletions(-) diff --git

[Intel-gfx] [CI 3/3] drm/i915/display: fix phy name

2019-12-17 Thread Lucas De Marchi
Pass the correct variable as argument. Signed-off-by: Lucas De Marchi Reviewed-by: Clinton Taylor --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c

[Intel-gfx] [CI 2/3] drm/i915/display: use clk_off name to avoid double negation

2019-12-17 Thread Lucas De Marchi
Instead of "ungated" use the same name for the variable as the bitfield, making it clearer what's the intent of the checks. Signed-off-by: Lucas De Marchi Reviewed-by: Clinton Taylor --- drivers/gpu/drm/i915/display/intel_ddi.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-)

[Intel-gfx] ✗ Fi.CI.IGT: failure for linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Patchwork
== Series Details == Series: linux-next: Tree for Dec 16 (drm_panel & intel_panel) URL : https://patchwork.freedesktop.org/series/71052/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7580_full -> Patchwork_15811_full

Re: [Intel-gfx] [PATCH v2 5/7] drm/i915/guc: Remove function pointers for send/receive calls

2019-12-17 Thread Michal Wajdeczko
On Tue, 17 Dec 2019 02:23:14 +0100, Daniele Ceraolo Spurio wrote: Since we started using CT buffers on all gens, the function pointers can only be set to either the _nop() or the _ct() functions. Since the _nop() case applies to when the CT are disabled, we can just handle that case in the

Re: [Intel-gfx] [PATCH v2 4/7] drm/i915/guc/ct: Group request-related variables in a sub-structure

2019-12-17 Thread Michal Wajdeczko
On Tue, 17 Dec 2019 02:23:13 +0100, Daniele Ceraolo Spurio wrote: For better isolation of the request tracking from the rest of the CT-related data. v2: split to separate patch, move next_fence to substructure (Michal) Signed-off-by: Daniele Ceraolo Spurio Cc: Michal Wajdeczko Cc: John

Re: [Intel-gfx] [PATCH v2 3/7] drm/i915/guc/ct: Stop expecting multiple CT channels

2019-12-17 Thread Michal Wajdeczko
On Tue, 17 Dec 2019 02:23:12 +0100, Daniele Ceraolo Spurio wrote: The GuC supports having multiple CT buffer pairs and we designed our implementation with that in mind. However, the different channels are not processed in parallel within the GuC, so there is very little advantage in having

Re: [Intel-gfx] [PATCH v2 2/7] drm/i915/guc/ct: Drop guards in enable/disable calls

2019-12-17 Thread Michal Wajdeczko
On Tue, 17 Dec 2019 02:23:11 +0100, Daniele Ceraolo Spurio wrote: We track the status of the GuC much more closely now and we expect the enable/disable functions to be correctly called only once. If this isn't true we do want to flag it as a flow failure (via the BUG_ON in the ctch

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix pid leak with banned clients (rev2)

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Fix pid leak with banned clients (rev2) URL : https://patchwork.freedesktop.org/series/71062/ State : success == Summary == CI Bug Log - changes from CI_DRM_7587 -> Patchwork_15818 Summary ---

Re: [Intel-gfx] [PATCH 1/2] drm: Handle connector tile support only for modes that match tile size

2019-12-17 Thread Manasi Navare
On Wed, Dec 11, 2019 at 01:24:32PM -0800, Manasi Navare wrote: > DRM Fb driver expects multiple CRTCs if it sees connector->has_tile > is set, but we need to handle tile support and look for multiple CRTCs > only for the modes that match the tile size. The other modes should > be able to be

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm: Handle connector tile support only for modes that match tile size

2019-12-17 Thread Manasi Navare
On Tue, Dec 17, 2019 at 09:56:54AM +0200, Tomi Sarvela wrote: > On 12/17/19 1:59 AM, Manasi Navare wrote: > >On Fri, Dec 13, 2019 at 10:54:55AM +0200, Tomi Sarvela wrote: > >>On 12/12/19 11:28 PM, Manasi Navare wrote: > >>>The KBL failure does not look related to the changes in this patch series.

Re: [Intel-gfx] [RFC v2 06/12] drm/i915/svm: Device memory support

2019-12-17 Thread Jason Gunthorpe
On Fri, Dec 13, 2019 at 01:56:08PM -0800, Niranjana Vishwanathapura wrote: > @@ -169,6 +170,11 @@ static int i915_range_fault(struct svm_notifier *sn, > return ret; > } > > + /* For dgfx, ensure the range is in device local memory only */ > +

Re: [Intel-gfx] [RFC v2 05/12] drm/i915/svm: Page table mirroring support

2019-12-17 Thread Jason Gunthorpe
On Fri, Dec 13, 2019 at 01:56:07PM -0800, Niranjana Vishwanathapura wrote: > +static struct i915_svm *vm_get_svm(struct i915_address_space *vm) > +{ > + struct i915_svm *svm = vm->svm; > + > + mutex_lock(>svm_mutex); > + if (svm && !kref_get_unless_zero(>ref)) > + svm =

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-12-17 Thread Stephen Rothwell
Hi Daniel, On Tue, 17 Dec 2019 14:19:37 +0100 Daniel Vetter wrote: > > On Mon, Dec 16, 2019 at 12:23:31PM +1100, Stephen Rothwell wrote: > > > > After merging the drm-misc tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > >

Re: [Intel-gfx] [RFC v2 02/12] drm/i915/svm: Runtime (RT) allocator support

2019-12-17 Thread Jason Gunthorpe
On Fri, Dec 13, 2019 at 01:56:04PM -0800, Niranjana Vishwanathapura wrote: > + ctx = i915_gem_context_lookup(file->driver_priv, args->rsvd1); > + if (!ctx || !rcu_access_pointer(ctx->vm)) > + return -ENOENT; > + > + rcu_read_lock(); > + vm = i915_vm_get(ctx->vm); > +

Re: [Intel-gfx] [PATCH] drm/i915/display: cleanup intel_bw_state on i915 module removal

2019-12-17 Thread Lucas De Marchi
On Thu, Dec 12, 2019 at 12:34:49PM -0800, Lucas De Marchi wrote: On Thu, Dec 12, 2019 at 09:37:17AM -0800, Matt Roper wrote: On Wed, Dec 11, 2019 at 04:22:50PM -0800, Lucas De Marchi wrote: On Wed, Dec 11, 2019 at 12:10:41PM +0530, Bharadiya,Pankaj wrote: On Tue, Dec 10, 2019 at 09:57:39PM

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,rebased,1/2] drm/i915/display/icl+: Do not program clockgating

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [v4,rebased,1/2] drm/i915/display/icl+: Do not program clockgating URL : https://patchwork.freedesktop.org/series/71058/ State : success == Summary == CI Bug Log - changes from CI_DRM_7585 -> Patchwork_15817

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Ensure monotonic rc6 (rev2)

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Ensure monotonic rc6 (rev2) URL : https://patchwork.freedesktop.org/series/70998/ State : success == Summary == CI Bug Log - changes from CI_DRM_7585 -> Patchwork_15816 Summary ---

Re: [Intel-gfx] [PATCH 5/8] drm/mipi-dbi: convert to drm device based logging

2019-12-17 Thread Sam Ravnborg
On Tue, Dec 17, 2019 at 08:00:11PM +0100, Sam Ravnborg wrote: > On Tue, Dec 10, 2019 at 02:30:47PM +0200, Jani Nikula wrote: > > Prefer drm device based logging where possible. > > > > Signed-off-by: Jani Nikula > > --- > > drivers/gpu/drm/drm_mipi_dbi.c | 15 --- > > 1 file

Re: [Intel-gfx] [PATCH 6/8] drm/atomic: convert to drm device based logging

2019-12-17 Thread Sam Ravnborg
Hi Jani. On Tue, Dec 10, 2019 at 02:30:48PM +0200, Jani Nikula wrote: > Prefer drm_dbg_atomic(). This patch simplify code by introducing a local drm_device varialble which is good. But this is not mentioned in the cahngelog. Anf the patch uses more than just drm_dbg_atomic(), see for example

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dp: Make sure all tiled connectors get added to the state with full modeset

2019-12-17 Thread Manasi Navare
On Tue, Dec 17, 2019 at 12:50:31PM +0200, Ville Syrjälä wrote: > On Mon, Dec 16, 2019 at 02:58:13PM -0800, Manasi Navare wrote: > > On Mon, Dec 16, 2019 at 02:33:10PM -0800, Manasi Navare wrote: > > > On Mon, Dec 16, 2019 at 11:37:38PM +0200, Ville Syrjälä wrote: > > > > On Mon, Dec 16, 2019 at

Re: [Intel-gfx] [PATCH 5/8] drm/mipi-dbi: convert to drm device based logging

2019-12-17 Thread Sam Ravnborg
On Tue, Dec 10, 2019 at 02:30:47PM +0200, Jani Nikula wrote: > Prefer drm device based logging where possible. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_mipi_dbi.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git

Re: [Intel-gfx] [PATCH 3/8] drm/fb-helper: convert to drm device based logging

2019-12-17 Thread Sam Ravnborg
Hi Jani. On Tue, Dec 10, 2019 at 02:30:45PM +0200, Jani Nikula wrote: > Prefer drm_dbg_kms(), drm_info(), and drm_err() over all other > logging. This is about KMS so switch to the KMS category while at it. > > Signed-off-by: Jani Nikula Reviewed-by: Sam Ravnborg > --- >

Re: [Intel-gfx] [PATCH 4/8] drm/gem-fb-helper: convert to drm device based logging

2019-12-17 Thread Sam Ravnborg
On Tue, Dec 10, 2019 at 02:30:46PM +0200, Jani Nikula wrote: > Prefer drm_dbg_kms() and drm_err() over all other logging. > > Signed-off-by: Jani Nikula Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/drm_gem_framebuffer_helper.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-)

Re: [Intel-gfx] [PATCH 2/8] drm/client: convert to drm device based logging

2019-12-17 Thread Sam Ravnborg
Hi Jani. On Tue, Dec 10, 2019 at 02:30:44PM +0200, Jani Nikula wrote: > Prefer drm_dbg_kms() and drm_err() over DRM_DEV_DEBUG_KMS() and > DRM_DEV_ERROR(). > > Signed-off-by: Jani Nikula Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/drm_client.c | 10 +- > 1 file changed, 5

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)

2019-12-17 Thread James Ausmus
(+Lakshmi) On Tue, Dec 17, 2019 at 06:33:58PM +, Souza, Jose wrote: > On Tue, 2019-12-17 at 18:10 +, Patchwork wrote: > > == Series Details == > > > > Series: series starting with [1/5] drm: Add > > __drm_atomic_helper_crtc_state_reset() & co. (rev3) > > URL :

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Force the state compute phase once to enable PSR (rev3)

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/display: Force the state compute phase once to enable PSR (rev3) URL : https://patchwork.freedesktop.org/series/7/ State : success == Summary == CI Bug Log - changes from CI_DRM_7585 -> Patchwork_15815

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)

2019-12-17 Thread Souza, Jose
On Tue, 2019-12-17 at 18:10 +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/5] drm: Add > __drm_atomic_helper_crtc_state_reset() & co. (rev3) > URL : https://patchwork.freedesktop.org/series/69129/ > State : failure > > == Summary == > > CI Bug Log - changes

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3) URL : https://patchwork.freedesktop.org/series/69129/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15797_full

Re: [Intel-gfx] [RFC v2 02/12] drm/i915/svm: Runtime (RT) allocator support

2019-12-17 Thread Jason Ekstrand
On Sun, Dec 15, 2019 at 10:24 PM Niranjan Vishwanathapura < niranjana.vishwanathap...@intel.com> wrote: > On Sat, Dec 14, 2019 at 10:31:37AM +, Chris Wilson wrote: > >Quoting Jason Ekstrand (2019-12-14 00:36:19) > >> On Fri, Dec 13, 2019 at 5:24 PM Niranjan Vishwanathapura < > >>

Re: [Intel-gfx] [PATCH v12 2/3] drm/i915: Restrict qgv points which don't have enough bandwidth.

2019-12-17 Thread Ville Syrjälä
On Fri, Dec 13, 2019 at 04:12:30PM +0200, Stanislav Lisovskiy wrote: > According to BSpec 53998, we should try to > restrict qgv points, which can't provide > enough bandwidth for desired display configuration. > > Currently we are just comparing against all of > those and take minimum(worst

Re: [Intel-gfx] [PATCH v3 06/11] drm/i915/display: Share intel_connector_needs_modeset()

2019-12-17 Thread Lucas De Marchi
On Tue, Dec 17, 2019 at 08:39:15AM -0800, Jose Souza wrote: On Mon, 2019-12-16 at 15:52 -0800, Lucas De Marchi wrote: On Mon, Dec 16, 2019 at 02:07:37PM -0800, Jose Souza wrote: > intel_connector_needs_modeset() will be used outside of > intel_display.c in a future patch so it would only be

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Move stuff from haswell_crtc_disable() into encoder .post_disable()

2019-12-17 Thread Souza, Jose
On Fri, 2019-12-13 at 21:52 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Move all of haswell_crtc_disable() into the encoder > .post_disable() hooks. Now we're left with just > calling the .disable() and .post_disable() hooks > back to back. > > I chose to move the code into the

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Expose list of clients in sysfs

2019-12-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-12-17 17:21:28) > > On 16/12/2019 12:53, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-12-16 12:07:01) > >> diff --git a/drivers/gpu/drm/i915/i915_drv.h > >> b/drivers/gpu/drm/i915/i915_drv.h > >> index 0781b6326b8c..9fcbcb6d6f76 100644 > >> ---

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Expose list of clients in sysfs

2019-12-17 Thread Tvrtko Ursulin
On 16/12/2019 12:53, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-12-16 12:07:01) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 0781b6326b8c..9fcbcb6d6f76 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -224,6

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix pid leak with banned clients

2019-12-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-12-17 17:09:33) > From: Tvrtko Ursulin > > Get_pid_task() needs to be paired with a put_pid or we leak a pid > reference every time a banned client tries to create a context. > > v2: > * task_pid_nr helper exists! (Chris) > > Signed-off-by: Tvrtko Ursulin >

[Intel-gfx] [PATCH v2] drm/i915: Fix pid leak with banned clients

2019-12-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Get_pid_task() needs to be paired with a put_pid or we leak a pid reference every time a banned client tries to create a context. v2: * task_pid_nr helper exists! (Chris) Signed-off-by: Tvrtko Ursulin Fixes: b083a0870c79 ("drm/i915: Add per client max context ban limit")

Re: [Intel-gfx] [PATCH v12 1/3] drm/i915: Refactor intel_can_enable_sagv

2019-12-17 Thread Ville Syrjälä
On Fri, Dec 13, 2019 at 04:12:29PM +0200, Stanislav Lisovskiy wrote: > Currently intel_can_enable_sagv function contains > a mix of workarounds for different platforms > some of them are not valid for gens >= 11 already, > so lets split it into separate functions. > > v2: > - Rework watermark

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Eliminate the trylock for reading a timeline's hwsp

2019-12-17 Thread Tvrtko Ursulin
On 16/12/2019 17:52, Chris Wilson wrote: As we stash a pointer to the HWSP cacheline on the request, when reading it we only need confirm that the cacheline is still valid by checking that the request and timeline are still intact. v2: Protect hwsp_cachline with RCU Signed-off-by: Chris

Re: [Intel-gfx] [PATCH v3 06/11] drm/i915/display: Share intel_connector_needs_modeset()

2019-12-17 Thread Souza, Jose
On Mon, 2019-12-16 at 15:52 -0800, Lucas De Marchi wrote: > On Mon, Dec 16, 2019 at 02:07:37PM -0800, Jose Souza wrote: > > intel_connector_needs_modeset() will be used outside of > > intel_display.c in a future patch so it would only be necessary to > > remove the state and add the prototype to

Re: [Intel-gfx] [PATCH] drm/i915: Fix pid leak with banned clients

2019-12-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-12-17 16:18:14) > From: Tvrtko Ursulin > > Get_pid_task() needs to be paired with a put_pid or we leak a pid > reference every time a banned client tries to create a context. > > Signed-off-by: Tvrtko Ursulin > Fixes: b083a0870c79 ("drm/i915: Add per client max

[Intel-gfx] [PATCH] drm/i915: Fix pid leak with banned clients

2019-12-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Get_pid_task() needs to be paired with a put_pid or we leak a pid reference every time a banned client tries to create a context. Signed-off-by: Tvrtko Ursulin Fixes: b083a0870c79 ("drm/i915: Add per client max context ban limit") Cc: Chris Wilson Cc: Mika Kuoppala ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Avoid multi-LRI on Sandybridge

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/gt: Avoid multi-LRI on Sandybridge URL : https://patchwork.freedesktop.org/series/71029/ State : success == Summary == CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15808_full Summary ---

Re: [Intel-gfx] [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-17 Thread Sam Ravnborg
Hi Jani. Will you type a todo entry as requested by Daniel? > Pushed this one patch, thanks for the reviews and acks. The rest could > still use review. ;) Will take a look again later tonight. I recall from last time I looked they were fine but I just never sent anything to the ML. Sam

Re: [Intel-gfx] linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Jani Nikula
On Tue, 17 Dec 2019, Andy Shevchenko wrote: > On Tue, Dec 17, 2019 at 5:28 PM Jani Nikula > wrote: >> On Tue, 17 Dec 2019, Andy Shevchenko wrote: >> > On Tue, Dec 17, 2019 at 1:56 PM Steven Price wrote: > >> > I think the proper one is to have s/IS_ENABLED/IS_REACHABLE/. >> > It fixes issue

Re: [Intel-gfx] linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Andy Shevchenko
On Tue, Dec 17, 2019 at 5:28 PM Jani Nikula wrote: > On Tue, 17 Dec 2019, Andy Shevchenko wrote: > > On Tue, Dec 17, 2019 at 1:56 PM Steven Price wrote: > > I think the proper one is to have s/IS_ENABLED/IS_REACHABLE/. > > It fixes issue for me. > > As discussed off-line, this will allow

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix vGPU kernel context kmemleak

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Fix vGPU kernel context kmemleak URL : https://patchwork.freedesktop.org/series/71027/ State : success == Summary == CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15807_full Summary ---

Re: [Intel-gfx] linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Jani Nikula
On Tue, 17 Dec 2019, Andy Shevchenko wrote: > On Tue, Dec 17, 2019 at 1:56 PM Steven Price wrote: >> On 17/12/2019 06:37, Randy Dunlap wrote: >> > On 12/16/19 9:42 PM, Sam Ravnborg wrote: >> >> On Mon, Dec 16, 2019 at 08:25:11AM -0800, Randy Dunlap wrote: >> >>> On 12/15/19 9:22 PM, Stephen

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Keep request alive while attaching fences

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/gem: Keep request alive while attaching fences URL : https://patchwork.freedesktop.org/series/71053/ State : success == Summary == CI Bug Log - changes from CI_DRM_7581 -> Patchwork_15814 Summary

[Intel-gfx] [PATCH v4 rebased 2/2] drm/i915/display: Fix warning about MST and DDI restrictions

2019-12-17 Thread José Roberto de Souza
Capturing the restrictions of the BSpec pages bellow: SKL and CNL do not support MST in DDI E, DDI E only support 2 lanes and it is mostly used to support a 4 lanes eDP panel together with DDI A. ICL's DDI E support MST just like other ports but DDI A is still eDP and MIPI only. TGL supports MST

[Intel-gfx] [PATCH v4 rebased 1/2] drm/i915/display/icl+: Do not program clockgating

2019-12-17 Thread José Roberto de Souza
Talked with HW team and this is a left over, driver should not program clockgating, mg or dekel firmware is reponsible for any clockgating programing. Also removing the register and bits definition related to clockgating. v2: Added WARN_ON v3: Only calling icl_phy_set_clock_gating() on

Re: [Intel-gfx] [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-17 Thread Jani Nikula
On Tue, 10 Dec 2019, Jani Nikula wrote: > Add new struct drm_device based logging macros modeled after the core > kernel device based logging macros. These would be preferred over the > drm printk and struct device based macros in drm code, where possible. > > We have existing drm specific struct

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,01/11] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev2)

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [v3,01/11] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev2) URL : https://patchwork.freedesktop.org/series/71009/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7581 -> Patchwork_15813

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: Add getfb2 ioctl (rev2)

2019-12-17 Thread Patchwork
== Series Details == Series: drm: Add getfb2 ioctl (rev2) URL : https://patchwork.freedesktop.org/series/67553/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15806_full Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH v2] drm/i915/pmu: Ensure monotonic rc6

2019-12-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-12-17 14:20:57) > From: Tvrtko Ursulin > > Avoid rc6 counter going backward in close to 0% RC6 scenarios like: > > 15.005477996114,246,613 ns i915/rc6-residency/ > 16.005876662667,657 ns i915/rc6-residency/ > 17.006131417

[Intel-gfx] [PATCH v2] drm/i915/pmu: Ensure monotonic rc6

2019-12-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Avoid rc6 counter going backward in close to 0% RC6 scenarios like: 15.005477996114,246,613 ns i915/rc6-residency/ 16.005876662667,657 ns i915/rc6-residency/ 17.006131417 7,286 ns i915/rc6-residency/ 18.006615031

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v2,rebased,01/11] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev2)

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [v2,rebased,01/11] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev2) URL : https://patchwork.freedesktop.org/series/70775/ State : failure == Summary == Applying: drm: Add __drm_atomic_helper_crtc_state_reset() & co. Applying:

Re: [Intel-gfx] linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Andy Shevchenko
On Tue, Dec 17, 2019 at 1:56 PM Steven Price wrote: > On 17/12/2019 06:37, Randy Dunlap wrote: > > On 12/16/19 9:42 PM, Sam Ravnborg wrote: > >> On Mon, Dec 16, 2019 at 08:25:11AM -0800, Randy Dunlap wrote: > >>> On 12/15/19 9:22 PM, Stephen Rothwell wrote: > >>> on x86_64: > >>> > >>> ld:

Re: [Intel-gfx] [PATCH] drm/i915/gem: Keep request alive while attaching fences

2019-12-17 Thread Matthew Auld
On Tue, 17 Dec 2019 at 13:47, Chris Wilson wrote: > > Since commit e5dadff4b093 ("drm/i915: Protect request retirement with > timeline->mutex"), the request retirement can happen outside of the > struct_mutex serialised only by the timeline->mutex. We drop the > timeline->mutex on submitting the

[Intel-gfx] [PATCH v2] drm/i915/display: Force the state compute phase once to enable PSR

2019-12-17 Thread José Roberto de Souza
Recent improvements in the state tracking in i915 caused PSR to not be enabled when reusing firmware/BIOS modeset, this is due to all initial commits returning ealier in intel_atomic_check() as needs_modeset() is always false. To fix that here forcing the state compute phase in CRTC that is

Re: [Intel-gfx] [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-17 Thread Lee Jones
On Tue, 17 Dec 2019, Jani Nikula wrote: > On Tue, 17 Dec 2019, Lee Jones wrote: > > On Mon, 16 Dec 2019, Hans de Goede wrote: > > > >> Hi, > >> > >> Doing immutable branches assumes that there is a base point, > >> e.g. 5.5-rc1 where the immutable branch can then be based on and > >> that the

[Intel-gfx] [PATCH] drm/i915/gem: Keep request alive while attaching fences

2019-12-17 Thread Chris Wilson
Since commit e5dadff4b093 ("drm/i915: Protect request retirement with timeline->mutex"), the request retirement can happen outside of the struct_mutex serialised only by the timeline->mutex. We drop the timeline->mutex on submitting the request (i915_request_add) so after that point, it is liable

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Add lmem fault handler

2019-12-17 Thread Abdiel Janulgue
On 17/12/2019 15.00, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/i915: Add lmem fault handler > URL : https://patchwork.freedesktop.org/series/71051/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7580 -> Patchwork_15810 >

[Intel-gfx] ✓ Fi.CI.BAT: success for linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Patchwork
== Series Details == Series: linux-next: Tree for Dec 16 (drm_panel & intel_panel) URL : https://patchwork.freedesktop.org/series/71052/ State : success == Summary == CI Bug Log - changes from CI_DRM_7580 -> Patchwork_15811 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/7] drm/i915/guc: Merge communication_stop and communication_disable

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [v2,1/7] drm/i915/guc: Merge communication_stop and communication_disable URL : https://patchwork.freedesktop.org/series/71020/ State : success == Summary == CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15805_full

Re: [Intel-gfx] [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-17 Thread Jani Nikula
On Tue, 17 Dec 2019, Lee Jones wrote: > On Mon, 16 Dec 2019, Hans de Goede wrote: > >> Hi, >> >> Doing immutable branches assumes that there is a base point, >> e.g. 5.5-rc1 where the immutable branch can then be based on and >> that the branch can then be merged without issues into both

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-12-17 Thread Daniel Vetter
On Mon, Dec 16, 2019 at 12:23:31PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c: In function > 'anx6345_i2c_probe': >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Patchwork
== Series Details == Series: linux-next: Tree for Dec 16 (drm_panel & intel_panel) URL : https://patchwork.freedesktop.org/series/71052/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4f9c2e2f3e3a linux-next: Tree for Dec 16 (drm_panel & intel_panel) -:22:

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Add lmem fault handler

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Add lmem fault handler URL : https://patchwork.freedesktop.org/series/71051/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7580 -> Patchwork_15810 Summary

Re: [Intel-gfx] [PULL] drm-misc-next

2019-12-17 Thread Daniel Vetter
On Tue, Dec 17, 2019 at 09:48:53AM +0100, Maarten Lankhorst wrote: > Hey, > > First pull for v5.6! > > Enjoy! > > ~Maarten > > drm-misc-next-2019-12-16: > drm-misc-next for v5.6: > > UAPI Changes: > - Add support for DMA-BUF HEAPS. > > Cross-subsystem Changes: > - mipi dsi definition

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Eliminate the trylock for reading a timeline's hwsp (rev3)

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/gt: Eliminate the trylock for reading a timeline's hwsp (rev3) URL : https://patchwork.freedesktop.org/series/70997/ State : success == Summary == CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15804_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Add lmem fault handler

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Add lmem fault handler URL : https://patchwork.freedesktop.org/series/71051/ State : warning == Summary == $ dim checkpatch origin/drm-tip 21b92ebb9c01 drm/i915: Add lmem fault handler -:116: WARNING:UNNECESSARY_ELSE: else is

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Add lmem fault handler

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Add lmem fault handler URL : https://patchwork.freedesktop.org/series/71051/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: Add lmem fault handler -

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add lmem fault handler

2019-12-17 Thread Abdiel Janulgue
On 17/12/2019 14.14, Chris Wilson wrote: > Quoting Abdiel Janulgue (2019-12-17 11:57:49) >> Fault handler to handle missing pages for lmem objects. >> >> v4: Restore non-contigous fault handling in addition to remap_io_mapping >> >> Signed-off-by: Abdiel Janulgue >> Signed-off-by: Matthew Auld

  1   2   >