Re: [Intel-gfx] [PATCH 01/23] drm: Add get_scanout_position() to struct drm_crtc_helper_funcs

2020-01-14 Thread Thomas Zimmermann
Hi Am 14.01.20 um 16:31 schrieb Yannick FERTRE: > Thanks for the patch. > > Tested-by: Yannick Fertré Thanks for testing all these patches. Best regards Thomas > > BR > Yannick Fertré > > > On 1/10/20 10:21 AM, Thomas Zimmermann wrote: >> The new callback get_scanout_position() reads the

[Intel-gfx] ✓ Fi.CI.IGT: success for Misc GuC CT improvements

2020-01-14 Thread Patchwork
== Series Details == Series: Misc GuC CT improvements URL : https://patchwork.freedesktop.org/series/71927/ State : success == Summary == CI Bug Log - changes from CI_DRM_7725_full -> Patchwork_16067_full Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm: Introduce struct drm_device based WARN* and use them in i915 (rev2)

2020-01-14 Thread Patchwork
== Series Details == Series: drm: Introduce struct drm_device based WARN* and use them in i915 (rev2) URL : https://patchwork.freedesktop.org/series/72035/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Introduce struct drm_device based WARN* and use them in i915 (rev2)

2020-01-14 Thread Patchwork
== Series Details == Series: drm: Introduce struct drm_device based WARN* and use them in i915 (rev2) URL : https://patchwork.freedesktop.org/series/72035/ State : success == Summary == CI Bug Log - changes from CI_DRM_7746 -> Patchwork_16105

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Introduce struct drm_device based WARN* and use them in i915 (rev2)

2020-01-14 Thread Patchwork
== Series Details == Series: drm: Introduce struct drm_device based WARN* and use them in i915 (rev2) URL : https://patchwork.freedesktop.org/series/72035/ State : warning == Summary == $ dim checkpatch origin/drm-tip 18f3673543e1 drm/print: introduce new struct drm_device based WARN* macros

[Intel-gfx] [ [PATCH v2 07/10] drm/i915/gvt: Make WARN* drm specific where drm_priv ptr is available

2020-01-14 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_i915_private struct pointer is readily available. The conversion was done

[Intel-gfx] [ [PATCH v2 08/10] drm/i915/gvt: Make WARN* drm specific where vgpu ptr is available

2020-01-14 Thread Pankaj Bharadiya
Drm specific drm_WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_device struct pointer is readily available. The conversion was done

[Intel-gfx] [ [PATCH v2 09/10] drm/i915: Make WARN* drm specific where drm_priv ptr is available

2020-01-14 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_i915_private struct pointer is readily available. The conversion was done

[Intel-gfx] [ [PATCH v2 10/10] drm/i915: Make WARN* drm specific where uncore or stream ptr is available

2020-01-14 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where intel_uncore/i915_perf_stream struct pointer is readily available. The conversion

[Intel-gfx] [ [PATCH v2 06/10] drm/i915/gt: Make WARN* drm specific where drm_priv ptr is available

2020-01-14 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_i915_private struct pointer is readily available. The conversion was done

[Intel-gfx] [ [PATCH v2 05/10] drm/i915/gem: Make WARN* drm specific where drm_priv ptr is available

2020-01-14 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_i915_private struct pointer is readily available. The conversion was done

[Intel-gfx] [ [PATCH v2 03/10] drm/i915/display: Make WARN* drm specific where drm_priv ptr is available

2020-01-14 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_i915_private struct pointer is readily available. The conversion was done

[Intel-gfx] [ [PATCH v2 04/10] drm/i915/display: Make WARN* drm specific where encoder ptr is available

2020-01-14 Thread Pankaj Bharadiya
Drm specific drm_WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where intel_encoder struct pointer is available. The conversion was done automatically

[Intel-gfx] [ [PATCH v2 02/10] drm/i915/display: Make WARN* drm specific where drm_device ptr is available

2020-01-14 Thread Pankaj Bharadiya
Drm specific drm_WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_device struct pointer is readily available. The conversion was done

[Intel-gfx] [ [PATCH v2 02/10] drm/i915/display: Make WARN* drm specific where drm_device ptr is available

2020-01-14 Thread Pankaj Bharadiya
Drm specific drm_WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_device struct pointer is readily available. The conversion was done

[Intel-gfx] [ [PATCH v2 00/10] drm: Introduce struct drm_device based WARN* and use them in i915

2020-01-14 Thread Pankaj Bharadiya
Device specific dev_WARN and dev_WARN_ONCE macros available in kernel include device information in the backtrace, so we know what device the warnings originate from. Similar to this, add new struct drm_device based drm_WARN* macros. These macros include device information in the backtrace, so we

[Intel-gfx] [ [PATCH v2 01/10] drm/print: introduce new struct drm_device based WARN* macros

2020-01-14 Thread Pankaj Bharadiya
Add new struct drm_device based WARN* macros. These are modeled after the core kernel device based WARN* macros. These would be preferred over the regular WARN* macros, where possible. These macros include device information in the backtrace, so we know what device the warnings originate from.

[Intel-gfx] [ [PATCH v2 01/10] drm/print: introduce new struct drm_device based WARN* macros

2020-01-14 Thread Pankaj Bharadiya
Add new struct drm_device based WARN* macros. These are modeled after the core kernel device based WARN* macros. These would be preferred over the regular WARN* macros, where possible. These macros include device information in the backtrace, so we know what device the warnings originate from.

[Intel-gfx] [ [PATCH v2 00/10] drm: Introduce struct drm_device based WARN* and use them in i915

2020-01-14 Thread Pankaj Bharadiya
Device specific dev_WARN and dev_WARN_ONCE macros available in kernel include device information in the backtrace, so we know what device the warnings originate from. Similar to this, add new struct drm_device based drm_WARN* macros. These macros include device information in the backtrace, so we

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/guc: Update to GuC FW v40

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update to GuC FW v40 URL : https://patchwork.freedesktop.org/series/72032/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Update to GuC FW v40

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update to GuC FW v40 URL : https://patchwork.freedesktop.org/series/72032/ State : success == Summary == CI Bug Log - changes from CI_DRM_7746 -> Patchwork_16104 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/ggtt: Add generic i915_ggtt ballooning support

2020-01-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/ggtt: Add generic i915_ggtt ballooning support URL : https://patchwork.freedesktop.org/series/71920/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7724_full -> Patchwork_16066_full

[Intel-gfx] [PATCH] drm/i915/guc: Update to GuC FW v40

2020-01-14 Thread John . C . Harrison
From: Matthew Brost The GuC major version has jumped from 35 to 40. This is because this FW includes a significant re-write of the API that completely breaks backwards compatibility for command submission. This patch is sufficient to enable loading of the GuC and hence authentication of the HuC.

[Intel-gfx] ✓ Fi.CI.BAT: success for Commit early to GuC

2020-01-14 Thread Patchwork
== Series Details == Series: Commit early to GuC URL : https://patchwork.freedesktop.org/series/72031/ State : success == Summary == CI Bug Log - changes from CI_DRM_7746 -> Patchwork_16103 Summary --- **SUCCESS** No regressions

[Intel-gfx] ✗ Fi.CI.BUILD: warning for Commit early to GuC

2020-01-14 Thread Patchwork
== Series Details == Series: Commit early to GuC URL : https://patchwork.freedesktop.org/series/72031/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is ready (#1)

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/dsi: Lookup the i2c bus from ACPI NS only if CONFIG_ACPI=y (v2)

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Lookup the i2c bus from ACPI NS only if CONFIG_ACPI=y (v2) URL : https://patchwork.freedesktop.org/series/72030/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: Lookup the i2c bus from ACPI NS only if CONFIG_ACPI=y (v2)

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Lookup the i2c bus from ACPI NS only if CONFIG_ACPI=y (v2) URL : https://patchwork.freedesktop.org/series/72030/ State : success == Summary == CI Bug Log - changes from CI_DRM_7746 -> Patchwork_16102

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Commit early to GuC

2020-01-14 Thread Patchwork
== Series Details == Series: Commit early to GuC URL : https://patchwork.freedesktop.org/series/72031/ State : warning == Summary == $ dim checkpatch origin/drm-tip c114a4a8e211 drm/i915/guc: Kill USES_GUC macro 033b28e648f2 drm/i915/guc: Kill USES_GUC_SUBMISSION macro 4eb628448c92

[Intel-gfx] ✓ Fi.CI.BAT: success for Security mitigation for Intel Gen7 HWs

2020-01-14 Thread Patchwork
== Series Details == Series: Security mitigation for Intel Gen7 HWs URL : https://patchwork.freedesktop.org/series/72028/ State : success == Summary == CI Bug Log - changes from CI_DRM_7746 -> Patchwork_16101 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.BUILD: warning for Security mitigation for Intel Gen7 HWs

2020-01-14 Thread Patchwork
== Series Details == Series: Security mitigation for Intel Gen7 HWs URL : https://patchwork.freedesktop.org/series/72028/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel:

[Intel-gfx] [PATCH 6/7] drm/i915/guc: Start considering GuC submission a proper back-end

2020-01-14 Thread Daniele Ceraolo Spurio
Now that we commit early to using GuC, we can start setting up the engine for GuC submission during engine_init, instead of initializing it for execlists submission first and updating it later. Note that the change is still mostly cosmetic, since the new GuC submission setup function internally

[Intel-gfx] [PATCH 4/7] drm/i915/uc: Abort early on uc_init failure

2020-01-14 Thread Daniele Ceraolo Spurio
Now that we can differentiate wants vs uses GuC/HuC, intel_uc_init is restricted to running only if we have successfully fetched the required blob(s) and are committed to using the microcontroller(s). The only remaining thing that can go wrong in uc_init is the allocation of GuC/HuC related

[Intel-gfx] [PATCH 2/7] drm/i915/guc: Kill USES_GUC_SUBMISSION macro

2020-01-14 Thread Daniele Ceraolo Spurio
use intel_uc_uses_guc_submission() directly instead, to be consistent in the way we check what we want to do with the GuC. Signed-off-by: Daniele Ceraolo Spurio Cc: Michal Wajdeczko Cc: John Harrison Cc: Matthew Brost --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +-

[Intel-gfx] [PATCH 1/7] drm/i915/guc: Kill USES_GUC macro

2020-01-14 Thread Daniele Ceraolo Spurio
use intel_uc_uses_guc() directly instead, to be consistent in the way we check what we want to do with the GuC. Signed-off-by: Daniele Ceraolo Spurio Cc: Michal Wajdeczko Cc: John Harrison Cc: Matthew Brost --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 +- drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [PATCH 3/7] drm/i915/uc: Improve tracking of uC init status

2020-01-14 Thread Daniele Ceraolo Spurio
To be able to setup GuC submission functions during engine init we need to commit to using GuC as soon as possible. Currently, the only thing that can stop us from using the microcontrollers once we've fetched the blobs is a fundamental error (e.g. OOM); given that if we hit such an error we can't

[Intel-gfx] [PATCH 5/7] drm/i915/guc: Apply new uC status tracking to GuC submission as well

2020-01-14 Thread Daniele Ceraolo Spurio
To be able to differentiate the before and after of our commitment to GuC submission, which will be used in follow-up patches to early set-up the submission structures. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_guc.c| 12

[Intel-gfx] [PATCH 0/7] Commit early to GuC

2020-01-14 Thread Daniele Ceraolo Spurio
We currently wait until we attempt to load the GuC to confirm if we're in GuC mode or not, at which point a lot of the engine setup has already happened and needs to be updated for GuC submission. To allow us to get the setup done directly into GuC mode, we need to commit to using GuC as soon as

[Intel-gfx] [PATCH 7/7] HAX: force enable_guc=2

2020-01-14 Thread Daniele Ceraolo Spurio
From: Anusha Srivatsa Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 31b88f297fbc..acda9f2a1207 100644 ---

[Intel-gfx] [PATCH] drm/i915/dsi: Lookup the i2c bus from ACPI NS only if CONFIG_ACPI=y (v2)

2020-01-14 Thread Vivek Kasireddy
Perform the i2c bus/adapter lookup from ACPI Namespace only if ACPI is enabled in the kernel config. If ACPI is not enabled or if the lookup fails, we'll fallback to using the VBT for identiying the i2c bus. This patch Fixes: 8cbf89db2941 ("drm/i915/dsi: Parse the I2C element from the VBT MIPI

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Security mitigation for Intel Gen7 HWs

2020-01-14 Thread Patchwork
== Series Details == Series: Security mitigation for Intel Gen7 HWs URL : https://patchwork.freedesktop.org/series/72028/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5ebdedee01b7 drm/i915: Add mechanism to submit a context WA on ring submission eb1ef8928cfc drm/i915/gen7:

[Intel-gfx] [RFC PATCH v2 2/2] drm/i915/gen7: Clear all EU/L3 residual contexts

2020-01-14 Thread Akeem G Abodunrin
From: Prathap Kumar Valsan On gen7 and gen7.5 devices, there could be leftover data residuals in EU/L3 from the retiring context. This patch introduces workaround to clear that residual contexts, by submitting a batch buffer with dedicated HW context to the GPU with ring allocation for each

[Intel-gfx] [RFC PATCH v2 0/2] Security mitigation for Intel Gen7 HWs

2020-01-14 Thread Akeem G Abodunrin
Intel ID: PSIRT-TA-201910-001 CVEID: CVE-2019-14615 Summary of Vulnerability Insufficient control flow in certain data structures for some Intel(R) Processors with Intel Processor Graphics may allow an unauthenticated user to potentially enable information disclosure via

[Intel-gfx] [RFC PATCH v2 1/2] drm/i915: Add mechanism to submit a context WA on ring submission

2020-01-14 Thread Akeem G Abodunrin
From: Mika Kuoppala This patch adds framework to submit an arbitrary batchbuffer on each context switch to clear residual state for render engine on Gen7/7.5 devices. Signed-off-by: Mika Kuoppala Signed-off-by: Akeem G Abodunrin Cc: Kumar Valsan Prathap Cc: Chris Wilson Cc: Balestrieri

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Restrict legacy color key ioctl to pre-gen12

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915: Restrict legacy color key ioctl to pre-gen12 URL : https://patchwork.freedesktop.org/series/72026/ State : success == Summary == CI Bug Log - changes from CI_DRM_7746 -> Patchwork_16100 Summary

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915: Restrict legacy color key ioctl to pre-gen12

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915: Restrict legacy color key ioctl to pre-gen12 URL : https://patchwork.freedesktop.org/series/72026/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel:

Re: [Intel-gfx] [PATCH 1/3] drm/i915: make stolen more region centric

2020-01-14 Thread Tang, CQ
Reviewed-by: CQ Tang > -Original Message- > From: Auld, Matthew > Sent: Friday, January 3, 2020 12:00 PM > To: intel-gfx@lists.freedesktop.org > Cc: Tang, CQ ; Chris Wilson > Subject: [PATCH 1/3] drm/i915: make stolen more region centric > > From: CQ Tang > > Signed-off-by: CQ Tang

Re: [Intel-gfx] [PATCH 1/3] drm/i915: make stolen more region centric

2020-01-14 Thread Tang, CQ
> -Original Message- > From: Chris Wilson > Sent: Friday, January 3, 2020 12:29 PM > To: Auld, Matthew ; intel- > g...@lists.freedesktop.org > Cc: Tang, CQ > Subject: Re: [PATCH 1/3] drm/i915: make stolen more region centric > > Quoting Matthew Auld (2020-01-03 20:00:28) > > From: CQ

Re: [Intel-gfx] [PATCH v2 5/5] drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel

2020-01-14 Thread Lyude Paul
fwiw - I got some feedback from one of the vendors that we work with that I haven't gone through yet, but I'm hoping to figure out whether we want to trust the vbt/dpcd based off that once I do. Once we've made up the decision on that (and I send out a reroll if needed), think this is good to

[Intel-gfx] ✗ Fi.CI.BUILD: warning for Security mitigation for Intel Gen7 and Gen7.5

2020-01-14 Thread Patchwork
== Series Details == Series: Security mitigation for Intel Gen7 and Gen7.5 URL : https://patchwork.freedesktop.org/series/72022/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel:

[Intel-gfx] ✓ Fi.CI.BAT: success for Security mitigation for Intel Gen7 and Gen7.5

2020-01-14 Thread Patchwork
== Series Details == Series: Security mitigation for Intel Gen7 and Gen7.5 URL : https://patchwork.freedesktop.org/series/72022/ State : success == Summary == CI Bug Log - changes from CI_DRM_7746 -> Patchwork_16099 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Correct typo in i915_vma_compress_finish stub

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915: Correct typo in i915_vma_compress_finish stub URL : https://patchwork.freedesktop.org/series/71917/ State : success == Summary == CI Bug Log - changes from CI_DRM_7721_full -> Patchwork_16065_full

Re: [Intel-gfx] [RFC] drm/i915: Restrict legacy color key ioctl to pre-gen12

2020-01-14 Thread Chris Wilson
Quoting Matt Roper (2020-01-14 23:03:20) > On Tue, Jan 14, 2020 at 10:54:50PM +, Chris Wilson wrote: > > Quoting Chris Wilson (2020-01-14 22:47:58) > > > Quoting Matt Roper (2020-01-14 22:45:08) > > > > Since gen12 platform support isn't finalized yet, let's kill off the > > > > legacy color

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Security mitigation for Intel Gen7 and Gen7.5

2020-01-14 Thread Patchwork
== Series Details == Series: Security mitigation for Intel Gen7 and Gen7.5 URL : https://patchwork.freedesktop.org/series/72022/ State : warning == Summary == $ dim checkpatch origin/drm-tip b4809d0d433d drm/i915: Add mechanism to submit a context WA on ring submission 499c2a70065d

Re: [Intel-gfx] [RFC] drm/i915: Restrict legacy color key ioctl to pre-gen12

2020-01-14 Thread Matt Roper
On Tue, Jan 14, 2020 at 10:54:50PM +, Chris Wilson wrote: > Quoting Chris Wilson (2020-01-14 22:47:58) > > Quoting Matt Roper (2020-01-14 22:45:08) > > > Since gen12 platform support isn't finalized yet, let's kill off the > > > legacy color key ioctl for this platform; there's no userspace

Re: [Intel-gfx] [RFC] drm/i915: Restrict legacy color key ioctl to pre-gen12

2020-01-14 Thread Chris Wilson
Quoting Chris Wilson (2020-01-14 22:47:58) > Quoting Matt Roper (2020-01-14 22:45:08) > > Since gen12 platform support isn't finalized yet, let's kill off the > > legacy color key ioctl for this platform; there's no userspace today > > that can run on this platform that utilizes this legacy ioctl,

[Intel-gfx] [RFC] drm/i915: Restrict legacy color key ioctl to pre-gen12

2020-01-14 Thread Matt Roper
Since gen12 platform support isn't finalized yet, let's kill off the legacy color key ioctl for this platform; there's no userspace today that can run on this platform that utilizes this legacy ioctl, so we can safely kill it now before it becomes ABI. Color key functionality never got integrated

Re: [Intel-gfx] [RFC] drm/i915: Restrict legacy color key ioctl to pre-gen12

2020-01-14 Thread Chris Wilson
Quoting Matt Roper (2020-01-14 22:45:08) > Since gen12 platform support isn't finalized yet, let's kill off the > legacy color key ioctl for this platform; there's no userspace today > that can run on this platform that utilizes this legacy ioctl, so we can > safely kill it now before it becomes

Re: [Intel-gfx] [RFC PATCH 2/2] drm/i915/gen7: Clear all EU/L3 residual contexts

2020-01-14 Thread Chris Wilson
Quoting Akeem G Abodunrin (2020-01-14 14:51:36) > From: Prathap Kumar Valsan > > On gen7 and gen7.5 devices, there could be leftover data residuals in > EU/L3 from the retiring context. This patch introduces workaround to clear > that residual contexts, by submitting a batch buffer with

[Intel-gfx] [RFC PATCH 0/2] Security mitigation for Intel Gen7 and Gen7.5

2020-01-14 Thread Akeem G Abodunrin
Intel ID: PSIRT-TA-201910-001 CVEID: CVE-2019-14615 Summary of Vulnerability Insufficient control flow in certain data structures for some Intel(R) Processors with Intel Processor Graphics may allow an unauthenticated user to potentially enable information disclosure via

[Intel-gfx] [RFC PATCH 2/2] drm/i915/gen7: Clear all EU/L3 residual contexts

2020-01-14 Thread Akeem G Abodunrin
From: Prathap Kumar Valsan On gen7 and gen7.5 devices, there could be leftover data residuals in EU/L3 from the retiring context. This patch introduces workaround to clear that residual contexts, by submitting a batch buffer with dedicated HW context to the GPU with ring allocation for each

[Intel-gfx] [RFC PATCH 1/2] drm/i915: Add mechanism to submit a context WA on ring submission

2020-01-14 Thread Akeem G Abodunrin
From: Mika Kuoppala This patch adds framework to submit an arbitrary batchbuffer on each context switch to clear residual state for render engine on Gen7/7.5 devices. Signed-off-by: Mika Kuoppala Signed-off-by: Akeem G Abodunrin Cc: Kumar Valsan Prathap Cc: Chris Wilson Cc: Balestrieri

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gen11: Add additional pcode status values

2020-01-14 Thread Matt Roper
On Tue, Jan 14, 2020 at 09:25:44PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/gen11: Add additional pcode status values > URL : https://patchwork.freedesktop.org/series/71915/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_7721_full ->

Re: [Intel-gfx] [RFC 7/7] drm/i915/dp: Program vswing, pre-emphasis, test-pattern

2020-01-14 Thread Manasi Navare
On Fri, Dec 13, 2019 at 10:54:20PM +0530, Animesh Manna wrote: > Hi Manasi/Jani, > > Thanks for helping phy compliance design. > > Added my understanding/doubts below. > > > On 12/12/2019 5:20 AM, Manasi Navare wrote: > >Hi Animesh/Jani, > > > >Is this the right way to force a full modeset by

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gen11: Add additional pcode status values

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915/gen11: Add additional pcode status values URL : https://patchwork.freedesktop.org/series/71915/ State : success == Summary == CI Bug Log - changes from CI_DRM_7721_full -> Patchwork_16064_full Summary

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/tgl: Add Wa_1409825376 to tgl (rev5)

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add Wa_1409825376 to tgl (rev5) URL : https://patchwork.freedesktop.org/series/71853/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Add Wa_1409825376 to tgl (rev5)

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add Wa_1409825376 to tgl (rev5) URL : https://patchwork.freedesktop.org/series/71853/ State : success == Summary == CI Bug Log - changes from CI_DRM_7742 -> Patchwork_16098 Summary ---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/vbt: Rename BDB_LVDS_POWER to BDB_LFP_POWER

2020-01-14 Thread Souza, Jose
On Tue, 2020-01-14 at 20:18 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/vbt: Rename BDB_LVDS_POWER to BDB_LFP_POWER > URL : https://patchwork.freedesktop.org/series/71912/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7721_full ->

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp/tgl+: Update combo phy vswing tables

2020-01-14 Thread Souza, Jose
On Tue, 2020-01-14 at 19:12 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dp/tgl+: Update combo phy vswing tables > URL : https://patchwork.freedesktop.org/series/71909/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_7721_full ->

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/vbt: Rename BDB_LVDS_POWER to BDB_LFP_POWER

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915/vbt: Rename BDB_LVDS_POWER to BDB_LFP_POWER URL : https://patchwork.freedesktop.org/series/71912/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7721_full -> Patchwork_16063_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp/tgl+: Update combo phy vswing tables

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915/dp/tgl+: Update combo phy vswing tables URL : https://patchwork.freedesktop.org/series/71909/ State : success == Summary == CI Bug Log - changes from CI_DRM_7721_full -> Patchwork_16062_full Summary

Re: [Intel-gfx] [PATCH 3/4] drm/i915/gt: Allow temporary suspension of inflight requests

2020-01-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-01-14 18:33:07) > > On 13/01/2020 10:44, Chris Wilson wrote: > > In order to support out-of-line error capture, we need to remove the > > active request from HW and put it to one side while a worker compresses > > and stores all the details associated with that

Re: [Intel-gfx] [PATCH 3/4] drm/i915/gt: Allow temporary suspension of inflight requests

2020-01-14 Thread Tvrtko Ursulin
On 13/01/2020 10:44, Chris Wilson wrote: In order to support out-of-line error capture, we need to remove the active request from HW and put it to one side while a worker compresses and stores all the details associated with that request. (As that compression may take an arbitrary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Add a mock i915_vma to the mock_ring (rev2)

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add a mock i915_vma to the mock_ring (rev2) URL : https://patchwork.freedesktop.org/series/72005/ State : success == Summary == CI Bug Log - changes from CI_DRM_7740 -> Patchwork_16096

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/selftests: Add a mock i915_vma to the mock_ring (rev2)

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add a mock i915_vma to the mock_ring (rev2) URL : https://patchwork.freedesktop.org/series/72005/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: Clean up VBLANK callbacks in struct drm_driver (rev6)

2020-01-14 Thread Patchwork
== Series Details == Series: drm: Clean up VBLANK callbacks in struct drm_driver (rev6) URL : https://patchwork.freedesktop.org/series/71873/ State : failure == Summary == Applying: drm: Add get_scanout_position() to struct drm_crtc_helper_funcs error: corrupt patch at line 18 error: could

[Intel-gfx] ✓ Fi.CI.IGT: success for Add ops to intel_uc (rev4)

2020-01-14 Thread Patchwork
== Series Details == Series: Add ops to intel_uc (rev4) URL : https://patchwork.freedesktop.org/series/70716/ State : success == Summary == CI Bug Log - changes from CI_DRM_7721_full -> Patchwork_16061_full Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/gt: Undo partial gt-pm enabling on error paths

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915/gt: Undo partial gt-pm enabling on error paths URL : https://patchwork.freedesktop.org/series/72010/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Undo partial gt-pm enabling on error paths

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915/gt: Undo partial gt-pm enabling on error paths URL : https://patchwork.freedesktop.org/series/72010/ State : success == Summary == CI Bug Log - changes from CI_DRM_7740 -> Patchwork_16095 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Bump up CDCLK to eliminate underruns on TGL (rev4)

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915: Bump up CDCLK to eliminate underruns on TGL (rev4) URL : https://patchwork.freedesktop.org/series/71760/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7721_full -> Patchwork_16060_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/6] drm/i915: Make a copy of the ggtt view for slave plane

2020-01-14 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Make a copy of the ggtt view for slave plane URL : https://patchwork.freedesktop.org/series/71896/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7721_full -> Patchwork_16058_full

Re: [Intel-gfx] [PATCH 01/23] drm: Add get_scanout_position() to struct drm_crtc_helper_funcs

2020-01-14 Thread Yannick FERTRE
Thanks for the patch. Tested-by: Yannick Fertré BR Yannick Fertré On 1/10/20 10:21 AM, Thomas Zimmermann wrote: The new callback get_scanout_position() reads the current location of the scanout process. The operation is currentyl located in struct drm_driver,

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Re-init lspcon after HPD if lspcon probe failed (rev5)

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915: Re-init lspcon after HPD if lspcon probe failed (rev5) URL : https://patchwork.freedesktop.org/series/71314/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7739 -> Patchwork_16094

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915: Re-init lspcon after HPD if lspcon probe failed (rev5)

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915: Re-init lspcon after HPD if lspcon probe failed (rev5) URL : https://patchwork.freedesktop.org/series/71314/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h

Re: [Intel-gfx] [PATCH 19/23] drm/stm: Convert to CRTC VBLANK callbacks

2020-01-14 Thread Yannick FERTRE
Thanks for the patch. Tested-by: Yannick Fertré BR Yannick Fertré On 1/10/20 10:21 AM, Thomas Zimmermann wrote: VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert stm over. Signed-off-by: Thomas

Re: [Intel-gfx] [PATCH 23/23] drm: Cleanup VBLANK callbacks in struct drm_driver

2020-01-14 Thread Yannick FERTRE
Thanks for the patch. Tested-by: Yannick Fertré BR Yannick Fertré On 1/10/20 10:21 AM, Thomas Zimmermann wrote: All non-legacy users of VBLANK functions in struct drm_driver have been converted to use the respective interfaces in struct drm_crtc_funcs. The

Re: [Intel-gfx] [PATCH 08/23] drm/stm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-14 Thread Yannick FERTRE
Thanks for the patch. Tested-by: Yannick Fertré BR Yannick Fertré On 1/10/20 10:21 AM, Thomas Zimmermann wrote: The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert stm over.

[Intel-gfx] [CI] drm/i915/selftests: Add a mock i915_vma to the mock_ring

2020-01-14 Thread Chris Wilson
Add a i915_vma to the mock_engine/mock_ring so that the core code can always assume the presence of ring->vma. Fixes: 8ccfc20a7d56 ("drm/i915/gt: Mark ring->vma as active while pinned") Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/mock_engine.c | 17

Re: [Intel-gfx] [PATCH 09/23] drm: Remove struct drm_driver.get_scanout_position()

2020-01-14 Thread Yannick FERTRE
Thanks for the patch. Tested-by: Yannick Fertré BR Yannick Fertré On 1/10/20 10:21 AM, Thomas Zimmermann wrote: All users of struct drm_driver.get_scanout_position() have been covnerted to the respective CRTC helper function. Remove the callback from struct

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Add a mock i915_vma to the mock_ring

2020-01-14 Thread Mika Kuoppala
Chris Wilson writes: > Add a i915_vma to the mock_engine/mock_ring so that the core code can > always assume the presence of ring->vma. > > Fixes: 8ccfc20a7d56 ("drm/i915/gt: Mark ring->vma as active while pinned") > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/gt/mock_engine.c | 8

Re: [Intel-gfx] [PATCH] drm/i915/gem: Take local vma references for the parser

2020-01-14 Thread Mika Kuoppala
Chris Wilson writes: > Take and hold a reference to each of the vma (and their objects) as we > process them with the cmdparser. This stops them being freed during the > work if the GEM execbuf is interrupted and the request we expected to > keep the objects alive is incomplete. > > Fixes:

Re: [Intel-gfx] [PATCH 13/13] drm/i915/gt: Limit C-states while waiting for requests

2020-01-14 Thread Chris Wilson
Quoting Mika Kuoppala (2020-01-14 15:12:03) > Chris Wilson writes: > > > Allow the sysadmin to specify whether we should prevent the CPU from > > entering higher C-states while waiting for the CPU, in order to reduce > > s/higher/deeper > s/CPU/GPU > > > the latency of request completions and

Re: [Intel-gfx] [PATCH 13/13] drm/i915/gt: Limit C-states while waiting for requests

2020-01-14 Thread Mika Kuoppala
Chris Wilson writes: > Allow the sysadmin to specify whether we should prevent the CPU from > entering higher C-states while waiting for the CPU, in order to reduce s/higher/deeper s/CPU/GPU > the latency of request completions and so speed up client continuations. > > The target dma latency

[Intel-gfx] [PATCH] drm/i915/gt: Undo partial gt-pm enabling on error paths

2020-01-14 Thread Chris Wilson
Undo the rps/llc enabling operations if we fail to bring up the engine subsequently. For bonus paranoia, scrub the GT state along the error path. Signed-off-by: Chris Wilson Cc: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 19 +-- 1 file changed, 9 insertions(+), 10

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev5)

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915: eDP DPCD aux backlight fixes (rev5) URL : https://patchwork.freedesktop.org/series/69914/ State : success == Summary == CI Bug Log - changes from CI_DRM_7739 -> Patchwork_16093 Summary ---

Re: [Intel-gfx] [PATCH v3] drm/i915: Re-init lspcon after HPD if lspcon probe failed

2020-01-14 Thread Ville Syrjälä
On Tue, Jan 14, 2020 at 04:11:40PM +0200, Jani Nikula wrote: > On Mon, 06 Jan 2020, Kai-Heng Feng wrote: > > Hi Jani, > > > >> On Dec 24, 2019, at 16:42, Kai-Heng Feng > >> wrote: > >> > >> On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port > >> becomes useless and never

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915: eDP DPCD aux backlight fixes (rev5)

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915: eDP DPCD aux backlight fixes (rev5) URL : https://patchwork.freedesktop.org/series/69914/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel:

Re: [Intel-gfx] [PATCH 3/9] drm/i915/sdvo: Consolidate SDVO HDMI force_dvi handling

2020-01-14 Thread Jani Nikula
On Wed, 08 Jan 2020, Ville Syrjala wrote: > From: Ville Syrjälä > > Move the force_dvi check to a single function that can be called from > both mode validation and compute_config(). Note that currently we > don't call it from mode validation, but that will change soon. > > Signed-off-by: Ville

Re: [Intel-gfx] [PATCH 1/9] drm/i915/sdvo: Reduce the size of the on stack buffers

2020-01-14 Thread Jani Nikula
On Wed, 08 Jan 2020, Ville Syrjala wrote: > From: Ville Syrjälä > > The strings we want to print to the on stack buffers should > be no more than > 8 * 3 + strlen("(GET_SCALED_HDTV_RESOLUTION_SUPPORT)") + 1 = 61 > bytes. So let's shrink the buffers down to 64 bytes. > > Also switch the BUG_ON()s

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Consolidate HDMI force_dvi handling

2020-01-14 Thread Jani Nikula
On Wed, 08 Jan 2020, Ville Syrjala wrote: > From: Ville Syrjälä > > Move the force_dvi check to a single function that can be called from > both mode validation and compute_config(). > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_hdmi.c

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Validation rotated vma bounds are within the object (rev2)

2020-01-14 Thread Patchwork
== Series Details == Series: drm/i915/gt: Validation rotated vma bounds are within the object (rev2) URL : https://patchwork.freedesktop.org/series/71827/ State : success == Summary == CI Bug Log - changes from CI_DRM_7720_full -> Patchwork_16056_full

  1   2   >