[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: drop alpha_support for good in favour of force_probe

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: drop alpha_support for good in favour of force_probe URL : https://patchwork.freedesktop.org/series/72326/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7783_full -> Patchwork_16184_full ===

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/hdcp: optimizing the srm handling

2020-01-21 Thread Patchwork
== Series Details == Series: drm/hdcp: optimizing the srm handling URL : https://patchwork.freedesktop.org/series/72312/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7782_full -> Patchwork_16182_full Summary --- **F

[Intel-gfx] ✗ Fi.CI.IGT: failure for Enable second DBuf slice for ICL and TGL (rev20)

2020-01-21 Thread Patchwork
== Series Details == Series: Enable second DBuf slice for ICL and TGL (rev20) URL : https://patchwork.freedesktop.org/series/70059/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7781_full -> Patchwork_16174_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/guc: Provide mmio list to be saved/restored on engine reset

2020-01-21 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/guc: Provide mmio list to be saved/restored on engine reset URL : https://patchwork.freedesktop.org/series/72358/ State : success == Summary == CI Bug Log - changes from CI_DRM_7787 -> Patchwork_16203

[Intel-gfx] ✗ Fi.CI.BAT: failure for linux-next: manual merge of the drm tree with the drm-intel-fixes tree (rev2)

2020-01-21 Thread Patchwork
== Series Details == Series: linux-next: manual merge of the drm tree with the drm-intel-fixes tree (rev2) URL : https://patchwork.freedesktop.org/series/71725/ State : failure == Summary == Applying: linux-next: manual merge of the drm tree with the drm-intel-fixes tree Using index info to r

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ehl: Ensure that the DDI selection MUX is programmed correctly

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Ensure that the DDI selection MUX is programmed correctly URL : https://patchwork.freedesktop.org/series/72357/ State : success == Summary == CI Bug Log - changes from CI_DRM_7787 -> Patchwork_16202

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/guc: Provide mmio list to be saved/restored on engine reset

2020-01-21 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/guc: Provide mmio list to be saved/restored on engine reset URL : https://patchwork.freedesktop.org/series/72358/ State : warning == Summary == $ dim checkpatch origin/drm-tip 79f1d9d3e751 drm/i915/guc: Provide mmio list to b

[Intel-gfx] linux-next: manual merge of the drm tree with the drm-intel-fixes tree

2020-01-21 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/i915/i915_gem_gtt.c between commit: ecc4d2a52df6 ("drm/i915/userptr: fix size calculation") from the drm-intel-fixes tree and commit: 2c86e55d2ab5 ("drm/i915/gtt: split up i915_gem_gtt") from the drm tr

[Intel-gfx] [CI 1/2] drm/i915/guc: Provide mmio list to be saved/restored on engine reset

2020-01-21 Thread Fernando Pacheco
The driver must provide GuC with a list of mmio registers that should be saved/restored during a GuC-based engine reset. We provide a minimal set of registers that should get things working and extend as needed. v2: rebase and comment to explain why mmio list is kept sorted Signed-off-by: Fernand

[Intel-gfx] [CI 2/2] HAX: force enable_guc=2

2020-01-21 Thread Fernando Pacheco
Signed-off-by: Fernando Pacheco --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 947d0a38fa3c..4d17235c33bd 100644 --- a/drivers/gpu/drm/i915/i915_params.h +++

[Intel-gfx] [PATCH] drm/i915/ehl: Ensure that the DDI selection MUX is programmed correctly

2020-01-21 Thread Vivek Kasireddy
Perhaps in some cases the BIOS/GOP or other firmware may turn on PHY A but may not program the MUX correctly. Therefore, re-program PHY A if it is determined after reading the VBT that the value programmed for the MUX bit does not match the expected value. Cc: Matt Roper Signed-off-by: Vivek Kasi

Re: [Intel-gfx] [PATCH libdrm] intel: drm_intel_bo_gem_create_from_* on platforms w/o HW tiling

2020-01-21 Thread Imre Deak
On Tue, Jan 21, 2020 at 10:40:48PM +, Eric Engestrom wrote: > On Monday, 2020-01-20 18:43:43 +0200, Imre Deak wrote: > > Platforms without a HW detiler doesn't support the get_tiling IOCTL. > > Fix the drm_intel_bo_gem_create_from_* functions assuming the default > > no-tiling, no-swizzling set

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Clear the GGTT_WRITE bit on unbinding the vma

2020-01-21 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Clear the GGTT_WRITE bit on unbinding the vma URL : https://patchwork.freedesktop.org/series/72355/ State : success == Summary == CI Bug Log - changes from CI_DRM_7786 -> Patchwork_16201

Re: [Intel-gfx] [PATCH libdrm] intel: drm_intel_bo_gem_create_from_* on platforms w/o HW tiling

2020-01-21 Thread Eric Engestrom
On Monday, 2020-01-20 18:43:43 +0200, Imre Deak wrote: > Platforms without a HW detiler doesn't support the get_tiling IOCTL. > Fix the drm_intel_bo_gem_create_from_* functions assuming the default > no-tiling, no-swizzling setting for the GEM buffer in this case. > > Signed-off-by: Imre Deak > -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Clear the GGTT_WRITE bit on unbinding the vma

2020-01-21 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Clear the GGTT_WRITE bit on unbinding the vma URL : https://patchwork.freedesktop.org/series/72355/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2068495785db drm/i915: Clear the GGTT_WRITE bit on unbinding the

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Don't show the blank process name for internal/simulated errors

2020-01-21 Thread Chris Wilson
Quoting Chris Wilson (2020-01-21 22:24:43) > For a simulated preemption reset, we don't populate the request and so > do not fill in the guilty context name. > > [ 79.991294] i915 :00:02.0: GPU HANG: ecode 9:1:e757fefe, in [0] > > Just don't mention the empty string in the logs! > > Fixes

[Intel-gfx] [PATCH 3/7] drm/i915: Don't show the blank process name for internal/simulated errors

2020-01-21 Thread Chris Wilson
For a simulated preemption reset, we don't populate the request and so do not fill in the guilty context name. [ 79.991294] i915 :00:02.0: GPU HANG: ecode 9:1:e757fefe, in [0] Just don't mention the empty string in the logs! Fixes: 742379c0c400 ("drm/i915: Start chopping up the GPU error

[Intel-gfx] [PATCH 5/7] drm/i915: Tighten atomicity of i915_active_acquire vs i915_active_release

2020-01-21 Thread Chris Wilson
As we use a mutex to serialise the first acquire (as it may be a lengthy operation), but only an atomic decrement for the release, we have to be careful in case a second thread races and completes both acquire/release as the first finishes its acquire. Fixes: c9ad602feabe ("drm/i915: Split i915_ac

[Intel-gfx] [PATCH 4/7] drm/i915: Mark the removal of the i915_request from the sched.link

2020-01-21 Thread Chris Wilson
Keep the rq->fence.flags consistent with the status of the rq->sched.link, and clear the associated bits when decoupling the link on retirement (as we may wish to inspect those flags independent of other state). Fixes: 32ff621fd744 ("drm/i915/gt: Allow temporary suspension of inflight requests")

[Intel-gfx] [PATCH 2/7] drm/i915/execlists: Reclaim the hanging virtual request

2020-01-21 Thread Chris Wilson
If we encounter a hang on a virtual engine, as we process the hang the request may already have been moved back to the virtual engine (we are processing the hang on the physical engine). We need to reclaim the request from the virtual engine so that the locking is consistent and local to the real e

[Intel-gfx] [PATCH 7/7] drm/i915/gt: Yield the timeslice if waiting on a semaphore

2020-01-21 Thread Chris Wilson
If we find ourselves waiting on a MI_SEMAPHORE_WAIT, either within the user batch or in our own preamble, the engine raises a GT_WAIT_ON_SEMAPHORE interrupt. We can unmask that interrupt and so respond to a semaphore wait by yielding the timeslice, if we have another context to yield to! The only

[Intel-gfx] [PATCH 1/7] drm/i915: Clear the GGTT_WRITE bit on unbinding the vma

2020-01-21 Thread Chris Wilson
While we do flush writes to the vma before unbinding (to make sure they go through the right detiling register), we may also be concurrently poking at the GGTT_WRITE bit from set-domain, as we mark all GGTT vma associated with an object. We know this is for another vma, as we are currently unbind t

[Intel-gfx] [PATCH 6/7] drm/i915/gt: Acquire ce->active before ce->pin_count/ce->pin_mutex

2020-01-21 Thread Chris Wilson
<0> [198.668822] gem_exec-12460 193899010us : timeline_advance: timeline_advance:387 GEM_BUG_ON(!atomic_read(&tl->pin_count)) <0> [198.668859] - <4> [198.669619] [ cut here ] <2> [198.669621] kernel BUG at drivers/gpu/drm/i915/gt/inte

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: set fail-safe mode if EDID corrupt

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915/dp: set fail-safe mode if EDID corrupt URL : https://patchwork.freedesktop.org/series/72311/ State : success == Summary == CI Bug Log - changes from CI_DRM_7781_full -> Patchwork_16179_full Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Nuke intel_atomic_lock/serialize_global_state() (rev2)

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: Nuke intel_atomic_lock/serialize_global_state() (rev2) URL : https://patchwork.freedesktop.org/series/72242/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7786 -> Patchwork_16200 Summa

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Hotplug cleanups (rev2)

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: Hotplug cleanups (rev2) URL : https://patchwork.freedesktop.org/series/72348/ State : success == Summary == CI Bug Log - changes from CI_DRM_7786 -> Patchwork_16199 Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.IGT: success for dumb buffer max size available

2020-01-21 Thread Patchwork
== Series Details == Series: dumb buffer max size available URL : https://patchwork.freedesktop.org/series/72309/ State : success == Summary == CI Bug Log - changes from CI_DRM_7781_full -> Patchwork_16178_full Summary --- **SUCCESS*

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Update to GuC FW v40 (rev3)

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update to GuC FW v40 (rev3) URL : https://patchwork.freedesktop.org/series/72032/ State : success == Summary == CI Bug Log - changes from CI_DRM_7786 -> Patchwork_16198 Summary --- **SUCCESS

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Update to GuC FW v40 (rev3)

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update to GuC FW v40 (rev3) URL : https://patchwork.freedesktop.org/series/72032/ State : warning == Summary == $ dim checkpatch origin/drm-tip 31a752e6b82c drm/i915/guc: Update to GuC FW v40 52f57a04ee86 Hack for CI: enable HuC loading by default -:8

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: conversion to new drm logging macros.

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: conversion to new drm logging macros. URL : https://patchwork.freedesktop.org/series/72350/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7786 -> Patchwork_16196 Summary --- **F

[Intel-gfx] ✗ Fi.CI.BUILD: failure for conversion to struct drm_device logging macros.

2020-01-21 Thread Patchwork
== Series Details == Series: conversion to struct drm_device logging macros. URL : https://patchwork.freedesktop.org/series/72349/ State : failure == Summary == Applying: drm/i915/dsi: conversion to struct drm_device log macros Applying: drm/i915/ddi: convert to struct drm_device log macros. A

[Intel-gfx] [PATCH v2 09/11] drm/i915: Turn intel_digital_port_connected() in a vfunc

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä Let's get rid of the platform if ladders in intel_digital_port_connected() and make it a vfunc. Now the if ladders are at the encoder initialization which makes them a bit less convoluted. v2: Add forward decl for intel_encoder in intel_tc.h Signed-off-by: Ville Syrjälä ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: conversion to new drm logging macros.

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: conversion to new drm logging macros. URL : https://patchwork.freedesktop.org/series/72350/ State : warning == Summary == $ dim checkpatch origin/drm-tip 54f3b2457681 drm/i915/atomic: use struct drm_device logging macros 565e4c05e932 drm/i915/bios: conver

Re: [Intel-gfx] [PATCH v15 3/5] drm/i915: Introduce parameterized DBUF_CTL

2020-01-21 Thread Ville Syrjälä
On Mon, Jan 20, 2020 at 02:21:01PM +0200, Stanislav Lisovskiy wrote: > Now start using parameterized DBUF_CTL instead > of hardcoded, this would allow shorter access > functions when reading or storing entire state. > > Tried to implement it in a MMIO_PIPE manner, however > DBUF_CTL1 address is hi

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/display: convert to struct drm_device logging macros.

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915/display: convert to struct drm_device logging macros. URL : https://patchwork.freedesktop.org/series/72351/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/genera

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Hotplug cleanups

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: Hotplug cleanups URL : https://patchwork.freedesktop.org/series/72348/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h HDRTEST drivers/gpu/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add display engine uncore helpers (rev3)

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: add display engine uncore helpers (rev3) URL : https://patchwork.freedesktop.org/series/72331/ State : success == Summary == CI Bug Log - changes from CI_DRM_7786 -> Patchwork_16193 Summary ---

[Intel-gfx] [CI v2 2/2] Hack for CI: enable HuC loading by default

2020-01-21 Thread John . C . Harrison
From: John Harrison --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 947d0a38fa3c..b53dee57f69b 100644 --- a/drivers/gpu/drm/i915/i915_params.h +++ b/drivers/g

[Intel-gfx] [CI v2 1/2] drm/i915/guc: Update to GuC FW v40

2020-01-21 Thread John . C . Harrison
From: Matthew Brost The GuC major version has jumped from 35 to 40. This is because this FW includes a significant re-write of the API that completely breaks backwards compatibility for command submission. This patch is sufficient to enable loading of the GuC and hence authentication of the HuC.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display engine uncore helpers (rev3)

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: add display engine uncore helpers (rev3) URL : https://patchwork.freedesktop.org/series/72331/ State : warning == Summary == $ dim checkpatch origin/drm-tip 50c85a55b8d5 drm/i915: add display engine uncore helpers -:35: WARNING:FILE_PATH_CHANGES: added, m

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Clear the GGTT_WRITE bit on unbinding the vma

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: Clear the GGTT_WRITE bit on unbinding the vma URL : https://patchwork.freedesktop.org/series/72340/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7786 -> Patchwork_16192 Summary --

Re: [Intel-gfx] [PATCH libdrm] intel: drm_intel_bo_gem_create_from_* on platforms w/o HW tiling

2020-01-21 Thread Emil Velikov
On Mon, 20 Jan 2020 at 16:43, Imre Deak wrote: > > Platforms without a HW detiler doesn't support the get_tiling IOCTL. > Fix the drm_intel_bo_gem_create_from_* functions assuming the default > no-tiling, no-swizzling setting for the GEM buffer in this case. > > Signed-off-by: Imre Deak Seems li

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Global state rework (rev2)

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: Global state rework (rev2) URL : https://patchwork.freedesktop.org/series/72301/ State : success == Summary == CI Bug Log - changes from CI_DRM_7786 -> Patchwork_16191 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Update to GuC FW v40

2020-01-21 Thread John Harrison
On 1/21/2020 10:29, Daniele Ceraolo Spurio wrote: On 1/15/20 12:37 PM, john.c.harri...@intel.com wrote: From: Michal Wajdeczko v1 was from Matt, now it is from Michal? Grrr. That would be git being annoying. I squashed Michal's update on top and it must have somehow decided to use his patch

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Update to GuC FW v40

2020-01-21 Thread Daniele Ceraolo Spurio
On 1/15/20 12:37 PM, john.c.harri...@intel.com wrote: From: Michal Wajdeczko v1 was from Matt, now it is from Michal? The GuC major version has jumped from 35 to 40. This is because this FW includes a significant re-write of the API that completely breaks backwards compatibility for comm

Re: [Intel-gfx] [PATCH v5 01/10] capabilities: introduce CAP_PERFMON to kernel and user space

2020-01-21 Thread Alexey Budankov
On 21.01.2020 20:55, Alexei Starovoitov wrote: > On Tue, Jan 21, 2020 at 9:31 AM Alexey Budankov > wrote: >> >> >> On 21.01.2020 17:43, Stephen Smalley wrote: >>> On 1/20/20 6:23 AM, Alexey Budankov wrote: Introduce CAP_PERFMON capability designed to secure system performance moni

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Global state rework (rev2)

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: Global state rework (rev2) URL : https://patchwork.freedesktop.org/series/72301/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6ee8aa846aab drm/i915: Polish WM_LINETIME register stuff a5c714cbc1b1 drm/i915: Move linetime wms into the crtc

Re: [Intel-gfx] [PATCH v3] drm/i915/execlists: Reclaim the hanging virtual request

2020-01-21 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-01-21 17:43:37) > > On 21/01/2020 17:32, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-01-21 17:19:52) > >> > >> On 21/01/2020 14:07, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2020-01-21 13:55:29) > > > On 21/01/2020 13:04, Chris Wilson wr

Re: [Intel-gfx] [PATCH v3] drm/i915/execlists: Reclaim the hanging virtual request

2020-01-21 Thread Tvrtko Ursulin
On 21/01/2020 17:32, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-01-21 17:19:52) On 21/01/2020 14:07, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-01-21 13:55:29) On 21/01/2020 13:04, Chris Wilson wrote: + GEM_BUG_ON(!reset_in_progress(&engine->execlists)); + +

Re: [Intel-gfx] [PATCH] drm/i915: Mark the removal of the i915_request from the sched.link

2020-01-21 Thread Tvrtko Ursulin
On 20/01/2020 20:27, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2020-01-20 19:47:08) >> >> On 20/01/2020 17:57, Chris Wilson wrote: >>> Keep the rq->fence.flags consistent with the status of the >>> rq->sched.link, and clear the associated bits when decoupling the link >>> on retirement (as we

Re: [Intel-gfx] [PATCH v3] drm/i915/execlists: Reclaim the hanging virtual request

2020-01-21 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-01-21 17:19:52) > > On 21/01/2020 14:07, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-01-21 13:55:29) > >> > >> > >> On 21/01/2020 13:04, Chris Wilson wrote: > >>> + GEM_BUG_ON(!reset_in_progress(&engine->execlists)); > >>> + > >>> + /*

Re: [Intel-gfx] [PATCH v5 01/10] capabilities: introduce CAP_PERFMON to kernel and user space

2020-01-21 Thread Alexey Budankov
On 21.01.2020 17:43, Stephen Smalley wrote: > On 1/20/20 6:23 AM, Alexey Budankov wrote: >> >> Introduce CAP_PERFMON capability designed to secure system performance >> monitoring and observability operations so that CAP_PERFMON would assist >> CAP_SYS_ADMIN capability in its governing role for pe

Re: [Intel-gfx] [PATCH] drm/i915: drop alpha_support for good in favour of force_probe

2020-01-21 Thread Vivi, Rodrigo
On Jan 21, 2020, at 4:01 AM, Joonas Lahtinen mailto:joonas.lahti...@linux.intel.com>> wrote: Quoting Jani Nikula (2020-01-21 12:30:20) It's been a long enough transition period since the DRM_I915_FORCE_PROBE config and i915.force_probe module parameter were introduced in commit 7ef5ef5cdead ("d

Re: [Intel-gfx] [PATCH v5 01/10] capabilities: introduce CAP_PERFMON to kernel and user space

2020-01-21 Thread Stephen Smalley
On 1/20/20 6:23 AM, Alexey Budankov wrote: Introduce CAP_PERFMON capability designed to secure system performance monitoring and observability operations so that CAP_PERFMON would assist CAP_SYS_ADMIN capability in its governing role for perf_events, i915_perf and other performance monitoring an

[Intel-gfx] [PATCH 1/6] drm/i915/dsi: conversion to struct drm_device log macros

2020-01-21 Thread Wambui Karuga
This converts the more straightforward instances of the printk based logging macros with the struct drm_device based logging macros. This transformation was achieved using coccinelle and the following script for matching an existing struct drm_i915_private device: @rule1@ identifier fn, T; @@ fn(.

[Intel-gfx] [PATCH 3/6] drm/i915/power: convert to struct drm_device macros in display/intel_display_power.c

2020-01-21 Thread Wambui Karuga
Converts various instances of the printk based logging macros in i915/display/intel_display_power.c to the struct drm_device based logging macros using the following coccinelle script: @rule1@ identifier fn, T; @@ fn(...,struct drm_i915_private *T,...) { <+... ( -DRM_INFO( +drm_info(&T->drm, ...)

[Intel-gfx] [PATCH v2 5/5] drm/i915/cdclk: use new struct drm_device logging macros

2020-01-21 Thread Wambui Karuga
Converts instances of the printk based debugging macros with the new struct drm_device based logging macros in i915/display/intel_cdclk.c. The conversion is achieved using the following coccinelle script that transforms based on the existence of a struct drm_i915_private device in the function: @r

[Intel-gfx] [PATCH v2 4/5] drm/i915/bw: convert to drm_device based logging macros

2020-01-21 Thread Wambui Karuga
This replaces the printk based logging macros with the struct drm_based macros in i915/display/intel_bw.c This transformation was achieved by using the following coccinelle script that matches based on the existence of a struct drm_i915_private device in the functions: @rule1@ identifier fn, T; @@

[Intel-gfx] [PATCH] drm/i915/display: convert to struct drm_device logging macros.

2020-01-21 Thread Wambui Karuga
This patch converts various instances of the printk based logging macros in drm/i915/display/intel_display.c to the new struct drm_device based logging macros. In some instances, this involves extracting the struct drm_i915_private device from various intel types and using it in the macros. Signed

[Intel-gfx] [PATCH 6/6] drm/i915/hdcp: conversion to struct drm_device based logging macros

2020-01-21 Thread Wambui Karuga
Converts various instances of the printk based logging macros in i915/display/intel_hdcp.c with the struct drm_device based macros using coccinelle. The script matches based on the existence of an existing struct drm_i915_private device: @rule1@ identifier fn, T; @@ fn(...,struct drm_i915_private

[Intel-gfx] [PATCH 4/6] drm/i915/dp: conversion to struct drm_device logging macros.

2020-01-21 Thread Wambui Karuga
This converts various instances of printk based logging macros in i915/display/intel_dp.c with the new struct drm_device based logging macros using the following coccinelle script: @rule1@ identifier fn, T; @@ fn(...,struct drm_i915_private *T,...) { <+... ( -DRM_INFO( +drm_info(&T->drm, ...) | -D

[Intel-gfx] [PATCH v2 1/5] drm/i915/atomic: use struct drm_device logging macros

2020-01-21 Thread Wambui Karuga
Convert to the new struct drm_based logging macros to replace the printk based macros in i915/display/intel_atomic_plane.c. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH v2 3/5] drm/i915/audio: convert to struct drm_device logging macros.

2020-01-21 Thread Wambui Karuga
Converts the printk based logging macros in i915/display/intel_audio.c to the struct drm_device based logging macros. This transformation was achieved using the following coccinelle script that matches the existence of the struct drm_i915_private device: @rule1@ identifier fn, T; @@ fn(struct drm

[Intel-gfx] [PATCH 2/6] drm/i915/ddi: convert to struct drm_device log macros.

2020-01-21 Thread Wambui Karuga
This patch converts various instances of the printk based logging macros into the struct drm_device based macros. This was achieved using the following coccinelle script for matching existing struct drm_i915_private devices: @rule1@ identifier fn, T; @@ fn(...,struct drm_i915_private *T,...) { <+.

[Intel-gfx] [PATCH v2 2/5] drm/i915/bios: convert to struct drm_device logging macros.

2020-01-21 Thread Wambui Karuga
This replaces the printk based logging macros with the struct drm_device based logging macros. This conversion was achieved using the following coccinelle script that transforms based on the existence of a struct drm_i915_private device: @rule1@ identifier fn, T; @@ fn(struct drm_i915_private *T,.

[Intel-gfx] [PATCH v2 0/5] drm/i915: conversion to new drm logging macros.

2020-01-21 Thread Wambui Karuga
This series continues the conversion to the new struct drm_device based logging macros in various files in drm/i915. These patches were achieved both using coccinelle and manually. v2: rebase patches onto drm-tip to fix merge conflict in v1 series. Wambui Karuga (5): drm/i915/atomic: use struct

[Intel-gfx] [PATCH 5/6] drm/i915/opregion: conversion to struct drm_device logging macros.

2020-01-21 Thread Wambui Karuga
This converts various instances of the printk based logging macros in i915/display/intel_opregion.c with the new struct drm_device based logging macros using the following coccinelle script: @rule1@ identifier fn, T; @@ fn(...,struct drm_i915_private *T,...) { <+... ( -DRM_INFO( +drm_info(&T->drm,

[Intel-gfx] [PATCH 0/6] conversion to struct drm_device logging macros.

2020-01-21 Thread Wambui Karuga
This series continues the ongoing conversion to the new struct drm_device based logging macros for debug in i915. This series was done using the coccinelle script: @rule1@ identifier fn, T; @@ fn(...,struct drm_i915_private *T,...) { <+... ( -DRM_INFO( +drm_info(&T->drm, ...) | -DRM_ERROR( +drm_er

Re: [Intel-gfx] [PATCH v3] drm/i915/execlists: Reclaim the hanging virtual request

2020-01-21 Thread Tvrtko Ursulin
On 21/01/2020 14:07, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-01-21 13:55:29) On 21/01/2020 13:04, Chris Wilson wrote: + GEM_BUG_ON(!reset_in_progress(&engine->execlists)); + + /* + * An unsubmitted request along a virtual engine will +

[Intel-gfx] [PATCH 07/11] drm/i915/dvo: Mark TMDS DVO connectors as polled

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä All the TMDS DVO chips have a sensible looking .detect(). Let's poll them. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dvo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dvo.c b/drivers/gpu/drm/i915/displa

[Intel-gfx] [PATCH 09/11] drm/i915: Turn intel_digital_port_connected() in a vfunc

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä Let's get rid of the platform if ladders in intel_digital_port_connected() and make it a vfunc. Now the if ladders are at the encoder initialization which makes them a bit less convoluted. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 19

[Intel-gfx] [PATCH 08/11] drm/i915: Sprinkle missing commas

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä Add the missing comma after the last initialized element of the hpd[] arrays. Best not give people bad ideas. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_irq.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH 10/11] drm/i915: Stash hpd status bits under dev_priv

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä Instead of constnantly having to figure out which hpd status bit array to use let's store them under dev_priv. Should perhaps take this further and stash even more stuff to make the hpd handling more abstract yet. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_

[Intel-gfx] [PATCH 11/11] drm/i915: Use stashed away hpd isr bits in intel_digital_port_connected()

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä Get rid of several platform specific variants of intel_digital_port_connected() and just use the ISR bits we've stashed away. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 16 ++- drivers/gpu/drm/i915/display/intel_dp.c | 121 ++--

[Intel-gfx] [PATCH 02/11] drm/i915: Introduce intel_connector_hpd_pin()

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä Simplify the hotplug code connector->encoder->hpd_pin handling by introducing a helper for exactly this purpose. In the helper we can neatly deal with the potential lack of an attached encoder on fresh MST connectors leaving the rest of the hpd code oblivious to such details.

[Intel-gfx] [PATCH 06/11] drm/i915: Mark ns2501 as LVDS without a fixed mode

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä ns2501 has a builtin scaler so it doesn't need a fixed mode, but let's still mark it as LVDS instead of TMDS/DVI to make life less confusing. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dvo.c | 13 - 1 file changed, 8 insertions(+), 5 del

[Intel-gfx] [PATCH 05/11] drm/i915: Mark all HPD capabled connectors as such

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä Currently we only set the DRM_CONNECTOR_POLL_{DISCONNECT,CONNECT} bits in intel_connector->polled (the base setting), leading to some confusing looking code to reset drm_connector->polled (the actual setting) to DRM_CONNECTOR_POLL_HPD. Let's set intel_connector->polled = DRM_C

[Intel-gfx] [PATCH 03/11] drm/i915/crt: Configure connector->polled and encoder->hpd_pin consistently

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä Let's make sure encoder->hpd_pin and connector->polled are mirror images of each other (when we want to use polling). The other potentially polled connectors (sdvo and tv) already get this right. Also nuke the rudundant force_hotplug_required initialization (the thing is kzal

[Intel-gfx] [PATCH 04/11] drm/i915/hpd: Replace the loop-within-loop with two independent loops

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä No point in looping over all connectors for each hpd pin. Just loop over each connector first and deal with each one's hpd pin. Then loop over all the hpd pins to mark them as enabled again. Also get rid of the MST special case as MST encoders simply don't have a HPD pin and

[Intel-gfx] [PATCH 01/11] drm/i915: Prefer intel_connector over drm_connector in hotplug code

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä Replace the drm_connector loops with intel_connector loops to streamline the code. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_hotplug.c | 83 +--- 1 file changed, 38 insertions(+), 45 deletions(-) diff --git a/drivers/gpu/drm/i915/d

[Intel-gfx] [PATCH 00/11] drm/i915: Hotplug cleanups

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä Improve a bunch of stuff around encoder->hpd_pin and connector->polled. Ville Syrjälä (11): drm/i915: Prefer intel_connector over drm_connector in hotplug code drm/i915: Introduce intel_connector_hpd_pin() drm/i915/crt: Configure connector->polled and encoder->hpd_pin

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Clean up VBLANK callbacks in struct drm_driver (rev8)

2020-01-21 Thread Jani Nikula
On Tue, 21 Jan 2020, Thomas Zimmermann wrote: > Hi > > Am 21.01.20 um 10:25 schrieb Jani Nikula: >> >> Thomas, please fix the sparse/build warnings. >> >> BR, >> Jani. >> >> >> On Mon, 20 Jan 2020, Patchwork wrote: >>> == Series Details == >>> >>> Series: drm: Clean up VBLANK callbacks in str

Re: [Intel-gfx] [PATCH] drm/i915/dp: debug log max vswing and pre-emphasis

2020-01-21 Thread Jani Nikula
On Tue, 21 Jan 2020, Ville Syrjälä wrote: > On Fri, Jan 17, 2020 at 05:02:35PM +0200, Jani Nikula wrote: >> Provide slightly more debugging help. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Ville Syrjälä Pushed to dinq, thanks for the review. BR, Jani. > >> --- >> drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Use intel_attached_encoder()

2020-01-21 Thread Juha-Pekka Heikkila
Reviewed-by: Juha-Pekka Heikkila On 4.12.2019 20.05, Ville Syrjala wrote: From: Ville Syrjälä It's easy to confuse the drm_connector->encoder (legacy state adjusted during modeset) and intel_connector->encoder (the statically (sans. MST) attached encoder of the connector). For the latter let'

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: add display engine uncore helpers (rev2)

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: add display engine uncore helpers (rev2) URL : https://patchwork.freedesktop.org/series/72331/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7783 -> Patchwork_16190 Summary ---

[Intel-gfx] [PATCH] drm/i915: Clear the GGTT_WRITE bit on unbinding the vma

2020-01-21 Thread Chris Wilson
While we do flush writes to the vma before unbinding (to make sure they go through the right detiling register), we may also be concurrently poking at the GGTT_WRITE bit from set-domain, as we mark all GGTT vma associated with an object. We know this is for another vma, as we are currently unbind t

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display engine uncore helpers (rev2)

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: add display engine uncore helpers (rev2) URL : https://patchwork.freedesktop.org/series/72331/ State : warning == Summary == $ dim checkpatch origin/drm-tip 21a0a18251df drm/i915: add display engine uncore helpers -:35: WARNING:FILE_PATH_CHANGES: added, m

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Reclaim hanging virtual request (rev4)

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Reclaim hanging virtual request (rev4) URL : https://patchwork.freedesktop.org/series/72320/ State : success == Summary == CI Bug Log - changes from CI_DRM_7783 -> Patchwork_16189 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Mark the removal of the i915_request from the sched.link

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: Mark the removal of the i915_request from the sched.link URL : https://patchwork.freedesktop.org/series/72302/ State : success == Summary == CI Bug Log - changes from CI_DRM_7781_full -> Patchwork_16176_full ===

Re: [Intel-gfx] [PATCH xf86-video-intel] sna: Use correct struct sna in sna_mode_wakeup

2020-01-21 Thread Thomas Preston
On 21/01/2020 11:27, Chris Wilson wrote: > Quoting Thomas Preston (2020-01-21 10:28:58) >> When deciding if we should defer_vblanks we should reference the event's >> struct sna, rather than the caller's struct sna. In order to do this, we >> must grab a new struct sna for each event in the buffer.

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Rename conn_to_dig_port() to intel_attached_dig_port()

2020-01-21 Thread Juha-Pekka Heikkila
Reviewed-by: Juha-Pekka Heikkila On 4.12.2019 20.05, Ville Syrjala wrote: From: Ville Syrjälä Use the standard naming convention and rename conn_to_dig_port() to intel_attached_dig_port(). @@ @@ - conn_to_dig_port + intel_attached_dig_port (...) { ... } @@ expression C; @@ - conn_to

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Use intel_attached_dp() instead of hand rolling it

2020-01-21 Thread Juha-Pekka Heikkila
Reviewed-by: Juha-Pekka Heikkila On 4.12.2019 20.05, Ville Syrjala wrote: From: Ville Syrjälä Replace the hand rolled intel_attached_dp() with the real thing. @@ identifier F !~ "^intel_attached_dp$"; expression C; @@ F(...) { <... - enc_to_intel_dp(intel_attached_encoder(C)) + intel_attache

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't show the blank process name for internal/simulated errors

2020-01-21 Thread Patchwork
== Series Details == Series: drm/i915: Don't show the blank process name for internal/simulated errors URL : https://patchwork.freedesktop.org/series/72337/ State : success == Summary == CI Bug Log - changes from CI_DRM_7783 -> Patchwork_16188 =

Re: [Intel-gfx] [PATCH] drm/i915/dp: debug log max vswing and pre-emphasis

2020-01-21 Thread Ville Syrjälä
On Fri, Jan 17, 2020 at 05:02:35PM +0200, Jani Nikula wrote: > Provide slightly more debugging help. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_dp.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git

Re: [Intel-gfx] [PATCH 1/2] drm: support feature masks in drm_core_check_feature()

2020-01-21 Thread Ville Syrjälä
On Tue, Jan 21, 2020 at 12:53:30PM +0200, Jani Nikula wrote: > Allow a mask of features to be passed to drm_core_check_feature(). All > features in the mask are required. > > Signed-off-by: Jani Nikula > --- > include/drm/drm_drv.h | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(

Re: [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers

2020-01-21 Thread Chris Wilson
Quoting Jani Nikula (2020-01-21 13:58:08) > On Tue, 21 Jan 2020, Chris Wilson wrote: > > Quoting Jani Nikula (2020-01-21 11:39:15) > >> Add convenience helpers for the most common uncore operations with > >> struct drm_i915_private * as context rather than struct intel_uncore *. > >> > >> The goa

Re: [Intel-gfx] [PATCH v3] drm/i915/execlists: Reclaim the hanging virtual request

2020-01-21 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-01-21 13:55:29) > > > On 21/01/2020 13:04, Chris Wilson wrote: > > + GEM_BUG_ON(!reset_in_progress(&engine->execlists)); > > + > > + /* > > + * An unsubmitted request along a virtual engine will > > + * remain on the a

[Intel-gfx] [PATCH v2 16/17] drm/i915: Convert cdclk to global state

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä Let's convert cdclk_state to be a proper global state. That allows us to use the regular atomic old vs. new state accessor, hopefully making the code less confusing. We do have to deal with a few more error cases in case the cdclk state duplication fails. But so be it. v2: F

Re: [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers

2020-01-21 Thread Jani Nikula
On Tue, 21 Jan 2020, Chris Wilson wrote: > Quoting Jani Nikula (2020-01-21 11:39:15) >> Add convenience helpers for the most common uncore operations with >> struct drm_i915_private * as context rather than struct intel_uncore *. >> >> The goal is to replace all instances of I915_READ(), >> I915_

Re: [Intel-gfx] [PATCH] drm/i915: Don't show the blank process name for internal/simulated errors

2020-01-21 Thread Mika Kuoppala
Chris Wilson writes: > For a simulated preemption reset, we don't populate the request and so > do not fill in the guilty context name. > > [ 79.991294] i915 :00:02.0: GPU HANG: ecode 9:1:e757fefe, in [0] > > Just don't mention the empty string in the logs! > > Fixes: 742379c0c400 ("drm/i9

  1   2   >