== Series Details ==
Series: drm/i915: Fix modeset locks in sanitize_watermarks()
URL : https://patchwork.freedesktop.org/series/72424/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7799_full -> Patchwork_16220_full
== Series Details ==
Series: series starting with [1/4] drm/i915: Check i915_active wait status
after flushing
URL : https://patchwork.freedesktop.org/series/72417/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7799_full -> Patchwork_16218_full
== Series Details ==
Series: drm/i915/perf: Fix OA context id overlap with idle context id
URL : https://patchwork.freedesktop.org/series/72505/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7806 -> Patchwork_16247
Summary
== Series Details ==
Series: drm/i915/perf: Fix OA context id overlap with idle context id
URL : https://patchwork.freedesktop.org/series/72505/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
481e30922e7f drm/i915/perf: Fix OA context id overlap with idle context id
-:46:
== Series Details ==
Series: series starting with [1/2] drm/i915: Check activity on i915_vma after
confirming pin_count==0
URL : https://patchwork.freedesktop.org/series/72497/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7806 -> Patchwork_16246
On 2020-01-22 at 16:56:06 +0200, Jani Nikula wrote:
> On Wed, 22 Jan 2020, Ramalingam C wrote:
> > On 2020-01-21 at 14:15:57 +0200, Jani Nikula wrote:
> >> On Tue, 21 Jan 2020, Ramalingam C wrote:
> >> > On 2020-01-20 at 11:19:54 +0530, Anshuman Gupta wrote:
> >> >> Content Protection property
== Series Details ==
Series: drm: Release filp before global lock (rev2)
URL : https://patchwork.freedesktop.org/series/72408/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7806 -> Patchwork_16245
Summary
---
== Series Details ==
Series: drm/i915: Wait on vma activity before taking the mutex
URL : https://patchwork.freedesktop.org/series/72495/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7806 -> Patchwork_16244
Summary
== Series Details ==
Series: drm/i915: Check activity on i915_vma after confirming pin_count==0
URL : https://patchwork.freedesktop.org/series/72491/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7806 -> Patchwork_16243
== Series Details ==
Series: series starting with [1/3] drm/dp: Include the AUX CH name in the debug
messages
URL : https://patchwork.freedesktop.org/series/72484/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7806 -> Patchwork_16242
== Series Details ==
Series: drm/i915/gem: fix null pointer dereference on vm (rev2)
URL : https://patchwork.freedesktop.org/series/72482/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7805 -> Patchwork_16241
Summary
Engine context pinned in perf OA was set to same context id as
the idle context. Set the context id to an unused value.
Clear the sw context id field in lrc descriptor before ORing with
ce->tag (Chris)
Fixes: https://gitlab.freedesktop.org/drm/intel/issues/756
Signed-off-by: Umesh Nerlige
Thanks for the review, pushed to dinq
Manasi
On Wed, Jan 22, 2020 at 04:24:14PM -0800, Manasi Navare wrote:
> In the port sync mode, for the master crtc, the master_transcoder is INVALID.
> In that case since its value is -1, do not set the bit in the bitmask.
>
> Cc: Ville Syrjälä
> Fixes:
== Series Details ==
Series: drm/i915/selftests: Show the RC6 residency on parking failure
URL : https://patchwork.freedesktop.org/series/72479/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7805 -> Patchwork_16240
Summary
On Mon, Jan 20, 2020 at 07:23:57PM +0530, Manna, Animesh wrote:
> On 15-01-2020 03:08, Manasi Navare wrote:
> >On Fri, Dec 13, 2019 at 10:54:20PM +0530, Animesh Manna wrote:
> >>Hi Manasi/Jani,
> >>
> >>Thanks for helping phy compliance design.
> >>
> >>Added my understanding/doubts below.
> >>
>
On Fri, Jan 03, 2020 at 01:22:11PM +0200, Mika Kuoppala wrote:
> Chris Wilson writes:
>
> > Empirically the minimal context image we use for rcs is insufficient to
> > state the engine. This is demonstrated if we poison the context image
> > such that any uninitialised state is invalid, and so
== Series Details ==
Series: drm/i915/gt: Poison GTT scratch pages (rev8)
URL : https://patchwork.freedesktop.org/series/72423/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7805 -> Patchwork_16239
Summary
---
213a352f
> > drm/drm_panel: fix export of drm_panel_of_backlight, try #3
> >
> >
> > As we expect this to fix it for good.
> > Maybe the patch has not hit the right tree
> > and is thus not in -next.
>
> Sorry, I don't have the linux-next git tree so
== Series Details ==
Series: series starting with [RESEND,1/6] drm/i915/dmc: use intel uncore
functions for forcewake register access
URL : https://patchwork.freedesktop.org/series/72476/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7804 -> Patchwork_16238
Hi Chris,
On Thu, Jan 23, 2020 at 02:57:55PM +, Chris Wilson wrote:
> Include the current RC6 residency counter in the error message, so that
> if we fail to park and manually enter RC6 we can see if the counter has
> a particularly suspect value (such as 0).
>
> Signed-off-by: Chris Wilson
== Series Details ==
Series: series starting with [RESEND,1/6] drm/i915/dmc: use intel uncore
functions for forcewake register access
URL : https://patchwork.freedesktop.org/series/72476/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
68bf5a21a662 drm/i915/dmc: use intel
== Series Details ==
Series: drm/i915/tgl: Re-enable RPS
URL : https://patchwork.freedesktop.org/series/72471/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7804 -> Patchwork_16236
Summary
---
**SUCCESS**
No
== Series Details ==
Series: drm: Clean up VBLANK callbacks in struct drm_driver (rev9)
URL : https://patchwork.freedesktop.org/series/71873/
State : failure
== Summary ==
Applying: drm: Remove internal setup of struct
drm_device.vblank_disable_immediate
Applying: drm: Add
On Thu, Jan 23, 2020 at 08:27:12PM +0200, Ville Syrjälä wrote:
> On Wed, Jan 22, 2020 at 04:24:15PM -0800, Manasi Navare wrote:
>
> Missing commit msg.
Yes will add the commit message
>
>
> > Cc: Ville Syrjälä
> > Fixes: a603f5bd1691 ("drm/i915/dp: Make sure all tiled connectors get added
>
Only assert that the i915_vma is now idle if and only if no other pins
are present. If another user has the i915_vma pinned, they may submit
more work to the i915_vma skipping the vm->mutex used to serialise the
unbind. We need to wait again, if we want to continue and unbind this
vma.
However,
Optimistically wait for the prior vma activity before taking the mutex
to minimise the mutex hold time while unbinding. We will then verify the
vma is idle with a second wait under the mutex to ensure it is safe to
unbind.
Signed-off-by: Chris Wilson
Cc: Tvrtko Ursulin
---
The file is not part of the global drm resource and can be released
prior to take the global mutex to drop the open_count (and potentially
close) the drm device. As the global mutex is indeed global, not only
within the device but across devices, a slow file release mechanism can
bottleneck the
== Series Details ==
Series: 3 display pipes combination system support
URL : https://patchwork.freedesktop.org/series/72468/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7804 -> Patchwork_16235
Summary
---
On Thu, Jan 23, 2020 at 04:01:28PM +0200, Ville Syrjälä wrote:
> On Wed, Jan 22, 2020 at 04:24:14PM -0800, Manasi Navare wrote:
> > In the port sync mode, for the master crtc, the master_transcoder is
> > INVALID.
> > In that case since its value is -1, do not set the bit in the bitmask.
> >
> >
On Thu, Jan 23, 2020 at 08:31:55PM +0200, Ville Syrjälä wrote:
> On Thu, Jan 23, 2020 at 06:25:29PM +, Souza, Jose wrote:
> > On Wed, 2020-01-22 at 16:24 -0800, Manasi Navare wrote:
> > > In the port sync mode, for the master crtc, the master_transcoder is
> > > INVALID.
> > > In that case
== Series Details ==
Series: 3 display pipes combination system support
URL : https://patchwork.freedesktop.org/series/72468/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
ff6c602c84d0 drm/i915: Iterate over pipe and skip the disabled one
dbdf2193b56c drm/i915: Remove (pipe ==
On 1/22/2020 18:24, Patchwork wrote:
== Series Details ==
Series: drm/i915/guc: Update to GuC FW v40 (rev3)
URL : https://patchwork.freedesktop.org/series/72032/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7786_full -> Patchwork_16198_full
== Series Details ==
Series: drm/i915/gem: Detect overflow in calculating dumb buffer size
URL : https://patchwork.freedesktop.org/series/72467/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7804 -> Patchwork_16234
Summary
Optimistically wait for the prior vma activity before taking the mutex
to minimise the mutex hold time while unbinding. We will then verify the
vma is idle with a second wait under the mutex to ensure it is safe to
unbind.
Signed-off-by: Chris Wilson
Cc: Tvrtko Ursulin
---
== Series Details ==
Series: series starting with [v4,1/2] drm: add drm_core_check_all_features() to
check for a mask of features
URL : https://patchwork.freedesktop.org/series/72466/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7804 -> Patchwork_16233
== Series Details ==
Series: drm: Introduce struct drm_device based WARN* and use them in i915 (rev3)
URL : https://patchwork.freedesktop.org/series/72035/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7804 -> Patchwork_16232
== Series Details ==
Series: drm: Introduce struct drm_device based WARN* and use them in i915 (rev3)
URL : https://patchwork.freedesktop.org/series/72035/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
ab441b2f141b drm/i915/display: Make WARN* drm specific where drm_device ptr
On 1/23/2020 7:38 AM, Michal Wajdeczko wrote:
On Thu, 23 Jan 2020 16:02:17 +0100, Chris Wilson
wrote:
Quoting Daniele Ceraolo Spurio (2020-01-22 23:52:33)
On 1/22/20 11:48 AM, Michal Wajdeczko wrote:
> From commit 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over i915
> in GuC/HuC
== Series Details ==
Series: drm/i915/gem: conversion to new drm logging macros
URL : https://patchwork.freedesktop.org/series/72454/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7802 -> Patchwork_16231
Summary
---
== Series Details ==
Series: conversion to struct drm_device logging macros. (rev2)
URL : https://patchwork.freedesktop.org/series/72349/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7802 -> Patchwork_16230
Summary
On 2020-01-23 15:59:33, Tvrtko Ursulin wrote:
> gem_context_clone_with_engines was agreed upon in principle some time ago
> but never implemented. I have now posted this as
> https://patchwork.freedesktop.org/series/72464/ and plan to merge it once it
> passes CI.
>
> Dale, Arjun, Krishnaiah and
== Series Details ==
Series: drm/i915/gvt: fix high-order allocation failure on late load
URL : https://patchwork.freedesktop.org/series/72455/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7802 -> Patchwork_16228
Summary
On 1/23/2020 7:38 AM, Michal Wajdeczko wrote:
On Thu, 23 Jan 2020 16:02:17 +0100, Chris Wilson
wrote:
Quoting Daniele Ceraolo Spurio (2020-01-22 23:52:33)
On 1/22/20 11:48 AM, Michal Wajdeczko wrote:
> From commit 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over i915
> in GuC/HuC
== Series Details ==
Series: drm/i915/display: conversion to new struct drm_device logging macros.
URL : https://patchwork.freedesktop.org/series/72456/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7802 -> Patchwork_16229
== Series Details ==
Series: drm/i915: add display engine uncore helpers (rev3)
URL : https://patchwork.freedesktop.org/series/72331/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7786_full -> Patchwork_16193_full
Summary
On Thu, Jan 23, 2020 at 08:31:55PM +0200, Ville Syrjälä wrote:
> On Thu, Jan 23, 2020 at 06:25:29PM +, Souza, Jose wrote:
> > On Wed, 2020-01-22 at 16:24 -0800, Manasi Navare wrote:
> > > In the port sync mode, for the master crtc, the master_transcoder is
> > > INVALID.
> > > In that case
On Thu, 23 Jan 2020 19:26:58 +0100, Ye, Tony wrote:
On 1/23/2020 7:38 AM, Michal Wajdeczko wrote:
On Thu, 23 Jan 2020 16:02:17 +0100, Chris Wilson
wrote:
Quoting Daniele Ceraolo Spurio (2020-01-22 23:52:33)
On 1/22/20 11:48 AM, Michal Wajdeczko wrote:
> From commit 84b1ca2f0e68
On Tue, 2020-01-21 at 15:58 -0800, Vivek Kasireddy wrote:
> Perhaps in some cases the BIOS/GOP or other firmware may turn on
> PHY A but may not program the MUX correctly. Therefore, re-program
> PHY A if it is determined after reading the VBT that the value
> programmed for the MUX bit does not
On Thu, Jan 23, 2020 at 06:25:29PM +, Souza, Jose wrote:
> On Wed, 2020-01-22 at 16:24 -0800, Manasi Navare wrote:
> > In the port sync mode, for the master crtc, the master_transcoder is
> > INVALID.
> > In that case since its value is -1, do not set the bit in the
> > bitmask.
> >
> > Cc:
On Wed, 2020-01-22 at 16:24 -0800, Manasi Navare wrote:
> In the port sync mode, for the master crtc, the master_transcoder is
> INVALID.
> In that case since its value is -1, do not set the bit in the
> bitmask.
>
> Cc: Ville Syrjälä
> Fixes: d0eed1545fe7 ("drm/i915: Fix post-fastset modeset
On Wed, Jan 22, 2020 at 04:24:15PM -0800, Manasi Navare wrote:
Missing commit msg.
> Cc: Ville Syrjälä
> Fixes: a603f5bd1691 ("drm/i915/dp: Make sure all tiled connectors get added
> to the state with full modeset")
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/516
>
Acked-by: Tony Ye
On 1/22/2020 11:48 AM, Michal Wajdeczko wrote:
From commit 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over i915
in GuC/HuC paths") we stopped using HUC_STATUS error -ENODEV only
to indicate lack of HuC hardware and we started to use this error
also for all other cases when
== Series Details ==
Series: drm/i915: Hotplug cleanups (rev2)
URL : https://patchwork.freedesktop.org/series/72348/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7786_full -> Patchwork_16199_full
Summary
---
== Series Details ==
Series: drm/i915/execlists: Reclaim hanging virtual request (rev4)
URL : https://patchwork.freedesktop.org/series/72320/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7783_full -> Patchwork_16189_full
On Wed, Jan 22, 2020 at 03:40:27PM -0800, Anusha Srivatsa wrote:
> Disable Early Read and Src Swap by setting the bit 14
> and 15 in the chicken register.
>
> BSpec: 46045,52890
> HSDES: 1606931601
Hmm. The bspec WA description (which is very poorly written) only
mentions setting bit 14, but
== Series Details ==
Series: drm/i915: Don't show the blank process name for internal/simulated
errors
URL : https://patchwork.freedesktop.org/series/72337/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7783_full -> Patchwork_16188_full
On Thu, Jan 23, 2020 at 05:45:42PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> The aux ch is used for more than DDC, so let's give it a better
> name. For maximum ease let's include both the AUX ch identifier
> and the port identifier (for cases where the VBT has redefined
> the
Only assert that the i915_vma is now idle if and only if no other pins
are present. If another user has the i915_vma pinned, they may submit
more work to the i915_vma skipping the vm->mutex used to serialise the
unbind. We need to wait again, if we want to continue and unbind this
vma.
However,
On Thu, Jan 23, 2020 at 05:45:41PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> To make it easier to figure out what caused a particular debug
> message let's print out aux->name.
>
> Signed-off-by: Ville Syrjälä
It might be worth adding commas to some of these messages too while
On 23/01/2020 09:09, Chris Wilson wrote:
Quoting Dale B Stimson (2020-01-22 23:26:57)
Switch from simple iteration over all potential engines to using
macro __for_each_physical_engine which only returns engines that are
actually present.
For each context (as it is created) call
Quoting Michal Wajdeczko (2020-01-23 15:38:52)
> On Thu, 23 Jan 2020 16:02:17 +0100, Chris Wilson
> wrote:
>
> > Quoting Daniele Ceraolo Spurio (2020-01-22 23:52:33)
> >>
> >>
> >> On 1/22/20 11:48 AM, Michal Wajdeczko wrote:
> >> > From commit 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over
From: Ville Syrjälä
The aux ch is used for more than DDC, so let's give it a better
name. For maximum ease let's include both the AUX ch identifier
and the port identifier (for cases where the VBT has redefined
the relationship of the two).
Signed-off-by: Ville Syrjälä
---
From: Ville Syrjälä
To make it easier to figure out what caused a particular debug
message let's print out aux->name.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_dp_helper.c | 44 +++--
1 file changed, 25 insertions(+), 19 deletions(-)
diff --git
From: Ville Syrjälä
To make it easier to figure out what caused a particular debug
message let's print out aux->name.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_dp.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git
From: Ville Syrjälä
To make it easier to figure out what caused a particular debug
message let's print out aux->name.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_dp_helper.c | 44 +++--
1 file changed, 25 insertions(+), 19 deletions(-)
diff --git
On Thu, 23 Jan 2020 16:02:17 +0100, Chris Wilson
wrote:
Quoting Daniele Ceraolo Spurio (2020-01-22 23:52:33)
On 1/22/20 11:48 AM, Michal Wajdeczko wrote:
> From commit 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over i915
> in GuC/HuC paths") we stopped using HUC_STATUS error -ENODEV
On 23/01/2020 15:26, Chris Wilson wrote:
> If the ctx->vm is freed before we can acquire a local reference to it,
> we proceed to call i915_vm_put(NULL), which is invalid.
>
> Reported-by: Colin Ian King
> Fixes: 5dbd2b7be61e ("drm/i915/gem: Convert vm idr to xarray")
> Signed-off-by: Chris
If the ctx->vm is freed before we can acquire a local reference to it,
we proceed to call i915_vm_put(NULL), which is invalid.
Reported-by: Colin Ian King
Fixes: 5dbd2b7be61e ("drm/i915/gem: Convert vm idr to xarray")
Signed-off-by: Chris Wilson
Cc: Colin Ian King
---
Quoting Colin King (2020-01-23 15:14:06)
> From: Colin Ian King
>
> Currently if the call to function context_get_vm_rcu returns
> a null pointer for vm then the error exit path via label err_put
> will call i915_vm_put on the null vm, causing a null pointer
> dereference. Fix this by adding a
From: Colin Ian King
Currently if the call to function context_get_vm_rcu returns
a null pointer for vm then the error exit path via label err_put
will call i915_vm_put on the null vm, causing a null pointer
dereference. Fix this by adding a null check on vm and returning
without calling the
Quoting Chris Wilson (2020-01-22 18:42:46)
> Double check that the i915_active is finally idle after waiting, and
> flushing its callback, just in case we need to re-activate it, for
> example to keep the vma alive a bit longer due to last minute HW
> activity (e.g. saving the context before
Quoting Daniele Ceraolo Spurio (2020-01-22 23:52:33)
>
>
> On 1/22/20 11:48 AM, Michal Wajdeczko wrote:
> > From commit 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over i915
> > in GuC/HuC paths") we stopped using HUC_STATUS error -ENODEV only
> > to indicate lack of HuC hardware and we started
Include the current RC6 residency counter in the error message, so that
if we fail to park and manually enter RC6 we can see if the counter has
a particularly suspect value (such as 0).
Signed-off-by: Chris Wilson
Cc: Andi Shyti
---
drivers/gpu/drm/i915/gt/selftest_rc6.c | 5 +++--
1 file
On Thu, 23 Jan 2020 03:43:04 +0100, Patchwork
wrote:
== Series Details ==
Series: drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS
URL : https://patchwork.freedesktop.org/series/72419/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7799 -> Patchwork_16219
Using a clear page for scratch means that we have relatively benign
errors in case it is accidentally used, but that can be rather too
benign for debugging. If we poison the scratch, ideally it quickly
results in an obvious error.
v2: Set each page individually just in case we are using highmem
Quoting Tvrtko Ursulin (2020-01-23 14:48:24)
>
> On 23/01/2020 14:16, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2020-01-23 14:01:41)
> >>
> >> On 23/01/2020 13:16, Chris Wilson wrote:
> >>> Either way, I would suggest doing
> >>>
> >>> int __gem_context_clone_with_engines(int i915, uint32_t
Using a clear page for scratch means that we have relatively benign
errors in case it is accidentally used, but that can be rather too
benign for debugging. If we poison the scratch, ideally it quickly
results in an obvious error.
v2: Set each page individually just in case we are using highmem
On 23/01/2020 14:16, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2020-01-23 14:01:41)
On 23/01/2020 13:16, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2020-01-23 13:08:26)
On 23/01/2020 12:54, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2020-01-23 12:43:06)
From: Tvrtko Ursulin
In
From: Chris Wilson
> Sent: 15 January 2020 20:53
>
> Since we may try and flush the cachelines associated with large buffers
> (an 8K framebuffer is about 128MiB, even before we try HDR), this leads
> to unacceptably long latencies (when using a voluntary CONFIG_PREEMPT).
> If we call
Quoting Ville Syrjälä (2020-01-23 14:16:46)
> On Thu, Jan 23, 2020 at 04:00:04PM +0200, Jani Nikula wrote:
> > Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and
> > switch to using intel_de_read_fw() and intel_de_write_fw(),
> > respectively.
> >
> > No functional changes.
>
Quoting Ville Syrjälä (2020-01-23 14:10:34)
> On Thu, Jan 23, 2020 at 03:59:59PM +0200, Jani Nikula wrote:
> > Move away from I915_READ_FW() and I915_WRITE_FW() and switch to using
> > intel_uncore_read_fw() and intel_uncore_write_fw(), respectively.
> >
> > No functional changes.
> >
> >
On Thu, 23 Jan 2020, Ville Syrjälä wrote:
> On Thu, Jan 23, 2020 at 03:59:59PM +0200, Jani Nikula wrote:
>> Move away from I915_READ_FW() and I915_WRITE_FW() and switch to using
>> intel_uncore_read_fw() and intel_uncore_write_fw(), respectively.
>>
>> No functional changes.
>>
>>
Quoting Tvrtko Ursulin (2020-01-23 14:01:41)
>
> On 23/01/2020 13:16, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2020-01-23 13:08:26)
> >>
> >> On 23/01/2020 12:54, Chris Wilson wrote:
> >>> Quoting Tvrtko Ursulin (2020-01-23 12:43:06)
> From: Tvrtko Ursulin
>
> In test cases
On Thu, Jan 23, 2020 at 04:00:04PM +0200, Jani Nikula wrote:
> Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and
> switch to using intel_de_read_fw() and intel_de_write_fw(),
> respectively.
>
> No functional changes.
>
> Signed-off-by: Jani Nikula
Only a few oddities
On Thu, Jan 23, 2020 at 04:00:02PM +0200, Jani Nikula wrote:
> Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and
> switch to using intel_de_read_fw() and intel_de_write_fw(),
> respectively. Also switch I915_READ() and I915_WRITE() over in this file
> while at it.
>
> No
On Thu, Jan 23, 2020 at 03:59:59PM +0200, Jani Nikula wrote:
> Move away from I915_READ_FW() and I915_WRITE_FW() and switch to using
> intel_uncore_read_fw() and intel_uncore_write_fw(), respectively.
>
> No functional changes.
>
> Signed-off-by: Jani Nikula
> ---
>
Am 23.01.20 um 13:48 schrieb Jani Nikula:
> Use drm_core_check_all_features() to ensure both the driver features and
> the per-device driver features are taken into account when registering
> debugfs files.
>
> v3:
> - files[i].driver_features == 0 actually means "don't care"
>
> v2:
> - use
The callback struct drm_driver.get_scanout_position() is deprecated in
favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert vc4
over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/vc4/vc4_crtc.c | 12 +++-
drivers/gpu/drm/vc4/vc4_drv.c | 1 -
Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and
switch to using intel_de_read_fw() and intel_de_write_fw(),
respectively. Also switch I915_READ() and I915_WRITE() over in this file
while at it.
No functional changes.
Signed-off-by: Jani Nikula
---
VBLANK callbacks in struct drm_driver are deprecated in favor of
their equivalents in struct drm_crtc_funcs. Convert vmwgfx over.
v2:
* remove accidental whitespace fixes
Signed-off-by: Thomas Zimmermann
Acked-by: Thomas Hellstrom
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 3 ---
Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and
switch to using intel_de_read_fw() and intel_de_write_fw(),
respectively.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_pm.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and
switch to using intel_de_read_fw() and intel_de_write_fw(),
respectively.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_irq.c | 27 ---
1 file changed, 16
VBLANK callbacks in struct drm_driver are deprecated in favor of
their equivalents in struct drm_crtc_funcs. Convert vc4 over.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/vc4/vc4_crtc.c | 1 +
drivers/gpu/drm/vc4/vc4_drv.c | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
diff
VBLANK callbacks in struct drm_driver are deprecated in favor of
their equivalents in struct drm_crtc_funcs. Convert vkms over.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Rodrigo Siqueira
Tested-by: Rodrigo Siqueira
---
drivers/gpu/drm/vkms/vkms_crtc.c | 9 ++---
On 23/01/2020 13:16, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2020-01-23 13:08:26)
On 23/01/2020 12:54, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2020-01-23 12:43:06)
From: Tvrtko Ursulin
In test cases which create new contexts and submit work against them using
the passed in engine
VBLANK callbacks in struct drm_driver are deprecated in favor of
their equivalents in struct drm_crtc_funcs. Convert sti over.
v2:
* remove unnecessary include of sti_crtc.h from sti_drv.c
Signed-off-by: Thomas Zimmermann
Acked-by: Benjamin Gaignard
---
drivers/gpu/drm/sti/sti_crtc.c
Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and
switch to using intel_de_read_fw() and intel_de_write_fw(),
respectively. Also switch I915_READ() and I915_WRITE() over in this file
while at it.
No functional changes.
Signed-off-by: Jani Nikula
---
The callback struct drm_driver.get_scanout_position() is deprecated in
favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert stm
over.
Signed-off-by: Thomas Zimmermann
Tested-by: Yannick Fertré
---
drivers/gpu/drm/stm/drv.c | 1 -
drivers/gpu/drm/stm/ltdc.c | 65
Move away from I915_READ_FW() and I915_WRITE_FW() and switch to using
intel_uncore_read_fw() and intel_uncore_write_fw(), respectively.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_csr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
All non-legacy users of VBLANK functions in struct drm_driver have been
converted to use the respective interfaces in struct drm_crtc_funcs. The
remaining users of VBLANK callbacks in struct drm_driver are legacy drivers
with userspace modesetting.
All users of struct
1 - 100 of 190 matches
Mail list logo
