[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: Add mechanism to submit a context WA on ring submission

2020-02-22 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Add mechanism to submit a context WA on ring submission URL : https://patchwork.freedesktop.org/series/73688/ State : success == Summary == CI Bug Log - changes from CI_DRM_7970_full -> Patchwork_16640_full

Re: [Intel-gfx] [PATCH 3/8] drm/i915/tgl: Implement Wa_1806527549

2020-02-22 Thread Chris Wilson
Quoting José Roberto de Souza (2020-02-22 02:08:10) > This will whitelist the HIZ_CHICKEN register so mesa can disable the > optimizations and void hang when using D16_UNORM. But it's not added to the whitelist. -Chris ___ Intel-gfx mailing list Intel-gf

Re: [Intel-gfx] [PATCH 02/51] drm/i915: Don't clear drvdata in ->release

2020-02-22 Thread Daniel Vetter
On Fri, Feb 21, 2020 at 10:36 PM Chris Wilson wrote: > Quoting Daniel Vetter (2020-02-21 21:02:30) > > For two reasons: > > > > - The driver core clears this already for us after we're unloaded in > > __device_release_driver(). > > Even if we abort before loading? > > History notes that i915_pci

Re: [Intel-gfx] [PATCH 02/51] drm/i915: Don't clear drvdata in ->release

2020-02-22 Thread Daniel Vetter
On Sat, Feb 22, 2020 at 10:48 AM Daniel Vetter wrote: > > On Fri, Feb 21, 2020 at 10:36 PM Chris Wilson > wrote: > > Quoting Daniel Vetter (2020-02-21 21:02:30) > > > For two reasons: > > > > > > - The driver core clears this already for us after we're unloaded in > > > __device_release_driver

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Verify LRC isolation

2020-02-22 Thread Chris Wilson
Quoting Patchwork (2020-02-22 02:04:28) > Possible regressions > > * igt@i915_selftest@live_gt_lrc: > - fi-icl-y: [PASS][1] -> [DMESG-FAIL][2] >[1]: > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7984/fi-icl-y/igt@i915_selftest@live_gt_lrc.html >[2]: > https:

[Intel-gfx] [PATCH] drm/i915/selftests: Verify LRC isolation

2020-02-22 Thread Chris Wilson
Record the LRC registers before/after a preemption event to ensure that the first context sees nothing from the second client; at least in the normal per-context register state. References: https://gitlab.freedesktop.org/drm/intel/issues/1233 Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH] drm/i915/selftests: Verify LRC isolation

2020-02-22 Thread Chris Wilson
Record the LRC registers before/after a preemption event to ensure that the first context sees nothing from the second client; at least in the normal per-context register state. References: https://gitlab.freedesktop.org/drm/intel/issues/1233 Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH 17/51] drm/gm12u320: Use drmm_add_final_kfree

2020-02-22 Thread Hans de Goede
Hi, On 2/21/20 10:02 PM, Daniel Vetter wrote: With this we can drop the final kfree from the release function. Signed-off-by: Daniel Vetter Cc: Hans de Goede Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- drivers/gpu/drm/tiny/gm12u320.c | 3 ++- 1 file change

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Verify LRC isolation (rev3)

2020-02-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Verify LRC isolation (rev3) URL : https://patchwork.freedesktop.org/series/73788/ State : warning == Summary == $ dim checkpatch origin/drm-tip 794ca4c5268b drm/i915/selftests: Verify LRC isolation -:123: CHECK:PARENTHESIS_ALIGNMENT: Alignment s

Re: [Intel-gfx] [PATCH 42/51] drm/gm12u320: More drmm_

2020-02-22 Thread Hans de Goede
Hi, On 2/21/20 10:03 PM, Daniel Vetter wrote: The drm_mode_config_cleanup call we can drop, and all the allocations we can switch over to drmm_kzalloc. Unfortunately the work queue is still present, so can't get rid of the drm_driver->release function outright. Signed-off-by: Daniel Vetter Cc:

Re: [Intel-gfx] [PATCH 43/51] drm/gm12u320: Use devm_drm_dev_init

2020-02-22 Thread Hans de Goede
Hi, On 2/21/20 10:03 PM, Daniel Vetter wrote: Only drops the drm_dev_put, but hey a few lines! Signed-off-by: Daniel Vetter Cc: Hans de Goede Cc: "Noralf Trønnes" Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- drivers/gpu/drm/tiny/gm12u320.c | 19 +++

Re: [Intel-gfx] [PATCH 44/51] drm/gm12u320: Use helpers for shutdown/suspend/resume

2020-02-22 Thread Hans de Goede
Hi, On 2/21/20 10:03 PM, Daniel Vetter wrote: Also there's a race in the disconnect implemenation. First shut down, then unplug, leaves a window where userspace could sneak in and restart the entire machinery. With this we can also delete the very un-atomic global pipe_enabled tracking. Patch

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Verify LRC isolation (rev3)

2020-02-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Verify LRC isolation (rev3) URL : https://patchwork.freedesktop.org/series/73788/ State : success == Summary == CI Bug Log - changes from CI_DRM_7985 -> Patchwork_16676 Summary --- **S

Re: [Intel-gfx] [PATCH 45/51] drm/gm12u320: Simplify upload work

2020-02-22 Thread Hans de Goede
Hi, On 2/21/20 10:03 PM, Daniel Vetter wrote: Instead of having a work item that never stops (which really should be a kthread), with a dedicated workqueue to not upset anyone else, use a delayed work. A bunch of changes: - We can throw out all the custom wakeup and requeue logic and state t

Re: [Intel-gfx] [PATCH 04/12] drm: Nuke mode->vrefresh

2020-02-22 Thread Sam Ravnborg
Hi Ville. Nice patch - and diffstat looks good: > 63 files changed, 217 insertions(+), 392 deletions(-) There is an item in the Documentation/gpu/todo.rst that describes this. Could you drop this from todo.rst in this patch too. > diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/m

Re: [Intel-gfx] [PATCH 45/51] drm/gm12u320: Simplify upload work

2020-02-22 Thread Daniel Vetter
On Sat, Feb 22, 2020 at 1:30 PM Hans de Goede wrote: > > Hi, > > On 2/21/20 10:03 PM, Daniel Vetter wrote: > > Instead of having a work item that never stops (which really should be > > a kthread), with a dedicated workqueue to not upset anyone else, use a > > delayed work. A bunch of changes: > >

[Intel-gfx] [PATCH] drm/i915/gt: remove redundant assignment to variable dw

2020-02-22 Thread Colin King
From: Colin Ian King Variable dw is being initialized with a value that is never read, it is assigned a new value later on. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- 1

Re: [Intel-gfx] [PATCH] drm/i915/gt: remove redundant assignment to variable dw

2020-02-22 Thread Chris Wilson
Quoting Colin King (2020-02-22 13:47:55) > From: Colin Ian King > > Variable dw is being initialized with a value that is never read, > it is assigned a new value later on. The assignment is redundant > and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: remove redundant assignment to variable dw

2020-02-22 Thread Patchwork
== Series Details == Series: drm/i915/gt: remove redundant assignment to variable dw URL : https://patchwork.freedesktop.org/series/73808/ State : success == Summary == CI Bug Log - changes from CI_DRM_7986 -> Patchwork_16677 Summary --

Re: [Intel-gfx] [PATCH 18/51] drm/: Use drmm_add_final_kfree

2020-02-22 Thread Russell King - ARM Linux admin
On Fri, Feb 21, 2020 at 10:02:46PM +0100, Daniel Vetter wrote: > These are the leftover drivers that didn't have a ->release hook that > needed to be updated. > > Signed-off-by: Daniel Vetter > Cc: "James (Qian) Wang" > Cc: Liviu Dudau > Cc: Mihail Atanassov > Cc: Russell King > Cc: Hans de G

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Double check bumping after the spinlock

2020-02-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Double check bumping after the spinlock URL : https://patchwork.freedesktop.org/series/73707/ State : success == Summary == CI Bug Log - changes from CI_DRM_7973_full -> Patchwork_16645_full

[Intel-gfx] ✓ Fi.CI.IGT: success for HDCP 2.2 Comp fixes

2020-02-22 Thread Patchwork
== Series Details == Series: HDCP 2.2 Comp fixes URL : https://patchwork.freedesktop.org/series/73708/ State : success == Summary == CI Bug Log - changes from CI_DRM_7975_full -> Patchwork_16646_full Summary --- **SUCCESS** No reg

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Introduce struct drm_device based WARN* and use them in i915 (rev7)

2020-02-22 Thread Patchwork
== Series Details == Series: drm: Introduce struct drm_device based WARN* and use them in i915 (rev7) URL : https://patchwork.freedesktop.org/series/72035/ State : success == Summary == CI Bug Log - changes from CI_DRM_7976_full -> Patchwork_16648_full =