On Thu, 27 Feb 2020, Anshuman Gupta wrote:
> Fixes: d54c1a513c48 ("drm/i915: Fix broken transcoder err state")
That's supposed to go in the section with the "tags" below. Can be fixed
while applying, please don't resend for this.
BR,
Jani.
> has_transcoder() was unused because function which wa
On 2020-02-27 at 13:56:58 -0500, Sean Paul wrote:
> From: Sean Paul
>
> De-duplicate the HDCP version code and print it for all connectors.
>
> Cc: Juston Li
> Signed-off-by: Sean Paul
>
> Changes in v4:
> - Added to the set
> ---
> .../drm/i915/display/intel_display_debugfs.c| 17 ++
On Fri, Feb 28, 2020 at 4:38 AM Dave Airlie wrote:
>
> On Fri, 28 Feb 2020 at 07:27, Daniel Vetter wrote:
> >
> > Hi all,
> >
> > You might have read the short take in the X.org board meeting minutes
> > already, here's the long version.
> >
> > The good news: gitlab.fd.o has become very popular
Hi Daniel
Am 27.02.20 um 19:15 schrieb Daniel Vetter:
> There's only two functions called from that:
> drm_kms_helper_poll_fini() and udl_free_urb_list(). Both of these are
> also called from the ubs_driver->disconnect hook, so entirely
> pointless to do the same again in the ->release hook.
The
Hi Daniel
Am 27.02.20 um 19:14 schrieb Daniel Vetter:
> drm_mode_config_cleanup is idempotent, so no harm in calling this
> twice. This allows us to gradually switch drivers over by removing
> explicit drm_mode_config_cleanup calls.
>
> With this step it's not also possible that (at least for sim
On 2/27/20 8:42 PM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20200227:
>
on i386:
../drivers/gpu/drm/i915/display/intel_display.c:252:1: error: 'has_transcoder'
defined but not used [-Werror=unused-function]
has_transcoder(struct drm_i915_private *dev
On Thu, 27 Feb 2020, José Roberto de Souza wrote:
> New firmware contains minor fixes around context restore.
Please get the firmware in linux-firmware and CI first:
<7>[6.328884] i915 :00:02.0: [drm:intel_csr_ucode_init [i915]] Loading
i915/tgl_dmc_ver2_06.bin
<4>[6.330612] i915 00
== Series Details ==
Series: series starting with [1/2] drm/i915: Handle all MCR ranges (rev2)
URL : https://patchwork.freedesktop.org/series/74047/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8024 -> Patchwork_16756
Summ
== Series Details ==
Series: Re-org uC debugfs files and move them under GT
URL : https://patchwork.freedesktop.org/series/74051/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8024 -> Patchwork_16755
Summary
---
**SU
This DMC FW should fix
https://gitlab.freedesktop.org/drm/intel/issues/453 => DSB busy issue
Reviewed-by: Swati Sharma
On 28-Feb-20 5:20 AM, José Roberto de Souza wrote:
New firmware contains minor fixes around context restore.
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915
== Series Details ==
Series: Re-org uC debugfs files and move them under GT
URL : https://patchwork.freedesktop.org/series/74051/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: drm/i915/guc: drop stage_pool debugfs
Okay!
Commit: drm/i915/uc: mark stru
== Series Details ==
Series: Re-org uC debugfs files and move them under GT
URL : https://patchwork.freedesktop.org/series/74051/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
342d7bf407c2 drm/i915/guc: drop stage_pool debugfs
dfe41cbafaee drm/i915/uc: mark structure passed to
> -Original Message-
> From: Daniel Stone
> Sent: 25 February 2020 13:00
> To: Laxminarayan Bharadiya, Pankaj
>
> Cc: Jani Nikula ; Daniel Vetter
> ; intel-gfx ; dri-devel
> ; Ville Syrjälä
> ; David Airlie ; Maarten
> Lankhorst ; tzimmerm...@suse.de;
> Maxime Ripard ; mihail.atanas...@
== Series Details ==
Series: drm/i915/ggtt: do not set bits 1-11 in gen8+ ptes
URL : https://patchwork.freedesktop.org/series/74050/
State : failure
== Summary ==
Applying: drm/i915/ggtt: do not set bits 1-11 in gen8+ ptes
Using index info to reconstruct a base tree...
M drivers/gpu/drm/
== Series Details ==
Series: series starting with [1/4] drm/i915/perf: Reintroduce wait on OA
configuration completion (rev2)
URL : https://patchwork.freedesktop.org/series/74049/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8024 -> Patchwork_16753
==
== Series Details ==
Series: series starting with [1/4] drm/i915/perf: Reintroduce wait on OA
configuration completion (rev2)
URL : https://patchwork.freedesktop.org/series/74049/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
8416743fda17 drm/i915/perf: Reintroduce wait on OA
> -Original Message-
> From: Jani Nikula
> Sent: 27 February 2020 14:00
> To: Laxminarayan Bharadiya, Pankaj
> ; Chris Wilson wilson.co.uk>
> Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; David
> Airlie
> ; Joonas Lahtinen ; Vivi,
> Rodrigo ; dan...@ffwll.ch
>
== Series Details ==
Series: drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS (rev2)
URL : https://patchwork.freedesktop.org/series/72419/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7984_full -> Patchwork_16665_full
=
== Series Details ==
Series: drm/i915/dmc: Use firmware v2.06 for TGL
URL : https://patchwork.freedesktop.org/series/74048/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8024 -> Patchwork_16752
Summary
---
**FAILURE*
== Series Details ==
Series: drm/i915: Skip barriers inside waits
URL : https://patchwork.freedesktop.org/series/73984/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8012_full -> Patchwork_16727_full
Summary
---
**SU
== Series Details ==
Series: series starting with [1/2] drm/i915: Handle all MCR ranges
URL : https://patchwork.freedesktop.org/series/74047/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8023 -> Patchwork_16751
Summary
---
On Fri, 28 Feb 2020 at 07:27, Daniel Vetter wrote:
>
> Hi all,
>
> You might have read the short take in the X.org board meeting minutes
> already, here's the long version.
>
> The good news: gitlab.fd.o has become very popular with our
> communities, and is used extensively. This especially inclu
== Series Details ==
Series: drm/i915/huc: update TGL HuC to v7.0.12
URL : https://patchwork.freedesktop.org/series/74046/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8023 -> Patchwork_16750
Summary
---
**SUCCESS**
== Series Details ==
Series: drm/i915/huc: update TGL HuC to v7.0.12
URL : https://patchwork.freedesktop.org/series/74046/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
ac34e02f4c48 drm/i915/huc: update TGL HuC to v7.0.12
-:12: WARNING:BAD_SIGN_OFF: Non-standard signature: Requ
== Series Details ==
Series: drm/i915: Minimize uaccess exposure in i915_gem_execbuffer2_ioctl()
URL : https://patchwork.freedesktop.org/series/74045/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8023 -> Patchwork_16749
Su
On 2/27/20 5:03 PM, Josh Poimboeuf wrote:
> On Thu, Feb 27, 2020 at 10:35:42PM +, Al Viro wrote:
>> On Thu, Feb 27, 2020 at 04:08:26PM -0600, Josh Poimboeuf wrote:
>>> With CONFIG_CC_OPTIMIZE_FOR_SIZE, objtool reports:
>>>
>>> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool:
== Series Details ==
Series: series starting with [v3,01/11] drm/i915/tgl: Implement Wa_1409804808
URL : https://patchwork.freedesktop.org/series/74044/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8023 -> Patchwork_16748
Follow-up patches will pass const objects from debugfs to some those
functions, so we need to be ready.
Signed-off-by: Daniele Ceraolo Spurio
Cc: Michal Wajdeczko
Cc: John Harrison
Cc: Matthew Brost
---
drivers/gpu/drm/i915/gt/intel_gt.h | 6 +++---
drivers/gpu/drm/i915/gt/uc/int
we do call uc_fini if there is an issue while loading the GuC, so we
can't delete in there the logs we need to debug the load failure.
Moving the log free to driver remove ensures the logs stick around ong
enough for us to dump them.
Signed-off-by: Daniele Ceraolo Spurio
Cc: Michal Wajdeczko
---
We currently initialize HuC support based on GuC being enabled in
modparam; this means that huc_is_supported() can return false on HW that
does have a HuC when enable_guc=0. The rationale for this behavior is
that HuC requires GuC for authentication and therefore is not supported
by itself. However
uC is a component of the GT, so it makes sense for the uC debugfs files
to be in the GT folder. A subfolder has been used to keep the same
structure we have for the code.
Signed-off-by: Daniele Ceraolo Spurio
Cc: Andi Shyti
Cc: Michal Wajdeczko
Cc: John Harrison
Cc: Matthew Brost
Cc: Tony Ye
Move the printers to the respective files for clarity. The
guc_load_status debugfs has been squashed in the guc_info one, has
having separate ones wasn't very useful. The HuC debugfs has been
renamed huc_info to match.
While at it, fix the register printed in the HuC debugfs for gen11+.
Suggested
Move printing functions to their respective feature files, squash the 2
guc status debugfs files (load_status and info) and move them under the
gt/ folder. A fix for keeping the log error around, to be dumped in
debugfs after a wedge, is also included at the end.
Cc: Andi Shyti
Cc: Michal Wajdecz
The pool will be private to GuC in the new submission scheme, so we
won't be able to print it and we can just drop the current legacy code.
Signed-off-by: Daniele Ceraolo Spurio
Cc: Michal Wajdeczko
Cc: John Harrison
Cc: Matthew Brost
---
drivers/gpu/drm/i915/i915_debugfs.c | 53 -
== Series Details ==
Series: series starting with [1/3] drm/i915/perf: Mark up the racy use of
perf->exclusive_stream
URL : https://patchwork.freedesktop.org/series/73978/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8011_full -> Patchwork_16726_full
== Series Details ==
Series: drm/i915/gt: Check engine-is-awake on reset later
URL : https://patchwork.freedesktop.org/series/74041/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8023 -> Patchwork_16746
Summary
---
*
== Series Details ==
Series: drm/i915/psr: Force PSR probe only after full initialization (rev8)
URL : https://patchwork.freedesktop.org/series/73436/
State : failure
== Summary ==
Applying: drm/i915/psr: Force PSR probe only after full initialization
Using index info to reconstruct a base tre
== Series Details ==
Series: drm/i915: Lock gmbus/aux mutexes while changing cdclk
URL : https://patchwork.freedesktop.org/series/74039/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8023 -> Patchwork_16745
Summary
---
On TGL, bits 2-4 in the GGTT PTE are not ignored anymore and are
instead used for some extra VT-d capabilities. We don't (yet?) have
support for those capabilities, but, given that we shared the pte_encode
function betweed GGTT and PPGTT, we still set those bits to the PPGTT
PPAT values. The DMA en
On 02/27/2020 05:00 PM, Tom Stellard wrote:
> On 02/27/2020 01:27 PM, Daniel Vetter wrote:
>> Hi all,
>>
>> You might have read the short take in the X.org board meeting minutes
>> already, here's the long version.
>>
>> The good news: gitlab.fd.o has become very popular with our
>> communities, an
We wish that the scheduler emit the context modification commands prior
to enabling the oa_config, for which we must explicitly inform it of the
ordering constraints. This is especially important as we now wait for
the final oa_config setup to be completed and as this wait may be on a
distinct cont
On Thu, Feb 27, 2020 at 10:35:42PM +, Al Viro wrote:
> On Thu, Feb 27, 2020 at 04:08:26PM -0600, Josh Poimboeuf wrote:
> > With CONFIG_CC_OPTIMIZE_FOR_SIZE, objtool reports:
> >
> > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool:
> > i915_gem_execbuffer2_ioctl()+0x5b7: cal
== Series Details ==
Series: Adding YUV444 packed format support for skl+ (rev4)
URL : https://patchwork.freedesktop.org/series/73020/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8023 -> Patchwork_16744
Summary
---
On 02/27/2020 01:27 PM, Daniel Vetter wrote:
> Hi all,
>
> You might have read the short take in the X.org board meeting minutes
> already, here's the long version.
>
> The good news: gitlab.fd.o has become very popular with our
> communities, and is used extensively. This especially includes all
We still need to wait for the initial OA configuration to happen
before we enable OA report writes to the OA buffer.
Reported-by: Lionel Landwerlin
Fixes: 15d0ace1f876 ("drm/i915/perf: execute OA configuration from command
stream")
Testcase: igt/perf/stream-open-close
Signed-off-by: Chris Wilson
We wish that the scheduler emit the context modification commands prior
to enabling the oa_config, for which we must explicitly inform it of the
ordering constraints. This is especially important as we now wait for
the final oa_config setup to be completed and as this wait may be on a
distinct cont
Extend i915_request_await_active() to be able to asynchronously wait on
all the tracked timelines simultaneously.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_active.c | 54 +++---
drivers/gpu/drm/i915/i915_active.h | 5 ++-
drivers/gpu/drm/i915/i915_vma.c
For conveniences of callers that just want to use an i915_active to
track a wide array of concurrent timelines, wrap the base i915_active
struct inside a kref. This i915_active will self-destruct after use.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_active.c | 52 +
== Series Details ==
Series: Adding YUV444 packed format support for skl+ (rev4)
URL : https://patchwork.freedesktop.org/series/73020/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
8e8ab83649cd drm/i915: Adding YUV444 packed format support for skl+ (V15)
-:9: WARNING:COMMIT_LOG
== Series Details ==
Series: drm/i915: Print HDCP version info for all connectors
URL : https://patchwork.freedesktop.org/series/74037/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8023 -> Patchwork_16743
Summary
---
== Series Details ==
Series: drm/i915: Clean up DPLL output/refclock tracking
URL : https://patchwork.freedesktop.org/series/73977/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8010_full -> Patchwork_16725_full
Summary
---
On Thu, Feb 27, 2020 at 10:27:04PM +0100, Daniel Vetter wrote:
> Hi all,
>
> You might have read the short take in the X.org board meeting minutes
> already, here's the long version.
>
> The good news: gitlab.fd.o has become very popular with our
> communities, and is used extensively. This espec
New firmware contains minor fixes around context restore.
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/display/intel_csr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_csr.c
b/drivers/gpu/drm/i915/display/intel_csr.c
On Thu, 2020-02-27 at 14:44 -0800, Daniele Ceraolo Spurio wrote:
> Update to the latest available TGL HuC, which includes changes
> required
> by the media team.
>
Reviewed-by: José Roberto de Souza
> Requested-by: Tony Ye
> Signed-off-by: Daniele Ceraolo Spurio <
> daniele.ceraolospu...@intel
On Thu, Feb 27, 2020 at 1:27 PM Daniel Vetter wrote:
>
> Hi all,
>
> You might have read the short take in the X.org board meeting minutes
> already, here's the long version.
>
> The good news: gitlab.fd.o has become very popular with our
> communities, and is used extensively. This especially inc
On Thu, 2020-02-27 at 13:56 -0500, Sean Paul wrote:
> From: Sean Paul
>
> De-duplicate the HDCP version code and print it for all connectors.
>
> Cc: Juston Li
> Signed-off-by: Sean Paul
>
> Changes in v4:
> - Added to the set
LGTM, thanks for adding this!
Reviewed-by: Juston Li
> ---
> .
The following changes since commit
efcfa03ae6100dfe523ebf612e03c3a90fc4c794:
linux-firmware: Update firmware file for Intel Bluetooth AX201 (2020-
02-24 07:43:42 -0500)
are available in the Git repository at:
git://anongit.freedesktop.org/drm/drm-firmware tgl_dmc_2.06
for you to fetch chang
The bspec documents multiple MCR ranges; make sure they're all captured
by the driver.
Bspec: 13991, 52079
Fixes: 592a7c5e082e ("drm/i915: Extend non readable mcr range")
Cc: Mika Kuoppala
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 25 ++---
1 fi
The register this workaround updates is a render engine register in the
MCR range, so we should initialize this in rcs_engine_wa_init() rather
than gt_wa_init().
Closes: https://gitlab.freedesktop.org/drm/intel/issues/1222
Fixes: 36204d80bacb ("drm/i915/icl: Wa_1406680159")
Cc: Mika Kuoppala
Sign
== Series Details ==
Series: drm managed resources, v3
URL : https://patchwork.freedesktop.org/series/74035/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8022 -> Patchwork_16742
Summary
---
**SUCCESS**
No regress
On Fri, Feb 14, 2020 at 04:27:51AM -0800, Aditya Swarup wrote:
> Add definitions for registers grouped under Transcoder VRR function
> with necessary bitfields.
>
> Bspec: 49268
>
> v2: Use REG_GENMASK, correct tabs/space indentation and move the
> definitions near the transcoder section.(Jani)
>
On Tue, Jan 07, 2020 at 06:36:55PM +0200, Ville Syrjälä wrote:
On Mon, Dec 23, 2019 at 12:59:55PM -0800, Lucas De Marchi wrote:
On Fri, Dec 20, 2019 at 10:11:15PM +, Chris Wilson wrote:
>Quoting Lucas De Marchi (2019-12-20 22:06:50)
>> According to intel_detect_preproduction_hw(), the SKL st
On Thu, Feb 27, 2020 at 04:08:26PM -0600, Josh Poimboeuf wrote:
> With CONFIG_CC_OPTIMIZE_FOR_SIZE, objtool reports:
>
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool:
> i915_gem_execbuffer2_ioctl()+0x5b7: call to gen8_canonical_addr() with
> UACCESS enabled
>
> This means
Hi Chris,
On Thu, Feb 27, 2020 at 08:57:11AM +, Chris Wilson wrote:
> Still chasing the mystery of the stray idle flush, let's ensure that the
> heartbeat does not run at the same time as our test and confuse us.
>
> References: https://gitlab.freedesktop.org/drm/intel/issues/541
> Signed-off
== Series Details ==
Series: drm managed resources, v3
URL : https://patchwork.freedesktop.org/series/74035/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: mm/sl[uo]b: export __kmalloc_track(_node)_caller
Okay!
== Series Details ==
Series: drm managed resources, v3
URL : https://patchwork.freedesktop.org/series/74035/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e3a16eee86fc mm/sl[uo]b: export __kmalloc_track(_node)_caller
-:58: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line
Update to the latest available TGL HuC, which includes changes required
by the media team.
Requested-by: Tony Ye
Signed-off-by: Daniele Ceraolo Spurio
Cc: Tony Ye
Cc: Michal Wajdeczko
Cc: Anusha Srivatsa
---
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 2 +-
1 file changed, 1 insertion(+), 1 d
The following changes since commit efcfa03ae6100dfe523ebf612e03c3a90fc4c794:
linux-firmware: Update firmware file for Intel Bluetooth AX201 (2020-02-24
07:43:42 -0500)
are available in the Git repository at:
git://anongit.freedesktop.org/drm/drm-firmware tgl_huc_7.0.12
for you to fetch cha
Hi Cris,
> Attaching to the i915_active barrier is a two stage process, and a flush
> is only effective when the barrier is activation. Thus it is possible
> for us to see a barrier, and attempt to flush, only for our flush to
> have no effect. As such, before attempting to activate signaling on t
On 28/02/2020 00:01, José Roberto de Souza wrote:
Just to make easier to check that the Wa was implemetend when
comparing to the number in BSpec.
BSpec: 52890
Signed-off-by: José Roberto de Souza
Reviewed-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 1 +
1 file
== Series Details ==
Series: drm/i915/ggtt: do not set bits 1-11 in gen12 ptes
URL : https://patchwork.freedesktop.org/series/73969/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8010_full -> Patchwork_16724_full
Summary
--
Quoting Josh Poimboeuf (2020-02-27 22:08:26)
> With CONFIG_CC_OPTIMIZE_FOR_SIZE, objtool reports:
>
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool:
> i915_gem_execbuffer2_ioctl()+0x5b7: call to gen8_canonical_addr() with
> UACCESS enabled
>
> This means i915_gem_execbuffer
Hi Chris,
On Thu, Feb 27, 2020 at 08:47:27PM +, Chris Wilson wrote:
> As we drop the engine-pm on retiring, that may happen while there are
> still CS events in the buffer. As such we cannot assert the engine is
> still active on reset, until we know that the current request is still
> in flig
With CONFIG_CC_OPTIMIZE_FOR_SIZE, objtool reports:
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool:
i915_gem_execbuffer2_ioctl()+0x5b7: call to gen8_canonical_addr() with UACCESS
enabled
This means i915_gem_execbuffer2_ioctl() is calling gen8_canonical_addr()
-- and indirectl
Different issues with the same fix, so justing adding
Wa_1409142259, Wa_1409252684, Wa_1409217633, Wa_1409207793,
Wa_1409178076 and 1408979724 to the comment so other devs can check if
this Was were implemetend with a simple grep.
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/
This workaround the CS not done issue on PIPE_CONTROL.
v2:
- replaced BIT() by REG_BIT() in all GEN7_ROW_CHICKEN2() bits
- shortened the name of the new bit
BSpec: 52890
BSpec: 46218
Cc: Matt Roper
Reviewed-by: Matt Roper
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/intel_
It is fixed in B0 stepping.
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/intel_pm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 22aa205793e5..a101d8072b5b 100644
--- a/drivers/gp
From: Matt Atwood
Disable Push Constant buffer addition for TGL.
v2: typos, add additional Wa reference
v3: use REG_BIT macro, move to rcs_engine_wa_init, clean up commit
message.
Bspec: 52890
Cc: Rafael Antognolli
Cc: Matt Roper
Reviewed-by: Matt Roper
Signed-off-by: Matt Atwood
Signed-off
The Wa number for this fix is Wa_1607087056 the BSpec bug id is
1607087056, just updating to match BSpec.
BSpec: 52890
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/
Add note about the confliting information in BSpec about this WA.
BSpec: 52890
Acked-by: Matt Roper
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_w
This will fix a memory coherence issue.
v3: using whitespace to make easy to read WA (Chris)
BSpec: 52890
Cc: Chris Wilson
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 8
drivers/gpu/drm/i915/i915_reg.h | 20 +++-
This issue workaround in Wa_1607063988 has the same fix as
Wa_1607138336, so just adding a note in the code.
Reviewed-by: Matt Roper
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drive
Just to make easier to check that the Wa was implemetend when
comparing to the number in BSpec.
BSpec: 52890
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
b/dri
From: Anusha Srivatsa
According to BSpec. Wa_1606931601 applies for all TGL steppings.
This patch moves the WA implementation out of A0 only block of
rcs_engine_wa_init().
The WA is has also been referred to by an alternate name
Wa_1607090982.
Bspec: 46045, 52890
Fixes: 3873fd1a43c7 ("drm/i915
This will whitelist the HIZ_CHICKEN register so mesa can disable the
optimizations and avoid hang when using D16_UNORM.
v2: moved to the right place and used the right function() (Chris)
Cc: Matt Roper
Cc: Rafael Antognolli
Cc: Chris Wilson
Signed-off-by: José Roberto de Souza
---
drivers/gp
== Series Details ==
Series: drm/i915: Fix kbuild test robot build error (rev2)
URL : https://patchwork.freedesktop.org/series/73990/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8021 -> Patchwork_16741
Summary
---
== Series Details ==
Series: series starting with [1/3] drm/i915/gem: Consolidate ctx->engines[]
release
URL : https://patchwork.freedesktop.org/series/73966/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8010_full -> Patchwork_16723_full
=
Hi all,
You might have read the short take in the X.org board meeting minutes
already, here's the long version.
The good news: gitlab.fd.o has become very popular with our
communities, and is used extensively. This especially includes all the
CI integration. Modern development process and tooling
== Series Details ==
Series: series starting with [1/3] drm/i915: add i915_ioc32.h for compat
URL : https://patchwork.freedesktop.org/series/74033/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8021 -> Patchwork_16740
Summa
On Thu, Feb 27, 2020 at 07:14:44PM +0100, Daniel Vetter wrote:
> With this we can drop the final kfree from the release function.
>
> v2: After drm_dev_init/drmm_add_final_kfree we need to clean up
> everything through a drm_dev_put. Rework the unwind code to match
> that.
>
> Signed-off-by: Dani
On Thu, Feb 27, 2020 at 07:14:40PM +0100, Daniel Vetter wrote:
> With this we can drop the final kfree from the release function.
>
> I also noticed that cirrus forgot to call drm_dev_fini().
>
> v2: Don't call kfree(cirrus) after we've handed overship of that to
> drm_device and the drmm_ stuff.
On Thu, Feb 27, 2020 at 07:14:37PM +0100, Daniel Vetter wrote:
> With this we can drop the final kfree from the release function.
>
> v2: We need drm_dev_put to unroll the driver creation (once
> drm_dev_init and drmm_add_final_kfree suceeded), otherwise
> the drmm_ magic doesn't happen.
>
> v3:
On Thu, Feb 27, 2020 at 07:14:36PM +0100, Daniel Vetter wrote:
> They all share mipi_dbi_release so we need to switch them all
> together. With this we can drop the final kfree from the release
> function.
>
> Aside, I think we could perhaps have a tiny additional helper for
> these mipi_dbi drive
Commit 60c6a14b489b ("drm/i915/display: Force the state compute phase
once to enable PSR") was forcing the state compute too earlier
causing errors because not everything was initialized, so here
moving to the end of i915_driver_modeset_probe() when the display is
all initialized.
Also fixing the
Hi Daniel.
Nicely written overview.
Acked-by: Sam Ravnborg
snip - detailed changelog + patch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915: add i915_ioc32.h for compat
URL : https://patchwork.freedesktop.org/series/74033/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
663fbcd4dcd6 drm/i915: add i915_ioc32.h for compat
-:80: WARNING:FILE_PATH_CHANGES:
As we drop the engine-pm on retiring, that may happen while there are
still CS events in the buffer. As such we cannot assert the engine is
still active on reset, until we know that the current request is still
in flight.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 7 ++
== Series Details ==
Series: drm/i915: Proper dbuf global state (rev3)
URL : https://patchwork.freedesktop.org/series/73421/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8021 -> Patchwork_16739
Summary
---
**SUCCESS
== Series Details ==
Series: series starting with [1/3] drm/i915: Fix 400 MHz FSB readout on elk
URL : https://patchwork.freedesktop.org/series/73965/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8010_full -> Patchwork_16722_full
==
== Series Details ==
Series: drm/i915: Proper dbuf global state (rev3)
URL : https://patchwork.freedesktop.org/series/73421/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3643e15727b1 drm/i915: Handle some leftover s/intel_crtc/crtc/
c2f2161d6505 drm/i915: Remove garbage WARNs
1 - 100 of 259 matches
Mail list logo
