[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gen12: Disable preemption timeout (rev4)

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915/gen12: Disable preemption timeout (rev4) URL : https://patchwork.freedesktop.org/series/74526/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8126_full -> Patchwork_16952_full Summary --

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/3] lib/i915/perf: remove generation code for mathml render

2020-03-12 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] lib/i915/perf: remove generation code for mathml render URL : https://patchwork.freedesktop.org/series/74641/ State : failure == Summary == CI Bug Log - changes from IGT_5506_full -> IGTPW_4298_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Enable non-contiguous pipe fusing

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915: Enable non-contiguous pipe fusing URL : https://patchwork.freedesktop.org/series/74570/ State : success == Summary == CI Bug Log - changes from CI_DRM_8113_full -> Patchwork_16920_full Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915 lpsp support for lpsp igt (rev2)

2020-03-12 Thread Patchwork
== Series Details == Series: i915 lpsp support for lpsp igt (rev2) URL : https://patchwork.freedesktop.org/series/74648/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8132 -> Patchwork_16959 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915 lpsp support for lpsp igt (rev2)

2020-03-12 Thread Patchwork
== Series Details == Series: i915 lpsp support for lpsp igt (rev2) URL : https://patchwork.freedesktop.org/series/74648/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9199409798de drm/i915: Power well id for ICL PG3 682ea86063da drm/i915: Add i915_lpsp_info debugfs -:103: WARNI

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: add OA interrupt support (rev6)

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915/perf: add OA interrupt support (rev6) URL : https://patchwork.freedesktop.org/series/54280/ State : success == Summary == CI Bug Log - changes from CI_DRM_8131 -> Patchwork_16958 Summary --- **SU

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/perf: add OA interrupt support (rev6)

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915/perf: add OA interrupt support (rev6) URL : https://patchwork.freedesktop.org/series/54280/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/i915_perf.c:674: warning: Function parameter or member 'oastatus'

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/perf: add OA interrupt support (rev6)

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915/perf: add OA interrupt support (rev6) URL : https://patchwork.freedesktop.org/series/54280/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/perf: rework aging tail workaround Okay! Commit: drm/i915/perf: m

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: add OA interrupt support (rev6)

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915/perf: add OA interrupt support (rev6) URL : https://patchwork.freedesktop.org/series/54280/ State : warning == Summary == $ dim checkpatch origin/drm-tip cf4dc4c5b6bb drm/i915/perf: rework aging tail workaround -:189: CHECK:SPACING: No space is necessary a

[Intel-gfx] [PULL] topic/mst-bw-check-fixes-for-airlied

2020-03-12 Thread Lyude Paul
topic/mst-bw-check-fixes-for-airlied-2020-03-12-2: UAPI Changes: None Cross-subsystem Changes: None Core Changes: Fixed regressions introduced by commit cd82d82cbc04 ("drm/dp_mst: Add branch bandwidth validation to MST atomic check"), which would cause us to: * Calculate the available bandwidth

Re: [Intel-gfx] [PATCH v4 7/7] drm/i915/dp: Program vswing, pre-emphasis, test-pattern

2020-03-12 Thread Manasi Navare
Just a few nits below On Tue, Mar 10, 2020 at 09:07:45PM +0530, Animesh Manna wrote: > This patch process phy compliance request by programming requested > vswing, pre-emphasis and test pattern. > > v1: Initial patch. > v2: Fixes added during testing with test-scope. (Khaled/Clint/Manasi) > - pip

Re: [Intel-gfx] [PATCH 4/7] drm/i915/perf: add new open param to configure polling of OA buffer

2020-03-12 Thread Umesh Nerlige Ramappa
On Thu, Mar 12, 2020 at 10:37:12PM +0200, Lionel Landwerlin wrote: On 12/03/2020 21:27, Dixit, Ashutosh wrote: On Tue, 03 Mar 2020 14:19:02 -0800, Umesh Nerlige Ramappa wrote: From: Lionel Landwerlin This new parameter let's the application choose how often the OA buffer should be checked on

Re: [Intel-gfx] [PATCH v4 6/7] drm/i915/dp: Register definition for DP compliance register

2020-03-12 Thread Manasi Navare
Hi Animesh, Here all the DP_COMP_CTL and DP_COMP_PAT register offsets should be pipe based like we changed in the intel_dp_update_phy_pattern() Since it could be on Port B but still use Pipe A and it should in that case write to DDi_DP_COMP_CTL_A On Tue, Mar 10, 2020 at 09:07:44PM +0530, Animesh

[Intel-gfx] [PATCH 0/4] drm/i915/perf: add OA interrupt support

2020-03-12 Thread Umesh Nerlige Ramappa
Hi all, This is a revival of an earlier patch series submitted by Lionel Landwerlin - https://patchwork.freedesktop.org/series/54280/ The patches enable interrupt support for the perf OA unit in i915, further details can be found in the orignal series linked above. v2: (Umesh) - This series will

[Intel-gfx] [PATCH 3/4] drm/i915/perf: only append status when data is available

2020-03-12 Thread Umesh Nerlige Ramappa
From: Lionel Landwerlin The only bit of the status register we currently report in the i915-perf stream is the "report loss" bit. Only report this when we have some data to report with it. There was a kind of inconsistency here in that we could report report loss without appending the reports ass

[Intel-gfx] [PATCH 1/4] drm/i915/perf: rework aging tail workaround

2020-03-12 Thread Umesh Nerlige Ramappa
From: Lionel Landwerlin We're about to introduce an options to open the perf stream, giving the user ability to configure how often it wants the kernel to poll the OA registers for available data. Right now the workaround against the OA tail pointer race condition requires at least twice the int

[Intel-gfx] [PATCH 4/4] drm/i915/perf: add new open param to configure polling of OA buffer

2020-03-12 Thread Umesh Nerlige Ramappa
From: Lionel Landwerlin This new parameter let's the application choose how often the OA buffer should be checked on the CPU side for data availability. Longer polling period tend to reduce CPU overhead if the application does not care about somewhat real time data collection. v2: Allow disablin

[Intel-gfx] [PATCH 2/4] drm/i915/perf: move pollin setup to non hw specific code

2020-03-12 Thread Umesh Nerlige Ramappa
From: Lionel Landwerlin This isn't really gen specific stuff, so just move it to the common code. v2: Rebase (Umesh) Signed-off-by: Lionel Landwerlin Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

Re: [Intel-gfx] [PATCH v4 5/7] drm/i915/dp: Add debugfs entry for DP phy compliance

2020-03-12 Thread Manasi Navare
On Tue, Mar 10, 2020 at 09:07:43PM +0530, Animesh Manna wrote: > These debugfs entry will help testapp to understand the test request > during dp phy compliance mode. > > Acked-by: Manasi Navare > Signed-off-by: Animesh Manna Reviewed-by: Manasi Navare Manasi > --- > drivers/gpu/drm/i915/di

[Intel-gfx] ✓ Fi.CI.IGT: success for Re-org uC debugfs files and move them under GT (rev2)

2020-03-12 Thread Patchwork
== Series Details == Series: Re-org uC debugfs files and move them under GT (rev2) URL : https://patchwork.freedesktop.org/series/74051/ State : success == Summary == CI Bug Log - changes from CI_DRM_8125_full -> Patchwork_16944_full Summar

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/perf: introduce global sseu pinning

2020-03-12 Thread Tvrtko Ursulin
On 12/03/2020 18:19, Tvrtko Ursulin wrote: On 06/03/2020 10:05, Lionel Landwerlin wrote: On Gen11 powergating half the execution units is a functional requirement when using the VME samplers. Not fullfilling this requirement can lead to hangs. This unfortunately plays fairly poorly with the N

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915: Add Wa_1604278689:icl,ehl

2020-03-12 Thread Souza, Jose
On Wed, 2020-03-11 at 09:22 -0700, Matt Roper wrote: > The bspec description for this workaround tells us to program > 0x_ into both FBC_RT_BASE_ADDR_REGISTER_* registers, but > we've > previously found that this leads to failures in CI. Our suspicion is > that the failures are caused by t

Re: [Intel-gfx] [PATCH v2 4/6] drm/i915: Add Wa_1406306137:icl,ehl

2020-03-12 Thread Souza, Jose
On Thu, 2020-03-12 at 15:08 -0700, José Roberto de Souza wrote: > On Wed, 2020-03-11 at 09:22 -0700, Matt Roper wrote: > > v2: > > - Move to context workarounds. ROW_CHICKEN4 is part of the > > context > >image on gen11 (although it isn't on gen12). > > > > Signed-off-by: Matt Roper > > ---

Re: [Intel-gfx] [PATCH v4 3/7] drm/i915/dp: Made intel_dp_adjust_train() non-static

2020-03-12 Thread Manasi Navare
On Tue, Mar 10, 2020 at 09:07:41PM +0530, Animesh Manna wrote: > vswing/pre-emphasis adjustment calculation is needed in processing > of auto phy compliance request other than link training, so have > made non-static function. > > No functional change. > > v1: initial patch. > v2: > - used "intel

Re: [Intel-gfx] [PATCH v4 2/7] drm/dp: get/set phy compliance pattern

2020-03-12 Thread Manasi Navare
On Tue, Mar 10, 2020 at 09:07:40PM +0530, Animesh Manna wrote: > During phy compliance auto test mode source need to read > requested test pattern from sink through DPCD. After processing > the request source need to set the pattern. So set/get method > added in drm layer as it is DP protocol. > >

Re: [Intel-gfx] [PATCH 1/1] Revert "drm/i915/tgl: Add extra hdc flush workaround"

2020-03-12 Thread Souza, Jose
On Thu, 2020-03-12 at 15:07 -0700, Lucas De Marchi wrote: > On Wed, Mar 04, 2020 at 05:04:52PM -0800, Lucas De Marchi wrote: > > On Wed, Mar 4, 2020 at 2:33 PM Caz Yokoyama > > wrote: > > > This reverts commit 36a6b5d964d995b536b1925ec42052ee40ba92c4. > > > Fixes: 36a6b5d964d9 ("drm/i915/tgl: Add

Re: [Intel-gfx] [PATCH 4/7] drm/i915/perf: add new open param to configure polling of OA buffer

2020-03-12 Thread Dixit, Ashutosh
On Thu, 12 Mar 2020 13:37:12 -0700, Lionel Landwerlin wrote: > On 12/03/2020 21:27, Dixit, Ashutosh wrote: > > On Tue, 03 Mar 2020 14:19:02 -0800, Umesh Nerlige Ramappa wrote: > >> From: Lionel Landwerlin > >> > >> This new parameter let's the application choose how often the OA > >> buffer should

Re: [Intel-gfx] [PATCH] drm/mm: Use debugobject to track lifetimes

2020-03-12 Thread kbuild test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.6-rc5 next-20200312] [if your patch is applied to the wrong git tree, please

Re: [Intel-gfx] [PATCH v4 1/7] drm/amd/display: Align macro name as per DP spec

2020-03-12 Thread Manasi Navare
On Tue, Mar 10, 2020 at 09:07:39PM +0530, Animesh Manna wrote: > [Why]: > Aligh with DP spec wanted to follow same naming convention. > > [How]: > Changed the macro name of the dpcd address used for getting requested > test-pattern. > > Cc: Harry Wentland > Cc: Alex Deucher > Reviewed-by: Harry

Re: [Intel-gfx] [PATCH v2 4/6] drm/i915: Add Wa_1406306137:icl,ehl

2020-03-12 Thread Souza, Jose
On Wed, 2020-03-11 at 09:22 -0700, Matt Roper wrote: > v2: > - Move to context workarounds. ROW_CHICKEN4 is part of the context >image on gen11 (although it isn't on gen12). > > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ > drivers/gpu/drm/i915/i9

Re: [Intel-gfx] [PATCH 1/1] Revert "drm/i915/tgl: Add extra hdc flush workaround"

2020-03-12 Thread Lucas De Marchi
On Wed, Mar 04, 2020 at 05:04:52PM -0800, Lucas De Marchi wrote: On Wed, Mar 4, 2020 at 2:33 PM Caz Yokoyama wrote: This reverts commit 36a6b5d964d995b536b1925ec42052ee40ba92c4. Fixes: 36a6b5d964d9 ("drm/i915/tgl: Add extra hdc flush workaround") The commit takes care Wa_1604544889 which was

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915/gem: Mark up sw-fence notify function

2020-03-12 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gem: Mark up sw-fence notify function URL : https://patchwork.freedesktop.org/series/74605/ State : success == Summary == CI Bug Log - changes from CI_DRM_8125_full -> Patchwork_16942_full

[Intel-gfx] [drm-tip:drm-tip 3/8] include/drm/drm_modeset_helper_vtables.h:859: undefined reference to `drm_connector_attach_encoder'

2020-03-12 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: 2e46e269a2843c5d0b6c72bfb7fa9d9913c15415 commit: 1be88a0837ab2a7e95a5177877a9b344f9e6a3e3 [3/8] Merge remote-tracking branch 'drm/drm-next' into drm-tip config: riscv-randconfig-a001-20200312 (attached as .config) compile

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915: Add Wa_1207131216:icl,ehl

2020-03-12 Thread Souza, Jose
On Wed, 2020-03-11 at 09:22 -0700, Matt Roper wrote: > On gen11 the XY_FAST_COPY_BLT command has some size restrictions on > its > usage. Although this instruction is mainly used by userspace, i915 > also > uses it to copy object contents during some selftests, so let's > ensure > the restrictions

Re: [Intel-gfx] [PATCH] drm/mm: Use debugobject to track lifetimes

2020-03-12 Thread kbuild test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.6-rc5 next-20200312] [if your patch is applied to the wrong git tree, please

Re: [Intel-gfx] [PATCH 4/7] drm/i915/perf: add new open param to configure polling of OA buffer

2020-03-12 Thread Lionel Landwerlin
On 12/03/2020 21:27, Dixit, Ashutosh wrote: On Tue, 03 Mar 2020 14:19:02 -0800, Umesh Nerlige Ramappa wrote: From: Lionel Landwerlin This new parameter let's the application choose how often the OA buffer should be checked on the CPU side for data availability. Longer polling period tend to re

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Mark up sw-fence notify function

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915/gem: Mark up sw-fence notify function URL : https://patchwork.freedesktop.org/series/74604/ State : success == Summary == CI Bug Log - changes from CI_DRM_8124_full -> Patchwork_16941_full Summary -

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Wrap i915_active in a simple kreffed struct

2020-03-12 Thread Ruhl, Michael J
>-Original Message- >From: Intel-gfx On Behalf Of Chris >Wilson >Sent: Wednesday, March 11, 2020 9:31 AM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH 02/12] drm/i915: Wrap i915_active in a simple >kreffed struct > >For conveniences of callers that just want to use an i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915 Support for integrated privacy screen

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915 Support for integrated privacy screen URL : https://patchwork.freedesktop.org/series/74650/ State : success == Summary == CI Bug Log - changes from CI_DRM_8127 -> Patchwork_16957 Summary --- **SU

Re: [Intel-gfx] [PATCH 4/7] drm/i915/perf: add new open param to configure polling of OA buffer

2020-03-12 Thread Dixit, Ashutosh
On Tue, 03 Mar 2020 14:19:02 -0800, Umesh Nerlige Ramappa wrote: > > From: Lionel Landwerlin > > This new parameter let's the application choose how often the OA > buffer should be checked on the CPU side for data availability. Longer > polling period tend to reduce CPU overhead if the application

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915 Support for integrated privacy screen

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915 Support for integrated privacy screen URL : https://patchwork.freedesktop.org/series/74650/ State : warning == Summary == $ dim checkpatch origin/drm-tip a0d97f65392d intel_acpi: Rename drm_dev local variable to dev 500f89acca9c drm/connector: Add support

[Intel-gfx] [PATCH v9 4/5] drm/i915: Add helper code for ACPI privacy screen

2020-03-12 Thread Rajat Jain
Add helper functions that can allow i915 to detect and control an integrated privacy screen via ACPI methods. These shall be used in the next patch. Signed-off-by: Rajat Jain --- v9: same as v8 v8: Initial version. formed by refactoring the previous patch 4. print the connector name in the de

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Take a copy of the engines for context_barrier_task (rev3)

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915/gem: Take a copy of the engines for context_barrier_task (rev3) URL : https://patchwork.freedesktop.org/series/74583/ State : success == Summary == CI Bug Log - changes from CI_DRM_8124_full -> Patchwork_16937_full =

[Intel-gfx] ✓ Fi.CI.BAT: success for Gen11 workarounds (rev5)

2020-03-12 Thread Patchwork
== Series Details == Series: Gen11 workarounds (rev5) URL : https://patchwork.freedesktop.org/series/74475/ State : success == Summary == CI Bug Log - changes from CI_DRM_8127 -> Patchwork_16956 Summary --- **SUCCESS** No regressi

Re: [Intel-gfx] [PATCH] drm/i915/gem: Drop relocation slowpath

2020-03-12 Thread Matthew Auld
On Wed, 11 Mar 2020 at 16:03, Chris Wilson wrote: > > Since the relocations are no longer performed under a global > struct_mutex, or any other lock, that is also held by pagefault handlers, > we can relax and allow our fast path to take a fault. As we no longer > need to abort the fast path for l

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Use igt_random_offset()

2020-03-12 Thread Chris Wilson
Quoting Matthew Auld (2020-03-12 17:00:58) > On Thu, 12 Mar 2020 at 15:47, Chris Wilson wrote: > > > > Switch igt_vm_isolation() to using igt_random_offset(). > > > > Signed-off-by: Chris Wilson > > Cc: Matthew Auld > > Cc: Akeem G Abodunrin > > --- > > drivers/gpu/drm/i915/gem/selftests/i915_

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/perf: introduce global sseu pinning

2020-03-12 Thread Tvrtko Ursulin
On 06/03/2020 10:05, Lionel Landwerlin wrote: On Gen11 powergating half the execution units is a functional requirement when using the VME samplers. Not fullfilling this requirement can lead to hangs. This unfortunately plays fairly poorly with the NOA requirements. NOA requires a stable power

Re: [Intel-gfx] [PATCH v2] drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only

2020-03-12 Thread Ville Syrjälä
On Thu, Mar 12, 2020 at 07:27:58PM +0200, Kai Vehmanen wrote: > Hey, > > On Tue, 10 Mar 2020, Ville Syrjälä wrote: > > > On Tue, Mar 10, 2020 at 07:18:58PM +0200, Kai Vehmanen wrote: > >> On Tue, 10 Mar 2020, Ville Syrjälä wrote: > >>> audio at init time. And we could maybe try to remove the mode

Re: [Intel-gfx] [PATCH v2] drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only

2020-03-12 Thread Ville Syrjälä
On Thu, Mar 12, 2020 at 07:27:58PM +0200, Kai Vehmanen wrote: > Hey, > > On Tue, 10 Mar 2020, Ville Syrjälä wrote: > > > On Tue, Mar 10, 2020 at 07:18:58PM +0200, Kai Vehmanen wrote: > >> On Tue, 10 Mar 2020, Ville Syrjälä wrote: > >>> audio at init time. And we could maybe try to remove the mode

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915/perf: remove redundant power configuration register override

2020-03-12 Thread Tvrtko Ursulin
On 06/03/2020 10:05, Lionel Landwerlin wrote: The caller of i915_oa_init_reg_state() already sets this. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_perf.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i9

Re: [Intel-gfx] [PATCH v2] drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only

2020-03-12 Thread Kai Vehmanen
Hey, On Tue, 10 Mar 2020, Ville Syrjälä wrote: > On Tue, Mar 10, 2020 at 07:18:58PM +0200, Kai Vehmanen wrote: >> On Tue, 10 Mar 2020, Ville Syrjälä wrote: >>> audio at init time. And we could maybe try to remove the modeset from the >>> put_power() so that at least if you get a blink it's just t

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Drop relocation slowpath

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915/gem: Drop relocation slowpath URL : https://patchwork.freedesktop.org/series/74592/ State : success == Summary == CI Bug Log - changes from CI_DRM_8124_full -> Patchwork_16934_full Summary --- **

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Use igt_random_offset()

2020-03-12 Thread Matthew Auld
On Thu, 12 Mar 2020 at 15:47, Chris Wilson wrote: > > Switch igt_vm_isolation() to using igt_random_offset(). > > Signed-off-by: Chris Wilson > Cc: Matthew Auld > Cc: Akeem G Abodunrin > --- > drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 8 +++- > 1 file changed, 3 insertions(+)

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Add Wa_1605460711 / Wa_1408767742 to ICL and EHL

2020-03-12 Thread Mika Kuoppala
Matt Roper writes: > This workaround appears under two different numbers (and with somewhat > confused stepping applicability on ICL). Ultimately it appears we > should just implement this for all stepping of ICL and EHL. > > Note that this is identical to Wa_1407928979:tgl that already exists i

Re: [Intel-gfx] [PATCH 1/6] lib/scatterlist: add sg_set_dma_addr() function

2020-03-12 Thread Logan Gunthorpe
On 2020-03-12 8:19 a.m., Jason Gunthorpe wrote: > On Thu, Mar 12, 2020 at 03:47:29AM -0700, Christoph Hellwig wrote: >> On Thu, Mar 12, 2020 at 11:31:35AM +0100, Christian König wrote: >>> But how should we then deal with all the existing interfaces which already >>> take a scatterlist/sg_table ?

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Use igt_random_offset()

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Use igt_random_offset() URL : https://patchwork.freedesktop.org/series/74649/ State : success == Summary == CI Bug Log - changes from CI_DRM_8127 -> Patchwork_16955 Summary --- **SUCCE

Re: [Intel-gfx] [PATCH v2 5/6] drm/i915: Apply Wa_1406680159:icl, ehl as an engine workaround

2020-03-12 Thread Mika Kuoppala
Matt Roper writes: > The register this workaround updates is a render engine register in the > MCR range, so we should initialize this in rcs_engine_wa_init() rather > than gt_wa_init(). > > Closes: https://gitlab.freedesktop.org/drm/intel/issues/1222 > Fixes: 36204d80bacb ("drm/i915/icl: Wa_1406

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Handle all MCR ranges

2020-03-12 Thread Mika Kuoppala
Matt Roper writes: > The bspec documents multiple MCR ranges; make sure they're all captured > by the driver. > > Bspec: 13991, 52079 > Fixes: 592a7c5e082e ("drm/i915: Extend non readable mcr range") Yeah it seems that the ranges drip feed into documentation slowly. > Cc: Mika Kuoppala > Signe

Re: [Intel-gfx] ***UNCHECKED*** Re: [PATCH] drm/i915/gt: Wait for RCUs frees before asserting idle on unload

2020-03-12 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-12 14:18:26) > > On 12/03/2020 11:53, Chris Wilson wrote: > > During driver unload, we have many asserts that we have released our > > bookkeeping structs and are idle. In some cases, these struct are > > protected by RCU and we do not release them until after an RC

Re: [Intel-gfx] [RFC][PATCH 0/5] Introduce drm scaling filter property

2020-03-12 Thread Ville Syrjälä
On Thu, Mar 12, 2020 at 03:37:03PM +, Laxminarayan Bharadiya, Pankaj wrote: > > > > -Original Message- > > From: Ville Syrjälä > > Sent: 12 March 2020 19:35 > > To: Laxminarayan Bharadiya, Pankaj > > > > Cc: jani.nik...@linux.intel.com; dan...@ffwll.ch; intel- > > g...@lists.freedes

Re: [Intel-gfx] [PATCH] drm/i915/gt: Wait for RCUs frees before asserting idle on unload

2020-03-12 Thread Mika Kuoppala
Chris Wilson writes: > During driver unload, we have many asserts that we have released our > bookkeeping structs and are idle. In some cases, these struct are > protected by RCU and we do not release them until after an RCU grace > period. > > Reported-by: Maarten Lankhorst > Fixes: 130a95e9098

[Intel-gfx] [PATCH] drm/i915/selftests: Use igt_random_offset()

2020-03-12 Thread Chris Wilson
Switch igt_vm_isolation() to using igt_random_offset(). Signed-off-by: Chris Wilson Cc: Matthew Auld Cc: Akeem G Abodunrin --- drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/selftests/i9

Re: [Intel-gfx] [PATCH 1/6] lib/scatterlist: add sg_set_dma_addr() function

2020-03-12 Thread Christian König
Am 12.03.20 um 15:19 schrieb Jason Gunthorpe: On Thu, Mar 12, 2020 at 03:47:29AM -0700, Christoph Hellwig wrote: On Thu, Mar 12, 2020 at 11:31:35AM +0100, Christian König wrote: But how should we then deal with all the existing interfaces which already take a scatterlist/sg_table ? The whole D

Re: [Intel-gfx] [RFC][PATCH 0/5] Introduce drm scaling filter property

2020-03-12 Thread Laxminarayan Bharadiya, Pankaj
> -Original Message- > From: Ville Syrjälä > Sent: 12 March 2020 19:35 > To: Laxminarayan Bharadiya, Pankaj > > Cc: jani.nik...@linux.intel.com; dan...@ffwll.ch; intel- > g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; airl...@linux.ie; > maarten.lankho...@linux.intel.com;

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915 lpsp support for lpsp igt

2020-03-12 Thread Patchwork
== Series Details == Series: i915 lpsp support for lpsp igt URL : https://patchwork.freedesktop.org/series/74648/ State : failure == Summary == Couldn't find any build artifact matching "Test-with: 20200312135642.13845-2-anshuman.gu...@intel.com"\nCheck that the msg-id is correct and make su

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/mm: Use debugobject to track lifetimes (rev3)

2020-03-12 Thread Patchwork
== Series Details == Series: drm/mm: Use debugobject to track lifetimes (rev3) URL : https://patchwork.freedesktop.org/series/74638/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8127 -> Patchwork_16953 Summary --- *

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/mm: Use debugobject to track lifetimes (rev3)

2020-03-12 Thread Patchwork
== Series Details == Series: drm/mm: Use debugobject to track lifetimes (rev3) URL : https://patchwork.freedesktop.org/series/74638/ State : warning == Summary == $ dim checkpatch origin/drm-tip c869cbdfdc9f drm/mm: Use debugobject to track lifetimes -:301: WARNING:TYPO_SPELLING: 'compatiblity

Re: [Intel-gfx] [PATCH] drm/i915/gt: Wait for RCUs frees before asserting idle on unload

2020-03-12 Thread Tvrtko Ursulin
On 12/03/2020 11:53, Chris Wilson wrote: During driver unload, we have many asserts that we have released our bookkeeping structs and are idle. In some cases, these struct are protected by RCU and we do not release them until after an RCU grace period. Reported-by: Maarten Lankhorst Fixes: 13

[Intel-gfx] [PATCH 0/2] i915 lpsp support for lpsp igt

2020-03-12 Thread Anshuman Gupta
This series adds i915_lpsp_info connector debugfs. Test-with: 20200312135642.13845-2-anshuman.gu...@intel.com Anshuman Gupta (2): drm/i915: Power well id for ICL PG3 drm/i915: Add i915_lpsp_info debugfs .../drm/i915/display/intel_display_debugfs.c | 65 +++ .../drm/i915/dis

[Intel-gfx] [PATCH 2/2] drm/i915: Add i915_lpsp_info debugfs

2020-03-12 Thread Anshuman Gupta
New i915_pm_lpsp igt solution approach relies on connector specific debugfs attribute i915_lpsp_info, it exposes whether an output is capable of driving lpsp and exposes lpsp enablement info. Signed-off-by: Anshuman Gupta --- .../drm/i915/display/intel_display_debugfs.c | 65 +++

[Intel-gfx] [PATCH 1/2] drm/i915: Power well id for ICL PG3

2020-03-12 Thread Anshuman Gupta
Gen11 onwards PG3 is contains functions for pipe B, external displays, and VGA. It make sense to add a power well id with name ICL_DISP_PW_3 rather then TGL_DISP_PW_3, Also PG3 power well id requires to know if lpsp is enabled. Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gen12: Disable preemption timeout (rev4)

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915/gen12: Disable preemption timeout (rev4) URL : https://patchwork.freedesktop.org/series/74526/ State : success == Summary == CI Bug Log - changes from CI_DRM_8126 -> Patchwork_16952 Summary --- *

Re: [Intel-gfx] [RFC][PATCH 0/5] Introduce drm scaling filter property

2020-03-12 Thread Ville Syrjälä
On Tue, Feb 25, 2020 at 12:35:40PM +0530, Pankaj Bharadiya wrote: > Integer scaling (IS) is a nearest-neighbor upscaling technique that > simply scales up the existing pixels by an integer (i.e., whole > number) multiplier. Nearest-neighbor (NN) interpolation works by > filling in the missing color

Re: [Intel-gfx] [RFC][PATCH 5/5] drm/i915/display: Add Nearest-neighbor based integer scaling support

2020-03-12 Thread Ville Syrjälä
On Thu, Mar 12, 2020 at 09:13:24AM +, Laxminarayan Bharadiya, Pankaj wrote: > > > > -Original Message- > > From: Ville Syrjälä > > Sent: 10 March 2020 21:47 > > To: Laxminarayan Bharadiya, Pankaj > > > > Cc: jani.nik...@linux.intel.com; dan...@ffwll.ch; intel- > > g...@lists.freedes

Re: [Intel-gfx] [PATCH v4 1/3] drm/i915/perf: remove generated code

2020-03-12 Thread Dan Carpenter
Hi Lionel, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Lionel-Landwerlin/drm-i915-perf-remove-generated-code/20200307-024544 base: git://anongit.freedesktop.org/drm-intel for-linux-next If you fix the issue, kindly add following tag

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Wait for RCUs frees before asserting idle on unload

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915/gt: Wait for RCUs frees before asserting idle on unload URL : https://patchwork.freedesktop.org/series/74645/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8126 -> Patchwork_16951 Summa

Re: [Intel-gfx] [PATCH] drm/i915/perf: Invalidate OA TLB on when closing perf stream

2020-03-12 Thread Lionel Landwerlin
On 10/03/2020 11:03, Lionel Landwerlin wrote: On 09/03/2020 23:10, Umesh Nerlige Ramappa wrote: On running several back to back perf capture sessions involving closing and opening the perf stream, invalid OA reports are seen in the beginning of the OA buffer in some sessions. Fix this by invalid

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Add request throughput measurement to perf

2020-03-12 Thread Tvrtko Ursulin
On 11/03/2020 10:49, Chris Wilson wrote: Under ideal circumstances, the driver should be able to keep the GPU fully saturated with work. Measure how close to ideal we get under the harshest of conditions with no user payload. v2: Also measure throughput using only one thread. Signed-off-by: C

Re: [Intel-gfx] [PATCH 1/6] lib/scatterlist: add sg_set_dma_addr() function

2020-03-12 Thread Christoph Hellwig
On Thu, Mar 12, 2020 at 11:14:22AM +0100, Christian König wrote: > > > The page pointer is set to NULL and only the DMA address, > > > length and offset values are valid. > > NAK. The only valid way to fill DMA address in scatterlists is > > dma_map_sg / dma_map_sg_attr. > > How can we then map P

Re: [Intel-gfx] [PATCH 1/6] lib/scatterlist: add sg_set_dma_addr() function

2020-03-12 Thread Christoph Hellwig
On Thu, Mar 12, 2020 at 11:31:35AM +0100, Christian König wrote: > But how should we then deal with all the existing interfaces which already > take a scatterlist/sg_table ? > > The whole DMA-buf design and a lot of drivers are build around > scatterlist/sg_table and to me that actually makes quite

Re: [Intel-gfx] [PATCH 1/6] lib/scatterlist: add sg_set_dma_addr() function

2020-03-12 Thread Christoph Hellwig
On Wed, Mar 11, 2020 at 02:51:53PM +0100, Christian König wrote: > This can be used by drivers to setup P2P DMA between device > memory which is not backed by struct pages. > > The drivers of the involved devices are responsible for > setting up and tearing down DMA addresses as necessary > using

Re: [Intel-gfx] [PATCH 1/6] lib/scatterlist: add sg_set_dma_addr() function

2020-03-12 Thread Christian König
Am 11.03.20 um 16:28 schrieb Christoph Hellwig: On Wed, Mar 11, 2020 at 02:51:53PM +0100, Christian König wrote: This can be used by drivers to setup P2P DMA between device memory which is not backed by struct pages. The drivers of the involved devices are responsible for setting up and tearing

[Intel-gfx] ✗ Fi.CI.BAT: failure for Introduce drm scaling filter property (rev2)

2020-03-12 Thread Patchwork
== Series Details == Series: Introduce drm scaling filter property (rev2) URL : https://patchwork.freedesktop.org/series/73883/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8126 -> Patchwork_16950 Summary --- **FAIL

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only (rev3)

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only (rev3) URL : https://patchwork.freedesktop.org/series/71525/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8121_full -> Patchwork_16933_full ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce drm scaling filter property (rev2)

2020-03-12 Thread Patchwork
== Series Details == Series: Introduce drm scaling filter property (rev2) URL : https://patchwork.freedesktop.org/series/73883/ State : warning == Summary == $ dim checkpatch origin/drm-tip 38e9b95fbc63 drm: Introduce plane and CRTC scaling filter properties -:136: CHECK:PARENTHESIS_ALIGNMENT:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/mm: Use debugobject to track lifetimes (rev2)

2020-03-12 Thread Patchwork
== Series Details == Series: drm/mm: Use debugobject to track lifetimes (rev2) URL : https://patchwork.freedesktop.org/series/74638/ State : success == Summary == CI Bug Log - changes from CI_DRM_8126 -> Patchwork_16949 Summary --- *

Re: [Intel-gfx] [PATCH v3] drm/i915/gen12: Disable preemption timeout

2020-03-12 Thread Mrozek, Michal
> -Original Message- > From: Tvrtko Ursulin > Sent: Thursday, March 12, 2020 12:58 PM > To: Intel-gfx@lists.freedesktop.org > Cc: Ursulin, Tvrtko ; Chris Wilson wilson.co.uk>; Joonas Lahtinen ; Mrozek, > Michal ; sta...@vger.kernel.org > Subject: [PATCH v3] drm/i915/gen12: Disable preempt

Re: [Intel-gfx] [RFC][PATCH 3/5] drm/i915: Enable scaling filter for plane and pipe

2020-03-12 Thread Ville Syrjälä
On Thu, Mar 12, 2020 at 08:58:42AM +, Laxminarayan Bharadiya, Pankaj wrote: > > > > -Original Message- > > From: Ville Syrjälä > > Sent: 10 March 2020 21:36 > > To: Laxminarayan Bharadiya, Pankaj > > > > Cc: jani.nik...@linux.intel.com; dan...@ffwll.ch; intel- > > g...@lists.freedes

[Intel-gfx] [PATCH] drm/mm: Use debugobject to track lifetimes

2020-03-12 Thread Chris Wilson
Since drm_mm_node are intended to be embedded into larger structs, we can use the DEBUG_OBJECTS facility to help track the lifetime of the drm_mm_node and ensure that they are not being used after the containing object has been freed, along with the usual verification that the drm_mm_nodes are bein

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/mm: Use debugobject to track lifetimes (rev2)

2020-03-12 Thread Patchwork
== Series Details == Series: drm/mm: Use debugobject to track lifetimes (rev2) URL : https://patchwork.freedesktop.org/series/74638/ State : warning == Summary == $ dim checkpatch origin/drm-tip 99485e1feb1b drm/mm: Use debugobject to track lifetimes -:199: WARNING:TYPO_SPELLING: 'compatiblity

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] lib/i915/perf: remove generation code for mathml render

2020-03-12 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] lib/i915/perf: remove generation code for mathml render URL : https://patchwork.freedesktop.org/series/74641/ State : success == Summary == CI Bug Log - changes from IGT_5506 -> IGTPW_4298 =

[Intel-gfx] [PATCH v3] drm/i915/gen12: Disable preemption timeout

2020-03-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Allow super long OpenCL workloads which cannot be preempted within the default timeout to run out of the box. v2: * Make it stick out more and apply only to RCS. (Chris) v3: * Mention platform override in kconfig. (Joonas) Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson

[Intel-gfx] [PATCH v3] drm/i915/gen12: Disable preemption timeout

2020-03-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Allow super long OpenCL workloads which cannot be preempted within the default timeout to run out of the box. v2: * Make it stick out more and apply only to RCS. (Chris) v3: * Mention platform override in kconfig. (Joonas) Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson

[Intel-gfx] [PATCH] drm/i915/gt: Wait for RCUs frees before asserting idle on unload

2020-03-12 Thread Chris Wilson
During driver unload, we have many asserts that we have released our bookkeeping structs and are idle. In some cases, these struct are protected by RCU and we do not release them until after an RCU grace period. Reported-by: Maarten Lankhorst Fixes: 130a95e9098e ("drm/i915/gem: Consolidate ctx->e

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Adjust PM QoS response frequency based on GPU load.

2020-03-12 Thread Tvrtko Ursulin
On 11/03/2020 19:54, Francisco Jerez wrote: Tvrtko Ursulin writes: On 10/03/2020 22:26, Chris Wilson wrote: Quoting Francisco Jerez (2020-03-10 21:41:55) diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index b9b3f78f1324..a5d7a80b826d 100644 --- a/dr

[Intel-gfx] ✗ GitLab.Pipeline: warning for series starting with [v2,1/3] lib/i915/perf: remove generation code for mathml render

2020-03-12 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] lib/i915/perf: remove generation code for mathml render URL : https://patchwork.freedesktop.org/series/74641/ State : warning == Summary == Did not get list of undocumented tests for this run, something is wrong! Other than that, pip

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable non-contiguous pipe fusing

2020-03-12 Thread Vudum, Lakshminarayana
Yes, that's a known issue, #656. Re-reported the results and all good now. Thanks, Lakshmi. -Original Message- From: Gupta, Anshuman Sent: Thursday, March 12, 2020 1:09 PM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana Subject: Re: ✗ Fi.CI.BAT: failure for drm/i915: Enable

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable non-contiguous pipe fusing

2020-03-12 Thread Patchwork
== Series Details == Series: drm/i915: Enable non-contiguous pipe fusing URL : https://patchwork.freedesktop.org/series/74570/ State : success == Summary == CI Bug Log - changes from CI_DRM_8113 -> Patchwork_16920 Summary --- **SUCCE

[Intel-gfx] [PATCH 5/5] drm/i915: Enable scaling filter for plane and CRTC

2020-03-12 Thread Pankaj Bharadiya
GEN >= 10 hardware supports the programmable scaler filter. Attach scaling filter property for CRTC and plane for GEN >= 10 hardwares and program scaler filter based on the selected filter type. Changes since RFC: * Enable properties for GEN >= 10 platforms (Ville) * Do not round off the crtc co-

[Intel-gfx] [PATCH 4/5] drm/i915/display: Add Nearest-neighbor based integer scaling support

2020-03-12 Thread Pankaj Bharadiya
Integer scaling (IS) is a nearest-neighbor upscaling technique that simply scales up the existing pixels by an integer (i.e., whole number) multiplier.Nearest-neighbor (NN) interpolation works by filling in the missing color values in the upscaled image with that of the coordinate-mapped nearest so

  1   2   >