[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Add definitions for VRR registers and bits (rev3)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add definitions for VRR registers and bits (rev3) URL : https://patchwork.freedesktop.org/series/74410/ State : success == Summary == CI Bug Log - changes from CI_DRM_8156_full -> Patchwork_17019_full

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Add new PCI IDs to TGL (rev2)

2020-03-18 Thread Matt Roper
On Thu, Mar 19, 2020 at 01:49:23AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/tgl: Add new PCI IDs to TGL (rev2) > URL : https://patchwork.freedesktop.org/series/74795/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_8154_full ->

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Add definitions for VRR registers and bits (rev3)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add definitions for VRR registers and bits (rev3) URL : https://patchwork.freedesktop.org/series/74410/ State : success == Summary == CI Bug Log - changes from CI_DRM_8156 -> Patchwork_17019

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Add definitions for VRR registers and bits (rev3)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add definitions for VRR registers and bits (rev3) URL : https://patchwork.freedesktop.org/series/74410/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0a8a0885ae09 drm/i915/tgl: Add definitions for VRR registers and bits -:24:

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/6] drm/i915/tc/tgl: Implement TCCOLD sequences

2020-03-18 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915/tc/tgl: Implement TCCOLD sequences URL : https://patchwork.freedesktop.org/series/74851/ State : success == Summary == CI Bug Log - changes from CI_DRM_8154_full -> Patchwork_17018_full

[Intel-gfx] [PATCH v4] drm/i915/tgl: Add definitions for VRR registers and bits

2020-03-18 Thread Aditya Swarup
Add definitions for registers grouped under Transcoder VRR function with necessary bitfields. Bspec: 49268 v2: Use REG_GENMASK, correct tabs/space indentation and move the definitions near the transcoder section.(Jani) v3: Remove unnecessary prefix from bit/mask definitions.(Manasi) v4: Use

[Intel-gfx] [PATCH v4] drm/i915/tgl: Add definitions for VRR registers and bits

2020-03-18 Thread Aditya Swarup
Add definitions for registers grouped under Transcoder VRR function with necessary bitfields. Bspec: 49268 v2: Use REG_GENMASK, correct tabs/space indentation and move the definitions near the transcoder section.(Jani) v3: Remove unnecessary prefix from bit/mask definitions.(Manasi) v4: Use

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Add new PCI IDs to TGL (rev2)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add new PCI IDs to TGL (rev2) URL : https://patchwork.freedesktop.org/series/74795/ State : success == Summary == CI Bug Log - changes from CI_DRM_8154_full -> Patchwork_17017_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix crtc nv12 etc. plane bitmasks for DPMS off (rev3)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Fix crtc nv12 etc. plane bitmasks for DPMS off (rev3) URL : https://patchwork.freedesktop.org/series/74346/ State : success == Summary == CI Bug Log - changes from CI_DRM_8154_full -> Patchwork_17016_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915/tc/tgl: Implement TCCOLD sequences

2020-03-18 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915/tc/tgl: Implement TCCOLD sequences URL : https://patchwork.freedesktop.org/series/74851/ State : success == Summary == CI Bug Log - changes from CI_DRM_8154 -> Patchwork_17018

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Port sync for skl+ (rev3)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Port sync for skl+ (rev3) URL : https://patchwork.freedesktop.org/series/74691/ State : success == Summary == CI Bug Log - changes from CI_DRM_8154_full -> Patchwork_17014_full Summary ---

[Intel-gfx] [PATCH 2/6] drm/i915/display: Add intel_display_power_get_without_ack()

2020-03-18 Thread José Roberto de Souza
To implement ICL TC static sequences is required to get the port aux powerwell without wait for hardware ack. Cc: Imre Deak Cc: Cooper Chiou Cc: Kai-Heng Feng Signed-off-by: José Roberto de Souza --- .../drm/i915/display/intel_display_power.c| 71 +++

[Intel-gfx] [PATCH 5/6] drm/i915/tc/icl: Implement the TC cold exit sequence

2020-03-18 Thread José Roberto de Souza
This is required for legacy/static TC ports as IOM is not aware of the connection and will not trigger the TC cold exit. Just request PCODE to exit TCCOLD is not enough as it could enter again be driver makes use of the port, to prevent it BSpec states that aux powerwell should be held. So

[Intel-gfx] [PATCH 6/6] drm/i915/dp: Get TC link reference during DP detection

2020-03-18 Thread José Roberto de Souza
As now the cost to lock and use a TC port is higher due the implementation of the TCCOLD sequences it is worty to hold a reference of the TC port to avoid all this locking at every aux transaction part of the DisplayPort detection. Cc: Imre Deak Cc: Cooper Chiou Cc: Kai-Heng Feng

[Intel-gfx] [PATCH 4/6] drm/i915/display: Add intel_aux_ch_to_power_domain()

2020-03-18 Thread José Roberto de Souza
This is a similar function to intel_aux_power_domain() but it do not care about TBT ports, this will be needed by GEN11 TC sequences. Cc: Imre Deak Cc: Cooper Chiou Cc: Kai-Heng Feng Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display.c | 14 --

[Intel-gfx] [PATCH 3/6] drm/i915/display: Implement intel_display_power_wait_enable_ack()

2020-03-18 Thread José Roberto de Souza
This function is meant to be used after intel_display_power_get_without_ack() this way we can be sure that the HW tied to the powerdomain will be powered and ready. Cc: Imre Deak Cc: Cooper Chiou Cc: Kai-Heng Feng Signed-off-by: José Roberto de Souza ---

[Intel-gfx] [PATCH 1/6] drm/i915/tc/tgl: Implement TCCOLD sequences

2020-03-18 Thread José Roberto de Souza
TC ports can enter in TCCOLD to save power and is required to request to PCODE to exit this state before use or read to TC registers. For TGL there is a new MBOX command to do that with a parameter to ask PCODE to exit and block TCCOLD entry or unblock TCCOLD entry. For GEN11 the sequence is more

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Add new PCI IDs to TGL (rev2)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add new PCI IDs to TGL (rev2) URL : https://patchwork.freedesktop.org/series/74795/ State : success == Summary == CI Bug Log - changes from CI_DRM_8154 -> Patchwork_17017 Summary ---

Re: [Intel-gfx] [PATCH 08/13] drm/i915: Implement port sync for SKL+

2020-03-18 Thread Manasi Navare
On Fri, Mar 13, 2020 at 06:48:26PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Transcoder port sync was introduced to the hardware in BDW. We > can trivially enable it for SKL+ since the same codepaths are > already used for ICL+ port sync. The only difference is the actual > location

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix crtc nv12 etc. plane bitmasks for DPMS off (rev3)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Fix crtc nv12 etc. plane bitmasks for DPMS off (rev3) URL : https://patchwork.freedesktop.org/series/74346/ State : success == Summary == CI Bug Log - changes from CI_DRM_8154 -> Patchwork_17016

Re: [Intel-gfx] [PATCH 06/13] drm/i915: Include port sync state in the state dump

2020-03-18 Thread Manasi Navare
On Fri, Mar 13, 2020 at 06:48:24PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Dump the port sync stat in intel_dump_pipe_config(). > > Signed-off-by: Ville Syrjälä Reviewed-by: Manasi Navare Manasi > --- > drivers/gpu/drm/i915/display/intel_display.c | 5 + > 1 file

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Reject dumb buffers when driver/device doesn't support modesetting (rev2)

2020-03-18 Thread Patchwork
== Series Details == Series: drm: Reject dumb buffers when driver/device doesn't support modesetting (rev2) URL : https://patchwork.freedesktop.org/series/74841/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8154 -> Patchwork_17015

Re: [Intel-gfx] [PATCH 05/13] drm/i915: Use REG_FIELD_PREP() & co. for TRANS_DDI_FUNC_CTL2

2020-03-18 Thread Manasi Navare
On Fri, Mar 13, 2020 at 06:48:23PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Clean up the TRANS_DDI_FUNC_CTL2 programming/readout by > using REG_FIELD_PREP() & co. > > Signed-off-by: Ville Syrjälä Reviewed-by: Manasi Navare Manasi > --- >

Re: [Intel-gfx] [PATCH 04/13] drm/i915: Move icl_get_trans_port_sync_config() into the DDI code

2020-03-18 Thread Manasi Navare
On Fri, Mar 13, 2020 at 06:48:22PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Move the port sync readout into the DDI code where it belongs. > > Signed-off-by: Ville Syrjälä Reviewed-by: Manasi Navare Manasi > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 54

Re: [Intel-gfx] [PATCH 03/13] drm/i915: Drop usless master_transcoder assignments

2020-03-18 Thread Manasi Navare
On Fri, Mar 13, 2020 at 06:48:21PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > The entire crtc state has been reset before readout so > master_transcoder is already set to INVALID. But wont that mean that the master transcoder would be set to 0 on reset and what we want is actually

Re: [Intel-gfx] [PATCH 02/13] drm/i915: Move TRANS_DDI_FUNC_CTL2 programming where it belongs

2020-03-18 Thread Manasi Navare
On Fri, Mar 13, 2020 at 06:48:20PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > This port sync enable/disable stuff is misplaced. It's just another step > of the normal TRANS_DDI_FUNC_CTL enable. Move it to its natural place. > > Signed-off-by: Ville Syrjälä > --- >

[Intel-gfx] [PATCH] drm/i915/tgl: Add new PCI IDs to TGL

2020-03-18 Thread Swathi Dhanavanthri
Adding 4 new PCI IDs to TGL Bspec: 44455 Signed-off-by: Swathi Dhanavanthri --- include/drm/i915_pciids.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 1d2c12219f44..662d8351c87a 100644 ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Port sync for skl+ (rev3)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Port sync for skl+ (rev3) URL : https://patchwork.freedesktop.org/series/74691/ State : success == Summary == CI Bug Log - changes from CI_DRM_8154 -> Patchwork_17014 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/execlists: Force single submission for sentinels

2020-03-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Force single submission for sentinels URL : https://patchwork.freedesktop.org/series/74845/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8154 -> Patchwork_17013

Re: [Intel-gfx] [PATCH v3] drm/i915/tgl: Add definitions for VRR registers and bits

2020-03-18 Thread Manasi Navare
Thanks for the revised patch, just one nitcpick below: On Fri, Mar 06, 2020 at 07:42:38PM -0800, Aditya Swarup wrote: > Add definitions for registers grouped under Transcoder VRR function > with necessary bitfields. > > Bspec: 49268 > > v2: Use REG_GENMASK, correct tabs/space indentation and

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Port sync for skl+ (rev3)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Port sync for skl+ (rev3) URL : https://patchwork.freedesktop.org/series/74691/ State : warning == Summary == $ dim checkpatch origin/drm-tip 72dac032db0d drm/i915/mst: Use .compute_config_late() to compute master transcoder 0124ef44a60a drm/i915: Move

Re: [Intel-gfx] [PATCH] drm: Reject dumb buffers when driver/device doesn't support modesetting

2020-03-18 Thread Ville Syrjälä
On Wed, Mar 18, 2020 at 01:31:07PM -0700, Matt Roper wrote: > On Wed, Mar 18, 2020 at 05:49:59PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently a driver must not provide a .dumb_create() hook in the > > drm_driver structure if it wants to declare dumb buffers as not > >

Re: [Intel-gfx] [PATCH] drm: Reject dumb buffers when driver/device doesn't support modesetting

2020-03-18 Thread Matt Roper
On Wed, Mar 18, 2020 at 05:49:59PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently a driver must not provide a .dumb_create() hook in the > drm_driver structure if it wants to declare dumb buffers as not > supported. So if the same driver wants to support both modeset > and

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add new PCI IDs to TGL

2020-03-18 Thread Matt Roper
On Tue, Mar 17, 2020 at 01:12:04PM -0700, Swathi Dhanavanthri wrote: > Adding 4 new PCI IDs to TGL > Bspec: 44455 > > Signed-off-by: Swathi Dhanavanthri > --- > include/drm/i915_pciids.h | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/include/drm/i915_pciids.h

Re: [Intel-gfx] [PATCH 07/10] cpufreq: intel_pstate: Implement VLP controller for HWP parts.

2020-03-18 Thread Francisco Jerez
"Pandruvada, Srinivas" writes: > On Wed, 2020-03-18 at 12:51 -0700, Francisco Jerez wrote: >> "Pandruvada, Srinivas" writes: >> >> > On Tue, 2020-03-10 at 14:42 -0700, Francisco Jerez wrote: >> > > This implements a simple variably low-pass-filtering governor in >> > > control of the HWP

Re: [Intel-gfx] [PATCH 07/10] cpufreq: intel_pstate: Implement VLP controller for HWP parts.

2020-03-18 Thread Pandruvada, Srinivas
On Wed, 2020-03-18 at 12:51 -0700, Francisco Jerez wrote: > "Pandruvada, Srinivas" writes: > > > On Tue, 2020-03-10 at 14:42 -0700, Francisco Jerez wrote: > > > This implements a simple variably low-pass-filtering governor in > > > control of the HWP MIN/MAX PERF range based on the previously >

Re: [Intel-gfx] [PATCH v6 6/7] drm/i915/dp: Register definition for DP compliance register

2020-03-18 Thread Manasi Navare
On Wed, Mar 18, 2020 at 12:05:14PM +0530, Animesh Manna wrote: > DP_COMP_CTL and DP_COMP_PAT register used to program DP > compliance pattern. > > v1: Initial patch. > v2: used pipe instead of port in macro definition. [Manasi] > v3: used trans_offset for offset calculation. [Manasi] > >

Re: [Intel-gfx] [PATCH] drm: Skip drm_mode_config_validate() for !modeset

2020-03-18 Thread Ville Syrjälä
On Wed, Mar 18, 2020 at 06:31:16PM +, Chris Wilson wrote: > Quoting Ville Syrjala (2020-03-18 18:25:18) > > From: Ville Syrjälä > > > > drm_mode_config_init() may not have been called when the driver/device > > doesn't support modeset. That will cause drm_mode_config_validate() > > to oops.

Re: [Intel-gfx] [PATCH 07/10] cpufreq: intel_pstate: Implement VLP controller for HWP parts.

2020-03-18 Thread Francisco Jerez
"Pandruvada, Srinivas" writes: > On Tue, 2020-03-10 at 14:42 -0700, Francisco Jerez wrote: >> This implements a simple variably low-pass-filtering governor in >> control of the HWP MIN/MAX PERF range based on the previously >> introduced get_vlp_target_range(). See "cpufreq: intel_pstate: >>

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Adjust PM QoS response frequency based on GPU load.

2020-03-18 Thread Francisco Jerez
Francisco Jerez writes: > Chris Wilson writes: > >> Quoting Francisco Jerez (2020-03-10 21:41:55) >>> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c >>> b/drivers/gpu/drm/i915/gt/intel_lrc.c >>> index b9b3f78f1324..a5d7a80b826d 100644 >>> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c >>> +++

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Skip drm_mode_config_validate() for !modeset

2020-03-18 Thread Patchwork
== Series Details == Series: drm: Skip drm_mode_config_validate() for !modeset URL : https://patchwork.freedesktop.org/series/74843/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8152 -> Patchwork_17012 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 (v3)

2020-03-18 Thread Jani Nikula
On Mon, 16 Mar 2020, Mario Kleiner wrote: > This fixes a problem found on the MacBookPro 2017 Retina panel. > > The panel reports 10 bpc color depth in its EDID, and the > firmware chooses link settings at boot which support enough > bandwidth for 10 bpc (324000 kbit/sec = multiplier 0xc), > but

Re: [Intel-gfx] [PATCH 00/10] drm/i915/display: conversion to drm_device based logging macros

2020-03-18 Thread Jani Nikula
On Wed, 11 Mar 2020, Wambui Karuga wrote: > On Wed, 11 Mar 2020, Jani Nikula wrote: > >> On Mon, 09 Mar 2020, Jani Nikula wrote: >>> Please ignore this, I seem to have some smtp trouble which fails some of >>> tha patches. This will be incomplete. >>> >>> Wambui, I'll resend this later. >> >>

Re: [Intel-gfx] [PATCH v9 01/11] drm/i915: Use 64-bit division macro

2020-03-18 Thread Jani Nikula
On Tue, 17 Mar 2020, Guru Das Srinagesh wrote: > Since the PWM framework is switching struct pwm_state.duty_cycle's > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL > to handle a 64-bit dividend. > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: David Airlie > Cc: Daniel

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Port sync for skl+ (rev2)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Port sync for skl+ (rev2) URL : https://patchwork.freedesktop.org/series/74691/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8152 -> Patchwork_17011 Summary --- **FAILURE**

[Intel-gfx] [PATCH 2/2] drm/i915/gem: Wait until the context is finally retired before releasing engines

2020-03-18 Thread Chris Wilson
If we want to percolate information back from the HW, up through the GEM context, we need to wait until the intel_context is scheduled out for the last time. This is handled by the retirement of the intel_context's barrier, i.e. by listening to the pulse after the notional unpin. To accommodate

[Intel-gfx] [PATCH 1/2] drm/i915/execlists: Force single submission for sentinels

2020-03-18 Thread Chris Wilson
Currently, we only combine a sentinel request with a max-priority barrier such that a sentinel request is always in ELSP[0] with nothing following it. However, we will want to create similar ELSP[] submissions providing a full-barrier in the submission queue, but without forcing maximum priority.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Port sync for skl+ (rev2)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Port sync for skl+ (rev2) URL : https://patchwork.freedesktop.org/series/74691/ State : warning == Summary == $ dim checkpatch origin/drm-tip d2cdf91643a0 drm/i915/mst: Use .compute_config_late() to compute master transcoder 2c7d28920dca drm/i915: Move

Re: [Intel-gfx] [PATCH] drm: Skip drm_mode_config_validate() for !modeset

2020-03-18 Thread Chris Wilson
Quoting Ville Syrjala (2020-03-18 18:25:18) > From: Ville Syrjälä > > drm_mode_config_init() may not have been called when the driver/device > doesn't support modeset. That will cause drm_mode_config_validate() > to oops. Skip the validation for !modeset. > > TODO: We may want to consider

[Intel-gfx] [PATCH] drm: Skip drm_mode_config_validate() for !modeset

2020-03-18 Thread Ville Syrjala
From: Ville Syrjälä drm_mode_config_init() may not have been called when the driver/device doesn't support modeset. That will cause drm_mode_config_validate() to oops. Skip the validation for !modeset. TODO: We may want to consider calling drm_mode_config_init() unconditionally to avoid similar

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Reject dumb buffers when driver/device doesn't support modesetting

2020-03-18 Thread Patchwork
== Series Details == Series: drm: Reject dumb buffers when driver/device doesn't support modesetting URL : https://patchwork.freedesktop.org/series/74841/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8151 -> Patchwork_17010

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix crtc nv12 etc. plane bitmasks for DPMS off

2020-03-18 Thread Rodrigo Vivi
On Wed, Mar 18, 2020 at 07:45:15PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > We only consider crtc_state->enable when initially calculating plane > visibility. Later on we try to override the plane's state to invisible > if the crtc is in DPMS off state (crtc_state->active==false). >

[Intel-gfx] [PATCH v2] drm/i915: Fix crtc nv12 etc. plane bitmasks for DPMS off

2020-03-18 Thread Ville Syrjala
From: Ville Syrjälä We only consider crtc_state->enable when initially calculating plane visibility. Later on we try to override the plane's state to invisible if the crtc is in DPMS off state (crtc_state->active==false). Unfortunately the code doing that only updates the plane_state.visible

Re: [Intel-gfx] [PATCH v9] drm/i915/color: Extract icl_read_luts()

2020-03-18 Thread Ville Syrjälä
On Tue, Mar 17, 2020 at 07:27:36PM +0530, Swati Sharma wrote: > For icl+, have hw read out to create hw blob of gamma > lut values. icl+ platforms supports multi segmented gamma > mode by default, add hw lut creation for this mode. > > This will be used to validate gamma programming using dsb >

[Intel-gfx] [PATCH v2 07/13] drm/i915: Store cpu_transcoder_mask in device info

2020-03-18 Thread Ville Syrjala
From: Ville Syrjälä We have a bunch of code that would like to know which CPU transcoders are actually present in the hardware. Rather than use various ad-hoc methods let's just include a full bitmask in the device info, alongside pipe_mask. v2: Rebase Signed-off-by: Ville Syrjälä ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/color: Extract icl_read_luts()

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/color: Extract icl_read_luts() URL : https://patchwork.freedesktop.org/series/74777/ State : success == Summary == CI Bug Log - changes from CI_DRM_8142_full -> Patchwork_16995_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Enable non-contiguous pipe fusing

2020-03-18 Thread Ville Syrjälä
On Fri, Mar 13, 2020 at 12:39:17AM -0700, Lucas De Marchi wrote: > On Wed, Mar 11, 2020 at 02:06:32PM +0530, Anshuman Gupta wrote: > >Allow 3-display pipes SKU system with any combination > >in INTEL_INFO pipe mask. > >B.Spec:50075 > > > >changes since RFC: > >- using intel_pipe_mask_is_valid()

Re: [Intel-gfx] [PATCH v3 7/7] drm: Allow drivers to leave encoder->possible_crtcs==0

2020-03-18 Thread Ville Syrjälä
On Wed, Feb 12, 2020 at 10:08:49AM +0100, Daniel Vetter wrote: > On Wed, Feb 12, 2020 at 10:07:55AM +0100, Daniel Vetter wrote: > > On Tue, Feb 11, 2020 at 07:14:51PM +0200, Ville Syrjälä wrote: > > > On Tue, Feb 11, 2020 at 06:05:45PM +0100, Daniel Vetter wrote: > > > > On Tue, Feb 11, 2020 at

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/color: Extract icl_read_luts()

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/color: Extract icl_read_luts() URL : https://patchwork.freedesktop.org/series/74777/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8142_full -> Patchwork_16995_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Prefer '%ps' for printing function symbol names

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Prefer '%ps' for printing function symbol names URL : https://patchwork.freedesktop.org/series/74831/ State : success == Summary == CI Bug Log - changes from CI_DRM_8147_full -> Patchwork_17007_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Wait until the context is finally retired before releasing engines (rev2)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/gem: Wait until the context is finally retired before releasing engines (rev2) URL : https://patchwork.freedesktop.org/series/74836/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8148 -> Patchwork_17009

Re: [Intel-gfx] [PATCH 1/9] drm: Constify topology id

2020-03-18 Thread Ville Syrjälä
On Fri, Mar 13, 2020 at 04:05:00PM -0400, Alex Deucher wrote: > On Fri, Mar 13, 2020 at 12:21 PM Ville Syrjala > wrote: > > > > From: Ville Syrjälä > > > > Make the topology id const since we don't want to change it. > > > > Signed-off-by: Ville Syrjälä > > Series is: > Reviewed-by: Alex

Re: [Intel-gfx] [PATCH 2/3] drm: Create a drm_connector_helper_funcs hook for Adaptive Sync support

2020-03-18 Thread Harry Wentland
On 2020-03-18 2:35 a.m., Manasi Navare wrote: > This patch adds a hook in drm_connector_helper_funcs to get the > support of the driver for adaptive sync functionality. > > This can be called in the connector probe helper function after > the connector detect() and get_modes() hooks to also >

[Intel-gfx] [PATCH] drm: Reject dumb buffers when driver/device doesn't support modesetting

2020-03-18 Thread Ville Syrjala
From: Ville Syrjälä Currently a driver must not provide a .dumb_create() hook in the drm_driver structure if it wants to declare dumb buffers as not supported. So if the same driver wants to support both modeset and non-modeset devices it would require two distinct drm_driver structures in order

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gt: move files more files into debugfs

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/gt: move files more files into debugfs URL : https://patchwork.freedesktop.org/series/74834/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h

[Intel-gfx] [PATCH] drm/i915/gem: Wait until the context is finally retired before releasing engines

2020-03-18 Thread Chris Wilson
If we want to percolate information back from the HW, up through the GEM context, we need to wait until the intel_context is scheduled out for the last time. This is handled by the retirement of the intel_context's barrier, i.e. by listening to the pulse after the notional unpin. To accommodate

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Track runtime spent in unreachable intel_contexts

2020-03-18 Thread Chris Wilson
Quoting Chris Wilson (2020-03-18 14:48:05) > We do have a notification here for the context_retire we could listen to > instead of listening to the request idling. If we use > > i915_sw_fence_await_active(>fence, >>active, >

[Intel-gfx] [PATCH] drm/i915/gem: Wait until the context is finally retired before releasing engines

2020-03-18 Thread Chris Wilson
If we want to percolate information back from the HW, up through the GEM context, we need to wait until the intel_context is scheduled out for the last time. This is handled by the retirement of the intel_context's barrier, i.e. by listening to the pulse after the notional unpin. To accommodate

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Track runtime spent in unreachable intel_contexts

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 14:38:53) > > On 18/03/2020 14:32, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-03-18 14:13:14) > >> > >> On 18/03/2020 13:55, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2020-03-18 12:11:34) > From: Tvrtko Ursulin > > As contexts

Re: [Intel-gfx] [PATCH 06/10] drm/i915/hdcp: convert to struct drm_device based logging.

2020-03-18 Thread Wambui Karuga
On Tue, 10 Mar 2020, Jani Nikula wrote: From: Wambui Karuga Converts various instances of the printk based drm logging macros to the struct drm_device based logging macros in i915/display/intel_hdcp.c. This also involves extracting the drm_i915_private device from the intel_connector type

Re: [Intel-gfx] [PATCH 03/10] drm/i915/fbdev: convert to drm_device based logging.

2020-03-18 Thread Wambui Karuga
On Tue, 10 Mar 2020, Jani Nikula wrote: From: Wambui Karuga Convert various instances of printk based drm logging macros to the struct drm_device based logging macros in i915/display/intel_fbdev.c. This also involves extracting the drm_i915_private device from various intel types. v2 by

Re: [Intel-gfx] [PATCH 02/10] drm/i915/fbc: convert to drm_device based logging macros.

2020-03-18 Thread Wambui Karuga
On Tue, 10 Mar 2020, Jani Nikula wrote: From: Wambui Karuga This replaces the uses of the printk based drm logging macros with the struct drm_device based logging macros in i915/display/intel_fbc.c. This transformation was done using the following coccinelle semantic patch that matches

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Track runtime spent in unreachable intel_contexts

2020-03-18 Thread Tvrtko Ursulin
On 18/03/2020 14:32, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-03-18 14:13:14) On 18/03/2020 13:55, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-03-18 12:11:34) From: Tvrtko Ursulin As contexts are abandoned we want to remember how much GPU time they used (per class) so later

Re: [Intel-gfx] [PATCH] drm/i915/display: Trigger Modeset at boot for audio codec init

2020-03-18 Thread Shankar, Uma
> -Original Message- > From: Maarten Lankhorst > Sent: Wednesday, March 18, 2020 5:46 PM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org > Cc: Ville Syrjälä ; Kai Vehmanen > ; Khor, Swee Aun > Subject: Re: [PATCH] drm/i915/display: Trigger Modeset at boot for audio > codec init >

Re: [Intel-gfx] [PATCH] drm/i915/gt: move files more files into debugfs

2020-03-18 Thread Chris Wilson
Quoting Andi Shyti (2020-03-18 14:13:13) > Hi Chris, > > On Wed, Mar 18, 2020 at 02:06:07PM +, Chris Wilson wrote: > > Quoting Andi Shyti (2020-03-18 13:58:37) > > > From: Andi Shyti > > > > > > The following interfaces: > > > > > > i915_wedged > > > i915_forcewake_user > > > > Ok. > > >

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Expose per-engine client busyness

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 14:15:31) > > On 18/03/2020 14:00, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-03-18 12:11:37) > >> +static u64 > >> +pphwsp_busy_add(struct i915_gem_context *ctx, unsigned int class) > >> +{ > >> + struct i915_gem_engines *engines =

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Track runtime spent in unreachable intel_contexts

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 14:13:14) > > On 18/03/2020 13:55, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-03-18 12:11:34) > >> From: Tvrtko Ursulin > >> > >> As contexts are abandoned we want to remember how much GPU time they used > >> (per class) so later we can used it for

Re: [Intel-gfx] [PATCH] drm/i915/gt: move files more files into debugfs

2020-03-18 Thread Andi Shyti
Hi Chris, On Wed, Mar 18, 2020 at 02:06:07PM +, Chris Wilson wrote: > Quoting Andi Shyti (2020-03-18 13:58:37) > > From: Andi Shyti > > > > The following interfaces: > > > > i915_wedged > > i915_forcewake_user > > Ok. > > > i915_gem_interrupt > > More display really, not actually the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Prefer '%ps' for printing function symbol names

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Prefer '%ps' for printing function symbol names URL : https://patchwork.freedesktop.org/series/74831/ State : success == Summary == CI Bug Log - changes from CI_DRM_8147 -> Patchwork_17007 Summary

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Expose per-engine client busyness

2020-03-18 Thread Tvrtko Ursulin
On 18/03/2020 14:00, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-03-18 12:11:37) +static u64 +pphwsp_busy_add(struct i915_gem_context *ctx, unsigned int class) +{ + struct i915_gem_engines *engines = rcu_dereference(ctx->engines); + struct i915_gem_engines_iter it; +

[Intel-gfx] [PATCH] drm/i915/gt: move files more files into debugfs

2020-03-18 Thread Andi Shyti
From: Andi Shyti The following interfaces: i915_wedged i915_forcewake_user i915_gem_interrupt i915_gem_drop_caches are dependent on gt values. Put them inside gt/ and drop the "i915_" prefix name. This would be the new structure: gt | +-- drop_caches | +-- forcewake_user | +--

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Track runtime spent in unreachable intel_contexts

2020-03-18 Thread Tvrtko Ursulin
On 18/03/2020 13:55, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-03-18 12:11:34) From: Tvrtko Ursulin As contexts are abandoned we want to remember how much GPU time they used (per class) so later we can used it for smarter purposes. Signed-off-by: Tvrtko Ursulin ---

[Intel-gfx] [PULL] drm-misc-fixes

2020-03-18 Thread Maarten Lankhorst
drm-misc-fixes-2020-03-18-1: One more fix for v5.6: - drm/lease: fix WARNING in idr_destroy The following changes since commit 1b79cfd99ff5127e6a143767b51694a527b3ea38: drm: kirin: Revert "Fix for hikey620 display offset problem" (2020-03-04 13:29:05 +) are available in the Git repository

Re: [Intel-gfx] [PATCH] drm/i915/gt: move files more files into debugfs

2020-03-18 Thread Chris Wilson
Quoting Andi Shyti (2020-03-18 13:58:37) > From: Andi Shyti > > The following interfaces: > > i915_wedged > i915_forcewake_user Ok. > i915_gem_interrupt More display really, not actually the primary info dump for GEM or GT. s/gem/ or just delete it, if we're not using, and display isn't,

Re: [Intel-gfx] [PATCH] drm/i915/display: Trigger Modeset at boot for audio codec init

2020-03-18 Thread Shankar, Uma
> -Original Message- > From: Gupta, Anshuman > Sent: Wednesday, March 18, 2020 5:37 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org; Khor, Swee Aun > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Trigger Modeset at boot > for audio > codec init > > On 2020-03-18 at

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Expose per-engine client busyness

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 12:11:37) > +static u64 > +pphwsp_busy_add(struct i915_gem_context *ctx, unsigned int class) > +{ > + struct i915_gem_engines *engines = rcu_dereference(ctx->engines); > + struct i915_gem_engines_iter it; > + struct intel_context *ce; > +

Re: [Intel-gfx] [PATCH 06/10] drm/i915: Track runtime spent in closed GEM contexts

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 12:11:35) > From: Tvrtko Ursulin > > As GEM contexts are closed we want to have the DRM client remember how > much GPU time they used (per class) so later we can used it for smarter > purposes. > > Signed-off-by: Tvrtko Ursulin > --- >

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Track runtime spent in unreachable intel_contexts

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 12:11:34) > From: Tvrtko Ursulin > > As contexts are abandoned we want to remember how much GPU time they used > (per class) so later we can used it for smarter purposes. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/gem/i915_gem_context.c

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Use explicit flag to mark unreachable intel_context

2020-03-18 Thread Tvrtko Ursulin
On 18/03/2020 13:49, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-03-18 12:11:33) From: Tvrtko Ursulin I need to keep the GEM context around a bit longer so adding an explicit flag for syncing execbuf with closed/abandonded contexts. v2: * Use already available context flags. (Chris)

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Use explicit flag to mark unreachable intel_context

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 12:11:33) > From: Tvrtko Ursulin > > I need to keep the GEM context around a bit longer so adding an explicit > flag for syncing execbuf with closed/abandonded contexts. > > v2: > * Use already available context flags. (Chris) > > Signed-off-by: Tvrtko

Re: [Intel-gfx] [PATCH 03/10] drm/i915: Make GEM contexts track DRM clients

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 12:11:32) > From: Tvrtko Ursulin > > If we make GEM contexts keep a reference to i915_drm_client for the whole > of their lifetime, we can consolidate the current task pid and name usage > by getting it from the client. > > v2: > * Don't bother supporting

[Intel-gfx] [PATCH] drm/i915: Prefer '%ps' for printing function symbol names

2020-03-18 Thread Chris Wilson
%pS includes the offset, which is useful for return addresses but noise when we are pretty printing a known (and expected) function entry point. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_sw_fence.c | 2 +- drivers/gpu/drm/i915/selftests/i915_active.c | 2 +-

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/display/fbc: Make fences a nice-to-have for GEN9+

2020-03-18 Thread Ville Syrjälä
On Fri, Mar 06, 2020 at 01:32:12AM +, Souza, Jose wrote: > On Thu, 2020-02-20 at 19:26 +0200, Ville Syrjälä wrote: > > On Tue, Feb 18, 2020 at 05:42:30PM -0800, José Roberto de Souza > > wrote: > > > dGFX have local memory so it do not have aperture and do not > > > support > > > CPU fences

Re: [Intel-gfx] [PATCH v19 4/8] drm/i915: Refactor intel_can_enable_sagv

2020-03-18 Thread Ville Syrjälä
On Wed, Mar 18, 2020 at 11:52:13AM +, Lisovskiy, Stanislav wrote: > >> @@ -5829,6 +6068,10 @@ skl_compute_wm(struct intel_atomic_state *state) > >>return ret; > >>} > >> > >> + ret = intel_compute_sagv_mask(state); > >> + if (ret) > >> +

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/display/fbc: Make fences a nice-to-have for GEN9+

2020-03-18 Thread Ville Syrjälä
On Thu, Mar 12, 2020 at 12:35:56AM +, Souza, Jose wrote: > On Thu, 2020-03-05 at 17:33 -0800, José Roberto de Souza wrote: > > On Thu, 2020-02-20 at 19:26 +0200, Ville Syrjälä wrote: > > > On Tue, Feb 18, 2020 at 05:42:30PM -0800, José Roberto de Souza > > > wrote: > > > > dGFX have local

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Trigger Modeset at boot for audio codec init

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/display: Trigger Modeset at boot for audio codec init URL : https://patchwork.freedesktop.org/series/74828/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8146 -> Patchwork_17006

Re: [Intel-gfx] [PATCH 0/9] Per client engine busyness

2020-03-18 Thread Tvrtko Ursulin
On 18/03/2020 11:01, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Another re-spin of the per-client engine busyness series. Highlights from this version: Broken version with one patch missing, apologies for the spam. Regards, Tvrtko * Checkpatch cleanup and bits of review feedback

Re: [Intel-gfx] [PATCH] drm/i915/display: Trigger Modeset at boot for audio codec init

2020-03-18 Thread Anshuman Gupta
On 2020-03-18 at 17:00:09 +0530, Uma Shankar wrote: > If external monitors are connected during boot up, driver > uses the same mode programmed by BIOS and avoids a full modeset. > This results in display audio codec left uninitialized and > display audio fails to work till user triggers a

Re: [Intel-gfx] [PATCH] drm/i915/display: Trigger Modeset at boot for audio codec init

2020-03-18 Thread Maarten Lankhorst
Op 18-03-2020 om 12:30 schreef Uma Shankar: > If external monitors are connected during boot up, driver > uses the same mode programmed by BIOS and avoids a full modeset. > This results in display audio codec left uninitialized and > display audio fails to work till user triggers a modeset. > >

[Intel-gfx] [PATCH 04/10] drm/i915: Use explicit flag to mark unreachable intel_context

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I need to keep the GEM context around a bit longer so adding an explicit flag for syncing execbuf with closed/abandonded contexts. v2: * Use already available context flags. (Chris) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c| 3 ++-

  1   2   >