[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add PCI IDs for Skylake GT1.5 (rev2)

2020-04-28 Thread Patchwork
== Series Details == Series: drm/i915: Add PCI IDs for Skylake GT1.5 (rev2) URL : https://patchwork.freedesktop.org/series/76577/ State : success == Summary == CI Bug Log - changes from CI_DRM_8389 -> Patchwork_17504 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists

2020-04-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists URL : https://patchwork.freedesktop.org/series/76681/ State : success == Summary == CI Bug Log - changes from CI_DRM_8388_full -> Patchwork_17500_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show

2020-04-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show URL : https://patchwork.freedesktop.org/series/76691/ State : success == Summary == CI Bug Log - changes from CI_DRM_8389 -> Patchwork_17503

[Intel-gfx] [patch] drm/i915: Update Slylake PCI IDs

2020-04-28 Thread Alexei Podtelezhnikov
Add three new devices 0x1513, 0x1515, and 0x1517 also known as iSKLULTGT15, iSKLULXGT15, and iSKLDTGT15. Reclassify 0x1923, 0x1927, and 0x192A according to specifications. Signed-off-by: Alexei Podtelezhnikov --- include/drm/i915_pciids.h | 19 +++ 1 file changed, 11

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev3)

2020-04-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev3) URL : https://patchwork.freedesktop.org/series/76678/ State : success == Summary == CI Bug Log - changes from CI_DRM_8388_full -> Patchwork_17499_full

[Intel-gfx] [PATCH] drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show

2020-04-28 Thread Nathan Chancellor
When building with clang + -Wuninitialized: drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:407:7: warning: variable 'rpcurupei' is uninitialized when used here [-Wuninitialized] rpcurupei, ^ drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:304:16:

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] drm/i915/execlists: Avoid reusing the same logical CCID

2020-04-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/execlists: Avoid reusing the same logical CCID URL : https://patchwork.freedesktop.org/series/76675/ State : success == Summary == CI Bug Log - changes from CI_DRM_8387_full -> Patchwork_17498_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state

2020-04-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state URL : https://patchwork.freedesktop.org/series/76686/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8388 -> Patchwork_17502

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state

2020-04-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state URL : https://patchwork.freedesktop.org/series/76686/ State : warning == Summary == $ dim checkpatch origin/drm-tip f78daa371c45 drm/i915/gt: Keep a no-frills

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: avoid unused scale_user_to_hw() warning

2020-04-28 Thread Patchwork
== Series Details == Series: drm/i915: avoid unused scale_user_to_hw() warning URL : https://patchwork.freedesktop.org/series/76682/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8388 -> Patchwork_17501 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists

2020-04-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists URL : https://patchwork.freedesktop.org/series/76681/ State : success == Summary == CI Bug Log - changes from CI_DRM_8388 -> Patchwork_17500

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists

2020-04-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists URL : https://patchwork.freedesktop.org/series/76681/ State : warning == Summary == $ dim checkpatch origin/drm-tip 14885f35fa1b drm/i915/gt: Always enable busy-stats for execlists

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev3)

2020-04-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev3) URL : https://patchwork.freedesktop.org/series/76678/ State : success == Summary == CI Bug Log - changes from CI_DRM_8388 -> Patchwork_17499

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2020-04-28 Thread Stephen Rothwell
Hi all, On Mon, 20 Apr 2020 13:01:18 +1000 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/video/fbdev/controlfb.c: In function 'controlfb_mmap': > drivers/video/fbdev/controlfb.c:756:23: error:

Re: [Intel-gfx] Re%3A [RFC] GPU-bound energy efficiency improvements for the intel_pstate driver (v2).=<20200310214203.26459-1-currojerez%40riseup.net>

2020-04-28 Thread Francisco Jerez
wax[0] writes: > Hi Francisco, n> > I am very interested in installing the patch to improve intel_pstate, I am > runing ubuntu 20.04 on a Surface Pro 7 with Ice Lake processor and I get some > issues with the computer freezing for few seconds randomly, it is specially > annoying because the

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev3)

2020-04-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev3) URL : https://patchwork.freedesktop.org/series/76678/ State : warning == Summary == $ dim checkpatch origin/drm-tip 62c3ddeb1d3d drm/i915/gt: Keep a no-frills swappable copy of the

[Intel-gfx] [PATCH 2/2] drm/i915/gt: Stop keeping the pinned_default_state

2020-04-28 Thread Chris Wilson
As we only restore the default context state upon banning a context, we only need enough of the state to run the ring and nothing more. That is we only need our bare protocontext. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Mika Kuoppala Cc: Andi Shyti ---

[Intel-gfx] [PATCH 1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state

2020-04-28 Thread Chris Wilson
We need to keep the default context state around to instantiate new contexts (aka golden rendercontext), and we also keep it pinned while the engine is active so that we can quickly reset a hanging context. However, the default contexts are large enough to merit keeping in swappable memory as

[Intel-gfx] [PATCH] drm/i915: avoid unused scale_user_to_hw() warning

2020-04-28 Thread Arnd Bergmann
After the function is no longer marked 'inline', there is now a new warning pointing out that the only caller is inside of an #ifdef: drivers/gpu/drm/i915/display/intel_panel.c:493:12: warning: 'scale_user_to_hw' defined but not used [-Wunused-function] 493 | static u32 scale_user_to_hw(struct

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers (rev2)

2020-04-28 Thread Patchwork
== Series Details == Series: drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers (rev2) URL : https://patchwork.freedesktop.org/series/76671/ State : success == Summary == CI Bug Log - changes from CI_DRM_8384_full -> Patchwork_17496_full

[Intel-gfx] [CI 2/6] drm/i915/gt: Move rps.enabled/active to flags

2020-04-28 Thread Chris Wilson
Pull the boolean intel_rps.enabled and intel_rps.active into a single flags field, in preparation for more. Signed-off-by: Chris Wilson Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/debugfs_gt_pm.c | 5 +-- drivers/gpu/drm/i915/gt/intel_rps.c | 43 ++-

[Intel-gfx] [CI 5/6] drm/i915/gt: Apply the aggressive downclocking to parking

2020-04-28 Thread Chris Wilson
We treat parking as a manual RPS timeout event, and downclock the GPU for the next unpark and batch execution. However, having restored the aggressive downclocking and observed that we have very light workloads whose only interaction is through the manual parking events, carry over the aggressive

[Intel-gfx] [CI 3/6] drm/i915/gt: Track use of RPS interrupts in flags

2020-04-28 Thread Chris Wilson
Use the new intel_rps.flags field to store whether or not interrupts are being used with RPS. Signed-off-by: Chris Wilson Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_rps.c | 17 - drivers/gpu/drm/i915/gt/intel_rps.h | 15 +++

[Intel-gfx] [CI 1/6] drm/i915/gt: Always enable busy-stats for execlists

2020-04-28 Thread Chris Wilson
In the near future, we will utilize the busy-stats on each engine to approximate the C0 cycles of each, and use that as an input to a manual RPS mechanism. That entails having busy-stats always enabled and so we can remove the enable/disable routines and simplify the pmu setup. As a consequence of

[Intel-gfx] [CI 4/6] drm/i915/gt: Switch to manual evaluation of RPS

2020-04-28 Thread Chris Wilson
As with the realisation for soft-rc6, we respond to idling the engines within microseconds, far faster than the response times for HW RC6 and RPS. Furthermore, our fast parking upon idle, prevents HW RPS from running for many desktop workloads, as the RPS evaluation intervals are on the order of

[Intel-gfx] [CI 6/6] drm/i915/gt: Restore aggressive post-boost downclocking

2020-04-28 Thread Chris Wilson
We reduced the clocks slowly after a boost event based on the observation that the smoothness of animations suffered. However, since reducing the evalution intervals, we should be able to respond to the rapidly fluctuating workload of a simple desktop animation and so restore the more aggressive

[Intel-gfx] [PATCH] drm/i915/gt: Keep a no-frills swappable copy of the default context state

2020-04-28 Thread Chris Wilson
We need to keep the default context state around to instantiate new contexts (aka golden rendercontext), and we also keep it pinned while the engine is active so that we can quickly reset a hanging context. However, the default contexts are large enough to merit keeping in swappable memory as

[Intel-gfx] [PATCH] drm/i915/gt: Keep a no-frills swappable copy of the default context state

2020-04-28 Thread Chris Wilson
We need to keep the default context state around to instantiate new contexts (aka golden rendercontext), and we also keep it pinned while the engine is active so that we can quickly reset a hanging context. However, the default contexts are large enough to merit keeping in swappable memory as

[Intel-gfx] [PATCH] drm/i915/gt: Keep a no-frills swappable copy of the default context state

2020-04-28 Thread Chris Wilson
We need to keep the default context state around to instantiate new contexts (aka golden rendercontext), and we also keep it pinned while the engine is active so that we can quickly reset a hanging context. However, the default contexts are large enough to merit keeping in swappable memory as

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915/execlists: Avoid reusing the same logical CCID

2020-04-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/execlists: Avoid reusing the same logical CCID URL : https://patchwork.freedesktop.org/series/76675/ State : success == Summary == CI Bug Log - changes from CI_DRM_8387 -> Patchwork_17498

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Put drm_display_mode on diet (rev4)

2020-04-28 Thread Patchwork
== Series Details == Series: drm: Put drm_display_mode on diet (rev4) URL : https://patchwork.freedesktop.org/series/73674/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8387 -> Patchwork_17497 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Tweak the tolerance for clock ticks to 12.5%

2020-04-28 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Tweak the tolerance for clock ticks to 12.5% URL : https://patchwork.freedesktop.org/series/76593/ State : success == Summary == CI Bug Log - changes from CI_DRM_8383_full -> Patchwork_17494_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Put drm_display_mode on diet (rev4)

2020-04-28 Thread Patchwork
== Series Details == Series: drm: Put drm_display_mode on diet (rev4) URL : https://patchwork.freedesktop.org/series/73674/ State : warning == Summary == $ dim checkpatch origin/drm-tip 391d956587ff drm: Nuke mode->hsync eaecaca706ae drm/i915: Introduce some local intel_dp variables

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Tweak the tolerance for clock ticks to 12.5%

2020-04-28 Thread Chris Wilson
Quoting Alexei Podtelezhnikov (2020-04-28 19:44:13) > On Tue, Apr 28, 2020 at 7:43 AM Chris Wilson wrote: > > > > Give a small bump for our tolerance on comparing the expected vs > > measured clock ticks/time from 10% to 12.5% to accommodate a bad result > > on Sandybridge that was off by 10.3%.

Re: [Intel-gfx] [PATCH 38/59] drm/i915: Use devm_drm_dev_alloc

2020-04-28 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 09:40:13AM +0200, Daniel Vetter wrote: > Luckily we're already well set up in the main driver, with > drm_dev_put() being the last thing in both the unload error case and > the pci remove function. > > Signed-off-by: Daniel Vetter Pushed to drm-misc-next with Jani's

Re: [Intel-gfx] [PATCH v2] drm/i915/tgl: Wa_14011059788

2020-04-28 Thread Rodrigo Vivi
On Tue, Apr 28, 2020 at 03:07:03PM +, Sripada, Radhakrishna wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of Matt > > Atwood > > Sent: Wednesday, April 15, 2020 12:36 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [Intel-gfx] [PATCH v2] drm/i915/tgl:

[Intel-gfx] [CI 1/3] drm/i915/execlists: Avoid reusing the same logical CCID

2020-04-28 Thread Chris Wilson
The bspec is confusing on the nature of the upper 32bits of the LRC descriptor. Once upon a time, it said that it uses the upper 32b to decide if it should perform a lite-restore, and so we must ensure that each unique context submitted to HW is given a unique CCID [for the duration of it being on

[Intel-gfx] [CI 3/3] drm/i915/execlists: Verify we don't submit two identical CCIDs

2020-04-28 Thread Chris Wilson
Check that we do not submit two contexts into ELSP with the same CCID [upper portion of the descriptor]. References: https://gitlab.freedesktop.org/drm/intel/-/issues/1793 Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_lrc.c | 37

[Intel-gfx] [CI 2/3] drm/i915/execlists: Track inflight CCID

2020-04-28 Thread Chris Wilson
The presumption is that by using a circular counter that is twice as large as the maximum ELSP submission, we would never reuse the same CCID for two inflight contexts. However, if we continually preempt an active context such that it always remains inflight, it can be resubmitted with an

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Tweak the tolerance for clock ticks to 12.5%

2020-04-28 Thread Alexei Podtelezhnikov
On Tue, Apr 28, 2020 at 7:43 AM Chris Wilson wrote: > > Give a small bump for our tolerance on comparing the expected vs > measured clock ticks/time from 10% to 12.5% to accommodate a bad result > on Sandybridge that was off by 10.3%. Hopefully, that is the worst we > will see. > -

Re: [Intel-gfx] [PATCH 2/3] drm/i915/execlists: Track inflight CCID

2020-04-28 Thread Mika Kuoppala
Chris Wilson writes: > The presumption is that by using a circular counter that is twice as > large as the maximum ELSP submission, we would never reuse the same CCID > for two inflight contexts. > > However, if we continually preempt an active context such that it always > remains inflight, it

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers (rev2)

2020-04-28 Thread Patchwork
== Series Details == Series: drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers (rev2) URL : https://patchwork.freedesktop.org/series/76671/ State : success == Summary == CI Bug Log - changes from CI_DRM_8384 -> Patchwork_17496

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/execlists: Avoid reusing the same logical CCID

2020-04-28 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/execlists: Avoid reusing the same logical CCID URL : https://patchwork.freedesktop.org/series/76585/ State : success == Summary == CI Bug Log - changes from CI_DRM_8382_full -> Patchwork_17492_full

[Intel-gfx] Re%3A [RFC] GPU-bound energy efficiency improvements for the intel_pstate driver (v2).=<20200310214203.26459-1-currojerez%40riseup.net>

2020-04-28 Thread wax [0]
Hi Francisco, I am very interested in installing the patch to improve intel_pstate, I am runing ubuntu 20.04 on a Surface Pro 7 with Ice Lake processor and I get some issues with the computer freezing for few seconds randomly, it is specially annoying because the cursor will also freeze, I

Re: [Intel-gfx] [PATCH v7 3/4] drm/i915/perf: prepare driver to receive multiple ctx handles

2020-04-28 Thread Lionel Landwerlin
On 28/04/2020 13:23, Chris Wilson wrote: Quoting Lionel Landwerlin (2020-04-28 11:08:15) +static int ctx_id_equal(const void *key, const void *elem) +{ + const struct i915_perf_context_detail *details = elem; + + return ((int)details->id) - *((int *)key); +} + +static inline bool

Re: [Intel-gfx] [PATCH] drm/i915: Avoid dereferencing a dead context

2020-04-28 Thread Abodunrin, Akeem G
> -Original Message- > From: Intel-gfx On Behalf Of Chris > Wilson > Sent: Tuesday, April 28, 2020 2:03 AM > To: intel-gfx@lists.freedesktop.org > Cc: Chris Wilson > Subject: [Intel-gfx] [PATCH] drm/i915: Avoid dereferencing a dead context > > Once the intel_context is closed, the

Re: [Intel-gfx] [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse

2020-04-28 Thread Robin Murphy
On 2020-04-28 4:32 pm, Daniel Vetter wrote: On Tue, Apr 28, 2020 at 04:02:57PM +0200, Christoph Hellwig wrote: On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use a proper sg_table entries and call

Re: [Intel-gfx] [RFC 10/17] drm: radeon: fix sg_table nents vs. orig_nents misuse

2020-04-28 Thread Christian König
Am 28.04.20 um 15:19 schrieb Marek Szyprowski: The Documentation/DMA-API-HOWTO.txt states that dma_map_sg returns the numer of the created entries in the DMA address space. However the subsequent calls to dma_sync_sg_for_{device,cpu} and dma_unmap_sg must be called with the original number of

Re: [Intel-gfx] [RFC 02/17] drm: amdgpu: fix sg_table nents vs. orig_nents misuse

2020-04-28 Thread Christian König
Am 28.04.20 um 15:19 schrieb Marek Szyprowski: The Documentation/DMA-API-HOWTO.txt states that dma_map_sg returns the numer of the created entries in the DMA address space. However the subsequent calls to dma_sync_sg_for_{device,cpu} and dma_unmap_sg must be called with the original number of

Re: [Intel-gfx] [PATCH 26/59] drm/qxl: Use devm_drm_dev_alloc

2020-04-28 Thread Daniel Vetter
On Tue, Apr 28, 2020 at 07:00:26PM +0200, Sam Ravnborg wrote: > On Tue, Apr 28, 2020 at 04:00:11PM +0200, Daniel Vetter wrote: > > On Fri, Apr 24, 2020 at 05:09:11PM +0200, Sam Ravnborg wrote: > > > Hi Daniel > > > > > > On Wed, Apr 15, 2020 at 09:40:01AM +0200, Daniel Vetter wrote: > > > > Also

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Avoid dereferencing a dead context

2020-04-28 Thread Patchwork
== Series Details == Series: drm/i915: Avoid dereferencing a dead context URL : https://patchwork.freedesktop.org/series/76584/ State : success == Summary == CI Bug Log - changes from CI_DRM_8382_full -> Patchwork_17491_full Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/perf: Add support for multi context perf queries (rev2)

2020-04-28 Thread Patchwork
== Series Details == Series: drm/i915/perf: Add support for multi context perf queries (rev2) URL : https://patchwork.freedesktop.org/series/76588/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8383 -> Patchwork_17495

[Intel-gfx] [PATCH v3 09/16] drm: Flatten drm_mode_vrefresh()

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä Remove the pointless whole-function indentation. Also don't need to worry about negative values anymore since we switched everything to u16. Reviewed-by: Sam Ravnborg Reviewed-by: Emil Velikov Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_modes.c | 26

[Intel-gfx] [PATCH v3 15/16] drm: Nuke mode->private_flags

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä The last two uses of mode->private_flags (in i915 and gma500) are now gone. So let's remove mode->private_flags entirely. v2: Drop the earlier int->u8 conversion CC: Sam Ravnborg Cc: Daniel Vetter Cc: Emil Velikov Reviewed-by: Sam Ravnborg Signed-off-by: Ville Syrjälä

[Intel-gfx] [PATCH v3 11/16] drm/mcde: Use mode->clock instead of reverse calculating it from the vrefresh

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä htotal*vtotal*vrefresh ~= clock. So just say "clock" when we mean it. Cc: Linus Walleij Cc: Sam Ravnborg Reviewed-by: Daniel Vetter Reviewed-by: Sam Ravnborg Reviewed-by: Linus Walleij Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/mcde/mcde_dsi.c | 3 +-- 1 file

[Intel-gfx] [PATCH v3 13/16] drm/i915: Replace I915_MODE_FLAG_INHERITED with a boolean

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä There's no reason for I915_MODE_FLAG_INHERITED to exist as a flag anymore. Just make it a boolean. CC: Sam Ravnborg Cc: Daniel Vetter Cc: Emil Velikov Reviewed-by: Daniel Vetter Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_atomic.c | 2 +-

[Intel-gfx] [PATCH v3 14/16] drm/gma500: Stop using mode->private_flags

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä gma500 only uses mode->private_flags to convey the sdvo pixel multiplier from the encoder .mode_fixup() hook to the encoder .mode_set() hook. Those always seems get called as a pair so let's just stuff the pixel multiplier into the encoder itself as there are no state objects

[Intel-gfx] [PATCH v3 16/16] drm: Replace mode->export_head with a boolean

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä In order to shrink drm_display_mode below the magic two cacheline mark in 64bit we need to shrink it by another 8 bytes. The easiest thing to eliminate is the 'export_head' list head which is only used during the getconnector ioctl to temporarly track which modes on the

[Intel-gfx] [PATCH v3 10/16] drm: pahole struct drm_display_mode

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä Reorganize drm_display_mode to eliminate all the holes. We'll put all the actual timings to the start of the struct and all the extra junk to the end. Gets the size down to 136 bytes on 64bit and 120 bytes on 32bit. With a bit more work we should be able to get this below

[Intel-gfx] [PATCH v3 12/16] drm/i915: Stop using mode->private_flags

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä Replace the use of mode->private_flags with a truly private bitmaks in our own crtc state. We also need a copy in the crtc itself so the vblank code can get at it. We already have scanline_offset in there for a similar reason, as well as the vblank->hwmode which is assigned

[Intel-gfx] [PATCH v3 08/16] drm: Shrink drm_display_mode timings

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä Store the timings (apart from the clock) as u16. The uapi mode struct already uses u16 for everything so using something bigger internally doesn't really help us. Reviewed-by: Sam Ravnborg Reviewed-by: Emil Velikov Reviewed-by: Daniel Vetter Signed-off-by: Ville Syrjälä

[Intel-gfx] [PATCH v3 07/16] drm: Make mode->flags u32

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä The mode flags are direclty exposed in the uapi as u32. Use the same size type to store them internally. Reviewed-by: Sam Ravnborg Reviewed-by: Emil Velikov Signed-off-by: Ville Syrjälä --- include/drm/drm_modes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Intel-gfx] [PATCH v3 05/16] drm: Shrink {width,height}_mm to u16

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä Instead of supporting ~2000km wide displayes let's limit ourselves to ~65m. That seems plenty big enough to me. Even with EDID_QUIRK_DETAILED_IN_CM EDIDs seem to be limited to 10*0xfff which fits into the 16 bits. Reviewed-by: Sam Ravnborg Reviewed-by: Emil Velikov

[Intel-gfx] [PATCH v3 00/16] drm: Put drm_display_mode on diet

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä Rebased mode dieting series. Hopefully will get this past ci finally. Changes from v2: - rebase - dropped the int->u8 private_flags patch Only the last patch remains unreviewed. Ville Syrjälä (16): drm: Nuke mode->hsync drm/i915: Introduce some local intel_dp variables

[Intel-gfx] [PATCH v3 04/16] drm/msm/dpu: Stop copying around mode->private_flags

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä The driver never sets mode->private_flags so copying it back and forth is entirely pointless. Stop doing it. Also drop private_flags from the tracepoint. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org Reviewed-by: Emil

[Intel-gfx] [PATCH v3 01/16] drm: Nuke mode->hsync

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä Let's just calculate the hsync rate on demand. No point in wasting space storing it and risking the cached value getting out of sync with reality. v2: Move drm_mode_hsync() next to its only users Drop the TODO Reviewed-by: Sam Ravnborg Reviewed-by: Emil Velikov #v1

[Intel-gfx] [PATCH v3 02/16] drm/i915: Introduce some local intel_dp variables

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä The drrs code dereferences mode->vrefresh via some really long chain of structures/pointers. Couldn't get coccinelle to see through all that so let's add some local variables to help it. Reviewed-by: Emil Velikov Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v3 06/16] drm: Shrink mode->type to u8

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä We only have 7 bits defined for mode->type. Shrink the storage to u8. Reviewed-by: Sam Ravnborg Reviewed-by: Emil Velikov Reviewed-by: Daniel Vetter Signed-off-by: Ville Syrjälä --- include/drm/drm_modes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Intel-gfx] [PATCH] drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers

2020-04-28 Thread Michal Orzel
As suggested by the TODO list for the kernel DRM subsystem, replace the deprecated functions that take/drop modeset locks with new helpers. Signed-off-by: Michal Orzel --- drivers/gpu/drm/drm_mode_object.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: Add support for multi context perf queries (rev2)

2020-04-28 Thread Patchwork
== Series Details == Series: drm/i915/perf: Add support for multi context perf queries (rev2) URL : https://patchwork.freedesktop.org/series/76588/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9d27db19c6bb drm/i915/perf: break OA config buffer object in 2 b411bf5dfcaa

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Tweak the tolerance for clock ticks to 12.5%

2020-04-28 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Tweak the tolerance for clock ticks to 12.5% URL : https://patchwork.freedesktop.org/series/76593/ State : success == Summary == CI Bug Log - changes from CI_DRM_8383 -> Patchwork_17494

Re: [Intel-gfx] [PATCH 56/59] drm/aspeed: Use managed drmm_mode_config_cleanup

2020-04-28 Thread Sam Ravnborg
On Tue, Apr 28, 2020 at 04:12:21PM +0200, Daniel Vetter wrote: > On Fri, Apr 24, 2020 at 08:10:02PM +0200, Sam Ravnborg wrote: > > On Wed, Apr 15, 2020 at 09:40:31AM +0200, Daniel Vetter wrote: > > > Since aspeed doesn't use devm_kzalloc anymore we can use the managed > > > mode config cleanup. >

Re: [Intel-gfx] [PATCH 26/59] drm/qxl: Use devm_drm_dev_alloc

2020-04-28 Thread Sam Ravnborg
On Tue, Apr 28, 2020 at 04:00:11PM +0200, Daniel Vetter wrote: > On Fri, Apr 24, 2020 at 05:09:11PM +0200, Sam Ravnborg wrote: > > Hi Daniel > > > > On Wed, Apr 15, 2020 at 09:40:01AM +0200, Daniel Vetter wrote: > > > Also need to remove the drm_dev_put from the remove hook. > > > > > >

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists

2020-04-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists URL : https://patchwork.freedesktop.org/series/76590/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8383 -> Patchwork_17493

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists

2020-04-28 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists URL : https://patchwork.freedesktop.org/series/76590/ State : warning == Summary == $ dim checkpatch origin/drm-tip 99b775e3f056 drm/i915/gt: Always enable busy-stats for execlists

Re: [Intel-gfx] [PATCH] Remove drm_display_mode.hsync

2020-04-28 Thread Ville Syrjälä
On Tue, Apr 28, 2020 at 05:18:13PM +0200, Daniel Vetter wrote: > On Mon, Apr 27, 2020 at 10:05:17AM +0200, Michal Orzel wrote: > > As suggested by the TODO list of DRM subsystem: > > -remove the member hsync of drm_display_mode > > -convert code using hsync member to use drm_mode_hsync() > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/execlists: Avoid reusing the same logical CCID

2020-04-28 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/execlists: Avoid reusing the same logical CCID URL : https://patchwork.freedesktop.org/series/76585/ State : success == Summary == CI Bug Log - changes from CI_DRM_8382 -> Patchwork_17492

Re: [Intel-gfx] [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse

2020-04-28 Thread Daniel Vetter
On Tue, Apr 28, 2020 at 04:02:57PM +0200, Christoph Hellwig wrote: > On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: > > 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use > >a proper sg_table entries and call respective DMA-mapping functions > >and

Re: [Intel-gfx] [PATCH] drm/i915/gem: Lazily acquire the device wakeref for freeing objects

2020-04-28 Thread Janusz Krzysztofik
On Tue, 2020-04-28 at 15:48 +0100, Chris Wilson wrote: > Quoting Janusz Krzysztofik (2020-04-28 15:35:03) > > On Tue, 2020-04-28 at 13:59 +0100, Chris Wilson wrote: > > > Quoting Janusz Krzysztofik (2020-04-28 13:45:13) > > > > Hi Chris, > > > > > > > > On Fri, 2020-04-24 at 16:24 +0100, Chris

Re: [Intel-gfx] [PATCH] Remove drm_display_mode.hsync

2020-04-28 Thread Daniel Vetter
On Mon, Apr 27, 2020 at 10:05:17AM +0200, Michal Orzel wrote: > As suggested by the TODO list of DRM subsystem: > -remove the member hsync of drm_display_mode > -convert code using hsync member to use drm_mode_hsync() > > Signed-off-by: Michal Orzel I think Ville has a bunch of patches doing

Re: [Intel-gfx] [PATCH v2] drm: make drm_file use keyed wakeups

2020-04-28 Thread Daniel Vetter
On Fri, Apr 24, 2020 at 06:26:15PM +0200, Kenny Levinsen wrote: > Some processes, such as systemd, are only polling for EPOLLERR|EPOLLHUP. > As drm_file uses unkeyed wakeups, such a poll can receive many spurious > wakeups from uninteresting events if, for example, the file description > is

Re: [Intel-gfx] [PATCH] drm: make drm_file use keyed wakeups

2020-04-28 Thread Daniel Vetter
On Fri, Apr 24, 2020 at 04:51:03PM +0200, Kenny Levinsen wrote: > Some processes, such as systemd, are only polling for EPOLLERR|EPOLLHUP. > As drm_file uses unkeyed wakeups, such a poll receives many spurious > wakeups from uninteresting events. > > Use keyed wakeups to allow the wakeup target

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Avoid dereferencing a dead context

2020-04-28 Thread Patchwork
== Series Details == Series: drm/i915: Avoid dereferencing a dead context URL : https://patchwork.freedesktop.org/series/76584/ State : success == Summary == CI Bug Log - changes from CI_DRM_8382 -> Patchwork_17491 Summary ---

Re: [Intel-gfx] [PATCH v2] drm/i915/tgl: Wa_14011059788

2020-04-28 Thread Sripada, Radhakrishna
> -Original Message- > From: Intel-gfx On Behalf Of Matt > Atwood > Sent: Wednesday, April 15, 2020 12:36 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2] drm/i915/tgl: Wa_14011059788 > > Reflect recent Bspec changes > > v2: fix whitespace, typo > >

Re: [Intel-gfx] [PATCH] drm/i915/gem: Lazily acquire the device wakeref for freeing objects

2020-04-28 Thread Chris Wilson
Quoting Janusz Krzysztofik (2020-04-28 15:35:03) > On Tue, 2020-04-28 at 13:59 +0100, Chris Wilson wrote: > > Quoting Janusz Krzysztofik (2020-04-28 13:45:13) > > > Hi Chris, > > > > > > On Fri, 2020-04-24 at 16:24 +0100, Chris Wilson wrote: > > > > We only need the device wakeref on freeing the

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Avoid dereferencing a dead context

2020-04-28 Thread Patchwork
== Series Details == Series: drm/i915: Avoid dereferencing a dead context URL : https://patchwork.freedesktop.org/series/76584/ State : warning == Summary == $ dim checkpatch origin/drm-tip 214ef915d9c5 drm/i915: Avoid dereferencing a dead context -:9: WARNING:COMMIT_LOG_LONG_LINE: Possible

Re: [Intel-gfx] [PATCH] drm/i915/gem: Lazily acquire the device wakeref for freeing objects

2020-04-28 Thread Janusz Krzysztofik
On Tue, 2020-04-28 at 13:59 +0100, Chris Wilson wrote: > Quoting Janusz Krzysztofik (2020-04-28 13:45:13) > > Hi Chris, > > > > On Fri, 2020-04-24 at 16:24 +0100, Chris Wilson wrote: > > > We only need the device wakeref on freeing the objects if we have to > > > unbind the object from the global

Re: [Intel-gfx] [patch] drm/i915: Add PCI IDs for Skylake GT1.5

2020-04-28 Thread Alexei Podtelezhnikov
> > These devices are also known as iSKLULTGT15 and iSKLDTGT15. > > We also seem to be missing 0x1915 from the ulx list. Indeed, iSKLULXGT15 can be found. > Another odd things I noticed in our SKL PCI ID lists is that > that 0x1923 and 0x1927 are potentially miscategorized. They > are listed as

Re: [Intel-gfx] [RFC 06/17] drm: i915: fix sg_table nents vs. orig_nents misuse

2020-04-28 Thread Tvrtko Ursulin
On 28/04/2020 14:19, Marek Szyprowski wrote: The Documentation/DMA-API-HOWTO.txt states that dma_map_sg returns the numer of the created entries in the DMA address space. However the subsequent calls to dma_sync_sg_for_{device,cpu} and dma_unmap_sg must be called with the original number of

Re: [Intel-gfx] [PATCH 56/59] drm/aspeed: Use managed drmm_mode_config_cleanup

2020-04-28 Thread Daniel Vetter
On Fri, Apr 24, 2020 at 08:10:02PM +0200, Sam Ravnborg wrote: > On Wed, Apr 15, 2020 at 09:40:31AM +0200, Daniel Vetter wrote: > > Since aspeed doesn't use devm_kzalloc anymore we can use the managed > > mode config cleanup. > > > > Signed-off-by: Daniel Vetter > > Cc: Joel Stanley > > Cc:

Re: [Intel-gfx] [patch] drm/i915: Remove dubious Valleyview PCI IDs

2020-04-28 Thread Ville Syrjälä
On Mon, Apr 27, 2020 at 11:47:52PM -0400, Alexei Podtelezhnikov wrote: > 0x0155 is rather Ivy Bridge PCI-E Root Port. A bit surprising we've not had any reports of the driver biding to the wrong device. > 0x0157 from the same commit ff049b6ce21d2814451afd4a116d001712e0116b > is likely wrong too.

Re: [Intel-gfx] [PATCH 53/59] drm/arc: Move to drm/tiny

2020-04-28 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 02:20:35PM +0200, Daniel Vetter wrote: > On Wed, Apr 15, 2020 at 2:03 PM Alexey Brodkin > wrote: > > > > Hi Daniel, > > > > > -Original Message- > > > From: Sam Ravnborg > > > Sent: Wednesday, April 15, 2020 12:45 PM > > > To: Daniel Vetter > > > Cc: Intel

Re: [Intel-gfx] [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse

2020-04-28 Thread Christoph Hellwig
On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: > 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use >a proper sg_table entries and call respective DMA-mapping functions >and adapt current code to it That sounds reasonable to me. Those could be

Re: [Intel-gfx] [PATCH 26/59] drm/qxl: Use devm_drm_dev_alloc

2020-04-28 Thread Daniel Vetter
On Fri, Apr 24, 2020 at 05:09:11PM +0200, Sam Ravnborg wrote: > Hi Daniel > > On Wed, Apr 15, 2020 at 09:40:01AM +0200, Daniel Vetter wrote: > > Also need to remove the drm_dev_put from the remove hook. > > > > Acked-by: Gerd Hoffmann > > Signed-off-by: Daniel Vetter > > Cc: Dave Airlie > >

Re: [Intel-gfx] [patch] drm/i915: Add PCI IDs for Skylake GT1.5

2020-04-28 Thread Ville Syrjälä
On Mon, Apr 27, 2020 at 11:47:05PM -0400, Alexei Podtelezhnikov wrote: > These devices are also known as iSKLULTGT15 and iSKLDTGT15. > > Signed-off-by: Alexei Podtelezhnikov > --- > include/drm/i915_pciids.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

[Intel-gfx] [PATCH v8 4/4] drm/i915/perf: enable filtering on multiple contexts

2020-04-28 Thread Lionel Landwerlin
Add 2 new properties to the i915-perf open ioctl to specify an array of GEM context handles as well as the length of the array. This can be used by drivers using multiple GEM contexts to implement a single GL context. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_perf.c | 58

[Intel-gfx] [PATCH v8 2/4] drm/i915/perf: stop using the kernel context

2020-04-28 Thread Lionel Landwerlin
Chris doesn't like that. v2: Don't forget to configure the kernel so that periodic reports are written appropriately (Lionel) Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_perf.c | 153 + drivers/gpu/drm/i915/i915_perf_types.h | 10 +- 2

[Intel-gfx] [PATCH v8 3/4] drm/i915/perf: prepare driver to receive multiple ctx handles

2020-04-28 Thread Lionel Landwerlin
Make all the internal necessary changes before we flip the switch. v2: Use an unlimited number of intel contexts (Chris) v3: Handle GEM context with multiple RCS0 logical contexts (Chris) v4: Let the intel_context create its own timeline (Chris) Only pin configuration context when needed

[Intel-gfx] [PATCH v8 0/4] drm/i915/perf: Add support for multi context perf queries

2020-04-28 Thread Lionel Landwerlin
Hi all, A quick fix to configure the kernel context and removing the useless timeline creation. Cheers, Lionel Landwerlin (4): drm/i915/perf: break OA config buffer object in 2 drm/i915/perf: stop using the kernel context drm/i915/perf: prepare driver to receive multiple ctx handles

[Intel-gfx] [PATCH v8 1/4] drm/i915/perf: break OA config buffer object in 2

2020-04-28 Thread Lionel Landwerlin
We want to enable performance monitoring on multiple contexts to cover the Iris use case of using 2 GEM contexts (3D & compute). So start by breaking the OA configuration BO which contains global & per context register writes. NOA muxes & OA configurations are global, while FLEXEU register

  1   2   >