[Intel-gfx] [CI] drm/i915/selftests: Add tiled blits selftest

2020-04-29 Thread Chris Wilson
From: Zbigniew Kempczyński Extend coverage of the blitter client by exercising conversion to and from tiled sources. In the process we perform spot checks to verify that the tiling/detiling is being applied correctly, along with position invariance of the tiling parameters. Signed-off-by: Zbigni

Re: [Intel-gfx] [PATCH] drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers

2020-04-29 Thread Michał Orzeł
On 29.04.2020 10:57, Jani Nikula wrote: > On Tue, 28 Apr 2020, Michal Orzel wrote: >> As suggested by the TODO list for the kernel DRM subsystem, replace >> the deprecated functions that take/drop modeset locks with new helpers. >> >> Signed-off-by: Michal Orzel >> --- >> drivers/gpu/drm/drm_

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add support for HDCP 1.4 over MST connectors (rev6)

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Add support for HDCP 1.4 over MST connectors (rev6) URL : https://patchwork.freedesktop.org/series/70393/ State : success == Summary == CI Bug Log - changes from CI_DRM_8394_full -> Patchwork_17521_full

Re: [Intel-gfx] i915 HDCP 2.2 TX encryption on Teledyne test instrument

2020-04-29 Thread Ramalingam C
On 2020-04-29 at 18:12:32 +, Voldman, Mikhail wrote: > Hi Ram, > > Thank you for your help, in the past. > We can control HDCP on our products as needed. > > One issue on the new motherboard used in our product. > In this case, i915 advertises itself as DP-1 sink repeater and authenticated

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Nuke mode.vrefresh usage

2020-04-29 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Nuke mode.vrefresh usage URL : https://patchwork.freedesktop.org/series/76741/ State : success == Summary == CI Bug Log - changes from CI_DRM_8394_full -> Patchwork_17520_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Stop holding onto the pinned_default_state

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915/gt: Stop holding onto the pinned_default_state URL : https://patchwork.freedesktop.org/series/76738/ State : success == Summary == CI Bug Log - changes from CI_DRM_8394_full -> Patchwork_17519_full Summ

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Update Slylake PCI IDs

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Update Slylake PCI IDs URL : https://patchwork.freedesktop.org/series/76750/ State : success == Summary == CI Bug Log - changes from CI_DRM_8399 -> Patchwork_17524 Summary --- **SUCCESS** No

[Intel-gfx] [patch v2] drm/i915: Update Slylake PCI IDs

2020-04-29 Thread Alexei Podtelezhnikov
Add three new devices 0x1913, 0x1915, and 0x1917 also known as iSKLULTGT15, iSKLULXGT15, and iSKLDTGT15; GT1.5 looks closer to GT2. Reclassify 0x1923, 0x1927, and 0x192A according to specifications and the second least significant digit, which points to GT3 as appropriate tier. Signed-off-by: Alex

[Intel-gfx] [patch] drm/i915: Update Haswell PCI IDs

2020-04-29 Thread Alexei Podtelezhnikov
Reclassify 0x0426 as GT3 (GT2+) according to specifications and the second least significant digit. Signed-off-by: Alexei Podtelezhnikov --- include/drm/i915_pciids.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index

[Intel-gfx] Update PCI IDs

2020-04-29 Thread Alexei Podtelezhnikov
Hi all, What follows are small changes to Haswell and Skylake lists. Some of the changes are purely semantic because some devices are not even tracked in the current Windows driver. Do they even exist? Perhaps, at some point the discontinued lines can be cleaned. I also learned that, from Haswell

Re: [Intel-gfx] [PATCH] drm/i915/mst: filter out the display mode exceed sink's capability

2020-04-29 Thread Lee, Shawn C
On Sat, 2020-04-25, Lyude Paul wrote: > >Hi! Sorry this took me a little while to get back to, I had a couple of MST >regressions that I had to look into > >On Sat, 2020-04-18 at 05:24 +0800, Lee Shawn C wrote: >> So far, max dot clock rate for MST mode rely on physcial bandwidth >> limitation.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Add tiled blits selftest

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add tiled blits selftest URL : https://patchwork.freedesktop.org/series/76746/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8397 -> Patchwork_17523 Summary --- **FAIL

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Add tiled blits selftest

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add tiled blits selftest URL : https://patchwork.freedesktop.org/series/76746/ State : warning == Summary == $ dim checkpatch origin/drm-tip 94fe0ca107f9 drm/i915/selftests: Add tiled blits selftest -:578: WARNING:LINE_SPACING: Missing a blank l

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Add tiled blits selftest

2020-04-29 Thread Chris Wilson
Quoting Chris Wilson (2020-04-30 01:20:35) > +static int igt_client_tiled_blits(void *arg) > +{ > + struct drm_i915_private *i915 = arg; > + I915_RND_STATE(prng); > + int inst = 0; > + > + /* Test requires explicit BLT tiling controls */ > + if (INTEL_GEN(i915) < 4) >

[Intel-gfx] [PATCH] drm/i915/selftests: Add tiled blits selftest

2020-04-29 Thread Chris Wilson
From: Zbigniew Kempczyński Extend coverage of the blitter client by exercising conversion to and from tiled sources. In the process we perform spot checks to verify that the tiling/detiling is being applied correctly, along with position invariance of the tiling parameters. Signed-off-by: Zbigni

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev4)

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev4) URL : https://patchwork.freedesktop.org/series/76678/ State : success == Summary == CI Bug Log - changes from CI_DRM_8392_full -> Patchwork_17518_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: FBC fixes (rev2)

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915: FBC fixes (rev2) URL : https://patchwork.freedesktop.org/series/76714/ State : success == Summary == CI Bug Log - changes from CI_DRM_8392_full -> Patchwork_17517_full Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists

2020-04-29 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists URL : https://patchwork.freedesktop.org/series/76744/ State : success == Summary == CI Bug Log - changes from CI_DRM_8395 -> Patchwork_17522 =

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists

2020-04-29 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists URL : https://patchwork.freedesktop.org/series/76744/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5b70b28be5c0 drm/i915/gt: Always enable busy-stats for execlists 8

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add support for HDCP 1.4 over MST connectors (rev6)

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Add support for HDCP 1.4 over MST connectors (rev6) URL : https://patchwork.freedesktop.org/series/70393/ State : success == Summary == CI Bug Log - changes from CI_DRM_8394 -> Patchwork_17521 Summary

[Intel-gfx] [CI 1/6] drm/i915/gt: Always enable busy-stats for execlists

2020-04-29 Thread Chris Wilson
In the near future, we will utilize the busy-stats on each engine to approximate the C0 cycles of each, and use that as an input to a manual RPS mechanism. That entails having busy-stats always enabled and so we can remove the enable/disable routines and simplify the pmu setup. As a consequence of

[Intel-gfx] [CI 3/6] drm/i915/gt: Track use of RPS interrupts in flags

2020-04-29 Thread Chris Wilson
Use the new intel_rps.flags field to store whether or not interrupts are being used with RPS. Signed-off-by: Chris Wilson Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_rps.c | 17 - drivers/gpu/drm/i915/gt/intel_rps.h | 15 +++ drivers/gpu/drm

[Intel-gfx] [CI 5/6] drm/i915/gt: Apply the aggressive downclocking to parking

2020-04-29 Thread Chris Wilson
We treat parking as a manual RPS timeout event, and downclock the GPU for the next unpark and batch execution. However, having restored the aggressive downclocking and observed that we have very light workloads whose only interaction is through the manual parking events, carry over the aggressive d

[Intel-gfx] [CI 2/6] drm/i915/gt: Move rps.enabled/active to flags

2020-04-29 Thread Chris Wilson
Pull the boolean intel_rps.enabled and intel_rps.active into a single flags field, in preparation for more. Signed-off-by: Chris Wilson Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/debugfs_gt_pm.c | 5 +-- drivers/gpu/drm/i915/gt/intel_rps.c | 43 ++- drivers

[Intel-gfx] [CI 4/6] drm/i915/gt: Switch to manual evaluation of RPS

2020-04-29 Thread Chris Wilson
As with the realisation for soft-rc6, we respond to idling the engines within microseconds, far faster than the response times for HW RC6 and RPS. Furthermore, our fast parking upon idle, prevents HW RPS from running for many desktop workloads, as the RPS evaluation intervals are on the order of te

[Intel-gfx] [CI 6/6] drm/i915/gt: Restore aggressive post-boost downclocking

2020-04-29 Thread Chris Wilson
We reduced the clocks slowly after a boost event based on the observation that the smoothness of animations suffered. However, since reducing the evalution intervals, we should be able to respond to the rapidly fluctuating workload of a simple desktop animation and so restore the more aggressive do

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for HDCP 1.4 over MST connectors (rev6)

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Add support for HDCP 1.4 over MST connectors (rev6) URL : https://patchwork.freedesktop.org/series/70393/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7c5a77a1d31e drm/i915: Fix sha_text population code -:66: WARNING:LINE_SPACING: Missing

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Nuke mode.vrefresh usage

2020-04-29 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Nuke mode.vrefresh usage URL : https://patchwork.freedesktop.org/series/76741/ State : success == Summary == CI Bug Log - changes from CI_DRM_8394 -> Patchwork_17520 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Nuke mode.vrefresh usage

2020-04-29 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Nuke mode.vrefresh usage URL : https://patchwork.freedesktop.org/series/76741/ State : warning == Summary == $ dim checkpatch origin/drm-tip c72890c16d9b drm/i915: Nuke mode.vrefresh usage e45bfe3703e2 drm/i915: Rename variables

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Stop holding onto the pinned_default_state

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915/gt: Stop holding onto the pinned_default_state URL : https://patchwork.freedesktop.org/series/76738/ State : success == Summary == CI Bug Log - changes from CI_DRM_8394 -> Patchwork_17519 Summary --

[Intel-gfx] [PATCH v6 10/16] drm/i915: Use ddi_update_pipe in intel_dp_mst

2020-04-29 Thread Sean Paul
From: Sean Paul In order to act upon content_protection property changes, we'll need to implement the .update_pipe() hook. We can re-use intel_ddi_update_pipe for this Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-10-s...@poorly.run #v1 Link

[Intel-gfx] [PATCH v6 04/16] drm/i915: Intercept Aksv writes in the aux hooks

2020-04-29 Thread Sean Paul
From: Sean Paul Instead of hand rolling the transfer ourselves in the hdcp hook, inspect aux messages and add the aksv flag in the aux transfer hook. IIRC, this was the original implementation and folks wanted this hack to be isolated to the hdcp code, which makes sense. However in testing an L

[Intel-gfx] [PATCH v6 09/16] drm/i915: Support DP MST in enc_to_dig_port() function

2020-04-29 Thread Sean Paul
From: Sean Paul Although DP_MST fake encoders are not subclassed from digital ports, they are associated with them. Support these encoders. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-9-s...@poorly.run #v1 Link: https://patchwork.freedesk

[Intel-gfx] [PATCH v6 12/16] drm/i915: Plumb port through hdcp init

2020-04-29 Thread Sean Paul
From: Sean Paul This patch plumbs port through hdcp init instead of relying on intel_attached_encoder() to return a non-NULL encoder which won't work for MST connectors. Cc: Ville Syrjälä Signed-off-by: Sean Paul Changes in v5: -Added to the set Changes in v6: -None Signed-off-by: Sean Paul

[Intel-gfx] [PATCH v6 07/16] drm/i915: Protect workers against disappearing connectors

2020-04-29 Thread Sean Paul
From: Sean Paul This patch adds some protection against connectors being destroyed before the HDCP workers are finished. For check_work, we do a synchronous cancel after the connector is unregistered which will ensure that it is finished before destruction. In the case of prop_work, we can't do

[Intel-gfx] [PATCH v6 15/16] drm/i915: Print HDCP version info for all connectors

2020-04-29 Thread Sean Paul
From: Sean Paul De-duplicate the HDCP version code for each connector and print it for all connectors. Cc: Juston Li Cc: Ramalingam C Reviewed-by: Juston Li Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200227185714.171466-1-s...@

[Intel-gfx] [PATCH v6 13/16] drm/i915: Add connector to hdcp_shim->check_link()

2020-04-29 Thread Sean Paul
From: Sean Paul Currently we derive the connector from digital port in check_link(). For MST, this isn't sufficient since the digital port passed into the function can have multiple connectors downstream. This patch adds connector to the check_link() arguments so we have it when we need it. Sign

[Intel-gfx] [PATCH v6 06/16] drm/i915: Factor out hdcp->value assignments

2020-04-29 Thread Sean Paul
From: Sean Paul This is a bit of housecleaning for a future patch. Instead of sprinkling hdcp->value assignments and prop_work scheduling everywhere, introduce a function to do it for us. Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20

[Intel-gfx] [PATCH v6 02/16] drm/i915: Clear the repeater bit on HDCP disable

2020-04-29 Thread Sean Paul
From: Sean Paul On HDCP disable, clear the repeater bit. This ensures if we connect a non-repeater sink after a repeater, the bit is in the state we expect. Fixes: ee5e5e7a5e0f (drm/i915: Add HDCP framework + base implementation) Cc: Chris Wilson Cc: Ramalingam C Cc: Daniel Vetter Cc: Sean Pa

[Intel-gfx] [PATCH v6 05/16] drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling

2020-04-29 Thread Sean Paul
From: Sean Paul Instead of using intel_dig_port's encoder pipe to determine which transcoder to toggle signalling on, use the cpu_transcoder field already stored in intel_hdmi. This is particularly important for MST. Suggested-by: Ville Syrjälä Reviewed-by: Ramalingam C Signed-off-by: Sean Pa

[Intel-gfx] [PATCH v6 16/16] drm/i915: Add HDCP 1.4 support for MST connectors

2020-04-29 Thread Sean Paul
From: Sean Paul Now that all the groundwork has been laid, we can turn on HDCP 1.4 over MST. Everything except for toggling the HDCP signalling and HDCP 2.2 support is the same as the DP case, so we'll re-use those callbacks Cc: Juston Li Signed-off-by: Sean Paul Link: https://patchwork.freed

[Intel-gfx] [PATCH v6 01/16] drm/i915: Fix sha_text population code

2020-04-29 Thread Sean Paul
From: Sean Paul This patch fixes a few bugs: 1- We weren't taking into account sha_leftovers when adding multiple ksvs to sha_text. As such, we were or'ing the end of ksv[j - 1] with the beginning of ksv[j] 2- In the sha_leftovers == 2 and sha_leftovers == 3 case, bstatus was being pla

[Intel-gfx] [PATCH v6 08/16] drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it

2020-04-29 Thread Sean Paul
From: Sean Paul This patch is required for HDCP over MST. If a port is being used for multiple HDCP streams, we don't want to fully disable HDCP on a port if one of them is disabled. Instead, we just disable the HDCP signalling on that particular pipe and exit early. The last pipe to disable HDCP

[Intel-gfx] [PATCH v6 11/16] drm/i915: Factor out HDCP shim functions from dp for use by dp_mst

2020-04-29 Thread Sean Paul
From: Sean Paul These functions are all the same for dp and dp_mst, so move them into a dedicated file for both sst and mst to use. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-11-s...@poorly.run #v1 Link: https://patchwork.freedesktop.org

[Intel-gfx] [PATCH v6 14/16] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message

2020-04-29 Thread Sean Paul
From: Sean Paul Used to query whether an MST stream is encrypted or not. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200218220242.107265-14-s...@poorly.run #v4 Link: https://patchwork.freedesktop.org/patch/msgid/20200305201236.152307-15-s...@poorly.run #v

[Intel-gfx] [PATCH v6 03/16] drm/i915: WARN if HDCP signalling is enabled upon disable

2020-04-29 Thread Sean Paul
From: Sean Paul HDCP signalling should not be left on, WARN if it is Cc: Ville Syrjälä Cc: Daniel Vetter Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191212190230.188505-4-s...@poorly.run #v2 Link: https://patchwork.freedesktop.o

[Intel-gfx] [PATCH v6 00/16] drm/i915: Add support for HDCP 1.4 over MST connectors

2020-04-29 Thread Sean Paul
From: Sean Paul Changes in v6: -Rebased on -tip -Disabled HDCP over MST on GEN12 -Addressed Lyude's review comments in the QUERY_STREAM_ENCRYPTION_STATUS patch Sean Paul (16): drm/i915: Fix sha_text population code drm/i915: Clear the repeater bit on HDCP disable drm/i915: WARN if HDCP sig

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdcp: Fix the return handling of drm_hdcp_check_ksvs_revoked

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Fix the return handling of drm_hdcp_check_ksvs_revoked URL : https://patchwork.freedesktop.org/series/76730/ State : success == Summary == CI Bug Log - changes from CI_DRM_8391_full -> Patchwork_17515_full

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Streamline the artihmetic

2020-04-29 Thread Chris Wilson
Quoting Ville Syrjala (2020-04-29 19:54:57) > From: Ville Syrjälä > > All these ROUNDIND_FACTORs and whatnot are making this thing hard to > read. Get rid of them. And let's massage some of the fractions to > give us less questionable intermediate results and perhaps less > divisions. > > Also l

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Nuke mode.vrefresh usage

2020-04-29 Thread Chris Wilson
Quoting Ville Syrjala (2020-04-29 19:54:55) > From: Ville Syrjälä > > mode.vrefresh is rounded to the nearest integer. You don't want to use > it anywhere that requires precision. Also I want to nuke it. > vtotal*vrefresh == 1000*clock/htotal, so let's use the latter. > > Cc: Anshuman Gupta > C

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: fix error handling in __live_lrc_indirect_ctx_bb()

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix error handling in __live_lrc_indirect_ctx_bb() URL : https://patchwork.freedesktop.org/series/76727/ State : success == Summary == CI Bug Log - changes from CI_DRM_8391_full -> Patchwork_17514_full ===

[Intel-gfx] [PATCH 3/3] drm/i915: Streamline the artihmetic

2020-04-29 Thread Ville Syrjala
From: Ville Syrjälä All these ROUNDIND_FACTORs and whatnot are making this thing hard to read. Get rid of them. And let's massage some of the fractions to give us less questionable intermediate results and perhaps less divisions. Also looks like a good helping of 64bit math stuff is needed to av

[Intel-gfx] [PATCH 2/3] drm/i915: Rename variables to be consistent with bspec

2020-04-29 Thread Ville Syrjala
From: Ville Syrjälä Since the code seems insistent on using the variable names from the bspec formulat, let's be consistent and use those names for all the things. For some reason 'link_clk' and 'lanes' were left out in the code until now. Cc: Anshuman Gupta Cc: Uma Shankar Signed-off-by: Vill

[Intel-gfx] [PATCH 1/3] drm/i915: Nuke mode.vrefresh usage

2020-04-29 Thread Ville Syrjala
From: Ville Syrjälä mode.vrefresh is rounded to the nearest integer. You don't want to use it anywhere that requires precision. Also I want to nuke it. vtotal*vrefresh == 1000*clock/htotal, so let's use the latter. Cc: Anshuman Gupta Cc: Uma Shankar Signed-off-by: Ville Syrjälä --- drivers/g

[Intel-gfx] [PATCH] drm/i915/gt: Stop holding onto the pinned_default_state

2020-04-29 Thread Chris Wilson
As we only restore the default context state upon banning a context, we only need enough of the state to run the ring and nothing more. That is we only need our bare protocontext. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Mika Kuoppala Cc: Andi Shyti --- drivers/gpu/drm/i915/gt/intel

Re: [Intel-gfx] i915 HDCP 2.2 TX encryption on Teledyne test instrument

2020-04-29 Thread Voldman, Mikhail
Hi Ram, Thank you for your help, in the past. We can control HDCP on our products as needed. One issue on the new motherboard used in our product. In this case, i915 advertises itself as DP-1 sink repeater and authenticated as HDCP 1.4 capable device, but downstream HDMI device is HDCP 2.3 capa

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Allow some leniency in PCU reads

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Allow some leniency in PCU reads URL : https://patchwork.freedesktop.org/series/76723/ State : success == Summary == CI Bug Log - changes from CI_DRM_8391_full -> Patchwork_17512_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev4)

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev4) URL : https://patchwork.freedesktop.org/series/76678/ State : success == Summary == CI Bug Log - changes from CI_DRM_8392 -> Patchwork_17518 ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev4)

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev4) URL : https://patchwork.freedesktop.org/series/76678/ State : warning == Summary == $ dim checkpatch origin/drm-tip c042783f5aa7 drm/i915/gt: Keep a no-frills swappable copy of the de

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: FBC fixes (rev2)

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915: FBC fixes (rev2) URL : https://patchwork.freedesktop.org/series/76714/ State : success == Summary == CI Bug Log - changes from CI_DRM_8392 -> Patchwork_17517 Summary --- **SUCCESS** No regres

[Intel-gfx] [CI] drm/i915/gt: Keep a no-frills swappable copy of the default context state

2020-04-29 Thread Chris Wilson
We need to keep the default context state around to instantiate new contexts (aka golden rendercontext), and we also keep it pinned while the engine is active so that we can quickly reset a hanging context. However, the default contexts are large enough to merit keeping in swappable memory as oppos

Re: ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev4)

2020-04-29 Thread Chris Wilson
Quoting Patchwork (2020-04-29 18:01:19) > == Series Details == > > Series: series starting with [CI,1/2] drm/i915/gt: Keep a no-frills swappable > copy of the default context state (rev4) > URL : https://patchwork.freedesktop.org/series/76719/ > State : failure > > == Summary == > > CI Bug Lo

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Update Slylake PCI IDs

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Update Slylake PCI IDs URL : https://patchwork.freedesktop.org/series/76720/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8391_full -> Patchwork_17510_full Summary --- **FAILUR

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev4)

2020-04-29 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev4) URL : https://patchwork.freedesktop.org/series/76719/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8392 -> Patchwork_17516

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev4)

2020-04-29 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev4) URL : https://patchwork.freedesktop.org/series/76719/ State : warning == Summary == $ dim checkpatch origin/drm-tip 33c25886e49a drm/i915/gt: Keep a no-f

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state

2020-04-29 Thread Chris Wilson
Quoting Matthew Auld (2020-04-29 17:11:38) > On 28/04/2020 22:55, Chris Wilson wrote: > > We need to keep the default context state around to instantiate new > > contexts (aka golden rendercontext), and we also keep it pinned while > > the engine is active so that we can quickly reset a hanging con

Re: [Intel-gfx] [PATCH v2] drm: Fix HDCP failures when SRM fw is missing

2020-04-29 Thread Ramalingam C
On 2020-04-29 at 10:46:29 -0400, Sean Paul wrote: > On Wed, Apr 29, 2020 at 10:22 AM Ramalingam C wrote: > > > > On 2020-04-29 at 09:58:16 -0400, Sean Paul wrote: > > > On Wed, Apr 29, 2020 at 9:50 AM Ramalingam C > > > wrote: > > > > > > > > On 2020-04-14 at 15:02:55 -0400, Sean Paul wrote: > >

Re: [Intel-gfx] [PATCH i-g-t v8 0/4] Add support for testing writeback connectors

2020-04-29 Thread Maxime Ripard
Hi, On Thu, Apr 23, 2020 at 09:26:01PM -0400, Rodrigo Siqueira wrote: > A couple of months ago, I updated and re-submitted a patchset made by > Brian Starkey and Liviu Dudau for adding a writeback connectors test to > IGT. It is important to highlight that DRM already have writeback > connectors s

Re: [Intel-gfx] [PATCH v2] drm: make drm_file use keyed wakeups

2020-04-29 Thread kl
April 28, 2020 5:14 PM, "Daniel Vetter" wrote: > On Fri, Apr 24, 2020 at 06:26:15PM +0200, Kenny Levinsen wrote: > >> Some processes, such as systemd, are only polling for EPOLLERR|EPOLLHUP. >> As drm_file uses unkeyed wakeups, such a poll can receive many spurious >> wakeups from uninteresting

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state

2020-04-29 Thread Matthew Auld
On 28/04/2020 22:55, Chris Wilson wrote: We need to keep the default context state around to instantiate new contexts (aka golden rendercontext), and we also keep it pinned while the engine is active so that we can quickly reset a hanging context. However, the default contexts are large enough to

Re: [Intel-gfx] [PATCH i-g-t] perf: Flush the work between rounds of gen8-unprivileged-single-ctx-counter

2020-04-29 Thread Lionel Landwerlin
On 29/04/2020 18:26, Chris Wilson wrote: Quoting Lionel Landwerlin (2020-04-29 16:23:34) On 29/04/2020 18:05, Chris Wilson wrote: Wait until the GPU is idle before starting a fresh round of probing gen8-unprivileged-single-ctx-counter. This avoids building up a huge backlog of render copies, ho

Re: [Intel-gfx] [patch] drm/i915: Update Slylake PCI IDs

2020-04-29 Thread Alexei Podtelezhnikov
On Wed, Apr 29, 2020 at 7:41 AM Alexei Podtelezhnikov wrote: > > Add three new devices 0x1913, 0x1915, and 0x1917 also known as > iSKLULTGT15, iSKLULXGT15, and iSKLDTGT15. Reclassify 0x1923, 0x1927, > and 0x192A according to specifications. Of note, the second to last > digit seems to correspond t

[Intel-gfx] [PATCH v2 02/12] drm/i915/fbc: Use the correct plane stride

2020-04-29 Thread Ville Syrjala
From: Ville Syrjälä Consult the actual plane stride instead of the fb stride. The two will disagree when we remap the gtt. The plane stride is what the hw will be fed so that's what we should look at for the FBC retrictions/cfb allocation. Since we no longer require a fence we are going to attem

Re: [Intel-gfx] [PATCH i-g-t] perf: Flush the work between rounds of gen8-unprivileged-single-ctx-counter

2020-04-29 Thread Chris Wilson
Quoting Lionel Landwerlin (2020-04-29 16:23:34) > On 29/04/2020 18:05, Chris Wilson wrote: > > Wait until the GPU is idle before starting a fresh round of probing > > gen8-unprivileged-single-ctx-counter. This avoids building up a huge > > backlog of render copies, hogging buffers and stale context

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Put drm_display_mode on diet (rev6)

2020-04-29 Thread Patchwork
== Series Details == Series: drm: Put drm_display_mode on diet (rev6) URL : https://patchwork.freedesktop.org/series/73674/ State : success == Summary == CI Bug Log - changes from CI_DRM_8390_full -> Patchwork_17509_full Summary ---

Re: [Intel-gfx] [PATCH i-g-t] perf: Flush the work between rounds of gen8-unprivileged-single-ctx-counter

2020-04-29 Thread Lionel Landwerlin
On 29/04/2020 18:05, Chris Wilson wrote: Wait until the GPU is idle before starting a fresh round of probing gen8-unprivileged-single-ctx-counter. This avoids building up a huge backlog of render copies, hogging buffers and stale contexts, and invoking the oomkiller. v2: Release everything befor

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: Fix the return handling of drm_hdcp_check_ksvs_revoked

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Fix the return handling of drm_hdcp_check_ksvs_revoked URL : https://patchwork.freedesktop.org/series/76730/ State : success == Summary == CI Bug Log - changes from CI_DRM_8391 -> Patchwork_17515

[Intel-gfx] [PATCH] drm/i915/gt: Stop keeping the pinned_default_state

2020-04-29 Thread Chris Wilson
As we only restore the default context state upon banning a context, we only need enough of the state to run the ring and nothing more. That is we only need our bare protocontext. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Mika Kuoppala Cc: Andi Shyti --- drivers/gpu/drm/i915/gt/intel

[Intel-gfx] [PATCH i-g-t] perf: Flush the work between rounds of gen8-unprivileged-single-ctx-counter

2020-04-29 Thread Chris Wilson
Wait until the GPU is idle before starting a fresh round of probing gen8-unprivileged-single-ctx-counter. This avoids building up a huge backlog of render copies, hogging buffers and stale contexts, and invoking the oomkiller. v2: Release everything before starting again. Signed-off-by: Chris Wil

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] perf: Flush the work between rounds of gen8-unprivileged-single-ctx-counter

2020-04-29 Thread Chris Wilson
Quoting Lionel Landwerlin (2020-04-29 15:57:41) > Oh... Is that on a low end platform? glk. But it was mostly that it got stuck in the rut of hitting -EAGAIN. /* This needs to be investigated... From time * to time, the work we kick off doesn't seem * to happen. WTH?? */ Hmm. And that's before

Re: [Intel-gfx] [PATCH i-g-t] perf: Flush the work between rounds of gen8-unprivileged-single-ctx-counter

2020-04-29 Thread Lionel Landwerlin
Oh... Is that on a low end platform? Looks alright : Reviewed-by: Lionel Landwerlin Thanks, -Lionel On 29/04/2020 17:51, Chris Wilson wrote: Wait until the GPU is idle before starting a fresh round of probing gen8-unprivileged-single-ctx-counter. This avoids building up a huge backlog of re

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: fix error handling in __live_lrc_indirect_ctx_bb()

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix error handling in __live_lrc_indirect_ctx_bb() URL : https://patchwork.freedesktop.org/series/76727/ State : success == Summary == CI Bug Log - changes from CI_DRM_8391 -> Patchwork_17514

[Intel-gfx] [PATCH i-g-t] perf: Flush the work between rounds of gen8-unprivileged-single-ctx-counter

2020-04-29 Thread Chris Wilson
Wait until the GPU is idle before starting a fresh round of probing gen8-unprivileged-single-ctx-counter. This avoids building up a huge backlog of render copies, hogging buffers and stale contexts, and invoking the oomkiller. Signed-off-by: Chris Wilson Cc: Lionel Landwerlin --- tests/perf.c |

Re: [Intel-gfx] [PATCH] drm/i915/hdcp: Fix the return handling of drm_hdcp_check_ksvs_revoked

2020-04-29 Thread Sean Paul
On Wed, Apr 29, 2020 at 9:46 AM Ramalingam C wrote: > > drm_hdcp_check_ksvs_revoked() returns the number of revoked keys and > error codes when the SRM parsing is failed. > > Errors in SRM parsing can't affect the HDCP auth, hence with this patch, > I915 will look out for revoked key count alone.

Re: [Intel-gfx] [PATCH v2] drm: Fix HDCP failures when SRM fw is missing

2020-04-29 Thread Sean Paul
On Wed, Apr 29, 2020 at 10:22 AM Ramalingam C wrote: > > On 2020-04-29 at 09:58:16 -0400, Sean Paul wrote: > > On Wed, Apr 29, 2020 at 9:50 AM Ramalingam C wrote: > > > > > > On 2020-04-14 at 15:02:55 -0400, Sean Paul wrote: > > > > From: Sean Paul > > > > > > > > The SRM cleanup in 79643fddd6eb

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists

2020-04-29 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/gt: Always enable busy-stats for execlists URL : https://patchwork.freedesktop.org/series/76715/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8390_full -> Patchwork_17508_full ===

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/25] perf/core: Only copy-to-user after completely unlocking all locks, v3.

2020-04-29 Thread Patchwork
== Series Details == Series: series starting with [01/25] perf/core: Only copy-to-user after completely unlocking all locks, v3. URL : https://patchwork.freedesktop.org/series/76724/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8391 -> Patchwork_17513 ===

Re: [Intel-gfx] [PATCH v2] drm: Fix HDCP failures when SRM fw is missing

2020-04-29 Thread Ramalingam C
On 2020-04-29 at 09:58:16 -0400, Sean Paul wrote: > On Wed, Apr 29, 2020 at 9:50 AM Ramalingam C wrote: > > > > On 2020-04-14 at 15:02:55 -0400, Sean Paul wrote: > > > From: Sean Paul > > > > > > The SRM cleanup in 79643fddd6eb2 ("drm/hdcp: optimizing the srm > > > handling") inadvertently altere

Re: [Intel-gfx] [PATCH] drm/i915: Avoid dereferencing a dead context

2020-04-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-04-29 14:42:44) > > On 28/04/2020 10:02, Chris Wilson wrote: > > Once the intel_context is closed, the GEM context may be freed and so > > the link from intel_context.gem_context is invalid. > > > > <3>[ 219.782944] BUG: KASAN: use-after-free in > > intel_engine_cor

Re: [Intel-gfx] [PATCH] drm/i915/selftests: fix error handling in __live_lrc_indirect_ctx_bb()

2020-04-29 Thread Andi Shyti
Hi Dan, On Wed, Apr 29, 2020 at 04:24:25PM +0300, Dan Carpenter wrote: > If intel_context_create() fails then it leads to an error pointer > dereference. I shuffled things around to make error handling easier. > > Fixes: 1dd47b54baea ("drm/i915: Add live selftests for indirect ctx > batchbuffer

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/25] perf/core: Only copy-to-user after completely unlocking all locks, v3.

2020-04-29 Thread Patchwork
== Series Details == Series: series starting with [01/25] perf/core: Only copy-to-user after completely unlocking all locks, v3. URL : https://patchwork.freedesktop.org/series/76724/ State : warning == Summary == $ dim checkpatch origin/drm-tip fafe194bca56 perf/core: Only copy-to-user after

Re: [Intel-gfx] [PATCH v2] drm: Fix HDCP failures when SRM fw is missing

2020-04-29 Thread Sean Paul
On Wed, Apr 29, 2020 at 9:50 AM Ramalingam C wrote: > > On 2020-04-14 at 15:02:55 -0400, Sean Paul wrote: > > From: Sean Paul > > > > The SRM cleanup in 79643fddd6eb2 ("drm/hdcp: optimizing the srm > > handling") inadvertently altered the behavior of HDCP auth when > > the SRM firmware is missing

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Allow some leniency in PCU reads

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Allow some leniency in PCU reads URL : https://patchwork.freedesktop.org/series/76723/ State : success == Summary == CI Bug Log - changes from CI_DRM_8391 -> Patchwork_17512 Summary --- **SUCCES

Re: [Intel-gfx] [PATCH] drm/i915/selftests: fix error handling in __live_lrc_indirect_ctx_bb()

2020-04-29 Thread Chris Wilson
Quoting Dan Carpenter (2020-04-29 14:24:25) > If intel_context_create() fails then it leads to an error pointer > dereference. I shuffled things around to make error handling easier. > > Fixes: 1dd47b54baea ("drm/i915: Add live selftests for indirect ctx > batchbuffers") > Signed-off-by: Dan Car

Re: ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev3)

2020-04-29 Thread Chris Wilson
Quoting Patchwork (2020-04-29 14:46:49) > == Series Details == > > Series: series starting with [CI,1/2] drm/i915/gt: Keep a no-frills swappable > copy of the default context state (rev3) > URL : https://patchwork.freedesktop.org/series/76719/ > State : failure > > == Summary == > > CI Bug Lo

Re: [Intel-gfx] [PATCH v2] drm: Fix HDCP failures when SRM fw is missing

2020-04-29 Thread Ramalingam C
On 2020-04-14 at 15:02:55 -0400, Sean Paul wrote: > From: Sean Paul > > The SRM cleanup in 79643fddd6eb2 ("drm/hdcp: optimizing the srm > handling") inadvertently altered the behavior of HDCP auth when > the SRM firmware is missing. Before that patch, missing SRM was > interpreted as the device h

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev3)

2020-04-29 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Keep a no-frills swappable copy of the default context state (rev3) URL : https://patchwork.freedesktop.org/series/76719/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8391 -> Patchwork_17511

[Intel-gfx] [PATCH] drm/i915/hdcp: Fix the return handling of drm_hdcp_check_ksvs_revoked

2020-04-29 Thread Ramalingam C
drm_hdcp_check_ksvs_revoked() returns the number of revoked keys and error codes when the SRM parsing is failed. Errors in SRM parsing can't affect the HDCP auth, hence with this patch, I915 will look out for revoked key count alone. Signed-off-by: Ramalingam C cc: Sean Paul --- drivers/gpu/dr

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: FBC fixes

2020-04-29 Thread Patchwork
== Series Details == Series: drm/i915: FBC fixes URL : https://patchwork.freedesktop.org/series/76714/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8390_full -> Patchwork_17507_full Summary --- **FAILURE** Seriou

Re: [Intel-gfx] [PATCH] drm/i915: Avoid dereferencing a dead context

2020-04-29 Thread Tvrtko Ursulin
On 28/04/2020 10:02, Chris Wilson wrote: Once the intel_context is closed, the GEM context may be freed and so the link from intel_context.gem_context is invalid. <3>[ 219.782944] BUG: KASAN: use-after-free in intel_engine_coredump_alloc+0x1bc3/0x2250 [i915] <3>[ 219.782996] Read of size 8

  1   2   >