Re: [Intel-gfx] [PATCH] RFC: i915: Drop relocation support on Gen12+

2020-05-07 Thread Joonas Lahtinen
Quoting Dave Airlie (2020-05-07 21:27:27) > On Fri, 8 May 2020 at 01:44, Chris Wilson wrote: > > > > Quoting Jason Ekstrand (2020-05-07 16:36:00) > > > The Vulkan driver in Mesa for Intel hardware never uses relocations if > > > it's running on a version of i915 that supports at least softpin

[Intel-gfx] [PULL] drm-intel-fixes

2020-05-07 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2020-05-07: - Fixes on execlist to avoid GPU hang situation (Chris) - Fixes couple deadlocks (Chris) - Timeslice preemption fixes (Chris) - Fix Display Port interrupt handling on Tiger Lake (Imre) - Reduce debug noise around Frame Buffer Compression

[Intel-gfx] linux-next: build failure after merge of the drm tree

2020-05-07 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from include/asm-generic/bug.h:19, from arch/x86/include/asm/bug.h:83, from include/linux/bug.h:5, from

[Intel-gfx] linux-next: manual merge of the drm tree with the drm-intel-fixes tree

2020-05-07 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/i915/gem/i915_gem_domain.c between commit: 47bf7b7a7151 ("drm/i915/gem: Remove object_is_locked assertion from unpin_from_display_plane") from the drm-intel-fixes tree and commit: 9da0ea09639f

Re: [Intel-gfx] [PATCH v11 14/14] drm/i915/psr: Use new DP VSC SDP compute routine on PSR

2020-05-07 Thread kbuild test robot
Hi Gwan-gyeong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next next-20200507] [cannot apply to tegra-drm/drm/tegra/for-next linus/master v5.7-rc4] [if your patch

Re: [Intel-gfx] [PATCH] drm/i915/mst: filter out the display mode exceed sink's capability

2020-05-07 Thread Lyude Paul
On Thu, 2020-04-30 at 02:37 +, Lee, Shawn C wrote: > On Sat, 2020-04-25, Lyude Paul wrote: > > Hi! Sorry this took me a little while to get back to, I had a couple of > > MST regressions that I had to look into > > > > On Sat, 2020-04-18 at 05:24 +0800, Lee Shawn C wrote: > > > So far, max

Re: [Intel-gfx] [PATCH 4/4] drm/i915/gen12: Invalidate aux table entries forcibly

2020-05-07 Thread Rafael Antognolli
On Wed, May 06, 2020 at 04:32:02PM +0100, Chris Wilson wrote: > Quoting Mika Kuoppala (2020-05-06 16:20:22) > > Chris Wilson writes: > > > > > Quoting Mika Kuoppala (2020-05-06 15:47:34) > > >> Aux table invalidation can fail on update. So > > >> next access may cause memory access to be into

Re: [Intel-gfx] [PATCH] drm/i915/gen12: Add aux table invalidate for all engines

2020-05-07 Thread Daniele Ceraolo Spurio
On 5/7/20 7:20 AM, Mika Kuoppala wrote: All engines, exception being blitter as it does not care about the form, can access compressed surfaces. So we need to add forced aux table invalidates for those engines. v2: virtual instance masking (Chris) v3: bug on if not found (Chris)

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2] drm/i915: Mark concurrent submissions with a weak-dependency (rev3)

2020-05-07 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915: Mark concurrent submissions with a weak-dependency (rev3) URL : https://patchwork.freedesktop.org/series/77045/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8444_full -> Patchwork_17606_full

[Intel-gfx] ✓ Fi.CI.IGT: success for SAGV support for Gen12+ (rev36)

2020-05-07 Thread Patchwork
== Series Details == Series: SAGV support for Gen12+ (rev36) URL : https://patchwork.freedesktop.org/series/75129/ State : success == Summary == CI Bug Log - changes from CI_DRM_8444_full -> Patchwork_17603_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mst: Wait for ACT sent before enabling the pipe

2020-05-07 Thread Patchwork
== Series Details == Series: drm/i915/mst: Wait for ACT sent before enabling the pipe URL : https://patchwork.freedesktop.org/series/77040/ State : success == Summary == CI Bug Log - changes from CI_DRM_8444_full -> Patchwork_17602_full

Re: [Intel-gfx] [PATCH] RFC: i915: Drop relocation support on Gen12+

2020-05-07 Thread Dave Airlie
On Fri, 8 May 2020 at 01:44, Chris Wilson wrote: > > Quoting Jason Ekstrand (2020-05-07 16:36:00) > > The Vulkan driver in Mesa for Intel hardware never uses relocations if > > it's running on a version of i915 that supports at least softpin which > > all versions of i915 supporting Gen12 do. On

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gen12: Add aux table invalidate for all engines (rev2)

2020-05-07 Thread Patchwork
== Series Details == Series: drm/i915/gen12: Add aux table invalidate for all engines (rev2) URL : https://patchwork.freedesktop.org/series/77038/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8444_full -> Patchwork_17601_full

Re: [Intel-gfx] [PATCH v2 14/22] drm/i915/rkl: provide port/phy mapping for vbt

2020-05-07 Thread Matt Roper
On Thu, May 07, 2020 at 03:04:30PM +0300, Ville Syrjälä wrote: > On Mon, May 04, 2020 at 03:52:19PM -0700, Matt Roper wrote: > > From: Lucas De Marchi > > > > RKL uses the DDI A, DDI B, DDI USBC1, DDI USBC2 from the DE point of > > view, so all DDI/pipe/transcoder register use these indexes to

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Mark concurrent submissions with a weak-dependency

2020-05-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-05-07 18:55:17) > > On 07/05/2020 16:34, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-05-07 16:23:59) > >> On 07/05/2020 16:00, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2020-05-07 15:53:08) > On 07/05/2020 09:21, Chris Wilson wrote: > > We

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Remove wait priority boosting

2020-05-07 Thread Tvrtko Ursulin
On 07/05/2020 16:23, Chris Wilson wrote: Upon waiting a request (when asked), we gave that request a small priority boost, not enough for it to cause preemption, but enough for it to be scheduled next before all equals. We also used that bit to give new clients a small priority boost, similar

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Mark concurrent submissions with a weak-dependency

2020-05-07 Thread Tvrtko Ursulin
On 07/05/2020 16:23, Chris Wilson wrote: We recorded the dependencies for WAIT_FOR_SUBMIT in order that we could correctly perform priority inheritance from the parallel branches to the common trunk. However, for the purpose of timeslicing and reset handling, the dependency is weak -- as we

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Mark concurrent submissions with a weak-dependency

2020-05-07 Thread Tvrtko Ursulin
On 07/05/2020 16:34, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-05-07 16:23:59) On 07/05/2020 16:00, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-05-07 15:53:08) On 07/05/2020 09:21, Chris Wilson wrote: We recorded the dependencies for WAIT_FOR_SUBMIT in order that we could

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Mark concurrent submissions with a weak-dependency (rev3)

2020-05-07 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915: Mark concurrent submissions with a weak-dependency (rev3) URL : https://patchwork.freedesktop.org/series/77045/ State : success == Summary == CI Bug Log - changes from CI_DRM_8444 -> Patchwork_17606

[Intel-gfx] ✓ Fi.CI.IGT: success for In order to readout DP SDPs, refactors the handling of DP SDPs (rev13)

2020-05-07 Thread Patchwork
== Series Details == Series: In order to readout DP SDPs, refactors the handling of DP SDPs (rev13) URL : https://patchwork.freedesktop.org/series/72853/ State : success == Summary == CI Bug Log - changes from CI_DRM_8444_full -> Patchwork_17600_full

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Remove wait priority boosting

2020-05-07 Thread Chris Wilson
Quoting Chris Wilson (2020-05-07 16:23:38) > Upon waiting a request (when asked), we gave that request a small > priority boost, not enough for it to cause preemption, but enough for it > to be scheduled next before all equals. We also used that bit to give > new clients a small priority boost,

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2] drm/i915: Mark concurrent submissions with a weak-dependency (rev2)

2020-05-07 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915: Mark concurrent submissions with a weak-dependency (rev2) URL : https://patchwork.freedesktop.org/series/77045/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8444 -> Patchwork_17605

[Intel-gfx] ✓ Fi.CI.BAT: success for SAGV support for Gen12+ (rev36)

2020-05-07 Thread Patchwork
== Series Details == Series: SAGV support for Gen12+ (rev36) URL : https://patchwork.freedesktop.org/series/75129/ State : success == Summary == CI Bug Log - changes from CI_DRM_8444 -> Patchwork_17603 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.BUILD: failure for RFC: i915: Drop relocation support on Gen12+

2020-05-07 Thread Patchwork
== Series Details == Series: RFC: i915: Drop relocation support on Gen12+ URL : https://patchwork.freedesktop.org/series/77048/ State : failure == Summary == Applying: RFC: i915: Drop relocation support on Gen12+ Using index info to reconstruct a base tree... M

Re: [Intel-gfx] [PATCH] drm/i915/gen12: Add aux table invalidate for all engines

2020-05-07 Thread Chris Wilson
Quoting Mika Kuoppala (2020-05-07 15:20:45) > All engines, exception being blitter as it does not > care about the form, can access compressed surfaces. > > So we need to add forced aux table invalidates > for those engines. > > v2: virtual instance masking (Chris) > v3: bug on if not found

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for SAGV support for Gen12+ (rev36)

2020-05-07 Thread Patchwork
== Series Details == Series: SAGV support for Gen12+ (rev36) URL : https://patchwork.freedesktop.org/series/75129/ State : warning == Summary == $ dim checkpatch origin/drm-tip 74acb8869d96 drm/i915: Introduce skl_plane_wm_level accessor. 37b1bc532f92 drm/i915: Extract skl SAGV checking

[Intel-gfx] [PULL] drm-misc-fixes

2020-05-07 Thread Maxime Ripard
Hi! Here is this week drm-misc-fixes PR Maxime drm-misc-fixes-2020-05-07: A few minor fixes for an ordering issue in virtio, an (old) gcc warning in sun4i, a probe issue in ingenic-drm and a regression in the HDCP support. The following changes since commit

Re: [Intel-gfx] [PATCH] RFC: i915: Drop relocation support on Gen12+

2020-05-07 Thread Jason Ekstrand
On Thu, May 7, 2020 at 10:44 AM Chris Wilson wrote: > > Quoting Jason Ekstrand (2020-05-07 16:36:00) > > The Vulkan driver in Mesa for Intel hardware never uses relocations if > > it's running on a version of i915 that supports at least softpin which > > all versions of i915 supporting Gen12 do.

[Intel-gfx] [PATCH v2] drm/i915: Mark concurrent submissions with a weak-dependency

2020-05-07 Thread Chris Wilson
We recorded the dependencies for WAIT_FOR_SUBMIT in order that we could correctly perform priority inheritance from the parallel branches to the common trunk. However, for the purpose of timeslicing and reset handling, the dependency is weak -- as we the pair of requests are allowed to run in

Re: [Intel-gfx] [PATCH] RFC: i915: Drop relocation support on Gen12+

2020-05-07 Thread Chris Wilson
Quoting Jason Ekstrand (2020-05-07 16:36:00) > The Vulkan driver in Mesa for Intel hardware never uses relocations if > it's running on a version of i915 that supports at least softpin which > all versions of i915 supporting Gen12 do. On the OpenGL side, Gen12 is > only supported by iris which

[Intel-gfx] [PATCH] RFC: i915: Drop relocation support on Gen12+

2020-05-07 Thread Jason Ekstrand
The Vulkan driver in Mesa for Intel hardware never uses relocations if it's running on a version of i915 that supports at least softpin which all versions of i915 supporting Gen12 do. On the OpenGL side, Gen12 is only supported by iris which never uses relocations. The older i965 driver in Mesa

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mst: Wait for ACT sent before enabling the pipe

2020-05-07 Thread Patchwork
== Series Details == Series: drm/i915/mst: Wait for ACT sent before enabling the pipe URL : https://patchwork.freedesktop.org/series/77040/ State : success == Summary == CI Bug Log - changes from CI_DRM_8444 -> Patchwork_17602 Summary

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Mark concurrent submissions with a weak-dependency

2020-05-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-05-07 16:23:59) > > > On 07/05/2020 16:00, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-05-07 15:53:08) > >> On 07/05/2020 09:21, Chris Wilson wrote: > >>> We recorded the dependencies for WAIT_FOR_SUBMIT in order that we could > >>> correctly perform

[Intel-gfx] [PATCH 1/3] drm/i915: Mark concurrent submissions with a weak-dependency

2020-05-07 Thread Chris Wilson
We recorded the dependencies for WAIT_FOR_SUBMIT in order that we could correctly perform priority inheritance from the parallel branches to the common trunk. However, for the purpose of timeslicing and reset handling, the dependency is weak -- as we the pair of requests are allowed to run in

[Intel-gfx] [PATCH 3/3] drm/i915: Remove wait priority boosting

2020-05-07 Thread Chris Wilson
Upon waiting a request (when asked), we gave that request a small priority boost, not enough for it to cause preemption, but enough for it to be scheduled next before all equals. We also used that bit to give new clients a small priority boost, similar to FQ_CODEL, such that we favoured short

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Mark concurrent submissions with a weak-dependency

2020-05-07 Thread Tvrtko Ursulin
On 07/05/2020 16:00, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-05-07 15:53:08) On 07/05/2020 09:21, Chris Wilson wrote: We recorded the dependencies for WAIT_FOR_SUBMIT in order that we could correctly perform priority inheritance from the parallel branches to the common trunk.

[Intel-gfx] [PATCH 2/3] drm/i915: Treat weak-dependencies as bidirectional when applying priorities

2020-05-07 Thread Chris Wilson
Clients may use a submit-fence as bidirectional bond between two or more co-operating requests, and so if we bump the priority of one, we wish to bump the priority of the set. Testcase: igt/gem_exec_fence/submitN Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin ---

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gem: Treat submit-fence as weak dependency for new clients

2020-05-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-05-07 16:10:37) > > On 07/05/2020 16:05, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-05-07 15:59:56) > >> > >> On 07/05/2020 09:21, Chris Wilson wrote: > >>> The submit-fence adds a weak dependency to the requests, and for the > >>> purpose of our FQ_CODEL

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gem: Treat submit-fence as weak dependency for new clients

2020-05-07 Thread Tvrtko Ursulin
On 07/05/2020 16:05, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-05-07 15:59:56) On 07/05/2020 09:21, Chris Wilson wrote: The submit-fence adds a weak dependency to the requests, and for the purpose of our FQ_CODEL hinting we do not want to treat as a restriction. This is primarily

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gen12: Add aux table invalidate for all engines (rev2)

2020-05-07 Thread Patchwork
== Series Details == Series: drm/i915/gen12: Add aux table invalidate for all engines (rev2) URL : https://patchwork.freedesktop.org/series/77038/ State : success == Summary == CI Bug Log - changes from CI_DRM_8444 -> Patchwork_17601

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gem: Treat submit-fence as weak dependency for new clients

2020-05-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-05-07 15:59:56) > > On 07/05/2020 09:21, Chris Wilson wrote: > > The submit-fence adds a weak dependency to the requests, and for the > > purpose of our FQ_CODEL hinting we do not want to treat as a > > restriction. This is primarily because clients may treat

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Mark concurrent submissions with a weak-dependency

2020-05-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-05-07 15:53:08) > > On 07/05/2020 09:21, Chris Wilson wrote: > > We recorded the dependencies for WAIT_FOR_SUBMIT in order that we could > > correctly perform priority inheritance from the parallel branches to the > > common trunk. However, for the purpose of

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gem: Treat submit-fence as weak dependency for new clients

2020-05-07 Thread Tvrtko Ursulin
On 07/05/2020 09:21, Chris Wilson wrote: The submit-fence adds a weak dependency to the requests, and for the purpose of our FQ_CODEL hinting we do not want to treat as a restriction. This is primarily because clients may treat submit-fences as a bidirectional bonding between a pair of

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Treat weak-dependencies as bidirectional when applying priorities

2020-05-07 Thread Tvrtko Ursulin
On 07/05/2020 09:21, Chris Wilson wrote: Clients may use a submit-fence as bidirectional bond between two or more co-operating requests, and so if we bump the priority of one, we wish to bump the priority of the set. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin ---

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Mark concurrent submissions with a weak-dependency

2020-05-07 Thread Tvrtko Ursulin
On 07/05/2020 09:21, Chris Wilson wrote: We recorded the dependencies for WAIT_FOR_SUBMIT in order that we could correctly perform priority inheritance from the parallel branches to the common trunk. However, for the purpose of timeslicing and reset handling, the dependency is weak -- as we

[Intel-gfx] ✓ Fi.CI.BAT: success for In order to readout DP SDPs, refactors the handling of DP SDPs (rev13)

2020-05-07 Thread Patchwork
== Series Details == Series: In order to readout DP SDPs, refactors the handling of DP SDPs (rev13) URL : https://patchwork.freedesktop.org/series/72853/ State : success == Summary == CI Bug Log - changes from CI_DRM_8444 -> Patchwork_17600

[Intel-gfx] [PATCH v28 1/6] drm/i915: Introduce skl_plane_wm_level accessor.

2020-05-07 Thread Stanislav Lisovskiy
For future Gen12 SAGV implementation we need to seemlessly alter wm levels calculated, depending on whether we are allowed to enable SAGV or not. So this accessor will give additional flexibility to do that. Currently this accessor is still simply working as "pass-through" function. This will be

[Intel-gfx] [PATCH v28 0/6] SAGV support for Gen12+

2020-05-07 Thread Stanislav Lisovskiy
For Gen11+ platforms BSpec suggests disabling specific QGV points separately, depending on bandwidth limitations and current display configuration. Thus it required adding a new PCode request for disabling QGV points and some refactoring of already existing SAGV code. Also had to refactor

[Intel-gfx] [PATCH v28 4/6] drm/i915: Add TGL+ SAGV support

2020-05-07 Thread Stanislav Lisovskiy
Starting from TGL we need to have a separate wm0 values for SAGV and non-SAGV which affects how calculations are done. v2: Remove long lines v3: Removed COLOR_PLANE enum references v4, v5, v6: Fixed rebase conflict v7: - Removed skl_plane_wm_level accessor from skl_allocate_pipe_ddb(Ville) -

[Intel-gfx] [PATCH v28 6/6] drm/i915: Enable SAGV support for Gen12

2020-05-07 Thread Stanislav Lisovskiy
Flip the switch and enable SAGV support for Gen12 also. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_pm.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 66775d4fb1ae..ef2ec390b99b 100644 ---

[Intel-gfx] [PATCH v28 5/6] drm/i915: Restrict qgv points which don't have enough bandwidth.

2020-05-07 Thread Stanislav Lisovskiy
According to BSpec 53998, we should try to restrict qgv points, which can't provide enough bandwidth for desired display configuration. Currently we are just comparing against all of those and take minimum(worst case). v2: Fixed wrong PCode reply mask, removed hardcoded values. v3: Forbid

[Intel-gfx] [PATCH v28 3/6] drm/i915: Make active_pipes check skl specific

2020-05-07 Thread Stanislav Lisovskiy
Seems that only skl needs to have SAGV turned off for multipipe scenarios, so lets do it this way. If anything blows up - we can always revert this patch. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_pm.c | 15 +-- drivers/gpu/drm/i915/intel_pm.h | 3 ++- 2

[Intel-gfx] [PATCH v28 2/6] drm/i915: Extract skl SAGV checking

2020-05-07 Thread Stanislav Lisovskiy
Introduce platform dependent SAGV checking in combination with bandwidth state pipe SAGV mask. This is preparation to adding TGL support, which requires different way of SAGV checking. v2, v3, v4, v5, v6: Fix rebase conflict v7: - Nuke icl specific function, use skl for icl as well, gen

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gen12: Add aux table invalidate for all engines (rev2)

2020-05-07 Thread Patchwork
== Series Details == Series: drm/i915/gen12: Add aux table invalidate for all engines (rev2) URL : https://patchwork.freedesktop.org/series/77038/ State : warning == Summary == $ dim checkpatch origin/drm-tip e20a34365bd6 drm/i915/gen12: Add aux table invalidate for all engines -:15:

[Intel-gfx] [kbuild] Re: [PATCH v12 3/4] drm/i915/perf: prepare driver to receive multiple ctx handles

2020-05-07 Thread Dan Carpenter
Hi Lionel, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Lionel-Landwerlin/drm-i915-perf-Add-support-for-multi-context-perf-queries/20200505-060720 base: git://anongit.freedesktop.org/drm-intel for-linux-next If you fix the issue,

[Intel-gfx] [PATCH] drm/i915/mst: Wait for ACT sent before enabling the pipe

2020-05-07 Thread Ville Syrjala
From: Ville Syrjälä The correct sequence according to bspec is to wait for the ACT sent status before we turn on the pipe. Make it so. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915/gen12: Add aux table invalidate for all engines

2020-05-07 Thread Mika Kuoppala
All engines, exception being blitter as it does not care about the form, can access compressed surfaces. So we need to add forced aux table invalidates for those engines. v2: virtual instance masking (Chris) v3: bug on if not found (Chris) References: d248b371f747 ("drm/i915/gen12: Invalidate

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for In order to readout DP SDPs, refactors the handling of DP SDPs (rev13)

2020-05-07 Thread Patchwork
== Series Details == Series: In order to readout DP SDPs, refactors the handling of DP SDPs (rev13) URL : https://patchwork.freedesktop.org/series/72853/ State : warning == Summary == $ dim checkpatch origin/drm-tip 96f3abd228ee video/hdmi: Add Unpack only function for DRM infoframe

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Hotplug cleanups (rev7)

2020-05-07 Thread Patchwork
== Series Details == Series: drm/i915: Hotplug cleanups (rev7) URL : https://patchwork.freedesktop.org/series/72348/ State : success == Summary == CI Bug Log - changes from CI_DRM_8442_full -> Patchwork_17599_full Summary ---

Re: [Intel-gfx] [PATCH 12/15] drm/i915: Replace the hardcoded I915_FENCE_TIMEOUT

2020-05-07 Thread Chris Wilson
Quoting Ruhl, Michael J (2020-05-07 14:53:00) > > > >-Original Message- > >From: Intel-gfx On Behalf Of Chris > >Wilson > >diff --git a/drivers/gpu/drm/i915/gem/i915_gem_client_blt.c > >b/drivers/gpu/drm/i915/gem/i915_gem_client_blt.c > >index 3a146aa2593b..d3a86a4d5c04 100644 > >---

Re: [Intel-gfx] [PATCH 12/15] drm/i915: Replace the hardcoded I915_FENCE_TIMEOUT

2020-05-07 Thread Ruhl, Michael J
>-Original Message- >From: Intel-gfx On Behalf Of Chris >Wilson >Sent: Wednesday, May 6, 2020 4:59 PM >To: intel-gfx@lists.freedesktop.org >Cc: Chris Wilson >Subject: [Intel-gfx] [PATCH 12/15] drm/i915: Replace the hardcoded >I915_FENCE_TIMEOUT > >Expose the hardcoded timeout for

Re: [Intel-gfx] [PATCH] drm/i915/gen12: Add aux table invalidate for all engines

2020-05-07 Thread Chris Wilson
Quoting Mika Kuoppala (2020-05-07 14:41:22) > All engines, exception being blitter as it does not > care about the form, can access compressed surfaces. > > So we need to add forced aux table invalidates > for those engines. > > v2: virtual instance masking (Chris) > > References: d248b371f747

[Intel-gfx] [PATCH] drm/i915/gen12: Add aux table invalidate for all engines

2020-05-07 Thread Mika Kuoppala
All engines, exception being blitter as it does not care about the form, can access compressed surfaces. So we need to add forced aux table invalidates for those engines. v2: virtual instance masking (Chris) References: d248b371f747 ("drm/i915/gen12: Invalidate aux table entries forcibly")

[Intel-gfx] [PATCH v11 13/14] drm/i915/dp: Add compute routine for DP PSR VSC SDP

2020-05-07 Thread Gwan-gyeong Mun
In order to use a common VSC SDP Colorimetry calculating code on PSR, it adds a compute routine for PSR VSC SDP. As PSR routine can not use infoframes.vsc of crtc state, it also adds new writing of DP SDPs (Secondary Data Packet) for PSR. PSR routine has its own scenario and timings of writing a

[Intel-gfx] [PATCH v11 01/14] video/hdmi: Add Unpack only function for DRM infoframe

2020-05-07 Thread Gwan-gyeong Mun
It adds an unpack only function for DRM infoframe for dynamic range and mastering infoframe readout. It unpacks the information data block contained in the binary buffer into a structured frame of the HDMI Dynamic Range and Mastering (DRM) information frame. In contrast to

[Intel-gfx] [PATCH v11 11/14] drm/i915: Program DP SDPs on pipe updates

2020-05-07 Thread Gwan-gyeong Mun
Call intel_dp_set_infoframes() function on pipe updates to make sure that we send VSC SDP and HDR Metadata Infoframe SDP (when applicable) on fastsets. Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + 1 file changed, 1 insertion(+)

[Intel-gfx] [PATCH v11 02/14] drm/i915/dp: Read out DP SDPs

2020-05-07 Thread Gwan-gyeong Mun
It adds code to read the DP SDPs from the video DIP and unpack them into the crtc state. It adds routines that read out DP VSC SDP and DP HDR Metadata Infoframe SDP In order to unpack DP VSC SDP, it adds intel_dp_vsc_sdp_unpack() function. It follows DP 1.4a spec. [Table 2-116: VSC SDP Header

[Intel-gfx] [PATCH v11 09/14] drm/i915: Add state readout for DP VSC SDP

2020-05-07 Thread Gwan-gyeong Mun
Added state readout for DP VSC SDP and enabled state validation for DP VSC SDP. v2: Minor style fix v3: Replace a structure name to drm_dp_vsc_sdp from intel_dp_vsc_sdp v4: Use struct drm_device logging macros v10: Skip checking of VSC SDP when a crtc config has psr. Signed-off-by: Gwan-gyeong

[Intel-gfx] [PATCH v11 14/14] drm/i915/psr: Use new DP VSC SDP compute routine on PSR

2020-05-07 Thread Gwan-gyeong Mun
In order to use a common VSC SDP Colorimetry calculating code on PSR, it uses a new psr vsc sdp compute routine. Because PSR routine has its own scenario and timings of writing a VSC SDP, the current PSR routine needs to have its own drm_dp_vsc_sdp structure member variable on struct i915_psr. In

[Intel-gfx] [PATCH v11 00/14] In order to readout DP SDPs, refactors the handling of DP SDPs

2020-05-07 Thread Gwan-gyeong Mun
In order to readout DP SDPs (Secondary Data Packet: DP HDR Metadata Infoframe SDP, DP VSC SDP), it refactors handling DP SDPs codes. It adds new compute routines for DP HDR Metadata Infoframe SDP and DP VSC SDP. And new writing routines of DP SDPs (Secondary Data Packet) that uses computed

[Intel-gfx] [PATCH v11 04/14] drm/i915: Include HDMI DRM infoframe in the crtc state dump

2020-05-07 Thread Gwan-gyeong Mun
Dump out the HDMI Dynamic Range and Mastering (DRM) infoframe in the normal crtc state dump. Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Intel-gfx] [PATCH v11 03/14] drm: Add logging function for DP VSC SDP

2020-05-07 Thread Gwan-gyeong Mun
When receiving video it is very useful to be able to log DP VSC SDP. This greatly simplifies debugging. v2: Minor style fix v3: Move logging functions to drm core [Jani N] v5: Rebased v10: Rebased Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/drm_dp_helper.c |

[Intel-gfx] [PATCH v11 06/14] drm/i915: Include DP VSC SDP in the crtc state dump

2020-05-07 Thread Gwan-gyeong Mun
Dump out the DP VSC SDP in the normal crtc state dump v3: Replace a structure name to drm_dp_vsc_sdp from intel_dp_vsc_sdp Use drm core's DP VSC SDP logging function Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_display.c | 13 +

[Intel-gfx] [PATCH v11 08/14] drm/i915: Add state readout for DP HDR Metadata Infoframe SDP

2020-05-07 Thread Gwan-gyeong Mun
Added state readout for DP HDR Metadata Infoframe SDP. v9: Rebased v10: Rebased Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_ddi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c

[Intel-gfx] [PATCH v11 10/14] drm/i915: Fix enabled infoframe states of lspcon

2020-05-07 Thread Gwan-gyeong Mun
Compared to implementation of DP and HDMI's encoder->infoframes_enabled, the lspcon's implementation returns its active state. (we expect enabled infoframe states of HW.) It leads to pipe state mismatch error when ddi_get_config is called. Because the current implementation of lspcon is not ready

[Intel-gfx] [PATCH v11 07/14] drm/i915: Program DP SDPs with computed configs

2020-05-07 Thread Gwan-gyeong Mun
In order to use computed config for DP SDPs (DP VSC SDP and DP HDR Metadata Infoframe SDP), it replaces intel_dp_vsc_enable() function and intel_dp_hdr_metadata_enable() function to intel_dp_set_infoframes() function. And it removes unused functions. Before: intel_dp_vsc_enable() and

[Intel-gfx] [PATCH v11 05/14] drm/i915: Include DP HDR Metadata Infoframe SDP in the crtc state dump

2020-05-07 Thread Gwan-gyeong Mun
Dump out the DP HDR Metadata Infoframe SDP in the normal crtc state dump. HDMI Dynamic Range and Mastering (DRM) infoframe and DP HDR Metadata Infoframe SDP use the same member variable in infoframes of crtc state. Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar ---

[Intel-gfx] [PATCH v11 12/14] drm/i915: Stop sending DP SDPs on ddi disable

2020-05-07 Thread Gwan-gyeong Mun
Call intel_dp_set_infoframes(false) function on intel_ddi_post_disable_dp() to make sure not to send VSC SDP and HDR Metadata Infoframe SDP. v5: Polish commit message [Uma] Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++ 1 file

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915: Stash hpd status bits under dev_priv

2020-05-07 Thread Imre Deak
On Thu, May 07, 2020 at 02:48:08PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Instead of constnantly having to figure out which hpd status bit > array to use let's store them under dev_priv. > > Should perhaps take this further and stash even more stuff to > make the hpd handling

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915: Mark concurrent submissions with a weak-dependency (rev2)

2020-05-07 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Mark concurrent submissions with a weak-dependency (rev2) URL : https://patchwork.freedesktop.org/series/77024/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8441_full -> Patchwork_17598_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Hotplug cleanups (rev7)

2020-05-07 Thread Patchwork
== Series Details == Series: drm/i915: Hotplug cleanups (rev7) URL : https://patchwork.freedesktop.org/series/72348/ State : success == Summary == CI Bug Log - changes from CI_DRM_8442 -> Patchwork_17599 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v2 06/22] drm/i915/rkl: Update memory bandwidth parameters

2020-05-07 Thread Ville Syrjälä
On Mon, May 04, 2020 at 03:52:11PM -0700, Matt Roper wrote: > The RKL platform has different memory characteristics from past > platforms. Update the values used by our memory bandwidth calculations > accordingly. > > Bspec: 53998 > Cc: James Ausmus > Signed-off-by: Matt Roper > --- >

Re: [Intel-gfx] [PATCH v2 07/22] drm/i915/rkl: Limit number of universal planes to 5

2020-05-07 Thread Ville Syrjälä
On Mon, May 04, 2020 at 03:52:12PM -0700, Matt Roper wrote: > RKL only has five universal planes, plus a cursor. Since the > bottom-most universal plane is considered the primary plane, set the > number of sprites available on this platform to 4. > > In general, the plane capabilities of the

Re: [Intel-gfx] [PATCH v2 14/22] drm/i915/rkl: provide port/phy mapping for vbt

2020-05-07 Thread Ville Syrjälä
On Mon, May 04, 2020 at 03:52:19PM -0700, Matt Roper wrote: > From: Lucas De Marchi > > RKL uses the DDI A, DDI B, DDI USBC1, DDI USBC2 from the DE point of > view, so all DDI/pipe/transcoder register use these indexes to refer to > them. Combo phy and IO functions follow another namespace that

Re: [Intel-gfx] [PATCH v2 12/22] drm/i915/rkl: Check proper SDEISR bits for TC1 and TC2 outputs

2020-05-07 Thread Ville Syrjälä
On Mon, May 04, 2020 at 03:52:17PM -0700, Matt Roper wrote: > When Rocket Lake is paired with a TGP PCH, the last two outputs utilize > the TC1 and TC2 hpd pins, even though these are combo outputs. > > Bspec: 49181 > Cc: Lucas De Marchi > Signed-off-by: Matt Roper > --- >

Re: [Intel-gfx] [PATCH v2 17/22] drm/i915/rkl: Don't try to read out DSI transcoders

2020-05-07 Thread Ville Syrjälä
On Mon, May 04, 2020 at 03:52:22PM -0700, Matt Roper wrote: > From: Aditya Swarup > > RKL doesn't have DSI outputs, so we shouldn't try to read out the DSI > transcoder registers. > > Signed-off-by: Aditya Swarup > Signed-off-by: Matt Roper > --- >

[Intel-gfx] [PATCH v4 2/3] drm/i915: Stash hpd status bits under dev_priv

2020-05-07 Thread Ville Syrjala
From: Ville Syrjälä Instead of constnantly having to figure out which hpd status bit array to use let's store them under dev_priv. Should perhaps take this further and stash even more stuff to make the hpd handling more abstract yet. v2: Remeber cnp (Imre) Add MISSING_CASE() for unknown

Re: [Intel-gfx] [PATCH v2 12/22] drm/i915/rkl: Check proper SDEISR bits for TC1 and TC2 outputs

2020-05-07 Thread Srivatsa, Anusha
> -Original Message- > From: Intel-gfx On Behalf Of Matt > Roper > Sent: Tuesday, May 5, 2020 4:22 AM > To: intel-gfx@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: [Intel-gfx] [PATCH v2 12/22] drm/i915/rkl: Check proper SDEISR bits > for > TC1 and TC2 outputs > > When

Re: [Intel-gfx] [PATCH v2 10/22] drm/i915/rkl: RKL only uses PHY_MISC for PHY's A and B

2020-05-07 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Wednesday, May 6, 2020 10:20 PM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v2 10/22] drm/i915/rkl: RKL only uses PHY_MISC > for PHY's A and B > > On Wed, May 06, 2020 at

Re: [Intel-gfx] [PATCH v2 01/22] drm/i915/rkl: Add RKL platform info and PCI ids

2020-05-07 Thread Srivatsa, Anusha
> -Original Message- > From: Intel-gfx On Behalf Of Matt > Roper > Sent: Tuesday, May 5, 2020 4:22 AM > To: intel-gfx@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: [Intel-gfx] [PATCH v2 01/22] drm/i915/rkl: Add RKL platform info and > PCI ids > > Introduce the basic

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915: Mark concurrent submissions with a weak-dependency (rev2)

2020-05-07 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Mark concurrent submissions with a weak-dependency (rev2) URL : https://patchwork.freedesktop.org/series/77007/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8441_full -> Patchwork_17597_full

[Intel-gfx] [drm-tip:drm-tip 3/9] drivers/gpu/drm/i915/gt/intel_engine_cs.c:1428:31: error: 'struct intel_context' has no member named 'lrc_desc'

2020-05-07 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: 6c0ee41a7c3201ef2a89800234803a95f65989be commit: e81df648fc5bcd0fa702df401e02b7914c76ff71 [3/9] Merge remote-tracking branch 'drm/drm-next' into drm-tip config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Ubuntu

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Mark concurrent submissions with a weak-dependency (rev2)

2020-05-07 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Mark concurrent submissions with a weak-dependency (rev2) URL : https://patchwork.freedesktop.org/series/77024/ State : success == Summary == CI Bug Log - changes from CI_DRM_8441 -> Patchwork_17598

Re: [Intel-gfx] [bug report] drm/i915: Use the async worker to avoid reclaim tainting the ggtt->mutex

2020-05-07 Thread Chris Wilson
Quoting Dan Carpenter (2020-05-07 10:17:14) > Hello Chris Wilson, > > The patch e3793468b466: "drm/i915: Use the async worker to avoid > reclaim tainting the ggtt->mutex" from Jan 30, 2020, leads to the > following static checker warning: > > drivers/gpu/drm/i915/i915_vma.c:356

[Intel-gfx] [bug report] drm/i915: Use the async worker to avoid reclaim tainting the ggtt->mutex

2020-05-07 Thread Dan Carpenter
Hello Chris Wilson, The patch e3793468b466: "drm/i915: Use the async worker to avoid reclaim tainting the ggtt->mutex" from Jan 30, 2020, leads to the following static checker warning: drivers/gpu/drm/i915/i915_vma.c:356 i915_vma_wait_for_bind() warn: 's64max' cannot fit into

Re: [Intel-gfx] [PATCH] drm/i915/display: Warn if the FBC is still writing to stolen on removal

2020-05-07 Thread Chris Wilson
Quoting Jani Nikula (2020-05-07 09:49:15) > On Sun, 03 May 2020, Chris Wilson wrote: > > If the FBC is still writing into stolen, it will overwrite any future > > users of that stolen region. Check before release. > > > > References: https://gitlab.freedesktop.org/drm/intel/-/issues/1635 > >

Re: [Intel-gfx] [PATCH] drm/i915/display: Warn if the FBC is still writing to stolen on removal

2020-05-07 Thread Jani Nikula
On Sun, 03 May 2020, Chris Wilson wrote: > If the FBC is still writing into stolen, it will overwrite any future > users of that stolen region. Check before release. > > References: https://gitlab.freedesktop.org/drm/intel/-/issues/1635 > Signed-off-by: Chris Wilson > --- >

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915: Stash hpd status bits under dev_priv

2020-05-07 Thread Imre Deak
On Thu, May 07, 2020 at 09:53:13AM +0300, Ville Syrjälä wrote: > On Wed, May 06, 2020 at 07:03:41PM +0300, Imre Deak wrote: > > On Wed, Mar 11, 2020 at 05:54:21PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Instead of constnantly having to figure out which hpd status bit >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Mark concurrent submissions with a weak-dependency (rev2)

2020-05-07 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Mark concurrent submissions with a weak-dependency (rev2) URL : https://patchwork.freedesktop.org/series/77007/ State : success == Summary == CI Bug Log - changes from CI_DRM_8441 -> Patchwork_17597

[Intel-gfx] [PATCH] drm/i915: Treat weak-dependencies as bidirectional when applying priorities

2020-05-07 Thread Chris Wilson
Clients may use a submit-fence as bidirectional bond between two or more co-operating requests, and so if we bump the priority of one, we wish to bump the priority of the set. Testcase: igt/gem_exec_fence/submitN Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin ---

  1   2   >