[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mst: filter out the display mode exceed sink's capability (rev3)

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915/mst: filter out the display mode exceed sink's capability (rev3) URL : https://patchwork.freedesktop.org/series/76095/ State : success == Summary == CI Bug Log - changes from CI_DRM_8498_full -> Patchwork_17706_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ehl: Extend w/a 14010685332 to JSP/MCC

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Extend w/a 14010685332 to JSP/MCC URL : https://patchwork.freedesktop.org/series/77382/ State : success == Summary == CI Bug Log - changes from CI_DRM_8498_full -> Patchwork_17705_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mst: filter out the display mode exceed sink's capability (rev3)

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915/mst: filter out the display mode exceed sink's capability (rev3) URL : https://patchwork.freedesktop.org/series/76095/ State : success == Summary == CI Bug Log - changes from CI_DRM_8498 -> Patchwork_17706

[Intel-gfx] [PATCH v3] drm/i915/mst: filter out the display mode exceed sink's capability

2020-05-18 Thread Lee Shawn C
So far, max dot clock rate for MST mode rely on physcial bandwidth limitation. It would caused compatibility issue if source display resolution exceed MST hub output ability. For example, source DUT had DP 1.2 output capability. And MST docking just support HDMI 1.4 spec. When a HDMI 2.0 monitor

[Intel-gfx] ✗ Fi.CI.IGT: failure for mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-18 Thread Patchwork
== Series Details == Series: mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages() URL : https://patchwork.freedesktop.org/series/77381/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8498_full -> Patchwork_17704_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: move trace_i915_reg_rw() to a separate file

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: move trace_i915_reg_rw() to a separate file URL : https://patchwork.freedesktop.org/series/77378/ State : success == Summary == CI Bug Log - changes from CI_DRM_8498_full -> Patchwork_17703_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ehl: Extend w/a 14010685332 to JSP/MCC

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Extend w/a 14010685332 to JSP/MCC URL : https://patchwork.freedesktop.org/series/77382/ State : success == Summary == CI Bug Log - changes from CI_DRM_8498 -> Patchwork_17705 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: Don't set queue-priority hint when supressing the reschedule

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Don't set queue-priority hint when supressing the reschedule URL : https://patchwork.freedesktop.org/series/77377/ State : success == Summary == CI Bug Log - changes from CI_DRM_8498_full -> Patchwork_17702_full

[Intel-gfx] ✓ Fi.CI.BAT: success for mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-18 Thread Patchwork
== Series Details == Series: mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages() URL : https://patchwork.freedesktop.org/series/77381/ State : success == Summary == CI Bug Log - changes from CI_DRM_8498 -> Patchwork_17704

[Intel-gfx] [PATCH] drm/i915/ehl: Extend w/a 14010685332 to JSP/MCC

2020-05-18 Thread Swathi Dhanavanthri
This is a permanent w/a for JSL/EHL.This is to be applied to the PCH types on JSL/EHL ie JSP/MCC Bspec: 52888 Signed-off-by: Swathi Dhanavanthri --- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Resolve device hotunplug issues

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915: Resolve device hotunplug issues URL : https://patchwork.freedesktop.org/series/77372/ State : success == Summary == CI Bug Log - changes from CI_DRM_8498_full -> Patchwork_17701_full Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-18 Thread Patchwork
== Series Details == Series: mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages() URL : https://patchwork.freedesktop.org/series/77381/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-18 Thread Patchwork
== Series Details == Series: mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages() URL : https://patchwork.freedesktop.org/series/77381/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5dd288837ad8 mm/gup: move __get_user_pages_fast() down a few lines in gup.c -:111:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: move trace_i915_reg_rw() to a separate file

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: move trace_i915_reg_rw() to a separate file URL : https://patchwork.freedesktop.org/series/77378/ State : success == Summary == CI Bug Log - changes from CI_DRM_8498 -> Patchwork_17703

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: move trace_i915_reg_rw() to a separate file

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: move trace_i915_reg_rw() to a separate file URL : https://patchwork.freedesktop.org/series/77378/ State : warning == Summary == $ dim checkpatch origin/drm-tip caee6db994c4 drm/i915: move trace_i915_reg_rw() to a separate file

[Intel-gfx] [PATCH 2/4] mm/gup: refactor and de-duplicate gup_fast() code

2020-05-18 Thread John Hubbard
There were two nearly identical sets of code for gup_fast() style of walking the page tables with interrupts disabled. This has lead to the usual maintenance problems that arise from having duplicated code. There is already a core internal routine in gup.c for gup_fast(), so just enhance it very

[Intel-gfx] [PATCH 3/4] mm/gup: introduce pin_user_pages_fast_only()

2020-05-18 Thread John Hubbard
This is the FOLL_PIN equivalent of __get_user_pages_fast(), except with a more descriptive name, and gup_flags instead of a boolean "write" in the argument list. Signed-off-by: John Hubbard --- include/linux/mm.h | 2 ++ mm/gup.c | 36 2 files

[Intel-gfx] [PATCH 4/4] drm/i915: convert get_user_pages() --> pin_user_pages()

2020-05-18 Thread John Hubbard
This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. There is some helpful background in [2]: basically, this is a

[Intel-gfx] [PATCH 1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c

2020-05-18 Thread John Hubbard
This is in order to avoid a forward declaration of internal_get_user_pages_fast(), in the next patch. This is code movement only--all generated code should be identical. Signed-off-by: John Hubbard --- mm/gup.c | 112 +++ 1 file changed, 56

[Intel-gfx] [PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-18 Thread John Hubbard
This needs to go through Andrew's -mm tree, due to adding a new gup.c routine. However, I would really love to have some testing from the drm/i915 folks, because I haven't been able to run-time test that part of it. Otherwise, though, the series has passed my basic run time testing: some LTP

Re: [Intel-gfx] [PATCH 2/2] drm/i915: trace intel_uncore_*_fw()

2020-05-18 Thread Lucas De Marchi
On Tue, May 19, 2020 at 12:35:02AM +0100, Chris Wilson wrote: Quoting Lucas De Marchi (2020-05-19 00:30:49) Now that we have the declaration of trace_i915_reg_rw() in a separate header, start tracing intel_uncore_*_fw() mmio-accessors. These were untraced on purpose. humn... can you share

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Don't set queue-priority hint when supressing the reschedule

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Don't set queue-priority hint when supressing the reschedule URL : https://patchwork.freedesktop.org/series/77377/ State : success == Summary == CI Bug Log - changes from CI_DRM_8498 -> Patchwork_17702

Re: [Intel-gfx] [PATCH 2/2] drm/i915: trace intel_uncore_*_fw()

2020-05-18 Thread Chris Wilson
Quoting Lucas De Marchi (2020-05-19 00:30:49) > Now that we have the declaration of trace_i915_reg_rw() in a separate > header, start tracing intel_uncore_*_fw() mmio-accessors. These were untraced on purpose. -Chris ___ Intel-gfx mailing list

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: Don't set queue-priority hint when supressing the reschedule

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Don't set queue-priority hint when supressing the reschedule URL : https://patchwork.freedesktop.org/series/77377/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Don't set queue-priority hint when supressing the reschedule

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Don't set queue-priority hint when supressing the reschedule URL : https://patchwork.freedesktop.org/series/77377/ State : warning == Summary == $ dim checkpatch origin/drm-tip c3388b20997e drm/i915: Don't set queue-priority

[Intel-gfx] [PATCH i-g-t 2/2] lib: Cleanup __igt_params_open()

2020-05-18 Thread Chris Wilson
The device always exist, so use it to derive the module name required to lookup either the debugfs params directory or the sysfs module parameters. Fixes: 2f5cee33ce55 ("igt/params: use igt_params_set_save for igt_set_module_param*") Signed-off-by: Chris Wilson Cc: Jani Nikula Cc: Juha-Pekka

[Intel-gfx] [PATCH i-g-t 1/2] Always pass device to igt_params_set

2020-05-18 Thread Chris Wilson
Don't second guess, require the user to provide the device that wish to set the module parameter for. Signed-off-by: Chris Wilson --- lib/igt_params.c | 8 lib/igt_params.h | 4 ++-- lib/igt_psr.c | 18 -

[Intel-gfx] [PATCH 2/2] drm/i915: trace intel_uncore_*_fw()

2020-05-18 Thread Lucas De Marchi
Now that we have the declaration of trace_i915_reg_rw() in a separate header, start tracing intel_uncore_*_fw() mmio-accessors. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_uncore.h | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH 1/2] drm/i915: move trace_i915_reg_rw() to a separate file

2020-05-18 Thread Lucas De Marchi
Currently we can't call trace_i915_reg_rw() from some headers due to include order and i915_trace.h needing some struct definitions. Move the declaration of trace_i915_reg_rw() to another file so it can be included separately. Note that the trace points are still defined by i915_trace_point.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Resolve device hotunplug issues

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915: Resolve device hotunplug issues URL : https://patchwork.freedesktop.org/series/77372/ State : success == Summary == CI Bug Log - changes from CI_DRM_8498 -> Patchwork_17701 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gvt: Use ARRAY_SIZE for vgpu_types

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Use ARRAY_SIZE for vgpu_types URL : https://patchwork.freedesktop.org/series/77369/ State : success == Summary == CI Bug Log - changes from CI_DRM_8498_full -> Patchwork_17699_full Summary ---

[Intel-gfx] [PATCH 1/4] drm/i915: Don't set queue-priority hint when supressing the reschedule

2020-05-18 Thread Chris Wilson
We recorded the execlists->queue_priority_hint update for the inflight request without kicking the tasklet. The next submitted request then failed to be scheduled as it had a lower priority than the hint, leaving the HW runnning with only the inflight request. Fixes: 6cebcf746f3f ("drm/i915:

[Intel-gfx] [PATCH 2/4] drm/i915/selftests: Change priority overflow detection

2020-05-18 Thread Chris Wilson
Check for integer overflow in the priority chain, rather than against a type-constricted max-priority check. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c

[Intel-gfx] [PATCH 4/4] drm/i915/selftests: Check for an initial-breadcrumb in wait_for_submit()

2020-05-18 Thread Chris Wilson
When we look at i915_request_is_started() we must be careful in case we are using a request that does not have the initial-breadcrumb and instead the is-started is being compared against the end of the previous request. This will make wait_for_submit() declare that a request has been already

[Intel-gfx] [PATCH 3/4] drm/i915/selftests: Restore to default heartbeat

2020-05-18 Thread Chris Wilson
Since we temporarily disable the heartbeat and restore back to the default value, we can use the stored defaults on the engine and avoid using a local. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 25 +++ drivers/gpu/drm/i915/gt/selftest_lrc.c | 67

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Resolve device hotunplug issues

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915: Resolve device hotunplug issues URL : https://patchwork.freedesktop.org/series/77372/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Resolve device hotunplug issues

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915: Resolve device hotunplug issues URL : https://patchwork.freedesktop.org/series/77372/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4d3df739b858 drm/i915: Drop user contexts on driver remove -:19: WARNING:COMMIT_LOG_LONG_LINE: Possible

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Check for an initial-breadcrumb in wait_for_submit()

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Check for an initial-breadcrumb in wait_for_submit() URL : https://patchwork.freedesktop.org/series/77371/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8498 -> Patchwork_17700

[Intel-gfx] [PATCH i-g-t] lib: Cleanup __igt_params_open()

2020-05-18 Thread Chris Wilson
The device always exist, so use it to derive the module name required to lookup either the debugfs params directory or the sysfs module parameters. Fixes: 2f5cee33ce55 ("igt/params: use igt_params_set_save for igt_set_module_param*") Signed-off-by: Chris Wilson Cc: Jani Nikula Cc: Juha-Pekka

[Intel-gfx] [PATCH i-g-t] perf: Hide any leak in gen8-unprivileged-single-ctx-counters

2020-05-18 Thread Chris Wilson
gen8-unprivileged-single-counters appears to leak contexts, and does not appear to be doing so intentionally.. Let's assume it's a bug in the test and see if the contexts are released along with the device fd. (If they are not released, that is more clearly an issue.) Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH i-g-t] lib/i915: Reset all engine properties to defaults prior to the start of a test

2020-05-18 Thread Chris Wilson
We need each test in an isolated context, so that bad results from one test do not interfere with the next. In particular, we want to clean up the device and reset it to the defaults so that they are known for the next test, and the test can focus on behaviour it wants to control. Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Use ARRAY_SIZE for vgpu_types

2020-05-18 Thread Chris Wilson
Quoting Aishwarya Ramakrishnan (2020-05-18 16:03:36) > Prefer ARRAY_SIZE instead of using sizeof > > Fixes coccicheck warning: Use ARRAY_SIZE > > Signed-off-by: Aishwarya Ramakrishnan Reviewed-by: Chris Wilson -Chris ___ Intel-gfx mailing list

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: Use ARRAY_SIZE for vgpu_types

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Use ARRAY_SIZE for vgpu_types URL : https://patchwork.freedesktop.org/series/77369/ State : success == Summary == CI Bug Log - changes from CI_DRM_8498 -> Patchwork_17699 Summary ---

[Intel-gfx] [PATCH i-g-t] lib: Cleanup __igt_params_open()

2020-05-18 Thread Chris Wilson
The device always exist, so use it to derive the module name required to lookup either the debugfs params directory or the sysfs module parameters. Fixes: 2f5cee33ce55 ("igt/params: use igt_params_set_save for igt_set_module_param*") Signed-off-by: Chris Wilson Cc: Jani Nikula Cc: Juha-Pekka

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix incorrect return of an error status

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915: fix incorrect return of an error status URL : https://patchwork.freedesktop.org/series/77368/ State : failure == Summary == Applying: drm/i915: fix incorrect return of an error status Using index info to reconstruct a base tree... M

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/params: don't expose inject_probe_failure in debugfs

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/params: don't expose inject_probe_failure in debugfs URL : https://patchwork.freedesktop.org/series/77366/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8497 -> Patchwork_17697

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Measure dispatch latency (rev8)

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Measure dispatch latency (rev8) URL : https://patchwork.freedesktop.org/series/77308/ State : success == Summary == CI Bug Log - changes from CI_DRM_8495_full -> Patchwork_17695_full Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/params: don't expose inject_probe_failure in debugfs

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/params: don't expose inject_probe_failure in debugfs URL : https://patchwork.freedesktop.org/series/77366/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/7] drm/i915: Move saturated workload detection back to the context

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Move saturated workload detection back to the context URL : https://patchwork.freedesktop.org/series/77365/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8497 -> Patchwork_17696

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/params: don't expose inject_probe_failure in debugfs

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/params: don't expose inject_probe_failure in debugfs URL : https://patchwork.freedesktop.org/series/77366/ State : warning == Summary == $ dim checkpatch origin/drm-tip 960f6e1f205d drm/i915/params: don't expose

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/7] drm/i915: Move saturated workload detection back to the context

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Move saturated workload detection back to the context URL : https://patchwork.freedesktop.org/series/77365/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Move saturated workload detection back to the context

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Move saturated workload detection back to the context URL : https://patchwork.freedesktop.org/series/77365/ State : warning == Summary == $ dim checkpatch origin/drm-tip a7577cd7f63b drm/i915: Move saturated workload detection

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Reverse preemph vs. voltage swing preference

2020-05-18 Thread Manasi Navare
On Fri, May 15, 2020 at 10:59:57PM +0300, Ville Syrjälä wrote: > On Fri, May 15, 2020 at 12:18:22PM -0700, Manasi Navare wrote: > > On Tue, May 12, 2020 at 08:41:43PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > The DP spec says: > > > "When the combination of the requested

[Intel-gfx] [RFC PATCH 0/4] drm/i915: Resolve device hotunplug issues

2020-05-18 Thread Janusz Krzysztofik
The idea is to revoke DMA mappings on driver remove in order to work around intel-iommu judging late unmapping on driver release after an open device is removed as bugs. That also resolves runtime power management warnings on late object removal. Janusz Krzysztofik (4): drm/i915: Drop user

[Intel-gfx] [RFC PATCH 3/4] drm/i915: Move GGTT cleanup from driver_release to _remove

2020-05-18 Thread Janusz Krzysztofik
GGTT including its scratch page is not cleaned up until driver release. Since DMA mappings still exist before scratch page cleanup, unmapping them on last device close after the driver has been already removed may be judged by intel-iommu code as a bug and result in kernel panic. Since we abort

[Intel-gfx] [RFC PATCH 1/4] drm/i915: Drop user contexts on driver remove

2020-05-18 Thread Janusz Krzysztofik
Contexts associated with open device file descriptors together with their assigned address spaces are now closed on device file close. On address space closure its associated DMA mappings are revoked. If the device is removed while being open, subsequent attempts to revoke those mappings while

[Intel-gfx] [RFC PATCH 4/4] drm/i915: Move UC firmware cleanup from driver_release to _remove

2020-05-18 Thread Janusz Krzysztofik
UC firmware is stored in a GEM object. Clean it up on driver remove to avoid intel-iommu triggered kernel panic on late DMA unmapping or even an RPM related warning on object late removal in no IOMMU setups. <4> [93.335282] [ cut here ] <4> [93.335515]

[Intel-gfx] [RFC PATCH 2/4] drm/i915: Release GT resources on driver remove

2020-05-18 Thread Janusz Krzysztofik
GT scratch page is now released and its DMA mappings revoked on driver release. If a device is removed while its file descriptor is still open, the driver is not released until last device file descriptor closure. In that case intel-iommu code may judge late DMA unmapping as a bug and kernel

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Measure dispatch latency (rev8)

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Measure dispatch latency (rev8) URL : https://patchwork.freedesktop.org/series/77308/ State : success == Summary == CI Bug Log - changes from CI_DRM_8495 -> Patchwork_17695 Summary ---

[Intel-gfx] [PATCH] drm/i915/selftests: Check for an initial-breadcrumb in wait_for_submit()

2020-05-18 Thread Chris Wilson
When we look at i915_request_is_started() we must be careful in case we are using a request that does not have the initial-breadcrumb and instead the is-started is being compared against the end of the previous request. This will make wait_for_submit() declare that a request has been already

[Intel-gfx] [PATCH] drm/i915/gvt: Use ARRAY_SIZE for vgpu_types

2020-05-18 Thread Aishwarya Ramakrishnan
Prefer ARRAY_SIZE instead of using sizeof Fixes coccicheck warning: Use ARRAY_SIZE Signed-off-by: Aishwarya Ramakrishnan --- drivers/gpu/drm/i915/gvt/vgpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix dbuf slice mask when turning off all the pipes

2020-05-18 Thread Ville Syrjälä
On Mon, May 18, 2020 at 02:14:15PM +0100, Chris Wilson wrote: > Quoting Ville Syrjala (2020-05-18 13:13:54) > > From: Ville Syrjälä > > > > The current dbuf slice computation only happens when there are > > active pipes. If we are turning off all the pipes we just leave > > the dbuf slice mask

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix dbuf slice mask when turning off all the pipes (rev2)

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915: Fix dbuf slice mask when turning off all the pipes (rev2) URL : https://patchwork.freedesktop.org/series/77322/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8494_full -> Patchwork_17690_full

[Intel-gfx] [PATCH][next] drm/i915: fix incorrect return of an error status

2020-05-18 Thread Colin King
From: Colin Ian King Currently when a call to intel_atomic_get_dbuf_state fails the error value being returns is a potentially uninitialized value in variable ret. Fix this by returning the error value of new_dbuf_state. Addresses-Coverity: ("Uninitialized scalar value") Fixes: 3cf43cdc63fb

[Intel-gfx] [PATCH 2/3] drm/i915/params: fix i915.fake_lmem_start module param sysfs permissions

2020-05-18 Thread Jani Nikula
fake_lmem_start does not need to be mutable via module param sysfs. It's only used during driver probe. Fixes: 1629224324b6 ("drm/i915/lmem: add the fake lmem region") Cc: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Reviewed-by: Rodrigo Vivi Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH 3/3] drm/i915/params: prevent changing module params runtime

2020-05-18 Thread Jani Nikula
Only support runtime changes through the debugfs. i915.verbose_state_checks remains an exception, and is not exposed via debugfs. This depends on IGT having been updated to use the debugfs for modifying the parameters. Cc: Juha-Pekka Heikkilä Cc: Venkata Sandeep Dhanalakota Reviewed-by:

[Intel-gfx] [PATCH 1/3] drm/i915/params: don't expose inject_probe_failure in debugfs

2020-05-18 Thread Jani Nikula
The parameter only makes sense as a module parameter only. Fixes: c43c5a8818d4 ("drm/i915/params: add i915 parameters to debugfs") Cc: Juha-Pekka Heikkilä Cc: Venkata Sandeep Dhanalakota Reviewed-by: Juha-Pekka Heikkila Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_params.h | 2 +-

[Intel-gfx] drm/i915: device params part 1

2020-05-18 Thread Jani Nikula
This is the first 3 patches of [1], because apparently patch 4 breaks the world. I've yet to pinpoint the issue, but these could move forward in the meanwhile. BR, Jani. [1] https://patchwork.freedesktop.org/series/77272/ ___ Intel-gfx mailing list

[Intel-gfx] [PATCH 3/7] drm/i915/gt: Kick virtual siblings on timeslice out

2020-05-18 Thread Chris Wilson
If we decide to timeslice out the current virtual request, we will unsubmit it while it is still busy (ve->context.inflight == sibling[0]). If the virtual tasklet and then the other sibling tasklets run before we completely schedule out the active virtual request for the preemption, those other

[Intel-gfx] [PATCH 4/7] drm/i915/gt: Incorporate the virtual engine into timeslicing

2020-05-18 Thread Chris Wilson
It was quite the oversight to only factor in the normal queue to decide the timeslicing switch priority. By leaving out the next virtual request from the priority decision, we would not timeslice the current engine if there was an available virtual request. Testcase: igt/gem_exec_balancer/sliced

[Intel-gfx] [PATCH 7/7] drm/i915/gt: Resubmit the virtual engine on schedule-out

2020-05-18 Thread Chris Wilson
Having recognised that we do not change the sibling until we schedule out, we can then defer the decision to resubmit the virtual engine from the unwind of the active queue to scheduling out of the virtual context. By keeping the unwind order intact on the local engine, we can preserve data

[Intel-gfx] [PATCH 5/7] drm/i915/gt: Use virtual_engine during execlists_dequeue

2020-05-18 Thread Chris Wilson
Rather than going back and forth between the rb_node entry and the virtual_engine type, store the ve local and reuse it. As the container_of conversion from rb_node to virtual_engine requires a variable offset, performing that conversion just once shaves off a bit of code. v2: Keep a single

[Intel-gfx] [PATCH 2/7] drm/i915/selftests: Add tests for timeslicing virtual engines

2020-05-18 Thread Chris Wilson
Make sure that we can execute a virtual request on an already busy engine, and conversely that we can execute a normal request if the engines are already fully occupied by virtual requests. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 188 - 1

[Intel-gfx] [PATCH 1/7] drm/i915: Move saturated workload detection back to the context

2020-05-18 Thread Chris Wilson
When we introduced the saturated workload detection to tell us to back off from semaphore usage [semaphores have a noticeable impact on contended bus cycles with the CPU for some heavy workloads], we first introduced it as a per-context tracker. This allows individual contexts to try and optimise

[Intel-gfx] [PATCH 6/7] drm/i915/gt: Decouple inflight virtual engines

2020-05-18 Thread Chris Wilson
Once a virtual engine has been bound to a sibling, it will remain bound until we finally schedule out the last active request. We can not rebind the context to a new sibling while it is inflight as the context save will conflict, hence we wait. As we cannot then use any other sibliing while the

Re: [Intel-gfx] [PATCH v6 00/16] drm/i915: Add support for HDCP 1.4 over MST connectors

2020-05-18 Thread Ramalingam C
On 2020-05-18 at 10:32:09 -0400, Sean Paul wrote: > On Fri, May 15, 2020 at 10:48 AM Ramalingam C wrote: > > > > On 2020-04-29 at 15:54:46 -0400, Sean Paul wrote: > > > From: Sean Paul > > > > > > Changes in v6: > > > -Rebased on -tip > > > -Disabled HDCP over MST on GEN12 > > > -Addressed

[Intel-gfx] ✓ Fi.CI.IGT: success for HDCP minor refactoring (rev2)

2020-05-18 Thread Patchwork
== Series Details == Series: HDCP minor refactoring (rev2) URL : https://patchwork.freedesktop.org/series/77224/ State : success == Summary == CI Bug Log - changes from CI_DRM_8494_full -> Patchwork_17688_full Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/8] drm/i915: Move saturated workload detection back to the context (rev2)

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/i915: Move saturated workload detection back to the context (rev2) URL : https://patchwork.freedesktop.org/series/77344/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8494 -> Patchwork_17693

[Intel-gfx] [PATCH] drm/i915/selftests: Measure dispatch latency

2020-05-18 Thread Chris Wilson
A useful metric of the system's health is how fast we can tell the GPU to do various actions, so measure our latency. v2: Refactor all the instruction building into emitters. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/selftests/i915_request.c |

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/selftests: Measure dispatch latency (rev7)

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Measure dispatch latency (rev7) URL : https://patchwork.freedesktop.org/series/77308/ State : failure == Summary == Applying: drm/i915/selftests: Measure dispatch latency error: corrupt patch at line 23 error: could not build fake ancestor

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/8] drm/i915: Move saturated workload detection back to the context (rev2)

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/i915: Move saturated workload detection back to the context (rev2) URL : https://patchwork.freedesktop.org/series/77344/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/i915: Move saturated workload detection back to the context (rev2)

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/i915: Move saturated workload detection back to the context (rev2) URL : https://patchwork.freedesktop.org/series/77344/ State : warning == Summary == $ dim checkpatch origin/drm-tip ebeb414a1e8b drm/i915: Move saturated workload

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsb: Pre allocate and late cleanup of cmd buffer (rev9)

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915/dsb: Pre allocate and late cleanup of cmd buffer (rev9) URL : https://patchwork.freedesktop.org/series/73036/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8494 -> Patchwork_17692

Re: [Intel-gfx] [PATCH 7/8] drm/i915/gt: Decouple inflight virtual engines

2020-05-18 Thread Chris Wilson
Quoting Chris Wilson (2020-05-18 16:40:15) > Quoting Tvrtko Ursulin (2020-05-18 15:55:46) > > > > On 18/05/2020 14:00, Chris Wilson wrote: > > > Quoting Tvrtko Ursulin (2020-05-18 13:53:29) > > >> > > >> On 18/05/2020 09:14, Chris Wilson wrote: > > >>> Once a virtual engine has been bound to a

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Refactor sibling selection

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Refactor sibling selection URL : https://patchwork.freedesktop.org/series/77352/ State : success == Summary == CI Bug Log - changes from CI_DRM_8494_full -> Patchwork_17687_full Summary

Re: [Intel-gfx] [PATCH 7/8] drm/i915/gt: Decouple inflight virtual engines

2020-05-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-05-18 15:55:46) > > On 18/05/2020 14:00, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-05-18 13:53:29) > >> > >> On 18/05/2020 09:14, Chris Wilson wrote: > >>> Once a virtual engine has been bound to a sibling, it will remain bound > >>> until we finally

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] Revert "drm/i915: Clean up dbuf debugs during .atomic_check()"

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/4] Revert "drm/i915: Clean up dbuf debugs during .atomic_check()" URL : https://patchwork.freedesktop.org/series/77358/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8494 -> Patchwork_17691

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Measure dispatch latency

2020-05-18 Thread Chris Wilson
Quoting Chris Wilson (2020-05-18 16:14:43) > Quoting Mika Kuoppala (2020-05-18 16:07:47) > > Chris Wilson writes: > > > + cs = emit_timestamp_store(cs, ce, offset + i * sizeof(u32)); > > > > Is the dual writes here so that when you kick the semaphore, you get the > > latest no matter

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Measure dispatch latency

2020-05-18 Thread Chris Wilson
Quoting Mika Kuoppala (2020-05-18 16:07:47) > Chris Wilson writes: > > + cs = emit_timestamp_store(cs, ce, offset + i * sizeof(u32)); > > Is the dual writes here so that when you kick the semaphore, you get the > latest no matter which side you were on? We wait on the first write in

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Measure dispatch latency (rev5)

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Measure dispatch latency (rev5) URL : https://patchwork.freedesktop.org/series/77308/ State : success == Summary == CI Bug Log - changes from CI_DRM_8494_full -> Patchwork_17686_full Summary

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Measure dispatch latency

2020-05-18 Thread Mika Kuoppala
Chris Wilson writes: > A useful metric of the system's health is how fast we can tell the GPU > to do various actions, so measure our latency. > > v2: Refactor all the instruction building into emitters. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Joonas Lahtinen > --- >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] Revert "drm/i915: Clean up dbuf debugs during .atomic_check()"

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/4] Revert "drm/i915: Clean up dbuf debugs during .atomic_check()" URL : https://patchwork.freedesktop.org/series/77358/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4de007ca5a0f Revert "drm/i915: Clean up dbuf debugs

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix dbuf slice mask when turning off all the pipes (rev2)

2020-05-18 Thread Patchwork
== Series Details == Series: drm/i915: Fix dbuf slice mask when turning off all the pipes (rev2) URL : https://patchwork.freedesktop.org/series/77322/ State : success == Summary == CI Bug Log - changes from CI_DRM_8494 -> Patchwork_17690

Re: [Intel-gfx] [PATCH 7/8] drm/i915/gt: Decouple inflight virtual engines

2020-05-18 Thread Tvrtko Ursulin
On 18/05/2020 14:00, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-05-18 13:53:29) On 18/05/2020 09:14, Chris Wilson wrote: Once a virtual engine has been bound to a sibling, it will remain bound until we finally schedule out the last active request. We can not rebind the context to a

Re: [Intel-gfx] [PATCH 3/4] Revert "drm/i915: Nuke skl_ddb_get_hw_state()"

2020-05-18 Thread Lisovskiy, Stanislav
On Mon, May 18, 2020 at 03:23:02PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Dbuf slice tracking busted across runtime PM. Back to the > drawing board. > > This reverts commit 0cde0e0ff5f5ebd27507069250728c763c14ac81. > > Signed-off-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH 2/4] Revert "drm/i915: Move the dbuf pre/post plane update"

2020-05-18 Thread Lisovskiy, Stanislav
On Mon, May 18, 2020 at 03:23:01PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Dbuf slice tracking busted across runtime PM. Back to the > drawing board. > > This reverts commit c7c0e7ebe4d9963573f81399374e4e95f37fd8e3. > > Signed-off-by: Ville Syrjälä > --- >

[Intel-gfx] [PATCH v2] drm/i915/selftests: Measure dispatch latency

2020-05-18 Thread Chris Wilson
A useful metric of the system's health is how fast we can tell the GPU to do various actions, so measure our latency. v2: Refactor all the instruction building into emitters. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/selftests/i915_request.c |

Re: [Intel-gfx] [PATCH 4/4] Revert "drm/i915: Introduce proper dbuf state"

2020-05-18 Thread Lisovskiy, Stanislav
On Mon, May 18, 2020 at 03:23:03PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Dbuf slice tracking busted across runtime PM. Back to the > drawing board. > > This reverts commit 3cf43cdc63fbc3df19ea8398e9b8717ab44a6304. > > Signed-off-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH v6 00/16] drm/i915: Add support for HDCP 1.4 over MST connectors

2020-05-18 Thread Sean Paul
On Fri, May 15, 2020 at 10:48 AM Ramalingam C wrote: > > On 2020-04-29 at 15:54:46 -0400, Sean Paul wrote: > > From: Sean Paul > > > > Changes in v6: > > -Rebased on -tip > > -Disabled HDCP over MST on GEN12 > > -Addressed Lyude's review comments in the QUERY_STREAM_ENCRYPTION_STATUS > > patch

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/params: don't expose inject_probe_failure in debugfs (rev2)

2020-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/params: don't expose inject_probe_failure in debugfs (rev2) URL : https://patchwork.freedesktop.org/series/77272/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8494 -> Patchwork_17689

  1   2   >