Re: [Intel-gfx] [PATCH 06/12] drm/i915/fbc: Don't clear busy_bits for origin==GTT

2020-06-24 Thread Souza, Jose
On Wed, 2020-04-29 at 13:10 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The hardware host tracking won't nuke the entire cfb (unless the > entire fb is written through the gtt) so don't clear the busy_bits > for gtt tracking. > > Not that it really matters anymore since we've lost ORIG

Re: [Intel-gfx] [PATCH 11/12] drm/i915: Fix g4x fbc watermark enable

2020-06-24 Thread Souza, Jose
On Wed, 2020-04-29 at 13:10 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > 'level' here means the highest level we can't use, so when checking > the fbc watermarks we need a -1 to get at the last enabled level. > > While at if refactor the code a bit to declutter > g4x_compute_pipe_wm().

Re: [Intel-gfx] [PATCH 12/12] drm/i915: Suppress spurious underruns on gen2

2020-06-24 Thread Souza, Jose
On Wed, 2020-04-29 at 13:10 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Often we seem to detect an underrun right after modeset on gen2. > It seems to be a spurious detection (potentially the pipe is still > in a wonky state when we enable the planes). An extra vblank wait > seems to cu

Re: [Intel-gfx] [PATCH 10/12] drm/i915/fbc: Reduce fbc1 compression interval to 1 second

2020-06-24 Thread Souza, Jose
On Wed, 2020-04-29 at 13:10 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The default fbc1 compression interval we use is 500 frames. That > translates to over 8 seconds typically. That's rather excessive > so let's drop it to 1 second. > > The hardware will not attempt recompression unl

Re: [Intel-gfx] [PATCH 09/12] drm/i915/fbc: Store the fbc1 compression interval in the params

2020-06-24 Thread Souza, Jose
On Wed, 2020-04-29 at 13:10 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Avoid the FBC_CONTROL rmw and just store the fbc compression > interval in the params/ Reviewed-by: José Roberto de Souza > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_fbc.c | 13

Re: [Intel-gfx] [PATCH 08/12] drm/i915/fbc: Parametrize FBC_CONTROL

2020-06-24 Thread Souza, Jose
On Wed, 2020-04-29 at 13:10 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Parametrize the FBC_CONTROL bits for neater code. > > Also add the one missing bit: "stop compression on modification". > Reviewed-by: José Roberto de Souza > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/

[Intel-gfx] [PATCH v3 3/3] drm/i915/display: Enable HOBL regardless the VBT value

2020-06-24 Thread José Roberto de Souza
HOBL worked in my TGL RVP even without the necessary HW support, also it worked in more than half of the TGL machines in CI so it is worthy to enable it by default. Even if link training fails with this new vswing table it will only cause one additional link training, that is worthy the try to get

[Intel-gfx] [PATCH v3 1/3] drm/i915/bios: Parse HOBL parameter

2020-06-24 Thread José Roberto de Souza
HOBL means hours of battery life, it is a power-saving feature were supported motherboards can use a special voltage swing table that uses less power. So here parsing the VBT to check if this feature is supported. BSpec: 20150 Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/displa

[Intel-gfx] [PATCH v3 2/3] drm/i915/display: Implement HOBL

2020-06-24 Thread José Roberto de Souza
Hours Of Battery Life is a new GEN12+ power-saving feature that allows supported motherboards to use a special voltage swing table for eDP panels that uses less power. So here if supported by HW, OEM will set it in VBT and i915 will try to train link with HOBL vswing table if link training fails i

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/display: Implement HOBL

2020-06-24 Thread Souza, Jose
On Wed, 2020-06-03 at 20:55 +, Souza, Jose wrote: > On Wed, 2020-06-03 at 23:33 +0300, Ville Syrjälä wrote: > > On Wed, Jun 03, 2020 at 12:43:07PM -0700, José Roberto de Souza wrote: > > > Hours Of Battery Life is a new GEN12+ power-saving feature that allows > > > supported motherboards to use

[Intel-gfx] [PATCH v2 5/6] drm/i915/display: use port_info in intel_ddi_init

2020-06-24 Thread Lucas De Marchi
Now that we have tables for all platforms using ddi, keep the port_info around so we can use it for decisions like "what phy does it have?" instead of keep checking the platform/gen everywhere. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_ddi.c | 39

[Intel-gfx] [PATCH v2 6/6] drm/i915/display: replace port to phy conversions in intel_ddi.c

2020-06-24 Thread Lucas De Marchi
This is the first level conversion to use port_info directly from intel_digital_port, rather than derive the phy or tc_port from the port. This touches only the functions which have the encoder or dig_port directly available. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_

[Intel-gfx] [PATCH v2 3/6] drm/i915/display: start description-based ddi initialization

2020-06-24 Thread Lucas De Marchi
Start adding per-platform relevant data into a table that we use for initialization. Intention is to keep the different indexes we need (e.g. phy, vbt, ddi, etc) and any other differences for each platform in these tables so we don't have to keep converting back and forth between them. For now, ju

[Intel-gfx] [PATCH v2 0/6] display/ddi: keep register indexes in a table

2020-06-24 Thread Lucas De Marchi
v2 of https://patchwork.freedesktop.org/series/71330/ I think I covered comments from Jani and Matt Roper here. This is still in the RFC phase and thus not properly tested. Change in this version is mostly that now it's not trying to generalize intel_setup_outputs(), but rather provide a function

[Intel-gfx] [PATCH v2 4/6] drm/i915/display: add phy, vbt and ddi indexes

2020-06-24 Thread Lucas De Marchi
Identify 3 possible cases in which the index numbers can be different from the "port" and add them to the description-based ddi initialization table. This can be used in place of additional functions mapping from one to the other. Right now we already cover part of this by creating kind of virtua

[Intel-gfx] [PATCH v2 1/6] drm/i915: move ICL port F hack to intel_bios

2020-06-24 Thread Lucas De Marchi
Move the check for port F to intel_bios.c and just make intel_ddi_init() call it. This will allow the output initialization of ICL to be like platforms after it, allowing us to make it generic. Suggested-by: Jani Nikula Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_bios.

[Intel-gfx] [PATCH v2 2/6] drm/i915/display: fix comment on skl straps

2020-06-24 Thread Lucas De Marchi
We are not checking for specific SKUs and feedback from HW team is that it may not work since it was supposed to be fixed by the same time straps stopped to be used. So, just update comment. v2: Instead of removing the check, just update the comment since feedback from HW team was that it actually

[Intel-gfx] [PATCH v2 3/3] Revert "drm/amd/display: Expose connector VRR range via debugfs"

2020-06-24 Thread Manasi Navare
From: Bhanuprakash Modem v2: * Rebase (Manasi) As both VRR min and max are already part of drm_display_info, drm can expose this VRR range for each connector. Hence this logic should move to core DRM. This reverts commit 727962f030c23422a01e8b22d0f463815fb15ec4. Signed-off-by: Bhanuprakash Mo

[Intel-gfx] [PATCH v3 1/2] drm/i915/dp: Helper for checking DDI_BUF_CTL Idle status

2020-06-24 Thread Manasi Navare
Modify the helper to add a fixed delay or poll with timeout based on platform specification to check for either Idle bit set (DDI_BUF_CTL is idle for disable case) v2: * Use 2 separate functions or idle and active (Ville) Cc: Ville Syrjälä Cc: Imre Deak Signed-off-by: Manasi Navare --- driver

[Intel-gfx] [PATCH v3 2/2] drm/i915/dp: Helper to check for DDI BUF status to get active

2020-06-24 Thread Manasi Navare
Based on the platform, Bspec expects us to wait or poll with timeout for DDI BUF IDLE bit to be set to 0 (non idle) or get active after enabling DDI_BUF_CTL. v3: * Add a new function _active for DDI BUF CTL to be non idle (Ville) v2: * Based on platform, fixed delay or poll (Ville) * Use a helper

[Intel-gfx] [PATCH] drm/i915: implement Wa_14011508470;gen12

2020-06-24 Thread Matt Atwood
Update code to reflect recent bspec changes Bspec: 52890 Bspec: 53508 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/display/intel_display_power.c | 8 drivers/gpu/drm/i915/i915_reg.h| 6 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/i9

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Implement WA_1406941453

2020-06-24 Thread Vudum, Lakshminarayana
Re-reported. -Original Message- From: Ausmus, James Sent: Wednesday, June 24, 2020 9:32 PM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana Cc: Taylor, Clinton A Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Implement WA_1406941453 On Fri, Jun 12, 2020 a

Re: [Intel-gfx] [PATCH] mm: Skip opportunistic reclaim for dma pinned pages

2020-06-24 Thread Chris Wilson
Quoting Jason Gunthorpe (2020-06-24 20:21:16) > On Wed, Jun 24, 2020 at 08:14:17PM +0100, Chris Wilson wrote: > > A general rule of thumb is that shrinkers should be fast and effective. > > They are called from direct reclaim at the most incovenient of times when > > the caller is waiting for a pag

Re: [Intel-gfx] [PATCH 7/7] drm/i915/gem: Acquire all vma/objects under reservation_ww_class

2020-06-24 Thread Chris Wilson
Quoting Dave Airlie (2020-06-24 20:04:02) > On Wed, 24 Jun 2020 at 07:19, Chris Wilson wrote: > > > > Quoting Dave Airlie (2020-06-23 22:01:24) > > > On Tue, 23 Jun 2020 at 20:03, Chris Wilson > > > wrote: > > > > > > > > Quoting Thomas Hellström (Intel) (2020-06-23 10:33:20) > > > > > Hi, Chris

Re: [Intel-gfx] [PATCH] dma-buf: minor doc touch-ups

2020-06-24 Thread Daniel Vetter
On Fri, Jun 12, 2020 at 09:05:35AM +0200, Daniel Vetter wrote: > Just some tiny edits: > - fix link to struct dma_fence > - give slightly more meaningful title - the polling here is about > implicit fences, explicit fences (in sync_file or drm_syncobj) also > have their own polling > > v2: I m

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Implement WA_1406941453

2020-06-24 Thread Patchwork
== Series Details == Series: drm/i915/gt: Implement WA_1406941453 URL : https://patchwork.freedesktop.org/series/78243/ State : success == Summary == CI Bug Log - changes from CI_DRM_8618 -> Patchwork_17931 Summary --- **SUCCESS**

[Intel-gfx] [PATCH v2] drm/i915/display: Implement new combo phy initialization step

2020-06-24 Thread José Roberto de Souza
This is new step that was recently added to the combo phy initialization. v2: - using intel_de_rmw() BSpec: 49291 Cc: Lucas De Marchi Signed-off-by: José Roberto de Souza --- .../gpu/drm/i915/display/intel_combo_phy.c| 23 +++ drivers/gpu/drm/i915/i915_reg.h |

[Intel-gfx] [PATCH] mm: Skip opportunistic reclaim for dma pinned pages

2020-06-24 Thread Chris Wilson
A general rule of thumb is that shrinkers should be fast and effective. They are called from direct reclaim at the most incovenient of times when the caller is waiting for a page. If we attempt to reclaim a page being pinned for active dma [pin_user_pages()], we will incur far greater latency than

Re: [Intel-gfx] [PATCH 7/7] drm/i915/gem: Acquire all vma/objects under reservation_ww_class

2020-06-24 Thread Dave Airlie
On Wed, 24 Jun 2020 at 07:19, Chris Wilson wrote: > > Quoting Dave Airlie (2020-06-23 22:01:24) > > On Tue, 23 Jun 2020 at 20:03, Chris Wilson wrote: > > > > > > Quoting Thomas Hellström (Intel) (2020-06-23 10:33:20) > > > > Hi, Chris! > > > > > > > > On 6/22/20 11:59 AM, Chris Wilson wrote: > >

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Implement WA_1406941453

2020-06-24 Thread James Ausmus
On Fri, Jun 12, 2020 at 12:04:35AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/gt: Implement WA_1406941453 > URL : https://patchwork.freedesktop.org/series/78243/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_8618 -> Patchwork_17931 >

Re: [Intel-gfx] [PATCH] drm/i915/gt: Implement WA_1406941453

2020-06-24 Thread Matt Atwood
On Thu, Jun 11, 2020 at 04:31:08PM -0700, clinton.a.tay...@intel.com wrote: > From: Clint Taylor > > Enable HW Default flip for small PL. > > bspec: 52890 > bspec: 53508 > bspec: 53273 > > Signed-off-by: Clint Taylor Reviewed-by: Matt Atwood > --- > drivers/gpu/drm/i915/gt/intel_workarounds.

Re: [Intel-gfx] [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Chris Wilson
Quoting Jason Gunthorpe (2020-06-24 17:50:57) > On Wed, Jun 24, 2020 at 03:37:32PM +0100, Chris Wilson wrote: > > Quoting Jason Gunthorpe (2020-06-24 15:25:44) > > > On Wed, Jun 24, 2020 at 03:21:49PM +0100, Chris Wilson wrote: > > > > Quoting Jason Gunthorpe (2020-06-24 15:16:04) > > > > > On Wed,

Re: [Intel-gfx] [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Chris Wilson
Quoting Jason Gunthorpe (2020-06-24 15:25:44) > On Wed, Jun 24, 2020 at 03:21:49PM +0100, Chris Wilson wrote: > > Quoting Jason Gunthorpe (2020-06-24 15:16:04) > > > On Wed, Jun 24, 2020 at 03:12:42PM +0100, Chris Wilson wrote: > > > > Quoting Jason Gunthorpe (2020-06-24 13:39:10) > > > > > On Wed,

Re: [Intel-gfx] [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Chris Wilson
Quoting Jason Gunthorpe (2020-06-24 15:16:04) > On Wed, Jun 24, 2020 at 03:12:42PM +0100, Chris Wilson wrote: > > Quoting Jason Gunthorpe (2020-06-24 13:39:10) > > > On Wed, Jun 24, 2020 at 01:21:03PM +0100, Chris Wilson wrote: > > > > Quoting Jason Gunthorpe (2020-06-24 13:10:53) > > > > > On Wed,

Re: [Intel-gfx] [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Chris Wilson
Quoting Jason Gunthorpe (2020-06-24 13:39:10) > On Wed, Jun 24, 2020 at 01:21:03PM +0100, Chris Wilson wrote: > > Quoting Jason Gunthorpe (2020-06-24 13:10:53) > > > On Wed, Jun 24, 2020 at 09:02:47AM +0100, Chris Wilson wrote: > > > > When direct reclaim enters the shrinker and tries to reclaim pa

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/display/rkl: Implement WA 14011471926

2020-06-24 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/rkl: Implement WA 14011471926 URL : https://patchwork.freedesktop.org/series/78761/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8661_full -> Patchwork_18015_full ===

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/26] Revert "drm/i915/gem: Async GPU relocations only" (rev2)

2020-06-24 Thread Patchwork
== Series Details == Series: series starting with [01/26] Revert "drm/i915/gem: Async GPU relocations only" (rev2) URL : https://patchwork.freedesktop.org/series/78744/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8661 -> Patchwork_18018 =

Re: [Intel-gfx] [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Chris Wilson
Quoting Jason Gunthorpe (2020-06-24 13:10:53) > On Wed, Jun 24, 2020 at 09:02:47AM +0100, Chris Wilson wrote: > > When direct reclaim enters the shrinker and tries to reclaim pages, it > > has to opportunitically unmap them [try_to_unmap_one]. For direct > > reclaim, the calling context is unknown

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/26] Revert "drm/i915/gem: Async GPU relocations only" (rev2)

2020-06-24 Thread Patchwork
== Series Details == Series: series starting with [01/26] Revert "drm/i915/gem: Async GPU relocations only" (rev2) URL : https://patchwork.freedesktop.org/series/78744/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/26] Revert "drm/i915/gem: Async GPU relocations only" (rev2)

2020-06-24 Thread Patchwork
== Series Details == Series: series starting with [01/26] Revert "drm/i915/gem: Async GPU relocations only" (rev2) URL : https://patchwork.freedesktop.org/series/78744/ State : warning == Summary == $ dim checkpatch origin/drm-tip 33892249d7d2 Revert "drm/i915/gem: Async GPU relocations only"

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Patchwork
== Series Details == Series: series starting with [1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL URL : https://patchwork.freedesktop.org/series/78767/ State : success == Summary == CI Bug Log - changes from CI_DRM_8661 -> Patchwork_18017 =

Re: [Intel-gfx] [PATCH v3 3/5] drm/i915: Add checks specific to async flips

2020-06-24 Thread Karthik B S
On 6/17/2020 9:27 PM, Ville Syrjälä wrote: On Thu, May 28, 2020 at 11:09:29AM +0530, Karthik B S wrote: Support added only for async flips on primary plane. If flip is requested on any other plane, reject it. Make sure there is no change in fbc, offset and framebuffer modifiers when async fli

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-06-24 Thread Karthik B S
On 6/17/2020 9:00 PM, Ville Syrjälä wrote: On Wed, Jun 17, 2020 at 11:58:10AM +0200, Daniel Vetter wrote: On Wed, Jun 10, 2020 at 03:33:06PM -0700, Paulo Zanoni wrote: Em qui, 2020-05-28 às 11:09 +0530, Karthik B S escreveu: Add enable/disable flip done functions and the flip done handler fu

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Patchwork
== Series Details == Series: series starting with [1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL URL : https://patchwork.freedesktop.org/series/78767/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-06-24 Thread Karthik B S
On 6/17/2020 8:15 PM, Kazlauskas, Nicholas wrote: On 2020-06-17 5:58 a.m., Daniel Vetter wrote: On Wed, Jun 10, 2020 at 03:33:06PM -0700, Paulo Zanoni wrote: Em qui, 2020-05-28 às 11:09 +0530, Karthik B S escreveu: Add enable/disable flip done functions and the flip done handler function whi

Re: [Intel-gfx] [PATCH 01/26] Revert "drm/i915/gem: Async GPU relocations only"

2020-06-24 Thread Chris Wilson
Quoting Chris Wilson (2020-06-23 16:23:31) > Quoting Maarten Lankhorst (2020-06-23 15:28:18) > > This reverts commit 9e0f9464e2ab36b864359a59b0e9058fdef0ce47, > > and related commit 7ac2d2536dfa7 ("drm/i915/gem: Delete unused code"). > > Regardless that you haven't adapted the series... > > This

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-06-24 Thread Karthik B S
On 6/17/2020 3:28 PM, Daniel Vetter wrote: On Wed, Jun 10, 2020 at 03:33:06PM -0700, Paulo Zanoni wrote: Em qui, 2020-05-28 às 11:09 +0530, Karthik B S escreveu: Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip d

[Intel-gfx] ✓ Fi.CI.BAT: success for Send a hotplug when edid changes (rev8)

2020-06-24 Thread Patchwork
== Series Details == Series: Send a hotplug when edid changes (rev8) URL : https://patchwork.freedesktop.org/series/62816/ State : success == Summary == CI Bug Log - changes from CI_DRM_8661 -> Patchwork_18016 Summary --- **SUCCESS**

[Intel-gfx] [PATCH] drm/i915: Kill context before taking ctx->mutex

2020-06-24 Thread Maarten Lankhorst
Killing context before taking ctx->mutex fixes a hang in gem_ctx_persistence.close-replace-race, where lut_close takes obj->resv.lock which is already held by execbuf, causing a stalling indefinitely. [ 1904.342847] 2 locks held by gem_ctx_persist/11520: [ 1904.342849] #0: 8882188e4968 (&ctx-

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-06-24 Thread Karthik B S
On 6/11/2020 4:03 AM, Paulo Zanoni wrote: Em qui, 2020-05-28 às 11:09 +0530, Karthik B S escreveu: Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip done interrupt in IER. Enable flip done function is called befor

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Send a hotplug when edid changes (rev8)

2020-06-24 Thread Patchwork
== Series Details == Series: Send a hotplug when edid changes (rev8) URL : https://patchwork.freedesktop.org/series/62816/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/amd/amd

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Send a hotplug when edid changes (rev8)

2020-06-24 Thread Patchwork
== Series Details == Series: Send a hotplug when edid changes (rev8) URL : https://patchwork.freedesktop.org/series/62816/ State : warning == Summary == $ dim checkpatch origin/drm-tip 75d80077 drm: Add helper to compare edids. -:32: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be wr

Re: [Intel-gfx] [PATCH 7/7] drm/i915/gem: Acquire all vma/objects under reservation_ww_class

2020-06-24 Thread Chris Wilson
Quoting Thomas Hellström (Intel) (2020-06-24 10:50:08) > > On 6/24/20 10:08 AM, Chris Wilson wrote: > > Quoting Thomas Hellström (Intel) (2020-06-24 06:42:33) > >> On 6/23/20 11:15 PM, Chris Wilson wrote: > >>> Quoting Thomas Hellström (Intel) (2020-06-23 21:31:38) > On 6/23/20 8:41 PM, Chris

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/display/rkl: Implement WA 14011471926

2020-06-24 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/rkl: Implement WA 14011471926 URL : https://patchwork.freedesktop.org/series/78761/ State : success == Summary == CI Bug Log - changes from CI_DRM_8661 -> Patchwork_18015 =

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/display/rkl: Implement WA 14011471926

2020-06-24 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/rkl: Implement WA 14011471926 URL : https://patchwork.freedesktop.org/series/78761/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8661 -> Patchwork_18014 =

[Intel-gfx] [PATCH i-g-t 1/2] lib/igt_fb: change comments with fd description

2020-06-24 Thread Melissa Wen
Generalize description of fd so as not restrict it to i915 driver Signed-off-by: Melissa Wen --- lib/igt_fb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/igt_fb.c b/lib/igt_fb.c index 5ed586e7..5a219c57 100644 --- a/lib/igt_fb.c +++ b/lib/igt_fb.c @@ -3548,7 +35

[Intel-gfx] [PATCH i-g-t 2/2] test/kms_cursor_crc: update subtests descriptions and some comments

2020-06-24 Thread Melissa Wen
Add descriptions for some subtests and detail a little more the comments in test_cursor_alpha. Signed-off-by: Melissa Wen --- tests/kms_cursor_crc.c | 38 -- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cur

[Intel-gfx] [PATCH i-g-t 0/2] minor improvements to the kms_cursor_crc doc and some comments cleanup

2020-06-24 Thread Melissa Wen
Hi, I was studying the code of kms_cursor_crc test, and I just adjusted some comments and added descriptions for subtests. Melissa Wen (2): lib/igt_fb: change comments with fd description test/kms_cursor_crc: update subtests descriptions and some comments lib/igt_fb.c | 6 +++---

Re: [Intel-gfx] [PATCH 7/7] drm/i915/gem: Acquire all vma/objects under reservation_ww_class

2020-06-24 Thread Intel
On 6/24/20 10:08 AM, Chris Wilson wrote: Quoting Thomas Hellström (Intel) (2020-06-24 06:42:33) On 6/23/20 11:15 PM, Chris Wilson wrote: Quoting Thomas Hellström (Intel) (2020-06-23 21:31:38) On 6/23/20 8:41 PM, Chris Wilson wrote: Quoting Thomas Hellström (Intel) (2020-06-23 19:21:28) On 6

Re: [Intel-gfx] [PATCH 1/8] drm/atomic-helper: reset vblank on crtc reset

2020-06-24 Thread Maxime Ripard
On Fri, Jun 12, 2020 at 06:00:49PM +0200, Daniel Vetter wrote: > Only when vblanks are supported ofc. > > Some drivers do this already, but most unfortunately missed it. This > opens up bugs after driver load, before the crtc is enabled for the > first time. syzbot spotted this when loading vkms a

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/display/rkl: Implement WA 14011471926

2020-06-24 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/rkl: Implement WA 14011471926 URL : https://patchwork.freedesktop.org/series/78761/ State : warning == Summary == $ dim checkpatch origin/drm-tip bd24ac2db018 drm/i915/display/rkl: Implement WA 14011471926 3ac2f590c2c8 d

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp_mst: Enable VC payload allocation after transcoder is enabled

2020-06-24 Thread Imre Deak
On Tue, Jun 23, 2020 at 12:48:08PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dp_mst: Enable VC payload allocation after transcoder is > enabled > URL : https://patchwork.freedesktop.org/series/78728/ > State : success Thanks for the review, patch pushed to -dinq. >

Re: [Intel-gfx] [PATCH 5/8] drm/vc4: Use __drm_atomic_helper_crtc_reset

2020-06-24 Thread Maxime Ripard
On Fri, Jun 12, 2020 at 06:00:53PM +0200, Daniel Vetter wrote: > Now also comes with the added benefit of doing a drm_crtc_vblank_off(), > which means vblank state isn't ill-defined and fail-y at driver load > before the first modeset on each crtc. > > Signed-off-by: Daniel Vetter > Cc: Eric Anho

Re: [Intel-gfx] [PATCH 04/26] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-06-24 Thread Chris Wilson
Quoting Thomas Hellström (Intel) (2020-06-24 08:49:21) > Hi, Chris, > > On 6/24/20 9:43 AM, Chris Wilson wrote: > > Quoting Thomas Hellström (Intel) (2020-06-24 08:10:43) > >> Hi, Maarten, > >> > >> > >> On 6/23/20 4:28 PM, Maarten Lankhorst wrote: > >>> i915_gem_ww_ctx is used to lock all gem bo'

Re: [Intel-gfx] [PATCH 7/7] drm/i915/gem: Acquire all vma/objects under reservation_ww_class

2020-06-24 Thread Chris Wilson
Quoting Thomas Hellström (Intel) (2020-06-24 06:42:33) > > On 6/23/20 11:15 PM, Chris Wilson wrote: > > Quoting Thomas Hellström (Intel) (2020-06-23 21:31:38) > >> On 6/23/20 8:41 PM, Chris Wilson wrote: > >>> Quoting Thomas Hellström (Intel) (2020-06-23 19:21:28) > On 6/23/20 6:36 PM, Chris

[Intel-gfx] [PATCH 2/2] drm/i915/gem: Use mmu_notifier_range_mayfail() to avoid waiting inside reclaim

2020-06-24 Thread Chris Wilson
The direct reclaim path may trigger the mmu_notifier callback as part of try_to_unmap_one. As this is purely an opportunitistic attempt to reclaim pages, and will be called from any allocation context under unknown conditions (that include attempting to allocate pages for the userptr object itself

[Intel-gfx] [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Chris Wilson
When direct reclaim enters the shrinker and tries to reclaim pages, it has to opportunitically unmap them [try_to_unmap_one]. For direct reclaim, the calling context is unknown and may include attempts to unmap one page of a dma object while attempting to allocate more pages for that object. Pass t

Re: [Intel-gfx] [PATCH 04/26] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-06-24 Thread Intel
Hi, Chris, On 6/24/20 9:43 AM, Chris Wilson wrote: Quoting Thomas Hellström (Intel) (2020-06-24 08:10:43) Hi, Maarten, On 6/23/20 4:28 PM, Maarten Lankhorst wrote: i915_gem_ww_ctx is used to lock all gem bo's for pinning and memory eviction. We don't use it yet, but lets start adding the def

Re: [Intel-gfx] [PATCH 04/26] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-06-24 Thread Chris Wilson
Quoting Thomas Hellström (Intel) (2020-06-24 08:10:43) > Hi, Maarten, > > > On 6/23/20 4:28 PM, Maarten Lankhorst wrote: > > i915_gem_ww_ctx is used to lock all gem bo's for pinning and memory > > eviction. We don't use it yet, but lets start adding the definition > > first. > > > > To use it, we

Re: [Intel-gfx] [PATCH 3/8] drm/imx: Use __drm_atomic_helper_crtc_reset

2020-06-24 Thread Daniel Vetter
On Fri, Jun 12, 2020 at 06:00:51PM +0200, Daniel Vetter wrote: > Now also comes with the added benefit of doing a drm_crtc_vblank_off(), > which means vblank state isn't ill-defined and fail-y at driver load > before the first modeset on each crtc. > > Signed-off-by: Daniel Vetter > Cc: Philipp Z

Re: [Intel-gfx] [PATCH 7/8] drm/mipi-dbi: Remove ->enabled

2020-06-24 Thread Daniel Vetter
On Tue, Jun 16, 2020 at 07:16:45PM +0200, Daniel Vetter wrote: > On Tue, Jun 16, 2020 at 3:57 PM Emil Velikov wrote: > > > > On Tue, 16 Jun 2020 at 07:50, Daniel Vetter wrote: > > > > > > On Mon, Jun 15, 2020 at 11:35 PM Emil Velikov > > > wrote: > > > > > > > > Hi Daniel, > > > > > > > > On Fr

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2020-06-24 Thread Stephen Rothwell
Hi Dave, On Wed, 24 Jun 2020 15:47:49 +1000 Dave Airlie wrote: > > My bad, my local builds passed, as I had made the change but forgot > the commit --amend > > Pushed out a new head with it in it now. Excellent, thanks. -- Cheers, Stephen Rothwell pgpiTA7UkNPQK.pgp Description: OpenPGP digi

Re: [Intel-gfx] [PATCH 8/8] drm/tiny/repaper: Drop edp->enabled

2020-06-24 Thread Daniel Vetter
On Sat, Jun 13, 2020 at 03:43:23PM +0200, Noralf Trønnes wrote: > > > Den 12.06.2020 18.00, skrev Daniel Vetter: > > Same patch as the mipi-dbi one, atomic tracks this for us already, we > > just have to check the right thing. > > > > Signed-off-by: Daniel Vetter > > Cc: "Noralf Trønnes" > > -

Re: [Intel-gfx] [PATCH 04/26] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-06-24 Thread Intel
Hi, Maarten, On 6/23/20 4:28 PM, Maarten Lankhorst wrote: i915_gem_ww_ctx is used to lock all gem bo's for pinning and memory eviction. We don't use it yet, but lets start adding the definition first. To use it, we have to pass a non-NULL ww to gem_object_lock, and don't unlock directly. It is