== Series Details ==
Series: drm/i915: Implement WA 14011294188
URL : https://patchwork.freedesktop.org/series/79825/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8778_full -> Patchwork_18236_full
Summary
---
**SUCC
Hello all,
TL;DR: my questions concern the following two topics:
- CRTCs and Intel integrated GPUs
- intel-virtual-output utility
I have a laptop with both an Intel integrated GPU and an AMD discrete GPU.
```
➜ ~ xrandr --listproviders
Providers: number : 2
Provider 0: id: 0x70 cap: 0x9, Source
== Series Details ==
Series: Allow privileged user to map the OA buffer (rev5)
URL : https://patchwork.freedesktop.org/series/79460/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8783 -> Patchwork_18237
Summary
---
*
== Series Details ==
Series: Allow privileged user to map the OA buffer (rev5)
URL : https://patchwork.freedesktop.org/series/79460/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.0
Fast mode used, each commit won't be checked separately.
__
== Series Details ==
Series: drm/i915: Filter wake_flags passed to default_wake_function
URL : https://patchwork.freedesktop.org/series/79824/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8778_full -> Patchwork_18235_full
From: Piotr Maciejewski
OA reports can be triggered into the OA buffer by writing into the
OAREPORTTRIG registers. Whitelist the registers to allow user to trigger
reports.
v2:
- Move related change to this patch (Lionel)
- Bump up perf revision (Lionel)
v3: Pardon whitelisted registers for sel
From: Piotr Maciejewski
i915 used to support time based sampling mode which is good for overall
system monitoring, but is not enough for query mode used to measure a
single draw call or dispatch. Gen9-Gen11 are using current i915 perf
implementation for query, but Gen12+ requires a new approach f
From: Piotr Maciejewski
It is useful to have markers in the OA reports to identify triggered
reports. Whitelist some OA counters that can be used as markers.
A triggered report can be found faster if we can sample the HW tail and
head registers when the report was triggered. Whitelist OA buffer
This cover letter is included to trigger "Test-with" an IGT patch.
Tests - https://patchwork.freedesktop.org/series/79829/
Signed-off-by: Umesh Nerlige Ramappa
Test-with: 20200724001521.35201-1-umesh.nerlige.rama...@intel.com
Piotr Maciejewski (4):
drm/i915/perf: Ensure observation logic is n
From: Piotr Maciejewski
A clock gating switch can control if the performance monitoring and
observation logic is enaled or not. Ensure that we enable the clocks.
v2: Separate code from other patches (Lionel)
v3: Reset PMON enable when disabling perf to save power (Lionel)
Fixes: 00a7f0d7155c ("
On Thu, Jul 23, 2020 at 9:17 PM Felipe Balbi wrote:
>
> Nicolas Boichat writes:
>
> > trace_printk should not be used in production code, replace it
> > call with dev_dbg.
> >
> > Signed-off-by: Nicolas Boichat
> >
> > ---
> >
> > Unclear why a trace_printk was used in the first place, it's
> >
On Thu, Jul 23, 2020 at 12:31:30PM +0300, Lionel Landwerlin wrote:
On 22/07/2020 08:55, Umesh Nerlige Ramappa wrote:
From: Piotr Maciejewski
i915 used to support time based sampling mode which is good for overall
system monitoring, but is not enough for query mode used to measure a
single draw
== Series Details ==
Series: drm/i915/gem: Delay tracking the GEM context until it is registered
URL : https://patchwork.freedesktop.org/series/79822/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8778_full -> Patchwork_18234_full
==
== Series Details ==
Series: drm/i915: Implement WA 14011294188
URL : https://patchwork.freedesktop.org/series/79825/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8778 -> Patchwork_18236
Summary
---
**SUCCESS**
N
== Series Details ==
Series: drm/i915: Implement WA 14011294188
URL : https://patchwork.freedesktop.org/series/79825/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.0
Fast mode used, each commit won't be checked separately.
_
Although the WA description targets the platforms it is a workaround
for the affected PCHs, that is why it is being checked.
BSpec: 52890
BSpec: 53273
BSpec: 52888
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/display/intel_display_power.c | 5 +
drivers/gpu/drm/i915/i915_reg
== Series Details ==
Series: series starting with [1/2] drm/i915/gt: Disable preparser around xcs
invalidations on tgl (rev2)
URL : https://patchwork.freedesktop.org/series/79820/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8778_full -> Patchwork_18233_full
== Series Details ==
Series: series starting with [1/3] drm: Restore driver.preclose() for all to use
URL : https://patchwork.freedesktop.org/series/79819/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8778_full -> Patchwork_18231_full
=
I've got a 66 patch series here, does it have a cover letter I missed?
Does it have a what is the goal of this series? Does it tell the
reviewer where things are headed and why this is a good idea from a
high level.
The problem with these series is they are impossible to review from a
WTF does it
== Series Details ==
Series: drm/i915: Filter wake_flags passed to default_wake_function
URL : https://patchwork.freedesktop.org/series/79824/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8778 -> Patchwork_18235
Summary
--
== Series Details ==
Series: drm/i915: Filter wake_flags passed to default_wake_function
URL : https://patchwork.freedesktop.org/series/79824/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.0
Fast mode used, each commit won't be checked separately.
The flags passed to the wait_entry.func are passed onwards to
try_to_wake_up(), which has a very particular interpretation for its
wake_flags. In particular, beyond the published WF_SYNC, it has a few
internal flags as well. Since we passed the fence->error down the chain
via the flags argument, th
== Series Details ==
Series: drm/i915/selftests: Downgrade severity of CS/SRM frequency scaling tests
URL : https://patchwork.freedesktop.org/series/79814/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8778_full -> Patchwork_18230_full
=
== Series Details ==
Series: drm/i915/gem: Delay tracking the GEM context until it is registered
URL : https://patchwork.freedesktop.org/series/79822/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8778 -> Patchwork_18234
Su
== Series Details ==
Series: drm/i915/gem: Delay tracking the GEM context until it is registered
URL : https://patchwork.freedesktop.org/series/79822/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.0
Fast mode used, each commit won't be checked separately
== Series Details ==
Series: series starting with [1/2] drm/i915/gt: Disable preparser around xcs
invalidations on tgl (rev2)
URL : https://patchwork.freedesktop.org/series/79820/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8778 -> Patchwork_18233
==
Quoting Chris Wilson (2020-07-23 19:33:48)
> Avoid exposing a partially constructed context by deferring the
> list_add() from the initial construction to the end of registration.
> Otherwise, if we peek into the list of contexts from inside debugfs, we
> may see the partially constructed context a
Avoid exposing a partially constructed context by deferring the
list_add() from the initial construction to the end of registration.
Otherwise, if we peek into the list of contexts from inside debugfs, we
may see the partially constructed context and change down some dangling
incomplete pointers.
== Series Details ==
Series: series starting with [1/2] drm/i915/gt: Disable preparser around xcs
invalidations on tgl (rev2)
URL : https://patchwork.freedesktop.org/series/79820/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.0
Fast mode used, each comm
== Series Details ==
Series: series starting with [1/2] drm/i915/gt: Disable preparser around xcs
invalidations on tgl
URL : https://patchwork.freedesktop.org/series/79820/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8778 -> Patchwork_18232
=
Whether this is an arbitrary stall or a vital ingredient, neverthess the
impact is noticeable. If we do not have the stall around the xcs
invalidation before a request, writes within that request sometimes go
astray.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2169
Signed-off-by: Chr
== Series Details ==
Series: series starting with [1/2] drm/i915/gt: Disable preparser around xcs
invalidations on tgl
URL : https://patchwork.freedesktop.org/series/79820/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.0
Fast mode used, each commit won'
== Series Details ==
Series: series starting with [1/3] drm: Restore driver.preclose() for all to use
URL : https://patchwork.freedesktop.org/series/79819/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8778 -> Patchwork_18231
===
Quoting Chris Wilson (2020-07-23 18:41:44)
> Whether this is an arbitrary stall or a vital ingredient, neverthess the
> impact is noticeable. If we do not have the stall around the xcs
> invalidation before a request, writes within that request sometimes go
> astray.
>
> Closes: https://gitlab.fre
Quoting Tang, CQ (2020-07-23 18:44:08)
>
>
> > -Original Message-
> > From: Chris Wilson
> > Sent: Thursday, July 23, 2020 10:21 AM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: dri-de...@lists.freedesktop.org; Chris Wilson
> > ;
> > Tang, CQ ; Vetter, Daniel ;
> > sta...@vger.kernel.
> -Original Message-
> From: Chris Wilson
> Sent: Thursday, July 23, 2020 10:21 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: dri-de...@lists.freedesktop.org; Chris Wilson ;
> Tang, CQ ; Vetter, Daniel ;
> sta...@vger.kernel.org
> Subject: [PATCH 2/3] drm/i915/gem: Move context decoupl
Unlike rcs where we have conclusive evidence from our selftesting that
disabling the preparser before performing the TLB invalidate and
relocations does impact upon the GPU execution, the evidence for the
same requirement on xcs is much more circumstantial. Let's apply the
preparser disable between
Whether this is an arbitrary stall or a vital ingredient, neverthess the
impact is noticeable. If we do not have the stall around the xcs
invalidation before a request, writes within that request sometimes go
astray.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2169
Signed-off-by: Chr
== Series Details ==
Series: series starting with [1/3] drm: Restore driver.preclose() for all to use
URL : https://patchwork.freedesktop.org/series/79819/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.0
Fast mode used, each commit won't be checked separ
== Series Details ==
Series: series starting with [1/3] drm: Restore driver.preclose() for all to use
URL : https://patchwork.freedesktop.org/series/79819/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
33b94230c8dd drm: Restore driver.preclose() for all to use
-:16: ERROR:GIT_C
Since the GEM contexts refer to other GEM state, we need to nerf those
pointers before that state is freed during drm_gem_release(). We need to
move i915_gem_context_close() from the postclose callback to the
preclose.
In particular, debugfs likes to peek into the GEM contexts, and from
there peek
Since the debugfs may peek into the GEM contexts as the corresponding
client/fd is being closed, we may try and follow a dangling pointer.
However, the context closure itself is serialised with the ctx->mutex,
so if we hold that mutex as we inspect the state coupled in the context,
we know the poin
An unfortunate sequence of events, but it turns out there is a valid
usecase for being able to free/decouple the driver objects before they
are freed by the DRM core. In particular, if we have a pointer into a
drm core object from inside a driver object, that pointer needs to be
nerfed *before* it
On 2020-07-15 13:50, Chris Wilson wrote:
Our timeline lock is our defence against a concurrent execbuf
interrupting our request construction. we need hold it throughout or,
for example, a second thread may interject a relocation request in
between our own relocation request and execution in the
== Series Details ==
Series: drm/i915/selftests: Downgrade severity of CS/SRM frequency scaling tests
URL : https://patchwork.freedesktop.org/series/79814/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8778 -> Patchwork_18230
===
== Series Details ==
Series: drm/i915/selftests: Downgrade severity of CS/SRM frequency scaling tests
URL : https://patchwork.freedesktop.org/series/79814/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.0
Fast mode used, each commit won't be checked separ
Gracefully skip over the failures in the frequency scaling for the
moment, the results are under review.
References: https://gitlab.freedesktop.org/drm/intel/-/issues/1754
Signed-off-by: Chris Wilson
Cc: "Sundaresan, Sujaritha"
Cc: "Ewins, Jon"
Reviewed-by: Sujaritha Sundaresan
---
drivers/gp
On 7/23/2020 6:07 PM, Chris Wilson wrote:
Gracefully skip over the failures in the frequency scaling for the
moment, the results are under review.
Signed-off-by: Chris Wilson
Cc: "Sundaresan, Sujaritha"
Cc: "Ewins, Jon"
---
drivers/gpu/drm/i915/gt/selftest_rps.c | 4 ++--
1 file changed,
== Series Details ==
Series: drm/i915/selftests: Downgrade severity of CS/SRM frequency scaling
URL : https://patchwork.freedesktop.org/series/79805/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8778 -> Patchwork_18229
Sum
On 2020-07-15 13:50, Chris Wilson wrote:
We need to make the DMA allocations used for page directories to be
performed up front so that we can include those allocations in our
memory reservation pass. The downside is that we have to assume the
worst case, even before we know the final layout, a
== Series Details ==
Series: drm/i915/selftests: Downgrade severity of CS/SRM frequency scaling
URL : https://patchwork.freedesktop.org/series/79805/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.0
Fast mode used, each commit won't be checked separately.
Gracefully skip over the failures in the frequency scaling for the
moment, the results are under review.
Signed-off-by: Chris Wilson
Cc: "Sundaresan, Sujaritha"
Cc: "Ewins, Jon"
---
drivers/gpu/drm/i915/gt/selftest_rps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/d
Re-reported.
-Original Message-
From: B S, Karthik
Sent: Thursday, July 23, 2020 1:44 AM
To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana
Subject: Re: ✗ Fi.CI.IGT: failure for Asynchronous flip implementation for i915
(rev5)
Hi,
This looks like an unrelated failure and fa
== Series Details ==
Series: Asynchronous flip implementation for i915 (rev5)
URL : https://patchwork.freedesktop.org/series/74386/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8766_full -> Patchwork_18212_full
Summary
---
Nicolas Boichat writes:
> trace_printk should not be used in production code, replace it
> call with dev_dbg.
>
> Signed-off-by: Nicolas Boichat
>
> ---
>
> Unclear why a trace_printk was used in the first place, it's
> possible that some rate-limiting is necessary here.
>
> drivers/usb/cdns3/g
== Series Details ==
Series: Asynchronous flip implementation for i915 (rev5)
URL : https://patchwork.freedesktop.org/series/74386/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8766_full -> Patchwork_18212_full
Summary
---
== Series Details ==
Series: drm/i915: Remove gen check before calling intel_rps_boost
URL : https://patchwork.freedesktop.org/series/79791/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8778_full -> Patchwork_18228_full
Su
== Series Details ==
Series: drm/i915: Remove gen check before calling intel_rps_boost
URL : https://patchwork.freedesktop.org/series/79791/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8778 -> Patchwork_18228
Summary
== Series Details ==
Series: drm/i915: Remove gen check before calling intel_rps_boost
URL : https://patchwork.freedesktop.org/series/79791/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.0
Fast mode used, each commit won't be checked separately.
__
On 22/07/2020 08:55, Umesh Nerlige Ramappa wrote:
From: Piotr Maciejewski
i915 used to support time based sampling mode which is good for overall
system monitoring, but is not enough for query mode used to measure a
single draw call or dispatch. Gen9-Gen11 are using current i915 perf
implementa
Hi,
This looks like an unrelated failure and false positive.
rev4 of the same series was green.
rev5 only has cosmetic changes to fix checkpatch and sparse warning.
Also, there shouldn't be any changes from this series with regards to
the failing cases.
Thanks and Regards,
Karthik.B.S
On 7/20
Chris Wilson writes:
> It's been a while since gen6_rps_boost() [that only worked on gen6+] was
> replaced by intel_rps_boost() that understood itself when rps was
> active. Since the intel_rps_boost() is gen-agnostic, just call it.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Mika Kuoppala
>
It's been a while since gen6_rps_boost() [that only worked on gen6+] was
replaced by intel_rps_boost() that understood itself when rps was
active. Since the intel_rps_boost() is gen-agnostic, just call it.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_request.c | 7 ++-
1 file ch
63 matches
Mail list logo
