Re: [Intel-gfx] [PATCH 2/3] drm/i915: add syncobj timeline support

2020-08-01 Thread Daniel Vetter
On Fri, Jul 31, 2020 at 9:07 PM Lionel Landwerlin wrote: > > On 31/07/2020 17:30, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2020-07-31 14:45:52) > >> - drm_syncobj_replace_fence(syncobj, fence); > >> + if (eb->fences[n].chain_fence) { > >> +

Re: [Intel-gfx] [RFC PATCH 00/17] Drop uses of pci_read_config_*() return value

2020-08-01 Thread Borislav Petkov
On Sat, Aug 01, 2020 at 01:24:29PM +0200, Saheed O. Bolarinwa wrote: > The return value of pci_read_config_*() may not indicate a device error. > However, the value read by these functions is more likely to indicate > this kind of error. This presents two overlapping ways of reporting > errors and

Re: [Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-08-01 Thread Hans de Goede
Hi Thierry, On 7/30/20 11:26 AM, Thierry Reding wrote: On Wed, Jul 29, 2020 at 11:32:28AM +0200, Hans de Goede wrote: cHi, On 7/29/20 10:23 AM, Andy Shevchenko wrote: On Mon, Jul 27, 2020 at 09:41:20AM +0200, Thierry Reding wrote: On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote

Re: [Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-08-01 Thread Hans de Goede
Hi, On 7/29/20 12:54 PM, Andy Shevchenko wrote: On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: Hi All, Here is v5 of my patch series converting the i915 driver's code for controlling the panel's backlight with an external PWM controller to use the atomic PWM API. See below for

[Intel-gfx] [CI 2/2] drm/i915/gt: Hold context/request reference while breadcrumbs are active

2020-08-01 Thread Chris Wilson
Currently we hold no actual reference to the request nor context while they are attached to a breadcrumb. To avoid freeing the request/context too early, we serialise with cancel-breadcrumbs by taking the irq spinlock in i915_request_retire(). The alternative is to take a reference for a new breadc

[Intel-gfx] [CI 1/2] drm/i915/gt: Move intel_breadcrumbs_arm_irq earlier

2020-08-01 Thread Chris Wilson
Move the __intel_breadcrumbs_arm_irq earlier, next to the disarm_irq, so that we can make use of it in the following patch. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 84 ++--- 1 file changed, 42 insertions(+), 42 de

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] drm/i915/gt: Move intel_breadcrumbs_arm_irq earlier

2020-08-01 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Move intel_breadcrumbs_arm_irq earlier URL : https://patchwork.freedesktop.org/series/80160/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be che

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/gt: Move intel_breadcrumbs_arm_irq earlier

2020-08-01 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Move intel_breadcrumbs_arm_irq earlier URL : https://patchwork.freedesktop.org/series/80160/ State : success == Summary == CI Bug Log - changes from CI_DRM_8827 -> Patchwork_18291 =

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915/gt: Move intel_breadcrumbs_arm_irq earlier

2020-08-01 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Move intel_breadcrumbs_arm_irq earlier URL : https://patchwork.freedesktop.org/series/80160/ State : success == Summary == CI Bug Log - changes from CI_DRM_8827_full -> Patchwork_18291_full ===

[Intel-gfx] [CI] drm/i915/gem: Don't drop the timeline lock during execbuf

2020-08-01 Thread Chris Wilson
Our timeline lock is our defence against a concurrent execbuf interrupting our request construction. we need hold it throughout or, for example, a second thread may interject a relocation request in between our own relocation request and execution in the ring. A second, major benefit, is that it a

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gem: Don't drop the timeline lock during execbuf

2020-08-01 Thread Patchwork
== Series Details == Series: drm/i915/gem: Don't drop the timeline lock during execbuf URL : https://patchwork.freedesktop.org/series/80161/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately. __

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Don't drop the timeline lock during execbuf

2020-08-01 Thread Patchwork
== Series Details == Series: drm/i915/gem: Don't drop the timeline lock during execbuf URL : https://patchwork.freedesktop.org/series/80161/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8828 -> Patchwork_18292 Summary

Re: [Intel-gfx] [CI] drm/i915/gem: Don't drop the timeline lock during execbuf

2020-08-01 Thread Dave Airlie
On Sun, 2 Aug 2020 at 04:29, Chris Wilson wrote: > > Our timeline lock is our defence against a concurrent execbuf > interrupting our request construction. we need hold it throughout or, > for example, a second thread may interject a relocation request in > between our own relocation request and e