[Intel-gfx] [PATCH] drm/managed: Cleanup of unused functions and polishing docs

2020-09-02 Thread Daniel Vetter
Following functions are only used internally, not by drivers: - devm_drm_dev_init Also, now that we have a very slick and polished way to allocate a drm_device with devm_drm_dev_alloc, update all the docs to reflect the new reality. Mostly this consists of deleting old and misleading hints. Two ma

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/managed: Cleanup of unused functions and polishing docs

2020-09-02 Thread Patchwork
== Series Details == Series: drm/managed: Cleanup of unused functions and polishing docs URL : https://patchwork.freedesktop.org/series/81253/ State : warning == Summary == $ dim checkpatch origin/drm-tip aabae0318a42 drm/managed: Cleanup of unused functions and polishing docs -:240: WARNING:N

Re: [Intel-gfx] [RFC] drm/i915/hdcp: Gen12 HDCP 1.4 support over DP MST

2020-09-02 Thread Anshuman Gupta
On 2020-09-01 at 09:57:35 -0400, Sean Paul wrote: > On Tue, Sep 1, 2020 at 8:22 AM Anshuman Gupta > wrote: > > > > Hi Anshuman, > Thank you for sending this along! I have a few comments below. Thanks sean for your comment. I have some doubts over ENCRYPT_STATUS_CHANGE_TIMEOUT_MS may be ram can p

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/managed: Cleanup of unused functions and polishing docs

2020-09-02 Thread Patchwork
== Series Details == Series: drm/managed: Cleanup of unused functions and polishing docs URL : https://patchwork.freedesktop.org/series/81253/ State : success == Summary == CI Bug Log - changes from CI_DRM_8953 -> Patchwork_18431 Summary --

[Intel-gfx] [PATCH] [RFC] drm/kms: Add separate hotplug event call for drm connector

2020-09-02 Thread Mohammed Khajapasha
Add separate hotplug event call for drm connector. Currently from uevent, user space doesn't know which connector got disconnected when multiple connectors are connected to DRM. Signed-off-by: Mohammed Khajapasha --- drivers/gpu/drm/drm_probe_helper.c | 30 ++ drivers

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/kms: Add separate hotplug event call for drm connector

2020-09-02 Thread Patchwork
== Series Details == Series: drm/kms: Add separate hotplug event call for drm connector URL : https://patchwork.freedesktop.org/series/81257/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/

Re: [Intel-gfx] [PATCH 1/2] drm/i915/opregion: add support for mailbox #5 EDID

2020-09-02 Thread Ville Syrjälä
On Tue, Sep 01, 2020 at 04:18:19PM +0300, Jani Nikula wrote: > On Mon, 31 Aug 2020, Jani Nikula wrote: > > On Mon, 31 Aug 2020, Ville Syrjälä wrote: > >> On Fri, Aug 28, 2020 at 09:19:40AM +0300, Jani Nikula wrote: > >>> The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be > >>>

Re: [Intel-gfx] [PATCH] drm/i915: fix regression leading to display audio probe failure on GLK

2020-09-02 Thread Ville Syrjälä
On Tue, Sep 01, 2020 at 06:10:36PM +0300, Kai Vehmanen wrote: > In commit 4f0b4352bd26 ("drm/i915: Extract cdclk requirements checking > to separate function") the order of force_min_cdclk_changed check and > intel_modeset_checks(), was reversed. This broke the mechanism to > immediately force a ne

[Intel-gfx] [PATCH] [RFC] drm/kms: Add separate hotplug event call for drm connector

2020-09-02 Thread Mohammed Khajapasha
Add separate hotplug event call for drm connector. Currently from uevent, user space doesn't know which connector got disconnected when multiple connectors are connected to DRM. Signed-off-by: Mohammed Khajapasha --- drivers/gpu/drm/drm_probe_helper.c | 30 ++ drivers

Re: [Intel-gfx] [PATCH 1/2] drm/i915/opregion: add support for mailbox #5 EDID

2020-09-02 Thread Jani Nikula
On Wed, 02 Sep 2020, Ville Syrjälä wrote: > On Tue, Sep 01, 2020 at 04:18:19PM +0300, Jani Nikula wrote: >> On Mon, 31 Aug 2020, Jani Nikula wrote: >> > On Mon, 31 Aug 2020, Ville Syrjälä wrote: >> >> On Fri, Aug 28, 2020 at 09:19:40AM +0300, Jani Nikula wrote: >> >>> The ACPI OpRegion Mailbox #

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/kms: Add separate hotplug event call for drm connector (rev2)

2020-09-02 Thread Patchwork
== Series Details == Series: drm/kms: Add separate hotplug event call for drm connector (rev2) URL : https://patchwork.freedesktop.org/series/81257/ State : warning == Summary == $ dim checkpatch origin/drm-tip e24fd2c19263 drm/kms: Add separate hotplug event call for drm connector -:40: CHECK

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/kms: Add separate hotplug event call for drm connector (rev2)

2020-09-02 Thread Patchwork
== Series Details == Series: drm/kms: Add separate hotplug event call for drm connector (rev2) URL : https://patchwork.freedesktop.org/series/81257/ State : success == Summary == CI Bug Log - changes from CI_DRM_8954 -> Patchwork_18433 Summ

Re: [Intel-gfx] [PATCH] drm/i915: fix regression leading to display audio probe failure on GLK

2020-09-02 Thread Lisovskiy, Stanislav
On Wed, Sep 02, 2020 at 01:31:09PM +0300, Ville Syrjälä wrote: > On Tue, Sep 01, 2020 at 06:10:36PM +0300, Kai Vehmanen wrote: > > In commit 4f0b4352bd26 ("drm/i915: Extract cdclk requirements checking > > to separate function") the order of force_min_cdclk_changed check and > > intel_modeset_check

Re: [Intel-gfx] [PATCH] drm/i915: fix regression leading to display audio probe failure on GLK

2020-09-02 Thread Ville Syrjälä
On Wed, Sep 02, 2020 at 03:12:01PM +0300, Lisovskiy, Stanislav wrote: > On Wed, Sep 02, 2020 at 01:31:09PM +0300, Ville Syrjälä wrote: > > On Tue, Sep 01, 2020 at 06:10:36PM +0300, Kai Vehmanen wrote: > > > In commit 4f0b4352bd26 ("drm/i915: Extract cdclk requirements checking > > > to separate fun

[Intel-gfx] [PATCH] drm/i915: Remove the old global state stuff

2020-09-02 Thread Ville Syrjala
From: Ville Syrjälä With the dbuf code mostly converted over to the new global state handling we can remove the leftovers of the old global state stuff. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_atomic.c | 39 --- drivers/gpu/drm/i915/display/intel_a

Re: [Intel-gfx] [PATCH] drm/i915: fix regression leading to display audio probe failure on GLK

2020-09-02 Thread Lisovskiy, Stanislav
On Wed, Sep 02, 2020 at 03:17:08PM +0300, Ville Syrjälä wrote: > On Wed, Sep 02, 2020 at 03:12:01PM +0300, Lisovskiy, Stanislav wrote: > > On Wed, Sep 02, 2020 at 01:31:09PM +0300, Ville Syrjälä wrote: > > > On Tue, Sep 01, 2020 at 06:10:36PM +0300, Kai Vehmanen wrote: > > > > In commit 4f0b4352bd2

Re: [Intel-gfx] [PATCH] drm/i915: fix regression leading to display audio probe failure on GLK

2020-09-02 Thread Lisovskiy, Stanislav
On Wed, Sep 02, 2020 at 01:31:09PM +0300, Ville Syrjälä wrote: > On Tue, Sep 01, 2020 at 06:10:36PM +0300, Kai Vehmanen wrote: > > In commit 4f0b4352bd26 ("drm/i915: Extract cdclk requirements checking > > to separate function") the order of force_min_cdclk_changed check and > > intel_modeset_check

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Remove the old global state stuff

2020-09-02 Thread Patchwork
== Series Details == Series: drm/i915: Remove the old global state stuff URL : https://patchwork.freedesktop.org/series/81265/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8954 -> Patchwork_18434 Summary --- **FAILU

Re: [Intel-gfx] [PATCH] drm/i915: fix regression leading to display audio probe failure on GLK

2020-09-02 Thread Ville Syrjälä
On Wed, Sep 02, 2020 at 03:34:50PM +0300, Lisovskiy, Stanislav wrote: > On Wed, Sep 02, 2020 at 03:17:08PM +0300, Ville Syrjälä wrote: > > On Wed, Sep 02, 2020 at 03:12:01PM +0300, Lisovskiy, Stanislav wrote: > > > On Wed, Sep 02, 2020 at 01:31:09PM +0300, Ville Syrjälä wrote: > > > > On Tue, Sep 0

Re: [Intel-gfx] Various problems for the Xen for XenGT code and guide.

2020-09-02 Thread Lv, Zhiyuan
Hi, It is mainly due to the business priority change. XenGT project was originally created for data center usages with XEON E3 servers which have integrated processor graphics. After SkyLake E3, there are no new servers capable of running GVT-g, and Intel future graphics for data center will ha

Re: [Intel-gfx] [PATCH v6 1/7] drm/i915: Add enable/disable flip done and flip done handler

2020-09-02 Thread Karthik B S
On 9/1/2020 4:42 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:45PM +0530, Karthik B S wrote: Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip done interrupt in IER. Enable flip done function is called b

Re: [Intel-gfx] [PATCH v6 2/7] drm/i915: Add support for async flips in I915

2020-09-02 Thread Karthik B S
On 9/1/2020 4:45 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:46PM +0530, Karthik B S wrote: Set the Async Address Update Enable bit in plane ctl when async flip is requested. v2: -Move the Async flip enablement to individual patch (Paulo) v3: -Rebased. v4: -Add separate plane hoo

Re: [Intel-gfx] [PATCH v6 3/7] drm/i915: Add checks specific to async flips

2020-09-02 Thread Karthik B S
On 9/1/2020 4:51 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:47PM +0530, Karthik B S wrote: If flip is requested on any other plane, reject it. Make sure there is no change in fbc, offset and framebuffer modifiers when async flip is requested. If any of these are modified, reject

Re: [Intel-gfx] [PATCH v6 4/7] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips

2020-09-02 Thread Karthik B S
On 9/1/2020 4:53 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:48PM +0530, Karthik B S wrote: Since the flip done event will be sent in the flip_done_handler, no need to add the event to the list and delay it for later. v2: -Moved the async check above vblank_get as it was caus

Re: [Intel-gfx] [PATCH v6 5/7] drm/i915: Add dedicated plane hook for async flip case

2020-09-02 Thread Karthik B S
On 9/1/2020 4:57 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:49PM +0530, Karthik B S wrote: This hook is added to avoid writing other plane registers in case of async flips, so that we do not write the double buffered registers during async surface address update. Signed-off-by: Ka

Re: [Intel-gfx] [PATCH 35/39] drm/i915: Encode fence specific waitqueue behaviour into the wait.flags

2020-09-02 Thread Intel
Hi, Chris, On 8/26/20 3:28 PM, Chris Wilson wrote: Use the wait_queue_entry.flags to denote the special fence behaviour (flattening continuations along fence chains, and for propagating errors) rather than trying to detect ordinary waiters by their functions. Signed-off-by: Chris Wilson ---

Re: [Intel-gfx] [PATCH v6 1/7] drm/i915: Add enable/disable flip done and flip done handler

2020-09-02 Thread Karthik B S
On 9/1/2020 5:10 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:45PM +0530, Karthik B S wrote: Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip done interrupt in IER. Enable flip done function is called b

[Intel-gfx] [PATCH 1/4] drm/i915: split intel_modeset_init() pre/post gem init

2020-09-02 Thread Jani Nikula
Turn current intel_modeset_init() to a pre-gem init function, and add a new intel_modeset_init() function and move all post-gem modeset init there, in the correct layer. No functional changes. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 28 +++

[Intel-gfx] [PATCH 0/4] drm/i915: modeset probe cleanup

2020-09-02 Thread Jani Nikula
Try to cleanup modeset probe and driver remove paths. Based on old patches, removed old reviewed-by's due to changes. BR, Jani. Jani Nikula (4): drm/i915: split intel_modeset_init() pre/post gem init drm/i915: move more display related probe to intel_modeset_init_noirq() drm/i915: spli

[Intel-gfx] [PATCH 3/4] drm/i915: split out intel_modeset_driver_remove_nogem() and simplify

2020-09-02 Thread Jani Nikula
Split out a separate display function for driver remove after gem deinitialization. Note that the sequence is not symmetric with init. However use similar naming as that reflects the deinit sequence. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_displa

[Intel-gfx] [PATCH 4/4] drm/i915: remove the extra modeset init layer

2020-09-02 Thread Jani Nikula
Streamline the modeset init by removing the extra init layer. No functional changes, which means the cleanup path looks hideous. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.c | 63 +++-- 1 file changed, 20 insertions(+), 43 deletions(-) diff --git a

[Intel-gfx] [PATCH 2/4] drm/i915: move more display related probe to intel_modeset_init_noirq()

2020-09-02 Thread Jani Nikula
With the intel_modeset_* probe functions clarified, we can continue with moving more related calls to the right layer: - drm_vblank_init() - intel_bios_init() - intel_vga_register() - intel_csr_ucode_init() Unfortunately, for the time being, we also need to move a call to the *wrong* layer: the p

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: modeset probe cleanup

2020-09-02 Thread Patchwork
== Series Details == Series: drm/i915: modeset probe cleanup URL : https://patchwork.freedesktop.org/series/81267/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/intel_r

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: modeset probe cleanup

2020-09-02 Thread Patchwork
== Series Details == Series: drm/i915: modeset probe cleanup URL : https://patchwork.freedesktop.org/series/81267/ State : success == Summary == CI Bug Log - changes from CI_DRM_8955 -> Patchwork_18435 Summary --- **SUCCESS** No r

Re: [Intel-gfx] [PATCH 4/4] drm/i915: remove the extra modeset init layer

2020-09-02 Thread Ville Syrjälä
On Wed, Sep 02, 2020 at 05:30:23PM +0300, Jani Nikula wrote: > Streamline the modeset init by removing the extra init layer. > > No functional changes, which means the cleanup path looks hideous. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.c | 63 +++

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: fix regression leading to display audio probe failure on GLK

2020-09-02 Thread Patchwork
== Series Details == Series: drm/i915: fix regression leading to display audio probe failure on GLK URL : https://patchwork.freedesktop.org/series/81227/ State : success == Summary == CI Bug Log - changes from CI_DRM_8951_full -> Patchwork_18429_full ===

Re: [Intel-gfx] Various problems for the Xen for XenGT code and guide.

2020-09-02 Thread Jason Long
Why not new XenGT for new GPU? Intel migrated to the KVM? On Wednesday, September 2, 2020, 05:19:18 PM GMT+4:30, Lv, Zhiyuan wrote: Hi, It is mainly due to the business priority change. XenGT project was originally created for data center usages with XEON E3 servers which have integ

Re: [Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_ENABLE register lookup

2020-09-02 Thread Srivatsa, Anusha
> -Original Message- > From: Rodrigo Vivi > Sent: Tuesday, September 1, 2020 12:30 PM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_ENABLE register > lookup > > On Tue, Sep 01, 2020 at 11:27:58AM -0700, Anu

Re: [Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_ENABLE register lookup

2020-09-02 Thread Vivi, Rodrigo
> On Sep 2, 2020, at 12:30 PM, Srivatsa, Anusha > wrote: > > > >> -Original Message- >> From: Rodrigo Vivi >> Sent: Tuesday, September 1, 2020 12:30 PM >> To: Srivatsa, Anusha >> Cc: intel-gfx@lists.freedesktop.org >> Subject: Re: [Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_EN

Re: [Intel-gfx] [Regression] "drm/i915: Implement display w/a #1143" breaks HDMI on ASUS GL552VW

2020-09-02 Thread Kai-Heng Feng
> On Aug 26, 2020, at 21:05, Ville Syrjälä > wrote: > > On Wed, Aug 26, 2020 at 12:40:15PM +0800, Kai-Heng Feng wrote: >> Hi, >> >>> On Aug 25, 2020, at 02:46, Runyan, Arthur J >>> wrote: >>> >>> I remember some strangeness about the blnclegdisbl. I'll see if I can dig >>> up some more.