Re: [Intel-gfx] [PATCH v2] drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()

2020-09-10 Thread Zhenyu Wang
On 2020.09.08 20:11:21 +0200, Alejandro Sior wrote: > In the function intel_vgpu_reg_rw_edid of kvmgt.c, pos can be equal > to NULL for GPUs that do not properly support EDID. In those cases, when > pos gets passed to the handle_edid functions, it gets added a short offset > then it's dereferenced

[Intel-gfx] dg1 flag for userspace to allocate contig resources

2020-09-10 Thread Dave Airlie
I've just been looking at the current DG1 uapi, and I can't see any flag to allow userspace to upfront say it was a contiguous vram BO. I think you'd really want this for scanout, since otherwise you'll have to migrate any non-contig to contig when it transitions to scanout, and cause an extra

Re: [Intel-gfx] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Joe Perches
On Thu, 2020-09-10 at 15:21 +0100, Robin Murphy wrote: > On 2020-09-09 21:06, Joe Perches wrote: > > fallthrough to a separate case/default label break; isn't very readable. > > > > Convert pseudo-keyword fallthrough; statements to a simple break; when > > the next label is case or default and

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4)

2020-09-10 Thread Patchwork
== Series Details == Series: drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4) URL : https://patchwork.freedesktop.org/series/81150/ State : success == Summary == CI Bug Log - changes from CI_DRM_8996_full -> Patchwork_18479_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4)

2020-09-10 Thread Patchwork
== Series Details == Series: drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4) URL : https://patchwork.freedesktop.org/series/81150/ State : success == Summary == CI Bug Log - changes from CI_DRM_8996 -> Patchwork_18479 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove the old global state stuff (rev2)

2020-09-10 Thread Patchwork
== Series Details == Series: drm/i915: Remove the old global state stuff (rev2) URL : https://patchwork.freedesktop.org/series/81265/ State : success == Summary == CI Bug Log - changes from CI_DRM_8995_full -> Patchwork_18478_full Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4)

2020-09-10 Thread Patchwork
== Series Details == Series: drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4) URL : https://patchwork.freedesktop.org/series/81150/ State : warning == Summary == $ dim checkpatch origin/drm-tip dac234339c17 drm/i915/pll: Centralize PLL_ENABLE register lookup -:38: CHECK:BRACES:

[Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_ENABLE register lookup

2020-09-10 Thread Anusha Srivatsa
We currenty check for platform at multiple parts in the driver to grab the correct PLL. Let us begin to centralize it through a helper function. v2: s/intel_get_pll_enable_reg()/intel_combo_pll_enable_reg() (Ville) v3: Clean up combo_pll_disable() (Rodrigo) v4: s/dev_priv/i915 (Jani) Move

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove the old global state stuff (rev2)

2020-09-10 Thread Patchwork
== Series Details == Series: drm/i915: Remove the old global state stuff (rev2) URL : https://patchwork.freedesktop.org/series/81265/ State : success == Summary == CI Bug Log - changes from CI_DRM_8995 -> Patchwork_18478 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Fix an error code i915_gem_object_copy_blt()

2020-09-10 Thread Mika Kuoppala
Dan Carpenter writes: > This code should use "vma[1]" instead of "vma". The "vma" is a variable > is a valid pointer. Not quite getting the last sentence with my non native english parser. "vma" is array would make sense. > > Fixes: 6b05030496f7 ("drm/i915: Convert

Re: [Intel-gfx] [PATCH v2 10/18] drm/dp: Add drm_dp_downstream_{min, max}_tmds_clock()

2020-09-10 Thread Lyude Paul
On Thu, 2020-09-10 at 16:55 +0300, Ville Syrjälä wrote: > On Tue, Sep 08, 2020 at 02:08:17PM -0400, Lyude Paul wrote: > > On Fri, 2020-09-04 at 14:53 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Add helpers to get the TMDS clock limits for HDMI/DVI downstream > > >

Re: [Intel-gfx] [PATCH v2 07/18] drm/dp: Pimp drm_dp_downstream_max_bpc()

2020-09-10 Thread Lyude Paul
On Thu, 2020-09-10 at 17:46 +0300, Ville Syrjälä wrote: > On Tue, Sep 08, 2020 at 01:51:56PM -0400, Lyude Paul wrote: > > On Fri, 2020-09-04 at 14:53 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Deal with more cases in drm_dp_downstream_max_bpc(): > > > - DPCD 1.0 ->

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Reduce INTEL_DISPLAY_ENABLED to just removing the outputs (rev3)

2020-09-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Reduce INTEL_DISPLAY_ENABLED to just removing the outputs (rev3) URL : https://patchwork.freedesktop.org/series/81507/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8995_full -> Patchwork_18476_full

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Return head pages from find_*_entry

2020-09-10 Thread Patchwork
== Series Details == Series: Return head pages from find_*_entry URL : https://patchwork.freedesktop.org/series/81557/ State : failure == Summary == Applying: mm: Factor find_get_incore_page out of mincore_page Applying: mm: Use find_get_incore_page in memcontrol Applying: mm: Optimise

[Intel-gfx] [PATCH v2 2/8] mm: Use find_get_incore_page in memcontrol

2020-09-10 Thread Matthew Wilcox (Oracle)
The current code does not protect against swapoff of the underlying swap device, so this is a bug fix as well as a worthwhile reduction in code complexity. Signed-off-by: Matthew Wilcox (Oracle) --- mm/memcontrol.c | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-)

[Intel-gfx] [PATCH v2 3/8] mm: Optimise madvise WILLNEED

2020-09-10 Thread Matthew Wilcox (Oracle)
Instead of calling find_get_entry() for every page index, use an XArray iterator to skip over NULL entries, and avoid calling get_page(), because we only want the swap entries. Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Johannes Weiner --- mm/madvise.c | 21 - 1 file

[Intel-gfx] [PATCH v2 6/8] mm: Convert find_get_entry to return the head page

2020-09-10 Thread Matthew Wilcox (Oracle)
There are only four callers remaining of find_get_entry(). get_shadow_from_swap_cache() only wants to see shadow entries and doesn't care about which page is returned. Push the find_subpage() call into find_lock_entry(), find_get_incore_page() and pagecache_get_page(). Signed-off-by: Matthew

[Intel-gfx] [PATCH v2 4/8] proc: Optimise smaps for shmem entries

2020-09-10 Thread Matthew Wilcox (Oracle)
Avoid bumping the refcount on pages when we're only interested in the swap entries. Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Johannes Weiner --- fs/proc/task_mmu.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index

[Intel-gfx] [PATCH v2 7/8] mm/shmem: Return head page from find_lock_entry

2020-09-10 Thread Matthew Wilcox (Oracle)
Convert shmem_getpage_gfp() (the only remaining caller of find_lock_entry()) to cope with a head page being returned instead of the subpage for the index. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 9 + mm/filemap.c| 25 +++--

[Intel-gfx] [PATCH v2 5/8] i915: Use find_lock_page instead of find_lock_entry

2020-09-10 Thread Matthew Wilcox (Oracle)
i915 does not want to see value entries. Switch it to use find_lock_page() instead, and remove the export of find_lock_entry(). Move find_lock_entry() and find_get_entry() to mm/internal.h to discourage any future use. Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Johannes Weiner ---

[Intel-gfx] [PATCH v2 1/8] mm: Factor find_get_incore_page out of mincore_page

2020-09-10 Thread Matthew Wilcox (Oracle)
Provide this functionality from the swap cache. It's useful for more than just mincore(). Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/swap.h | 7 +++ mm/mincore.c | 28 ++-- mm/swap_state.c | 32 3 files

[Intel-gfx] [PATCH v2 0/8] Return head pages from find_*_entry

2020-09-10 Thread Matthew Wilcox (Oracle)
This patch series started out as part of the THP patch set, but it has some nice effects along the way and it seems worth splitting it out and submitting separately. Currently find_get_entry() and find_lock_entry() return the page corresponding to the requested index, but the first thing most

[Intel-gfx] [PATCH v2 8/8] mm: Add find_lock_head

2020-09-10 Thread Matthew Wilcox (Oracle)
Add a new FGP_HEAD flag which avoids calling find_subpage() and add a convenience wrapper for it. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 32 ++-- mm/filemap.c| 9 ++--- 2 files changed, 32 insertions(+), 9 deletions(-)

[Intel-gfx] ✓ Fi.CI.IGT: success for Fixes for incoming smarter IOMMU (rev2)

2020-09-10 Thread Patchwork
== Series Details == Series: Fixes for incoming smarter IOMMU (rev2) URL : https://patchwork.freedesktop.org/series/81552/ State : success == Summary == CI Bug Log - changes from CI_DRM_8995_full -> Patchwork_18475_full Summary ---

Re: [Intel-gfx] [PATCH v3 6/7] drm: Validate encoder->possible_crtcs

2020-09-10 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: amd-gfx On Behalf Of > Daniel Vetter > Sent: Monday, September 7, 2020 3:15 AM > To: Jan Kiszka ; amd-gfx list g...@lists.freedesktop.org>; Wentland, Harry ; > Kazlauskas, Nicholas > Cc: dri-devel ; intel-gfx g...@lists.freedesktop.org>;

Re: [Intel-gfx] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Nicolas.Ferre
Joe, Please drop this chunk: it's a successive controller version number which are all backward compatible with "fallthrough" on each case so removing from this last one makes it inconsistent. In sort: NACK for atmel-mci. Best regards, Nicolas On 09/09/2020 at 22:06, Joe Perches wrote: >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix inconsistent IS_ERR and PTR_ERR

2020-09-10 Thread Patchwork
== Series Details == Series: drm/i915: Fix inconsistent IS_ERR and PTR_ERR URL : https://patchwork.freedesktop.org/series/81554/ State : success == Summary == CI Bug Log - changes from CI_DRM_8995_full -> Patchwork_18474_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Reduce INTEL_DISPLAY_ENABLED to just removing the outputs (rev3)

2020-09-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Reduce INTEL_DISPLAY_ENABLED to just removing the outputs (rev3) URL : https://patchwork.freedesktop.org/series/81507/ State : success == Summary == CI Bug Log - changes from CI_DRM_8995 -> Patchwork_18476

Re: [Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_ENABLE register lookup

2020-09-10 Thread Srivatsa, Anusha
> -Original Message- > From: Jani Nikula > Sent: Thursday, September 10, 2020 6:31 AM > To: Srivatsa, Anusha ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_ENABLE register > lookup > > On Tue, 08 Sep 2020, Anusha Srivatsa wrote: >

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: disable all display features when no display (rev2)

2020-09-10 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: disable all display features when no display (rev2) URL : https://patchwork.freedesktop.org/series/81541/ State : success == Summary == CI Bug Log - changes from CI_DRM_8995_full -> Patchwork_18472_full

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes for incoming smarter IOMMU (rev2)

2020-09-10 Thread Patchwork
== Series Details == Series: Fixes for incoming smarter IOMMU (rev2) URL : https://patchwork.freedesktop.org/series/81552/ State : success == Summary == CI Bug Log - changes from CI_DRM_8995 -> Patchwork_18475 Summary ---

[Intel-gfx] [PATCH v2 2/2] drm/i915: Reduce INTEL_DISPLAY_ENABLED to just treat outputs as disconnected

2020-09-10 Thread Ville Syrjala
From: Ville Syrjälä Since the display hardware is all there even when INTEL_DISPLAY_ENABLED return false we have to be capable of shutting it down cleanly so as to not anger the hw. To that end let's reduce the effect of !INTEL_DISPLAY_ENABLE to just treating all outputs as disconnected. Should

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix inconsistent IS_ERR and PTR_ERR

2020-09-10 Thread Patchwork
== Series Details == Series: drm/i915: Fix inconsistent IS_ERR and PTR_ERR URL : https://patchwork.freedesktop.org/series/81554/ State : success == Summary == CI Bug Log - changes from CI_DRM_8995 -> Patchwork_18474 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Reduce INTEL_DISPLAY_ENABLED to just removing the outputs (rev2)

2020-09-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Reduce INTEL_DISPLAY_ENABLED to just removing the outputs (rev2) URL : https://patchwork.freedesktop.org/series/81507/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8995 -> Patchwork_18473

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Add a vblank wait for FBC activation within same frame

2020-09-10 Thread Patchwork
== Series Details == Series: drm/i915/display: Add a vblank wait for FBC activation within same frame URL : https://patchwork.freedesktop.org/series/81550/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8994_full -> Patchwork_18470_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: disable all display features when no display (rev2)

2020-09-10 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: disable all display features when no display (rev2) URL : https://patchwork.freedesktop.org/series/81541/ State : success == Summary == CI Bug Log - changes from CI_DRM_8995 -> Patchwork_18472

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: disable all display features when no display (rev2)

2020-09-10 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: disable all display features when no display (rev2) URL : https://patchwork.freedesktop.org/series/81541/ State : warning == Summary == $ dim checkpatch origin/drm-tip 744b4488a267 drm/i915: disable all display features when

[Intel-gfx] [PATCH v2] drm/i915: Fix DMA mapped scatterlist lookup

2020-09-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As the previous patch fixed the places where we walk the whole scatterlist for DMA addresses, this patch fixes the random lookup functionality. To achieve this we have to add a second lookup iterator and add a i915_gem_object_get_sg_dma helper, to be used analoguous to

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: Kill unused savePCH_PORT_HOTPLUG (rev2)

2020-09-10 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Kill unused savePCH_PORT_HOTPLUG (rev2) URL : https://patchwork.freedesktop.org/series/81461/ State : success == Summary == CI Bug Log - changes from CI_DRM_8994_full -> Patchwork_18469_full

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes for incoming smarter IOMMU

2020-09-10 Thread Patchwork
== Series Details == Series: Fixes for incoming smarter IOMMU URL : https://patchwork.freedesktop.org/series/81552/ State : success == Summary == CI Bug Log - changes from CI_DRM_8995 -> Patchwork_18471 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH v2 07/18] drm/dp: Pimp drm_dp_downstream_max_bpc()

2020-09-10 Thread Ville Syrjälä
On Tue, Sep 08, 2020 at 01:51:56PM -0400, Lyude Paul wrote: > On Fri, 2020-09-04 at 14:53 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Deal with more cases in drm_dp_downstream_max_bpc(): > > - DPCD 1.0 -> assume 8bpc for non-DP > > - DPCD 1.1+ DP (or DP++ with DP sink) -> allow

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes for incoming smarter IOMMU

2020-09-10 Thread Patchwork
== Series Details == Series: Fixes for incoming smarter IOMMU URL : https://patchwork.freedesktop.org/series/81552/ State : warning == Summary == $ dim checkpatch origin/drm-tip 47b38f77a065 drm/i915: Fix DMA mapped scatterlist walks 1f4eba21c445 drm/i915: Fix DMA mapped scatterlist lookup

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix slightly botched merge in __reloc_entry_gpu

2020-09-10 Thread Patchwork
== Series Details == Series: drm/i915: Fix slightly botched merge in __reloc_entry_gpu URL : https://patchwork.freedesktop.org/series/81549/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8994_full -> Patchwork_18468_full

Re: [Intel-gfx] [PATCH] drm/i915/display: Add a vblank wait for FBC activation within same frame

2020-09-10 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjälä > Sent: Thursday, September 10, 2020 7:22 PM > To: Shankar, Uma > Cc: Jani Nikula ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Add a vblank wait for FBC > activation within same frame > > On Thu, Sep

Re: [Intel-gfx] [PATCH v2 10/18] drm/dp: Add drm_dp_downstream_{min, max}_tmds_clock()

2020-09-10 Thread Ville Syrjälä
On Tue, Sep 08, 2020 at 02:08:17PM -0400, Lyude Paul wrote: > On Fri, 2020-09-04 at 14:53 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Add helpers to get the TMDS clock limits for HDMI/DVI downstream > > facing ports. > > > > Signed-off-by: Ville Syrjälä > > --- > >

Re: [Intel-gfx] [PATCH] drm/i915/display: Add a vblank wait for FBC activation within same frame

2020-09-10 Thread Ville Syrjälä
On Thu, Sep 10, 2020 at 01:42:23PM +, Shankar, Uma wrote: > > > > -Original Message- > > From: Jani Nikula > > Sent: Thursday, September 10, 2020 7:04 PM > > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Add a vblank wait

Re: [Intel-gfx] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index e32ef3f01fe8..b13b1cbcac29 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct > pci_device_id *id)

Re: [Intel-gfx] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Keith Busch
On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: > diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c > index eea0f453cfb6..8aac5bc60f4c 100644 > --- a/crypto/tcrypt.c > +++ b/crypto/tcrypt.c > @@ -2464,7 +2464,7 @@ static int do_test(const char *alg, u32 type, u32 mask, > int m, u32

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix DMA mapped scatterlist lookup

2020-09-10 Thread Tom Murphy
This patch series fixes the issue I was having. I tested it with my patch set ("[PATCH V2 0/5] Convert the intel iommu driver to the dma-iommu api") applied, excluding the last patch in that series which disables the coalescing. So once your patch set is merged we should be good to convert the

Re: [Intel-gfx] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Mauro Carvalho Chehab
Em Wed, 09 Sep 2020 13:06:39 -0700 Joe Perches escreveu: > fallthrough to a separate case/default label break; isn't very readable. > > Convert pseudo-keyword fallthrough; statements to a simple break; when > the next label is case or default and the only statement in the next > label block is

Re: [Intel-gfx] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Ilya Dryomov
On Wed, Sep 9, 2020 at 10:10 PM Joe Perches wrote: > > fallthrough to a separate case/default label break; isn't very readable. > > Convert pseudo-keyword fallthrough; statements to a simple break; when > the next label is case or default and the only statement in the next > label block is break;

Re: [Intel-gfx] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Steffen Maier
On 9/9/20 10:06 PM, Joe Perches wrote: fallthrough to a separate case/default label break; isn't very readable. Convert pseudo-keyword fallthrough; statements to a simple break; when the next label is case or default and the only statement in the next label block is break; Found using: $

Re: [Intel-gfx] [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api

2020-09-10 Thread Tom Murphy
On Thu, 10 Sep 2020 at 14:33, Tom Murphy wrote: > > On Wed, 9 Sep 2020 at 13:56, Tvrtko Ursulin > wrote: > > > > > > On 09/09/2020 10:16, Tvrtko Ursulin wrote: > > > On 08/09/2020 23:43, Tom Murphy wrote: > > >> On Tue, 8 Sep 2020 at 16:56, Tvrtko Ursulin > > >> wrote: > > >>> On 08/09/2020

Re: [Intel-gfx] [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api

2020-09-10 Thread Tom Murphy
On Wed, 9 Sep 2020 at 13:56, Tvrtko Ursulin wrote: > > > On 09/09/2020 10:16, Tvrtko Ursulin wrote: > > On 08/09/2020 23:43, Tom Murphy wrote: > >> On Tue, 8 Sep 2020 at 16:56, Tvrtko Ursulin > >> wrote: > >>> On 08/09/2020 16:44, Logan Gunthorpe wrote: > On 2020-09-08 9:28 a.m., Tvrtko

[Intel-gfx] [PATCH][next] drm/i915: Fix inconsistent IS_ERR and PTR_ERR

2020-09-10 Thread Gustavo A. R. Silva
Fix inconsistent IS_ERR and PTR_ERR in i915_gem_object_copy_blt(). The proper pointer to be passed as argument to PTR_ERR() is vma[1]. This bug was detected with the help of Coccinelle. Fixes: 6b05030496f7 ("drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2.")

Re: [Intel-gfx] [PATCH] drm/i915/display: Add a vblank wait for FBC activation within same frame

2020-09-10 Thread Shankar, Uma
> -Original Message- > From: Jani Nikula > Sent: Thursday, September 10, 2020 7:04 PM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Add a vblank wait for FBC > activation within same frame > > On Thu, 10 Sep 2020, Uma Shankar

Re: [Intel-gfx] i915: boot/load regression since Linux v5.7-rc1 on Iris Pro (Crystal Well)

2020-09-10 Thread Jani Nikula
On Wed, 02 Sep 2020, Peter Vollmer wrote: > Hi, > > since kernel v5.7-rc1 my graphical output hangs on boot or if the i915 > module is blacklisted on modprobe. > I've already found and extended a bugzilla > https://bugzilla.kernel.org/show_bug.cgi?id=208737 > > But sadly there has been little

Re: [Intel-gfx] [PATCH] drm/i915/display: Add a vblank wait for FBC activation within same frame

2020-09-10 Thread Jani Nikula
On Thu, 10 Sep 2020, Uma Shankar wrote: > Add a vblank wait when fbc activation request comes for the > same frame on TGL. This helps fix underrun related to fbc. > > Signed-off-by: Uma Shankar > --- > drivers/gpu/drm/i915/display/intel_fbc.c | 13 +++-- > 1 file changed, 11

Re: [Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_ENABLE register lookup

2020-09-10 Thread Jani Nikula
On Tue, 08 Sep 2020, Anusha Srivatsa wrote: > We currenty check for platform at multiple parts in the driver > to grab the correct PLL. Let us begin to centralize it through a > helper function. > > v2: s/intel_get_pll_enable_reg()/intel_combo_pll_enable_reg() (Ville) > > v3: Clean up

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Add a vblank wait for FBC activation within same frame

2020-09-10 Thread Patchwork
== Series Details == Series: drm/i915/display: Add a vblank wait for FBC activation within same frame URL : https://patchwork.freedesktop.org/series/81550/ State : success == Summary == CI Bug Log - changes from CI_DRM_8994 -> Patchwork_18470

Re: [Intel-gfx] [PATCH] drm/i915: Disable frontbuffer tracking

2020-09-10 Thread Jani Nikula
On Tue, 08 Sep 2020, Animesh Manna wrote: > From: Maarten Lankhorst > The "why" would go here. > Signed-off-by: Maarten Lankhorst Please add your own Signed-off-by when you send someone else's patches. BR, Jani. > --- > drivers/gpu/drm/i915/display/intel_frontbuffer.c | 6 ++ > 1 file

Re: [Intel-gfx] [PATCH] drm/i915: Nuke dpio_phy_iosf_port[]

2020-09-10 Thread Jani Nikula
On Mon, 07 Sep 2020, Ville Syrjala wrote: > From: Ville Syrjälä > > There's no real reason to stash away the DPIO PHY IOSF sideband port > numbers for VLV/CHV. Just compute them at runtime in the sideband code. > > Gets rid of the oddball intel_init_dpio() function from the high level > init

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix an error code i915_gem_object_copy_blt()

2020-09-10 Thread Patchwork
== Series Details == Series: drm/i915: Fix an error code i915_gem_object_copy_blt() URL : https://patchwork.freedesktop.org/series/81545/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8994_full -> Patchwork_18467_full

Re: [Intel-gfx] [PATCH v1 03/12] drm/i915: vgpu pv command buffer transport protocol

2020-09-10 Thread Jani Nikula
On Sat, 05 Sep 2020, Xiaolin Zhang wrote: > based on the common shared memory, vgpu pv command transport buffer (CTB) > protocol is implemented which is a simple pv command buffer ring with pv > command descriptor used to perform guest-2-gvt single direction commucation > between guest and host

Re: [Intel-gfx] [PATCH v1 02/12] drm/i915: vgpu shared memory setup for pv support

2020-09-10 Thread Jani Nikula
On Sat, 05 Sep 2020, Xiaolin Zhang wrote: > To support vgpu pv features, a common shared memory is setup used for > communication and data exchange between guest and host GVTg to reduce > data access overhead and trap cost. > > guest i915 will allocate this common memory (1 page size) and then

Re: [Intel-gfx] [PATCH v1 01/12] drm/i915: introduced vgpu pv capability

2020-09-10 Thread Jani Nikula
On Sat, 05 Sep 2020, Xiaolin Zhang wrote: > to enable vgpu pv feature, pv capability is introduced for guest by > new pv_caps member in struct i915_virtual_gpu and for host GVT by > new pv_caps register in struct vgt_if. > > both of them are used to control different pv feature support in each >

Re: [Intel-gfx] [PATCH v1 01/12] drm/i915: introduced vgpu pv capability

2020-09-10 Thread Jani Nikula
On Sat, 05 Sep 2020, Xiaolin Zhang wrote: > to enable vgpu pv feature, pv capability is introduced for guest by > new pv_caps member in struct i915_virtual_gpu and for host GVT by > new pv_caps register in struct vgt_if. > > both of them are used to control different pv feature support in each >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Kill unused savePCH_PORT_HOTPLUG (rev2)

2020-09-10 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Kill unused savePCH_PORT_HOTPLUG (rev2) URL : https://patchwork.freedesktop.org/series/81461/ State : success == Summary == CI Bug Log - changes from CI_DRM_8994 -> Patchwork_18469

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix slightly botched merge in __reloc_entry_gpu

2020-09-10 Thread Patchwork
== Series Details == Series: drm/i915: Fix slightly botched merge in __reloc_entry_gpu URL : https://patchwork.freedesktop.org/series/81549/ State : success == Summary == CI Bug Log - changes from CI_DRM_8994 -> Patchwork_18468 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix slightly botched merge in __reloc_entry_gpu

2020-09-10 Thread Patchwork
== Series Details == Series: drm/i915: Fix slightly botched merge in __reloc_entry_gpu URL : https://patchwork.freedesktop.org/series/81549/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3920ee5ddfb9 drm/i915: Fix slightly botched merge in __reloc_entry_gpu -:27:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix an error code i915_gem_object_copy_blt()

2020-09-10 Thread Patchwork
== Series Details == Series: drm/i915: Fix an error code i915_gem_object_copy_blt() URL : https://patchwork.freedesktop.org/series/81545/ State : success == Summary == CI Bug Log - changes from CI_DRM_8994 -> Patchwork_18467 Summary

[Intel-gfx] [PATCH 1/2] drm/i915: Fix DMA mapped scatterlist walks

2020-09-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When walking DMA mapped scatterlists sg_dma_len has to be used since it can be different (coalesced) from the backing store entry. This also means we have to end the walk when encountering a zero length DMA entry and cannot rely on the normal sg list end marker. Both

[Intel-gfx] [PATCH 0/2] Fixes for incoming smarter IOMMU

2020-09-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin There are incoming improvements to Intel IOMMU code to allow sg table coalescing on map operations. We do not handle that well (we assume 1:1 between backing store and DMA mapped entries) so this series is an attempt to improve this area and get ready for those changes.

[Intel-gfx] [PATCH 2/2] drm/i915: Fix DMA mapped scatterlist lookup

2020-09-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As the previous patch fixed the places where we walk the whole scatterlist for DMA addresses, this patch fixes the random lookup functionality. To achieve this we have to add a second lookup iterator and add a i915_gem_object_get_sg_dma helper, to be used analoguous to

[Intel-gfx] [PATCH] drm/i915/display: Add a vblank wait for FBC activation within same frame

2020-09-10 Thread Uma Shankar
Add a vblank wait when fbc activation request comes for the same frame on TGL. This helps fix underrun related to fbc. Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_fbc.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

Re: [Intel-gfx] [PATCH] drm/i915: Fix slightly botched merge in __reloc_entry_gpu

2020-09-10 Thread Ville Syrjälä
On Thu, Sep 10, 2020 at 01:12:25PM +0200, Maarten Lankhorst wrote: > This function should be an int, not a bool. > > Presumably because we had the same 2 reverts in a slightly different > way, git got confused. > > Thanks to Dan for reporting. :) > > Signed-off-by: Maarten Lankhorst >

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915: disable all display features when no display

2020-09-10 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: disable all display features when no display URL : https://patchwork.freedesktop.org/series/81541/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8992_full -> Patchwork_18466_full

[Intel-gfx] [PATCH] drm/i915: Fix slightly botched merge in __reloc_entry_gpu

2020-09-10 Thread Maarten Lankhorst
This function should be an int, not a bool. Presumably because we had the same 2 reverts in a slightly different way, git got confused. Thanks to Dan for reporting. :) Signed-off-by: Maarten Lankhorst Reported-by: Dan Carpenter Cc: Dave Airlie ---

Re: [Intel-gfx] [PATCH 3/3] drm/i915: move gmbus restore to i915_restore_display

2020-09-10 Thread Ville Syrjälä
On Thu, Sep 10, 2020 at 12:52:27PM +0300, Jani Nikula wrote: > Logically part of the display restore. > > Note: This has been in place since the introduction of gmbus > support. The gmbus code also does the resets before transfers. Is this > really needed, or a historical accident? I suspect we

Re: [Intel-gfx] [PATCH 2/3] drm/i915: move gen4 GCDGMBUS save/restore to display save/restore

2020-09-10 Thread Ville Syrjälä
On Thu, Sep 10, 2020 at 12:52:26PM +0300, Jani Nikula wrote: > Logically part of the display save/restore. No functional changes. > Somewhat tempted to move this into the gmbus code proper. But we don't have a gmbus resume hook atm so would need to add one. In the meantime: Reviewed-by: Ville

Re: [Intel-gfx] [PATCH 1/3] drm/i915: disable all display features when no display

2020-09-10 Thread Ville Syrjälä
On Thu, Sep 10, 2020 at 12:52:25PM +0300, Jani Nikula wrote: > Disable all display feature flags when there are no pipes i.e. there is > no display. This should help with not having to additionally check for > HAS_DISPLAY() when a feature flag check would suffice. > > Also disable modeset and

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: disable all display features when no display

2020-09-10 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: disable all display features when no display URL : https://patchwork.freedesktop.org/series/81541/ State : success == Summary == CI Bug Log - changes from CI_DRM_8992 -> Patchwork_18466

Re: [Intel-gfx] [PATCH] drm/i915: Fix DMA mapped scatterlist walks

2020-09-10 Thread Tvrtko Ursulin
On 09/09/2020 20:29, Logan Gunthorpe wrote: On 2020-09-09 6:44 a.m., Tvrtko Ursulin wrote: From: Tvrtko Ursulin When walking DMA mapped scatterlists sg_dma_len has to be used since it can be different (coalesced) from the backing store entry. This also means we have to end the walk when

Re: [Intel-gfx] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Matthias Brugger
On 09/09/2020 22:06, Joe Perches wrote: diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c index 09f931d4598c..778be26d329f 100644 --- a/drivers/net/wireless/mediatek/mt7601u/dma.c +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c @@

[Intel-gfx] [PATCH] drm/i915: Fix an error code i915_gem_object_copy_blt()

2020-09-10 Thread Dan Carpenter
This code should use "vma[1]" instead of "vma". The "vma" is a variable is a valid pointer. Fixes: 6b05030496f7 ("drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2.") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/i915/gem/i915_gem_object_blt.c | 2 +- 1 file

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: disable all display features when no display

2020-09-10 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: disable all display features when no display URL : https://patchwork.freedesktop.org/series/81541/ State : warning == Summary == $ dim checkpatch origin/drm-tip e7ece370fe10 drm/i915: disable all display features when no

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Reduce INTEL_DISPLAY_ENABLED to just removing the outputs

2020-09-10 Thread Jani Nikula
On Thu, 10 Sep 2020, Jani Nikula wrote: > On Thu, 10 Sep 2020, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> Having a mode where the display hardware is present but we try >> to pretend it isn't just leads to massive headaches when trying >> to reason what the fallout might be from skipping

[Intel-gfx] [PATCH 3/3] drm/i915: move gmbus restore to i915_restore_display

2020-09-10 Thread Jani Nikula
Logically part of the display restore. Note: This has been in place since the introduction of gmbus support. The gmbus code also does the resets before transfers. Is this really needed, or a historical accident? Cc: Ville Syrjälä Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH 1/3] drm/i915: disable all display features when no display

2020-09-10 Thread Jani Nikula
Disable all display feature flags when there are no pipes i.e. there is no display. This should help with not having to additionally check for HAS_DISPLAY() when a feature flag check would suffice. Also disable modeset and atomic driver features. Cc: Ville Syrjälä Signed-off-by: Jani Nikula

[Intel-gfx] [PATCH 2/3] drm/i915: move gen4 GCDGMBUS save/restore to display save/restore

2020-09-10 Thread Jani Nikula
Logically part of the display save/restore. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_suspend.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_suspend.c

Re: [Intel-gfx] [RFC 0/6] HDCP 2.2 DP MST Support

2020-09-10 Thread Anshuman Gupta
On 2020-09-10 at 14:42:46 +0530, Ramalingam C wrote: > On 2020-09-10 at 13:47:21 +0530, Anshuman Gupta wrote: > > This is RFC proposal to support HDCP 2.2 on DP MST. > > This series is built on below series using the > > common functionality of HDCP stream encryption. > > Before I get into the

Re: [Intel-gfx] [RFC 0/6] HDCP 2.2 DP MST Support

2020-09-10 Thread Ramalingam C
On 2020-09-10 at 13:47:21 +0530, Anshuman Gupta wrote: > This is RFC proposal to support HDCP 2.2 on DP MST. > This series is built on below series using the > common functionality of HDCP stream encryption. Before I get into the series, what is the plan for CI coverage for HDCP DP MST, w.r.t igt

[Intel-gfx] ✗ Fi.CI.BUILD: failure for HDCP 2.2 DP MST Support

2020-09-10 Thread Patchwork
== Series Details == Series: HDCP 2.2 DP MST Support URL : https://patchwork.freedesktop.org/series/81538/ State : failure == Summary == Applying: drm/i915/hdcp: Encapsulate hdcp_port_data to dig_port Using index info to reconstruct a base tree... M

Re: [Intel-gfx] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Felipe Balbi
Hi, Joe Perches writes: > drivers/usb/dwc3/core.c | 2 +- > drivers/usb/gadget/legacy/inode.c | 2 +- > drivers/usb/gadget/udc/pxa25x_udc.c | 4 ++-- > drivers/usb/phy/phy-fsl-usb.c |

[Intel-gfx] [bug report] drm/i915: Use ww pinning for intel_context_create_request()

2020-09-10 Thread Dan Carpenter
Hello Maarten Lankhorst, The patch 8a929c9eb1c2: "drm/i915: Use ww pinning for intel_context_create_request()" from Aug 19, 2020, leads to the following static checker warning: drivers/gpu/drm/i915/gt/intel_context.c:481 intel_context_create_request() error: uninitialized symbol

[Intel-gfx] [bug report] drm/i915: Use per object locking in execbuf, v12.

2020-09-10 Thread Dan Carpenter
Hey Dave, I think this is a bad merge: The patch c43ce12328df: "drm/i915: Use per object locking in execbuf, v12." from Aug 19, 2020, leads to the following static checker warning: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1459 __reloc_entry_gpu() warn: signedness bug

[Intel-gfx] [RFC 5/6] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-09-10 Thread Anshuman Gupta
Add support for HDCP 2.2 DP MST shim callback. This adds existing DP HDCP shim callback for Link Authentication and Encryption and HDCP 2.2 stream encryption callback. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- .../drm/i915/display/intel_display_types.h| 4 +

[Intel-gfx] [RFC 4/6] drm/i915/hdcp: Add HDCP 2.2 stream register

2020-09-10 Thread Anshuman Gupta
Add HDCP 2.2 DP MST HDCP2_STREAM_STATUS and HDCP2_AUTH_STREAM register in i915_reg header. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_reg.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [RFC 3/6] drm/i915/hdcp: Pass connector to check_2_2_link

2020-09-10 Thread Anshuman Gupta
This requires for HDCP 2.2 MST check link. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +-

[Intel-gfx] [RFC 6/6] drm/i915/hdcp: Enable HDCP 2.2 MST support

2020-09-10 Thread Anshuman Gupta
Enable HDCP 2.2 over DP MST. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c

  1   2   >