Re: [Intel-gfx] [PATCH v8 4/8] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips

2020-09-16 Thread Karthik B S
On 9/15/2020 7:37 PM, Ville Syrjälä wrote: On Mon, Sep 14, 2020 at 11:26:29AM +0530, Karthik B S wrote: Since the flip done event will be sent in the flip_done_handler, no need to add the event to the list and delay it for later. v2: -Moved the async check above vblank_get as it was cau

Re: [Intel-gfx] [PATCH v8 3/8] drm/i915: Add checks specific to async flips

2020-09-16 Thread Karthik B S
On 9/15/2020 7:33 PM, Ville Syrjälä wrote: On Mon, Sep 14, 2020 at 11:26:28AM +0530, Karthik B S wrote: If flip is requested on any other plane, reject it. Make sure there is no change in fbc, offset and framebuffer modifiers when async flip is requested. If any of these are modified, reject

Re: [Intel-gfx] [PATCH v8 2/8] drm/i915: Add support for async flips in I915

2020-09-16 Thread Karthik B S
On 9/15/2020 7:18 PM, Ville Syrjälä wrote: On Mon, Sep 14, 2020 at 11:26:27AM +0530, Karthik B S wrote: Set the Async Address Update Enable bit in plane ctl when async flip is requested. v2: -Move the Async flip enablement to individual patch (Paulo) v3: -Rebased. v4: -Add separate plane ho

Re: [Intel-gfx] [PATCH v8 1/8] drm/i915: Add enable/disable flip done and flip done handler

2020-09-16 Thread Karthik B S
On 9/15/2020 7:17 PM, Ville Syrjälä wrote: On Mon, Sep 14, 2020 at 11:26:26AM +0530, Karthik B S wrote: Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip done interrupt in IER. Enable flip done function is called

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/gt: Show engine properties in the pretty printer

2020-09-16 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gt: Show engine properties in the pretty printer URL : https://patchwork.freedesktop.org/series/81727/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gt: Show engine properties in the pretty printer

2020-09-16 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gt: Show engine properties in the pretty printer URL : https://patchwork.freedesktop.org/series/81727/ State : warning == Summary == $ dim checkpatch origin/drm-tip 22a8bb51bc47 drm/i915/gt: Show engine properties in the pretty

Re: [Intel-gfx] [PATCH 0/3] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-16 Thread Daniel Vetter
On Wed, Sep 16, 2020 at 12:48:20PM +0200, Thomas Zimmermann wrote: > Hi > > Am 16.09.20 um 11:37 schrieb Daniel Vetter: > > On Mon, Sep 14, 2020 at 01:25:18PM +0200, Thomas Zimmermann wrote: > >> Dma-buf provides vmap() and vunmap() for retrieving and releasing mappings > >> of dma-buf memory in k

Re: [Intel-gfx] [PATCH v2 21/21] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:58PM +0200, Thomas Zimmermann wrote: > Several GEM and PRIME callbacks have been deprecated in favor of > per-instance GEM object functions. Remove the callbacks as they are > now unused. The only exception is .gem_prime_mmap, which is still > in use by several drivers

Re: [Intel-gfx] [PATCH v2 17/21] drm/virtgpu: Set PRIME export function in struct drm_gem_object_funcs

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:54PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces virtgpu's per-driver PRIME export > function with a per-object function. > > Signed-off-by: Thomas Zimmermann Review

Re: [Intel-gfx] [PATCH v2 13/21] drm/rockchip: Convert to drm_gem_object_funcs

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:50PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in rockchip. The only exception is gem_prime_mmap, > which is no

Re: [Intel-gfx] [PATCH v2 09/21] drm/nouveau: Introduce GEM object functions

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:46PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in nouveau. > > Signed-off-by: Thomas Zimmermann Hm ttm and g

Re: [Intel-gfx] [PATCH v2 08/21] drm/msm: Introduce GEM object funcs

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:45PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in msm. The only exception is gem_prime_mmap, > which is non-tri

Re: [Intel-gfx] [PATCH v2 07/21] drm/mediatek: Introduce GEM object functions

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:44PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in mediatek. The only exception is gem_prime_mmap, > which is no

Re: [Intel-gfx] [PATCH v2 05/21] drm/gma500: Introduce GEM object functions

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:42PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in gma500. > > Signed-off-by: Thomas Zimmermann Reviewed-by:

Re: [Intel-gfx] [PATCH v2 04/21] drm/exynos: Introduce GEM object functions

2020-09-16 Thread Daniel Vetter
On Wed, Sep 16, 2020 at 12:36:28PM +0200, Thomas Zimmermann wrote: > Hi > > Am 16.09.20 um 12:03 schrieb Daniel Vetter: > > On Tue, Sep 15, 2020 at 04:59:41PM +0200, Thomas Zimmermann wrote: > >> GEM object functions deprecate several similar callback interfaces in > >> struct drm_driver. This pat

Re: [Intel-gfx] [PATCH v2 03/21] drm/etnaviv: Introduce GEM object functions

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:40PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in etnaviv. The only exception is gem_prime_mmap, > which is non

[Intel-gfx] [CI 1/2] drm/i915: Initialise outparam for error return from wait_for_register

2020-09-16 Thread Chris Wilson
Just in case the caller passes in 0 for both slow&fast timeouts, make sure we initialise the stack value returned. Add an assert so that we don't make the mistake of passing 0 timeouts for the wait. drivers/gpu/drm/i915/intel_uncore.c:2011 __intel_wait_for_register_fw() error: uninitialized symbo

[Intel-gfx] [CI 2/2] drm/i915/selftests: Push the fake iommu device from the stack to data

2020-09-16 Thread Chris Wilson
Since we store a pointer to the fake iommu device that is allocated on the stack, as soon as we leave the function it goes out of scope and any future dereference is undefined behaviour. Just in case we may need to look at the fake iommu device after initialiation, move the allocation from the stac

Re: [Intel-gfx] [PATCH 0/3] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-16 Thread Thomas Zimmermann
Hi Am 16.09.20 um 11:37 schrieb Daniel Vetter: > On Mon, Sep 14, 2020 at 01:25:18PM +0200, Thomas Zimmermann wrote: >> Dma-buf provides vmap() and vunmap() for retrieving and releasing mappings >> of dma-buf memory in kernel address space. The functions operate with plain >> addresses and the assu

Re: [Intel-gfx] [PATCH v2 04/21] drm/exynos: Introduce GEM object functions

2020-09-16 Thread Thomas Zimmermann
Hi Am 16.09.20 um 12:03 schrieb Daniel Vetter: > On Tue, Sep 15, 2020 at 04:59:41PM +0200, Thomas Zimmermann wrote: >> GEM object functions deprecate several similar callback interfaces in >> struct drm_driver. This patch replaces the per-driver callbacks with >> per-instance callbacks in exynos.

Re: [Intel-gfx] [PATCH v2 04/21] drm/exynos: Introduce GEM object functions

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 04:59:41PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in exynos. The only exception is gem_prime_mmap, > which is non-

[Intel-gfx] [PATCH 3/3] drm/i915/gt: Retire cancelled requests on unload

2020-09-16 Thread Chris Wilson
If we manage to hit the intel_gt_set_wedged_on_fini() while active, i.e. module unload during a stress test, we may cancel the requests but not clean up. This leads to a slow module unload as we wait for something or other to trigger the retirement flushing. Instead if we explicitly cancel then cle

[Intel-gfx] [PATCH 2/3] drm/i915/selftests: Finish pending mock requests on cancellation.

2020-09-16 Thread Chris Wilson
Flush all the pending requests from the mock engine when they are cancelled. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/mock_engine.c | 29 +++ 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/mock_engine.c b/drivers/gpu

[Intel-gfx] [PATCH 1/3] drm/i915/gt: Signal cancelled requests

2020-09-16 Thread Chris Wilson
After marking the requests on an engine as cancelled upon wedging, send any signals for their completions. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 1 + drivers/gpu/drm/i915/gt/intel_ring_submission.c | 1 + 2 files changed, 2 insertions(+) diff --git a/

[Intel-gfx] [PATCH 2/4] drm/i915: Cancel outstanding work after disabling heartbeats on an engine

2020-09-16 Thread Chris Wilson
We only allow persistent requests to remain on the GPU past the closure of their containing context (and process) so long as they are continuously checked for hangs or allow other requests to preempt them, as we need to ensure forward progress of the system. If we allow persistent contexts to remai

[Intel-gfx] [PATCH 4/4] drm/i915/gem: Always test execution status on closing the context

2020-09-16 Thread Chris Wilson
Verify that if a context is active at the time it is closed, that it is either persistent and preemptible (with hangcheck running) or it shall be removed from execution. Fixes: 9a40bddd47ca ("drm/i915/gt: Expose heartbeat interval via sysfs") Testcase: igt/gem_ctx_persistence/heartbeat-close Signe

[Intel-gfx] [PATCH 1/4] drm/i915/gem: Hold request reference for canceling an active context

2020-09-16 Thread Chris Wilson
We have to be very careful while walking the timeline->requests list under the RCU guard, as the requests (and so rq->link) use SLAB_TYPESAFE_BY_RCU and so the requests may be reallocated within an rcu grace period. As the requests are reallocated, they are removed from one list and placed on anoth

[Intel-gfx] [PATCH 3/4] drm/i915/gt: Always send a pulse down the engine after disabling heartbeat

2020-09-16 Thread Chris Wilson
Currently, we check we can send a pulse prior to disabling the heartbeat to verify that we can change the heartbeat, but since we may re-evaluate execution upon changing the heartbeat interval we need another pulse afterwards to refresh execution. Fixes: 9a40bddd47ca ("drm/i915/gt: Expose heartbea

Re: [Intel-gfx] [PATCH 0/3] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-16 Thread Daniel Vetter
On Mon, Sep 14, 2020 at 01:25:18PM +0200, Thomas Zimmermann wrote: > Dma-buf provides vmap() and vunmap() for retrieving and releasing mappings > of dma-buf memory in kernel address space. The functions operate with plain > addresses and the assumption is that the memory can be accessed with load >

Re: [Intel-gfx] [PATCH 2/3] dma-buf: Use struct dma_buf_map in dma_buf_vmap() interfaces

2020-09-16 Thread Daniel Vetter
On Mon, Sep 14, 2020 at 01:25:20PM +0200, Thomas Zimmermann wrote: > This patch updates dma_buf_vmap() and dma-buf's vmap callback to use > struct dma_buf_map. > > The interfaces used to return a buffer address. This address now gets > stored in an instance of the structure that is given as an add

[Intel-gfx] [PATCH 3/3] drm/i915: Reduce GPU error capture mutex hold time

2020-09-16 Thread Chris Wilson
Shrink the hold time for the error capture mutex to just around the acquire/release of the PTE used for reading back the object via the Global GTT. For platforms that do not need the GGTT read back, we can skip the mutex entirely and allow concurrent error capture. Where we do use the GGTT, by rest

[Intel-gfx] [PATCH 1/3] drm/i915/gt: Show engine properties in the pretty printer

2020-09-16 Thread Chris Wilson
When debugging the engine state, include the user properties that may, or may not, have been adjusted by the user/test. For example, vecs0 ... Properties: heartbeat_interval_ms: 2500 [default 2500] max_busywait_duration_ns: 8000 [default 8000]

[Intel-gfx] [PATCH 2/3] drm/i915: Break up error capture compression loops with cond_resched()

2020-09-16 Thread Chris Wilson
As the error capture will compress user buffers as directed to by the user, it can take an arbitrary amount of time and space. Break up the compression loops with a call to cond_resched(), that will allow other processes to schedule (avoiding the soft lockups) and also serve as a warning should we

[Intel-gfx] Fixes that failed to apply to v5.9-rc5

2020-09-16 Thread Jani Nikula
Now that we have drm-intel-gt-next merged, we also get the gt fixes. The following commits failed to cherry-pick: 56f581bad4bf ("drm/i915/gt: Only transfer the virtual context to the new engine if active") b3786b29379c ("drm/i915/gt: Distinguish the virtual breadcrumbs from the irq breadcrumb

Re: [Intel-gfx] [PATCH 2/4] drm/i915/gt: Wait for CSB entries on Tigerlake

2020-09-16 Thread Greg KH
On Wed, Sep 16, 2020 at 09:26:58AM +0100, Chris Wilson wrote: > Quoting Greg KH (2020-09-16 07:33:58) > > On Tue, Sep 15, 2020 at 01:41:48PM +0100, Chris Wilson wrote: > > > On Tigerlake, we are seeing a repeat of commit d8f505311717 > > > ("drm/i915/icl: > > > Forcibly evict stale csb entries") w

Re: [Intel-gfx] [PATCH 2/4] drm/i915/gt: Wait for CSB entries on Tigerlake

2020-09-16 Thread Chris Wilson
Quoting Greg KH (2020-09-16 07:33:58) > On Tue, Sep 15, 2020 at 01:41:48PM +0100, Chris Wilson wrote: > > On Tigerlake, we are seeing a repeat of commit d8f505311717 ("drm/i915/icl: > > Forcibly evict stale csb entries") where, presumably, due to a missing > > Global Observation Point synchronisati

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex

2020-09-16 Thread Tvrtko Ursulin
On 16/09/2020 08:42, Daniel Vetter wrote: On Mon, Sep 14, 2020 at 05:45:09PM +0100, Tvrtko Ursulin wrote: On 23/07/2020 18:21, Chris Wilson wrote: Since the debugfs may peek into the GEM contexts as the corresponding client/fd is being closed, we may try and follow a dangling pointer. Howeve

Re: [Intel-gfx] [PATCH i-g-t v6 00/24] tests/core_hotunplug: Fixes and enhancements

2020-09-16 Thread Janusz Krzysztofik
Hi Lakshmi, On Tue, 2020-09-15 at 15:39 +, Vudum, Lakshminarayana wrote: > Hi Janusz, > > I have filed https://gitlab.freedesktop.org/drm/intel/-/issues/2469 for > igt@core_hotunplug@hotrebind-lateclose failure. > Is it GUC issue? Wow, I thought that issue got hidden behind another one and

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add support for mipi dsi cmd mode (rev11)

2020-09-16 Thread Patchwork
== Series Details == Series: Add support for mipi dsi cmd mode (rev11) URL : https://patchwork.freedesktop.org/series/69290/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9016_full -> Patchwork_18508_full Summary ---

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Nuke force_min_cdclk_changed

2020-09-16 Thread Lisovskiy, Stanislav
On Tue, Jul 14, 2020 at 06:26:26PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Since we now have proper old and new cdclk state we no longer > need to keep this flag to indicate that the force min cdclk has > changed. Instead just check if the old vs. new value are different. > > Signe

Re: [Intel-gfx] [PATCH] drm/i915: Remove the old global state stuff

2020-09-16 Thread Lisovskiy, Stanislav
On Wed, Sep 02, 2020 at 03:21:41PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > With the dbuf code mostly converted over to the new global state > handling we can remove the leftovers of the old global state > stuff. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/displa

Re: [Intel-gfx] [RFC 1/5] drm/i915/dp: Program source OUI on eDP panels

2020-09-16 Thread Jani Nikula
On Tue, 15 Sep 2020, Rodrigo Vivi wrote: > On Tue, Sep 15, 2020 at 01:29:35PM -0400, Lyude Paul wrote: >> Since we're about to start adding support for Intel's magic HDR >> backlight interface over DPCD, we need to ensure we're properly >> programming this field so that Intel specific sink service

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex

2020-09-16 Thread Daniel Vetter
On Mon, Sep 14, 2020 at 05:45:09PM +0100, Tvrtko Ursulin wrote: > > On 23/07/2020 18:21, Chris Wilson wrote: > > Since the debugfs may peek into the GEM contexts as the corresponding > > client/fd is being closed, we may try and follow a dangling pointer. > > However, the context closure itself is

Re: [Intel-gfx] [patch 00/13] preempt: Make preempt count unconditional

2020-09-16 Thread Daniel Vetter
On Tue, Sep 15, 2020 at 7:35 PM Linus Torvalds wrote: > > On Tue, Sep 15, 2020 at 1:39 AM Thomas Gleixner wrote: > > > > OTOH, having a working 'preemptible()' or maybe better named > > 'can_schedule()' check makes tons of sense to make decisions about > > allocation modes or other things. > > No

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Add max plane width for NV12 AUX plane for Gen10+ platforms

2020-09-16 Thread Jani Nikula
On Tue, 15 Sep 2020, Aditya Swarup wrote: > Gen 10+ and Gen11+ platforms specify different max plane width for > planar formats. Add max plane width for GLK and ICL based on > BSpec: 7666 > > Fixes: 372b9ffb5799 ("drm/i915: Fix skl+ max plane width") > Fixes is part of the tags; no blank lines he

Re: [Intel-gfx] [RFC 5/5] drm/dp: Revert "drm/dp: Introduce EDID-based quirks"

2020-09-16 Thread Jani Nikula
On Tue, 15 Sep 2020, Lyude Paul wrote: > This reverts commit 0883ce8146ed6074c76399f4e70dbed788582e12. Originally > these quirks were added because of the issues with using the eDP > backlight interfaces on certain laptop panels, which made it impossible > to properly probe for DPCD backlight supp

<    1   2