Re: [Intel-gfx] remove alloc_vm_area v2

2020-09-25 Thread Andrew Morton
On Thu, 24 Sep 2020 15:58:42 +0200 Christoph Hellwig wrote: > this series removes alloc_vm_area, which was left over from the big > vmalloc interface rework. It is a rather arkane interface, basicaly > the equivalent of get_vm_area + actually faulting in all PTEs in > the allocated area. It

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Update to GuC v49

2020-09-25 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update to GuC v49 URL : https://patchwork.freedesktop.org/series/82113/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9057_full -> Patchwork_18577_full Summary ---

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make intel_{enable, disable}_sagv() static

2020-09-25 Thread Souza, Jose
On Fri, 2020-09-25 at 15:17 +0300, Ville Syrjala wrote: > From: Ville Syrjälä < > ville.syrj...@linux.intel.com > > > > intel_{enable,disable}_sagv() are no longer needed outside the > compilation unit. Make them static. Reviewed-by: José Roberto de Souza > > Signed-off-by: Ville Syrjälä < >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Don't hide the intel_crtc_atomic_check() call

2020-09-25 Thread Souza, Jose
On Fri, 2020-09-25 at 15:17 +0300, Ville Syrjala wrote: > From: Ville Syrjälä < > ville.syrj...@linux.intel.com > > > > Move the intel_crtc_atomic_check() call out from the variable > declarations to a place where we can actually see it. Reviewed-by: José Roberto de Souza > > Signed-off-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Update to GuC v49

2020-09-25 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update to GuC v49 URL : https://patchwork.freedesktop.org/series/82113/ State : success == Summary == CI Bug Log - changes from CI_DRM_9057 -> Patchwork_18577 Summary --- **WARNING**

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/11] mm: update the documentation for vfree (rev2)

2020-09-25 Thread Patchwork
== Series Details == Series: series starting with [01/11] mm: update the documentation for vfree (rev2) URL : https://patchwork.freedesktop.org/series/82063/ State : success == Summary == CI Bug Log - changes from CI_DRM_9057_full -> Patchwork_18576_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Update to GuC v49

2020-09-25 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update to GuC v49 URL : https://patchwork.freedesktop.org/series/82113/ State : warning == Summary == $ dim checkpatch origin/drm-tip ea290b73bdf2 drm/i915/guc: Update to use firmware v49.0.1 -:231: WARNING:LONG_LINE: line length of 103 exceeds 100

[Intel-gfx] [PATCH 2/4] drm/i915/guc: Improved reporting when GuC fails to load

2020-09-25 Thread John . C . Harrison
From: John Harrison Rather than just saying 'GuC failed to load: -110', actually print out the GuC status register and break it down into the individual fields. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 31 --- 1 file changed, 22

[Intel-gfx] [PATCH 4/4] drm/i915/uc: turn on GuC/HuC auto mode by default

2020-09-25 Thread John . C . Harrison
From: Daniele Ceraolo Spurio This will enable HuC loading for Gen11+ by default if the binaries are available on the system. GuC submission still requires explicit enabling by the user. Signed-off-by: Daniele Ceraolo Spurio Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +-

[Intel-gfx] [PATCH 1/4] drm/i915/guc: Update to use firmware v49.0.1

2020-09-25 Thread John . C . Harrison
From: John Harrison The latest GuC firmware includes a number of interface changes that require driver updates to match. * Starting from Gen11, the ID to be provided to GuC needs to contain the engine class in bits [0..2] and the instance in bits [3..6]. NOTE: this patch breaks pointer

[Intel-gfx] [PATCH 0/4] drm/i915/guc: Update to GuC v49

2020-09-25 Thread John . C . Harrison
From: John Harrison Update to the latest GuC firmware and enable by default. Signed-off-by: John Harrison Daniele Ceraolo Spurio (1): drm/i915/uc: turn on GuC/HuC auto mode by default John Harrison (3): drm/i915/guc: Update to use firmware v49.0.1 drm/i915/guc: Improved reporting when

[Intel-gfx] [PATCH 3/4] drm/i915/guc: Clear pointers on free

2020-09-25 Thread John . C . Harrison
From: John Harrison Was hitting null pointers and similar issues when running various module load/unload and inject failure type tests. So clear those pointers down when the objects have been de-allocated. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 1 +

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Finish (de)gamma readout prep bits

2020-09-25 Thread Patchwork
== Series Details == Series: drm/i915: Finish (de)gamma readout prep bits URL : https://patchwork.freedesktop.org/series/82099/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9056_full -> Patchwork_18575_full Summary

Re: [Intel-gfx] [PATCH v3 0/4] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-25 Thread Tomasz Figa
Hi Thomas, On Fri, Sep 25, 2020 at 01:55:57PM +0200, Thomas Zimmermann wrote: > Dma-buf provides vmap() and vunmap() for retriving and releasing mappings > of dma-buf memory in kernel address space. The functions operate with plain > addresses and the assumption is that the memory can be accessed

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add support for DP-HDMI2.1 PCON

2020-09-25 Thread Patchwork
== Series Details == Series: Add support for DP-HDMI2.1 PCON URL : https://patchwork.freedesktop.org/series/82098/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9056_full -> Patchwork_18574_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Make intel_{enable, disable}_sagv() static

2020-09-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Make intel_{enable, disable}_sagv() static URL : https://patchwork.freedesktop.org/series/82096/ State : success == Summary == CI Bug Log - changes from CI_DRM_9056_full -> Patchwork_18573_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for dma-buf: Flag vmap'ed memory as system or I/O memory (rev3)

2020-09-25 Thread Patchwork
== Series Details == Series: dma-buf: Flag vmap'ed memory as system or I/O memory (rev3) URL : https://patchwork.freedesktop.org/series/81647/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9056_full -> Patchwork_18572_full

Re: [Intel-gfx] [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-25 Thread Lyude Paul
On Thu, 2020-09-24 at 17:46 -0600, Kevin Chowski wrote: > cc back a few others who were unintentionally dropped from the thread > earlier. > > Someone (at Google) helped me dig into this a little more and they > found a document titled "eDP Backlight Brightness bit alignment" sent > out for

Re: [Intel-gfx] [PATCH v2 4/6] drm/dp: Add LTTPR helpers

2020-09-25 Thread Imre Deak
On Fri, Sep 25, 2020 at 07:02:47PM +0300, Ville Syrjälä wrote: > On Thu, Sep 24, 2020 at 09:48:03PM +0300, Imre Deak wrote: > > Add the helpers and register definitions needed to read out the common > > and per-PHY LTTPR capabilities and perform link training in the LTTPR > > non-transparent mode.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/11] mm: update the documentation for vfree (rev2)

2020-09-25 Thread Patchwork
== Series Details == Series: series starting with [01/11] mm: update the documentation for vfree (rev2) URL : https://patchwork.freedesktop.org/series/82063/ State : success == Summary == CI Bug Log - changes from CI_DRM_9057 -> Patchwork_18576

Re: [Intel-gfx] [PATCH v2 5/6] drm/i915: Switch to LTTPR transparent mode link training

2020-09-25 Thread Imre Deak
On Fri, Sep 25, 2020 at 07:03:50PM +0300, Ville Syrjälä wrote: > On Thu, Sep 24, 2020 at 09:48:04PM +0300, Imre Deak wrote: > > By default LTTPRs should be in transparent link training mode, > > nevertheless in this patch we switch to this default mode explicitly. > > > > The DP Standard

[Intel-gfx] [PATCH 08/11, fixed] drm/i915: use vmap in i915_gem_object_map

2020-09-25 Thread Christoph Hellwig
i915_gem_object_map implements fairly low-level vmap functionality in a driver. Split it into two helpers, one for remapping kernel memory which can use vmap, and one for I/O memory that uses vmap_pfn. The only practical difference is that alloc_vm_area prefeaults the vmalloc area PTEs, which

Re: [Intel-gfx] [PATCH v2 5/6] drm/i915: Switch to LTTPR transparent mode link training

2020-09-25 Thread Ville Syrjälä
On Thu, Sep 24, 2020 at 09:48:04PM +0300, Imre Deak wrote: > By default LTTPRs should be in transparent link training mode, > nevertheless in this patch we switch to this default mode explicitly. > > The DP Standard recommends this, supposedly because an LTTPR may be left > in the non-transparent

Re: [Intel-gfx] [PATCH v2 4/6] drm/dp: Add LTTPR helpers

2020-09-25 Thread Ville Syrjälä
On Thu, Sep 24, 2020 at 09:48:03PM +0300, Imre Deak wrote: > Add the helpers and register definitions needed to read out the common > and per-PHY LTTPR capabilities and perform link training in the LTTPR > non-transparent mode. > > v2: > - Add drm_dp_dpcd_read_phy_link_status() and DP_PHY_LTTPR()

Re: [Intel-gfx] [PATCH 08/11] drm/i915: use vmap in i915_gem_object_map

2020-09-25 Thread Christoph Hellwig
On Fri, Sep 25, 2020 at 03:08:59PM +0100, Matthew Auld wrote: > > + i = 0; > > + for_each_sgt_page(page, iter, obj->mm.pages) > > + pages[i++] = page; > > + vaddr = vmap(pages, n_pages, 0, pgprot); > > + if (pages != stack) > > + kvfree(pages); >

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915: Redo "Remove i915_request.lock requirement for execution callbacks"

2020-09-25 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Redo "Remove i915_request.lock requirement for execution callbacks" URL : https://patchwork.freedesktop.org/series/82091/ State : success == Summary == CI Bug Log - changes from CI_DRM_9056_full -> Patchwork_18571_full

Re: [Intel-gfx] [PATCH][next] drm/i915: Fix inconsistent IS_ERR and PTR_ERR

2020-09-25 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this? Thanks -- Gustavo On 9/10/20 05:21, Gustavo A. R. Silva wrote: > Fix inconsistent IS_ERR and PTR_ERR in i915_gem_object_copy_blt(). > > The proper pointer to be passed as argument to PTR_ERR() is vma[1]. > > This bug was detected with the help of

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-25 Thread Jason Gunthorpe
On Fri, Sep 25, 2020 at 01:29:49PM +0100, Tvrtko Ursulin wrote: > > On 25/09/2020 12:58, Jason Gunthorpe wrote: > > On Fri, Sep 25, 2020 at 12:41:29PM +0100, Tvrtko Ursulin wrote: > > > > > > On 25/09/2020 08:13, Leon Romanovsky wrote: > > > > On Thu, Sep 24, 2020 at 09:21:20AM +0100, Tvrtko

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-25 Thread Jason Gunthorpe
On Fri, Sep 25, 2020 at 10:13:30AM +0300, Leon Romanovsky wrote: > > > diff --git a/tools/testing/scatterlist/main.c > > > b/tools/testing/scatterlist/main.c > > > index 0a1464181226..4899359a31ac 100644 > > > +++ b/tools/testing/scatterlist/main.c > > > @@ -55,14 +55,13 @@ int main(void) > > >

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-25 Thread Maor Gottlieb
On 9/25/2020 2:55 PM, Jason Gunthorpe wrote: On Fri, Sep 25, 2020 at 10:13:30AM +0300, Leon Romanovsky wrote: diff --git a/tools/testing/scatterlist/main.c b/tools/testing/scatterlist/main.c index 0a1464181226..4899359a31ac 100644 +++ b/tools/testing/scatterlist/main.c @@ -55,14 +55,13 @@ int

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-25 Thread Jason Gunthorpe
On Fri, Sep 25, 2020 at 12:41:29PM +0100, Tvrtko Ursulin wrote: > > On 25/09/2020 08:13, Leon Romanovsky wrote: > > On Thu, Sep 24, 2020 at 09:21:20AM +0100, Tvrtko Ursulin wrote: > > > > > > On 22/09/2020 09:39, Leon Romanovsky wrote: > > > > From: Maor Gottlieb > > > > > > > > Extend

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-25 Thread Maor Gottlieb
On 9/25/2020 2:41 PM, Tvrtko Ursulin wrote: On 25/09/2020 08:13, Leon Romanovsky wrote: On Thu, Sep 24, 2020 at 09:21:20AM +0100, Tvrtko Ursulin wrote: On 22/09/2020 09:39, Leon Romanovsky wrote: From: Maor Gottlieb Extend __sg_alloc_table_from_pages to support dynamic allocation of SG

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-25 Thread Maor Gottlieb
On 9/25/2020 3:33 PM, Tvrtko Ursulin wrote: On 25/09/2020 13:18, Maor Gottlieb wrote: On 9/25/2020 2:55 PM, Jason Gunthorpe wrote: On Fri, Sep 25, 2020 at 10:13:30AM +0300, Leon Romanovsky wrote: diff --git a/tools/testing/scatterlist/main.c b/tools/testing/scatterlist/main.c index

Re: [Intel-gfx] [PATCH 10/11] x86/xen: open code alloc_vm_area in arch_gnttab_valloc

2020-09-25 Thread boris . ostrovsky
On 9/24/20 9:58 AM, Christoph Hellwig wrote: > Replace the last call to alloc_vm_area with an open coded version using > an iterator in struct gnttab_vm_area instead of the triple indirection > magic in alloc_vm_area. > > Signed-off-by: Christoph Hellwig Reviewed-by: Boris Ostrovsky

Re: [Intel-gfx] [PATCH 09/11] xen/xenbus: use apply_to_page_range directly in xenbus_map_ring_pv

2020-09-25 Thread boris . ostrovsky
On 9/24/20 9:58 AM, Christoph Hellwig wrote: > Replacing alloc_vm_area with get_vm_area_caller + apply_page_range > allows to fill put the phys_addr values directly instead of doing > another loop over all addresses. > > Signed-off-by: Christoph Hellwig Reviewed-by: Boris Ostrovsky -boris

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/atomic: document and enforce rules around "spurious" EBUSY

2020-09-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/atomic: document and enforce rules around "spurious" EBUSY URL : https://patchwork.freedesktop.org/series/82086/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9056_full -> Patchwork_18570_full

Re: [Intel-gfx] [PATCH 3/4] drm/i915/gt: Always send a pulse down the engine after disabling heartbeat

2020-09-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-09-25 14:19:22) > > On 25/09/2020 11:01, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-09-24 14:43:08) > >> > >> On 16/09/2020 10:42, Chris Wilson wrote: > >>> Currently, we check we can send a pulse prior to disabling the > >>> heartbeat to verify that we can

Re: [Intel-gfx] [PATCH 08/11] drm/i915: use vmap in i915_gem_object_map

2020-09-25 Thread Matthew Auld
On Thu, 24 Sep 2020 at 14:59, Christoph Hellwig wrote: > > i915_gem_object_map implements fairly low-level vmap functionality in > a driver. Split it into two helpers, one for remapping kernel memory > which can use vmap, and one for I/O memory that uses vmap_pfn. > > The only practical

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-25 Thread Tvrtko Ursulin
On 25/09/2020 14:39, Maor Gottlieb wrote: On 9/25/2020 3:33 PM, Tvrtko Ursulin wrote: On 25/09/2020 13:18, Maor Gottlieb wrote: On 9/25/2020 2:55 PM, Jason Gunthorpe wrote: On Fri, Sep 25, 2020 at 10:13:30AM +0300, Leon Romanovsky wrote: diff --git a/tools/testing/scatterlist/main.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Finish (de)gamma readout prep bits

2020-09-25 Thread Patchwork
== Series Details == Series: drm/i915: Finish (de)gamma readout prep bits URL : https://patchwork.freedesktop.org/series/82099/ State : success == Summary == CI Bug Log - changes from CI_DRM_9056 -> Patchwork_18575 Summary ---

[Intel-gfx] [PATCH 3/9] drm/i915: Include the LUT sizes in the state dump

2020-09-25 Thread Ville Syrjala
From: Ville Syrjälä Dump the sizes of the software LUTs in the state dump. Makes it a bit easier to see which is present without having to decode it from the gamma_mode and other bits of state. v2: Drop a spurious "is" in commit msg (Uma) Reviewed-by: Uma Shankar Signed-off-by: Ville Syrjälä

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Finish (de)gamma readout prep bits

2020-09-25 Thread Patchwork
== Series Details == Series: drm/i915: Finish (de)gamma readout prep bits URL : https://patchwork.freedesktop.org/series/82099/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

Re: [Intel-gfx] [PATCH 4/4] drm/i915/gem: Always test execution status on closing the context

2020-09-25 Thread Tvrtko Ursulin
On 25/09/2020 11:05, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-09-24 15:26:56) On 16/09/2020 10:42, Chris Wilson wrote: Verify that if a context is active at the time it is closed, that it is either persistent and preemptible (with hangcheck running) or it shall be removed from

[Intel-gfx] [PATCH 1/9] drm/i915: Fix state checker hw.active/hw.enable readout

2020-09-25 Thread Ville Syrjala
From: Ville Syrjälä Previously intel_dump_pipe_config() used to dump the full crtc state whether or not the crtc was logically enabled or not. As that meant occasionally dumping confusing stale garbage I changed it to check whether the crtc is logically enabled or not. However I did not realize

[Intel-gfx] [PATCH 0/9] drm/i915: Finish (de)gamma readout prep bits

2020-09-25 Thread Ville Syrjala
From: Ville Syrjälä The easy prep stuff from my earlier (de)gamma readout series. All reviewed already by Uma (thanks). The rest of that series still needs some work. Ville Syrjälä (9): drm/i915: Fix state checker hw.active/hw.enable readout drm/i915: Move MST master transcoder dump earlier

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for DP-HDMI2.1 PCON

2020-09-25 Thread Patchwork
== Series Details == Series: Add support for DP-HDMI2.1 PCON URL : https://patchwork.freedesktop.org/series/82098/ State : success == Summary == CI Bug Log - changes from CI_DRM_9056 -> Patchwork_18574 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH 3/4] drm/i915/gt: Always send a pulse down the engine after disabling heartbeat

2020-09-25 Thread Tvrtko Ursulin
On 25/09/2020 11:01, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-09-24 14:43:08) On 16/09/2020 10:42, Chris Wilson wrote: Currently, we check we can send a pulse prior to disabling the heartbeat to verify that we can change the heartbeat, but since we may re-evaluate execution upon

[Intel-gfx] [PATCH 4/9] drm/i915: s/glk_read_lut_10/bdw_read_lut_10/

2020-09-25 Thread Ville Syrjala
From: Ville Syrjälä glk_read_lut_10() works just fine for all bdw+ platforms, so rename it. Reviewed-by: Uma Shankar Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 6/9] drm/i915: Shuffle chv_cgm_gamma_pack() around a bit

2020-09-25 Thread Ville Syrjala
From: Ville Syrjälä Move chv_cgm_gamma_pack() next to the other CGM gamma functions. Right now it's stuck in the middle of the CGM degamma functions. Reviewed-by: Uma Shankar Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 14 +++--- 1 file changed, 7

[Intel-gfx] [PATCH 8/9] drm/i915: Polish bdw_read_lut_10() a bit

2020-09-25 Thread Ville Syrjala
From: Ville Syrjälä Since bdw_read_lut_10() uses the auto-increment mode we must have an equal number of entries in the software LUT and the hardware LUT. WARN if that is not the case. Reviewed-by: Uma Shankar Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 7

[Intel-gfx] [PATCH 2/9] drm/i915: Move MST master transcoder dump earlier

2020-09-25 Thread Ville Syrjala
From: Ville Syrjälä Move the MST master transcoder dump next to the other transcoder bits. Reviewed-by: Uma Shankar Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 5/9] drm/i915: Reset glk degamma index after programming/readout

2020-09-25 Thread Ville Syrjala
From: Ville Syrjälä Just for some extra consistency let's reset the glk degamma LUT index back to 0 after we're dong trawling the LUT. Reviewed-by: Uma Shankar Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 6 +- 1 file changed, 5 insertions(+), 1

[Intel-gfx] [PATCH 7/9] drm/i915: Relocate CHV CGM gamma masks

2020-09-25 Thread Ville Syrjala
From: Ville Syrjälä CGM_PIPE_GAMMA_RED_MASK & co. are misplaced. Move then below the relevant register. And while at it add the degamma counterparts. Reviewed-by: Uma Shankar Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 9 ++--- 1 file changed, 6 insertions(+), 3

[Intel-gfx] [PATCH 9/9] drm/i915: Replace some gamma_mode ifs with switches

2020-09-25 Thread Ville Syrjala
From: Ville Syrjälä Since gamma_mode can have more than two values on ilk+ let's use switch statements when interpreting them. v2: Fix typo (Uma) Reviewed-by: Uma Shankar Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 92 -- 1 file changed,

Re: [Intel-gfx] [PATCH 08/11] drm/i915: use vmap in i915_gem_object_map

2020-09-25 Thread Tvrtko Ursulin
On 24/09/2020 14:58, Christoph Hellwig wrote: i915_gem_object_map implements fairly low-level vmap functionality in a driver. Split it into two helpers, one for remapping kernel memory which can use vmap, and one for I/O memory that uses vmap_pfn. The only practical difference is that

Re: [Intel-gfx] [PATCH 06/11] drm/i915: use vmap in shmem_pin_map

2020-09-25 Thread Tvrtko Ursulin
On 24/09/2020 14:58, Christoph Hellwig wrote: shmem_pin_map somewhat awkwardly reimplements vmap using alloc_vm_area and manual pte setup. The only practical difference is that alloc_vm_area prefeaults the vmalloc area PTEs, which doesn't seem to be required here (and could be added to vmap

Re: [Intel-gfx] [PATCH 07/11] drm/i915: stop using kmap in i915_gem_object_map

2020-09-25 Thread Tvrtko Ursulin
On 24/09/2020 14:58, Christoph Hellwig wrote: kmap for !PageHighmem is just a convoluted way to say page_address, and kunmap is a no-op in that case. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-)

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add support for DP-HDMI2.1 PCON

2020-09-25 Thread Patchwork
== Series Details == Series: Add support for DP-HDMI2.1 PCON URL : https://patchwork.freedesktop.org/series/82098/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for DP-HDMI2.1 PCON

2020-09-25 Thread Patchwork
== Series Details == Series: Add support for DP-HDMI2.1 PCON URL : https://patchwork.freedesktop.org/series/82098/ State : warning == Summary == $ dim checkpatch origin/drm-tip ca36191ea8ce drm/edid: Add additional HFVSDB fields for HDMI2.1 -:57: WARNING:NO_AUTHOR_SIGN_OFF: Missing

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Make intel_{enable, disable}_sagv() static

2020-09-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Make intel_{enable, disable}_sagv() static URL : https://patchwork.freedesktop.org/series/82096/ State : success == Summary == CI Bug Log - changes from CI_DRM_9056 -> Patchwork_18573

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Make intel_{enable, disable}_sagv() static

2020-09-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Make intel_{enable, disable}_sagv() static URL : https://patchwork.freedesktop.org/series/82096/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-25 Thread Tvrtko Ursulin
On 25/09/2020 13:18, Maor Gottlieb wrote: On 9/25/2020 2:55 PM, Jason Gunthorpe wrote: On Fri, Sep 25, 2020 at 10:13:30AM +0300, Leon Romanovsky wrote: diff --git a/tools/testing/scatterlist/main.c b/tools/testing/scatterlist/main.c index 0a1464181226..4899359a31ac 100644 +++

[Intel-gfx] ✓ Fi.CI.BAT: success for dma-buf: Flag vmap'ed memory as system or I/O memory (rev3)

2020-09-25 Thread Patchwork
== Series Details == Series: dma-buf: Flag vmap'ed memory as system or I/O memory (rev3) URL : https://patchwork.freedesktop.org/series/81647/ State : success == Summary == CI Bug Log - changes from CI_DRM_9056 -> Patchwork_18572 Summary

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-25 Thread Tvrtko Ursulin
On 25/09/2020 12:58, Jason Gunthorpe wrote: On Fri, Sep 25, 2020 at 12:41:29PM +0100, Tvrtko Ursulin wrote: On 25/09/2020 08:13, Leon Romanovsky wrote: On Thu, Sep 24, 2020 at 09:21:20AM +0100, Tvrtko Ursulin wrote: On 22/09/2020 09:39, Leon Romanovsky wrote: From: Maor Gottlieb Extend

[Intel-gfx] [RFC 4/7] drm/i915: Add support for starting FRL training for HDMI2.1 via PCON

2020-09-25 Thread Ankit Nautiyal
This patch adds functions to start FRL training for an HDMI2.1 sink, connected via a PCON as a DP branch device. This patch also adds a new structure for storing frl training related data, when FRL training is completed. Signed-off-by: Ankit Nautiyal ---

[Intel-gfx] [RFC 0/7] Add support for DP-HDMI2.1 PCON

2020-09-25 Thread Ankit Nautiyal
This patch series attempts to add support for a DP-HDMI2.1 Protocol Convertor. The VESA spec for the HDMI2.1 PCON are proposed in Errata E5 to DisplayPort_v2.0: https://vesa.org/join-vesamemberships/member-downloads/?action=stamp=42299 The details are mentioned in DP to HDMI2.1 PCON Enum/Config

[Intel-gfx] [RFC 1/7] drm/edid: Add additional HFVSDB fields for HDMI2.1

2020-09-25 Thread Ankit Nautiyal
From: Swati Sharma The HDMI2.1 extends HFVSBD (HDMI Forum Vendor Specific Data block) to have fields related to newly defined methods of FRL (Fixed Rate Link) levels, number of lanes supported, DSC Color bit depth, VRR min/max, FVA (Fast Vactive), ALLM etc. This patch adds the new HFVSDB fields

[Intel-gfx] [RFC 2/7] drm/edid: Parse MAX_FRL field from HFVSDB block

2020-09-25 Thread Ankit Nautiyal
From: Swati Sharma This patch parses MAX_FRL field to get the MAX rate in Gbps that the HDMI 2.1 panel can support in FRL mode. Source need this field to determine the optimal rate between the source and sink during FRL training. Signed-off-by: Sharma, Swati2 Signed-off-by: Ankit Nautiyal ---

[Intel-gfx] [RFC 6/7] drm/dp_helper: Add support for link status and link recovery

2020-09-25 Thread Ankit Nautiyal
From: Swati Sharma This patch adds support for link status and link recovery. There are specific DPCD’s defined for link status check and recovery in case of any issues. PCON will communicate the same using an IRQ_HPD to source. HDMI sink would have indicated the same to PCON using SCDC

[Intel-gfx] [RFC 3/7] drm/dp_helper: Add FRL training support for a DP-HDMI2.1 PCON

2020-09-25 Thread Ankit Nautiyal
This patch adds support for configuring a PCON device, connected as a DP branched device to enable FRL Link training with a HDMI2.1 + sink. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/drm_dp_helper.c | 305 include/drm/drm_dp_helper.h | 81 +

[Intel-gfx] [RFC 5/7] drm/i915: Check for FRL training before DP Link training

2020-09-25 Thread Ankit Nautiyal
This patch calls functions to check FRL training requirements for an HDMI2.1 sink, when connected through PCON. The call is made before the DP link training. In case FRL is not required or failure during FRL training, the TMDS mode is selected for the pcon. Signed-off-by: Ankit Nautiyal ---

[Intel-gfx] [RFC 7/7] drm/i915: Add support for enabling link status and recovery

2020-09-25 Thread Ankit Nautiyal
From: Swati Sharma In this patch enabled support for link status and recovery in i915 driver. HDMI link loss indication to upstream DP source is indicated via IRQ_HPD. This is followed by reading of HDMI link configuration status (HDMI_TX_LINK_ACTIVE_STATUS). If the PCON → HDMI 2.1 link status

[Intel-gfx] [PATCH 2/2] drm/i915: Don't hide the intel_crtc_atomic_check() call

2020-09-25 Thread Ville Syrjala
From: Ville Syrjälä Move the intel_crtc_atomic_check() call out from the variable declarations to a place where we can actually see it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH 1/2] drm/i915: Make intel_{enable, disable}_sagv() static

2020-09-25 Thread Ville Syrjala
From: Ville Syrjälä intel_{enable,disable}_sagv() are no longer needed outside the compilation unit. Make them static. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- drivers/gpu/drm/i915/intel_pm.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for dma-buf: Flag vmap'ed memory as system or I/O memory (rev3)

2020-09-25 Thread Patchwork
== Series Details == Series: dma-buf: Flag vmap'ed memory as system or I/O memory (rev3) URL : https://patchwork.freedesktop.org/series/81647/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for dma-buf: Flag vmap'ed memory as system or I/O memory (rev3)

2020-09-25 Thread Patchwork
== Series Details == Series: dma-buf: Flag vmap'ed memory as system or I/O memory (rev3) URL : https://patchwork.freedesktop.org/series/81647/ State : warning == Summary == $ dim checkpatch origin/drm-tip c94eaf86e18e dma-buf: Add struct dma-buf-map for storing struct dma_buf.vaddr_ptr -:47:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Redo "Remove i915_request.lock requirement for execution callbacks"

2020-09-25 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Redo "Remove i915_request.lock requirement for execution callbacks" URL : https://patchwork.freedesktop.org/series/82091/ State : success == Summary == CI Bug Log - changes from CI_DRM_9056 -> Patchwork_18571

[Intel-gfx] [PATCH v3 3/4] dma-buf: Use struct dma_buf_map in dma_buf_vunmap() interfaces

2020-09-25 Thread Thomas Zimmermann
This patch updates dma_buf_vunmap() and dma-buf's vunmap callback to use struct dma_buf_map. The interfaces used to receive a buffer address. This address is now given in an instance of the structure. Users of the functions are updated accordingly. This is only an interface change. It is

[Intel-gfx] [PATCH v3 4/4] dma-buf: Document struct dma_buf_map

2020-09-25 Thread Thomas Zimmermann
This patch adds struct dma_buf_map and its helpers to the documentation. A short tutorial is included. v3: * update documentation in a separate patch * expand docs (Daniel) * carry-over acks from patch 1 Signed-off-by: Thomas Zimmermann Reviewed-by: Christian König

[Intel-gfx] [PATCH v3 1/4] dma-buf: Add struct dma-buf-map for storing struct dma_buf.vaddr_ptr

2020-09-25 Thread Thomas Zimmermann
The new type struct dma_buf_map represents a mapping of dma-buf memory into kernel space. It contains a flag, is_iomem, that signals users to access the mapped memory with I/O operations instead of regular loads and stores. It was assumed that DMA buffer memory can be accessed with regular load

[Intel-gfx] [PATCH v3 0/4] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-25 Thread Thomas Zimmermann
Dma-buf provides vmap() and vunmap() for retriving and releasing mappings of dma-buf memory in kernel address space. The functions operate with plain addresses and the assumption is that the memory can be accessed with load and store operations. This is not the case on some architectures (e.g.,

[Intel-gfx] [PATCH v3 2/4] dma-buf: Use struct dma_buf_map in dma_buf_vmap() interfaces

2020-09-25 Thread Thomas Zimmermann
This patch updates dma_buf_vmap() and dma-buf's vmap callback to use struct dma_buf_map. The interfaces used to return a buffer address. This address now gets stored in an instance of the structure that is given as an additional argument. The functions return an errno code on errors. Users of

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Redo "Remove i915_request.lock requirement for execution callbacks"

2020-09-25 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Redo "Remove i915_request.lock requirement for execution callbacks" URL : https://patchwork.freedesktop.org/series/82091/ State : warning == Summary == $ dim checkpatch origin/drm-tip e9ed1a8a1759 drm/i915: Redo "Remove

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-25 Thread Tvrtko Ursulin
On 25/09/2020 08:13, Leon Romanovsky wrote: On Thu, Sep 24, 2020 at 09:21:20AM +0100, Tvrtko Ursulin wrote: On 22/09/2020 09:39, Leon Romanovsky wrote: From: Maor Gottlieb Extend __sg_alloc_table_from_pages to support dynamic allocation of SG table from pages. It should be used by drivers

Re: [Intel-gfx] [PATCH v2 1/3] dma-buf: Add struct dma-buf-map for storing struct dma_buf.vaddr_ptr

2020-09-25 Thread Thomas Zimmermann
Hi Am 23.09.20 um 16:27 schrieb Christian König: > Am 23.09.20 um 14:32 schrieb Thomas Zimmermann: >> The new type struct dma_buf_map represents a mapping of dma-buf memory >> into kernel space. It contains a flag, is_iomem, that signals users to >> access the mapped memory with I/O operations

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/atomic: document and enforce rules around "spurious" EBUSY

2020-09-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/atomic: document and enforce rules around "spurious" EBUSY URL : https://patchwork.freedesktop.org/series/82086/ State : success == Summary == CI Bug Log - changes from CI_DRM_9056 -> Patchwork_18570

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_ctx_persistence: Exercise cleanup after disabling heartbeats

2020-09-25 Thread Joonas Lahtinen
Quoting Chris Wilson (2020-08-13 00:33:00) > We expose the heartbeat interval on each engine, allowing the sysadim to > disable them if they prefer avoiding any interruption for their GPU > tasks. A caveat to allowing the contexts to run without checks is that > we require such contexts to be

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Cancel outstanding work after disabling heartbeats on an engine

2020-09-25 Thread Joonas Lahtinen
Quoting Chris Wilson (2020-09-16 12:42:17) > We only allow persistent requests to remain on the GPU past the closure > of their containing context (and process) so long as they are continuously > checked for hangs or allow other requests to preempt them, as we need to > ensure forward progress of

Re: [Intel-gfx] [PATCH] drm/i915: Implement display WA #1142:kbl, cfl, cml

2020-09-25 Thread Ville Syrjälä
On Thu, Sep 24, 2020 at 08:43:33PM +, Souza, Jose wrote: > On Thu, 2020-09-24 at 22:48 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä < > > ville.syrj...@linux.intel.com > > > > > > > Implement display w/a #1142. This supposedly fixes some underruns > > with FBC+VTd. Bspec says we should

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/atomic: document and enforce rules around "spurious" EBUSY

2020-09-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/atomic: document and enforce rules around "spurious" EBUSY URL : https://patchwork.freedesktop.org/series/82086/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6e02c964a485 drm/atomic: document and enforce rules

[Intel-gfx] [CI 1/2] drm/i915: Redo "Remove i915_request.lock requirement for execution callbacks"

2020-09-25 Thread Chris Wilson
The reordering and rebasing of commit 2e4c6c1a9db5 ("drm/i915: Remove i915_request.lock requirement for execution callbacks") caused it to revert an earlier correction. Let us restore commit 99f0a640d464 ("drm/i915: Remove requirement for holding i915_request.lock for breadcrumbs") Fixes:

[Intel-gfx] [CI 2/2] drm/i915/gem: Hold request reference for canceling an active context

2020-09-25 Thread Chris Wilson
We have to be very careful while walking the timeline->requests list under the RCU guard, as the requests (and so rq->link) use SLAB_TYPESAFE_BY_RCU and so the requests may be reallocated within an rcu grace period. As the requests are reallocated, they are removed from one list and placed on

Re: [Intel-gfx] [PATCH 4/4] drm/i915/gem: Always test execution status on closing the context

2020-09-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-09-24 15:26:56) > > On 16/09/2020 10:42, Chris Wilson wrote: > > Verify that if a context is active at the time it is closed, that it is > > either persistent and preemptible (with hangcheck running) or it shall > > be removed from execution. > > > > Fixes:

Re: [Intel-gfx] [PATCH 3/4] drm/i915/gt: Always send a pulse down the engine after disabling heartbeat

2020-09-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-09-24 14:43:08) > > On 16/09/2020 10:42, Chris Wilson wrote: > > Currently, we check we can send a pulse prior to disabling the > > heartbeat to verify that we can change the heartbeat, but since we may > > re-evaluate execution upon changing the heartbeat interval we

Re: [Intel-gfx] [PATCH i-g-t] lib: Only avoid relocations with full-ppgtt

2020-09-25 Thread Zbigniew Kempczyński
On Fri, Sep 25, 2020 at 09:41:48AM +0100, Chris Wilson wrote: > We can only assigned random addresses with impunity if we know we have > complete control over the ppGTT. If the ppGTT is shared, either aliased > with the global GTT or simply the global GTT on ancient HW, then we have > to be

Re: [Intel-gfx] [PATCH 2/2] drm/atomic: debug output for EBUSY

2020-09-25 Thread Pekka Paalanen
On Fri, 25 Sep 2020 10:46:51 +0200 Daniel Vetter wrote: > Hopefully we'll have the drm crash recorder RSN, but meanwhile > compositors would like to know a bit better why they get an EBUSY. > > v2: Move misplaced hunk to the right patch (Pekka) Hi, both patches Acked-by: Pekka Paalanen

[Intel-gfx] [PATCH 2/2] drm/atomic: debug output for EBUSY

2020-09-25 Thread Daniel Vetter
Hopefully we'll have the drm crash recorder RSN, but meanwhile compositors would like to know a bit better why they get an EBUSY. v2: Move misplaced hunk to the right patch (Pekka) Cc: Sean Paul Cc: Daniel Stone Cc: Pekka Paalanen Cc: Simon Ser Cc: Ville Syrjälä Signed-off-by: Daniel Vetter

[Intel-gfx] [PATCH 1/2] drm/atomic: document and enforce rules around "spurious" EBUSY

2020-09-25 Thread Daniel Vetter
When doing an atomic modeset with ALLOW_MODESET drivers are allowed to pull in arbitrary other resources, including CRTCs (e.g. when reconfiguring global resources). But in nonblocking mode userspace has then no idea this happened, which can lead to spurious EBUSY calls, both: - when that other

Re: [Intel-gfx] [PATCH] drm/atomic: document and enforce rules around "spurious" EBUSY

2020-09-25 Thread Daniel Vetter
On Fri, Sep 25, 2020 at 11:24:46AM +0300, Pekka Paalanen wrote: > On Wed, 23 Sep 2020 17:18:52 +0200 > Daniel Vetter wrote: > > > When doing an atomic modeset with ALLOW_MODESET drivers are allowed to > > pull in arbitrary other resources, including CRTCs (e.g. when > > reconfiguring global

[Intel-gfx] [PATCH i-g-t] lib: Only avoid relocations with full-ppgtt

2020-09-25 Thread Chris Wilson
We can only assigned random addresses with impunity if we know we have complete control over the ppGTT. If the ppGTT is shared, either aliased with the global GTT or simply the global GTT on ancient HW, then we have to be careful in case they are objects already fixed in place inside the GTT, e.g.

  1   2   >