[Intel-gfx] [PATCH 3/3] drm/i915/dsb: multi dsb instance support in dsb-commit()

2020-12-14 Thread Animesh Manna
Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_dsb.c | 74 +--- 1 file changed, 39 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c index c968c9785484..b3f1cc1652b8 100644 ---

[Intel-gfx] [PATCH 1/3] drm/i915/dsb: multi dsb instance support in prepare() and cleanup()

2020-12-14 Thread Animesh Manna
Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_atomic.c | 9 +- drivers/gpu/drm/i915/display/intel_display.c | 6 +- .../drm/i915/display/intel_display_types.h| 2 +- drivers/gpu/drm/i915/display/intel_dsb.c | 99 ++- 4 files changed, 65 inserti

[Intel-gfx] [PATCH 2/3] drm/i915/dsb: multi dsb instance support in dsb-write()

2020-12-14 Thread Animesh Manna
Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_color.c | 40 +- drivers/gpu/drm/i915/display/intel_dsb.c | 8 ++--- drivers/gpu/drm/i915/display/intel_dsb.h | 4 +-- 3 files changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i91

[Intel-gfx] [PATCH 0/3] Multi DSB instance support

2020-12-14 Thread Animesh Manna
As an enhancement of dsb multi instance support added which can be used by color framework for big lut programming in future. Signed-off-by: Animesh Manna Animesh Manna (3): drm/i915/dsb: multi dsb instance support in prepare() and cleanup() drm/i915/dsb: multi dsb instance support in dsb-wr

Re: [Intel-gfx] [PATCH 1/1] drm/i915/dp: optimize pps_lock wherever required

2020-12-14 Thread Anshuman Gupta
On 2020-12-11 at 16:13:56 +0200, Jani Nikula wrote: > On Fri, 04 Dec 2020, Anshuman Gupta wrote: > > Reading backlight status from PPS register doesn't require > > AUX power on the platform which has South Display Engine on PCH. > > It invokes a unnecessary power well enable/disable noise. > > opt

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/gt: Split logical ring contexts from execlist submission

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Split logical ring contexts from execlist submission URL : https://patchwork.freedesktop.org/series/84930/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9482_full -> Patchwork_19142_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gt: Split logical ring contexts from execlist submission

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Split logical ring contexts from execlist submission URL : https://patchwork.freedesktop.org/series/84930/ State : success == Summary == CI Bug Log - changes from CI_DRM_9482 -> Patchwork_19142 ==

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915/gt: Split logical ring contexts from execlist submission

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Split logical ring contexts from execlist submission URL : https://patchwork.freedesktop.org/series/84930/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gt/intel_lrc.c:1: w

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gt: Split logical ring contexts from execlist submission

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Split logical ring contexts from execlist submission URL : https://patchwork.freedesktop.org/series/84930/ State : warning == Summary == $ dim checkpatch origin/drm-tip b43f0b75f3e2 drm/i915/gt: Split logical ring contexts f

[Intel-gfx] [PATCH 2/2] drm/i915/gt: Provide a utility to create a scratch buffer

2020-12-14 Thread Chris Wilson
Primarily used by selftests, but also by runtime debugging of engine w/a, is a routine to create a temporarily bound buffer for readback. Almagamate the duplicated routines into one. Suggested-by: Daniele Ceraolo Spurio Signed-off-by: Chris Wilson --- .../drm/i915/gem/selftests/igt_gem_utils.h

[Intel-gfx] ✗ Fi.CI.BAT: failure for Introduce Intel PXP component - Mesa single session (rev9)

2020-12-14 Thread Patchwork
== Series Details == Series: Introduce Intel PXP component - Mesa single session (rev9) URL : https://patchwork.freedesktop.org/series/84620/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9482 -> Patchwork_19141 Summary ---

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Introduce Intel PXP component - Mesa single session (rev9)

2020-12-14 Thread Patchwork
== Series Details == Series: Introduce Intel PXP component - Mesa single session (rev9) URL : https://patchwork.freedesktop.org/series/84620/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file ./drivers/gpu/drm/i915/gt/intel_lrc.c WARNING: kernel

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce Intel PXP component - Mesa single session (rev9)

2020-12-14 Thread Patchwork
== Series Details == Series: Introduce Intel PXP component - Mesa single session (rev9) URL : https://patchwork.freedesktop.org/series/84620/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9cc153390294 drm/i915/pxp: Introduce Intel PXP component -:111: WARNING:FILE_PATH_CHANGES:

[Intel-gfx] [RFC-v9 12/23] drm/i915/pxp: User interface for Protected buffer

2020-12-14 Thread Huang, Sean Z
From: Bommu Krishnaiah This api allow user mode to create Protected buffer and context creation. Signed-off-by: Bommu Krishnaiah Cc: Telukuntla Sreedhar Cc: Kondapally Kalyan Cc: Gupta Anshuman Cc: Huang Sean Z --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 15 ++-- drivers/gp

[Intel-gfx] [RFC-v9 06/23] drm/i915/pxp: Enable PXP irq worker and callback stub

2020-12-14 Thread Huang, Sean Z
Create the irq worker that serves as callback handler, those callback stubs should be called while the hardware key teardown occurs. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 4 + drivers/gpu/drm/i915/i915_reg.h | 3 +- drivers/gpu/drm/i915/

[Intel-gfx] [RFC-v9 20/23] drm/i915/pxp: Add PXP-related registers into allowlist

2020-12-14 Thread Huang, Sean Z
Add several PXP-related reg into allowlist to allow user space driver to read the those register values. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/i915_reg.h | 6 drivers/gpu/drm/i915/intel_uncore.c | 50 - 2 files changed, 41 insertions(+), 15 d

[Intel-gfx] [RFC-v9 11/23] drm/i915/uapi: introduce drm_i915_gem_create_ext

2020-12-14 Thread Huang, Sean Z
From: Bommu Krishnaiah Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. For now we use the extensions mechanism to support PAVP. Signed-off-by: Bommu Krishnaiah Signed-off-by: Matthew Auld Cc: Joonas Lahtinen joonas.lahti...@linux.i

[Intel-gfx] [RFC-v9 19/23] drm/i915/pxp: Termiante the session upon app crash

2020-12-14 Thread Huang, Sean Z
PXP should terminate the hardware session and cleanup the software state gracefully when the application has established the protection session, but doesn't close the session correctly due to some cases like application crash. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [RFC-v9 07/23] drm/i915/pxp: Destroy arb session upon teardown

2020-12-14 Thread Huang, Sean Z
Teardown is triggered when the display topology changes and no long meets the secure playback requirement, and hardware trashes all the encryption keys for display. So as a result, PXP should handle such case and terminate the type0 sessions, which including arb session Signed-off-by: Huang, Sean

[Intel-gfx] [RFC-v9 17/23] drm/i915/pxp: Implement ioctl action to send TEE commands

2020-12-14 Thread Huang, Sean Z
Implement the ioctl action to allow userspace driver sends TEE commands via PXP ioctl, instead of TEE iotcl. So we can centralize those protection operations at PXP. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 48 +--- drivers/gpu/drm/i915/pxp/inte

[Intel-gfx] [RFC-v9 21/23] mei: bus: add vtag support

2020-12-14 Thread Huang, Sean Z
From: Alexander Usyskin Add API to support vtag in communication on mei bus. Add mei_cldev_send_vtag, mei_cldev_recv_vtag and mei_cldev_recv_nonblock_vtag functions to allow sending a message with vtag set and to receive vtag of an incoming message. Cc: Sean Z Huang Signed-off-by: Alexander Us

[Intel-gfx] [RFC-v9 16/23] drm/i915/pxp: Implement ioctl action to terminate the session

2020-12-14 Thread Huang, Sean Z
Implement the PXP ioctl action to allow userspace driver to terminate the hardware session and cleanup its software session state. PXP sends the session termination command to GPU once receves this ioctl action. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 10 +++

[Intel-gfx] [RFC-v9 08/23] drm/i915/pxp: Enable PXP power management

2020-12-14 Thread Huang, Sean Z
During the power event S3+ sleep/resume, hardware will lose all the encryption keys for every hardware session, even though the software session state was marked as alive after resume. So to handle such case, PXP should terminate all the hardware sessions and cleanup all the software states after t

[Intel-gfx] [RFC-v9 13/23] drm/i915/pxp: Add plane decryption support

2020-12-14 Thread Huang, Sean Z
From: Anshuman Gupta Add support to enable/disable PLANE_SURF Decryption Request bit. It requires only to enable plane decryption support when following condition met. 1. PAVP session is enabled. 2. Buffer object is protected. v2: - Rebased to libva_cp-drm-tip_tgl_cp tree. - Used gen fb obj user

[Intel-gfx] [RFC-v9 18/23] drm/i915/pxp: Implement ioctl action to query PXP tag

2020-12-14 Thread Huang, Sean Z
Enable the PXP ioctl action to allow userspace driver to query the PXP tag, which is a 32-bit bitwise value indicating the current session info, including protection type, session id, and whether the session is enabled. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c

[Intel-gfx] [RFC-v9 23/23] drm/i915/pxp: Enable the PXP ioctl for protected session

2020-12-14 Thread Huang, Sean Z
In the previous commits, we have implemented the PXP ioctl functions. Now we enable those handlers and expose them as PXP ioctl, so allow the userspace driver can establish, set, or destory the protected session via this ioctl. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [RFC-v9 01/23] drm/i915/pxp: Introduce Intel PXP component

2020-12-14 Thread Huang, Sean Z
PXP (Protected Xe Path) is an i915 componment, available on GEN12+, that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. This patch series is to allow the kernel space to create and manage a single hardware session (

[Intel-gfx] [RFC-v9 14/23] drm/i915/pxp: Implement ioctl action to reserve session slots

2020-12-14 Thread Huang, Sean Z
With this ioctl action, userspace driver can reserve one or multiple session slot/id assigned by kernel PXP, as the first step of PXP session establishment flow. The session info is stored in the session list structure. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile

[Intel-gfx] [RFC-v9 09/23] drm/i915/pxp: Expose session state for display protection flip

2020-12-14 Thread Huang, Sean Z
Implement the intel_pxp_gem_object_status() to allow i915 display querying the current PXP session state. In the design, display should not perform protection flip on the protected buffers if there is no PXP session alive. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 9

[Intel-gfx] [RFC-v9 10/23] mei: pxp: export pavp client to me client bus

2020-12-14 Thread Huang, Sean Z
From: Vitaly Lubart Export PAVP client to work with i915_cp driver, for binding it uses kernel component framework. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 2 + drivers/misc/mei/Makefile | 1 + drivers/misc/mei/pxp/Kconfig | 1

[Intel-gfx] [RFC-v9 22/23] mei: pxp: add vtag parameter to mei_pxp_send/receive interface

2020-12-14 Thread Huang, Sean Z
From: Tomas Winkler Added vtag parameter to mei_pxp_send_message and mei_pxp_receive_message functions. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 4 ++-- drivers/misc/mei/pxp/mei_pxp.c | 10 ++ include/drm/i915_

[Intel-gfx] [RFC-v9 05/23] drm/i915/pxp: Func to send hardware session termination

2020-12-14 Thread Huang, Sean Z
Implement the functions to allow PXP to send a GPU command, in order to terminate the hardware session, so hardware can recycle this session slot for the next usage. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/pxp/intel_pxp_cmd.c | 159

[Intel-gfx] [RFC-v9 03/23] drm/i915/pxp: Implement funcs to create the TEE channel

2020-12-14 Thread Huang, Sean Z
Implement the funcs to create the TEE channel, so kernel can send the TEE commands directly to TEE for creating the arbitrary (defualt) session. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 3 +- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm/i

[Intel-gfx] [RFC-v9 15/23] drm/i915/pxp: Implement ioctl action to set session in play

2020-12-14 Thread Huang, Sean Z
With this ioctl action, userspace driver can set the session in state "session in play", after dirver reserved the session slot/id from kernel PXP, and sent the TEE commands to activate the corresponding hardware session. Session state "session in play" means this session is ready for secure playba

[Intel-gfx] [RFC-v9 02/23] drm/i915/pxp: set KCR reg init during the boot time

2020-12-14 Thread Huang, Sean Z
Set the KCR init during the boot time, which is required by hardware, to allow us doing further protection operation such as sending commands to GPU or TEE. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/g

[Intel-gfx] [RFC-v9 00/23] Introduce Intel PXP component - Mesa single session

2020-12-14 Thread Huang, Sean Z
PXP (Protected Xe Path) is an i915 componment, available on GEN12+ that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. [commit #1 - #13] This patch series is to allow the kernel space to create and manage a single h

[Intel-gfx] [RFC-v9 04/23] drm/i915/pxp: Create the arbitrary session after boot

2020-12-14 Thread Huang, Sean Z
Create the arbitrary session, with the fixed session id 0xf, after system boot, for the case that application allocates the protected buffer without establishing any protection session. Because the hardware requires at least one alive session for protected buffer creation. This arbitrary session n

Re: [Intel-gfx] [PATCH i-g-t] lib: Pass device fd to gem_mmappable_aperture_size()

2020-12-14 Thread Chang, Yu bruce
>From: Chris Wilson > >Sent: Monday, December 14, 2020 2:15 PM >To: Chang, Yu bruce; intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] [PATCH i-g-t] lib: Pass device fd to >gem_mmappable_aperture_size() > >Quoting Chang, Yu bruce (2020-12-14 21:52:10) >> >> > >> >From: Chris Wilson >> >S

Re: [Intel-gfx] [PATCH] drm/i915/display: Prevent double YUV range correction on HDR planes

2020-12-14 Thread Shankar, Uma
> -Original Message- > From: andrescj via sendgmr > On Behalf Of Andres Calderon Jaramillo > Sent: Tuesday, December 15, 2020 3:50 AM > To: intel-gfx@lists.freedesktop.org > Cc: Shankar, Uma ; Venkatesh Reddy, Sushma > ; seanp...@chromium.org; Andres > Calderon Jaramillo > Subject: [PA

Re: [Intel-gfx] [PATCH] drm/i915/gt: Split logical ring contexts from execlist submission

2020-12-14 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2020-12-14 22:11:01) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.h > > b/drivers/gpu/drm/i915/gt/intel_lrc.h > > new file mode 100644 > > index ..3d3e408a87a9 > > --- /dev/null > > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.h > > @@ -0,0 +1,114

Re: [Intel-gfx] [PATCH i-g-t] lib: Pass device fd to gem_mmappable_aperture_size()

2020-12-14 Thread Chris Wilson
Quoting Chang, Yu bruce (2020-12-14 21:52:10) > > > > >From: Chris Wilson > >Sent: Monday, December 14, 2020 12:48 PM > >To: Chang, Yu bruce; intel-gfx@lists.freedesktop.org > >Cc: igt-dev@ > >Subject: Re: [Intel-gfx] [PATCH i-g-t] lib: Pass device fd to > gem_mmappable_aperture_size() > > > >Qu

Re: [Intel-gfx] [PATCH] drm/i915/gt: Split logical ring contexts from execlist submission

2020-12-14 Thread Daniele Ceraolo Spurio
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.h b/drivers/gpu/drm/i915/gt/intel_lrc.h new file mode 100644 index ..3d3e408a87a9 --- /dev/null +++ b/drivers/gpu/drm/i915/gt/intel_lrc.h @@ -0,0 +1,114 @@ +/* SPDX-License-Identifier: MIT */ +/* + * Copyright © 2014 Intel Corporation

Re: [Intel-gfx] [PATCH i-g-t] lib: Pass device fd to gem_mmappable_aperture_size()

2020-12-14 Thread Chang, Yu bruce
> >From: Chris Wilson >Sent: Monday, December 14, 2020 12:48 PM >To: Chang, Yu bruce; intel-gfx@lists.freedesktop.org >Cc: igt-dev@ >Subject: Re: [Intel-gfx] [PATCH i-g-t] lib: Pass device fd to >gem_mmappable_aperture_size() > >Quoting Chang, Yu bruce (2020-12-14 18:45:04) >> +/** >> + * gem_ma

[Intel-gfx] [PATCH i-g-t] i915/gem_shrink: Refactor allocation sizing based on available memory

2020-12-14 Thread Chris Wilson
Refactor the allocation such that we utilise just enough memory pressure to invoke the shrinker, and just enough processes to spread across the CPUs and contend on the shrinker. v2: Reduce over-allocation from mem_size/2 to mem_size/8, and 9 processes per cpu. Signed-off-by: Chris Wilson Cc: Tvr

Re: [Intel-gfx] [PATCH i-g-t] lib: Pass device fd to gem_mmappable_aperture_size()

2020-12-14 Thread Chris Wilson
Quoting Chang, Yu bruce (2020-12-14 18:45:04) > +/** > + * gem_mappable_aperture_size: > + * > + * Feature test macro to query the kernel for the mappable gpu aperture size. > + * This is the area available for GTT memory mappings. > + * > + * Returns: The mappable gtt address space size. > + */ >

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_schedule: Measure timeslice distribution when oversaturated

2020-12-14 Thread Chris Wilson
Check that timeslices for an oversaturated system (where there is more work than can be supported by a single engine) are evenly distributed between the clients. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/i915/gem_exec_schedule.c | 179 + 1 file cha

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Reduce duplicated switch cases in hpd code (rev2)

2020-12-14 Thread Patchwork
== Series Details == Series: drm/i915: Reduce duplicated switch cases in hpd code (rev2) URL : https://patchwork.freedesktop.org/series/84593/ State : success == Summary == CI Bug Log - changes from CI_DRM_9481_full -> Patchwork_19137_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Fix ICL MG PHY vswing handling (rev2)

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix ICL MG PHY vswing handling (rev2) URL : https://patchwork.freedesktop.org/series/84651/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9481_full -> Patchwork_19136_full ==

[Intel-gfx] ✗ Fi.CI.BAT: failure for doc: Fix build of documentation after i915 file rename

2020-12-14 Thread Patchwork
== Series Details == Series: doc: Fix build of documentation after i915 file rename URL : https://patchwork.freedesktop.org/series/84914/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9481 -> Patchwork_19140 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v6,1/5] drm: Add function to convert rect in 16.16 fixed format to regular format

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [v6,1/5] drm: Add function to convert rect in 16.16 fixed format to regular format URL : https://patchwork.freedesktop.org/series/84910/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9481 -> Patchwork_19139 ===

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Individual request cancellation

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Individual request cancellation URL : https://patchwork.freedesktop.org/series/84906/ State : success == Summary == CI Bug Log - changes from CI_DRM_9481_full -> Patchwork_19134_full =

[Intel-gfx] [PATCH] doc: Fix build of documentation after i915 file rename

2020-12-14 Thread José Roberto de Souza
Commit 70a2b431c364 ("drm/i915/gt: Rename lrc.c to execlists_submission.c") renamed intel_lrc.c to intel_execlists_submission.c but forgot to update i915.rst. Fixes: 70a2b431c364 ("drm/i915/gt: Rename lrc.c to execlists_submission.c") Cc: Chris Wilson Signed-off-by: José Roberto de Souza --- Do

Re: [Intel-gfx] [PATCH i-g-t] lib: Pass device fd to gem_mmappable_aperture_size()

2020-12-14 Thread Chang, Yu bruce
Some minor comments as below. Reviewed-by: Bruce Chang From: Chris Wilson Sent: Saturday, December 12, 2020 1:43 AM To: intel-gfx@lists.freedesktop.org Cc: igt-...@lists.freedesktop.org; Chris Wilson; Chang, Yu bruce Subject: [PATCH i-g-t] lib: Pass device fd t

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [v6,1/5] drm: Add function to convert rect in 16.16 fixed format to regular format

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [v6,1/5] drm: Add function to convert rect in 16.16 fixed format to regular format URL : https://patchwork.freedesktop.org/series/84910/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file ./drive

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v6,1/5] drm: Add function to convert rect in 16.16 fixed format to regular format

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [v6,1/5] drm: Add function to convert rect in 16.16 fixed format to regular format URL : https://patchwork.freedesktop.org/series/84910/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, ea

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] dma-buf: Remove kmap kerneldoc vestiges (rev2)

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [1/4] dma-buf: Remove kmap kerneldoc vestiges (rev2) URL : https://patchwork.freedesktop.org/series/84849/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9481 -> Patchwork_19138 =

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/4] dma-buf: Remove kmap kerneldoc vestiges (rev2)

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [1/4] dma-buf: Remove kmap kerneldoc vestiges (rev2) URL : https://patchwork.freedesktop.org/series/84849/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file ./drivers/gpu/drm/i915/gt/intel_lrc.c

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] dma-buf: Remove kmap kerneldoc vestiges (rev2)

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [1/4] dma-buf: Remove kmap kerneldoc vestiges (rev2) URL : https://patchwork.freedesktop.org/series/84849/ State : warning == Summary == $ dim checkpatch origin/drm-tip 431d5d802932 dma-buf: Remove kmap kerneldoc vestiges -:115: WARNING:FROM_S

[Intel-gfx] [PATCH v6 5/5] HAX/DO_NOT_MERGE_IT: drm/i915/display: Enable PSR2 selective fetch for testing

2020-12-14 Thread José Roberto de Souza
Enabling it to check if it causes regressions in CI but the feature is still not ready to be enabled by default. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/d

[Intel-gfx] [PATCH v6 4/5] drm/i915/display/psr: Program plane's calculated offset to plane SF register

2020-12-14 Thread José Roberto de Souza
It programs Plane's calculated x, y, offset to Plane SF register. It does the calculation of x and y offsets using skl_calc_main_surface_offset(). v3: Update commit message Cc: Gwan-gyeong Mun Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza Reviewed-by: Gwan-gyeong Mun Tested-by: Gwan-

[Intel-gfx] [PATCH v6 2/5] drm/i915/display/psr: Use plane damage clips to calculate damaged area

2020-12-14 Thread José Roberto de Souza
Now using plane damage clips property to calcualte the damaged area. Selective fetch only supports one region to be fetched so software needs to calculate a bounding box around all damage clips. Now that we are not complete fetching each plane, there is another loop needed as all the plane areas t

[Intel-gfx] [PATCH v6 3/5] drm/i915/display: Split and export main surface calculation from skl_check_main_surface()

2020-12-14 Thread José Roberto de Souza
The calculation the offsets of the main surface will be needed by PSR2 selective fetch code so here splitting and exporting it. No functional changes were done here. v3: Rebased Cc: Gwan-gyeong Mun Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza Reviewed-by: Gwan-gyeong Mun Tested-by:

[Intel-gfx] [PATCH v6 1/5] drm: Add function to convert rect in 16.16 fixed format to regular format

2020-12-14 Thread José Roberto de Souza
Much more clear to read one function call than four lines doing this conversion. Cc: dri-de...@lists.freedesktop.org Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/drm_rect.c | 15 +++ include/drm/drm_rect.h | 2 ++ 2 files changed, 17 insertions(+

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915/display: Support Multiple Transcoders' PSR status on debugfs

2020-12-14 Thread Mun, Gwan-gyeong
On Mon, 2020-12-14 at 13:35 +0200, Jani Nikula wrote: > On Mon, 14 Dec 2020, Anshuman Gupta wrote: > > On 2020-12-11 at 19:14:21 +0200, Gwan-gyeong Mun wrote: > > > In order to support the PSR state of each transcoder, it adds > > > i915_psr_status to sub-directory of each transcoder. > > > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reduce duplicated switch cases in hpd code (rev2)

2020-12-14 Thread Patchwork
== Series Details == Series: drm/i915: Reduce duplicated switch cases in hpd code (rev2) URL : https://patchwork.freedesktop.org/series/84593/ State : success == Summary == CI Bug Log - changes from CI_DRM_9481 -> Patchwork_19137 Summary --

[Intel-gfx] [PATCH] dma-buf: begin/end_cpu might lock the dma_resv lock

2020-12-14 Thread Daniel Vetter
At least amdgpu and i915 do, so lets just document this as the rule. v2: Works better with less typos (intel-gfx-ci) Signed-off-by: Daniel Vetter Cc: Thomas Zimmermann Cc: Sumit Semwal Cc: "Christian König" Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org --- drivers/dma-bu

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Reduce duplicated switch cases in hpd code (rev2)

2020-12-14 Thread Patchwork
== Series Details == Series: drm/i915: Reduce duplicated switch cases in hpd code (rev2) URL : https://patchwork.freedesktop.org/series/84593/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file ./drivers/gpu/drm/i915/gt/intel_lrc.c WARNING: kerne

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915/display: Support PSR Multiple Transcoders

2020-12-14 Thread Mun, Gwan-gyeong
On Mon, 2020-12-14 at 13:33 +0200, Jani Nikula wrote: > On Fri, 11 Dec 2020, Gwan-gyeong Mun > wrote: > > It is a preliminary work for supporting multiple EDP PSR and > > DP PanelReplay. And it refactors singleton PSR to Multi Transcoder > > supportable PSR. > > And this moves and renames the i915

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix ICL MG PHY vswing handling (rev2)

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix ICL MG PHY vswing handling (rev2) URL : https://patchwork.freedesktop.org/series/84651/ State : success == Summary == CI Bug Log - changes from CI_DRM_9481 -> Patchwork_19136

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_vm_create: Race vm-destroy against object free

2020-12-14 Thread Chris Wilson
Quoting Matthew Auld (2020-12-14 15:52:06) > On 08/12/2020 17:02, Chris Wilson wrote: > > Matthew postulated that we should be able to hit a race in > > __i915_vm_close() between the RCU object free and vma unbind viz > > > >GEM_BUG_ON(!list_empty(&vm->bound_list)); > > > > due to the effect

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915: Fix ICL MG PHY vswing handling (rev2)

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix ICL MG PHY vswing handling (rev2) URL : https://patchwork.freedesktop.org/series/84651/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file ./drivers/gpu/drm/i915/gt/intel_lrc.

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/4] i915/gem_shrink: Refactor allocation sizing based on available memory

2020-12-14 Thread Chris Wilson
Quoting Chris Wilson (2020-12-14 16:21:53) > Quoting Tvrtko Ursulin (2020-12-14 15:57:59) > > > > On 14/12/2020 10:51, Chris Wilson wrote: > > > Refactor the allocation such that we utilise just enough memory pressure > > > to invoke the shrinker, and just enough processes to spread across the > >

Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-12-14 Thread Imre Deak
On Fri, Dec 11, 2020 at 09:04:02AM +0200, Chery, Nanley G wrote: > [...] > > > We probably don't have to update the header, but we noticed in our > > > testing that the clear color prefers an alignment greater than 64B. > > > Unfortunately, I can't find any bspec note about this. As long as the > >

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/4] i915/gem_shrink: Refactor allocation sizing based on available memory

2020-12-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-12-14 15:57:59) > > On 14/12/2020 10:51, Chris Wilson wrote: > > Refactor the allocation such that we utilise just enough memory pressure > > to invoke the shrinker, and just enough processes to spread across the > > CPUs and contend on the shrinker. > > > > Signed-of

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/4] i915/perf_pmu: Verify RC6 measurements before/after suspend

2020-12-14 Thread Chris Wilson
Quoting Chris Wilson (2020-12-14 16:17:05) > Quoting Tvrtko Ursulin (2020-12-14 16:08:34) > > > > On 14/12/2020 15:49, Chris Wilson wrote: > > > Quoting Tvrtko Ursulin (2020-12-14 15:42:20) > > >> > > >> On 14/12/2020 10:51, Chris Wilson wrote: > > >>> RC6 should work before suspend, and continue

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/4] i915/perf_pmu: Verify RC6 measurements before/after suspend

2020-12-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-12-14 16:08:34) > > On 14/12/2020 15:49, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-12-14 15:42:20) > >> > >> On 14/12/2020 10:51, Chris Wilson wrote: > >>> RC6 should work before suspend, and continue to increment while idle > >>> after suspend. Should. > >>

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/4] i915/perf_pmu: Verify RC6 measurements before/after suspend

2020-12-14 Thread Tvrtko Ursulin
On 14/12/2020 15:49, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-12-14 15:42:20) On 14/12/2020 10:51, Chris Wilson wrote: RC6 should work before suspend, and continue to increment while idle after suspend. Should. v2: Include a longer sleep after suspend; it appears we are reticent to

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/4] i915/gem_exec_balancer: Measure timeslicing fairness

2020-12-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-12-14 15:51:24) > > On 14/12/2020 10:51, Chris Wilson wrote: > > Oversaturate the virtual engines on the system and check that each > > workload receives a fair share of the available GPU time. > > A simpler one to start with, I support that. > > > > > Signed-off-by

Re: [Intel-gfx] [PATCH 1/4] dma-buf: Remove kmap kerneldoc vestiges

2020-12-14 Thread Daniel Vetter
On Mon, Dec 14, 2020 at 11:33:10AM +0100, Christian König wrote: > Am 11.12.20 um 16:58 schrieb Daniel Vetter: > > Also try to clarify a bit when dma_buf_begin/end_cpu_access should > > be called. > > > > Signed-off-by: Daniel Vetter > > Cc: Thomas Zimmermann > > Cc: Sumit Semwal > > Cc: "Chris

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915/display: Support PSR Multiple Transcoders

2020-12-14 Thread Mun, Gwan-gyeong
On Mon, 2020-12-14 at 16:32 +0530, Anshuman Gupta wrote: > On 2020-12-11 at 19:14:20 +0200, Gwan-gyeong Mun wrote: > > It is a preliminary work for supporting multiple EDP PSR and > > DP PanelReplay. And it refactors singleton PSR to Multi Transcoder > > supportable PSR. > > And this moves and rena

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/69] drm/i915: Use cmpxchg64 for 32b compatilibity

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [01/69] drm/i915: Use cmpxchg64 for 32b compatilibity URL : https://patchwork.freedesktop.org/series/84900/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9478_full -> Patchwork_19133_full ==

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/4] i915/gem_shrink: Refactor allocation sizing based on available memory

2020-12-14 Thread Tvrtko Ursulin
On 14/12/2020 10:51, Chris Wilson wrote: Refactor the allocation such that we utilise just enough memory pressure to invoke the shrinker, and just enough processes to spread across the CPUs and contend on the shrinker. Signed-off-by: Chris Wilson --- tests/i915/gem_shrink.c | 11 ++-

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_vm_create: Race vm-destroy against object free

2020-12-14 Thread Matthew Auld
On 08/12/2020 17:02, Chris Wilson wrote: Matthew postulated that we should be able to hit a race in __i915_vm_close() between the RCU object free and vma unbind viz GEM_BUG_ON(!list_empty(&vm->bound_list)); due to the effect of leaving the vma on the list if we are unable to obtain the kref

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/4] i915/gem_exec_balancer: Measure timeslicing fairness

2020-12-14 Thread Tvrtko Ursulin
On 14/12/2020 10:51, Chris Wilson wrote: Oversaturate the virtual engines on the system and check that each workload receives a fair share of the available GPU time. A simpler one to start with, I support that. Signed-off-by: Chris Wilson --- tests/i915/gem_exec_balancer.c | 154 +++

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/4] i915/perf_pmu: Verify RC6 measurements before/after suspend

2020-12-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-12-14 15:42:20) > > On 14/12/2020 10:51, Chris Wilson wrote: > > RC6 should work before suspend, and continue to increment while idle > > after suspend. Should. > > > > v2: Include a longer sleep after suspend; it appears we are reticent to > > idle so soon after waki

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/4] i915/perf_pmu: Verify RC6 measurements before/after suspend

2020-12-14 Thread Tvrtko Ursulin
On 14/12/2020 10:51, Chris Wilson wrote: RC6 should work before suspend, and continue to increment while idle after suspend. Should. v2: Include a longer sleep after suspend; it appears we are reticent to idle so soon after waking up. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tes

[Intel-gfx] ✗ Fi.CI.DOCS: warning for HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev8)

2020-12-14 Thread Patchwork
== Series Details == Series: HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev8) URL : https://patchwork.freedesktop.org/series/82998/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file ./drivers/gpu/drm/i915/gt/intel_lrc.c WARNING: kernel-doc './s

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev8)

2020-12-14 Thread Patchwork
== Series Details == Series: HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev8) URL : https://patchwork.freedesktop.org/series/82998/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./drivers/gpu

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Individual request cancellation

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Individual request cancellation URL : https://patchwork.freedesktop.org/series/84906/ State : success == Summary == CI Bug Log - changes from CI_DRM_9481 -> Patchwork_19134 S

Re: [Intel-gfx] [patch 23/30] net/mlx5: Use effective interrupt affinity

2020-12-14 Thread Tariq Toukan
On 12/10/2020 9:25 PM, Thomas Gleixner wrote: Using the interrupt affinity mask for checking locality is not really working well on architectures which support effective affinity masks. The affinity mask is either the system wide default or set by user space, but the architecture can or even

Re: [Intel-gfx] [patch 21/30] net/mlx4: Use effective interrupt affinity

2020-12-14 Thread Tariq Toukan
On 12/10/2020 9:25 PM, Thomas Gleixner wrote: Using the interrupt affinity mask for checking locality is not really working well on architectures which support effective affinity masks. The affinity mask is either the system wide default or set by user space, but the architecture can or even

Re: [Intel-gfx] [patch 20/30] net/mlx4: Replace irq_to_desc() abuse

2020-12-14 Thread Tariq Toukan
On 12/10/2020 9:25 PM, Thomas Gleixner wrote: No driver has any business with the internals of an interrupt descriptor. Storing a pointer to it just to use yet another helper at the actual usage site to retrieve the affinity mask is creative at best. Just because C does not allow encapsulation

Re: [Intel-gfx] [patch 22/30] net/mlx5: Replace irq_to_desc() abuse

2020-12-14 Thread Tariq Toukan
On 12/10/2020 9:25 PM, Thomas Gleixner wrote: No driver has any business with the internals of an interrupt descriptor. Storing a pointer to it just to use yet another helper at the actual usage site to retrieve the affinity mask is creative at best. Just because C does not allow encapsulation

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915: Individual request cancellation

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Individual request cancellation URL : https://patchwork.freedesktop.org/series/84906/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file ./drivers/gpu/drm/i915/gt/intel_lrc.c WARNI

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Individual request cancellation

2020-12-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Individual request cancellation URL : https://patchwork.freedesktop.org/series/84906/ State : warning == Summary == $ dim checkpatch origin/drm-tip 27629d7496f4 drm/i915: Individual request cancellation -:318: CHECK:LINE_SPACING

[Intel-gfx] [PATCH v8 04/19] drm/i915/hdcp: No HDCP when encoder is't initialized

2020-12-14 Thread Anshuman Gupta
There can be situation when DP MST connector is created without mst modeset being done, in those cases connector->encoder will be NULL. MST connector->encoder initializes after modeset. Don't enable HDCP in such cases to prevent any crash. Cc: Ramalingam C Cc: Juston Li Tested-by: Karthik B S R

Re: [Intel-gfx] [PATCH v5 3/6] drm/i915/display/psr: Use plane damage clips to calculate damaged area

2020-12-14 Thread Souza, Jose
On Mon, 2020-12-14 at 11:00 +, Mun, Gwan-gyeong wrote: > On Sun, 2020-12-13 at 10:39 -0800, José Roberto de Souza wrote: > > Now using plane damage clips property to calcualte the damaged area. > > Selective fetch only supports one region to be fetched so software > > needs to calculate a bound

Re: [Intel-gfx] [PATCH v4 16/16] drm/i915: Enable PCON configuration for Color Conversion for TGL

2020-12-14 Thread Nautiyal, Ankit K
On 12/13/2020 12:59 PM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Tuesday, December 8, 2020 1:22 PM To: intel-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org; Shankar, Uma ; airl...@linux.ie; jani.nik...@linux.intel.com; ville.syrj...@linux.int

Re: [Intel-gfx] [PATCH v8 18/19] drm/i915/hdcp: Configure HDCP2.2 MST steram encryption status

2020-12-14 Thread Ramalingam C
On 2020-12-11 at 19:12:43 +0530, Anshuman Gupta wrote: > Authenticate and enable port encryption only once for > an active HDCP 2.2 session, once port is authenticated > and encrypted enable encryption for each stream that > requires encryption on this port. > > Similarly disable the stream encryp

Re: [Intel-gfx] [PATCH v8 17/19] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-12-14 Thread Ramalingam C
On 2020-12-11 at 19:12:42 +0530, Anshuman Gupta wrote: > Add support for HDCP 2.2 DP MST shim callback. > This adds existing DP HDCP shim callback for Link Authentication > and Encryption and HDCP 2.2 stream encryption > callback. > > v2: > - Added a WARN_ON() instead of drm_err. [Uma] > - Cosmeti

  1   2   3   >