Re: [Intel-gfx] [PATCH][next] drm/i915/hdcp: Fix null pointer dereference of connector->encoder

2021-02-25 Thread Gupta, Anshuman
> -Original Message- > From: Colin King > Sent: Wednesday, February 24, 2021 12:49 AM > To: Jani Nikula ; Joonas Lahtinen > ; Vivi, Rodrigo ; > David Airlie ; Daniel Vetter ; C, > Ramalingam > ; Gupta, Anshuman ; > intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Cc:

Re: [Intel-gfx] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread John Stultz
On Tue, Feb 23, 2021 at 3:00 AM Daniel Vetter wrote: > > tldr; DMA buffers aren't normal memory, expecting that you can use > them like that (like calling get_user_pages works, or that they're > accounting like any other normal memory) cannot be guaranteed. > > Since some userspace only runs on

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/uc: Use platform specific defaults for GuC/HuC enabling (rev3)

2021-02-25 Thread Patchwork
== Series Details == Series: drm/i915/uc: Use platform specific defaults for GuC/HuC enabling (rev3) URL : https://patchwork.freedesktop.org/series/86100/ State : success == Summary == CI Bug Log - changes from CI_DRM_9809_full -> Patchwork_19730_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/uc: Use platform specific defaults for GuC/HuC enabling (rev3)

2021-02-25 Thread Patchwork
== Series Details == Series: drm/i915/uc: Use platform specific defaults for GuC/HuC enabling (rev3) URL : https://patchwork.freedesktop.org/series/86100/ State : success == Summary == CI Bug Log - changes from CI_DRM_9809 -> Patchwork_19730

[Intel-gfx] [PATCH] drm/i915/uc: Use platform specific defaults for GuC/HuC enabling

2021-02-25 Thread John . C . Harrison
From: John Harrison The meaning of 'default' for the enable_guc module parameter has been updated to accurately reflect what is supported on current platforms. So start using the defaults instead of forcing everything off. Although, note that right now, the default is for everything to be off

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Move DDI clock readout to encoder->get_config() (rev2)

2021-02-25 Thread Patchwork
== Series Details == Series: drm/i915: Move DDI clock readout to encoder->get_config() (rev2) URL : https://patchwork.freedesktop.org/series/87351/ State : success == Summary == CI Bug Log - changes from CI_DRM_9804_full -> Patchwork_19729_full

Re: [Intel-gfx] udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-25 Thread Pavel Machek
Hi! > > > > This is in -next, but I get same behaviour on 5.11; and no, udl does > > > > > > Thanks for reporting. We are in the process of fixing the issue. The > > > latest > > > patch is at [1]. > > > > > > > Thank you, that fixes the DMA issue, and I can use the udl. > > > > ...for a

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move DDI clock readout to encoder->get_config() (rev2)

2021-02-25 Thread Patchwork
== Series Details == Series: drm/i915: Move DDI clock readout to encoder->get_config() (rev2) URL : https://patchwork.freedesktop.org/series/87351/ State : success == Summary == CI Bug Log - changes from CI_DRM_9804 -> Patchwork_19729

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Christian König
Am 25.02.21 um 16:49 schrieb Daniel Vetter: On Thu, Feb 25, 2021 at 11:44 AM Daniel Vetter wrote: On Thu, Feb 25, 2021 at 11:28:31AM +0100, Christian König wrote: Am 24.02.21 um 10:31 schrieb Daniel Vetter: On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) wrote: On 2/24/21 9:45

Re: [Intel-gfx] [PATCH] drm/compat: Clear bounce structures

2021-02-25 Thread Maxime Ripard
On Mon, Feb 22, 2021 at 11:06:43AM +0100, Daniel Vetter wrote: > Some of them have gaps, or fields we don't clear. Native ioctl code > does full copies plus zero-extends on size mismatch, so nothing can > leak. But compat is more hand-rolled so need to be careful. > > None of these matter for

Re: [Intel-gfx] [PATCH] drm/compat: more dummy implementations

2021-02-25 Thread Maxime Ripard
On Mon, Feb 22, 2021 at 11:06:08AM +0100, Daniel Vetter wrote: > drm_noop really doesnt do much, and who cares about the permission checks. ^ doesn't > So let's delete some code. With the typo fixed, Acked-by: Maxime Ripard Maxime > > Signed-off-by: Daniel Vetter > --- >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Move DDI clock readout to encoder->get_config() (rev2)

2021-02-25 Thread Patchwork
== Series Details == Series: drm/i915: Move DDI clock readout to encoder->get_config() (rev2) URL : https://patchwork.freedesktop.org/series/87351/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v2 2/6] drm/i915: Do intel_dpll_readout_hw_state() after encoder readout

2021-02-25 Thread Ville Syrjala
From: Ville Syrjälä The clock readout for DDI encoders needs to moved into the encoders. To that end intel_dpll_readout_hw_state() needs to happen after the encoder readout as otherwise it can't correctly populate the PLL crtc_mask/active_mask bitmasks. v2: Populate DPLL ref clocks before the

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 11:44 AM Daniel Vetter wrote: > > On Thu, Feb 25, 2021 at 11:28:31AM +0100, Christian König wrote: > > Am 24.02.21 um 10:31 schrieb Daniel Vetter: > > > On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) > > > wrote: > > > > > > > > On 2/24/21 9:45 AM, Daniel

[Intel-gfx] [PULL] drm-intel-next-fixes

2021-02-25 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-next-fixes-2021-02-25: A fix for color format check from Ville, plus the re-enable of -Wuninitialized from Nathan, and the GVT fixes including fixes for ww locking, cmd parser and a general cleanup of dev_priv->gt. Thanks, Rodrigo. The following changes

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Christian König
Am 24.02.21 um 10:31 schrieb Daniel Vetter: On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) wrote: On 2/24/21 9:45 AM, Daniel Vetter wrote: On Wed, Feb 24, 2021 at 8:46 AM Thomas Hellström (Intel) wrote: On 2/23/21 11:59 AM, Daniel Vetter wrote: tldr; DMA buffers aren't normal

Re: [Intel-gfx] [5.10.y regression] i915 clear-residuals mitigation is causing gfx issues

2021-02-25 Thread Hans de Goede
Hi Chris, On 2/11/21 11:49 AM, Chris Wilson wrote: > Quoting Hans de Goede (2021-02-11 10:36:13) >> Hi, >> >> On 2/10/21 1:48 PM, Chris Wilson wrote: >>> Quoting Hans de Goede (2021-02-10 10:37:19) Hi, On 2/10/21 12:07 AM, Chris Wilson wrote: > Quoting Hans de Goede (2021-02-09

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] dma-buf: Require VM_PFNMAP vma for mmap (rev3)

2021-02-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] dma-buf: Require VM_PFNMAP vma for mmap (rev3) URL : https://patchwork.freedesktop.org/series/87313/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9804 -> Patchwork_19728

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 11:30:23AM +0100, Christian König wrote: > > > Am 24.02.21 um 19:46 schrieb Jason Gunthorpe: > > On Wed, Feb 24, 2021 at 09:45:51AM +0100, Daniel Vetter wrote: > > > > > Hm I figured everyone just uses MAP_SHARED for buffer objects since > > > COW really makes absolutely

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 11:28:31AM +0100, Christian König wrote: > Am 24.02.21 um 10:31 schrieb Daniel Vetter: > > On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) > > wrote: > > > > > > On 2/24/21 9:45 AM, Daniel Vetter wrote: > > > > On Wed, Feb 24, 2021 at 8:46 AM Thomas Hellström

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] dma-buf: Require VM_PFNMAP vma for mmap (rev3)

2021-02-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] dma-buf: Require VM_PFNMAP vma for mmap (rev3) URL : https://patchwork.freedesktop.org/series/87313/ State : warning == Summary == $ dim checkpatch origin/drm-tip b71cc38b23b9 dma-buf: Require VM_PFNMAP vma for mmap -:34:

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Christian König
Am 24.02.21 um 19:46 schrieb Jason Gunthorpe: On Wed, Feb 24, 2021 at 09:45:51AM +0100, Daniel Vetter wrote: Hm I figured everyone just uses MAP_SHARED for buffer objects since COW really makes absolutely no sense. How would we enforce this? In RDMA we test

[Intel-gfx] [PATCH] drm/vgem: use shmem helpers

2021-02-25 Thread Daniel Vetter
Aside from deleting lots of code the real motivation here is to switch the mmap over to VM_PFNMAP, to be more consistent with what real gpu drivers do. They're all VM_PFNMP, which means get_user_pages doesn't work, and even if you try and there's a struct page behind that, touching it and mucking

Re: [Intel-gfx] udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-25 Thread Pavel Machek
Hi! > > Thank you, that fixes the DMA issue, and I can use the udl. > > > > ...for a while. Then screensaver blanks laptop screen, udl screen > > blanks too. Upon hitting a key, internal screen shows up, udl does > > not. > > > > I try rerunning xrandr ... --auto, but could not recover it. > >

Re: [Intel-gfx] udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-25 Thread Thomas Zimmermann
Hi Am 25.02.21 um 10:53 schrieb Pavel Machek: Hi! This is in -next, but I get same behaviour on 5.11; and no, udl does Thanks for reporting. We are in the process of fixing the issue. The latest patch is at [1]. Thank you, that fixes the DMA issue, and I can use the udl. ...for a while.

[Intel-gfx] udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-25 Thread Pavel Machek
Hi! > >This is in -next, but I get same behaviour on 5.11; and no, udl does > > Thanks for reporting. We are in the process of fixing the issue. The latest > patch is at [1]. > Thank you, that fixes the DMA issue, and I can use the udl. ...for a while. Then screensaver blanks laptop screen,

[Intel-gfx] [PULL] drm-misc-next-fixes

2021-02-25 Thread Maarten Lankhorst
drm-misc-next-fixes-2021-02-25: drm-misc-next tasty fixes for v5.12: - Cherry pick of drm-misc-fixes pull: "here's this week's PR for drm-misc-fixes. One of the patches is a memory leak; the rest is for hardware issues." - Fix dt bindings for dp connector. - Fix build error in atyfb. - Improve

Re: [Intel-gfx] [PULL] drm-misc-fixes

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 8:53 AM Thomas Zimmermann wrote: > > Hi > > Am 25.02.21 um 02:55 schrieb Dave Airlie: > > On Wed, 24 Feb 2021 at 20:27, Thomas Zimmermann wrote: > >> > >> Hi Dave and Daniel, > >> > >> here's this week's PR for drm-misc-fixes. One of the patches is a memory > >> leak; the

Re: [Intel-gfx] [PULL] drm-misc-fixes

2021-02-25 Thread Maxime Ripard
Hi, On Thu, Feb 25, 2021 at 08:53:42AM +0100, Thomas Zimmermann wrote: > Am 25.02.21 um 02:55 schrieb Dave Airlie: > > On Wed, 24 Feb 2021 at 20:27, Thomas Zimmermann wrote: > > > > > > Hi Dave and Daniel, > > > > > > here's this week's PR for drm-misc-fixes. One of the patches is a memory > >

Re: [Intel-gfx] udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-25 Thread Thomas Zimmermann
Hi Am 24.02.21 um 21:09 schrieb Pavel Machek: Hi! This is in -next, but I get same behaviour on 5.11; and no, udl does Thanks for reporting. We are in the process of fixing the issue. The latest patch is at [1]. Best regards Thomas [1]