[Intel-gfx] [PATCH v4 3/3] drm/i915/display: Configure HDMI2.1 Pcon for FRL only if Src-Ctl mode is available

Add the check if source control mode is supported by the PCON, before starting configuring PCON for FRL training, as per spec VESA DP2.0-HDMI2.1 PCON Draft-1 Sec-7. v2: Added spec details for the change. (Uma) Signed-off-by: Ankit Nautiyal Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/disp

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add state checker for CSC coeff values

== Series Details == Series: drm/i915: Add state checker for CSC coeff values URL : https://patchwork.freedesktop.org/series/88242/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6b4acba31287 drm/i915/display: Introduce vfunc read_csc() to create hw ctm 36688ee5a039 drm/i915/dis

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Add state checker for CSC coeff values

== Series Details == Series: drm/i915: Add state checker for CSC coeff values URL : https://patchwork.freedesktop.org/series/88242/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/dr

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Add state checker for CSC coeff values

== Series Details == Series: drm/i915: Add state checker for CSC coeff values URL : https://patchwork.freedesktop.org/series/88242/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9879 -> Patchwork_19820 Summary --- **

Re: [Intel-gfx] [PATCH 27/30] drm/dp_mst: Pass drm_dp_mst_topology_mgr to drm_dp_get_vc_payload_bw()

Hey Lyude, Thanks for the patch. On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote: > > Since this is one of the few functions in drm_dp_mst_topology.c that > doesn't have any way of getting access to a drm_device, let's pass the > drm_dp_mst_topology_mgr down to this function so that it can use >

[Intel-gfx] [bug report] drm/i915: Computer does not shutdown,

Hello, It seems, like the mailing list, didn't accept my email. So I'll send it again: I want to report a bug. I have a PC with Intel i7-6700K processor (with integrated graphics) and an AsRock Fatal1ty Z170 Gaming K6 mainboard. I use the CPU's integrated graphics. My system is Archlinux with Ker

Re: [Intel-gfx] drm/i915: Fix DP LTTPR link training mode initialization

Tested-by: Zephaniah E. Loss-Cutler-Hull ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 12/30] drm/bridge/analogix/anx6345: Cleanup on errors in anx6345_bridge_attach()

Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote: > > Another drive-by fix I found when fixing DP AUX adapter across the kernel > tree - make sure we don't leak resources (and by proxy-AUX adapters) on > failures in a

Re: [Intel-gfx] [PATCH 28/30] drm/dp: Convert drm_dp_helper.c to using drm_err/drm_dbg_*()

Hey Lyude, Thanks for the patch. On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote: > > Now that we've added a back-pointer to drm_device to drm_dp_aux, made > drm_dp_aux available to any functions in drm_dp_helper.c which need to > print to the kernel log, and ensured all of our logging uses a con

Re: [Intel-gfx] [PATCH 04/30] drm/bridge/tc358767: Don't register DP AUX channel until bridge is attached

Hey Lyude, This patch looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote: > > Since this is a bridge, we don't start out with a respective DRM device. > Likewise this means we don't have a connector, which also means that we > should be following drm_dp_a

[Intel-gfx] [PATCH] gpu: drm: i915: gt: Rudimentary typo fix in the file intel_timeline.c

s/bariers/barriers/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c index 8015964043eb..2b921c1796dc 100644 ---

Re: [Intel-gfx] [PATCH 08/30] drm/bridge/analogix/anx78xx: Setup encoder before registering connector

Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote: > > Since encoder mappings for connectors are exposed to userspace, we should > be attaching the encoder before exposing the connector to userspace. Just a > drive-by

[Intel-gfx] BUG in i915/i915_pci.c, commit fe0f1e3

Hello, I want to report a bug. I have a PC with Intel i7-6700K processor (with integrated graphics) and an AsRock Fatal1ty Z170 Gaming K6 mainboard. I use the CPU's integrated graphics. My system is Archlinux with Kernel v5.11.6. Using this setup, my PC works normally. However, when I shut it dow

Re: [Intel-gfx] [PATCH 09/30] drm/bridge/analogix/anx78xx: Cleanup on error in anx78xx_bridge_attach()

Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote: > > Just another issue I noticed while correcting usages of > drm_dp_aux_init()/drm_dp_aux_register() around the tree. If any of the > steps in anx78xx_bridge_attach()

Re: [Intel-gfx] [PATCH 11/30] drm/bridge/analogix/anx6345: Don't link encoder until after connector registration

Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote: > > Another case of linking an encoder to a connector after the connector's > been registered. The proper place to do this is before connector > registration, so let's

Re: [Intel-gfx] [PATCH 18/30] drm/print: Fixup DRM_DEBUG_KMS_RATELIMITED()

Hey Lyude, Thanks for the patch, On Fri, 19 Feb 2021 at 22:59, Lyude Paul wrote: > > Since we're about to move drm_dp_helper.c over to drm_dbg_*(), we'll want > to make sure that we can also add ratelimited versions of these macros in > order to retain some of the previous debugging output behav

Re: [Intel-gfx] [PATCH 10/30] drm/bridge/analogix/anx6345: Add missing drm_dp_aux_unregister() call

Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote: > > Another driver I found that seems to forget to unregister it's DP AUX > device. Let's fix this by adding anx6345_bridge_detach(). > > Signed-off-by: Lyude Paul >

[Intel-gfx] [PATCH] drm: i915: Fix a typo

s/nothign/nothing/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c index f6ad257a260e..14d784a6f

Re: [Intel-gfx] drm/i915: Fix DP LTTPR link training mode initialization

Acked-By: Zephaniah E. Loss-Cutler-Hull ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915/gt: A typo fix

s/bariers/barriers/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c index 037b0e3ccbed..25fc7f44fee0 100644 ---

Re: [Intel-gfx] [PATCH 13/30] drm/bridge/analogix/dp_core: Unregister DP AUX channel on error in analogix_dp_probe()

Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote: > > Just another drive-by fix I noticed while going through the tree to cleanup > DP aux adapter registration - make sure we unregister the DP AUX dev if > analogix_dp

Re: [Intel-gfx] [PATCH 07/30] drm/bridge/analogix/anx78xx: Add missing drm_dp_aux_unregister() call

Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote: > > Surprisingly, this bridge actually registers it's AUX adapter at the > correct time already. Nice job! However, it does forget to actually > unregister the AUX ada

Re: [Intel-gfx] [PATCH 30/30] drm/dp_mst: Convert drm_dp_mst_topology.c to drm_err()/drm_dbg*()

Hey Lyude, Thanks for the patch On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote: > > And finally, convert all of the code in drm_dp_mst_topology.c over to using > drm_err() and drm_dbg*(). Note that this refactor would have been a lot > more complicated to have tried writing a coccinelle script f

[Intel-gfx] [PATCH] display: Fix typo issue

From: zuoqilin Change 'befor' to 'before'. Signed-off-by: zuoqilin --- drivers/gpu/drm/i915/display/vlv_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c index f94025e..45187ff 100644 --- a

Re: [Intel-gfx] [bug report] drm/i915: Computer does not shutdown,

Hi, On 3/14/21 11:30 AM, Mario Hüttel wrote: > Hello, > > It seems, like the mailing list, didn't accept my email. So I'll send > it again: > > I want to report a bug. I have a PC with Intel i7-6700K processor (with > integrated graphics) and an AsRock Fatal1ty Z170 Gaming K6 mainboard. I > use

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

On Sat, 20 Mar 2021 at 14:48, Jason Ekstrand wrote: > > On Fri, Mar 19, 2021 at 5:39 PM Jason Ekstrand wrote: > > > > This reverts commit 88be76cdafc7e60e2e4ed883bfe7e8dd7f35fa3a. This API > > has never been used by any real userspace. > > After further digging, there is a compute-runtime PR for

[Intel-gfx] ✗ Fi.CI.BUILD: failure for HDMI2.1 PCON Misc Fixes (rev4)

== Series Details == Series: HDMI2.1 PCON Misc Fixes (rev4) URL : https://patchwork.freedesktop.org/series/86677/ State : failure == Summary == Applying: drm/dp_helper: Define options for FRL training for HDMI2.1 PCON Applying: drm/i915/display: Remove FRL related code from disable DP sequence

[Intel-gfx] [PATCH] drm/i915/display: Disable PSR2 on ADLS

In light of PSR2 can be enabled only on BOM9 platform team has requested to disable PSR2 by default in driver, starting with gfx-driver-ci-master-7517. Disabling it for ADLS. Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[Intel-gfx] [PATCH V2] drm/i915/display: Disable PSR2 on Gen12/12+

In light of PSR2 can be enabled only on BOM9 platform team has requested to disable PSR2 by default in driver, starting with gfx-driver-ci-master-7517. Disabling it for all gen12/12+. Changes since V1 : - Added check for GEN12/12+ - Modified commit message accoringly Signed-off-by

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

On 19/03/2021 22:38, Jason Ekstrand wrote: This API allows one context to grab bits out of another context upon creation. It can be used as a short-cut for setparam(getparam()) for things like I915_CONTEXT_PARAM_VM. However, it's never been used by any real userspace. It's used by a few IGT

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: i915: Fix a typo

== Series Details == Series: drm: i915: Fix a typo URL : https://patchwork.freedesktop.org/series/88255/ State : failure == Summary == Applying: drm: i915: Fix a typo Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/display/intel_dpll_mgr.c Falling back to patching b

[Intel-gfx] ✓ Fi.CI.BAT: success for gpu: drm: i915: gt: Rudimentary typo fix in the file intel_timeline.c

== Series Details == Series: gpu: drm: i915: gt: Rudimentary typo fix in the file intel_timeline.c URL : https://patchwork.freedesktop.org/series/88254/ State : success == Summary == CI Bug Log - changes from CI_DRM_9880 -> Patchwork_19822

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: uAPI clean-ups part 2

On Fri, 19 Mar 2021, Patchwork wrote: > == Series Details == > > Series: drm/i915: uAPI clean-ups part 2 > URL : https://patchwork.freedesktop.org/series/88196/ > State : failure > > == Summary == > > Applying: drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE > Applying: drm/i915: Drop I915_CONTEXT_PA

Re: [Intel-gfx] [PATCH] drm/i915/audio: set HDA link parameters in driver

Hi, On Fri, 12 Feb 2021, Kai Vehmanen wrote: > Update logic to program AUD_FREQ_CNTRL register based on new guidance. > Earlier this register was configured by BIOS and driver discovered the > value at init. This is no longer recommended and instead driver should > set the values based on the har

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: A typo fix

== Series Details == Series: drm/i915/gt: A typo fix URL : https://patchwork.freedesktop.org/series/88256/ State : success == Summary == CI Bug Log - changes from CI_DRM_9880 -> Patchwork_19824 Summary --- **SUCCESS** No regressio

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

On Sat, 20 Mar 2021, Jason Ekstrand wrote: > This reverts commit 88be76cdafc7e60e2e4ed883bfe7e8dd7f35fa3a. This API Small nit, I think it would be useful to reference commits with the citation style: 88be76cdafc7 ("drm/i915: Allow userspace to specify ringsize on construction") I use this

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for display: Fix typo issue

== Series Details == Series: display: Fix typo issue URL : https://patchwork.freedesktop.org/series/88257/ State : warning == Summary == $ dim checkpatch origin/drm-tip c0f358be8b75 display: Fix typo issue -:19: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

On 19/03/2021 22:38, Jason Ekstrand wrote: I'd love to delete the SINGLE_TIMELINE API because it leaks an implementation detail of contexts through to the API and is something that userspace can do itself, trivially. Unfortunately, it's used by the media driver so we can't do that. We can, ho

[Intel-gfx] ✓ Fi.CI.BAT: success for display: Fix typo issue

== Series Details == Series: display: Fix typo issue URL : https://patchwork.freedesktop.org/series/88257/ State : success == Summary == CI Bug Log - changes from CI_DRM_9880 -> Patchwork_19825 Summary --- **SUCCESS** No regressio

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Disable PSR2 on ADLS

== Series Details == Series: drm/i915/display: Disable PSR2 on ADLS URL : https://patchwork.freedesktop.org/series/88261/ State : warning == Summary == $ dim checkpatch origin/drm-tip a24808990721 drm/i915/display: Disable PSR2 on ADLS -:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped comm

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Disable PSR2 on ADLS

== Series Details == Series: drm/i915/display: Disable PSR2 on ADLS URL : https://patchwork.freedesktop.org/series/88261/ State : success == Summary == CI Bug Log - changes from CI_DRM_9880 -> Patchwork_19826 Summary --- **SUCCESS**

Re: [Intel-gfx] drm/i915/ilk-glk: Fix link training on links with LTTPRs

Tested-By: Santiago Zarate Tested with kernel built in obs, see https://apibugzilla.suse.com/show_bug.cgi?id=1183294#c19 for more details Regards, Santiago On Tue, 2021-03-16 at 18:54 +0200, Imre Deak wrote: > The spec requires to use at least 3.2ms for the AUX timeout period if > there are L

[Intel-gfx] [PATCH v3 4/6] drm/i915: Request watchdog infrastructure

From: Tvrtko Ursulin Prepares the plumbing for setting request/fence expiration time. All code is put in place but is never activeted due yet missing ability to actually configure the timer. Outline of the basic operation: A timer is started when request is ready for execution. If the request c

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Default request/fence expiry + watchdog (rev3)

On 19/03/2021 01:17, Patchwork wrote: Okay with 20s default expiration the hangcheck tests on Tigerlake pass and we are left with these failures: IGT changes Possible regressions * igt@gem_ctx_ringsize@idle@bcs0: o shard-skl: PASS

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Not to try to re-enable PSR after being raised an irq aux error

On Wed, 2021-03-17 at 23:26 +0200, Gwan-gyeong Mun wrote: > If an irq aux error happens, it does not need to wait for PSR "IDLE state" > for re-enabling PSR. And it should not try to re-enable PSR. > > The PSR interrupt handler sets irq_aux_error when the PSR error happens. > And it schedules the

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Default request/fence expiry + watchdog (rev3)

On Mon, Mar 22, 2021 at 01:37:58PM +, Tvrtko Ursulin wrote: > > On 19/03/2021 01:17, Patchwork wrote: > > Okay with 20s default expiration the hangcheck tests on Tigerlake pass and > we are left with these failures: > > > IGT changes > > > > > > Possible regressions > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Disable PSR2 on Gen12/12+

== Series Details == Series: drm/i915/display: Disable PSR2 on Gen12/12+ URL : https://patchwork.freedesktop.org/series/88264/ State : success == Summary == CI Bug Log - changes from CI_DRM_9880 -> Patchwork_19827 Summary --- **SUCCE

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Default request/fence expiry + watchdog (rev4)

== Series Details == Series: Default request/fence expiry + watchdog (rev4) URL : https://patchwork.freedesktop.org/series/87930/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0dab5b547041 drm/i915: Individual request cancellation 877af4e8c3a0 drm/i915: Restrict sentinel reques

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

On Mon, Mar 22, 2021 at 11:22:01AM +, Tvrtko Ursulin wrote: > > On 19/03/2021 22:38, Jason Ekstrand wrote: > > This API allows one context to grab bits out of another context upon > > creation. It can be used as a short-cut for setparam(getparam()) for > > things like I915_CONTEXT_PARAM_VM.

[Intel-gfx] [PATCH i-g-t] scripts/trace.pl: Remove the tool

From: Tvrtko Ursulin Tool has been broken for a while after changes to tracepoint format an behaviour. Although I have patches somewhere to mostly fix it, it seems that it has outlived its usefulness and could be deleted just as well. Signed-off-by: Tvrtko Ursulin --- scripts/Makefile.am |

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

On 22/03/2021 14:09, Daniel Vetter wrote: On Mon, Mar 22, 2021 at 11:22:01AM +, Tvrtko Ursulin wrote: On 19/03/2021 22:38, Jason Ekstrand wrote: This API allows one context to grab bits out of another context upon creation. It can be used as a short-cut for setparam(getparam()) for thin

[Intel-gfx] ✗ Fi.CI.BAT: failure for Default request/fence expiry + watchdog (rev4)

== Series Details == Series: Default request/fence expiry + watchdog (rev4) URL : https://patchwork.freedesktop.org/series/87930/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9880 -> Patchwork_19828 Summary --- **FA

Re: [Intel-gfx] [PATCH] drm/i915: Avoid div-by-zero on gen2

On Sun, Mar 21, 2021 at 04:30:32PM +, Chris Wilson wrote: > Quoting Chris Wilson (2021-03-21 16:28:07) > > Quoting Ville Syrjala (2021-03-21 16:10:38) > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c > > > b/drivers/gpu/drm/i915/gem/i915_gem_mman.c > > > index ec28a6cde49b..0b2434e2

Re: [Intel-gfx] [bug report] drm/i915: Computer does not shutdown,

On Mon, Mar 22, 2021 at 11:45:39AM +0100, Hans de Goede wrote: > Hi, > > On 3/14/21 11:30 AM, Mario Hüttel wrote: > > Hello, > > > > It seems, like the mailing list, didn't accept my email. So I'll send > > it again: > > > > I want to report a bug. I have a PC with Intel i7-6700K processor (with

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

On Mon, Mar 22, 2021 at 3:33 PM Tvrtko Ursulin wrote: > > > On 22/03/2021 14:09, Daniel Vetter wrote: > > On Mon, Mar 22, 2021 at 11:22:01AM +, Tvrtko Ursulin wrote: > >> > >> On 19/03/2021 22:38, Jason Ekstrand wrote: > >>> This API allows one context to grab bits out of another context upon

Re: [Intel-gfx] [bug report] drm/i915: Computer does not shutdown,

On Sun, Mar 14, 2021 at 11:30:12AM +0100, Mario Hüttel wrote: > Hello, > > It seems, like the mailing list, didn't accept my email. So I'll send > it again: > > I want to report a bug. I have a PC with Intel i7-6700K processor (with > integrated graphics) and an AsRock Fatal1ty Z170 Gaming K6 mai

Re: [Intel-gfx] [PATCH 6/6] drm/i915/display: Simplify GLK display version tests

On Fri, Mar 19, 2021 at 09:42:45PM -0700, Matt Roper wrote: > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c > b/drivers/gpu/drm/i915/display/intel_cdclk.c > index 4be848d0d156..eb1121e05c0d 100644 > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c > +++ b/drivers/gpu/drm/i915/display/int

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

On 22/03/2021 14:57, Daniel Vetter wrote: On Mon, Mar 22, 2021 at 3:33 PM Tvrtko Ursulin wrote: On 22/03/2021 14:09, Daniel Vetter wrote: On Mon, Mar 22, 2021 at 11:22:01AM +, Tvrtko Ursulin wrote: On 19/03/2021 22:38, Jason Ekstrand wrote: This API allows one context to grab bits o

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Individual request cancellation

On Thu, 18 Mar 2021 at 17:04, Tvrtko Ursulin wrote: > > From: Chris Wilson > > Currently, we cancel outstanding requests within a context when the > context is closed. We may also want to cancel individual requests using > the same graceful preemption mechanism. > > v2 (Tvrtko): > * Cancel waite

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable TPS3/4 on all platforms that support them

On Fri, Mar 19, 2021 at 07:08:40PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Enable TPS3/4 on all platforms that support them > URL : https://patchwork.freedesktop.org/series/88186/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_9877 -> Patc

Re: [Intel-gfx] [bug report] drm/i915: Computer does not shutdown,

Hi, On 3/22/21 3:53 PM, Ville Syrjälä wrote: > On Mon, Mar 22, 2021 at 11:45:39AM +0100, Hans de Goede wrote: >> Hi, >> >> On 3/14/21 11:30 AM, Mario Hüttel wrote: >>> Hello, >>> >>> It seems, like the mailing list, didn't accept my email. So I'll send >>> it again: >>> >>> I want to report a bug.

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

On Mon, Mar 22, 2021 at 5:52 AM Matthew Auld wrote: > > On Sat, 20 Mar 2021 at 14:48, Jason Ekstrand wrote: > > > > On Fri, Mar 19, 2021 at 5:39 PM Jason Ekstrand wrote: > > > > > > This reverts commit 88be76cdafc7e60e2e4ed883bfe7e8dd7f35fa3a. This API > > > has never been used by any real user

Re: [Intel-gfx] [bug report] drm/i915: Computer does not shutdown,

On Mon, Mar 22, 2021 at 04:51:26PM +0100, Hans de Goede wrote: > Hi, > > On 3/22/21 3:53 PM, Ville Syrjälä wrote: > > On Mon, Mar 22, 2021 at 11:45:39AM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 3/14/21 11:30 AM, Mario Hüttel wrote: > >>> Hello, > >>> > >>> It seems, like the mailing list,

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

On Mon, Mar 22, 2021 at 7:01 AM Jani Nikula wrote: > > On Sat, 20 Mar 2021, Jason Ekstrand wrote: > > This reverts commit 88be76cdafc7e60e2e4ed883bfe7e8dd7f35fa3a. This API > > Small nit, I think it would be useful to reference commits with the > citation style: > > 88be76cdafc7 ("drm/i915:

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

On Mon, Mar 22, 2021 at 7:28 AM Tvrtko Ursulin wrote: > > > On 19/03/2021 22:38, Jason Ekstrand wrote: > > I'd love to delete the SINGLE_TIMELINE API because it leaks an > > implementation detail of contexts through to the API and is something > > that userspace can do itself, trivially. Unfortun

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: uAPI clean-ups part 2

On Mon, Mar 22, 2021 at 6:55 AM Jani Nikula wrote: > > On Fri, 19 Mar 2021, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915: uAPI clean-ups part 2 > > URL : https://patchwork.freedesktop.org/series/88196/ > > State : failure > > > > == Summary == > > > > Applying: drm/i915: D

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdcp: mst streams type1 capability check (rev2)

== Series Details == Series: drm/i915/hdcp: mst streams type1 capability check (rev2) URL : https://patchwork.freedesktop.org/series/86345/ State : success == Summary == CI Bug Log - changes from CI_DRM_9874_full -> Patchwork_19809_full Sum

Re: [Intel-gfx] [PATCH 4/7] drm/i915/display: Extract chv_read_csc()

On Mon, Mar 22, 2021 at 08:00:05PM +0530, Bhanuprakash Modem wrote: > For Cherryview, add hw read out to create hw blob of ctm coeff > values. > > Cc: Swati Sharma > Cc: Uma Shankar > Signed-off-by: Bhanuprakash Modem > --- > drivers/gpu/drm/i915/display/intel_color.c | 47

Re: [Intel-gfx] [PATCH 0/7] drm/i915: Add state checker for CSC coeff values

On Mon, Mar 22, 2021 at 08:00:01PM +0530, Bhanuprakash Modem wrote: > In this patch series, added state checker to validate CSC. This reads > hardware state, and compares the originally requested state(s/w). This > is done for chv, ilk, glk and their variant platforms. Rest of > the platforms will

Re: [Intel-gfx] [PATCH 5/7] drm/i915/display: Extract ilk_read_csc()

On Mon, Mar 22, 2021 at 08:00:06PM +0530, Bhanuprakash Modem wrote: > For ilk+, add hw read out to create hw blob of ctm coeff values. We need an explanation why this is safe given display w/a 1184... > > Cc: Swati Sharma > Cc: Uma Shankar > Signed-off-by: Bhanuprakash Modem > --- > drivers/

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

Ugh... timezones. On Mon, Mar 22, 2021 at 10:31 AM Tvrtko Ursulin wrote: > > > On 22/03/2021 14:57, Daniel Vetter wrote: > > On Mon, Mar 22, 2021 at 3:33 PM Tvrtko Ursulin > > wrote: > >> > >> > >> On 22/03/2021 14:09, Daniel Vetter wrote: > >>> On Mon, Mar 22, 2021 at 11:22:01AM +, Tvrtko U

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

On Mon, Mar 22, 2021 at 5:01 PM Jason Ekstrand wrote: > > On Mon, Mar 22, 2021 at 7:01 AM Jani Nikula > wrote: > > > > On Sat, 20 Mar 2021, Jason Ekstrand wrote: > > > This reverts commit 88be76cdafc7e60e2e4ed883bfe7e8dd7f35fa3a. This > > > API > > > > Small nit, I think it would be usefu

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

On Mon, Mar 22, 2021 at 4:31 PM Tvrtko Ursulin wrote: > > > On 22/03/2021 14:57, Daniel Vetter wrote: > > On Mon, Mar 22, 2021 at 3:33 PM Tvrtko Ursulin > > wrote: > >> > >> > >> On 22/03/2021 14:09, Daniel Vetter wrote: > >>> On Mon, Mar 22, 2021 at 11:22:01AM +, Tvrtko Ursulin wrote: >

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

On Fri, Mar 19, 2021 at 05:38:56PM -0500, Jason Ekstrand wrote: > I'd love to delete the SINGLE_TIMELINE API because it leaks an > implementation detail of contexts through to the API and is something > that userspace can do itself, trivially. Unfortunately, it's used by > the media driver so we c

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Restrict sentinel requests further

On Thu, 18 Mar 2021 at 17:04, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Disallow sentinel requests follow previous sentinels to make request > cancellation work better when faced with a chain of requests which have > all been marked as in error. Could you elaborate some more on why this

Re: [Intel-gfx] [bug report] drm/i915: Computer does not shutdown,

Hi, On 3/22/21 5:00 PM, Ville Syrjälä wrote: > On Mon, Mar 22, 2021 at 04:51:26PM +0100, Hans de Goede wrote: >> Hi, >> >> On 3/22/21 3:53 PM, Ville Syrjälä wrote: >>> On Mon, Mar 22, 2021 at 11:45:39AM +0100, Hans de Goede wrote: Hi, On 3/14/21 11:30 AM, Mario Hüttel wrote: > H

[Intel-gfx] [PATCH 1/3] drm/i915: Warn when display irq functions are called without display

With previous changes none of those warnings will be printed but let's add them so CI can caught regressions. Cc: Lucas De Marchi Signed-off-by: José Roberto de Souza Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_fifo_underrun.c | 2 ++ drivers/gpu/drm/i915/display/intel_hotp

[Intel-gfx] [PATCH 3/3] drm/i915: skip display initialization when there is no display

Display features should not be initialized or de-initialized when there is no display. Skip modeset initialization, output setup, plane, crtc, encoder, connector registration, display cdclk and rawclk initialization, display core initialization, etc. Skip the functionality at as high level as poss

[Intel-gfx] [PATCH 2/3] drm/i915: Do not set any power wells when there is no display

Power wells are only part of display block and not necessary when running a headless driver. Cc: Lucas De Marchi Signed-off-by: José Roberto de Souza Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_power.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) dif

[Intel-gfx] [PATCH 06/11] cgroup: fix -Wzero-length-bounds warnings

From: Arnd Bergmann When cgroups are enabled, but every single subsystem is turned off, CGROUP_SUBSYS_COUNT is zero, and the cgrp->subsys[] array has no members. gcc-11 points out that this leads to an invalid access in any function that might access this array: kernel/cgroup/cgroup.c: In funct

[Intel-gfx] [PATCH 05/11] qnx: avoid -Wstringop-overread warning

From: Arnd Bergmann gcc-11 warns that the size of the link name is longer than the di_fname field: fs/qnx4/dir.c: In function ‘qnx4_readdir’: fs/qnx4/dir.c:51:32: error: ‘strnlen’ specified bound 48 exceeds source size 16 [-Werror=stringop-overread] 51 | size = strnle

Re: [Intel-gfx] [PATCH 03/11] security: commoncap: fix -Wstringop-overread warning

On Mon, Mar 22, 2021 at 05:02:41PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 introdces a harmless warning for cap_inode_getsecurity: > > security/commoncap.c: In function ‘cap_inode_getsecurity’: > security/commoncap.c:440:33: error: ‘memcpy’ reading 16 bytes from a region >

[Intel-gfx] [PATCH 04/11] ath11: Wstringop-overread warning

From: Arnd Bergmann gcc-11 with the kernel address sanitizer prints a warning for this driver: In function 'ath11k_peer_assoc_h_vht', inlined from 'ath11k_peer_assoc_prepare' at drivers/net/wireless/ath/ath11k/mac.c:1632:2: drivers/net/wireless/ath/ath11k/mac.c:1164:13: error: 'ath11k_peer

[Intel-gfx] [PATCH 07/11] ARM: sharpsl_param: work around -Wstringop-overread warning

From: Arnd Bergmann gcc warns that accessing a pointer based on a numeric constant may be an offset into a NULL pointer, and would therefore has zero accessible bytes: arch/arm/common/sharpsl_param.c: In function ‘sharpsl_save_param’: arch/arm/common/sharpsl_param.c:43:9: error: ‘memcpy’ reading

[Intel-gfx] [PATCH 03/11] security: commoncap: fix -Wstringop-overread warning

From: Arnd Bergmann gcc-11 introdces a harmless warning for cap_inode_getsecurity: security/commoncap.c: In function ‘cap_inode_getsecurity’: security/commoncap.c:440:33: error: ‘memcpy’ reading 16 bytes from a region of size 0 [-Werror=stringop-overread] 440 |

[Intel-gfx] [PATCH 09/11] scsi: lpfc: fix gcc -Wstringop-overread warning

From: Arnd Bergmann gcc-11 warns about an strnlen with a length larger than the size of the passed buffer: drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_nvme_info_show': drivers/scsi/lpfc/lpfc_attr.c:518:25: error: 'strnlen' specified bound 4095 exceeds source size 24 [-Werror=stringop-overr

[Intel-gfx] [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

From: Arnd Bergmann gcc-11 warns that intel_dp_check_mst_status() has a local array of fourteen bytes and passes the last four bytes into a function that expects a six-byte array: drivers/gpu/drm/i915/display/intel_dp.c: In function ‘intel_dp_check_mst_status’: drivers/gpu/drm/i915/display/inte

[Intel-gfx] [PATCH 08/11] atmel: avoid gcc -Wstringop-overflow warning

From: Arnd Bergmann gcc-11 notices that the fields as defined in the ass_req_format structure do not match the actual use of that structure: cc1: error: writing 4 bytes into a region of size between 18446744073709551613 and 2 [-Werror=stringop-overflow=] drivers/net/wireless/atmel/atmel.c:2884:

[Intel-gfx] [PATCH 00/11] treewide: address gcc-11 -Wstringop-overread warnings

From: Arnd Bergmann The coming gcc release introduces a new warning for string operations reading beyond the end of a fixed-length object. After testing randconfig kernels for a while, think I have patches for any such warnings that came up on x86, arm and arm64. Most of these warnings are false

[Intel-gfx] [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

From: Arnd Bergmann gcc-11 warns about using string operations on pointers that are defined at compile time as offsets from a NULL pointer. Unfortunately that also happens on the result of fix_to_virt(), which is a compile-time constant for a constantn input: arch/x86/kernel/tboot.c: In function

[Intel-gfx] [PATCH 01/11] x86: compressed: avoid gcc-11 -Wstringop-overread warning

From: Arnd Bergmann gcc gets confused by the comparison of a pointer to an integer listeral, with the assumption that this is an offset from a NULL pointer and that dereferencing it is invalid: In file included from arch/x86/boot/compressed/misc.c:18: In function ‘parse_elf’, inlined from ‘e

[Intel-gfx] [PATCH 10/11] drm/i915: avoid stringop-overread warning on pri_latency

From: Arnd Bergmann gcc-11 warns about what appears to be an out-of-range array access: In function ‘snb_wm_latency_quirk’, inlined from ‘ilk_setup_wm_latency’ at drivers/gpu/drm/i915/intel_pm.c:3108:3: drivers/gpu/drm/i915/intel_pm.c:3057:9: error: ‘intel_print_wm_latency’ reading 16 byte

Re: [Intel-gfx] [bug report] drm/i915: Computer does not shutdown,

On Mon, Mar 22, 2021 at 07:00:38PM +0100, Hans de Goede wrote: > Hi, > > On 3/22/21 5:00 PM, Ville Syrjälä wrote: > > On Mon, Mar 22, 2021 at 04:51:26PM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 3/22/21 3:53 PM, Ville Syrjälä wrote: > >>> On Mon, Mar 22, 2021 at 11:45:39AM +0100, Hans de G

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Warn when display irq functions are called without display

On Mon, Mar 22, 2021 at 11:10:53AM -0700, José Roberto de Souza wrote: > With previous changes none of those warnings will be printed but let's > add them so CI can caught regressions. > > Cc: Lucas De Marchi > Signed-off-by: José Roberto de Souza > Signed-off-by: Jani Nikula > --- > .../gpu/d

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Warn when display irq functions are called without display

== Series Details == Series: series starting with [1/3] drm/i915: Warn when display irq functions are called without display URL : https://patchwork.freedesktop.org/series/88294/ State : success == Summary == CI Bug Log - changes from CI_DRM_9880 -> Patchwork_19829 ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for treewide: address gcc-11 -Wstringop-overread warnings

== Series Details == Series: treewide: address gcc-11 -Wstringop-overread warnings URL : https://patchwork.freedesktop.org/series/88295/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8b23b18b19c9 x86: compressed: avoid gcc-11 -Wstringop-overread warning -:15: WARNING:COMMIT_LOG

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for treewide: address gcc-11 -Wstringop-overread warnings

== Series Details == Series: treewide: address gcc-11 -Wstringop-overread warnings URL : https://patchwork.freedesktop.org/series/88295/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/g

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

On Mon, Mar 22, 2021 at 11:59 AM Daniel Vetter wrote: > > On Fri, Mar 19, 2021 at 05:38:56PM -0500, Jason Ekstrand wrote: > > I'd love to delete the SINGLE_TIMELINE API because it leaks an > > implementation detail of contexts through to the API and is something > > that userspace can do itself, t

[Intel-gfx] ✓ Fi.CI.BAT: success for treewide: address gcc-11 -Wstringop-overread warnings

== Series Details == Series: treewide: address gcc-11 -Wstringop-overread warnings URL : https://patchwork.freedesktop.org/series/88295/ State : success == Summary == CI Bug Log - changes from CI_DRM_9880 -> Patchwork_19830 Summary ---

[Intel-gfx] [PATCH v2 6/6] drm/i915/display: Simplify GLK display version tests

GLK has always been a bit of a special case since it reports INTEL_GEN() as 9, but has version 10 display IP. Now we can properly represent the display version as 10 and simplify the display generation tests throughout the display code. Aside from manually adding the version to the glk_info struc

  1   2   >