Re: [Intel-gfx] [PATCH 2/2] drm/doc: Add RFC section

Acked-by: Jason Ekstrand On March 24, 2021 16:10:48 Daniel Vetter wrote: Motivated by the pre-review process for i915 gem/gt features, but probably useful in general for complex stuff. v2: Add reminder to not forget userspace projects in the discussion (Simon, Jason) Cc: Simon Ser Cc: Jani

[Intel-gfx] ✗ Fi.CI.IGT: failure for HDMI2.1 PCON Misc Fixes (rev5)

== Series Details == Series: HDMI2.1 PCON Misc Fixes (rev5) URL : https://patchwork.freedesktop.org/series/86677/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9885_full -> Patchwork_19838_full Summary --- **FAILURE*

[Intel-gfx] [PATCH 2/2] drm/i915: Stop adding planes to the commit needlessly

From: Ville Syrjälä The dbuf bandwidth calculations don't need the planes to be added to the state. Each plane's data rate has already been precalculated and stored in the crtc state, and that with the dbuf slice usage for each plane is all the dbuf bandwidth code needs to figure out what the min

[Intel-gfx] [PATCH 1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level()

From: Ville Syrjälä Accidentally transposed the arguments to skl_plane_wm_level() which is causing us to mistakenly think that the plane watermarks have/have not changed when the opposite may be true. Swap the arguments so this actually works. The other uses of this look OK. Cc: Stanislav Lisov

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/audio: set HDA link parameters in driver (rev2)

== Series Details == Series: drm/i915/audio: set HDA link parameters in driver (rev2) URL : https://patchwork.freedesktop.org/series/87040/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9889_full -> Patchwork_19848_full Sum

[Intel-gfx] ✗ Fi.CI.IGT: failure for Default request/fence expiry + watchdog (rev5)

== Series Details == Series: Default request/fence expiry + watchdog (rev5) URL : https://patchwork.freedesktop.org/series/87930/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9889_full -> Patchwork_19847_full Summary -

[Intel-gfx] ✓ Fi.CI.IGT: success for HDCP 2.2 DP errata (rev2)

== Series Details == Series: HDCP 2.2 DP errata (rev2) URL : https://patchwork.freedesktop.org/series/86340/ State : success == Summary == CI Bug Log - changes from CI_DRM_9889_full -> Patchwork_19845_full Summary --- **SUCCESS**

[Intel-gfx] linux-next: build warning after merge of the drm-intel-fixes tree

Hi all, After merging the drm-intel-fixes tree, today's linux-next build (htmldocs) produced this warning: Documentation/gpu/i915:22: /home/sfr/next/next/drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string. Introduced by commit 8840e3bd981f ("

[Intel-gfx] [PATCH 2/2] drm/doc: Add RFC section

Motivated by the pre-review process for i915 gem/gt features, but probably useful in general for complex stuff. v2: Add reminder to not forget userspace projects in the discussion (Simon, Jason) Cc: Simon Ser Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Jason Ekstrand Cc: Dave Ai

[Intel-gfx] [PATCH 1/2] drm/i915: add gem/gt TODO

We've discussed a bit how to get the gem/gt team better integrated and collaborate more with the wider community and agreed to the following: - all gem/gt patches are reviewed on dri-devel for now. That's overkill, but in the past there was definitely too little of that. - i915-gem folks are en

[Intel-gfx] Regarding the laptop with the BOE panel with ID 2270

Hey Aaron! A while ago you submitted some patches for a machine that appears to have needed the VESA backlight interface in order to control the panel backlight on it: https://patchwork.freedesktop.org/patch/394371/ We're currently dealing with a different laptop where the machine advertises VESA

Re: [Intel-gfx] [PATCH v2] drm/i915/audio: set HDA link parameters in driver

> -Original Message- > From: Kai Vehmanen > Sent: Wednesday, March 24, 2021 6:07 PM > To: intel-gfx@lists.freedesktop.org > Cc: Kai Vehmanen ; Shankar, Uma > > Subject: [PATCH v2] drm/i915/audio: set HDA link parameters in driver > > Update logic to program AUD_FREQ_CNTRL register bas

[Intel-gfx] [PATCH 1/4] drm/i915/gen12: Add recommended hardware tuning value

From: Caz Yokoyama Follow Bspec 31870 to set recommended tuning values for certain GT register. These values aren't workarounds per-se, but it's best to handle them in the same general area of the driver, especially since there may be real workarounds that update other bits of the same registers

[Intel-gfx] [PATCH 0/4] drm/i915: missing workarounds and refactors

Missing WAs and related refactors. Caz Yokoyama (2): drm/i915/gen12: Add recommended hardware tuning value drm/i915/icl: add Wa_22010271021 for all gen11 José Roberto de Souza (1): drm/i915: Move Wa_16011163337 to gen12_ctx_workarounds_init() Swathi Dhanavanthri (1): drm/i915: Add Wa_140

[Intel-gfx] [PATCH 2/4] drm/i915/icl: add Wa_22010271021 for all gen11

From: Caz Yokoyama Wa_22010271021 does not apply only to EHL, but to all gen11 and other gen12 platforms. Gen12 is already covered in another code path, but we need to stop checking for EHL when handling gen11. Bspec: 33450, 52887 v2: Remove "gen11" suffix as it also applies to gen12 platforms

[Intel-gfx] [PATCH 4/4] drm/i915: Add Wa_14011060649

From: Swathi Dhanavanthri This is a permanent workaround for TGL,RKL,DG1 and ADLS. Signed-off-by: Swathi Dhanavanthri Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 26 + drivers/gpu/drm/i915/i915_reg.h | 3 +++ 2 files changed,

[Intel-gfx] [PATCH 3/4] drm/i915: Move Wa_16011163337 to gen12_ctx_workarounds_init()

From: José Roberto de Souza This WA is needed in all gen12 platforms, moving it to gen12_ctx_workarounds_init() allow us to remove the duplicated implementation. Also allow us to remove the tgl_ctx_workarounds_init() that after the WA move above was empty. Signed-off-by: José Roberto de Souza R

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Simplify intel_setup_outputs() (rev3)

On Wed, Mar 24, 2021 at 05:09:55PM +, Patchwork wrote: == Series Details == Series: Simplify intel_setup_outputs() (rev3) URL : https://patchwork.freedesktop.org/series/87068/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9886_full -> Patchwork_19844_full ===

Re: [Intel-gfx] [PATCH v9 63/70] drm/i915: Move gt_revoke() slightly

On Wed, Mar 24, 2021 at 06:16:44PM +0100, Daniel Vetter wrote: > On Wed, Mar 24, 2021 at 07:15:36PM +0200, Ville Syrjälä wrote: > > On Wed, Mar 24, 2021 at 06:00:12PM +0100, Daniel Vetter wrote: > > > On Tue, Mar 23, 2021 at 04:50:52PM +0100, Maarten Lankhorst wrote: > > > > We get a lockdep splat

Re: [Intel-gfx] [PATCH 10/11] drm/i915: avoid stringop-overread warning on pri_latency

On Wed, Mar 24, 2021 at 05:30:24PM +0200, Jani Nikula wrote: > On Mon, 22 Mar 2021, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > gcc-11 warns about what appears to be an out-of-range array access: > > > > In function ‘snb_wm_latency_quirk’, > > inlined from ‘ilk_setup_wm_latency’ at

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Handle async cancellation in sentinel assert

On Wed, 24 Mar 2021 at 12:14, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > With the watchdog cancelling requests asynchronously to preempt-to-busy we > need to relax one assert making it apply only to requests not in error. > > v2: > * Check against the correct request! > > v3: > * Simpli

Re: [Intel-gfx] [PATCH v9 66/70] drm/i915: Add ww parameter to get_pages() callback

On Tue, Mar 23, 2021 at 04:50:55PM +0100, Maarten Lankhorst wrote: > We will need this to support eviction with lmem, so > explicitly pass ww as a parameter. > > Signed-off-by: Maarten Lankhorst I'm leaving this and later patches out for now. Would be good to fast-track the bsw fix, but the othe

Re: [Intel-gfx] [PATCH v9 70/70] drm/i915: Remove asynchronous vma binding

On Tue, Mar 23, 2021 at 04:50:59PM +0100, Maarten Lankhorst wrote: > The current asynchronous work is done in a dma_fence_work, which > has signalling annotations, because dma_fence_work signals on completion. > > On braswell, we can call stop_machine inside fence_work, causing a splat > because m

Re: [Intel-gfx] [PATCH] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v2)

On Wed, Mar 24, 2021 at 6:36 AM Tvrtko Ursulin wrote: > > > On 24/03/2021 09:52, Daniel Vetter wrote: > > On Wed, Mar 24, 2021 at 09:28:58AM +, Tvrtko Ursulin wrote: > >> > >> On 23/03/2021 17:51, Jason Ekstrand wrote: > >>> This API is entirely unnecessary and I'd love to get rid of it. If >

Re: [Intel-gfx] [PATCH v9 63/70] drm/i915: Move gt_revoke() slightly

On Wed, Mar 24, 2021 at 07:15:36PM +0200, Ville Syrjälä wrote: > On Wed, Mar 24, 2021 at 06:00:12PM +0100, Daniel Vetter wrote: > > On Tue, Mar 23, 2021 at 04:50:52PM +0100, Maarten Lankhorst wrote: > > > We get a lockdep splat when the reset mutex is held, because it can be > > > taken from fence_

Re: [Intel-gfx] [PATCH v9 63/70] drm/i915: Move gt_revoke() slightly

On Wed, Mar 24, 2021 at 06:00:12PM +0100, Daniel Vetter wrote: > On Tue, Mar 23, 2021 at 04:50:52PM +0100, Maarten Lankhorst wrote: > > We get a lockdep splat when the reset mutex is held, because it can be > > taken from fence_wait. This conflicts with the mmu notifier we have, > > because we recu

Re: [Intel-gfx] [PATCH v9 65/70] drm/i915: Fix pin_map in scheduler selftests

On Tue, Mar 23, 2021 at 04:50:54PM +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst Fixes a commit I'll drop anyway, so didn't bother with this one. -Daniel > --- > drivers/gpu/drm/i915/selftests/i915_scheduler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

[Intel-gfx] ✗ Fi.CI.IGT: failure for Simplify intel_setup_outputs() (rev3)

== Series Details == Series: Simplify intel_setup_outputs() (rev3) URL : https://patchwork.freedesktop.org/series/87068/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9886_full -> Patchwork_19844_full Summary --- **F

Re: [Intel-gfx] [PATCH v9 64/70] drm/i915: Add missing -EDEADLK path in execbuffer ggtt pinning.

On Tue, Mar 23, 2021 at 04:50:53PM +0100, Maarten Lankhorst wrote: > In reloc_iomap we swallow the -EDEADLK error, but this needs to > be returned for -EDEADLK handling. Add the missing check to > make bsw pass again. > > Testcase: gem_exec_fence.basic-await > > Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] [PATCH v9 63/70] drm/i915: Move gt_revoke() slightly

On Tue, Mar 23, 2021 at 04:50:52PM +0100, Maarten Lankhorst wrote: > We get a lockdep splat when the reset mutex is held, because it can be > taken from fence_wait. This conflicts with the mmu notifier we have, > because we recurse between reset mutex and mmap lock -> mmu notifier. > > Remove this

Re: [Intel-gfx] [PATCH v9 44/70] drm/i915/selftests: Prepare context tests for obj->mm.lock removal.

On Tue, Mar 23, 2021 at 04:50:33PM +0100, Maarten Lankhorst wrote: > Straightforward conversion, just convert a bunch of calls to > unlocked versions. > > Signed-off-by: Maarten Lankhorst > Reviewed-by: Thomas Hellström Another one where I just picked your old version: https://lore.kernel.org/

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for HDMI2.1 PCON Misc Fixes (rev5)

Re-reported. -Original Message- From: Nautiyal, Ankit K Sent: Wednesday, March 24, 2021 5:14 AM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana Subject: Re: ✗ Fi.CI.BAT: failure for HDMI2.1 PCON Misc Fixes (rev5) Hi Lakshmi, igt@kms_chamelium@hdmi-hpd-fast: * fi-icl-u2

Re: [Intel-gfx] [PATCH v9 34/70] drm/i915: Add ww locking around vm_access()

On Tue, Mar 23, 2021 at 04:50:23PM +0100, Maarten Lankhorst wrote: > i915_gem_object_pin_map potentially needs a ww context, so ensure we > have one we can revoke. > > Signed-off-by: Maarten Lankhorst > Reviewed-by: Thomas Hellström We shouldn't hand-roll our own vm_access callback, generic_acc

Re: [Intel-gfx] [PATCH v9 31/70] drm/i915: Fix workarounds selftest, part 1

On Tue, Mar 23, 2021 at 04:50:20PM +0100, Maarten Lankhorst wrote: > pin_map needs the ww lock, so ensure we pin both before submission. > > Signed-off-by: Maarten Lankhorst > Reviewed-by: Thomas Hellström Another one where I picked an older version: https://lore.kernel.org/intel-gfx/202101281

[Intel-gfx] ✓ Fi.CI.BAT: success for HDMI2.1 PCON Misc Fixes (rev5)

== Series Details == Series: HDMI2.1 PCON Misc Fixes (rev5) URL : https://patchwork.freedesktop.org/series/86677/ State : success == Summary == CI Bug Log - changes from CI_DRM_9885 -> Patchwork_19838 Summary --- **SUCCESS** No re

[Intel-gfx] ✓ Fi.CI.IGT: success for i915_vma: Rename vma_lookup to i915_vma_lookup

== Series Details == Series: i915_vma: Rename vma_lookup to i915_vma_lookup URL : https://patchwork.freedesktop.org/series/88362/ State : success == Summary == CI Bug Log - changes from CI_DRM_9886_full -> Patchwork_19843_full Summary -

Re: [Intel-gfx] [PATCH 10/11] drm/i915: avoid stringop-overread warning on pri_latency

On Mon, 22 Mar 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns about what appears to be an out-of-range array access: > > In function ‘snb_wm_latency_quirk’, > inlined from ‘ilk_setup_wm_latency’ at > drivers/gpu/drm/i915/intel_pm.c:3108:3: > drivers/gpu/drm/i915/intel_pm.c

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Restrict sentinel requests further

On Wed, 24 Mar 2021 at 12:14, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Disallow sentinel requests follow previous sentinels to make request > cancellation work better when faced with a chain of requests which have > all been marked as in error. > > Because in cases where we end up with

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Individual request cancellation

On Wed, 24 Mar 2021 at 12:13, Tvrtko Ursulin wrote: > > From: Chris Wilson > > Currently, we cancel outstanding requests within a context when the > context is closed. We may also want to cancel individual requests using > the same graceful preemption mechanism. > > v2 (Tvrtko): > * Cancel waite

Re: [Intel-gfx] [PATCH v9 30/70] drm/i915: Fix pread/pwrite to work with new locking rules.

On Tue, Mar 23, 2021 at 04:50:19PM +0100, Maarten Lankhorst wrote: > We are removing obj->mm.lock, and need to take the reservation lock > before we can pin pages. Move the pinning pages into the helper, and > merge gtt pwrite/pread preparation and cleanup paths. > > The fence lock is also removed

Re: [Intel-gfx] [PATCH resend 2/2] drm/i915/display: Make vlv_find_free_pps() skip pipes which are in use for non DP purposes

On Wed, Mar 24, 2021 at 03:10:59PM +0100, Hans de Goede wrote: > Hi, > > On 3/24/21 3:02 PM, Ville Syrjälä wrote: > > On Tue, Mar 23, 2021 at 11:39:09AM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 3/2/21 3:51 PM, Ville Syrjälä wrote: > >>> On Tue, Mar 02, 2021 at 01:00:40PM +0100, Hans de Go

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/audio: set HDA link parameters in driver (rev2)

== Series Details == Series: drm/i915/audio: set HDA link parameters in driver (rev2) URL : https://patchwork.freedesktop.org/series/87040/ State : success == Summary == CI Bug Log - changes from CI_DRM_9889 -> Patchwork_19848 Summary -

Re: [Intel-gfx] [PATCH v9 28/70] drm/i915: Take obj lock around set_domain ioctl

On Tue, Mar 23, 2021 at 04:50:17PM +0100, Maarten Lankhorst wrote: > We need to lock the object to move it to the correct domain, > add the missing lock. > > Signed-off-by: Maarten Lankhorst > Reviewed-by: Thomas Hellström This conflicted real bad with the in-flight -gt-next stuff that wasn't r

Re: [Intel-gfx] [PATCH resend 2/2] drm/i915/display: Make vlv_find_free_pps() skip pipes which are in use for non DP purposes

Hi, On 3/24/21 3:02 PM, Ville Syrjälä wrote: > On Tue, Mar 23, 2021 at 11:39:09AM +0100, Hans de Goede wrote: >> Hi, >> >> On 3/2/21 3:51 PM, Ville Syrjälä wrote: >>> On Tue, Mar 02, 2021 at 01:00:40PM +0100, Hans de Goede wrote: As explained by a long comment block, on VLV intel_setup_output

Re: [Intel-gfx] [PATCH resend 2/2] drm/i915/display: Make vlv_find_free_pps() skip pipes which are in use for non DP purposes

On Tue, Mar 23, 2021 at 11:39:09AM +0100, Hans de Goede wrote: > Hi, > > On 3/2/21 3:51 PM, Ville Syrjälä wrote: > > On Tue, Mar 02, 2021 at 01:00:40PM +0100, Hans de Goede wrote: > >> As explained by a long comment block, on VLV intel_setup_outputs() > >> sometimes thinks there might be an eDP pa

Re: [Intel-gfx] [PATCH v9 11/70] drm/i915: Disable userptr pread/pwrite support.

Never used by Mesa AFAIK Acked-by: Jason Ekstrand On Tue, Mar 23, 2021 at 10:51 AM Maarten Lankhorst wrote: > > Userptr should not need the kernel for a userspace memcpy, userspace > needs to call memcpy directly. > > Specifically, disable i915_gem_pwrite_ioctl() and i915_gem_pread_ioctl(). > >

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/audio: set HDA link parameters in driver (rev2)

== Series Details == Series: drm/i915/audio: set HDA link parameters in driver (rev2) URL : https://patchwork.freedesktop.org/series/87040/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915:22: ./drivers/gpu/drm/i915/intel_run

[Intel-gfx] ✓ Fi.CI.BAT: success for Default request/fence expiry + watchdog (rev5)

== Series Details == Series: Default request/fence expiry + watchdog (rev5) URL : https://patchwork.freedesktop.org/series/87930/ State : success == Summary == CI Bug Log - changes from CI_DRM_9889 -> Patchwork_19847 Summary --- **SU

Re: [Intel-gfx] [bug report] drm/i915: Fix enabled_planes bitmask

On Wed, Mar 24, 2021 at 10:22:54AM +0300, Dan Carpenter wrote: > Hello Ville Syrjälä, > > This is a semi-automatic email about new static checker warnings. > > The patch 97bc7ffa1b1e: "drm/i915: Fix enabled_planes bitmask" from > Mar 5, 2021, leads to the following Smatch complaint: > > driv

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Default request/fence expiry + watchdog (rev5)

== Series Details == Series: Default request/fence expiry + watchdog (rev5) URL : https://patchwork.freedesktop.org/series/87930/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915:22: ./drivers/gpu/drm/i915/intel_runtime_pm.c:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Default request/fence expiry + watchdog (rev5)

== Series Details == Series: Default request/fence expiry + watchdog (rev5) URL : https://patchwork.freedesktop.org/series/87930/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8fc435bf4d9f drm/i915: Extract active lookup engine to a helper -:114: CHECK:LINE_SPACING: Please don'

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Remove obj->mm.lock! (rev19)

== Series Details == Series: drm/i915: Remove obj->mm.lock! (rev19) URL : https://patchwork.freedesktop.org/series/82337/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9889 -> Patchwork_19846 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Remove obj->mm.lock! (rev19)

== Series Details == Series: drm/i915: Remove obj->mm.lock! (rev19) URL : https://patchwork.freedesktop.org/series/82337/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' n

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Remove obj->mm.lock! (rev19)

== Series Details == Series: drm/i915: Remove obj->mm.lock! (rev19) URL : https://patchwork.freedesktop.org/series/82337/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +drivers/gpu/drm/i915/gt/in

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove obj->mm.lock! (rev19)

== Series Details == Series: drm/i915: Remove obj->mm.lock! (rev19) URL : https://patchwork.freedesktop.org/series/82337/ State : warning == Summary == $ dim checkpatch origin/drm-tip f2f3d15b07cd drm/i915: Do not share hwsp across contexts any more, v8. -:565: WARNING:CONSTANT_COMPARISON: Com

[Intel-gfx] [PATCH v2] drm/i915/audio: set HDA link parameters in driver

Update logic to program AUD_FREQ_CNTRL register based on new guidance. Earlier this register was configured by BIOS and driver discovered the value at init. This is no longer recommended and instead driver should set the values based on the hardware revision. Add the recommended values for all sup

[Intel-gfx] ✓ Fi.CI.BAT: success for HDCP 2.2 DP errata (rev2)

== Series Details == Series: HDCP 2.2 DP errata (rev2) URL : https://patchwork.freedesktop.org/series/86340/ State : success == Summary == CI Bug Log - changes from CI_DRM_9889 -> Patchwork_19845 Summary --- **SUCCESS** No regress

Re: [Intel-gfx] [PATCH 15/18] vfio/gvt: Make DRM_I915_GVT depend on VFIO_MDEV

On Tue, Mar 23, 2021 at 08:26:30PM +0100, Christoph Hellwig wrote: > On Tue, Mar 23, 2021 at 02:55:32PM -0300, Jason Gunthorpe wrote: > > Ideally all of this would be moved to kvmgt.c, but it is entangled with > > the rest of the "generic" code in an odd way. Thus put in a kconfig > > dependency so

Re: [Intel-gfx] [PATCH v9 27/70] drm/i915: Make __engine_unpark() compatible with ww locking.

On Tue, Mar 23, 2021 at 04:50:16PM +0100, Maarten Lankhorst wrote: > Take the ww lock around engine_unpark. Because of the > many many places where rpm is used, I chose the safest option > and used a trylock to opportunistically take this lock for > __engine_unpark. Correct choice, runtime pm resu

Re: [Intel-gfx] [PATCH v9 25/70] drm/i915: Take reservation lock around i915_vma_pin.

On Tue, Mar 23, 2021 at 04:50:14PM +0100, Maarten Lankhorst wrote: > We previously complained when ww == NULL. > > This function is now only used in selftests to pin an object, > and ww locking is now fixed. > > Signed-off-by: Maarten Lankhorst > Reviewed-by: Thomas Hellström > --- > .../i915/

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Extract active lookup engine to a helper

On Wed, 24 Mar 2021 at 12:13, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Move active engine lookup to exported i915_request_active_engine. > > Signed-off-by: Tvrtko Ursulin Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@lists.f

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for HDMI2.1 PCON Misc Fixes (rev5)

Hi Lakshmi, igt@kms_chamelium@hdmi-hpd-fast: * fi-icl-u2: PASS -> DMESG-WARN

[Intel-gfx] ✗ Fi.CI.DOCS: warning for HDCP 2.2 DP errata (rev2)

== Series Details == Series: HDCP 2.2 DP errata (rev2) URL : https://patchwork.freedesktop.org/series/86340/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915:22: ./drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline

[Intel-gfx] [PATCH 7/7] drm/i915: Allow configuring default request expiry via modparam

From: Tvrtko Ursulin Module parameter is added (request_timeout_ms) to allow configuring the default request/fence expiry. Default value is inherited from CONFIG_DRM_I915_REQUEST_TIMEOUT. Signed-off-by: Tvrtko Ursulin Cc: Daniel Vetter Acked-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i9

[Intel-gfx] [PATCH 5/7] drm/i915: Request watchdog infrastructure

From: Tvrtko Ursulin Prepares the plumbing for setting request/fence expiration time. All code is put in place but is never activated due yet missing ability to actually configure the timer. Outline of the basic operation: A timer is started when request is ready for execution. If the request c

[Intel-gfx] [PATCH 6/7] drm/i915: Fail too long user submissions by default

From: Tvrtko Ursulin A new Kconfig option CONFIG_DRM_I915_REQUEST_TIMEOUT is added, defaulting to 20s, and this timeout is applied to all users contexts using the previously added watchdog facility. Result of this is that any user submission will simply fail after this timeout, either causing a

[Intel-gfx] [PATCH 4/7] drm/i915: Handle async cancellation in sentinel assert

From: Tvrtko Ursulin With the watchdog cancelling requests asynchronously to preempt-to-busy we need to relax one assert making it apply only to requests not in error. v2: * Check against the correct request! v3: * Simplify the check to avoid the question of when to sample the fence error

[Intel-gfx] [PATCH 3/7] drm/i915: Restrict sentinel requests further

From: Tvrtko Ursulin Disallow sentinel requests follow previous sentinels to make request cancellation work better when faced with a chain of requests which have all been marked as in error. Because in cases where we end up with a stream of cancelled requests we want to turn of request coalescin

[Intel-gfx] [PATCH 2/7] drm/i915: Individual request cancellation

From: Chris Wilson Currently, we cancel outstanding requests within a context when the context is closed. We may also want to cancel individual requests using the same graceful preemption mechanism. v2 (Tvrtko): * Cancel waiters carefully considering no timeline lock and RCU. * Fixed selftests

[Intel-gfx] [PATCH 1/7] drm/i915: Extract active lookup engine to a helper

From: Tvrtko Ursulin Move active engine lookup to exported i915_request_active_engine. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 34 +--- drivers/gpu/drm/i915/i915_request.c | 44 + drivers/gpu/drm/i915/i915_request.

[Intel-gfx] [PATCH v4 0/7] Default request/fence expiry + watchdog

From: Tvrtko Ursulin "Watchdog" aka "restoring hangcheck" aka default request/fence expiry - second post of a somewhat controversial feature, now upgraded to patch status. I quote the "watchdog" becuase in classical sense watchdog would allow userspace to ping it and so remain alive. I quote "r

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP 2.2 DP errata (rev2)

== Series Details == Series: HDCP 2.2 DP errata (rev2) URL : https://patchwork.freedesktop.org/series/86340/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3cb4056611f6 drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg -:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrappe

[Intel-gfx] [PATCH] drm/i915: Pass ww ctx to pin_map, v2.

This will allow us to explicitly pass the ww to pin_pages, when it starts taking it. This allows us to finally kill off the explicit passing of ww by retrieving it from the obj. Changes since v1: - Rename 'ret' to ptr, fix error handling of return ptr. Signed-off-by: Maarten Lankhorst --- .../

[Intel-gfx] [PATCH v2 2/2] drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16

Fix LC_Send_L_Prime message timeout to 16 as documented in DP HDCP 2.2 errata page 3. https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf Cc: Ramalingam C Reviewed-by: Ankit Nautiyal Signed-off-by: Anshuman Gupta --- include/drm/drm_hdcp.h | 2 +- 1 file chan

[Intel-gfx] [PATCH v2 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg

As documented in HDCP 2.2 DP Errata spec transmitter should abort the authentication protocol in case transmitter has not received the entire {AKE_Send_Cert, AKE_Send_H_prime, AKE_Send_Paring_Info} msg within {110,7,5} miliseconds. Adding above msg timeout values and aborting the HDCP authenticati

[Intel-gfx] [PATCH v2 0/2] HDCP 2.2 DP errata

HDCP DP 2.2 errata is part of HDCP DP 2.3 specs as well. Anshuman Gupta (2): drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16 drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++-- include/drm/drm_hdcp.h

Re: [Intel-gfx] [PATCH] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v2)

On 24/03/2021 09:52, Daniel Vetter wrote: On Wed, Mar 24, 2021 at 09:28:58AM +, Tvrtko Ursulin wrote: On 23/03/2021 17:51, Jason Ekstrand wrote: This API is entirely unnecessary and I'd love to get rid of it. If userspace wants a single timeline across multiple contexts, they can either

Re: [Intel-gfx] [PATCH v9 16/70] drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v7.

On 3/24/21 12:28 PM, Daniel Vetter wrote: On Tue, Mar 23, 2021 at 04:50:05PM +0100, Maarten Lankhorst wrote: Instead of doing what we do currently, which will never work with PROVE_LOCKING, do the same as AMD does, and something similar to relocation slowpath. When all locks are dropped, we acq

Re: [Intel-gfx] [PATCH v9 16/70] drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v7.

On Tue, Mar 23, 2021 at 04:50:05PM +0100, Maarten Lankhorst wrote: > Instead of doing what we do currently, which will never work with > PROVE_LOCKING, do the same as AMD does, and something similar to > relocation slowpath. When all locks are dropped, we acquire the > pages for pinning. When the l

Re: [Intel-gfx] [PATCH] drm/i915/audio: set HDA link parameters in driver

> -Original Message- > From: Kai Vehmanen > Sent: Monday, March 22, 2021 5:24 PM > To: Kai Vehmanen > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > Subject: Re: [PATCH] drm/i915/audio: set HDA link parameters in driver > > Hi, > > On Fri, 12 Feb 2021, Kai Vehmanen wrote: > >

Re: [Intel-gfx] [PATCH v9 17/70] drm/i915: Flatten obj->mm.lock

On Tue, Mar 23, 2021 at 04:50:06PM +0100, Maarten Lankhorst wrote: > With userptr fixed, there is no need for all separate lockdep classes > now, and we can remove all lockdep tricks used. A trylock in the > shrinker is all we need now to flatten the locking hierarchy. > > Signed-off-by: Maarten L

Re: [Intel-gfx] [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

From: David Laight > Sent: 24 March 2021 09:12 > > From: Martin Sebor > > Sent: 22 March 2021 22:08 > ... > > In GCC 11, all access warnings expect objects to be either declared > > or allocated. Pointers with constant values are taken to point to > > nothing valid (as Arnd mentioned above, this

Re: [Intel-gfx] [PATCH v9 68/70] drm/i915: Pass ww ctx to pin_map

On Wed, Mar 24, 2021 at 10:31:26AM +0100, Maarten Lankhorst wrote: > Op 23-03-2021 om 18:30 schreef Matthew Auld: > > On Tue, 23 Mar 2021 at 15:51, Maarten Lankhorst > > wrote: > >> This will allow us to explicitly pass the ww to pin_pages, > >> when it starts taking it. > >> > >> This allows us t

Re: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg

> -Original Message- > From: Nautiyal, Ankit K > Sent: Wednesday, March 24, 2021 3:06 PM > To: Gupta, Anshuman ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to > read entire msg > > Hi Anshuman, > > Changes look good

Re: [Intel-gfx] [PATCH] i915_vma: Rename vma_lookup to i915_vma_lookup

On Tue, Mar 23, 2021 at 01:42:21PM +, Liam Howlett wrote: > Use i915 prefix to avoid name collision with future vma_lookup() in mm. > > Signed-off-by: Liam R. Howlett > Reviewed-by: Matthew Wilcox (Oracle) Applied to i915-gem-next branch for 5.13. We have a bit a branch shuffling going on r

Re: [Intel-gfx] [PATCH] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v2)

On Wed, Mar 24, 2021 at 09:28:58AM +, Tvrtko Ursulin wrote: > > On 23/03/2021 17:51, Jason Ekstrand wrote: > > This API is entirely unnecessary and I'd love to get rid of it. If > > userspace wants a single timeline across multiple contexts, they can > > either use implicit synchronization or

Re: [Intel-gfx] [PATCH] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v2)

On Tue, Mar 23, 2021 at 12:51:49PM -0500, Jason Ekstrand wrote: > This API is entirely unnecessary and I'd love to get rid of it. If > userspace wants a single timeline across multiple contexts, they can > either use implicit synchronization or a syncobj, both of which existed > at the time this f

Re: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg

Hi Anshuman, Changes look good to me as per the Errata. There are minor comments, inline: On 1/27/2021 1:54 PM, Anshuman Gupta wrote: As documented in HDCP 2.2 DP Errata spec transmitter should abort the authentication protocol in case transmitter has not received the entire {AKE_Send_Cert, AK

Re: [Intel-gfx] [PATCH v9 68/70] drm/i915: Pass ww ctx to pin_map

Op 23-03-2021 om 18:30 schreef Matthew Auld: > On Tue, 23 Mar 2021 at 15:51, Maarten Lankhorst > wrote: >> This will allow us to explicitly pass the ww to pin_pages, >> when it starts taking it. >> >> This allows us to finally kill off the explicit passing of ww >> by retrieving it from the obj. >

Re: [Intel-gfx] [PATCH] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v2)

On 23/03/2021 17:51, Jason Ekstrand wrote: This API is entirely unnecessary and I'd love to get rid of it. If userspace wants a single timeline across multiple contexts, they can either use implicit synchronization or a syncobj, both of which existed at the time this feature landed. The justi

Re: [Intel-gfx] [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

From: Martin Sebor > Sent: 22 March 2021 22:08 ... > In GCC 11, all access warnings expect objects to be either declared > or allocated. Pointers with constant values are taken to point to > nothing valid (as Arnd mentioned above, this is to detect invalid > accesses to members of structs at addre

[Intel-gfx] [bug report] drm/i915: Fix enabled_planes bitmask

Hello Ville Syrjälä, This is a semi-automatic email about new static checker warnings. The patch 97bc7ffa1b1e: "drm/i915: Fix enabled_planes bitmask" from Mar 5, 2021, leads to the following Smatch complaint: drivers/gpu/drm/i915/display/intel_atomic_plane.c:332 intel_plane_atomic_check_wit

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Add RFC section

On Tue, 23 Mar 2021 at 18:45, Daniel Vetter wrote: > > Motivated by the pre-review process for i915 gem/gt features, but > probably useful in general for complex stuff. > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Jason Ekstrand > Cc: Dave Airlie > Signed-off-by: Daniel