Re: [Intel-gfx] [PATCH 15/18] vfio/gvt: Make DRM_I915_GVT depend on VFIO_MDEV

2021-03-29 Thread Zhenyu Wang
On 2021.03.23 16:39:36 -0300, Jason Gunthorpe wrote: > On Tue, Mar 23, 2021 at 08:26:30PM +0100, Christoph Hellwig wrote: > > On Tue, Mar 23, 2021 at 02:55:32PM -0300, Jason Gunthorpe wrote: > > > Ideally all of this would be moved to kvmgt.c, but it is entangled with > > > the rest of the

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Eliminate IS_GEN9_{BC,LP} (rev2)

2021-03-29 Thread Patchwork
== Series Details == Series: drm/i915/display: Eliminate IS_GEN9_{BC,LP} (rev2) URL : https://patchwork.freedesktop.org/series/88466/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9913_full -> Patchwork_19878_full Summary

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add support for FBs requiring a POT stride padding (rev4)

2021-03-29 Thread Imre Deak
On Mon, Mar 29, 2021 at 04:28:43PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Add support for FBs requiring a POT stride padding (rev4) > URL : https://patchwork.freedesktop.org/series/87859/ > State : success Thanks for the review, pushed to -din. > == Summary == >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Eliminate IS_GEN9_{BC,LP} (rev2)

2021-03-29 Thread Patchwork
== Series Details == Series: drm/i915/display: Eliminate IS_GEN9_{BC,LP} (rev2) URL : https://patchwork.freedesktop.org/series/88466/ State : success == Summary == CI Bug Log - changes from CI_DRM_9913 -> Patchwork_19878 Summary ---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove repeated declaration

2021-03-29 Thread Souza, Jose
On Fri, 2021-03-26 at 17:39 +, Patchwork wrote: Patch Details Series: drm/i915: Remove repeated declaration URL:https://patchwork.freedesktop.org/series/88480/ State: failure Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19866/index.html CI Bug Log - changes from

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display: Eliminate IS_GEN9_{BC,LP} (rev2)

2021-03-29 Thread Patchwork
== Series Details == Series: drm/i915/display: Eliminate IS_GEN9_{BC,LP} (rev2) URL : https://patchwork.freedesktop.org/series/88466/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Eliminate IS_GEN9_{BC,LP} (rev2)

2021-03-29 Thread Patchwork
== Series Details == Series: drm/i915/display: Eliminate IS_GEN9_{BC,LP} (rev2) URL : https://patchwork.freedesktop.org/series/88466/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5804ba5dc847 drm/i915/display: Eliminate IS_GEN9_{BC, LP} -:998: CHECK:UNNECESSARY_PARENTHESES:

Re: [Intel-gfx] [PATCH v2 8/8] drm/displayid: rename displayid_hdr to displayid_header

2021-03-29 Thread Ville Syrjälä
On Mon, Mar 29, 2021 at 04:37:22PM +0300, Jani Nikula wrote: > Avoid any confusion with High Dynamic Range. No functional changes. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_displayid.c | 10 +- > include/drm/drm_displayid.h | 2 +- > 2

Re: [Intel-gfx] [PATCH v2 7/8] drm/displayid: allow data blocks with 0 payload length

2021-03-29 Thread Ville Syrjälä
On Mon, Mar 29, 2021 at 04:37:21PM +0300, Jani Nikula wrote: > The DisplayID specifications explicitly call out 0 as a valid payload > length for data blocks. The mere presence of a data block, or the > information coded in the block specific data (bits 7:3 in offset 1), may > be enough to convey

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev5)

2021-03-29 Thread Patchwork
== Series Details == Series: drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev5) URL : https://patchwork.freedesktop.org/series/87242/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9912_full -> Patchwork_19877_full

[Intel-gfx] [PATCH v2] drm/i915/display: Eliminate IS_GEN9_{BC, LP}

2021-03-29 Thread Matt Roper
Now that we've eliminated INTEL_GEN(), IS_GEN_RANGE(), etc. from the display code, we should also kill off our use of the IS_GEN9_* macros too. We'll do the conversion manually this time instead of using Coccinelle since the most logical substitution can depend heavily on the code context, and

[Intel-gfx] ✓ Fi.CI.IGT: success for vfio/pci: Add support for opregion v2.0+ (rev5)

2021-03-29 Thread Patchwork
== Series Details == Series: vfio/pci: Add support for opregion v2.0+ (rev5) URL : https://patchwork.freedesktop.org/series/84494/ State : success == Summary == CI Bug Log - changes from CI_DRM_9895_full -> Patchwork_19853_full Summary

Re: [Intel-gfx] linux-next: build warning after merge of the drm-intel-fixes tree

2021-03-29 Thread Imre Deak
Hi Stephen, thanks for the report. On Mon, Mar 29, 2021 at 09:01:17AM +1100, Stephen Rothwell wrote: > Hi all, > > On Fri, 26 Mar 2021 19:58:38 +1100 Stephen Rothwell > wrote: > > > > After merging the drm-intel-fixes tree, today's linux-next build > > (htmldocs) produced this warning: > > >

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add support for FBs requiring a POT stride padding (rev4)

2021-03-29 Thread Vudum, Lakshminarayana
Re-reported. -Original Message- From: Deak, Imre Sent: Monday, March 29, 2021 8:47 AM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915: Add support for FBs requiring a POT stride padding (rev4) Hi Lakshmi, On Sun, Mar 28,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev5)

2021-03-29 Thread Patchwork
== Series Details == Series: drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev5) URL : https://patchwork.freedesktop.org/series/87242/ State : success == Summary == CI Bug Log - changes from CI_DRM_9912 -> Patchwork_19877

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev5)

2021-03-29 Thread Patchwork
== Series Details == Series: drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev5) URL : https://patchwork.freedesktop.org/series/87242/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev5)

2021-03-29 Thread Patchwork
== Series Details == Series: drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev5) URL : https://patchwork.freedesktop.org/series/87242/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev5)

2021-03-29 Thread Patchwork
== Series Details == Series: drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev5) URL : https://patchwork.freedesktop.org/series/87242/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6ae29065652a drm/dp: Fixup kernel docs for struct drm_dp_aux 1aaf16c813ff

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid: overhaul displayid iterator (rev3)

2021-03-29 Thread Patchwork
== Series Details == Series: drm/edid: overhaul displayid iterator (rev3) URL : https://patchwork.freedesktop.org/series/87802/ State : success == Summary == CI Bug Log - changes from CI_DRM_9912_full -> Patchwork_19875_full Summary

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for vfio/pci: Add support for opregion v2.0+ (rev5)

2021-03-29 Thread Vudum, Lakshminarayana
That's a warning. For now, nothing we can do about that. -Original Message- From: Gao, Fred Sent: Monday, March 29, 2021 9:23 AM To: Vudum, Lakshminarayana ; intel-gfx@lists.freedesktop.org Cc: Wang, Zhenyu Z Subject: RE: ✗ Fi.CI.DOCS: warning for vfio/pci: Add support for opregion

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add support for FBs requiring a POT stride padding (rev4)

2021-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Add support for FBs requiring a POT stride padding (rev4) URL : https://patchwork.freedesktop.org/series/87859/ State : success == Summary == CI Bug Log - changes from CI_DRM_9909_full -> Patchwork_19873_full

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for vfio/pci: Add support for opregion v2.0+ (rev5)

2021-03-29 Thread Gao, Fred
Thanks for the quick help. Test of Fi.CI.DOCS is still failed although we do not change any code in i915. > -Original Message- > From: Vudum, Lakshminarayana > Sent: Tuesday, March 30, 2021 12:20 AM > To: Gao, Fred ; intel-gfx@lists.freedesktop.org > Cc: Wang, Zhenyu Z > Subject: RE: ✗

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for vfio/pci: Add support for opregion v2.0+ (rev5)

2021-03-29 Thread Vudum, Lakshminarayana
Failure is reported. It's now showing as success. -Original Message- From: Gao, Fred Sent: Monday, March 29, 2021 12:12 AM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana Cc: Wang, Zhenyu Z Subject: RE: ✗ Fi.CI.DOCS: warning for vfio/pci: Add support for opregion v2.0+

[Intel-gfx] ✓ Fi.CI.BAT: success for vfio/pci: Add support for opregion v2.0+ (rev5)

2021-03-29 Thread Patchwork
== Series Details == Series: vfio/pci: Add support for opregion v2.0+ (rev5) URL : https://patchwork.freedesktop.org/series/84494/ State : success == Summary == CI Bug Log - changes from CI_DRM_9895 -> Patchwork_19853 Summary ---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add support for FBs requiring a POT stride padding (rev4)

2021-03-29 Thread Imre Deak
Hi Lakshmi, On Sun, Mar 28, 2021 at 12:22:46AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Add support for FBs requiring a POT stride padding (rev4) > URL : https://patchwork.freedesktop.org/series/87859/ > State : failure > > == Summary == > > CI Bug Log - changes

[Intel-gfx] ✗ Fi.CI.BUILD: failure for i915: Fix uninitialized variable err

2021-03-29 Thread Patchwork
== Series Details == Series: i915: Fix uninitialized variable err URL : https://patchwork.freedesktop.org/series/88545/ State : failure == Summary == Applying: i915: Fix uninitialized variable err Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/i915_mm.c Falling

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: overhaul displayid iterator (rev3)

2021-03-29 Thread Patchwork
== Series Details == Series: drm/edid: overhaul displayid iterator (rev3) URL : https://patchwork.freedesktop.org/series/87802/ State : success == Summary == CI Bug Log - changes from CI_DRM_9912 -> Patchwork_19875 Summary ---

Re: [Intel-gfx] [PATCH v3 02/16] mei: pxp: export pavp client to me client bus

2021-03-29 Thread Michal Wajdeczko
On 29.03.2021 00:56, Daniele Ceraolo Spurio wrote: > From: Vitaly Lubart > > Export PAVP client to work with i915 driver, > for binding it uses kernel component framework. > > Signed-off-by: Vitaly Lubart > Signed-off-by: Tomas Winkler > Signed-off-by: Daniele Ceraolo Spurio > --- >

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/edid: overhaul displayid iterator (rev3)

2021-03-29 Thread Patchwork
== Series Details == Series: drm/edid: overhaul displayid iterator (rev3) URL : https://patchwork.freedesktop.org/series/87802/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: overhaul displayid iterator (rev3)

2021-03-29 Thread Patchwork
== Series Details == Series: drm/edid: overhaul displayid iterator (rev3) URL : https://patchwork.freedesktop.org/series/87802/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: overhaul displayid iterator (rev3)

2021-03-29 Thread Patchwork
== Series Details == Series: drm/edid: overhaul displayid iterator (rev3) URL : https://patchwork.freedesktop.org/series/87802/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7e7342d215ff drm/edid: make a number of functions, parameters and variables const d0337807fed3

Re: [Intel-gfx] [PATCH v3 01/16] drm/i915/pxp: Define PXP component interface

2021-03-29 Thread Michal Wajdeczko
On 29.03.2021 00:56, Daniele Ceraolo Spurio wrote: > This will be used for communication between the i915 driver and the mei > one. Defining it in a stand-alone patch to avoid circualr dependedencies typos > between the patches modifying the 2 drivers. > > Split out from an original patch

[Intel-gfx] [PATCH] i915: Fix uninitialized variable err

2021-03-29 Thread Colin King
From: Colin Ian King In the case where !sg_dma_len(sgl) breaks out of the do-while loop on the first iteration, error variable err has not been assigned any value and will contain garbage. Fix this by ensuring err is initialized to zero. Addresses-Coverity: ("Uninitialized scalar variable")

[Intel-gfx] [PATCH v2 8/8] drm/displayid: rename displayid_hdr to displayid_header

2021-03-29 Thread Jani Nikula
Avoid any confusion with High Dynamic Range. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_displayid.c | 10 +- include/drm/drm_displayid.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_displayid.c

[Intel-gfx] [PATCH v2 7/8] drm/displayid: allow data blocks with 0 payload length

2021-03-29 Thread Jani Nikula
The DisplayID specifications explicitly call out 0 as a valid payload length for data blocks. The mere presence of a data block, or the information coded in the block specific data (bits 7:3 in offset 1), may be enough to convey the necessary information. Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH v2 6/8] drm/edid: use the new displayid iterator for tile info

2021-03-29 Thread Jani Nikula
Neatly reduce displayid boilerplate in code. Remove excessive debug logging while at it, no other functional changes. The old displayid iterator becomes unused; remove it as well as make drm_find_displayid_extension() static. Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH v2 5/8] drm/edid: use the new displayid iterator for finding CEA extension

2021-03-29 Thread Jani Nikula
Neatly reduce displayid boilerplate in code. No functional changes. Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c

[Intel-gfx] [PATCH v2 4/8] drm/edid: use the new displayid iterator for detailed modes

2021-03-29 Thread Jani Nikula
Neatly reduce displayid boilerplate in code. No functional changes. Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c

[Intel-gfx] [PATCH v2 3/8] drm/displayid: add new displayid section/block iterators

2021-03-29 Thread Jani Nikula
Iterating DisplayID blocks across sections (in EDID extensions) is unnecessarily complicated for the caller. Implement DisplayID iterators to go through all blocks in all sections. Usage example: const struct displayid_block *block; struct displayid_iter iter;

[Intel-gfx] [PATCH v2 2/8] drm/displayid: add separate drm_displayid.c

2021-03-29 Thread Jani Nikula
We'll be adding more DisplayID specific functions going forward, so start off by splitting out a few functions to a separate file. We don't bother with exporting the functions; at least for now they should be needed solely within drm.ko. No functional changes. Reviewed-by: Ville Syrjälä

[Intel-gfx] [PATCH v2 1/8] drm/edid: make a number of functions, parameters and variables const

2021-03-29 Thread Jani Nikula
If there's no need to change it, it should be const. There's more to be done, but start off with changes that make follow-up work easier. No functional changes. Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 58 ++---

[Intel-gfx] [PATCH v2 0/8] drm/edid: overhaul displayid iterator

2021-03-29 Thread Jani Nikula
v2 of [1], addressing Ville's review comments, and adding a couple of extra patches on top. BR, Jani. [1] https://patchwork.freedesktop.org/series/87802/ Jani Nikula (8): drm/edid: make a number of functions, parameters and variables const drm/displayid: add separate drm_displayid.c

Re: [Intel-gfx] [PATCH v4 0/7] drm/i915: refactor KBL/TGL/ADLS stepping scheme

2021-03-29 Thread Jani Nikula
On Fri, 26 Mar 2021, Jani Nikula wrote: > v4 of [1], minor tweaks to address review. > > BR, > Jani. > > [1] https://patchwork.freedesktop.org/series/87323/ Pushed to drm-intel-next, thanks for the reviews. BR, Jani. > > > Jani Nikula (7): > drm/i915: split out stepping info to a new file >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Stop adding planes to the commit needlessly

2021-03-29 Thread Lisovskiy, Stanislav
On Thu, Mar 25, 2021 at 01:37:31PM +0200, Ville Syrjälä wrote: > On Thu, Mar 25, 2021 at 11:35:53AM +0200, Lisovskiy, Stanislav wrote: > > On Thu, Mar 25, 2021 at 02:44:15AM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > The dbuf bandwidth calculations don't need the planes to

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for vfio/pci: Add support for opregion v2.0+ (rev5)

2021-03-29 Thread Zhenyu Wang
On 2021.03.29 15:12:23 +0800, Gao, Fred wrote: > Hi, Lakshmi: > > Can u help on this failure again, > the only difference between version 5& 4 is the comments. > Thanks in advance. Looks i915 build warning, not related to vfio driver at all... > > > -Original Message- > > From:

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for vfio/pci: Add support for opregion v2.0+ (rev5)

2021-03-29 Thread Gao, Fred
Hi, Lakshmi: Can u help on this failure again, the only difference between version 5& 4 is the comments. Thanks in advance. > -Original Message- > From: Patchwork > Sent: Friday, March 26, 2021 5:05 AM > To: Gao, Fred > Cc: intel-gfx@lists.freedesktop.org > Subject: ✗ Fi.CI.DOCS:

Re: [Intel-gfx] [PATCH v2 05/20] drm/dp: Add backpointer to drm_device in drm_dp_aux

2021-03-29 Thread Thierry Reding
On Fri, Mar 26, 2021 at 04:37:52PM -0400, Lyude Paul wrote: > This is something that we've wanted for a while now: the ability to > actually look up the respective drm_device for a given drm_dp_aux struct. > This will also allow us to transition over to using the drm_dbg_*() helpers > for debug

Re: [Intel-gfx] [PATCH v2 02/20] drm/tegra: Don't register DP AUX channels before connectors

2021-03-29 Thread Thierry Reding
On Fri, Mar 26, 2021 at 04:37:49PM -0400, Lyude Paul wrote: > As pointed out by the documentation for drm_dp_aux_register(), > drm_dp_aux_init() should be used in situations where the AUX channel for a > display driver can potentially be registered before it's respective DRM > driver. This is the