[Intel-gfx] ✓ Fi.CI.BAT: success for Simplify intel_setup_outputs

2021-04-13 Thread Patchwork
== Series Details == Series: Simplify intel_setup_outputs URL : https://patchwork.freedesktop.org/series/88988/ State : success == Summary == CI Bug Log - changes from CI_DRM_9962 -> Patchwork_19919 Summary --- **WARNING** Minor u

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Extend GEN renames to the rest of the driver (rev3)

2021-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Extend GEN renames to the rest of the driver (rev3) URL : https://patchwork.freedesktop.org/series/88825/ State : success == Summary == CI Bug Log - changes from CI_DRM_9962_full -> Patchwork_19918_full

Re: [Intel-gfx] [PATCH 4/7] mm: Introduce verify_page_range()

2021-04-13 Thread Peter Zijlstra
On Mon, Apr 12, 2021 at 01:05:09PM -0700, Kees Cook wrote: > On Mon, Apr 12, 2021 at 10:00:16AM +0200, Peter Zijlstra wrote: > > +struct vpr_data { > > + int (*fn)(pte_t pte, unsigned long addr, void *data); > > + void *data; > > +}; > > Eeerg. This is likely to become an attack target itself.

[Intel-gfx] [RFC] Cross-driver ww transaction lock lists

2021-04-13 Thread Thomas Hellström
Hi! During the dma_resv conversion of the i915 driver, we've been using ww transaction lock lists to keep track of ww_mutexes that are locked during the transaction so that they can be batch unlocked at suitable locations. Including also the LMEM/VRAM eviction we've ended up with two static lists

Re: [Intel-gfx] [RFC] Cross-driver ww transaction lock lists

2021-04-13 Thread Christian König
Am 13.04.21 um 09:50 schrieb Thomas Hellström: Hi! During the dma_resv conversion of the i915 driver, we've been using ww transaction lock lists to keep track of ww_mutexes that are locked during the transaction so that they can be batch unlocked at suitable locations. Including also the LMEM/

Re: [Intel-gfx] [RFC] Cross-driver ww transaction lock lists

2021-04-13 Thread Intel
Hi, On 4/13/21 9:57 AM, Christian König wrote: Am 13.04.21 um 09:50 schrieb Thomas Hellström: Hi! During the dma_resv conversion of the i915 driver, we've been using ww transaction lock lists to keep track of ww_mutexes that are locked during the transaction so that they can be batch unlocke

[Intel-gfx] ✗ Fi.CI.IGT: failure for Simplify intel_setup_outputs

2021-04-13 Thread Patchwork
== Series Details == Series: Simplify intel_setup_outputs URL : https://patchwork.freedesktop.org/series/88988/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9962_full -> Patchwork_19919_full Summary --- **FAILURE**

[Intel-gfx] [PATCH] drm/i915/gvt: remove useless function

2021-04-13 Thread Jiapeng Chong
Fix the following clang warning: drivers/gpu/drm/i915/gvt/gtt.c:590:20: warning: unused function 'ppgtt_set_guest_root_entry' [-Wunused-function]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/i915/gvt/gtt.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/d

Re: [Intel-gfx] [PATCH 3/3] drm/i915/display: remove strap checks from gen 9

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Lucas De Marchi wrote: > Direction on gen9+ was to stop reading the straps and only rely on the > VBT for marking the port presence. This happened while dealing with > WaIgnoreDDIAStrap and instead of using it as a WA, it should now be the > normal flow. See commit 885d3e5b6f0

Re: [Intel-gfx] [PATCH v2 01/12] drm/i915/display: use DISPLAY_VER() on remaining users

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Lucas De Marchi wrote: > Commit 989634fb49ad ("drm/i915/audio: set HDA link parameters in driver") > added INTEL_GEN() in the display code, where it should actually be using > DISPLAY_VER(). Switch to the new macro. > > Cc: Kai Vehmanen > Signed-off-by: Lucas De Marchi Revi

Re: [Intel-gfx] [PATCH v2 02/12] drm/i915: rename display.version to display.ver

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Lucas De Marchi wrote: > The macro we use to check is called DISPLAY_VER(). While using this > macro and the new ones being added in following changes I made the > mistake multiple times when mixing both "ver" and "version". Although > it's usually better to prefer the complet

Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-13 Thread Matthew Auld
On Mon, 12 Apr 2021 at 18:01, Daniel Vetter wrote: > > On Mon, Apr 12, 2021 at 6:08 PM Matthew Auld > wrote: > > > > On Mon, 12 Apr 2021 at 16:17, Daniel Vetter wrote: > > > > > > On Mon, Apr 12, 2021 at 10:05:25AM +0100, Matthew Auld wrote: > > > > We need to general our accessor for the page d

Re: [Intel-gfx] [PATCH v2 04/12] drm/i915: add macros for graphics and media versions

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Lucas De Marchi wrote: > Like it was done in > commit 01eb15c9165e ("drm/i915: Add DISPLAY_VER() and related macros") > add the correspondent macros for graphics and media. Going forward we > will prefer checking the versions for the specific IPs (graphics, media > and display

Re: [Intel-gfx] [PATCH v2 03/12] drm/i915/display: rename display version macros

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Lucas De Marchi wrote: > While converting the rest of the driver to use GRAPHICS_VER() and > MEDIA_VER(), following what was done for display, some discussions went > back on what we did for display: > > 1) Why is the == comparison special that deserves a separate >

Re: [Intel-gfx] [PATCH v2 05/12] drm/i915/gt: replace gen use in intel_engine_cs

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Lucas De Marchi wrote: > Start using the new fields graphics_version for the previous gen checks. > Here we rename the "gen" field and replace the comparisons using it to > start using the new GRAPHICS_VER(). Other uses of INTEL_GEN() were left > as is for automatic conversion

Re: [Intel-gfx] [PATCH v2 06/12] drm/i915/selftests: replace unused mask with simple version

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Lucas De Marchi wrote: > Since its introduction 2 years ago, we never used the mask to span more > than one gen. Replace gen_mask a single number and start using the new > GRAPHICS_VER(). > > Signed-off-by: Lucas De Marchi Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/

[Intel-gfx] [PATCH] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-13 Thread Jisheng Zhang
I met below error during boot with i915 builtin if pass "i915.mitigations=off": [0.015589] Booting kernel: `off' invalid for parameter `i915.mitigations' The reason is slab subsystem isn't ready at that time, so kstrdup() returns NULL. Fix this issue by using stack var instead of kstrdup(). F

Re: [Intel-gfx] [PATCH v2 07/12] drm/i915/selftests: eliminate use of gen_mask

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Lucas De Marchi wrote: > Remove the remaining uses of INTEL_GEN_MASK() and the correspondent > gen_mask in struct intel_device_info. This will allow the removal of > gen_mask later since it's incompatible with the new per-IP versioning > scheme. > > Signed-off-by: Lucas De Mar

Re: [Intel-gfx] [PATCH v2 08/12] drm/i915: finish removal of gen_mask

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Lucas De Marchi wrote: > Now that it's not used anywhere, remove it from struct > intel_device_info. To allow a period in which code will be converted to > the new macro, keep IS_GEN_RANGE() around, just redefining it to use > the new fields. The size advantage from IS_GEN_RAN

Re: [Intel-gfx] [PATCH v2 09/12] drm/i915: eliminate remaining uses of intel_device_info->gen

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Lucas De Marchi wrote: > Replace gen with the new graphics_ver value and use GRAPHICS_VER() > in those places. > > Signed-off-by: Lucas De Marchi > --- > .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 22 +-- > drivers/gpu/drm/i915/i915_drv.c |

Re: [Intel-gfx] [PATCH v2 10/12] drm/i915: finish removal of gen from intel_device_info

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Lucas De Marchi wrote: > Now that it's not being used anymore, finish its removal. Like for > gen_mask, we replace INTEL_GEN() and IS_GEN() macros to use the new > field. > > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/i915_drv.h | 10 +-

Re: [Intel-gfx] [PATCH v2 11/12] drm/i915: add media and display versions to device_info print

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Lucas De Marchi wrote: > Since we are now converting from a single gen version to graphics_ver, > media_ver and display_ver, add the last 2 when printing the device info. > > Signed-off-by: Lucas De Marchi Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_device

Re: [Intel-gfx] [PATCH v2 12/12] drm/i915: split dgfx features from gen 12

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Lucas De Marchi wrote: > Make them independent so we can use DGFX_FEATURES more generically. > For future platforms that do not use the GEN nomenclature we will define > graphics, media and display separately, so we avoid setting graphics_ver > with the GEN() macro. > > Signed

[Intel-gfx] [PATCH 01/12] drm/arm: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Daniel Vetter
Since commit 890880ddfdbe256083170866e49c87618b706ac7 Author: Paul Kocialkowski Date: Fri Jan 4 09:56:10 2019 +0100 drm: Auto-set allow_fb_modifiers when given modifiers at plane init this is done automatically as part of plane init, if drivers set the modifier list correctly. Which is th

[Intel-gfx] [PATCH 02/12] drm/arm/malidp: Always list modifiers

2021-04-13 Thread Daniel Vetter
Even when all we support is linear, make that explicit. Otherwise the uapi is rather confusing. Cc: sta...@vger.kernel.org Cc: Pekka Paalanen Cc: Liviu Dudau Cc: Brian Starkey Signed-off-by: Daniel Vetter --- drivers/gpu/drm/arm/malidp_planes.c | 9 +++-- 1 file changed, 7 insertions(+),

[Intel-gfx] [PATCH 04/12] drm/i915: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Daniel Vetter
Since commit 890880ddfdbe256083170866e49c87618b706ac7 Author: Paul Kocialkowski Date: Fri Jan 4 09:56:10 2019 +0100 drm: Auto-set allow_fb_modifiers when given modifiers at plane init this is done automatically as part of plane init, if drivers set the modifier list correctly. Which is th

[Intel-gfx] [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Daniel Vetter
Since commit 890880ddfdbe256083170866e49c87618b706ac7 Author: Paul Kocialkowski Date: Fri Jan 4 09:56:10 2019 +0100 drm: Auto-set allow_fb_modifiers when given modifiers at plane init this is done automatically as part of plane init, if drivers set the modifier list correctly. Which is th

[Intel-gfx] [PATCH 07/12] drm/msm/mdp4: Fix modifier support enabling

2021-04-13 Thread Daniel Vetter
Setting the cap without the modifier list is very confusing to userspace. Fix that by listing the ones we support explicitly. Stable backport so that userspace can rely on this working in a reasonable way, i.e. that the cap set implies IN_FORMATS is available. Cc: sta...@vger.kernel.org Cc: Pekka

[Intel-gfx] [PATCH 09/12] drm/stm: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Daniel Vetter
Since commit 890880ddfdbe256083170866e49c87618b706ac7 Author: Paul Kocialkowski Date: Fri Jan 4 09:56:10 2019 +0100 drm: Auto-set allow_fb_modifiers when given modifiers at plane init this is done automatically as part of plane init, if drivers set the modifier list correctly. Which is th

[Intel-gfx] [PATCH 11/12] drm/vc4: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Daniel Vetter
Since commit 890880ddfdbe256083170866e49c87618b706ac7 Author: Paul Kocialkowski Date: Fri Jan 4 09:56:10 2019 +0100 drm: Auto-set allow_fb_modifiers when given modifiers at plane init this is done automatically as part of plane init, if drivers set the modifier list correctly. Which is th

[Intel-gfx] [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-13 Thread Daniel Vetter
It's very confusing for userspace to have to deal with inconsistencies here, and some drivers screwed this up a bit. Most just ommitted the format list when they meant to say that only linear modifier is allowed, but some also meant that only implied modifiers are acceptable (because actually none

[Intel-gfx] [PATCH 2/3] drm/vgem: use shmem helpers

2021-04-13 Thread Daniel Vetter
Aside from deleting lots of code the real motivation here is to switch the mmap over to VM_PFNMAP, to be more consistent with what real gpu drivers do. They're all VM_PFNMP, which means get_user_pages doesn't work, and even if you try and there's a struct page behind that, touching it and mucking a

[Intel-gfx] [PATCH 03/12] drm/exynos: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Daniel Vetter
Since commit 890880ddfdbe256083170866e49c87618b706ac7 Author: Paul Kocialkowski Date: Fri Jan 4 09:56:10 2019 +0100 drm: Auto-set allow_fb_modifiers when given modifiers at plane init this is done automatically as part of plane init, if drivers set the modifier list correctly. Which is th

[Intel-gfx] [PATCH 08/12] drm/nouveau: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Daniel Vetter
Since commit 890880ddfdbe256083170866e49c87618b706ac7 Author: Paul Kocialkowski Date: Fri Jan 4 09:56:10 2019 +0100 drm: Auto-set allow_fb_modifiers when given modifiers at plane init this is done automatically as part of plane init, if drivers set the modifier list correctly. Which is th

[Intel-gfx] [PATCH 06/12] drm/msm/dpu1: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Daniel Vetter
Since commit 890880ddfdbe256083170866e49c87618b706ac7 Author: Paul Kocialkowski Date: Fri Jan 4 09:56:10 2019 +0100 drm: Auto-set allow_fb_modifiers when given modifiers at plane init this is done automatically as part of plane init, if drivers set the modifier list correctly. Which is th

[Intel-gfx] [PATCH 10/12] drm/tegra: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Daniel Vetter
Since commit 890880ddfdbe256083170866e49c87618b706ac7 Author: Paul Kocialkowski Date: Fri Jan 4 09:56:10 2019 +0100 drm: Auto-set allow_fb_modifiers when given modifiers at plane init this is done automatically as part of plane init, if drivers set the modifier list correctly. Which is th

[Intel-gfx] [PATCH 1/3] dma-buf: Require VM_PFNMAP vma for mmap

2021-04-13 Thread Daniel Vetter
tldr; DMA buffers aren't normal memory, expecting that you can use them like that (like calling get_user_pages works, or that they're accounting like any other normal memory) cannot be guaranteed. Since some userspace only runs on integrated devices, where all buffers are actually all resident sys

[Intel-gfx] [PATCH 3/3] drm/shmem-helper: Align to page size in dumb_create

2021-04-13 Thread Daniel Vetter
shmem helpers seem a bit sloppy here by automatically rounding up when actually creating the buffer, which results in under-reporting of what we actually have. Caught by igt/vgem_basic tests. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_gem_shmem_helper.c | 4 ++-- 1 file changed, 2 inse

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gvt: remove useless function

2021-04-13 Thread Patchwork
== Series Details == Series: drm/i915/gvt: remove useless function URL : https://patchwork.freedesktop.org/series/88996/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' no

Re: [Intel-gfx] [PATCH v2 00/12] drm/i915: Extend GEN renames to the rest of the driver

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Lucas De Marchi wrote: > Like was done for the display part that parted ways with INTEL_GEN(), > replacing with DISPLAY_VER(), do a similar conversion for the rest of > the driver. > > v1.1: Remove .ko that was incorrectly added as part of patch 11, making it > very big and no

Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-13 Thread Daniel Vetter
On Tue, Apr 13, 2021 at 11:29 AM Matthew Auld wrote: > > On Mon, 12 Apr 2021 at 18:01, Daniel Vetter wrote: > > > > On Mon, Apr 12, 2021 at 6:08 PM Matthew Auld > > wrote: > > > > > > On Mon, 12 Apr 2021 at 16:17, Daniel Vetter wrote: > > > > > > > > On Mon, Apr 12, 2021 at 10:05:25AM +0100, Ma

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: remove useless function

2021-04-13 Thread Patchwork
== Series Details == Series: drm/i915/gvt: remove useless function URL : https://patchwork.freedesktop.org/series/88996/ State : success == Summary == CI Bug Log - changes from CI_DRM_9963 -> Patchwork_19920 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 3/3] drm/shmem-helper: Align to page size in dumb_create

2021-04-13 Thread Thomas Zimmermann
Hi Am 13.04.21 um 11:49 schrieb Daniel Vetter: shmem helpers seem a bit sloppy here by automatically rounding up when actually creating the buffer, which results in under-reporting of what we actually have. Caught by igt/vgem_basic tests. Signed-off-by: Daniel Vetter Drivers get it more wron

Re: [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions

2021-04-13 Thread Jani Nikula
On Mon, 12 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Fix a couple of regressions due to the glk display version 9->10 > change. I *think* all the ones that slipped through involved > either DISPLAY_VER==9 or DISPLAY_VER<10 checks. These three > regressions are the ones I found thro

Re: [Intel-gfx] [PATCH 10/12] drm/tegra: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Thierry Reding
On Tue, Apr 13, 2021 at 11:49:01AM +0200, Daniel Vetter wrote: > Since > > commit 890880ddfdbe256083170866e49c87618b706ac7 > Author: Paul Kocialkowski > Date: Fri Jan 4 09:56:10 2019 +0100 > > drm: Auto-set allow_fb_modifiers when given modifiers at plane init > > this is done automatical

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Fix "mitigations" parsing if i915 is builtin URL : https://patchwork.freedesktop.org/series/88998/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter

[Intel-gfx] [RFC PATCH v2] drm/doc/rfc: i915 DG1 uAPI

2021-04-13 Thread Matthew Auld
Add an entry for the new uAPI needed for DG1. v2(Daniel): - include the overall upstreaming plan - add a note for mmap, there are differences here for TTM vs i915 - bunch of other suggestions from Daniel Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Daniel Vetter Cc: Dave Airlie -

Re: [Intel-gfx] [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Lucas Stach
Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > Since > > commit 890880ddfdbe256083170866e49c87618b706ac7 > Author: Paul Kocialkowski > Date: Fri Jan 4 09:56:10 2019 +0100 > > drm: Auto-set allow_fb_modifiers when given modifiers at plane init > > this is done automati

Re: [Intel-gfx] [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-13 Thread Lucas Stach
Am Dienstag, dem 13.04.2021 um 11:49 +0200 schrieb Daniel Vetter: > It's very confusing for userspace to have to deal with inconsistencies > here, and some drivers screwed this up a bit. Most just ommitted the > format list when they meant to say that only linear modifier is > allowed, but some als

Re: [Intel-gfx] [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-13 Thread Pekka Paalanen
On Tue, 13 Apr 2021 11:49:03 +0200 Daniel Vetter wrote: > It's very confusing for userspace to have to deal with inconsistencies > here, and some drivers screwed this up a bit. Most just ommitted the > format list when they meant to say that only linear modifier is > allowed, but some also meant

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gvt: remove useless function

2021-04-13 Thread Patchwork
== Series Details == Series: drm/i915/gvt: remove useless function URL : https://patchwork.freedesktop.org/series/88996/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9963_full -> Patchwork_19920_full Summary --- **F

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Fix "mitigations" parsing if i915 is builtin URL : https://patchwork.freedesktop.org/series/88998/ State : success == Summary == CI Bug Log - changes from CI_DRM_9963 -> Patchwork_19921 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/12] drm/arm: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Patchwork
== Series Details == Series: series starting with [01/12] drm/arm: Don't set allow_fb_modifiers explicitly URL : https://patchwork.freedesktop.org/series/88999/ State : warning == Summary == $ dim checkpatch origin/drm-tip 95d1b78648fe drm/arm: Don't set allow_fb_modifiers explicitly -:8: ERR

[Intel-gfx] [PATCH v2 4/5] drm/connector: Add a helper to attach the colorspace property

2021-04-13 Thread Maxime Ripard
The intel driver uses the same logic to attach the Colorspace property in multiple places and we'll need it in vc4 too. Let's move that common code in a helper. Signed-off-by: Maxime Ripard --- Changes from v1: - New patch --- drivers/gpu/drm/drm_connector.c | 20 ++

[Intel-gfx] [PATCH v2 5/5] drm/vc4: hdmi: Signal the proper colorimetry info in the infoframe

2021-04-13 Thread Maxime Ripard
Our driver while supporting HDR didn't send the proper colorimetry info in the AVI infoframe. Let's add the property needed so that the userspace can let us know what the colorspace is supposed to be. Signed-off-by: Maxime Ripard --- Changes from v1: - New patch --- drivers/gpu/drm/vc4/vc4_

[Intel-gfx] [PATCH v2 2/5] drm/connector: Add helper to compare HDR metadata

2021-04-13 Thread Maxime Ripard
All the drivers that support the HDR metadata property have a similar function to compare the metadata from one connector state to the next, and force a mode change if they differ. All these functions run pretty much the same code, so let's turn it into an helper that can be shared across those dr

[Intel-gfx] [PATCH v2 1/5] drm/connector: Create a helper to attach the hdr_output_metadata property

2021-04-13 Thread Maxime Ripard
All the drivers that implement HDR output call pretty much the same function to initialise the hdr_output_metadata property, and while the creation of that property is in a helper, every driver uses the same code to attach it. Provide a helper for it as well Reviewed-by: Harry Wentland Reviewed-

[Intel-gfx] [PATCH v2 3/5] drm/vc4: Add HDR metadata property to the VC5 HDMI connectors

2021-04-13 Thread Maxime Ripard
From: Dave Stevenson Now that we can export deeper colour depths, add in the signalling for HDR metadata. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- Changes from v1: - Rebased on latest drm-misc-next tag --- drivers/gpu/drm/vc4/vc4_hdmi.c | 53 +

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [01/12] drm/arm: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Patchwork
== Series Details == Series: series starting with [01/12] drm/arm: Don't set allow_fb_modifiers explicitly URL : https://patchwork.freedesktop.org/series/88999/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warni

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/12] drm/arm: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Patchwork
== Series Details == Series: series starting with [01/12] drm/arm: Don't set allow_fb_modifiers explicitly URL : https://patchwork.freedesktop.org/series/88999/ State : success == Summary == CI Bug Log - changes from CI_DRM_9963 -> Patchwork_19922 =

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] dma-buf: Require VM_PFNMAP vma for mmap

2021-04-13 Thread Patchwork
== Series Details == Series: series starting with [1/3] dma-buf: Require VM_PFNMAP vma for mmap URL : https://patchwork.freedesktop.org/series/89003/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8ed494629919 dma-buf: Require VM_PFNMAP vma for mmap -:34: WARNING:TYPO_SPELLING:

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/3] dma-buf: Require VM_PFNMAP vma for mmap

2021-04-13 Thread Patchwork
== Series Details == Series: series starting with [1/3] dma-buf: Require VM_PFNMAP vma for mmap URL : https://patchwork.freedesktop.org/series/89003/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] dma-buf: Require VM_PFNMAP vma for mmap

2021-04-13 Thread Patchwork
== Series Details == Series: series starting with [1/3] dma-buf: Require VM_PFNMAP vma for mmap URL : https://patchwork.freedesktop.org/series/89003/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9963 -> Patchwork_19923 Sum

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/doc/rfc: i915 DG1 uAPI (rev2)

2021-04-13 Thread Patchwork
== Series Details == Series: drm/doc/rfc: i915 DG1 uAPI (rev2) URL : https://patchwork.freedesktop.org/series/88958/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8258e1583be6 drm/doc/rfc: i915 DG1 uAPI -:19: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAI

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/doc/rfc: i915 DG1 uAPI (rev2)

2021-04-13 Thread Patchwork
== Series Details == Series: drm/doc/rfc: i915 DG1 uAPI (rev2) URL : https://patchwork.freedesktop.org/series/88958/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not de

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v2,1/5] drm/connector: Create a helper to attach the hdr_output_metadata property

2021-04-13 Thread Patchwork
== Series Details == Series: series starting with [v2,1/5] drm/connector: Create a helper to attach the hdr_output_metadata property URL : https://patchwork.freedesktop.org/series/89008/ State : failure == Summary == Applying: drm/connector: Create a helper to attach the hdr_output_metadata

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/doc/rfc: i915 DG1 uAPI (rev2)

2021-04-13 Thread Patchwork
== Series Details == Series: drm/doc/rfc: i915 DG1 uAPI (rev2) URL : https://patchwork.freedesktop.org/series/88958/ State : success == Summary == CI Bug Log - changes from CI_DRM_9963 -> Patchwork_19924 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Fix "mitigations" parsing if i915 is builtin URL : https://patchwork.freedesktop.org/series/88998/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9963_full -> Patchwork_19921_full Summa

Re: [Intel-gfx] [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Daniel Vetter
On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > Since > > > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > Author: Paul Kocialkowski > > Date: Fri Jan 4 09:56:10 2019 +0100 > > > > drm: Auto-set all

Re: [Intel-gfx] [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-13 Thread Daniel Vetter
On Tue, Apr 13, 2021 at 02:56:02PM +0300, Pekka Paalanen wrote: > On Tue, 13 Apr 2021 11:49:03 +0200 > Daniel Vetter wrote: > > > It's very confusing for userspace to have to deal with inconsistencies > > here, and some drivers screwed this up a bit. Most just ommitted the > > format list when th

Re: [Intel-gfx] [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Lucas Stach
Am Dienstag, dem 13.04.2021 um 16:04 +0200 schrieb Daniel Vetter: > On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > > Since > > > > > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > > Author: Paul Kocialko

Re: [Intel-gfx] [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-13 Thread Daniel Vetter
On Tue, Apr 13, 2021 at 01:54:00PM +0200, Lucas Stach wrote: > Am Dienstag, dem 13.04.2021 um 11:49 +0200 schrieb Daniel Vetter: > > It's very confusing for userspace to have to deal with inconsistencies > > here, and some drivers screwed this up a bit. Most just ommitted the > > format list when t

Re: [Intel-gfx] [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-13 Thread Daniel Vetter
On Tue, Apr 13, 2021 at 04:11:29PM +0200, Daniel Vetter wrote: > On Tue, Apr 13, 2021 at 02:56:02PM +0300, Pekka Paalanen wrote: > > On Tue, 13 Apr 2021 11:49:03 +0200 > > Daniel Vetter wrote: > > > > > It's very confusing for userspace to have to deal with inconsistencies > > > here, and some dr

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/12] drm/arm: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Patchwork
== Series Details == Series: series starting with [01/12] drm/arm: Don't set allow_fb_modifiers explicitly URL : https://patchwork.freedesktop.org/series/88999/ State : success == Summary == CI Bug Log - changes from CI_DRM_9963_full -> Patchwork_19922_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/doc/rfc: i915 DG1 uAPI (rev2)

2021-04-13 Thread Patchwork
== Series Details == Series: drm/doc/rfc: i915 DG1 uAPI (rev2) URL : https://patchwork.freedesktop.org/series/88958/ State : success == Summary == CI Bug Log - changes from CI_DRM_9963_full -> Patchwork_19924_full Summary --- **SUCCE

Re: [Intel-gfx] [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-13 Thread Simon Ser
On Tuesday, April 13th, 2021 at 11:49 AM, Daniel Vetter wrote: > + * Note that userspace can check the DRM_CAP_ADDFB2_MODIFIERS driver Prepend an ampersand like so and a hyperlink will be rendered: Note that userspace can check the &DRM_CAP_ADDFB2_MODIFIERS driver _

Re: [Intel-gfx] [PATCH 3/3] drm/i915/display: remove strap checks from gen 9

2021-04-13 Thread Ville Syrjälä
On Mon, Apr 12, 2021 at 11:09:27PM -0700, Lucas De Marchi wrote: > Direction on gen9+ was to stop reading the straps and only rely on the > VBT for marking the port presence. This happened while dealing with > WaIgnoreDDIAStrap and instead of using it as a WA, it should now be the > normal flow. Se

Re: [Intel-gfx] [PATCH] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-13 Thread Ville Syrjälä
On Tue, Apr 13, 2021 at 05:02:40PM +0800, Jisheng Zhang wrote: > I met below error during boot with i915 builtin if pass > "i915.mitigations=off": > [0.015589] Booting kernel: `off' invalid for parameter `i915.mitigations' > > The reason is slab subsystem isn't ready at that time, so kstrdup()

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix modesetting in case of unexpected AUX timeouts

2021-04-13 Thread Ville Syrjälä
On Tue, Apr 13, 2021 at 02:24:12AM +0300, Imre Deak wrote: > In case AUX failures happen unexpectedly during a modeset, the driver > should still complete the modeset. In particular the driver should > perform the link training sequence steps even in case of an AUX failure, > as this sequence also

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Drop redundant address-of op before lttpr_common_caps array

2021-04-13 Thread Ville Syrjälä
On Tue, Apr 13, 2021 at 02:24:13AM +0300, Imre Deak wrote: > The addres-of op in front of an array is just an alias to using the > array on its own, so drop the op. > > Signed-off-by: Imre Deak Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +- >

Re: [Intel-gfx] [PATCH 3/3] drm/i915/display: remove strap checks from gen 9

2021-04-13 Thread Lucas De Marchi
On Tue, Apr 13, 2021 at 06:45:16PM +0300, Ville Syrjälä wrote: On Mon, Apr 12, 2021 at 11:09:27PM -0700, Lucas De Marchi wrote: Direction on gen9+ was to stop reading the straps and only rely on the VBT for marking the port presence. This happened while dealing with WaIgnoreDDIAStrap and instead

[Intel-gfx] [PATCH] drm/i915/pm: Make the wm parameter of print_wm_latency a pointer

2021-04-13 Thread Jason Ekstrand
This fixes the following build error with GCC 11: In function ‘snb_wm_latency_quirk’, inlined from ‘ilk_setup_wm_latency’ at drivers/gpu/drm/i915/intel_pm.c:3109:3, inlined from ‘intel_init_pm’ at drivers/gpu/drm/i915/intel_pm.c:7695:3: drivers/gpu/drm/i915/intel_pm.c:3058

Re: [Intel-gfx] [PATCH 3/3] drm/i915/display: remove strap checks from gen 9

2021-04-13 Thread Ville Syrjälä
On Tue, Apr 13, 2021 at 10:22:24AM -0700, Lucas De Marchi wrote: > On Tue, Apr 13, 2021 at 06:45:16PM +0300, Ville Syrjälä wrote: > >On Mon, Apr 12, 2021 at 11:09:27PM -0700, Lucas De Marchi wrote: > >> Direction on gen9+ was to stop reading the straps and only rely on the > >> VBT for marking the

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pm: Make the wm parameter of print_wm_latency a pointer

2021-04-13 Thread Patchwork
== Series Details == Series: drm/i915/pm: Make the wm parameter of print_wm_latency a pointer URL : https://patchwork.freedesktop.org/series/89022/ State : warning == Summary == $ dim checkpatch origin/drm-tip 03e2f5a6dc70 drm/i915/pm: Make the wm parameter of print_wm_latency a pointer -:13:

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/pm: Make the wm parameter of print_wm_latency a pointer

2021-04-13 Thread Patchwork
== Series Details == Series: drm/i915/pm: Make the wm parameter of print_wm_latency a pointer URL : https://patchwork.freedesktop.org/series/89022/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function p

Re: [Intel-gfx] [PATCH 3/3] drm/i915/display: remove strap checks from gen 9

2021-04-13 Thread Lucas De Marchi
On Tue, Apr 13, 2021 at 08:39:07PM +0300, Ville Syrjälä wrote: On Tue, Apr 13, 2021 at 10:22:24AM -0700, Lucas De Marchi wrote: On Tue, Apr 13, 2021 at 06:45:16PM +0300, Ville Syrjälä wrote: >On Mon, Apr 12, 2021 at 11:09:27PM -0700, Lucas De Marchi wrote: >> Direction on gen9+ was to stop readi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pm: Make the wm parameter of print_wm_latency a pointer

2021-04-13 Thread Patchwork
== Series Details == Series: drm/i915/pm: Make the wm parameter of print_wm_latency a pointer URL : https://patchwork.freedesktop.org/series/89022/ State : success == Summary == CI Bug Log - changes from CI_DRM_9963 -> Patchwork_19926 Summa

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pm: Make the wm parameter of print_wm_latency a pointer

2021-04-13 Thread Patchwork
== Series Details == Series: drm/i915/pm: Make the wm parameter of print_wm_latency a pointer URL : https://patchwork.freedesktop.org/series/89022/ State : success == Summary == CI Bug Log - changes from CI_DRM_9963_full -> Patchwork_19926_full =

Re: [Intel-gfx] [PATCH] drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake

2021-04-13 Thread Souza, Jose
On Thu, 2021-04-01 at 20:05 +0300, Gwan-gyeong Mun wrote: > As per b.spec 49274, the IO buffer Wake lines and Fast Wake lines can be > calculated based on the following formula. > >  IO buffer wake lines = ROUNDUP(PSR2 IO wake time / total line time in > microseconds) >  Fast wake lines = ROUNDUP

[Intel-gfx] [PATCH v2 1/1] drm/i915/dg1: Add HWMON power sensor support

2021-04-13 Thread Dale B Stimson
As part of the System Managemenent Interface (SMI), use the HWMON subsystem to display power utilization. The following standard HWMON power sensors are currently supported (and appropriately scaled): /sys/class/drm/card0/device/hwmon/hwmon - energy1_input - power1_cap -

[Intel-gfx] [PATCH v1 0/1] drm/i915/dg1: Add HWMON power sensor support

2021-04-13 Thread Dale B Stimson
As part of the System Managemenent Interface (SMI), use the HWMON subsystem to display power utilization. The following standard HWMON power sensors are currently supported (and appropriately scaled): /sys/class/drm/card0/device/hwmon/hwmon - energy1_input - power1_cap -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg1: Add HWMON power sensor support (rev2)

2021-04-13 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Add HWMON power sensor support (rev2) URL : https://patchwork.freedesktop.org/series/88459/ State : warning == Summary == $ dim checkpatch origin/drm-tip fd48aa4fd9a8 drm/i915/dg1: Add HWMON power sensor support -:104: WARNING:FILE_PATH_CHANGES: added

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dg1: Add HWMON power sensor support (rev2)

2021-04-13 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Add HWMON power sensor support (rev2) URL : https://patchwork.freedesktop.org/series/88459/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg1: Add HWMON power sensor support (rev2)

2021-04-13 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Add HWMON power sensor support (rev2) URL : https://patchwork.freedesktop.org/series/88459/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9964 -> Patchwork_19927 Summary ---

[Intel-gfx] [PATCH 1/8] drm/i915: Add frontbuffer tracking tracepoints

2021-04-13 Thread Ville Syrjala
From: Ville Syrjälä Add some tracpoints for frontbuffer tracking so we can try to figure out what's going on. Signed-off-by: Ville Syrjälä --- .../gpu/drm/i915/display/intel_frontbuffer.c | 5 +++ drivers/gpu/drm/i915/i915_trace.h | 38 +++ 2 files changed, 43 ins

[Intel-gfx] [PATCH 0/8] drm/i915: FBC cleanups

2021-04-13 Thread Ville Syrjala
From: Ville Syrjälä The FBC code is a bit of mess. Start cleaning it up a bit. The main thing here is throwing out tons of redundant state from the fbc_state_cache and just checkng that stuff ahead of time from the plane/crtc states. Ville Syrjälä (8): drm/i915: Add frontbuffer tracking tracep

[Intel-gfx] [PATCH 2/8] drm/i915: Rewrite the FBC tiling check a bit

2021-04-13 Thread Ville Syrjala
From: Ville Syrjälä Write the tiling check in a nicer form. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c i

[Intel-gfx] [PATCH 3/8] drm/i915: Extract intel_fbc_update()

2021-04-13 Thread Ville Syrjala
From: Ville Syrjälä Pull the fbc enable vs. disable stuff into a small helper so we don't have to have it pollute the higher level modeset code. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 5 +--- drivers/gpu/drm/i915/display/intel_fbc.c | 26 ++

[Intel-gfx] [PATCH 4/8] drm/i915: Clear no_fbc_reason on activate

2021-04-13 Thread Ville Syrjala
From: Ville Syrjälä We try to set no_fbc_reason when FBC is not possible, let's consistently clear when activating FBC. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH 5/8] drm/i915: Move the "recompress on activate" to a central place

2021-04-13 Thread Ville Syrjala
From: Ville Syrjälä On ILK+ we current do a nuke right after activating FBC. If my memory isn't playing tricks on me this is actially required if FBC didn't stay disabled for a full frame. In that case the deactivate+reactivate may not invalidate the cfb. I'd have to double chekc to be sure thoug

  1   2   >