Re: [Intel-gfx] [PATCH 1/8] drm/i915: Add frontbuffer tracking tracepoints

2021-04-21 Thread Jani Nikula
On Wed, 14 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Add some tracpoints for frontbuffer tracking so we can > try to figure out what's going on. > > Signed-off-by: Ville Syrjälä Acked-by: Jani Nikula > --- > .../gpu/drm/i915/display/intel_frontbuffer.c | 5 +++ >

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Rewrite the FBC tiling check a bit

2021-04-21 Thread Jani Nikula
On Thu, 15 Apr 2021, Ville Syrjälä wrote: > On Wed, Apr 14, 2021 at 06:09:23PM +0300, Jani Nikula wrote: >> On Wed, 14 Apr 2021, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > Write the tiling check in a nicer form. >> > >> > Signed-off-by: Ville Syrjälä >> > --- >> >

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Extract intel_fbc_update()

2021-04-21 Thread Jani Nikula
On Wed, 14 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Pull the fbc enable vs. disable stuff into a small helper so > we don't have to have it pollute the higher level modeset code. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

[Intel-gfx] [PATCH] drm/i915: Simplify CCS and UV plane alignment handling

2021-04-21 Thread Imre Deak
We can handle the surface alignment of CCS and UV color planes for all modifiers at one place, so do this. An AUX color plane can be a CCS or a UV plane, use only the more specific query functions and remove is_aux_plane() becoming redundant. Signed-off-by: Imre Deak ---

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path.

2021-04-21 Thread Jani Nikula
On Wed, 21 Apr 2021, Rodrigo Vivi wrote: > Although this abstraction removes the convenience of grepping > for the file name, it: > - makes addition easier. > - makes it easier to tweak global path when experiments are needed. > - get in sync with guc/huc, without getting overly abstracted. > -

Re: [Intel-gfx] [PATCH 00/11] drm/i915/adl_p: Add support for Display Page Tables

2021-04-21 Thread Jani Nikula
On Wed, 21 Apr 2021, Imre Deak wrote: > On Wed, Apr 21, 2021 at 02:03:45PM +0300, Jani Nikula wrote: >> On Thu, 15 Apr 2021, Jani Nikula wrote: >> > On Wed, 14 Apr 2021, Imre Deak wrote: >> >> Alder Lake-P adds a new Display Page Table hardware structure, mapping >> >> tiled framebuffer pages

[Intel-gfx] [PATCH] drm/i915: Fix docbook descriptions for i915_gem_shrinker

2021-04-21 Thread Maarten Lankhorst
Fixes the following htmldocs warning: drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink' Fixes: cf41a8f1dc1e ("drm/i915: Finally remove obj->mm.lock.") Reported-by: Stephen Rothwell Signed-off-by: Maarten Lankhorst

[Intel-gfx] [PATCH] drm/i915: Fix docbook descriptions for i915_cmd_parser

2021-04-21 Thread Maarten Lankhorst
Fixes the following htmldocs warnings: drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove asynchronous vma binding

2021-04-21 Thread Daniel Vetter
On Tue, Apr 20, 2021 at 12:34:50PM +0200, Maarten Lankhorst wrote: > Commit e3793468b466 ("drm/i915: Use the async worker to avoid reclaim > tainting the ggtt->mutex") moves the vma binding to dma_fence_work, > but dma_fence_work has has signalling fence semantics. > > On braswell, we can call

Re: [Intel-gfx] [PATCH 11/19] drm/i915: Update the helper to set correct mapping

2021-04-21 Thread Matthew Auld
On 19/04/2021 16:01, Tvrtko Ursulin wrote: On 19/04/2021 15:37, Matthew Auld wrote: On 19/04/2021 15:07, Tvrtko Ursulin wrote: On 19/04/2021 12:30, Matthew Auld wrote: On 15/04/2021 12:05, Tvrtko Ursulin wrote: On 15/04/2021 10:23, Matthew Auld wrote: On Thu, 15 Apr 2021 at 09:21, Tvrtko

Re: [Intel-gfx] [PATCH 00/11] drm/i915/adl_p: Add support for Display Page Tables

2021-04-21 Thread Imre Deak
On Wed, Apr 21, 2021 at 02:03:45PM +0300, Jani Nikula wrote: > On Thu, 15 Apr 2021, Jani Nikula wrote: > > On Wed, 14 Apr 2021, Imre Deak wrote: > >> Alder Lake-P adds a new Display Page Table hardware structure, mapping > >> tiled framebuffer pages to the display engine, reducing the address >

Re: [Intel-gfx] [PATCH 00/11] drm/i915/adl_p: Add support for Display Page Tables

2021-04-21 Thread Jani Nikula
On Thu, 15 Apr 2021, Jani Nikula wrote: > On Wed, 14 Apr 2021, Imre Deak wrote: >> Alder Lake-P adds a new Display Page Table hardware structure, mapping >> tiled framebuffer pages to the display engine, reducing the address >> space required in GGTT for these framebuffers. >> >> This patchset

Re: [Intel-gfx] [PATCH v2 00/50] Introduce Alder Lake-P

2021-04-21 Thread Jani Nikula
On Thu, 25 Mar 2021, Matt Roper wrote: > The previous version of this series was here: > > https://lists.freedesktop.org/archives/intel-gfx/2021-March/262168.html > > The preparation patches that convert display/ to use DISPLAY_VER() > instead of INTEL_GEN() have landed on drm-tip now,

Re: [Intel-gfx] [PULL] gvt-next-fixes

2021-04-21 Thread Jani Nikula
On Wed, 21 Apr 2021, Zhenyu Wang wrote: > Hi, > > Here're queued gvt-next-fixes changes. Two ones are for code cleanup > on unused function or duplicated function call, with another one for > consistent function return type. Thanks, pulled to drm-intel-next-fixes. BR, Jani. > > Thanks. > -- >

[Intel-gfx] [PATCH v2 4/4] drm/i915/stolen: actually mark as contiguous

2021-04-21 Thread Matthew Auld
Stolen memory is always allocated as physically contiguous pages, so mark the object flags as such. It looks like the flags were previously just ignored so this had no effect. In the future we might to add the proper plumbing for passing the flags all over the way down from the caller, but for now

[Intel-gfx] [PATCH v2 3/4] drm/i915/stolen: enforce the min_page_size contract

2021-04-21 Thread Matthew Auld
From: CQ Tang Since stolen can now be device local-memory underneath, we should try to enforce any min_page_size restrictions when allocating pages. Signed-off-by: CQ Tang Signed-off-by: Matthew Auld Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 7 --- 1

[Intel-gfx] [PATCH v2 1/4] drm/i915: Create stolen memory region from local memory

2021-04-21 Thread Matthew Auld
From: CQ Tang Add "REGION_STOLEN" device info to dg1, create stolen memory region from upper portion of local device memory, starting from DSMBASE. v2: - s/drm_info/drm_dbg; userspace likely doesn't care about stolen. - mem->type is only setup after the region probe, so setting the name

[Intel-gfx] [PATCH v2 2/4] drm/i915/stolen: treat stolen local as normal local memory

2021-04-21 Thread Matthew Auld
Underneath it's the same stuff, so things like the PTE_LM bits for the GTT should just keep working as-is. Signed-off-by: Matthew Auld Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PULL] gvt-next-fixes

2021-04-21 Thread Zhenyu Wang
Hi, Here're queued gvt-next-fixes changes. Two ones are for code cleanup on unused function or duplicated function call, with another one for consistent function return type. Thanks. -- The following changes since commit d153e8c156dafeb847fd655f416cf81c007e8706: Merge tag

Re: [Intel-gfx] [PATCH 4/5] drm/i915/stolen: pass the allocation flags

2021-04-21 Thread Matthew Auld
On 20/04/2021 17:14, Tvrtko Ursulin wrote: On 20/04/2021 14:18, Matthew Auld wrote: From: CQ Tang Stolen memory is always allocated as physically contiguous pages, mark the object flags as such. v2: move setting I915_BO_ALLOC_CONTIGUOUS into create_stolen Signed-off-by: CQ Tang

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Create stolen memory region from local memory

2021-04-21 Thread Matthew Auld
On 20/04/2021 17:06, Tvrtko Ursulin wrote: On 20/04/2021 14:18, Matthew Auld wrote: From: CQ Tang Add "REGION_STOLEN" device info to dg1, create stolen memory region from upper portion of local device memory, starting from DSMBASE. v2: - s/drm_info/drm_dbg; userspace likely doesn't

[Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path.

2021-04-21 Thread Rodrigo Vivi
Although this abstraction removes the convenience of grepping for the file name, it: - makes addition easier. - makes it easier to tweak global path when experiments are needed. - get in sync with guc/huc, without getting overly abstracted. - allows future junction with CSR_VERSION for simplicity.

Re: [Intel-gfx] [PATCH] drm/i915: set min brightness for aux backlight interface.

2021-04-21 Thread Jani Nikula
On Mon, 19 Apr 2021, Lee Shawn C wrote: > Min brightness level for aux backlight interface is always zero. > Driver should refer to VBT's setting to configure proper minimum > level just like PWM backlight interface. Unfortunately this change makes it harder for Lyude to extract the dpcd

Re: [Intel-gfx] [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-21 Thread Tvrtko Ursulin
On 20/04/2021 18:00, Jason Ekstrand wrote: On Tue, Apr 20, 2021 at 11:34 AM Tvrtko Ursulin wrote: On 19/04/2021 16:19, Jason Ekstrand wrote: On Mon, Apr 19, 2021 at 7:02 AM Matthew Auld wrote: On 16/04/2021 17:38, Jason Ekstrand wrote: On Thu, Apr 15, 2021 at 11:04 AM Matthew Auld

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Rename pm_ prefixed functions names

2021-04-21 Thread Jani Nikula
On Tue, 20 Apr 2021, Rodrigo Vivi wrote: > On Tue, Apr 20, 2021 at 05:41:47PM +0300, Jani Nikula wrote: >> On Tue, 20 Apr 2021, Rodrigo Vivi wrote: >> > On Tue, Apr 20, 2021 at 04:08:53PM +0300, Jani Nikula wrote: >> >> From: Hsin-Yi Wang >> >> >> >> pm_resume and pm_suspend might be conflict

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp: Use slow and wide link training for everything

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915/dp: Use slow and wide link training for everything URL : https://patchwork.freedesktop.org/series/89283/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9989_full -> Patchwork_19958_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Use slow and wide link training for everything

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915/dp: Use slow and wide link training for everything URL : https://patchwork.freedesktop.org/series/89283/ State : success == Summary == CI Bug Log - changes from CI_DRM_9989 -> Patchwork_19958 Summary

<    1   2