Re: [Intel-gfx] [PATCH] drm/i915: Include intel_de_{read, write}_fw() in i915_reg_rw traces

2021-04-29 Thread Gupta, Anshuman
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Thursday, April 29, 2021 8:06 AM > To: intel-gfx@lists.freedesktop.org > Cc: Chiou, Cooper > Subject: [Intel-gfx] [PATCH] drm/i915: Include intel_de_{read, write}_fw() in > i915_reg_rw traces > > From: Ville Sy

Re: [Intel-gfx] [PATCH 09/21] drm/i915/gem: Disallow creating contexts with too many engines

2021-04-29 Thread Tvrtko Ursulin
On 28/04/2021 18:09, Jason Ekstrand wrote: On Wed, Apr 28, 2021 at 9:26 AM Tvrtko Ursulin wrote: On 28/04/2021 15:02, Daniel Vetter wrote: On Wed, Apr 28, 2021 at 11:42:31AM +0100, Tvrtko Ursulin wrote: On 28/04/2021 11:16, Daniel Vetter wrote: On Fri, Apr 23, 2021 at 05:31:19PM -0500, Ja

Re: [Intel-gfx] [PATCH 03/21] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem

2021-04-29 Thread Tvrtko Ursulin
On 28/04/2021 18:24, Jason Ekstrand wrote: On Wed, Apr 28, 2021 at 10:55 AM Tvrtko Ursulin wrote: On 23/04/2021 23:31, Jason Ekstrand wrote: Instead of handling it like a context param, unconditionally set it when intel_contexts are created. This doesn't fix anything but does simplify the c

Re: [Intel-gfx] [PATCH 06/21] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v3)

2021-04-29 Thread Tvrtko Ursulin
On 28/04/2021 18:26, Jason Ekstrand wrote: On Wed, Apr 28, 2021 at 10:49 AM Tvrtko Ursulin wrote: On 23/04/2021 23:31, Jason Ekstrand wrote: This API is entirely unnecessary and I'd love to get rid of it. If userspace wants a single timeline across multiple contexts, they can either use i

Re: [Intel-gfx] [PATCH] drm/i915: Include intel_de_{read, write}_fw() in i915_reg_rw traces

2021-04-29 Thread Jani Nikula
On Thu, 29 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > We lost the i915_reg_rw tracepoint for a lot of display registers > when we switched from the heavyweight normal register accessors to > the lightweight _fw() variants. Sorry, which change was that exactly? > Put the tracepoint

Re: [Intel-gfx] BUG in i915/i915_pci.c, commit fe0f1e3

2021-04-29 Thread Jani Nikula
On Wed, 28 Apr 2021, Mario Hüttel wrote: > Hi, > > yes. The bug is still present with a recent kernel. > I got the tip from Imre Deak to try out > > 7962893ecb853 ("drm/i915: Disable runtime power management during > shutdown") > > This fixes the issue for me. Do I still have to file a bug report

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add relocation exceptions for two other platforms

2021-04-29 Thread Zbigniew Kempczyński
On Wed, Apr 28, 2021 at 07:43:42PM +, Patchwork wrote: >Patch Details > >Series: drm/i915: Add relocation exceptions for two other platforms > >URL: https://patchwork.freedesktop.org/series/89594/ > >State: failure

Re: [Intel-gfx] [PATCH] drm/i915: Fix crash in auto_retire

2021-04-29 Thread Tvrtko Ursulin
On 29/04/2021 04:10, Stéphane Marchesin wrote: The retire logic uses the 2 lower bits of the pointer to the retire function to store flags. However, the auto_retire function is not guaranteed to be aligned to a multiple of 4, which causes crashes as we jump to the wrong address, for example like

Re: [Intel-gfx] [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-29 Thread Lionel Landwerlin
On 29/04/2021 03:34, Umesh Nerlige Ramappa wrote: Perf measurements rely on CPU and engine timestamps to correlate events of interest across these time domains. Current mechanisms get these timestamps separately and the calculated delta between these timestamps lack enough accuracy. To improve t

[Intel-gfx] [PATCH 2/2] drm/i915/selftests: Fix active retire callback alignment

2021-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin __i915_active_call annotation is required on the retire callback to ensure correct function alignment. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c | 2 +- drivers/gpu/drm/i915/selftests/i915_active.c| 2 +- 2 files changed,

[Intel-gfx] [PATCH 1/2] drm/i915/overlay: Fix active retire callback alignment

2021-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin __i915_active_call annotation is required on the retire callback to ensure correct function alignment. Signed-off-by: Tvrtko Ursulin Fixes: a21ce8ad12d2 ("drm/i915/overlay: Switch to using i915_active tracking") Cc: Chris Wilson Cc: Matthew Auld --- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH i-g-t] tests/i915/gem_workarounds: Prepare for read mask

2021-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I plan to extend i915 to expose the read mask in i915_wa_registers so prepare the IGT for that format change. Signed-off-by: Tvrtko Ursulin --- tests/i915/gem_workarounds.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/tests/i915/

[Intel-gfx] [PATCH] drm/i915: Use correct downstream caps for check Src-Ctl mode for PCON

2021-04-29 Thread Ankit Nautiyal
Fix the typo in DPCD caps used for checking SRC CTL mode of HDMI2.1 PCON Fixes: 04b6603d13be (drm/i915/display: Configure HDMI2.1 Pcon for FRL only if Src-Ctl mode is available) Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[Intel-gfx] [PULL] drm-misc-next-fixes

2021-04-29 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-next-fixes PR Maxime drm-misc-next-fixes-2021-04-29: Two patches in drm-misc-next-fixes this week, one to fix the error handling in TTM when a BO can't be swapped out and one to prevent a wrong dereference in efifb. The following changes since commit a4

[Intel-gfx] [PULL] gvt-next-fixes

2021-04-29 Thread Zhenyu Wang
Hi, Here's just another left fix for possible divide error in vgpu display rate calculation by Colin. btw, I'll need a backmerge of linus tree or maybe wait till rc1 to apply gvt mdev dependency fix from https://patchwork.freedesktop.org/series/89479/ Thanks -- The following changes since comm

[Intel-gfx] [PATCH 0/6] Workaround building improvements

2021-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some cleanups and improvements to checks being done when building workaround lists. First five patches are small cleanups while the last one contains the actual story of what gets improved. Test-with: 20210429084130.850426-1-tvrtko.ursu...@linux.intel.com Tvrtko Ursulin (6)

[Intel-gfx] [PATCH 2/6] drm/i915/debugfs: Expose read mask in i915_wa_registers

2021-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In order to stop conflating the validation via readback with the workaround mask I need to expose the read mask separately so gem_workarounds IGT can continue operating correctly. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file change

[Intel-gfx] [PATCH 1/6] drm/i915: Drop duplicate WaDisable4x2SubspanOptimization:hsw

2021-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Same workaround was listed two times - once under the Gen7 block and once under the Haswell section. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_workaround

[Intel-gfx] [PATCH 3/6] drm/i915: Add a separate low-level helper for masked workarounds

2021-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We distinguish masked registers from other workarounds by the mask (clr) being zero for the former. To avoid callers of the low-level wa_add having to know that, and be passing this zero explicitly, add a wa_masked_add low-level helper which embeds this knowledge. Signed-of

[Intel-gfx] [PATCH 4/6] drm/i915/icl: Use appropriate helper for a masked workaround

2021-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Instead of "open coding" WaEnableFloatBlendOptimization:icl via wa_write_clr_set, which should be for non-masked workarounds, add a new helper wa_masked_en_no_verify and use it. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 13 +---

[Intel-gfx] [PATCH 6/6] drm/i915: Add more checks when building workaround lists

2021-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In current code we check that a workaround is not completely overwriting the existing one, but for instance partial conflict in some bits would get missed, as would problems involving masked registers, courtesy of the mask (wa->clr) being forced to zero for such registers and

[Intel-gfx] [PATCH 5/6] drm/i915/icl: Stop conflating mask and readback verify

2021-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add a new helper wa_write_no_verify for Wa_1604278689:icl,ehl which is a write only register. This allows the mask to correctly reflect what bits the workaround writes versus which bits it will verify during read- back. In turn this will allow more safety checks to be added i

Re: [Intel-gfx] [PATCH v2] drm/i915/gem: Remove reference to struct drm_device.pdev

2021-04-29 Thread Jani Nikula
On Tue, 27 Apr 2021, "Ruhl, Michael J" wrote: >>-Original Message- >>From: Thomas Zimmermann >>Sent: Tuesday, April 27, 2021 1:49 PM >>To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, >>Rodrigo >>; airl...@linux.ie; dan...@ffwll.ch; Auld, Matthew >>; Ruhl, Michael

Re: [Intel-gfx] [PULL] drm-misc-next-fixes

2021-04-29 Thread Maxime Ripard
On Wed, Apr 28, 2021 at 04:57:26PM -0400, Alex Deucher wrote: > On Mon, Apr 26, 2021 at 3:35 AM Maxime Ripard wrote: > > > > Hi Alex, > > > > On Thu, Apr 22, 2021 at 12:40:10PM -0400, Alex Deucher wrote: > > > On Thu, Apr 22, 2021 at 12:33 PM Maxime Ripard wrote: > > > > > > > > Hi Dave, Daniel,

[Intel-gfx] [PATCH] drm/i915: Be more gentle with exiting non-persistent context

2021-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When a non-persistent context exits we currently mark it as banned in order to trigger fast termination of any outstanding GPU jobs it may have left running. In doing so we apply a very strict 1ms limit in which the left over job has to preempt before we issues an engine res

[Intel-gfx] [PATCH 0/4] drm/i915: Propagate ww parameter to get_pages().

2021-04-29 Thread Maarten Lankhorst
For TTM eviction we may need to retrieve the ww parameter, to ensure we can lock extra objects while evicting. Pass along the struct i915_gem_ww_ctx, so this can be done. Maarten Lankhorst (4): drm/i915: Add ww parameter to get_pages() callback drm/i915: Add ww context to prepare_(read/write)

[Intel-gfx] [PATCH 2/4] drm/i915: Add ww context to prepare_(read/write)

2021-04-29 Thread Maarten Lankhorst
This will allow us to explicitly pass the ww to pin_pages, when it starts taking it. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/gem/i915_gem_domain.c | 2 ++ drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 7 --- drivers/gpu/drm/i915/gem/i915_gem_object

[Intel-gfx] [PATCH 3/4] drm/i915: Pass ww ctx to pin_map, v2.

2021-04-29 Thread Maarten Lankhorst
This will allow us to explicitly pass the ww to pin_pages, when it starts taking it. This allows us to finally kill off the explicit passing of ww by retrieving it from the obj. Changes since v1: - Rename 'ret' to ptr, fix error handling of return ptr. Signed-off-by: Maarten Lankhorst --- .../

[Intel-gfx] [PATCH 1/4] drm/i915: Add ww parameter to get_pages() callback

2021-04-29 Thread Maarten Lankhorst
We will need this to support eviction with lmem, so explicitly pass ww as a parameter. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 3 ++- drivers/gpu/drm/i915/gem/i915_gem_internal.c | 3 ++- drivers/gpu/drm/i915/gem/i915_gem_object_types.h

[Intel-gfx] [PATCH 4/4] drm/i915: Pass ww ctx to i915_gem_object_pin_pages, v2.

2021-04-29 Thread Maarten Lankhorst
This is the final part of passing ww ctx to the get_pages() callbacks. Now we no longer have to implicitly get ww ctx by using get_ww_ctx. Changes since v1: - Fix error handling in pin_map_unlocked(). Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- dr

[Intel-gfx] [PATCH v2 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-29 Thread Matthew Auld
Add an entry for the new uAPI needed for DG1. Also add the overall upstream plan, including some notes for the TTM conversion. v2(Daniel): - include the overall upstreaming plan - add a note for mmap, there are differences here for TTM vs i915 - bunch of other suggestions from Daniel v3: (D

[Intel-gfx] [PATCH v2 2/9] drm/i915: mark stolen as private

2021-04-29 Thread Matthew Auld
In the next patch we want to expose the supported regions to userspace, which can then be fed into the gem_create_ext placement extensions. For now treat stolen memory as private from userspace pov. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Thomas Hellström Cc: Daniele Ceraolo Spurio

[Intel-gfx] [PATCH v2 3/9] drm/i915/query: Expose memory regions through the query uAPI

2021-04-29 Thread Matthew Auld
From: Abdiel Janulgue Returns the available memory region areas supported by the HW. v2(Daniel & Jason): - Add some kernel-doc, including example usage. - Drop all the extra rsvd v3(Jason & Tvrtko) - add back rsvd Signed-off-by: Abdiel Janulgue Signed-off-by: Matthew Auld Cc: Joon

[Intel-gfx] [PATCH v2 4/9] drm/i915: rework gem_create flow for upcoming extensions

2021-04-29 Thread Matthew Auld
With the upcoming gem_create_ext we want to be able create a "vanilla" object upfront and pass that directly to the extensions, before actually initialising the object. Functionally this should be the same expect we now feed the object into the lower-level region specific init_object. Signed-off-b

[Intel-gfx] [PATCH v2 5/9] drm/i915/uapi: introduce drm_i915_gem_create_ext

2021-04-29 Thread Matthew Auld
Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. v2:(Chris) - Use separate ioctl number for gem_create_ext, instead of hijacking the existing gem_create ioctl, otherwise we run into the issue with being unable to detect

[Intel-gfx] [PATCH v2 6/9] drm/i915/uapi: implement object placement extension

2021-04-29 Thread Matthew Auld
Add new extension to support setting an immutable-priority-list of potential placements, at creation time. If we use the normal gem_create or gem_create_ext without the extensions/placements then we still get the old behaviour with only placing the object in system memory. v2(Daniel & Jason):

[Intel-gfx] [PATCH v2 7/9] drm/i915/lmem: support optional CPU clearing for special internal use

2021-04-29 Thread Matthew Auld
For some internal device local-memory objects it would be useful to have an option to CPU clear the pages upon gathering the backing store. Note that this might be before the blitter is useable, which is the case for some internal GuC objects. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc:

[Intel-gfx] [PATCH v2 8/9] drm/i915/gem: clear userspace buffers for LMEM

2021-04-29 Thread Matthew Auld
All userspace objects must be cleared when allocating the backing store, before they are potentially visible to userspace. For now use simple CPU based clearing to do this for device local-memory objects, note that in the near future this will instead use the blitter engine. Signed-off-by: Matthe

[Intel-gfx] [PATCH v2 9/9] drm/i915/gem: hide new uAPI behind CONFIG_BROKEN

2021-04-29 Thread Matthew Auld
Treat it the same as the fake local-memory stuff, where it is disabled for normal kernels, in case some random UMD is tempted to use this. Once we have all the other bits and pieces in place, like the TTM conversion, we can turn this on for real. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen C

[Intel-gfx] [PATCH v8 0/5] drm: Move struct drm_device.pdev to legacy

2021-04-29 Thread Thomas Zimmermann
V8 of the patchset fixes more bitrot and some commit messages. The pdev field in struct drm_device points to a PCI device structure and goes back to UMS-only days when all DRM drivers were for PCI devices. Meanwhile we also support USB, SPI and platform devices. Each of those uses the generic devi

[Intel-gfx] [PATCH v8 2/5] drm/i915/gt: Remove reference to struct drm_device.pdev

2021-04-29 Thread Thomas Zimmermann
References to struct drm_device.pdev should not be used any longer as the field will be moved into the struct's legacy section. Add a fix for the rsp commit. v8: * fix commit message (Michael) Signed-off-by: Thomas Zimmermann Fixes: a50ca39fbd01 ("drm/i915: setup the LMEM region") Cc: Lu

[Intel-gfx] [PATCH v8 1/5] drm/ast: Remove reference to struct drm_device.pdev

2021-04-29 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Upcast with to_pci_dev() from struct drm_device.dev to get the PCI device structure. Signed-off-by: Thomas Zimmermann Fixes: ba4e0339a6a3 ("drm/ast: Fixed CVE for DP501") Cc: KuoHsiang Chou Cc: kernel test robot Cc: Thomas Zimmermann Cc: Dave Airlie

[Intel-gfx] [PATCH v8 3/5] drm/i915: Remove reference to struct drm_device.pdev

2021-04-29 Thread Thomas Zimmermann
References to struct drm_device.pdev should not be used any longer as the field will be moved into the struct's legacy section. Fix a rsp comment. v8: * fix commit message (Michael) Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/intel_runtime_pm.h | 2 +- 1 file changed, 1 in

[Intel-gfx] [PATCH v8 4/5] drm/i915: Don't assign to struct drm_device.pdev

2021-04-29 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Don't assign it. Users should upcast from struct drm_device.dev. v6: * also fix the assignment in selftests in this patch (Chris) Signed-off-by: Thomas Zimmermann Reviewed-by: Chris Wilson Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi

[Intel-gfx] [PATCH v8 5/5] drm: Move struct drm_device.pdev to legacy section

2021-04-29 Thread Thomas Zimmermann
Struct drm_device.pdev is being moved to legacy status as only legacy DRM drivers use it. A possible follow-up patchset could remove pdev entirely. v4: * rebased Signed-off-by: Thomas Zimmermann Reviewed-by: Chris Wilson Acked-by: Sam Ravnborg --- include/drm/drm_device.h | 6 +++---

Re: [Intel-gfx] [PULL] gvt-next-fixes

2021-04-29 Thread Jani Nikula
On Thu, 29 Apr 2021, Zhenyu Wang wrote: > Hi, > > Here's just another left fix for possible divide error in vgpu > display rate calculation by Colin. Thanks, pulled to drm-intel-next-fixes. > btw, I'll need a backmerge of linus tree or maybe wait till rc1 > to apply gvt mdev dependency fix from

Re: [Intel-gfx] [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-29 Thread Daniel Vetter
On Wed, Apr 28, 2021 at 11:43:22AM +0300, Jani Nikula wrote: > On Tue, 27 Apr 2021, Umesh Nerlige Ramappa > wrote: > > Perf measurements rely on CPU and engine timestamps to correlate > > events of interest across these time domains. Current mechanisms get > > these timestamps separately and the

Re: [Intel-gfx] [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-29 Thread Daniel Vetter
On Wed, Apr 28, 2021 at 11:52:49PM +0200, Hans de Goede wrote: > Userspace could hold open a reference to the connector->kdev device, > through e.g. holding a sysfs-atrtribute open after > drm_sysfs_connector_remove() has been called. In this case the connector > could be free-ed while the connecto

Re: [Intel-gfx] [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-29 Thread Greg Kroah-Hartman
On Thu, Apr 29, 2021 at 01:40:28PM +0200, Daniel Vetter wrote: > On Wed, Apr 28, 2021 at 11:52:49PM +0200, Hans de Goede wrote: > > Userspace could hold open a reference to the connector->kdev device, > > through e.g. holding a sysfs-atrtribute open after > > drm_sysfs_connector_remove() has been c

[Intel-gfx] [PATCH] drm/i915: Use might_alloc()

2021-04-29 Thread Bernard Zhao
This maybe uses lockdep through the fs_reclaim annotations. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/i915/i915_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 9165971c3c47..7e1aa

[Intel-gfx] [PATCH] drm/i915: Use might_alloc()

2021-04-29 Thread Bernard Zhao
This maybe used lockdep through the fs_reclaim annotations. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/i915/i915_sw_fence.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_sw_fence.c b/drivers/gpu/drm/i915/i915_sw_fence.c index 2744558f30

Re: [Intel-gfx] BUG in i915/i915_pci.c, commit fe0f1e3

2021-04-29 Thread Mario Hüttel
Hi, yes. The bug is still present with a recent kernel. I got the tip from Imre Deak to try out 7962893ecb853 ("drm/i915: Disable runtime power management during shutdown") This fixes the issue for me. Do I still have to file a bug report or will this patch eventually find its way upstream? Tha

[Intel-gfx] [PATCH] drm/i915: Remove erroneous i915_is_ggtt check for I915_GEM_OBJECT_UNBIND_VM_TRYLOCK

2021-04-29 Thread Maarten Lankhorst
We changed the locking hierarchy for both ppgtt and ggtt, so both locks should be trylocked inside i915_gem_object_unbind(). Signed-off-by: Maarten Lankhorst Fixes: bc6f80cce9ae ("drm/i915: Use trylock in shrinker for ggtt on bsw vt-d and bxt, v2.") Cc: Thomas Hellström --- drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 01:54:46PM +0200, Greg Kroah-Hartman wrote: > On Thu, Apr 29, 2021 at 01:40:28PM +0200, Daniel Vetter wrote: > > On Wed, Apr 28, 2021 at 11:52:49PM +0200, Hans de Goede wrote: > > > Userspace could hold open a reference to the connector->kdev device, > > > through e.g. holdi

[Intel-gfx] [PATCH] drm/i915/display Try YCbCr420 color when RGB fails

2021-04-29 Thread Werner Sembach
When encoder validation of a display mode fails, retry with less bandwidth heavy YCbCr420 color mode, if available. This enables some HDMI 1.4 setups to support 4k60Hz output, which previously failed silently. AMDGPU had nearly the exact same issue. This problem description is therefore copied fro

Re: [Intel-gfx] [PATCH 06/21] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v3)

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 09:06:47AM +0100, Tvrtko Ursulin wrote: > > On 28/04/2021 18:26, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 10:49 AM Tvrtko Ursulin > > wrote: > > > > > > > > > On 23/04/2021 23:31, Jason Ekstrand wrote: > > > > This API is entirely unnecessary and I'd love to get

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-29 Thread Daniel Vetter
On Wed, Apr 28, 2021 at 01:17:27PM -0500, Jason Ekstrand wrote: > On Wed, Apr 28, 2021 at 1:02 PM Matthew Brost wrote: > > > > On Wed, Apr 28, 2021 at 12:46:07PM -0500, Jason Ekstrand wrote: > > > On Wed, Apr 28, 2021 at 12:26 PM Matthew Brost > > > wrote: > > > > Jumping on here mid-thread. For

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-29 Thread Daniel Vetter
On Wed, Apr 28, 2021 at 01:58:17PM -0500, Jason Ekstrand wrote: > On Wed, Apr 28, 2021 at 12:18 PM Jason Ekstrand wrote: > > > > On Wed, Apr 28, 2021 at 5:13 AM Daniel Vetter wrote: > > > > > > On Tue, Apr 27, 2021 at 08:51:08AM -0500, Jason Ekstrand wrote: > > > > I sent a v2 of this patch becau

Re: [Intel-gfx] [PATCH 11/21] drm/i915: Stop manually RCU banging in reset_stats_ioctl

2021-04-29 Thread Daniel Vetter
On Wed, Apr 28, 2021 at 01:22:14PM -0500, Jason Ekstrand wrote: > On Wed, Apr 28, 2021 at 5:27 AM Daniel Vetter wrote: > > > > On Fri, Apr 23, 2021 at 05:31:21PM -0500, Jason Ekstrand wrote: > > > As far as I can tell, the only real reason for this is to avoid taking a > > > reference to the i915_

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-29 Thread Daniel Vetter
On Wed, Apr 28, 2021 at 04:51:19PM +0100, Tvrtko Ursulin wrote: > > On 23/04/2021 23:31, Jason Ekstrand wrote: > > This adds a bunch of complexity which the media driver has never > > actually used. The media driver does technically bond a balanced engine > > to another engine but the balanced en

Re: [Intel-gfx] [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-29 Thread Hans de Goede
Hi, On 4/29/21 1:40 PM, Daniel Vetter wrote: > On Wed, Apr 28, 2021 at 11:52:49PM +0200, Hans de Goede wrote: >> Userspace could hold open a reference to the connector->kdev device, >> through e.g. holding a sysfs-atrtribute open after >> drm_sysfs_connector_remove() has been called. In this case

Re: [Intel-gfx] [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-29 Thread Hans de Goede
Hi, On 4/29/21 2:04 PM, Daniel Vetter wrote: > On Thu, Apr 29, 2021 at 01:54:46PM +0200, Greg Kroah-Hartman wrote: >> On Thu, Apr 29, 2021 at 01:40:28PM +0200, Daniel Vetter wrote: >>> On Wed, Apr 28, 2021 at 11:52:49PM +0200, Hans de Goede wrote: Userspace could hold open a reference to the

Re: [Intel-gfx] [PATCH 15/21] drm/i915/gt: Drop i915_address_space::file

2021-04-29 Thread Daniel Vetter
On Fri, Apr 23, 2021 at 05:31:25PM -0500, Jason Ekstrand wrote: > There's a big comment saying how useful it is but no one is using this > for anything. > > Signed-off-by: Jason Ekstrand I was trying to find anything before all your deletions, but alas nothing. I did spent a bit of time on this,

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-29 Thread Tvrtko Ursulin
On 29/04/2021 13:24, Daniel Vetter wrote: On Wed, Apr 28, 2021 at 04:51:19PM +0100, Tvrtko Ursulin wrote: On 23/04/2021 23:31, Jason Ekstrand wrote: This adds a bunch of complexity which the media driver has never actually used. The media driver does technically bond a balanced engine to an

Re: [Intel-gfx] [PATCH 13/21] drm/i915/gem: Add an intermediate proto_context struct

2021-04-29 Thread Daniel Vetter
The commit introducing a new data structure really should have a solid intro in the commit message about. Please cover - that ctx really should be immutable, safe for exceptions like priority - that unfortunately we butchered the uapi with setparam and sharing setparams between create_ext and s

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add ww parameter to get_pages() callback

2021-04-29 Thread Matthew Auld
On Thu, 29 Apr 2021 at 11:10, Maarten Lankhorst wrote: > > We will need this to support eviction with lmem, so > explicitly pass ww as a parameter. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Matthew Auld Should be Cc: dri-devel ___ Intel-gfx ma

Re: [Intel-gfx] [igt-dev] [ANNOUNCE] igt-gpu-tools 1.26

2021-04-29 Thread Tvrtko Ursulin
On 23/04/2021 13:12, Petri Latvala wrote: A new igt-gpu-tools release is available with the following changes: - Autotools support has been entirely dropped in favor of only meson. (Arkadiusz Hiler) - Tests can now signal that the whole test round should be aborted. (Arkadiusz Hiler) - Vari

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Add ww context to prepare_(read/write)

2021-04-29 Thread Matthew Auld
On Thu, 29 Apr 2021 at 11:10, Maarten Lankhorst wrote: > > This will allow us to explicitly pass the ww to pin_pages, when it starts > taking it. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@lists

Re: [Intel-gfx] [PATCH 14/21] drm/i915/gem: Return an error ptr from context_lookup

2021-04-29 Thread Daniel Vetter
On Fri, Apr 23, 2021 at 05:31:24PM -0500, Jason Ekstrand wrote: > We're about to start doing lazy context creation which means contexts > get created in i915_gem_context_lookup and we may start having more > errors than -ENOENT. > > Signed-off-by: Jason Ekstrand > --- > drivers/gpu/drm/i915/gem/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/backlight: use unique backlight device names (rev2)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915/backlight: use unique backlight device names (rev2) URL : https://patchwork.freedesktop.org/series/89578/ State : success == Summary == CI Bug Log - changes from CI_DRM_10027 -> Patchwork_20028 Summary

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Pass ww ctx to pin_map, v2.

2021-04-29 Thread Matthew Auld
On Thu, 29 Apr 2021 at 11:10, Maarten Lankhorst wrote: > > This will allow us to explicitly pass the ww to pin_pages, > when it starts taking it. > > This allows us to finally kill off the explicit passing of ww > by retrieving it from the obj. This seems to contradict the first sentence? > > C

[Intel-gfx] [PATCH] drm/i915: Fix wrong name announced on FB driver switching

2021-04-29 Thread Janusz Krzysztofik
Commit 7a0f9ef9703d ("drm/i915: Use drm_fb_helper_fill_info") effectively changed our FB driver name from "inteldrmfb" to "i915drmfb". However, we are still using the old name when kicking out a firmware fbdev driver potentially bound to our device. Use the new name to avoid confusion. Note: sin

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Pass ww ctx to i915_gem_object_pin_pages, v2.

2021-04-29 Thread Matthew Auld
On Thu, 29 Apr 2021 at 11:10, Maarten Lankhorst wrote: > > This is the final part of passing ww ctx to the get_pages() callbacks. > Now we no longer have to implicitly get ww ctx by using get_ww_ctx. > > Changes since v1: > - Fix error handling in pin_map_unlocked(). > > Signed-off-by: Maarten Lan

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/overlay: Fix active retire callback alignment

2021-04-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/overlay: Fix active retire callback alignment URL : https://patchwork.freedesktop.org/series/89637/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10027 -> Patchwork_20029

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Pass ww ctx to pin_map, v2.

2021-04-29 Thread Maarten Lankhorst
Op 29-04-2021 om 15:28 schreef Matthew Auld: > On Thu, 29 Apr 2021 at 11:10, Maarten Lankhorst > wrote: >> This will allow us to explicitly pass the ww to pin_pages, >> when it starts taking it. >> >> This allows us to finally kill off the explicit passing of ww >> by retrieving it from the obj. >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use correct downstream caps for check Src-Ctl mode for PCON

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Use correct downstream caps for check Src-Ctl mode for PCON URL : https://patchwork.freedesktop.org/series/89639/ State : success == Summary == CI Bug Log - changes from CI_DRM_10027 -> Patchwork_20030

Re: [Intel-gfx] [PATCH 06/21] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v3)

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 7:08 AM Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 09:06:47AM +0100, Tvrtko Ursulin wrote: > > > > On 28/04/2021 18:26, Jason Ekstrand wrote: > > > On Wed, Apr 28, 2021 at 10:49 AM Tvrtko Ursulin > > > wrote: > > > > > > > > > > > > On 23/04/2021 23:31, Jason Ekstran

Re: [Intel-gfx] [PATCH 03/21] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 3:04 AM Tvrtko Ursulin wrote: > > > On 28/04/2021 18:24, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 10:55 AM Tvrtko Ursulin > > wrote: > >> On 23/04/2021 23:31, Jason Ekstrand wrote: > >>> Instead of handling it like a context param, unconditionally set it when > >>

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Pass ww ctx to pin_map, v2.

2021-04-29 Thread Matthew Auld
On Thu, 29 Apr 2021 at 11:10, Maarten Lankhorst wrote: > > This will allow us to explicitly pass the ww to pin_pages, > when it starts taking it. > > This allows us to finally kill off the explicit passing of ww > by retrieving it from the obj. > > Changes since v1: > - Rename 'ret' to ptr, fix er

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Pass ww ctx to pin_map, v2.

2021-04-29 Thread Maarten Lankhorst
Op 29-04-2021 om 16:55 schreef Matthew Auld: > On Thu, 29 Apr 2021 at 11:10, Maarten Lankhorst > wrote: >> This will allow us to explicitly pass the ww to pin_pages, >> when it starts taking it. >> >> This allows us to finally kill off the explicit passing of ww >> by retrieving it from the obj. >

[Intel-gfx] ✓ Fi.CI.BAT: success for Workaround building improvements

2021-04-29 Thread Patchwork
== Series Details == Series: Workaround building improvements URL : https://patchwork.freedesktop.org/series/89641/ State : success == Summary == CI Bug Log - changes from CI_DRM_10027 -> Patchwork_20031 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Be more gentle with exiting non-persistent context

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Be more gentle with exiting non-persistent context URL : https://patchwork.freedesktop.org/series/89644/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6d335c292ae3 drm/i915: Be more gentle with exiting non-persistent context -:113: ERROR:C

Re: [Intel-gfx] [PATCH 15/21] drm/i915/gt: Drop i915_address_space::file

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 7:37 AM Daniel Vetter wrote: > > On Fri, Apr 23, 2021 at 05:31:25PM -0500, Jason Ekstrand wrote: > > There's a big comment saying how useful it is but no one is using this > > for anything. > > > > Signed-off-by: Jason Ekstrand > > I was trying to find anything before all

Re: [Intel-gfx] [PATCH 14/21] drm/i915/gem: Return an error ptr from context_lookup

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 8:27 AM Daniel Vetter wrote: > > On Fri, Apr 23, 2021 at 05:31:24PM -0500, Jason Ekstrand wrote: > > We're about to start doing lazy context creation which means contexts > > get created in i915_gem_context_lookup and we may start having more > > errors than -ENOENT. > > >

Re: [Intel-gfx] [PATCH] drm/i915: Include intel_de_{read, write}_fw() in i915_reg_rw traces

2021-04-29 Thread Ville Syrjälä
On Thu, Apr 29, 2021 at 11:11:25AM +0300, Jani Nikula wrote: > On Thu, 29 Apr 2021, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We lost the i915_reg_rw tracepoint for a lot of display registers > > when we switched from the heavyweight normal register accessors to > > the lightweight _fw

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 7:54 AM Tvrtko Ursulin wrote: > > > On 29/04/2021 13:24, Daniel Vetter wrote: > > On Wed, Apr 28, 2021 at 04:51:19PM +0100, Tvrtko Ursulin wrote: > >> > >> On 23/04/2021 23:31, Jason Ekstrand wrote: > >>> This adds a bunch of complexity which the media driver has never > >>

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Be more gentle with exiting non-persistent context

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Be more gentle with exiting non-persistent context URL : https://patchwork.freedesktop.org/series/89644/ State : success == Summary == CI Bug Log - changes from CI_DRM_10027 -> Patchwork_20032 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Propagate ww parameter to get_pages().

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Propagate ww parameter to get_pages(). URL : https://patchwork.freedesktop.org/series/89646/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5b47c2a18575 drm/i915: Add ww parameter to get_pages() callback d88153c9c5d0 drm/i915: Add ww contex

Re: [Intel-gfx] BUG in i915/i915_pci.c, commit fe0f1e3

2021-04-29 Thread Ville Syrjälä
On Thu, Apr 29, 2021 at 11:13:53AM +0300, Jani Nikula wrote: > On Wed, 28 Apr 2021, Mario Hüttel wrote: > > Hi, > > > > yes. The bug is still present with a recent kernel. > > I got the tip from Imre Deak to try out > > > > 7962893ecb853 ("drm/i915: Disable runtime power management during > > shut

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Daniel Vetter
Yeah this needs some text to explain what/why you're doing this, and maybe some rough sketch of the locking design. On Fri, Apr 23, 2021 at 05:31:26PM -0500, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 657 -- > dr

Re: [Intel-gfx] [PATCH] drm/i915: Include intel_de_{read, write}_fw() in i915_reg_rw traces

2021-04-29 Thread Ville Syrjälä
On Thu, Apr 29, 2021 at 07:34:00AM +, Gupta, Anshuman wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of Ville > > Syrjala > > Sent: Thursday, April 29, 2021 8:06 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Chiou, Cooper > > Subject: [Intel-gfx] [PATCH] drm/i9

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 7:16 AM Daniel Vetter wrote: > > On Wed, Apr 28, 2021 at 01:58:17PM -0500, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 12:18 PM Jason Ekstrand > > wrote: > > > > > > On Wed, Apr 28, 2021 at 5:13 AM Daniel Vetter wrote: > > > > > > > > On Tue, Apr 27, 2021 at 08:51:

Re: [Intel-gfx] [PATCH v8 2/5] drm/i915/gt: Remove reference to struct drm_device.pdev

2021-04-29 Thread Ruhl, Michael J
>-Original Message- >From: Intel-gfx On Behalf Of >Thomas Zimmermann >Sent: Thursday, April 29, 2021 6:51 AM >To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo >; airl...@linux.ie; dan...@ffwll.ch; chris@chris- >wilson.co.uk >Cc: Winiarski, Michal ; Nikula, Ja

Re: [Intel-gfx] [PATCH v8 3/5] drm/i915: Remove reference to struct drm_device.pdev

2021-04-29 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Thomas Zimmermann >Sent: Thursday, April 29, 2021 6:51 AM >To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo >; airl...@linux.ie; dan...@ffwll.ch; chris@chris- >wilson.co.uk >Cc: intel-gfx@lists.freedesktop.or

Re: [Intel-gfx] [PATCH v8 1/5] drm/ast: Remove reference to struct drm_device.pdev

2021-04-29 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Thomas Zimmermann >Sent: Thursday, April 29, 2021 6:51 AM >To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo >; airl...@linux.ie; dan...@ffwll.ch; chris@chris- >wilson.co.uk >Cc: lkp ; intel-gfx@lists.freed

Re: [Intel-gfx] BUG in i915/i915_pci.c, commit fe0f1e3

2021-04-29 Thread Imre Deak
On Thu, Apr 29, 2021 at 06:48:39PM +0300, Ville Syrjälä wrote: > On Thu, Apr 29, 2021 at 11:13:53AM +0300, Jani Nikula wrote: > > On Wed, 28 Apr 2021, Mario Hüttel wrote: > > > Hi, > > > > > > yes. The bug is still present with a recent kernel. > > > I got the tip from Imre Deak to try out > > > >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/backlight: use unique backlight device names (rev2)

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915/backlight: use unique backlight device names (rev2) URL : https://patchwork.freedesktop.org/series/89578/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10027_full -> Patchwork_20028_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Propagate ww parameter to get_pages().

2021-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Propagate ww parameter to get_pages(). URL : https://patchwork.freedesktop.org/series/89646/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10027 -> Patchwork_20033 Summary --- *

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/9] drm/doc/rfc: i915 DG1 uAPI URL : https://patchwork.freedesktop.org/series/89648/ State : warning == Summary == $ dim checkpatch origin/drm-tip 04da5ac951fc drm/doc/rfc: i915 DG1 uAPI -:63: WARNING:FILE_PATH_CHANGES: added, moved or del

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/9] drm/doc/rfc: i915 DG1 uAPI URL : https://patchwork.freedesktop.org/series/89648/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +driver

  1   2   >