== Series Details ==
Series: drm/i915: Initialize the mbus_offset to fix static analysis issue
URL : https://patchwork.freedesktop.org/series/90975/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10168_full -> Patchwork_20281_full
On Wed, Jun 02, 2021 at 03:33:43PM +0100, Tvrtko Ursulin wrote:
>
> On 06/05/2021 20:14, Matthew Brost wrote:
> > Reset implementation for new GuC interface. This is the legacy reset
> > implementation which is called when the i915 owns the engine hang check.
> > Future patches will offload the
== Series Details ==
Series: drm/i915: Initialize the mbus_offset to fix Klockwork issue
URL : https://patchwork.freedesktop.org/series/90972/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10168_full -> Patchwork_20280_full
Hi all,
On Thu, 3 Jun 2021 12:48:47 +1000 Stephen Rothwell
wrote:
>
> Today's linux-next merge of the amdgpu tree got conflicts in:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>
> between commit:
>
> d3116756a710 ("drm/ttm: rename bo->mem and
On Thu, Jun 03, 2021 at 11:35:28PM +0200, Daniel Vetter wrote:
> On Wed, Jun 02, 2021 at 10:16:18PM -0700, Matthew Brost wrote:
> > From: Michal Wajdeczko
> >
> > Generic helpers should be placed in i915_utils.h.
>
> Random rant, but we're _way_ too happy to just stuff random things into
>
== Series Details ==
Series: Introduce i915_sched_engine object (rev2)
URL : https://patchwork.freedesktop.org/series/90630/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10168_full -> Patchwork_20279_full
Summary
---
== Series Details ==
Series: drm/i915: Initialize the mbus_offset to fix static analysis issue
URL : https://patchwork.freedesktop.org/series/90975/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10168 -> Patchwork_20281
== Series Details ==
Series: drm/i915: Initialize the mbus_offset to fix Klockwork issue
URL : https://patchwork.freedesktop.org/series/90972/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10168 -> Patchwork_20280
Summary
== Series Details ==
Series: Introduce i915_sched_engine object (rev2)
URL : https://patchwork.freedesktop.org/series/90630/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10168 -> Patchwork_20279
Summary
---
== Series Details ==
Series: Introduce i915_sched_engine object (rev2)
URL : https://patchwork.freedesktop.org/series/90630/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/i915_scheduler_types.h:105: warning: cannot understand
function
== Series Details ==
Series: Introduce i915_sched_engine object (rev2)
URL : https://patchwork.freedesktop.org/series/90630/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
8225af1a908b drm/i915: Move priolist to new i915_sched_engine object
-:17: WARNING:REPEATED_WORD: Possible
From: Michal Wajdeczko
Upcoming GuC firmware will always require just two CTBs and we
also plan to configure them with different sizes, so definining
them as array is no longer suitable.
v2: Use %p for ptrdiff print
v3: Use %tx for ptrdiff print
Signed-off-by: Michal Wajdeczko
Signed-off-by:
From: Michal Wajdeczko
Future GuC will require CTB buffers sizes to be multiple of 4K.
Make these changes now as this shouldn't impact us too much.
Signed-off-by: Michal Wajdeczko
Signed-off-by: Matthew Brost
Reviewed-by: Matthew Brost
Cc: John Harrison
---
On Thu, Jun 03, 2021 at 02:53:38PM -0700, Manasi Navare wrote:
> Static analysis identified an issue in skl_crtc_allocate_ddb where
> mbus_offset may be used uninitialized.
> This patch fixes it.
>
> Fixes: 835c176cb1c4 ("drm/i915: Introduce MBUS relative dbuf offsets")
> Cc: Ville Syrjälä
>
From: Michal Wajdeczko
Upcoming GuC firmware will always require just two CTBs and we
also plan to configure them with different sizes, so definining
them as array is no longer suitable.
Signed-off-by: Michal Wajdeczko
Signed-off-by: Matthew Brost
Reviewed-by: Matthew Brost
Reported-by:
From: Michal Wajdeczko
Future GuC will require CTB buffers sizes to be multiple of 4K.
Make these changes now as this shouldn't impact us too much.
Signed-off-by: Michal Wajdeczko
Signed-off-by: Matthew Brost
Reviewed-by: Matthew Brost
Cc: John Harrison
---
== Series Details ==
Series: drm/i915: Finish conversion to GRAPHICS_VER
URL : https://patchwork.freedesktop.org/series/90964/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10166_full -> Patchwork_20277_full
Summary
Static analysis identified an issue in skl_crtc_allocate_ddb where
mbus_offset may be used uninitialized.
This patch fixes it.
Fixes: 835c176cb1c4 ("drm/i915: Introduce MBUS relative dbuf offsets")
Cc: Ville Syrjälä
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_pm.c | 2 +-
1
== Series Details ==
Series: shmem helpers for vgem (rev5)
URL : https://patchwork.freedesktop.org/series/90670/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10166 -> Patchwork_20278
Summary
---
**FAILURE**
Static analysis identified an issue in skl_crtc_allocate_ddb where
mbus_offset may be used uninitialized.
This patch fixes it.
Fixes: 835c176cb1c4 ("drm/i915: Introduce MBUS relative dbuf offsets")
Cc: Ville Syrjälä
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_pm.c | 2 +-
1
> https://github.com/0day-ci/linux/commits/Matthew-Brost/GuC-CTBs-changes-a-few-misc-patches/20210603-130102
> base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
> config: i386-randconfig-a015-20210603 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>
On Wed, Jun 02, 2021 at 10:16:18PM -0700, Matthew Brost wrote:
> From: Michal Wajdeczko
>
> Generic helpers should be placed in i915_utils.h.
Random rant, but we're _way_ too happy to just stuff random things into
i915_utils.h without trying to properly upstream it.
For thinks like this the
== Series Details ==
Series: shmem helpers for vgem (rev5)
URL : https://patchwork.freedesktop.org/series/90670/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9e8ef4e2828c dma-buf: Require VM_PFNMAP vma for mmap
-:34: WARNING:TYPO_SPELLING: 'entires' may be misspelled -
Move active request tracking and its lock to i915_sched_engine. This
lock is also the submission lock so having it in the i915_sched_engine
is the correct place.
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/i915/gt/intel_engine.h| 2 -
drivers/gpu/drm/i915/gt/intel_engine_cs.c
The submission tasklet operates on i915_sched_engine, thus it is the
correct place for it.
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/i915/gt/intel_engine.h| 14 ---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 12 +--
drivers/gpu/drm/i915/gt/intel_engine_types.h | 5 --
The schedule function should be in the schedule object.
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/i915/gem/i915_gem_wait.c | 4 ++--
drivers/gpu/drm/i915/gt/intel_engine_cs.c| 3 ---
drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c | 4 ++--
Rather than touching schedule state in the generic PM code, reset the
priolist allocation when empty in the submission code. Add a wrapper
function to do this and update the backends to call it in the correct
place.
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/i915/gt/intel_engine_pm.c
Signed-off-by: Matthew Brost
---
Documentation/gpu/i915.rst | 6
drivers/gpu/drm/i915/i915_scheduler_types.h | 37 ++---
2 files changed, 38 insertions(+), 5 deletions(-)
diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst
index
Rather than touching execlist specific structures in the generic
scheduling code, add a callback function in the backend.
Signed-off-by: Matthew Brost
---
.../drm/i915/gt/intel_execlists_submission.c | 52
drivers/gpu/drm/i915/i915_scheduler.c | 62 +--
Add wrapper function around RB tree to determine if i915_sched_engine is
empty.
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c| 2 +-
drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 6 +++---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c| 2
Rather passing around an intel_engine_cs in the scheduling code, pass
around a i915_sched_engine.
Signed-off-by: Matthew Brost
---
.../drm/i915/gt/intel_execlists_submission.c | 11 +++--
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
drivers/gpu/drm/i915/i915_scheduler.c | 46
Introduce i915_sched_engine object which is lower level data structure
that i915_scheduler / generic code can operate on without touching
execlist specific structures. This allows additional submission backends
to be added without breaking the layering.
This is a bit of detour to integrating the
As discussed in [1] we are breaking that large series into a several
smaller ones. This series is stand alone patch part of step #4 which has
no other dependencies or patches relevant to it.
v2:
(Daniel Vetter):
- Split into several smaller patches
- Add kernel doc for i915_sched_engine
Aside from deleting lots of code the real motivation here is to switch
the mmap over to VM_PFNMAP, to be more consistent with what real gpu
drivers do. They're all VM_PFNMP, which means get_user_pages doesn't
work, and even if you try and there's a struct page behind that,
touching it and mucking
We want to stop gup, which isn't the case if we use vmf_insert_page
and VM_MIXEDMAP, because that does not set pte_special.
v2: With this shmem gem helpers now definitely need CONFIG_MMU (0day)
v3: add more depends on MMU. For usb drivers this is a bit awkward,
but really it's correct: To be
== Series Details ==
Series: Use platform specific defaults for GuC/HuC enabling
URL : https://patchwork.freedesktop.org/series/90956/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10166_full -> Patchwork_20275_full
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next
tegra-drm/drm/tegra/for-next linus/master v5.13-rc4 next-20210603]
[cannot apply to drm/drm-next]
[If your patch
== Series Details ==
Series: drm/i915: Finish conversion to GRAPHICS_VER
URL : https://patchwork.freedesktop.org/series/90964/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10166 -> Patchwork_20277
Summary
---
== Series Details ==
Series: drm/i915: Finish conversion to GRAPHICS_VER
URL : https://patchwork.freedesktop.org/series/90964/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
== Series Details ==
Series: drm/i915: Finish conversion to GRAPHICS_VER
URL : https://patchwork.freedesktop.org/series/90964/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
dd73d7c8a448 drm/i915/gt: replace IS_GEN and friends with GRAPHICS_VER
-:2330: WARNING:LONG_LINE: line
== Series Details ==
Series: shmem helpers for vgem (rev3)
URL : https://patchwork.freedesktop.org/series/90670/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10166 -> Patchwork_20276
Summary
---
**FAILURE**
On Wed, Jun 2, 2021 at 12:25 AM Zbigniew Kempczyński
wrote:
>
> We have established previously we stop using relocations starting
> from gen12 platforms with Tigerlake as an exception. We keep this
> statement but we want to enable relocations conditionally for
> Rocketlake and Alderlake under
== Series Details ==
Series: shmem helpers for vgem (rev3)
URL : https://patchwork.freedesktop.org/series/90670/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c0a84d0fb311 dma-buf: Require VM_PFNMAP vma for mmap
-:34: WARNING:TYPO_SPELLING: 'entires' may be misspelled -
Am 03.06.21 um 17:03 schrieb Daniel Vetter:
shmem helpers seem a bit sloppy here by automatically rounding up when
actually creating the buffer, which results in under-reporting of what
we actually have. Caught by igt/vgem_basic tests.
Acked-by: Thomas Zimmermann
Signed-off-by: Daniel Vetter
On Thu, Jun 03, 2021 at 09:42:00PM +0300, Andi Shyti wrote:
> Hi Daniel,
>
> > +/*
> > + * This just sets wc mode for shmem helpers. vgem doesn't have any
> > begin/end cpu
> > + * access ioctls, there must use coherent memory or dma-buf sharing just
> > wont
> > + * work.
> > + */
> > +static
== Series Details ==
Series: Use platform specific defaults for GuC/HuC enabling
URL : https://patchwork.freedesktop.org/series/90956/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10166 -> Patchwork_20275
Summary
---
Hi Daniel,
> +/*
> + * This just sets wc mode for shmem helpers. vgem doesn't have any begin/end
> cpu
> + * access ioctls, there must use coherent memory or dma-buf sharing just wont
> + * work.
> + */
> +static struct drm_gem_object *vgem_gem_create_object(struct drm_device *dev,
> size_t
On Thu, Jun 03, 2021 at 08:37:22AM -0700, Kulkarni, Vandita wrote:
> > -Original Message-
> > From: Manna, Animesh
> > Sent: Thursday, June 3, 2021 7:24 PM
> > To: Kulkarni, Vandita ; Nikula, Jani
> > ; Saarinen, Jani ; intel-
> > g...@lists.freedesktop.org
> > Cc: Navare, Manasi D
> >
On Thu, Jun 03, 2021 at 06:49:23AM -0700, Manna, Animesh wrote:
>
>
> > -Original Message-
> > From: Jani Nikula
> > Sent: Thursday, June 3, 2021 6:03 PM
> > To: Roper, Matthew D ; intel-
> > g...@lists.freedesktop.org
> > Cc: Manna, Animesh ; Navare, Manasi D
> > ; Kulkarni, Vandita
>
== Series Details ==
Series: drm/i915: Get rid of fence error propagation (rev2)
URL : https://patchwork.freedesktop.org/series/90891/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10165_full -> Patchwork_20274_full
CRC should be collected without degamma transformation
and after drawing gradient with degamma LUT.
This patch removes things which are not related to degamma
and makes it similar to pipe gamma test.
Signed-off-by: Vidya Srinivas
---
tests/kms_color.c | 16 ++--
1 file changed, 6
== Series Details ==
Series: drm/i915: Get rid of fence error propagation (rev2)
URL : https://patchwork.freedesktop.org/series/90891/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10165 -> Patchwork_20274
Summary
---
v3 is a resend from v2 (https://patchwork.freedesktop.org/series/90693/)
now with dri-devel Cc'ed. Notice that this patch series can be applied
splitting it up through the trees, it's not necessary to apply them
together. The intention is to apply first 3 patches on drm-intel-gt-next
and the
This was done by the following semantic patch:
@@ expression i915; @@
- INTEL_GEN(i915)
+ GRAPHICS_VER(i915)
@@ expression i915; expression E; @@
- INTEL_GEN(i915) >= E
+ GRAPHICS_VER(i915) >= E
@@ expression dev_priv; expression E; @@
For some reason coccinelle misses a few cases in header files with calls to
INTEL_GEN()/IS_GEN(). Do a manual conversion for those.
Signed-off-by: Lucas De Marchi
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/i915_drv.h | 37 -
drivers/gpu/drm/i915/i915_reg.h
This was done by the following semantic patch:
@@ expression i915; @@
- INTEL_GEN(i915)
+ GRAPHICS_VER(i915)
@@ expression i915; expression E; @@
- INTEL_GEN(i915) >= E
+ GRAPHICS_VER(i915) >= E
@@ expression dev_priv; expression E; @@
This was done by the following semantic patch:
@@ expression i915; @@
- INTEL_GEN(i915)
+ GRAPHICS_VER(i915)
@@ expression i915; expression E; @@
- INTEL_GEN(i915) >= E
+ GRAPHICS_VER(i915) >= E
@@ expression dev_priv; expression E; @@
Since we are replacing IS_GEN() with GRAPHICS_VER(), make sure we take
care of the comments as well.
Signed-off-by: Lucas De Marchi
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/display/intel_tv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This was done by the following semantic patch:
@@ expression i915; @@
- INTEL_GEN(i915)
+ GRAPHICS_VER(i915)
@@ expression i915; expression E; @@
- INTEL_GEN(i915) >= E
+ GRAPHICS_VER(i915) >= E
@@ expression dev_priv; expression E; @@
For some reason coccinelle misses a few cases in gt with calls to
INTEL_GEN()/IS_GEN(). Do a manual conversion for those.
Signed-off-by: Lucas De Marchi
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gt/debugfs_gt_pm.c | 2 +-
drivers/gpu/drm/i915/gt/intel_engine_types.h | 4 ++--
shmem helpers seem a bit sloppy here by automatically rounding up when
actually creating the buffer, which results in under-reporting of what
we actually have. Caught by igt/vgem_basic tests.
Acked-by: Thomas Zimmermann
Signed-off-by: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc:
Aside from deleting lots of code the real motivation here is to switch
the mmap over to VM_PFNMAP, to be more consistent with what real gpu
drivers do. They're all VM_PFNMP, which means get_user_pages doesn't
work, and even if you try and there's a struct page behind that,
touching it and mucking
We want to stop gup, which isn't the case if we use vmf_insert_page
and VM_MIXEDMAP, because that does not set pte_special.
v2: With this shmem gem helpers now definitely need CONFIG_MMU (0day)
Signed-off-by: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc:
tldr; DMA buffers aren't normal memory, expecting that you can use
them like that (like calling get_user_pages works, or that they're
accounting like any other normal memory) cannot be guaranteed.
Since some userspace only runs on integrated devices, where all
buffers are actually all resident
Hi all,
Another small iteration, lost another patch, so another full resend.
Thomas Zimmermann pointed out how to get at drm_gem_shmem_funcs without
getting at drm_gem_shmem_funcs directly.
Test-with: 20210527140732.5762-1-daniel.vet...@ffwll.ch
Cheers, Daniel
Daniel Vetter (4):
dma-buf:
On Thu, Jun 03, 2021 at 09:51:19AM +0100, Tvrtko Ursulin wrote:
>
> On 03/06/2021 05:10, Matthew Brost wrote:
> > On Wed, Jun 02, 2021 at 04:27:18PM +0100, Tvrtko Ursulin wrote:
> > >
> > > On 25/05/2021 17:45, Matthew Brost wrote:
>
> [snip]
>
> > > > >* Kludgy way of interfacing with
== Series Details ==
Series: drm/i915: Get rid of fence error propagation (rev2)
URL : https://patchwork.freedesktop.org/series/90891/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function
parameter
On Thu, May 27, 2021 at 06:40:00PM +, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/3] drm/i915/ddi: Flush encoder power domain
> ref puts during driver unload
> URL : https://patchwork.freedesktop.org/series/90613/
> State : success
Thanks for the review,
== Series Details ==
Series: drm/i915: Get rid of fence error propagation (rev2)
URL : https://patchwork.freedesktop.org/series/90891/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
== Series Details ==
Series: drm/i915: Get rid of fence error propagation (rev2)
URL : https://patchwork.freedesktop.org/series/90891/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
20301afd39c9 drm/i915: Revert "drm/i915/gem: Asynchronous cmdparser"
-:6: ERROR:GIT_COMMIT_ID:
From: John Harrison
The meaning of 'default' for the enable_guc module parameter has been
updated to accurately reflect what is supported on current platforms.
So start using the defaults instead of forcing everything off.
Although, note that right now, the default is for everything to be off
Reviewed a long time ago, resending for CI + to dri-devel.
John Harrison (1):
drm/i915/uc: Use platform specific defaults for GuC/HuC enabling
drivers/gpu/drm/i915/i915_params.c | 2 +-
drivers/gpu/drm/i915/i915_params.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.28.0
On Thu, Jun 3, 2021 at 2:32 AM Daniel Vetter wrote:
>
> On Thu, Jun 3, 2021 at 12:23 AM Jason Ekstrand wrote:
> >
> > On Mon, May 31, 2021 at 4:12 AM Daniel Vetter wrote:
> > >
> > > On Thu, May 27, 2021 at 11:26:42AM -0500, Jason Ekstrand wrote:
> > > > +static int set_proto_ctx_engines(struct
== Series Details ==
Series: shmem helpers for igt
URL : https://patchwork.freedesktop.org/series/90947/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10165 -> Patchwork_20273
Summary
---
**FAILURE**
Serious
On Thu, Jun 03, 2021 at 11:44:57AM +0200, Michal Wajdeczko wrote:
>
>
> On 03.06.2021 07:16, Matthew Brost wrote:
> > Ensure H2G buffer updates are visible before descriptor tail updates by
> > inserting a barrier between the H2G buffer update and the tail. The
> > barrier is simple wmb() for
On Thu, Jun 03, 2021 at 11:05:15AM +0200, Daniel Vetter wrote:
> On Thu, Jun 3, 2021 at 5:30 AM Matthew Brost wrote:
> >
> > On Mon, May 31, 2021 at 10:31:53AM +0200, Daniel Vetter wrote:
> > > On Thu, May 27, 2021 at 4:19 PM Matthew Brost
> > > wrote:
> > > >
> > > > On Thu, May 27, 2021 at
== Series Details ==
Series: shmem helpers for igt
URL : https://patchwork.freedesktop.org/series/90947/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
16d2d93866c0 drm/gem-shmem-helper: Export drm_gem_shmem_funcs
-:49: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email
Hi
Am 03.06.21 um 17:03 schrieb Daniel Vetter:
Drivers which need to overwrite the drm_driver->gem_create_object hook
need this. Specifically vgem, which wants wc mode, but everything else
is fine as-is.
Signed-off-by: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas
On Thu, 03 Jun 2021, "Manna, Animesh" wrote:
>> -Original Message-
>> From: Jani Nikula
>> Sent: Thursday, June 3, 2021 3:10 PM
>> To: Roper, Matthew D ; intel-
>> g...@lists.freedesktop.org
>> Cc: Manna, Animesh ; Navare, Manasi D
>> ; Kulkarni, Vandita
>> Subject: Re: [Intel-gfx] [CI
This reverts a6c5e2aea704 ("drm/i915: Skip over MI_NOOP when parsing").
It complicates the batch parsing code a bit and increases indentation
for no reason other than fast-skipping a command that userspace uses
only rarely. Sure, there may be IGT tests that fill batches with NOOPs
but that's not
Asynchronous command parsing was the only thing which ever returned a
non-zero error. With that gone, we can drop the error handling from
dma_fence_work.
Signed-off-by: Jason Ekstrand
Reviewed-by: Jon Bloomfield
Acked-by: Daniel Vetter
---
drivers/gpu/drm/i915/gem/i915_gem_clflush.c | 4 +---
This reverts the rest of 0edbb9ba1bfe ("drm/i915: Move cmd parser
pinning to execbuffer"). Now that the only user of i915_gem_object_get_sg
without allow_alloc has been removed, we can drop the parameter. This
portion of the revert was broken into its own patch to aid review.
Signed-off-by:
This reverts commit 9e31c1fe45d555a948ff66f1f0e3fe1f83ca63f7. Ever
since that commit, we've been having issues where a hang in one client
can propagate to another. In particular, a hang in an app can propagate
to the X server which causes the whole desktop to lock up.
Error propagation along
Fence error propagation is sketchy at best. Instead of explicitly handling
fences which might have errors set in the code which is aware of errors, we
just kick them down the line and hope that userspace knows what to do when
a wait eventually fails. This is sketchy at best because most
This reverts 686c7c35abc2 ("drm/i915/gem: Asynchronous cmdparser"). The
justification for this commit in the git history was a vague comment
about getting it out from under the struct_mutex. While this may
improve perf for some workloads on Gen7 platforms where we rely on the
command parser for
> -Original Message-
> From: Manna, Animesh
> Sent: Thursday, June 3, 2021 7:24 PM
> To: Kulkarni, Vandita ; Nikula, Jani
> ; Saarinen, Jani ; intel-
> g...@lists.freedesktop.org
> Cc: Navare, Manasi D
> Subject: RE: [Intel-gfx] [PATCH] drm/i915/dsc: Remove redundant checks in
> DSC
On Thu, Jun 3, 2021 at 3:28 AM Daniel Vetter wrote:
>
> On Thu, Jun 03, 2021 at 10:25:00AM +0200, Daniel Vetter wrote:
> > On Thu, Jun 03, 2021 at 10:24:21AM +0200, Daniel Vetter wrote:
> > > On Wed, Jun 02, 2021 at 11:41:48AM -0500, Jason Ekstrand wrote:
> > > > This reverts commit
On Thu, Jun 3, 2021 at 3:22 AM Daniel Vetter wrote:
>
> On Wed, Jun 02, 2021 at 11:41:45AM -0500, Jason Ekstrand wrote:
> > This reverts 686c7c35abc2 ("drm/i915/gem: Asynchronous cmdparser"). The
> > justification for this commit in the git history was a vague comment
> > about getting it out
CRC should be collected without degamma transformation
and after drawing gradient with degamma LUT.
This patch removes things which are not related to degamma
and makes it similar to pipe gamma test.
Change-Id: I37f957b3a95dfe95119f0f0941f20c10471f437c
Signed-off-by: Vidya Srinivas
---
Aside from deleting lots of code the real motivation here is to switch
the mmap over to VM_PFNMAP, to be more consistent with what real gpu
drivers do. They're all VM_PFNMP, which means get_user_pages doesn't
work, and even if you try and there's a struct page behind that,
touching it and mucking
shmem helpers seem a bit sloppy here by automatically rounding up when
actually creating the buffer, which results in under-reporting of what
we actually have. Caught by igt/vgem_basic tests.
Acked-by: Thomas Zimmermann
Signed-off-by: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc:
Drivers which need to overwrite the drm_driver->gem_create_object hook
need this. Specifically vgem, which wants wc mode, but everything else
is fine as-is.
Signed-off-by: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: David Airlie
Cc: Daniel Vetter
---
We want to stop gup, which isn't the case if we use vmf_insert_page
and VM_MIXEDMAP, because that does not set pte_special.
v2: With this shmem gem helpers now definitely need CONFIG_MMU (0day)
Signed-off-by: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc:
Hi all,
I finally figured out why CI is unhappy on some machines, we've lost WC
mode on the vgem side!
Test-with: 20210527140732.5762-1-daniel.vet...@ffwll.ch
Cheers, Daniel
Daniel Vetter (4):
drm/gem-shmem-helper: Export drm_gem_shmem_funcs
drm/shmem-helper: Switch to vmf_insert_pfn
== Series Details ==
Series: shmem helpers for vgem (rev2)
URL : https://patchwork.freedesktop.org/series/90670/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10165 -> Patchwork_20272
Summary
---
**FAILURE**
== Series Details ==
Series: series starting with [1/2] drm/i915/dsc: abstract helpers to get
bigjoiner primary/secondary crtc
URL : https://patchwork.freedesktop.org/series/90936/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10164_full -> Patchwork_20271_full
On 6/3/21 11:48 AM, Matthew Auld wrote:
On Wed, 2 Jun 2021 at 18:08, Thomas Hellström
wrote:
For discrete, use TTM for both cached and WC system memory. That means
we currently rely on the TTM memory accounting / shrinker. For cached
system memory we should consider remaining shmem-backed,
== Series Details ==
Series: shmem helpers for vgem (rev2)
URL : https://patchwork.freedesktop.org/series/90670/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a1fb989b5b4e dma-buf: Require VM_PFNMAP vma for mmap
-:34: WARNING:TYPO_SPELLING: 'entires' may be misspelled -
On 6/3/21 1:17 PM, Matthew Auld wrote:
On Wed, 2 Jun 2021 at 18:08, Thomas Hellström
wrote:
The object ops i915_GEM_OBJECT_HAS_IOMEM and the object
I915_BO_ALLOC_STRUCT_PAGE flags are considered immutable by
much of our code. Introduce a new mem_flags member to hold these
and make sure checks
> -Original Message-
> From: Nikula, Jani
> Sent: Thursday, June 3, 2021 5:59 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Nikula, Jani ; Manna, Animesh
> ; Navare, Manasi D
> ; Kulkarni, Vandita
> Subject: [PATCH 1/2] drm/i915/dsc: abstract helpers to get bigjoiner
>
1 - 100 of 158 matches
Mail list logo
