Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Relax CTB response timeout

2021-06-10 Thread Michal Wajdeczko
On 11.06.2021 02:05, Matthew Brost wrote: > In upcoming patch we will allow more CTB requests to be sent in > parallel to the GuC for processing, so we shouldn't assume any more > that GuC will always reply without 10ms. s/without/within > > Use bigger value hardcoded value of 1s instead. >

Re: [Intel-gfx] [PULL] drm-misc-next

2021-06-10 Thread Thomas Zimmermann
Hi Am 10.06.21 um 15:32 schrieb Daniel Vetter: On Thu, Jun 10, 2021 at 1:15 PM Thomas Zimmermann wrote: Hi Dave and Daniel, here's the second PR for drm-misc-next for this week, and the final one for 5.14. I backmerged drm-next for the TTM changes. As for highlights nouveau now has eDP backl

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Reorder tasklet_disable vs local_bh_disable

2021-06-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Reorder tasklet_disable vs local_bh_disable URL : https://patchwork.freedesktop.org/series/91372/ State : success == Summary == CI Bug Log - changes from CI_DRM_10209 -> Patchwork_20341 Summa

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add relocation exceptions for two other platforms (rev5)

2021-06-10 Thread Zbigniew Kempczyński
On Thu, Jun 10, 2021 at 03:02:20PM +, Patchwork wrote: >Patch Details > >Series: drm/i915: Add relocation exceptions for two other platforms > (rev5) >URL: https://patchwork.freedesktop.org/series/89594/ > >State: failure

[Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

2021-06-10 Thread Zbigniew Kempczyński
We have established previously we stop using relocations starting from gen12 platforms with Tigerlake as an exception. We keep this statement but we want to enable relocations conditionally for Alderlake S+P under require_force_probe flag set. Keeping relocations under require_force_probe flag is

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Reorder tasklet_disable vs local_bh_disable

2021-06-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Reorder tasklet_disable vs local_bh_disable URL : https://patchwork.freedesktop.org/series/91372/ State : warning == Summary == $ dim checkpatch origin/drm-tip f80b835c6383 drm/i915/selftests: Reorder tasklet_disable vs local_bh_disable -:13: WA

Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

2021-06-10 Thread Zbigniew Kempczyński
On Thu, Jun 10, 2021 at 10:36:12AM -0400, Rodrigo Vivi wrote: > On Thu, Jun 10, 2021 at 12:39:55PM +0200, Zbigniew Kempczyński wrote: > > We have established previously we stop using relocations starting > > from gen12 platforms with Tigerlake as an exception. We keep this > > statement but we want

[Intel-gfx] [PATCH] drm/i915/selftests: Reorder tasklet_disable vs local_bh_disable

2021-06-10 Thread Thomas Hellström
From: Chris Wilson Due to a change in requirements that disallows tasklet_disable() being called from atomic context, rearrange the selftest to avoid doing so. <3> [324.942939] BUG: sleeping function called from invalid context at kernel/softirq.c:888 <3> [324.942952] in_atomic(): 1, irqs_disab

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uapi: Add query for L3 bank count

2021-06-10 Thread Lionel Landwerlin
On 10/06/2021 23:46, john.c.harri...@intel.com wrote: From: John Harrison Various UMDs need to know the L3 bank count. So add a query API for it. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++ drivers/gpu/drm/i915/gt/intel_gt.h | 1 + drivers/gp

Re: [Intel-gfx] Strange hugepages result?

2021-06-10 Thread Thomas Hellström
On 6/10/21 9:57 PM, Matthew Auld wrote: Hi, On Thu, 10 Jun 2021 at 20:02, Thomas Hellström wrote: Hi, Matthew! I got a funny result from the hugepages selftest when trying to break out some functionality from shmem to make a ttm page pool for cached-only TTM system bos. It turns out that sh

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Steer MCR reads to lowest potential slice/subslice

2021-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Steer MCR reads to lowest potential slice/subslice URL : https://patchwork.freedesktop.org/series/91367/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10206_full -> Patchwork_20340_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for Relax CTB response timeout

2021-06-10 Thread Patchwork
== Series Details == Series: Relax CTB response timeout URL : https://patchwork.freedesktop.org/series/91366/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10206_full -> Patchwork_20339_full Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

2021-06-10 Thread Modem, Bhanuprakash
> From: Intel-gfx On Behalf Of Vidya > Srinivas > Sent: Tuesday, June 1, 2021 7:38 PM > To: intel-gfx@lists.freedesktop.org; igt-...@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't > set primary fb color in coverage-vs-premult-vs-constant > > Pa

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Steer MCR reads to lowest potential slice/subslice

2021-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Steer MCR reads to lowest potential slice/subslice URL : https://patchwork.freedesktop.org/series/91367/ State : success == Summary == CI Bug Log - changes from CI_DRM_10206 -> Patchwork_20340 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for Add support for querying hw info that UMDs need

2021-06-10 Thread Patchwork
== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/91353/ State : success == Summary == CI Bug Log - changes from CI_DRM_10205_full -> Patchwork_20338_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for Relax CTB response timeout

2021-06-10 Thread Patchwork
== Series Details == Series: Relax CTB response timeout URL : https://patchwork.freedesktop.org/series/91366/ State : success == Summary == CI Bug Log - changes from CI_DRM_10206 -> Patchwork_20339 Summary --- **SUCCESS** No regre

[Intel-gfx] [PATCH] drm/i915: Steer MCR reads to lowest potential slice/subslice

2021-06-10 Thread Matt Roper
When determining the slice/subslice to use for steering multicast register reads we need to not only consider the fusing (to avoid steering to a fused off instance), but also the "minconfig" that the hardware uses to wake from RC6 when render power gating is enabled on some platforms. Although it

[Intel-gfx] ✗ Fi.CI.IGT: failure for Revert "drm/i915/display: Drop FIXME about turn off infoframes"

2021-06-10 Thread Patchwork
== Series Details == Series: Revert "drm/i915/display: Drop FIXME about turn off infoframes" URL : https://patchwork.freedesktop.org/series/91350/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10205_full -> Patchwork_20337_full =

[Intel-gfx] [PATCH 0/1] Relax CTB response timeout

2021-06-10 Thread Matthew Brost
A previous version of patch [1] was NACK'd because it introduced a Kconfig option. We agreed on a larger timeout value if problems were shown with the current timeout value. A problem was shown in CI [2], let's increase the timeout. [1] https://patchwork.freedesktop.org/patch/436623/ [2] https://

[Intel-gfx] [PATCH 1/1] drm/i915/guc: Relax CTB response timeout

2021-06-10 Thread Matthew Brost
In upcoming patch we will allow more CTB requests to be sent in parallel to the GuC for processing, so we shouldn't assume any more that GuC will always reply without 10ms. Use bigger value hardcoded value of 1s instead. v2: Add CONFIG_DRM_I915_GUC_CTB_TIMEOUT config option v3: (Daniel Vetter)

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uapi: Add query for L3 bank count

2021-06-10 Thread Michal Wajdeczko
On 10.06.2021 22:46, john.c.harri...@intel.com wrote: > From: John Harrison > > Various UMDs need to know the L3 bank count. So add a query API for it. > > Signed-off-by: John Harrison > --- > drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++ > drivers/gpu/drm/i915/gt/intel_gt.h | 1

[Intel-gfx] ✗ Fi.CI.IGT: failure for Pipe DMC Support (rev6)

2021-06-10 Thread Patchwork
== Series Details == Series: Pipe DMC Support (rev6) URL : https://patchwork.freedesktop.org/series/90445/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10205_full -> Patchwork_20336_full Summary --- **FAILURE** S

Re: [Intel-gfx] [PATCH v4 13/17] drm/i915/pxp: Enable PXP power management

2021-06-10 Thread Daniele Ceraolo Spurio
On 6/2/2021 9:20 AM, Rodrigo Vivi wrote: On Mon, May 24, 2021 at 10:47:59PM -0700, Daniele Ceraolo Spurio wrote: From: "Huang, Sean Z" During the power event S3+ sleep/resume, hardware will lose all the encryption keys for every hardware session, even though the session state might still be

Re: [Intel-gfx] [PATCH 2/3] drm/i915/uapi: Add query for hwconfig table

2021-06-10 Thread Michal Wajdeczko
On 10.06.2021 22:46, john.c.harri...@intel.com wrote: > From: Rodrigo Vivi > > GuC contains a consolidated table with a bunch of information about the > current device. > > Previously, this information was spread and hardcoded to all the components > including GuC, i915 and various UMDs. The

Re: [Intel-gfx] [PATCH v4 12/17] drm/i915/pxp: start the arb session on demand

2021-06-10 Thread Daniele Ceraolo Spurio
On 6/2/2021 11:14 AM, Rodrigo Vivi wrote: On Mon, May 24, 2021 at 10:47:58PM -0700, Daniele Ceraolo Spurio wrote: Now that we can handle destruction and re-creation of the arb session, we can postpone the start of the session to the first submission that requires it, to avoid keeping it runni

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Add fetch of hwconfig table

2021-06-10 Thread Michal Wajdeczko
On 10.06.2021 22:46, john.c.harri...@intel.com wrote: > From: John Harrison > > Implement support for fetching the hardware description table from the > GuC. The call is made twice - once without a destination buffer to > query the size and then a second time to fill in the buffer. > > This pa

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uapi: Add query for L3 bank count

2021-06-10 Thread Matthew Brost
On Thu, Jun 10, 2021 at 01:46:26PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > Various UMDs need to know the L3 bank count. So add a query API for it. > > Signed-off-by: John Harrison > --- > drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++ > drivers/gpu/drm/i915/

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/fbc: Clean up cfb allocation code

2021-06-10 Thread Patchwork
== Series Details == Series: drm/i915/fbc: Clean up cfb allocation code URL : https://patchwork.freedesktop.org/series/91347/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10205_full -> Patchwork_20335_full Summary ---

Re: [Intel-gfx] [PATCH 5/5] DONOTMERGE: dma-buf: Get rid of dma_fence_get_rcu_safe

2021-06-10 Thread Christian König
Am 10.06.21 um 19:11 schrieb Daniel Vetter: On Thu, Jun 10, 2021 at 06:54:13PM +0200, Christian König wrote: Am 10.06.21 um 18:37 schrieb Daniel Vetter: On Thu, Jun 10, 2021 at 6:24 PM Jason Ekstrand wrote: On Thu, Jun 10, 2021 at 10:13 AM Daniel Vetter wrote: On Thu, Jun 10, 2021 at 3:59

Re: [Intel-gfx] [PATCH 2/3] drm/i915/uapi: Add query for hwconfig table

2021-06-10 Thread Matthew Brost
On Thu, Jun 10, 2021 at 01:46:25PM -0700, john.c.harri...@intel.com wrote: > From: Rodrigo Vivi > > GuC contains a consolidated table with a bunch of information about the > current device. > > Previously, this information was spread and hardcoded to all the components > including GuC, i915 and

[Intel-gfx] [PATCH i-g-t 2/2] tests/i915/query: Add test for L3 bank count

2021-06-10 Thread John . C . Harrison
From: John Harrison Various UMDs need to know the L3 bank count. So a query API has been added for it. Test that query. Signed-off-by: John Harrison --- include/drm-uapi/i915_drm.h | 1 + tests/i915/i915_query.c | 35 +++ 2 files changed, 36 insertions(+)

[Intel-gfx] [PATCH i-g-t 0/2] Add tests for new hw info queries

2021-06-10 Thread John . C . Harrison
From: John Harrison Various UMDs require hardware configuration information about the current platform. New interfaces have been added to the KMD to return this informatio. So, add some tests for the new interfaces. Signed-off-by: John Harrison John Harrison (1): tests/i915/query: Add test

[Intel-gfx] [PATCH i-g-t 1/2] tests/i915/query: Query, parse and validate the hwconfig table

2021-06-10 Thread John . C . Harrison
From: Rodrigo Vivi All the static platform configuration per SKU is moving to this KVL table. User Space components can query and parse it to find the proper hw configuration instead of having to hardcode it. Add a query as both an example of how to fetch the table and to validate the KLV conten

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Add fetch of hwconfig table

2021-06-10 Thread Matthew Brost
On Thu, Jun 10, 2021 at 01:46:24PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > Implement support for fetching the hardware description table from the > GuC. The call is made twice - once without a destination buffer to > query the size and then a second time to fill in the b

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for querying hw info that UMDs need

2021-06-10 Thread Patchwork
== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/91353/ State : success == Summary == CI Bug Log - changes from CI_DRM_10205 -> Patchwork_20338 Summary --- **

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Force a TypeC PHY disconnect during suspend/shutdown

2021-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Force a TypeC PHY disconnect during suspend/shutdown URL : https://patchwork.freedesktop.org/series/91345/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10205_full -> Patchwork_20334_full ==

[Intel-gfx] [PATCH 3/6] dma-buf: Document DMA_BUF_IOCTL_SYNC (v2)

2021-06-10 Thread Jason Ekstrand
This adds a new "DMA Buffer ioctls" section to the dma-buf docs and adds documentation for DMA_BUF_IOCTL_SYNC. v2 (Daniel Vetter): - Fix a couple typos - Add commentary about synchronization with other devices - Use item list format for describing flags Signed-off-by: Jason Ekstrand Reviewed-

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for querying hw info that UMDs need

2021-06-10 Thread Patchwork
== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/91353/ State : warning == Summary == $ dim checkpatch origin/drm-tip aec94293496a drm/i915/guc: Add fetch of hwconfig table -:33: WARNING:FILE_PATH_CHANGES: added, moved

Re: [Intel-gfx] [PATCH 4/7] dma-buf: Document DMA_BUF_IOCTL_SYNC

2021-06-10 Thread Jason Ekstrand
On Thu, May 27, 2021 at 5:38 AM Daniel Vetter wrote: > > On Tue, May 25, 2021 at 04:17:50PM -0500, Jason Ekstrand wrote: > > This adds a new "DMA Buffer ioctls" section to the dma-buf docs and adds > > documentation for DMA_BUF_IOCTL_SYNC. > > > > Signed-off-by: Jason Ekstrand > > Cc: Daniel Vett

Re: [Intel-gfx] [PATCH 5/5] DONOTMERGE: dma-buf: Get rid of dma_fence_get_rcu_safe

2021-06-10 Thread Christian König
Am 10.06.21 um 18:37 schrieb Daniel Vetter: On Thu, Jun 10, 2021 at 6:24 PM Jason Ekstrand wrote: On Thu, Jun 10, 2021 at 10:13 AM Daniel Vetter wrote: On Thu, Jun 10, 2021 at 3:59 PM Jason Ekstrand wrote: On Thu, Jun 10, 2021 at 1:51 AM Christian König wrote: Am 09.06.21 um 23:29 schrieb

[Intel-gfx] [PATCH 1/3] drm/i915/guc: Add fetch of hwconfig table

2021-06-10 Thread John . C . Harrison
From: John Harrison Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer. This patch also adds a header file which lists all the attribute values curre

[Intel-gfx] [PATCH 2/3] drm/i915/uapi: Add query for hwconfig table

2021-06-10 Thread John . C . Harrison
From: Rodrigo Vivi GuC contains a consolidated table with a bunch of information about the current device. Previously, this information was spread and hardcoded to all the components including GuC, i915 and various UMDs. The goal here is to consolidate the data into GuC in a way that all interes

[Intel-gfx] [PATCH 0/3] Add support for querying hw info that UMDs need

2021-06-10 Thread John . C . Harrison
From: John Harrison Various UMDs require hardware configuration information about the current platform. A bunch of static information is available in a fixed table that can be retrieved from the GuC. Further information can be calculated dynamically from fuse registers. Signed-off-by: John Harri

[Intel-gfx] [PATCH 3/3] drm/i915/uapi: Add query for L3 bank count

2021-06-10 Thread John . C . Harrison
From: John Harrison Various UMDs need to know the L3 bank count. So add a query API for it. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++ drivers/gpu/drm/i915/gt/intel_gt.h | 1 + drivers/gpu/drm/i915/i915_query.c | 22 ++ drive

Re: [Intel-gfx] [PATCH 0/5] dma-fence, i915: Stop allowing SLAB_TYPESAFE_BY_RCU for dma_fence

2021-06-10 Thread Daniel Vetter
On Thu, Jun 10, 2021 at 10:10 PM Jason Ekstrand wrote: > > On Thu, Jun 10, 2021 at 8:35 AM Jason Ekstrand wrote: > > On Thu, Jun 10, 2021 at 6:30 AM Daniel Vetter > > wrote: > > > On Thu, Jun 10, 2021 at 11:39 AM Christian König > > > wrote: > > > > Am 10.06.21 um 11:29 schrieb Tvrtko Ursulin:

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915/display: Drop FIXME about turn off infoframes"

2021-06-10 Thread Patchwork
== Series Details == Series: Revert "drm/i915/display: Drop FIXME about turn off infoframes" URL : https://patchwork.freedesktop.org/series/91350/ State : success == Summary == CI Bug Log - changes from CI_DRM_10205 -> Patchwork_20337 Summa

Re: [Intel-gfx] [PATCH 0/7] dma-buf: Add an API for exporting sync files (v11)

2021-06-10 Thread Jason Ekstrand
On Thu, Jun 10, 2021 at 3:11 PM Chia-I Wu wrote: > > On Tue, May 25, 2021 at 2:18 PM Jason Ekstrand wrote: > > Modern userspace APIs like Vulkan are built on an explicit > > synchronization model. This doesn't always play nicely with the > > implicit synchronization used in the kernel and assume

Re: [Intel-gfx] [PATCH 0/7] dma-buf: Add an API for exporting sync files (v11)

2021-06-10 Thread Chia-I Wu
On Tue, May 25, 2021 at 2:18 PM Jason Ekstrand wrote: > Modern userspace APIs like Vulkan are built on an explicit > synchronization model. This doesn't always play nicely with the > implicit synchronization used in the kernel and assumed by X11 and > Wayland. The client -> compositor half of th

Re: [Intel-gfx] [PATCH 0/5] dma-fence, i915: Stop allowing SLAB_TYPESAFE_BY_RCU for dma_fence

2021-06-10 Thread Jason Ekstrand
On Thu, Jun 10, 2021 at 8:35 AM Jason Ekstrand wrote: > On Thu, Jun 10, 2021 at 6:30 AM Daniel Vetter wrote: > > On Thu, Jun 10, 2021 at 11:39 AM Christian König > > wrote: > > > Am 10.06.21 um 11:29 schrieb Tvrtko Ursulin: > > > > On 09/06/2021 22:29, Jason Ekstrand wrote: > > > >> > > > >> We'

[Intel-gfx] ✗ Fi.CI.IGT: failure for Revert "drm/i915: Apply Wa_1406680159:icl, ehl as an engine workaround" (rev2)

2021-06-10 Thread Patchwork
== Series Details == Series: Revert "drm/i915: Apply Wa_1406680159:icl, ehl as an engine workaround" (rev2) URL : https://patchwork.freedesktop.org/series/91325/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10205_full -> Patchwork_20333_full =

Re: [Intel-gfx] Strange hugepages result?

2021-06-10 Thread Matthew Auld
Hi, On Thu, 10 Jun 2021 at 20:02, Thomas Hellström wrote: > > Hi, Matthew! > > I got a funny result from the hugepages selftest when trying to break > out some functionality from shmem to make a ttm page pool for > cached-only TTM system bos. > > It turns out that shmem computed the pagesizes usi

[Intel-gfx] ✓ Fi.CI.BAT: success for Pipe DMC Support (rev6)

2021-06-10 Thread Patchwork
== Series Details == Series: Pipe DMC Support (rev6) URL : https://patchwork.freedesktop.org/series/90445/ State : success == Summary == CI Bug Log - changes from CI_DRM_10205 -> Patchwork_20336 Summary --- **SUCCESS** No regressi

Re: [Intel-gfx] Computation of return value being discarded in get_cpu_power() in drivers/platform/x86/intel_ips.c

2021-06-10 Thread Jesse Barnes
Arg html email sorry. Resending plain text: It may be ok to drop this driver entirely now too; I doubt anyone is relying on GPU turbo in Ironlake for anything critical anymore. That would allow for some simplifications in i915 too if it's still supported. On Thu, Jun 10, 2021 at 4:56 AM Joonas

Re: [Intel-gfx] Computation of return value being discarded in get_cpu_power() in drivers/platform/x86/intel_ips.c

2021-06-10 Thread Jesse Barnes
It may be ok to drop this driver entirely now too; I doubt anyone is relying on GPU turbo in Ironlake for anything critical anymore. That would allow for some simplifications in i915 too if it's still supported. Jesse On Thu, Jun 10, 2021 at 4:56 AM Joonas Lahtinen < joonas.lahti...@linux.intel.

[Intel-gfx] [PATCH] Revert "drm/i915/display: Drop FIXME about turn off infoframes"

2021-06-10 Thread José Roberto de Souza
Looks this FIXME is still valid as we need a way to tell LSPCON to stop sending infoframes, so reverting it. This reverts commit 3f409e4cd579b287a6c41d017e62c392f7997193. Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + 1 file changed,

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Pipe DMC Support (rev6)

2021-06-10 Thread Patchwork
== Series Details == Series: Pipe DMC Support (rev6) URL : https://patchwork.freedesktop.org/series/90445/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/display/intel_disp

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Pipe DMC Support (rev6)

2021-06-10 Thread Patchwork
== Series Details == Series: Pipe DMC Support (rev6) URL : https://patchwork.freedesktop.org/series/90445/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7f3a0ee96dbc drm/i915/dmc: Introduce DMC_FW_MAIN 89e00e964d4c drm/i915/xelpd: Pipe A DMC plugging -:48: WARNING:LONG_LINE: li

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbc: Clean up cfb allocation code

2021-06-10 Thread Patchwork
== Series Details == Series: drm/i915/fbc: Clean up cfb allocation code URL : https://patchwork.freedesktop.org/series/91347/ State : success == Summary == CI Bug Log - changes from CI_DRM_10205 -> Patchwork_20335 Summary --- **SUCCE

[Intel-gfx] [CI 4/4] drm/i915/adl_p: Load DMC

2021-06-10 Thread Anusha Srivatsa
Load DMC v2.10 on ADLP. The release notes mention that this version enables few power savings features. v2: Add DMC_PATH() for ADLP (Lucas) Cc: Lucas De Marchi Cc: Clint Taylor Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 10 +- 1 file changed, 9 inser

[Intel-gfx] [CI 3/4] drm/i915/adl_p: Pipe B DMC Support

2021-06-10 Thread Anusha Srivatsa
ADLP requires us to load both Pipe A and Pipe B. Plug Pipe B loading support. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 ++ drivers/gpu/drm/i915/display/intel_dmc.h | 1 + 2 files cha

[Intel-gfx] [CI 1/4] drm/i915/dmc: Introduce DMC_FW_MAIN

2021-06-10 Thread Anusha Srivatsa
This is a prep patch for Pipe DMC plugging. Add dmc_info struct in intel_dmc to have all common fields shared between all DMC's in the package. Add DMC_FW_MAIN(dmc_id 0) to refer to the blob. v2: Remove dmc_offset and start_mmioaddr from dmc_info struct (Jose) Cc: Souza, Jose Signed-off-by: Anu

[Intel-gfx] [CI 2/4] drm/i915/xelpd: Pipe A DMC plugging

2021-06-10 Thread Anusha Srivatsa
This patch adds Pipe A plumbing to the already existing parsing and loading functions which is taken care of in the prep patches. Adding MAX_DMC_FW to keep track for both Main and Pipe A DMC while loading the respective blobs. Also adding present field in dmc_info. s/find_dmc_fw_offset/csr_set_dmc

[Intel-gfx] [CI 0/4] Pipe DMC Support

2021-06-10 Thread Anusha Srivatsa
With all DMC cleanup patches merged, sending the rebased version of actual Pipe DMC bits. One change from previous verison is a fix of SKL regression. Corner cases for stepping-substepping combination was missing from fw_info_matches_stepping() helper. Luckily SKL was the only platform in CI that

[Intel-gfx] Strange hugepages result?

2021-06-10 Thread Thomas Hellström
Hi, Matthew! I got a funny result from the hugepages selftest when trying to break out some functionality from shmem to make a ttm page pool for cached-only TTM system bos. It turns out that shmem computed the pagesizes using the underlying pages rather than the dma segments, so when I chang

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/fbc: Clean up cfb allocation code

2021-06-10 Thread Patchwork
== Series Details == Series: drm/i915/fbc: Clean up cfb allocation code URL : https://patchwork.freedesktop.org/series/91347/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Force a TypeC PHY disconnect during suspend/shutdown

2021-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Force a TypeC PHY disconnect during suspend/shutdown URL : https://patchwork.freedesktop.org/series/91345/ State : success == Summary == CI Bug Log - changes from CI_DRM_10205 -> Patchwork_20334 Summar

[Intel-gfx] [PATCH 9/9] drm/i915/fbc: Allocate llb before cfb

2021-06-10 Thread Ville Syrjala
From: Ville Syrjälä Since the llb allocation has a fixed size, let's grab it before the potentially variable sized cfb. That should avoid some allocation failure cases once we allow different compression ratios for FBC1. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbc.c

[Intel-gfx] [PATCH 7/9] drm/i915/fbc: Extract intel_fbc_stolen_end()

2021-06-10 Thread Ville Syrjala
From: Ville Syrjälä Declutter find_compression_limit() a bit by extracting intel_fbc_stolen_end(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbc.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/display/int

[Intel-gfx] [PATCH 8/9] drm/i915/fbc: Make the cfb allocation loop a bit more legible

2021-06-10 Thread Ville Syrjala
From: Ville Syrjälä Write the cfb allocation loop as an actual loop instead of some hard to read goto thing. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbc.c | 51 1 file changed, 26 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/

[Intel-gfx] [PATCH 6/9] drm/i915/fbc: Introduce g4x_dpfc_ctl_limit()

2021-06-10 Thread Ville Syrjala
From: Ville Syrjälä Exctract the limit->register value conversion into a common helper. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbc.c | 58 ++-- 1 file changed, 25 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fb

[Intel-gfx] [PATCH 5/9] drm/i915/fbc: Handle 16bpp compression limit better

2021-06-10 Thread Ville Syrjala
From: Ville Syrjälä The limit++ for the 16bpp case is nonsense since the compression limit is always supposed to be power of two. Replace it with <<=1. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --

[Intel-gfx] [PATCH 4/9] drm/i915/fbc: Don't pass around the mm node

2021-06-10 Thread Ville Syrjala
From: Ville Syrjälä No point in passing the mm node explicitly to find_compression_limit() since it's always the same node for the cfb. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbc.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH 3/9] drm/i915/fbc: Embed the compressed_llb node

2021-06-10 Thread Ville Syrjala
From: Ville Syrjälä Not much point in dynamically allocating the line length buffer mm node that I can see. Just embed it directly like we do the for the cfb node. One less failure point to worry about. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbc.c | 29

[Intel-gfx] [PATCH 2/9] drm/i915/fbc: Extract intel_fbc_program_cfb()

2021-06-10 Thread Ville Syrjala
From: Ville Syrjälä Extract the CFB (+LLB) programming into a separate function. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbc.c | 46 ++-- 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/

[Intel-gfx] [PATCH 1/9] drm/i915/fbc: s/threshold/limit/

2021-06-10 Thread Ville Syrjala
From: Ville Syrjälä Let's call the compression limit the limit. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbc.c | 50 drivers/gpu/drm/i915/i915_drv.h | 3 +- 2 files changed, 27 insertions(+), 26 deletions(-) diff --git a/drivers/gp

[Intel-gfx] [PATCH 0/9] drm/i915/fbc: Clean up cfb allocation code

2021-06-10 Thread Ville Syrjala
From: Ville Syrjälä I need to tweak the cfb stride/size handling a bit the current cfb allocation code is too messy to make that easy. Start by cleaning stuff up. Ville Syrjälä (9): drm/i915/fbc: s/threshold/limit/ drm/i915/fbc: Extract intel_fbc_program_cfb() drm/i915/fbc: Embed the comp

Re: [Intel-gfx] [PATCH] drm/i915: Fix parenthesis and dbuf condition

2021-06-10 Thread Matt Roper
On Thu, Jun 10, 2021 at 10:02:13AM +0300, Stanislav Lisovskiy wrote: > Removed excessive parenthesis and placed && on > previous line in DBUF state checker. > > Signed-off-by: Stanislav Lisovskiy Reviewed-by: Matt Roper Minor nit: you probably want "parentheses" in the subject and commit mess

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Force a TypeC PHY disconnect during suspend/shutdown

2021-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Force a TypeC PHY disconnect during suspend/shutdown URL : https://patchwork.freedesktop.org/series/91345/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +dr

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/display: Drop FIXME about turn off infoframes

2021-06-10 Thread Souza, Jose
On Thu, 2021-06-10 at 15:18 +0300, Ville Syrjälä wrote: > On Wed, Jun 09, 2021 at 07:25:36PM +, Souza, Jose wrote: > > On Tue, 2021-06-08 at 10:26 +0300, Ville Syrjälä wrote: > > > On Fri, May 14, 2021 at 04:22:47PM -0700, José Roberto de Souza wrote: > > > > intel_dp_set_infoframes() call in i

[Intel-gfx] [PATCH] drm/i915: Force a TypeC PHY disconnect during suspend/shutdown

2021-06-10 Thread Imre Deak
Disconnect TypeC PHYs during system suspend and shutdown, even with the corresponding TypeC sink still plugged to its connector, since leaving the PHY connected causes havoc at least during system resume in the presence of an Nvidia card. Note that this will only make a difference in the TypeC DP

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915: Apply Wa_1406680159:icl, ehl as an engine workaround" (rev2)

2021-06-10 Thread Patchwork
== Series Details == Series: Revert "drm/i915: Apply Wa_1406680159:icl, ehl as an engine workaround" (rev2) URL : https://patchwork.freedesktop.org/series/91325/ State : success == Summary == CI Bug Log - changes from CI_DRM_10205 -> Patchwork_20333 ===

[Intel-gfx] [PULL] drm-misc-fixes

2021-06-10 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-fixes PR Thanks! Maxime drm-misc-fixes-2021-06-10: One fix for snu4i that prevents it from probing, two locking fixes for ttm and drm_auth, one off-by-x1000 fix for mcde and a fix for vc4 to prevent an out-of-bounds access. The following changes since c

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Simplify userptr locking (rev3)

2021-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Simplify userptr locking (rev3) URL : https://patchwork.freedesktop.org/series/88974/ State : success == Summary == CI Bug Log - changes from CI_DRM_10204_full -> Patchwork_20332_full Summary ---

Re: [Intel-gfx] [PATCH v2 1/7] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-06-10 Thread Maxime Ripard
Hi, On Wed, Jun 09, 2021 at 09:23:27PM +, Simon Ser wrote: > This function sends a hotplug uevent with a CONNECTOR property. > > Signed-off-by: Simon Ser > --- > drivers/gpu/drm/drm_sysfs.c | 25 + > include/drm/drm_sysfs.h | 1 + > 2 files changed, 26 insertion

Re: [Intel-gfx] [PATCH 5/5] DONOTMERGE: dma-buf: Get rid of dma_fence_get_rcu_safe

2021-06-10 Thread Daniel Vetter
On Thu, Jun 10, 2021 at 06:54:13PM +0200, Christian König wrote: > Am 10.06.21 um 18:37 schrieb Daniel Vetter: > > On Thu, Jun 10, 2021 at 6:24 PM Jason Ekstrand wrote: > > > On Thu, Jun 10, 2021 at 10:13 AM Daniel Vetter > > > wrote: > > > > On Thu, Jun 10, 2021 at 3:59 PM Jason Ekstrand > >

Re: [Intel-gfx] [PATCH 5/5] DONOTMERGE: dma-buf: Get rid of dma_fence_get_rcu_safe

2021-06-10 Thread Daniel Vetter
On Thu, Jun 10, 2021 at 11:52:23AM -0500, Jason Ekstrand wrote: > On Thu, Jun 10, 2021 at 11:38 AM Daniel Vetter wrote: > > > > On Thu, Jun 10, 2021 at 6:24 PM Jason Ekstrand wrote: > > > > > > On Thu, Jun 10, 2021 at 10:13 AM Daniel Vetter > > > wrote: > > > > > > > > On Thu, Jun 10, 2021 at 3

Re: [Intel-gfx] [PATCH 16/31] drm/i915/gem: Add an intermediate proto_context struct (v4)

2021-06-10 Thread Jason Ekstrand
On Thu, Jun 10, 2021 at 11:44 AM Daniel Vetter wrote: > > On Wed, Jun 09, 2021 at 11:00:26AM -0500, Jason Ekstrand wrote: > > On Wed, Jun 9, 2021 at 6:28 AM Daniel Vetter wrote: > > > > > > On Tue, Jun 08, 2021 at 11:35:58PM -0500, Jason Ekstrand wrote: > > > > The current context uAPI allows for

Re: [Intel-gfx] [PATCH 5/5] DONOTMERGE: dma-buf: Get rid of dma_fence_get_rcu_safe

2021-06-10 Thread Jason Ekstrand
On Thu, Jun 10, 2021 at 11:38 AM Daniel Vetter wrote: > > On Thu, Jun 10, 2021 at 6:24 PM Jason Ekstrand wrote: > > > > On Thu, Jun 10, 2021 at 10:13 AM Daniel Vetter > > wrote: > > > > > > On Thu, Jun 10, 2021 at 3:59 PM Jason Ekstrand > > > wrote: > > > > > > > > On Thu, Jun 10, 2021 at 1:5

Re: [Intel-gfx] [PATCH 16/31] drm/i915/gem: Add an intermediate proto_context struct (v4)

2021-06-10 Thread Daniel Vetter
On Wed, Jun 09, 2021 at 11:00:26AM -0500, Jason Ekstrand wrote: > On Wed, Jun 9, 2021 at 6:28 AM Daniel Vetter wrote: > > > > On Tue, Jun 08, 2021 at 11:35:58PM -0500, Jason Ekstrand wrote: > > > The current context uAPI allows for two methods of setting context > > > parameters: SET_CONTEXT_PARAM

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Apply Wa_1406680159:icl, ehl as an engine workaround"

2021-06-10 Thread Matt Roper
On Thu, Jun 10, 2021 at 03:16:58PM +0530, Tejas Upadhyay wrote: > This reverts commit fb899dd8ea9c4ac5928b86946e6536790981adae. > > w/a on mentioned platforms not working as expected and causing > more harm on the RC6 flow. > > Fixes: fb899dd8ea9c ("drm/i915: Apply Wa_1406680159:icl,ehl as an eng

Re: [Intel-gfx] [PATCH 5/5] DONOTMERGE: dma-buf: Get rid of dma_fence_get_rcu_safe

2021-06-10 Thread Daniel Vetter
On Thu, Jun 10, 2021 at 6:24 PM Jason Ekstrand wrote: > > On Thu, Jun 10, 2021 at 10:13 AM Daniel Vetter wrote: > > > > On Thu, Jun 10, 2021 at 3:59 PM Jason Ekstrand wrote: > > > > > > On Thu, Jun 10, 2021 at 1:51 AM Christian König > > > wrote: > > > > > > > > Am 09.06.21 um 23:29 schrieb Jas

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Move intel_engine_free_request_pool to i915_request.c

2021-06-10 Thread Jason Ekstrand
On Thu, Jun 10, 2021 at 10:07 AM Tvrtko Ursulin wrote: > > On 10/06/2021 14:57, Jason Ekstrand wrote: > > On Thu, Jun 10, 2021 at 5:04 AM Tvrtko Ursulin > > wrote: > >> > >> On 09/06/2021 22:29, Jason Ekstrand wrote: > >>> This appears to break encapsulation by moving an intel_engine_cs > >>> fun

[Intel-gfx] ✓ Fi.CI.IGT: success for Move LMEM (VRAM) management over to TTM (rev8)

2021-06-10 Thread Patchwork
== Series Details == Series: Move LMEM (VRAM) management over to TTM (rev8) URL : https://patchwork.freedesktop.org/series/90681/ State : success == Summary == CI Bug Log - changes from CI_DRM_10204_full -> Patchwork_20331_full Summary

Re: [Intel-gfx] [PATCH 5/5] DONOTMERGE: dma-buf: Get rid of dma_fence_get_rcu_safe

2021-06-10 Thread Jason Ekstrand
On Thu, Jun 10, 2021 at 10:13 AM Daniel Vetter wrote: > > On Thu, Jun 10, 2021 at 3:59 PM Jason Ekstrand wrote: > > > > On Thu, Jun 10, 2021 at 1:51 AM Christian König > > wrote: > > > > > > Am 09.06.21 um 23:29 schrieb Jason Ekstrand: > > > > This helper existed to handle the weird corner-cases

Re: [Intel-gfx] Computation of return value being discarded in get_cpu_power() in drivers/platform/x86/intel_ips.c

2021-06-10 Thread Hans de Goede
Hi, On 6/10/21 1:55 PM, Joonas Lahtinen wrote: > (Address for Hans was corrupt in previous message, which confused my mail > client. Sorry for duplicate message, the other is without From: field). > > + Jesse > > Quoting Colin Ian King (2021-06-09 14:50:07) >> Hi, >> >> I was reviewing some old

Re: [Intel-gfx] [RFC PATCH 36/97] drm/i915/guc: Add non blocking CTB send function

2021-06-10 Thread Daniel Vetter
On Wed, Jun 09, 2021 at 04:10:23PM -0700, Matthew Brost wrote: > On Tue, Jun 08, 2021 at 10:46:15AM +0200, Daniel Vetter wrote: > > On Tue, Jun 8, 2021 at 10:39 AM Tvrtko Ursulin > > wrote: > > > > > > > > > On 07/06/2021 18:31, Matthew Brost wrote: > > > > On Thu, May 27, 2021 at 04:11:50PM +0100

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Simplify userptr locking (rev3)

2021-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Simplify userptr locking (rev3) URL : https://patchwork.freedesktop.org/series/88974/ State : success == Summary == CI Bug Log - changes from CI_DRM_10204 -> Patchwork_20332 Summary --- **SUCCES

Re: [Intel-gfx] [PATCH 5/5] DONOTMERGE: dma-buf: Get rid of dma_fence_get_rcu_safe

2021-06-10 Thread Daniel Vetter
On Thu, Jun 10, 2021 at 3:59 PM Jason Ekstrand wrote: > > On Thu, Jun 10, 2021 at 1:51 AM Christian König > wrote: > > > > Am 09.06.21 um 23:29 schrieb Jason Ekstrand: > > > This helper existed to handle the weird corner-cases caused by using > > > SLAB_TYPESAFE_BY_RCU for backing dma_fence. Now

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Move intel_engine_free_request_pool to i915_request.c

2021-06-10 Thread Tvrtko Ursulin
On 10/06/2021 14:57, Jason Ekstrand wrote: On Thu, Jun 10, 2021 at 5:04 AM Tvrtko Ursulin wrote: On 09/06/2021 22:29, Jason Ekstrand wrote: This appears to break encapsulation by moving an intel_engine_cs function to a i915_request file. However, this function is intrinsically tied to the

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add relocation exceptions for two other platforms (rev5)

2021-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Add relocation exceptions for two other platforms (rev5) URL : https://patchwork.freedesktop.org/series/89594/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10204_full -> Patchwork_20330_full ==

  1   2   >