[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Get rid of fence error propagation (rev3)

2021-07-10 Thread Patchwork
== Series Details == Series: drm/i915: Get rid of fence error propagation (rev3) URL : https://patchwork.freedesktop.org/series/90891/ State : failure == Summary == Couldn't find any build artifact matching "Test-with: Test-with: 20210711035204.802908-1-ja...@jlekstrand.net" Check that the ms

[Intel-gfx] [PATCH 5/5] Revert "drm/i915: Skip over MI_NOOP when parsing"

2021-07-10 Thread Jason Ekstrand
This reverts a6c5e2aea704 ("drm/i915: Skip over MI_NOOP when parsing"). It complicates the batch parsing code a bit and increases indentation for no reason other than fast-skipping a command that userspace uses only rarely. Sure, there may be IGT tests that fill batches with NOOPs but that's not a

[Intel-gfx] [PATCH 2/5] Revert "drm/i915: Propagate errors on awaiting already signaled fences"

2021-07-10 Thread Jason Ekstrand
This reverts commit 9e31c1fe45d555a948ff66f1f0e3fe1f83ca63f7. Ever since that commit, we've been having issues where a hang in one client can propagate to another. In particular, a hang in an app can propagate to the X server which causes the whole desktop to lock up. Error propagation along fen

[Intel-gfx] [PATCH 4/5] drm/i915: Drop error handling from dma_fence_work

2021-07-10 Thread Jason Ekstrand
Asynchronous command parsing was the only thing which ever returned a non-zero error. With that gone, we can drop the error handling from dma_fence_work. Signed-off-by: Jason Ekstrand Reviewed-by: Jon Bloomfield Acked-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_clflush.c | 4 +---

[Intel-gfx] [PATCH 3/5] drm/i915: Remove allow_alloc from i915_gem_object_get_sg*

2021-07-10 Thread Jason Ekstrand
This reverts the rest of 0edbb9ba1bfe ("drm/i915: Move cmd parser pinning to execbuffer"). Now that the only user of i915_gem_object_get_sg without allow_alloc has been removed, we can drop the parameter. This portion of the revert was broken into its own patch to aid review. Signed-off-by: Jaso

[Intel-gfx] [PATCH 1/5] drm/i915: Revert "drm/i915/gem: Asynchronous cmdparser"

2021-07-10 Thread Jason Ekstrand
This reverts 686c7c35abc2 ("drm/i915/gem: Asynchronous cmdparser"). The justification for this commit in the git history was a vague comment about getting it out from under the struct_mutex. While this may improve perf for some workloads on Gen7 platforms where we rely on the command parser for f

[Intel-gfx] [PATCH 0/5] drm/i915: Get rid of fence error propagation (v2)

2021-07-10 Thread Jason Ekstrand
Fence error propagation is sketchy at best. Instead of explicitly handling fences which might have errors set in the code which is aware of errors, we just kick them down the line and hope that userspace knows what to do when a wait eventually fails. This is sketchy at best because most userspace

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Better document VM and engine set APIs

2021-07-10 Thread Patchwork
== Series Details == Series: drm/i915: Better document VM and engine set APIs URL : https://patchwork.freedesktop.org/series/92403/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10330_full -> Patchwork_20569_full Summary --

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Better document VM and engine set APIs

2021-07-10 Thread Patchwork
== Series Details == Series: drm/i915: Better document VM and engine set APIs URL : https://patchwork.freedesktop.org/series/92403/ State : success == Summary == CI Bug Log - changes from CI_DRM_10330 -> Patchwork_20569 Summary --- *

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Better document VM and engine set APIs

2021-07-10 Thread Patchwork
== Series Details == Series: drm/i915: Better document VM and engine set APIs URL : https://patchwork.freedesktop.org/series/92403/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7e293cab2b16 drm/i915: Don't allow setting I915_CONTEXT_PARAM_VM twice bb17bb50227a drm/i915/uapi: A

[Intel-gfx] [PATCH 2/2] drm/i915/uapi: Add docs about immutability of engine sets and VMs

2021-07-10 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: Daniel Vetter --- include/uapi/drm/i915_drm.h | 39 ++--- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h index e334a8b14ef2d..b6bfbda1258c8 100644 --- a/in

[Intel-gfx] [PATCH 1/2] drm/i915: Don't allow setting I915_CONTEXT_PARAM_VM twice

2021-07-10 Thread Jason Ekstrand
Allowing setting it multiple times brings no real utility to the API, no userspace relies on it, and it does make i915 a tiny bit more complicated. Let's disallow it for now unless someone comes up with a compelling reason to support it. Signed-off-by: Jason Ekstrand Cc: Daniel Vetter --- driv

[Intel-gfx] [PATCH 0/2] drm/i915: Better document VM and engine set APIs

2021-07-10 Thread Jason Ekstrand
As per Daniel's request, this better documents the VM and engine set APIs including some discussion of the deprecation plan. Test-with: 20210710211923.784638-1-ja...@jlekstrand.net Cc: Daniel Vetter Jason Ekstrand (2): drm/i915: Don't allow setting I915_CONTEXT_PARAM_VM twice drm/i915/uapi:

[Intel-gfx] ✗ Fi.CI.IGT: failure for Minor revid/stepping and workaround cleanup (rev2)

2021-07-10 Thread Patchwork
== Series Details == Series: Minor revid/stepping and workaround cleanup (rev2) URL : https://patchwork.freedesktop.org/series/92299/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10329_full -> Patchwork_20568_full Summary

Re: [Intel-gfx] [PATCH 43/47] drm/i915/guc: Hook GuC scheduling policies up

2021-07-10 Thread Matthew Brost
On Fri, Jun 25, 2021 at 12:10:46PM -0700, John Harrison wrote: > On 6/24/2021 17:59, Matthew Brost wrote: > > On Thu, Jun 24, 2021 at 12:05:12AM -0700, Matthew Brost wrote: > > > From: John Harrison > > > > > > Use the official driver default scheduling policies for configuring > > > the GuC sche

Re: [Intel-gfx] [PATCH 16/16] drm/i915/guc/rc: Setup and enable GUCRC feature

2021-07-10 Thread Michal Wajdeczko
On 10.07.2021 03:20, Vinay Belgaumkar wrote: > This feature hands over the control of HW RC6 to the GUC. > GUC decides when to put HW into RC6 based on it's internal > busyness algorithms. > > GUCRC needs GUC submission to be enabled, and only > supported on Gen12+ for now. > > When GUCRC is en

Re: [Intel-gfx] [PATCH 15/16] drm/i915/guc/slpc: slpc selftest

2021-07-10 Thread Michal Wajdeczko
On 10.07.2021 03:20, Vinay Belgaumkar wrote: > Tests that exercise the slpc get/set frequency interfaces. > > Clamp_max will set max frequency to multiple levels and check > that slpc requests frequency lower than or equal to it. > > Clamp_min will set min frequency to different levels and chec

Re: [Intel-gfx] [PATCH 14/16] drm/i915/guc/slpc: Sysfs hooks for slpc

2021-07-10 Thread Michal Wajdeczko
On 10.07.2021 03:20, Vinay Belgaumkar wrote: > Update the get/set min/max freq hooks to work for > slpc case as well. Consolidate helpers for requested/min/max > frequency get/set to intel_rps where the proper action can > be taken depending on whether slpc is enabled. 2x s/slpc/SLPC > > Sign

Re: [Intel-gfx] [PATCH 12/16] drm/i915/guc/slpc: Cache platform frequency limits for slpc

2021-07-10 Thread Michal Wajdeczko
On 10.07.2021 03:20, Vinay Belgaumkar wrote: > Cache rp0, rp1 and rpn platform limits into slpc structure > for range checking while setting min/max frequencies. > > Also add "soft" limits which keep track of frequency changes > made from userland. These are initially set to platform min > and

Re: [Intel-gfx] [PATCH 10/16] drm/i915/guc/slpc: Add debugfs for slpc info

2021-07-10 Thread Michal Wajdeczko
On 10.07.2021 03:20, Vinay Belgaumkar wrote: > This prints out relevant SLPC info from the SLPC shared structure. > > We will send a h2g message which forces SLPC to update the > shared data structure with latest information before reading it. > > Signed-off-by: Vinay Belgaumkar > Signed-off-

Re: [Intel-gfx] [PATCH 09/16] drm/i915/guc/slpc: Add get max/min freq hooks

2021-07-10 Thread Michal Wajdeczko
On 10.07.2021 03:20, Vinay Belgaumkar wrote: > Add helpers to read the min/max frequency being used > by SLPC. This is done by send a h2g command which forces s/h2g/H2G > SLPC to update the shared data struct which can then be > read. > > Signed-off-by: Vinay Belgaumkar > Signed-off-by: Sund

Re: [Intel-gfx] [PATCH 08/16] drm/i915/guc/slpc: Add methods to set min/max frequency

2021-07-10 Thread Michal Wajdeczko
On 10.07.2021 03:20, Vinay Belgaumkar wrote: > Add param set h2g helpers to set the min and max frequencies > for use by SLPC. > > Signed-off-by: Sundaresan Sujaritha > Signed-off-by: Vinay Belgaumkar > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 94 + > drivers/g

Re: [Intel-gfx] [PATCH 07/16] drm/i915/guc/slpc: Enable slpc and add related H2G events

2021-07-10 Thread Michal Wajdeczko
On 10.07.2021 03:20, Vinay Belgaumkar wrote: > Add methods for interacting with guc for enabling SLPC. Enable > SLPC after guc submission has been established. GuC load will s/guc/GuC > fail if SLPC cannot be successfully initialized. Add various > helper methods to set/unset the parameters fo

Re: [Intel-gfx] [PATCH 06/16] drm/i915/guc/slpc: Allocate, initialize and release slpc

2021-07-10 Thread Michal Wajdeczko
On 10.07.2021 03:20, Vinay Belgaumkar wrote: > Allocate data structures for SLPC and functions for > initializing on host side. > > Signed-off-by: Vinay Belgaumkar > Signed-off-by: Sundaresan Sujaritha > --- > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 11 +++ > drivers/gpu/drm/i915/gt

Re: [Intel-gfx] [PATCH 05/16] drm/i915/guc/slpc: Adding slpc communication interfaces

2021-07-10 Thread Michal Wajdeczko
On 10.07.2021 03:20, Vinay Belgaumkar wrote: > Replicate the SLPC header file in GuC for the most part. There are what you mean by "replicate" here? > some SLPC mode based parameters which haven't been included since > we are not using them. > > Signed-off-by: Vinay Belgaumkar > Signed-off-by

Re: [Intel-gfx] [PATCH 04/16] drm/i915/guc/slpc: Lay out slpc init/enable/disable/fini

2021-07-10 Thread Michal Wajdeczko
On 10.07.2021 03:20, Vinay Belgaumkar wrote: > Declare header and source files for SLPC, along with init and > enable/disable function templates. later you claim that "disable" is not needed > > Signed-off-by: Vinay Belgaumkar > Signed-off-by: Sundaresan Sujaritha > --- > drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH 02/16] drm/i915/guc/slpc: Initial definitions for slpc

2021-07-10 Thread Michal Wajdeczko
Hi Vinay, On 10.07.2021 03:20, Vinay Belgaumkar wrote: > Add macros to check for slpc support. This feature is currently supported > for gen12+ and enabled whenever guc submission is enabled/selected. please try to use consistent names across all patches: s/slpc/SLPC s/gen12/Gen12 s/guc/GuC >

Re: [Intel-gfx] [PATCH 14/16] drm/i915/guc/slpc: Sysfs hooks for slpc

2021-07-10 Thread kernel test robot
, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Vinay-Belgaumkar/Enable-GuC-based-power-management-features/20210710-092520 base: git://anongit.freed

[Intel-gfx] ✗ Fi.CI.IGT: failure for iommu/vt-d: Disable igfx iommu superpage on bxt/skl/glk

2021-07-10 Thread Patchwork
== Series Details == Series: iommu/vt-d: Disable igfx iommu superpage on bxt/skl/glk URL : https://patchwork.freedesktop.org/series/92374/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10326_full -> Patchwork_20566_full Sum

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ehl: unconditionally flush the pages on acquire (rev2)

2021-07-10 Thread Patchwork
== Series Details == Series: drm/i915/ehl: unconditionally flush the pages on acquire (rev2) URL : https://patchwork.freedesktop.org/series/92367/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10326_full -> Patchwork_20564_full =

Re: [Intel-gfx] [PATCH 14/16] drm/i915/guc/slpc: Sysfs hooks for slpc

2021-07-10 Thread kernel test robot
, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Vinay-Belgaumkar/Enable-GuC-based-power-management-features/20210710-092520 base: git://anongit.freed

[Intel-gfx] [RFC PATCH] drm/i915/guc/slpc: intel_rps_read_punit_req() can be static

2021-07-10 Thread kernel test robot
drivers/gpu/drm/i915/gt/intel_rps.c:1969:5: warning: symbol 'intel_rps_read_punit_req' was not declared. Should it be static? drivers/gpu/drm/i915/gt/intel_rps.c:1978:5: warning: symbol 'intel_rps_get_req' was not declared. Should it be static? Reported-by: kernel test robot Signed-off-by: kern