Re: [Intel-gfx] [PATCH v2] drm/i915/display: split DISPLAY_VER 9 and 10 in intel_setup_outputs()

2021-07-22 Thread Matt Roper
On Thu, Jul 22, 2021 at 04:29:22PM -0700, Lucas De Marchi wrote: > Commit 5a9d38b20a5a ("drm/i915/display: hide workaround for broken vbt > in intel_bios.c") moved the workaround for broken or missing VBT to > intel_bios.c. However is_port_valid() only protects the handling of > different skus of

[Intel-gfx] [PATCH v2 2/2] drm/i915/adl_p: Add ddi buf translation tables for combo PHY

2021-07-22 Thread Matt Roper
ADL-P now has its own set of DDI buf translation tables (except for eDP which appears to be the same as TGL). Add the new values (last updated in bspec 2021-07-22) to the driver. v2: - Actually hook up the new tables via encoder->get_buf_trans() Bspec: 49291 Signed-off-by: Matt Roper ---

[Intel-gfx] [PATCH 1/2] drm/i915/adl_s: Update ddi buf translation tables

2021-07-22 Thread Matt Roper
The hardware team updates the translation tables on 2021-06-23. Let's update the driver accordingly. Bspec: 49291 Signed-off-by: Matt Roper --- .../drm/i915/display/intel_ddi_buf_trans.c| 44 +-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git

[Intel-gfx] [PATCH 0/2] ADL DDI translation buffer updates

2021-07-22 Thread Matt Roper
Both ADL-S and ADL-P have had some updates to their combo PHY DDI buf translation tables. Matt Roper (2): drm/i915/adl_s: Update ddi buf translation tables drm/i915/adl_p: Add ddi buf translation tables for combo PHY .../drm/i915/display/intel_ddi_buf_trans.c| 148 +++--- 1

[Intel-gfx] [PATCH 2/2] drm/i915/adl_p: Add ddi buf translation tables for combo PHY

2021-07-22 Thread Matt Roper
ADL-P now has its own set of DDI buf translation tables (except for eDP which appears to be the same as TGL). Add the new values (last updated in bspec 2021-07-22) to the driver. Bspec: 49291 Signed-off-by: Matt Roper --- .../drm/i915/display/intel_ddi_buf_trans.c| 104 ++

[Intel-gfx] ✗ Fi.CI.IGT: failure for Remaining patches for basic GuC submission

2021-07-22 Thread Patchwork
== Series Details == Series: Remaining patches for basic GuC submission URL : https://patchwork.freedesktop.org/series/92912/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10374_full -> Patchwork_20686_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: nuke gen6_hw_id

2021-07-22 Thread Patchwork
== Series Details == Series: drm/i915/gt: nuke gen6_hw_id URL : https://patchwork.freedesktop.org/series/92916/ State : success == Summary == CI Bug Log - changes from CI_DRM_10376 -> Patchwork_20687 Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: split DISPLAY_VER 9 and 10 in intel_setup_outputs() (rev2)

2021-07-22 Thread Patchwork
== Series Details == Series: drm/i915/display: split DISPLAY_VER 9 and 10 in intel_setup_outputs() (rev2) URL : https://patchwork.freedesktop.org/series/92902/ State : success == Summary == CI Bug Log - changes from CI_DRM_10373_full -> Patchwork_20685_full

[Intel-gfx] ✓ Fi.CI.BAT: success for Remaining patches for basic GuC submission

2021-07-22 Thread Patchwork
== Series Details == Series: Remaining patches for basic GuC submission URL : https://patchwork.freedesktop.org/series/92912/ State : success == Summary == CI Bug Log - changes from CI_DRM_10374 -> Patchwork_20686 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Remaining patches for basic GuC submission

2021-07-22 Thread Patchwork
== Series Details == Series: Remaining patches for basic GuC submission URL : https://patchwork.freedesktop.org/series/92912/ State : warning == Summary == $ dim checkpatch origin/drm-tip c4c2a95bc42c drm/i915/guc: GuC virtual engines -:595: CHECK:LINE_SPACING: Please don't use multiple blank

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Extend Wa_1406941453 to adl-p

2021-07-22 Thread Patchwork
== Series Details == Series: drm/i915: Extend Wa_1406941453 to adl-p URL : https://patchwork.freedesktop.org/series/92905/ State : success == Summary == CI Bug Log - changes from CI_DRM_10373_full -> Patchwork_20684_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: split DISPLAY_VER 9 and 10 in intel_setup_outputs() (rev2)

2021-07-22 Thread Patchwork
== Series Details == Series: drm/i915/display: split DISPLAY_VER 9 and 10 in intel_setup_outputs() (rev2) URL : https://patchwork.freedesktop.org/series/92902/ State : success == Summary == CI Bug Log - changes from CI_DRM_10373 -> Patchwork_20685

[Intel-gfx] [PATCH v2] drm/i915/gt: nuke gen6_hw_id

2021-07-22 Thread Lucas De Marchi
This is only used by GRAPHICS_VER == 6 and GRAPHICS_VER == 7. All other recent platforms do not depend on this field, so it doesn't make much sense to keep it generic like that. Instead, just do a mapping from engine class to HW ID in the single place that is needed. v2: use macros with the

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/10] drm/i915/bios: Allow DSI ports to be parsed by parse_ddi_port() (rev2)

2021-07-22 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/bios: Allow DSI ports to be parsed by parse_ddi_port() (rev2) URL : https://patchwork.freedesktop.org/series/92874/ State : success == Summary == CI Bug Log - changes from CI_DRM_10373_full -> Patchwork_20682_full

[Intel-gfx] [PATCH 19/33] drm/i915/guc: Fix for error capture after full GPU reset with GuC

2021-07-22 Thread Matthew Brost
From: John Harrison In the case of a full GPU reset (e.g. because GuC has died or because GuC's hang detection has been disabled), the driver can't rely on GuC reporting the guilty context. Instead, the driver needs to scan all active contexts and find one that is currently executing, as per the

[Intel-gfx] [PATCH 22/33] drm/i915/guc: Include scheduling policies in the debugfs state dump

2021-07-22 Thread Matthew Brost
From: John Harrison Added the scheduling policy parameters to the 'guc_info' debugfs state dump. Signed-off-by: John Harrison Signed-off-by: Matthew Brost Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 14 ++

[Intel-gfx] [PATCH 31/33] drm/i915/selftest: Bump selftest timeouts for hangcheck

2021-07-22 Thread Matthew Brost
From: John Harrison Some testing environments and some heavier tests are slower than previous limits allowed for. For example, it can take multiple seconds for the 'context has been reset' notification handler to reach the 'kill the requests' code in the 'active' version of the 'reset engines'

[Intel-gfx] [PATCH 20/33] drm/i915/guc: Hook GuC scheduling policies up

2021-07-22 Thread Matthew Brost
From: John Harrison Use the official driver default scheduling policies for configuring the GuC scheduler rather than a bunch of hardcoded values. v2: (Matthew Brost) - Move I915_ENGINE_WANT_FORCED_PREEMPTION to later patch Signed-off-by: John Harrison Signed-off-by: Matthew Brost

[Intel-gfx] [PATCH 28/33] drm/i915/selftest: Fix MOCS selftest for GuC submission

2021-07-22 Thread Matthew Brost
From: Rahul Kumar Singh When GuC submission is enabled, the GuC controls engine resets. Rather than explicitly triggering a reset, the driver must submit a hanging context to GuC and wait for the reset to occur. Signed-off-by: Rahul Kumar Singh Signed-off-by: John Harrison Signed-off-by:

[Intel-gfx] [PATCH 26/33] drm/i915/selftest: Better error reporting from hangcheck selftest

2021-07-22 Thread Matthew Brost
From: John Harrison There are many ways in which the hangcheck selftest can fail. Very few of them actually printed an error message to say what happened. So, fill in the missing messages. Signed-off-by: John Harrison Signed-off-by: Matthew Brost Reviewed-by: Matthew Brost Cc: Daniele

[Intel-gfx] [PATCH 24/33] drm/i915/guc: Implement banned contexts for GuC submission

2021-07-22 Thread Matthew Brost
When using GuC submission, if a context gets banned disable scheduling and mark all inflight requests as complete. Cc: John Harrison Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- drivers/gpu/drm/i915/gt/intel_context.h

[Intel-gfx] [PATCH 25/33] drm/i915/guc: Support request cancellation

2021-07-22 Thread Matthew Brost
This adds GuC backend support for i915_request_cancel(), which in turn makes CONFIG_DRM_I915_REQUEST_TIMEOUT work. This implemenation makes use of fence while there is likely simplier options. A fence was choosen because of another feature coming soon which requires a user to block on a context

[Intel-gfx] [PATCH 08/33] drm/i915/guc: Reset implementation for new GuC interface

2021-07-22 Thread Matthew Brost
Reset implementation for new GuC interface. This is the legacy reset implementation which is called when the i915 owns the engine hang check. Future patches will offload the engine hang check to GuC but we will continue to maintain this legacy path as a fallback and this code path is also required

[Intel-gfx] [PATCH 17/33] drm/i915/guc: Enable GuC engine reset

2021-07-22 Thread Matthew Brost
From: John Harrison Clear the 'disable resets' flag to allow GuC to reset hung contexts (detected via pre-emption timeout). Signed-off-by: John Harrison Signed-off-by: Matthew Brost Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 3 +-- 1 file changed, 1

[Intel-gfx] [PATCH 33/33] drm/i915/guc: Unblock GuC submission on Gen11+

2021-07-22 Thread Matthew Brost
From: Daniele Ceraolo Spurio Unblock GuC submission on Gen11+ platforms. v2: (Martin Peres / John H) - Delete debug message when GuC is disabled by default on certain platforms Signed-off-by: Michal Wajdeczko Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Matthew Brost

[Intel-gfx] [PATCH 30/33] drm/i915/selftest: Fix hangcheck self test for GuC submission

2021-07-22 Thread Matthew Brost
From: John Harrison When GuC submission is enabled, the GuC controls engine resets. Rather than explicitly triggering a reset, the driver must submit a hanging context to GuC and wait for the reset to occur. Conversely, one of the tests specifically sends hanging batches to the engines but

[Intel-gfx] [PATCH 21/33] drm/i915/guc: Connect reset modparam updates to GuC policy flags

2021-07-22 Thread Matthew Brost
From: John Harrison Changing the reset module parameter has no effect on a running GuC. The corresponding entry in the ADS must be updated and then the GuC informed via a Host2GuC message. The new debugfs interface to module parameters allows this to happen. However, connecting the parameter

[Intel-gfx] [PATCH 16/33] drm/i915/guc: Don't complain about reset races

2021-07-22 Thread Matthew Brost
From: John Harrison It is impossible to seal all race conditions of resets occurring concurrent to other operations. At least, not without introducing excesive mutex locking. Instead, don't complain if it occurs. In particular, don't complain if trying to send a H2G during a reset. Whatever the

[Intel-gfx] [PATCH 10/33] drm/i915/guc: Add disable interrupts to guc sanitize

2021-07-22 Thread Matthew Brost
Add disable GuC interrupts to intel_guc_sanitize(). Part of this requires moving the guc_*_interrupt wrapper function into header file intel_guc.h. Signed-off-by: Matthew Brost Cc: Daniele Ceraolo Spurio Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.h | 16

[Intel-gfx] [PATCH 13/33] drm/i915/guc: Handle engine reset failure notification

2021-07-22 Thread Matthew Brost
GuC will notify the driver, via G2H, if it fails to reset an engine. We recover by resorting to a full GPU reset. v2: (John Harrison): - s/drm_dbg/drm_err Signed-off-by: Matthew Brost Signed-off-by: Fernando Pacheco Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.h

[Intel-gfx] [PATCH 29/33] drm/i915/selftest: Increase some timeouts in live_requests

2021-07-22 Thread Matthew Brost
Requests may take slightly longer with GuC submission, let's increase the timeouts in live_requests. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/selftests/i915_request.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 05/33] drm/i915/guc: Direct all breadcrumbs for a class to single breadcrumbs

2021-07-22 Thread Matthew Brost
With GuC virtual engines the physical engine which a request executes and completes on isn't known to the i915. Therefore we can't attach a request to a physical engines breadcrumbs. To work around this we create a single breadcrumbs per engine class when using GuC submission and direct all

[Intel-gfx] [PATCH 32/33] drm/i915/guc: Implement GuC priority management

2021-07-22 Thread Matthew Brost
Implement a simple static mapping algorithm of the i915 priority levels (int, -1k to 1k exposed to user) to the 4 GuC levels. Mapping is as follows: i915 level < 0 -> GuC low level (3) i915 level == 0 -> GuC normal level (2) i915 level < INT_MAX-> GuC high level(1)

[Intel-gfx] [PATCH 12/33] drm/i915/guc: Handle context reset notification

2021-07-22 Thread Matthew Brost
GuC will issue a reset on detecting an engine hang and will notify the driver via a G2H message. The driver will service the notification by resetting the guilty context to a simple state or banning it completely. v2: (John Harrison) - Move msg[0] lookup after length check v3: (John Harrison)

[Intel-gfx] [PATCH 27/33] drm/i915/selftest: Fix workarounds selftest for GuC submission

2021-07-22 Thread Matthew Brost
From: "Signed-off-by: Rahul Kumar Singh" When GuC submission is enabled, the GuC controls engine resets. Rather than explicitly triggering a reset, the driver must submit a hanging context to GuC and wait for the reset to occur. Signed-off-by: Rahul Kumar Singh Signed-off-by: John Harrison

[Intel-gfx] [PATCH 18/33] drm/i915/guc: Capture error state on context reset

2021-07-22 Thread Matthew Brost
We receive notification of an engine reset from GuC at its completion. Meaning GuC has potentially cleared any HW state we may have been interested in capturing. GuC resumes scheduling on the engine post-reset, as the resets are meant to be transparent, further muddling our error state. There is

[Intel-gfx] [PATCH 23/33] drm/i915/guc: Add golden context to GuC ADS

2021-07-22 Thread Matthew Brost
From: John Harrison The media watchdog mechanism involves GuC doing a silent reset and continue of the hung context. This requires the i915 driver provide a golden context to GuC in the ADS. v2: (Matthew Brost): - Fix memory corruption in shmem_read (John H) - Use locals rather than

[Intel-gfx] [PATCH 01/33] drm/i915/guc: GuC virtual engines

2021-07-22 Thread Matthew Brost
Implement GuC virtual engines. Rather simple implementation, basically just allocate an engine, setup context enter / exit function to virtual engine specific functions, set all other variables / functions to guc versions, and set the engine mask to that of all the siblings. v2: Update to work

[Intel-gfx] [PATCH 09/33] drm/i915: Reset GPU immediately if submission is disabled

2021-07-22 Thread Matthew Brost
If submission is disabled by the backend for any reason, reset the GPU immediately in the heartbeat code as the backend can't be reenabled until the GPU is reset. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- .../gpu/drm/i915/gt/intel_engine_heartbeat.c | 63 +++

[Intel-gfx] [PATCH 04/33] drm/i915/guc: Disable bonding extension with GuC submission

2021-07-22 Thread Matthew Brost
Update the bonding extension to return -ENODEV when using GuC submission as this extension fundamentally will not work with the GuC submission interface. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 + 1 file changed, 5

[Intel-gfx] [PATCH 06/33] drm/i915: Add i915_sched_engine destroy vfunc

2021-07-22 Thread Matthew Brost
This is required to allow backend specific cleanup v2: (John H) - Rework commit message Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/i915_scheduler.c | 3 ++- drivers/gpu/drm/i915/i915_scheduler.h | 4 +---

[Intel-gfx] [PATCH 03/33] drm/i915: Hold reference to intel_context over life of i915_request

2021-07-22 Thread Matthew Brost
Hold a reference to the intel_context over life of an i915_request. Without this an i915_request can exist after the context has been destroyed (e.g. request retired, context closed, but user space holds a reference to the request from an out fence). In the case of GuC submission + virtual engine,

[Intel-gfx] [PATCH 07/33] drm/i915: Move active request tracking to a vfunc

2021-07-22 Thread Matthew Brost
Move active request tracking to a backend vfunc rather than assuming all backends want to do this in the manner. In the of case execlists / ring submission the tracking is on the physical engine while with GuC submission it is on the context. Signed-off-by: Matthew Brost Reviewed-by: John

[Intel-gfx] [PATCH 15/33] drm/i915/guc: Provide mmio list to be saved/restored on engine reset

2021-07-22 Thread Matthew Brost
From: "Signed-off-by: John Harrison" The driver must provide GuC with a list of mmio registers that should be saved/restored during a GuC-based engine reset. Unfortunately, the list must be dynamically allocated as its size is variable. That means the driver must generate the list twice - once

[Intel-gfx] [PATCH 11/33] drm/i915/guc: Suspend/resume implementation for new interface

2021-07-22 Thread Matthew Brost
The new GuC interface introduces an MMIO H2G command, INTEL_GUC_ACTION_RESET_CLIENT, which is used to implement suspend. This MMIO tears down any active contexts generating a context reset G2H CTB for each. Once that step completes the GuC tears down the CTB channels. It is safe to suspend once

[Intel-gfx] [PATCH 14/33] drm/i915/guc: Enable the timer expired interrupt for GuC

2021-07-22 Thread Matthew Brost
The GuC can implement execution qunatums, detect hung contexts and other such things but it requires the timer expired interrupt to do so. Signed-off-by: Matthew Brost CC: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/intel_rps.c | 4 1 file changed, 4

[Intel-gfx] [PATCH 02/33] drm/i915/guc: Make hangcheck work with GuC virtual engines

2021-07-22 Thread Matthew Brost
From: John Harrison The serial number tracking of engines happens at the backend of request submission and was expecting to only be given physical engines. However, in GuC submission mode, the decomposition of virtual to physical engines does not happen in i915. Instead, requests are submitted

[Intel-gfx] [PATCH 00/33] Remaining patches for basic GuC submission

2021-07-22 Thread Matthew Brost
The remaining patches for basic GuC submission [1]. Need 4 more RB and CI results to get this merged. Signed-off-by: Matthew Brost [1] https://patchwork.freedesktop.org/series/91840/ Daniele Ceraolo Spurio (1): drm/i915/guc: Unblock GuC submission on Gen11+ John Harrison (11):

[Intel-gfx] [PATCH v2] drm/i915/display: split DISPLAY_VER 9 and 10 in intel_setup_outputs()

2021-07-22 Thread Lucas De Marchi
Commit 5a9d38b20a5a ("drm/i915/display: hide workaround for broken vbt in intel_bios.c") moved the workaround for broken or missing VBT to intel_bios.c. However is_port_valid() only protects the handling of different skus of the same display version. Since in intel_setup_outputs() we share the

Re: [Intel-gfx] [PATCH 1/3] drm/plane: remove drm_helper_get_plane_damage_clips

2021-07-22 Thread Souza, Jose
On Wed, 2021-07-21 at 15:30 +0200, Daniel Vetter wrote: > It's not used. Drivers should instead use the helpers anyway. > > Currently both vbox and i915 hand-roll this and it's not the greatest. > vbox looks buggy, and i915 does a bit much that helpers would take > care of I think. > > Also

Re: [Intel-gfx] [PATCH 3/3] drm/plane: Move drm_plane_enable_fb_damage_clips into core

2021-07-22 Thread Souza, Jose
On Wed, 2021-07-21 at 15:30 +0200, Daniel Vetter wrote: > We're trying to have a fairly strict split between core functionality > that defines the uapi, including the docs, and the helper functions to > implement it. > > Move drm_plane_enable_fb_damage_clips and associated kerneldoc into >

Re: [Intel-gfx] [PATCH 2/3] drm/plane: check that fb_damage is set up when used

2021-07-22 Thread Souza, Jose
On Wed, 2021-07-21 at 15:30 +0200, Daniel Vetter wrote: > There's two stages of manual upload/invalidate displays: > - just handling dirtyfb and uploading the entire fb all the time > - looking at damage clips > > In the latter case we support it through fbdev emulation (with > fb_defio), atomic

Re: [Intel-gfx] [PATCH 50/51] drm/i915/guc: Implement GuC priority management

2021-07-22 Thread Matthew Brost
On Thu, Jul 22, 2021 at 02:50:24PM -0700, Daniele Ceraolo Spurio wrote: > > > > > > > @@ -1756,15 +1796,119 @@ static int guc_context_alloc(struct > > > > intel_context *ce) > > > > return lrc_alloc(ce, ce->engine); > > > >} > > > > +static void guc_context_set_prio(struct

Re: [Intel-gfx] [PATCH 50/51] drm/i915/guc: Implement GuC priority management

2021-07-22 Thread Daniele Ceraolo Spurio
@@ -1756,15 +1796,119 @@ static int guc_context_alloc(struct intel_context *ce) return lrc_alloc(ce, ce->engine); } +static void guc_context_set_prio(struct intel_guc *guc, +struct intel_context *ce, +u8 prio) +{ +

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: Fix ports mask (rev2)

2021-07-22 Thread Rodrigo Vivi
On Thu, Jul 22, 2021 at 03:09:13PM -, Patchwork wrote: >Patch Details > >Series: drm/i915/bios: Fix ports mask (rev2) >URL: [1]https://patchwork.freedesktop.org/series/92850/ >State: failure >Details: >

Re: [Intel-gfx] [PATCH 50/51] drm/i915/guc: Implement GuC priority management

2021-07-22 Thread Matthew Brost
On Thu, Jul 22, 2021 at 01:26:30PM -0700, Daniele Ceraolo Spurio wrote: > > > On 7/16/2021 1:17 PM, Matthew Brost wrote: > > Implement a simple static mapping algorithm of the i915 priority levels > > (int, -1k to 1k exposed to user) to the 4 GuC levels. Mapping is as > > follows: > > > > i915

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Extend Wa_1406941453 to adl-p

2021-07-22 Thread Patchwork
== Series Details == Series: drm/i915: Extend Wa_1406941453 to adl-p URL : https://patchwork.freedesktop.org/series/92905/ State : success == Summary == CI Bug Log - changes from CI_DRM_10373 -> Patchwork_20684 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: split DISPLAY_VER 9 and 10 in intel_setup_outputs()

2021-07-22 Thread Patchwork
== Series Details == Series: drm/i915/display: split DISPLAY_VER 9 and 10 in intel_setup_outputs() URL : https://patchwork.freedesktop.org/series/92902/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10373 -> Patchwork_20683

Re: [Intel-gfx] [PATCH 50/51] drm/i915/guc: Implement GuC priority management

2021-07-22 Thread Daniele Ceraolo Spurio
On 7/16/2021 1:17 PM, Matthew Brost wrote: Implement a simple static mapping algorithm of the i915 priority levels (int, -1k to 1k exposed to user) to the 4 GuC levels. Mapping is as follows: i915 level < 0 -> GuC low level (3) i915 level == 0 -> GuC normal level (2)

Re: [Intel-gfx] [PATCH] drm/i915: Extend Wa_1406941453 to adl-p

2021-07-22 Thread Matt Roper
On Thu, Jul 22, 2021 at 12:20:41PM -0700, José Roberto de Souza wrote: > Workaround also needed for alderlake-P. > > HSDES: 14010801662 > Cc: Matt Roper > Signed-off-by: José Roberto de Souza Marked incorrectly in the workaround database, but based on the notes there, it is indeed needed for

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/10] drm/i915/bios: Allow DSI ports to be parsed by parse_ddi_port() (rev2)

2021-07-22 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/bios: Allow DSI ports to be parsed by parse_ddi_port() (rev2) URL : https://patchwork.freedesktop.org/series/92874/ State : success == Summary == CI Bug Log - changes from CI_DRM_10373 -> Patchwork_20682

Re: [Intel-gfx] [PATCH 43/51] drm/i915/guc: Support request cancellation

2021-07-22 Thread Matthew Brost
On Thu, Jul 22, 2021 at 12:56:56PM -0700, Daniele Ceraolo Spurio wrote: > > > On 7/16/2021 1:17 PM, Matthew Brost wrote: > > This adds GuC backend support for i915_request_cancel(), which in turn > > makes CONFIG_DRM_I915_REQUEST_TIMEOUT work. > > This needs a bit of explanation on why we're

Re: [Intel-gfx] [PATCH 43/51] drm/i915/guc: Support request cancellation

2021-07-22 Thread Daniele Ceraolo Spurio
On 7/16/2021 1:17 PM, Matthew Brost wrote: This adds GuC backend support for i915_request_cancel(), which in turn makes CONFIG_DRM_I915_REQUEST_TIMEOUT work. This needs a bit of explanation on why we're using fences for this instead of other simpler options. Signed-off-by: Matthew Brost

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/10] drm/i915/bios: Allow DSI ports to be parsed by parse_ddi_port() (rev2)

2021-07-22 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/bios: Allow DSI ports to be parsed by parse_ddi_port() (rev2) URL : https://patchwork.freedesktop.org/series/92874/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] drm/i915/bios: Allow DSI ports to be parsed by parse_ddi_port() (rev2)

2021-07-22 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/bios: Allow DSI ports to be parsed by parse_ddi_port() (rev2) URL : https://patchwork.freedesktop.org/series/92874/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2895a0aeaa5c drm/i915/bios: Allow DSI ports to

Re: [Intel-gfx] [PATCH v3 3/5] drm/print: RFC add choice to use dynamic debug in drm-debug

2021-07-22 Thread jim . cromie
Thanks for the feedback! On Tue, Jul 20, 2021 at 9:29 AM Daniel Vetter wrote: > > On Wed, Jul 14, 2021 at 11:51:36AM -0600, Jim Cromie wrote: > > drm's debug system uses distinct categories of debug messages, encoded > > in an enum (DRM_UT_), which are mapped to bits in drm.debug. > >

Re: [Intel-gfx] [PATCH 3/3] drm/vmwgfx: fix potential UAF in vmwgfx_surface.c

2021-07-22 Thread Zack Rusin
On 7/22/21 5:29 AM, Desmond Cheong Zhi Xi wrote: drm_file.master should be protected by either drm_device.master_mutex or drm_file.master_lookup_lock when being dereferenced. However, drm_master_get is called on unprotected file_priv->master pointers in vmw_surface_define_ioctl and

[Intel-gfx] [PATCH] drm/i915: Extend Wa_1406941453 to adl-p

2021-07-22 Thread José Roberto de Souza
Workaround also needed for alderlake-P. HSDES: 14010801662 Cc: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c

Re: [Intel-gfx] [PATCH] drm/i915/display: split DISPLAY_VER 9 and 10 in intel_setup_outputs()

2021-07-22 Thread Rodrigo Vivi
On Thu, Jul 22, 2021 at 10:15:35AM -0700, Lucas De Marchi wrote: > Commit 5a9d38b20a5a ("drm/i915/display: hide workaround for broken vbt > in intel_bios.c") moved the workaround for broken or missing VBT to > intel_bios.c. However is_port_valid() only protects the handling of > different skus of

Re: [Intel-gfx] [PATCH 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-22 Thread Daniel Vetter
On Thu, Jul 22, 2021 at 6:00 PM Boqun Feng wrote: > > On Thu, Jul 22, 2021 at 12:38:10PM +0200, Daniel Vetter wrote: > > On Thu, Jul 22, 2021 at 05:29:27PM +0800, Desmond Cheong Zhi Xi wrote: > > > Inside drm_is_current_master, using the outer drm_device.master_mutex > > > to protect reads of

Re: [Intel-gfx] [PATCH v4 4/4] drm/vgem: use shmem helpers

2021-07-22 Thread Thomas Zimmermann
Hi Am 13.07.21 um 22:51 schrieb Daniel Vetter: Aside from deleting lots of code the real motivation here is to switch the mmap over to VM_PFNMAP, to be more consistent with what real gpu drivers do. They're all VM_PFNMP, which means get_user_pages doesn't work, and even if you try and there's a

Re: [Intel-gfx] [PATCH v4 3/4] drm/shmem-helpers: Allocate wc pages on x86

2021-07-22 Thread Thomas Zimmermann
Hi Am 13.07.21 um 22:51 schrieb Daniel Vetter: intel-gfx-ci realized that something is not quite coherent anymore on some platforms for our i915+vgem tests, when I tried to switch vgem over to shmem helpers. After lots of head-scratching I realized that I've removed calls to drm_clflush. And

Re: [Intel-gfx] [PATCH v4 2/4] drm/shmem-helper: Switch to vmf_insert_pfn

2021-07-22 Thread Thomas Zimmermann
Hi, I'm not knowledgeable enougth to give this a full review. If you can just answer my questions, fell free to add an Acked-by: Thomas Zimmermann to the patch. :) Am 13.07.21 um 22:51 schrieb Daniel Vetter: We want to stop gup, which isn't the case if we use vmf_insert_page What is

[Intel-gfx] [RFC PATCH] drm/i915/guc/slpc: slpc_decode_min_freq() can be static

2021-07-22 Thread kernel test robot
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c:217:5: warning: symbol 'slpc_decode_min_freq' was not declared. Should it be static? drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c:229:5: warning: symbol 'slpc_decode_max_freq' was not declared. Should it be static? Reported-by: kernel test robot

Re: [Intel-gfx] [PATCH 06/14] drm/i915/guc/slpc: Enable SLPC and add related H2G events

2021-07-22 Thread kernel test robot
Hi Vinay, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm/drm-next v5.14-rc2 next-20210722] [If your patch is applied to the wrong git tree

Re: [Intel-gfx] [PATCH rdma-next v2 1/2] lib/scatterlist: Fix wrong update of orig_nents

2021-07-22 Thread Jason Gunthorpe
On Thu, Jul 22, 2021 at 02:07:51PM +0100, Christoph Hellwig wrote: > On Thu, Jul 22, 2021 at 10:00:40AM -0300, Jason Gunthorpe wrote: > > this is better: > > > >struct sg_append_table state; > > > >sg_append_init(, sgt, gfp_mask); > > > >while (..) > > ret = sg_append_pages(,

[Intel-gfx] [PATCH] drm/i915/display: split DISPLAY_VER 9 and 10 in intel_setup_outputs()

2021-07-22 Thread Lucas De Marchi
Commit 5a9d38b20a5a ("drm/i915/display: hide workaround for broken vbt in intel_bios.c") moved the workaround for broken or missing VBT to intel_bios.c. However is_port_valid() only protects the handling of different skus of the same display version. Since in intel_setup_outputs() we share the

Re: [Intel-gfx] [PATCH rdma-next v2 1/2] lib/scatterlist: Fix wrong update of orig_nents

2021-07-22 Thread Jason Gunthorpe
On Sun, Jul 18, 2021 at 02:09:12PM +0300, Leon Romanovsky wrote: > @@ -386,12 +414,14 @@ static struct scatterlist *get_next_sg(struct sg_table > *table, > return ERR_PTR(-ENOMEM); > sg_init_table(new_sg, alloc_size); > if (cur) { > + if (total_nents) > +

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: Fix ports mask (rev3)

2021-07-22 Thread Patchwork
== Series Details == Series: drm/i915/bios: Fix ports mask (rev3) URL : https://patchwork.freedesktop.org/series/92850/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10371 -> Patchwork_20681 Summary --- **FAILURE**

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for CI pass for reviewed Xe_HP SDV and DG2 patches

2021-07-22 Thread Matt Roper
On Thu, Jul 22, 2021 at 07:47:21AM +, Patchwork wrote: > == Series Details == > > Series: CI pass for reviewed Xe_HP SDV and DG2 patches > URL : https://patchwork.freedesktop.org/series/92853/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_10367_full ->

Re: [Intel-gfx] 5.14-rc2 warnings with kvmgvt

2021-07-22 Thread Christoph Hellwig
On Thu, Jul 22, 2021 at 09:03:45AM -0700, Lucas De Marchi wrote: > On Thu, Jul 22, 2021 at 08:20:34AM +0100, Christoph Hellwig wrote: > > On Thu, Jul 22, 2021 at 01:55:23AM -0400, Lucas De Marchi wrote: > > > humn... PORT_F. KBL doesn't have PORT_F. We decided to keep the handling > > > of

Re: [Intel-gfx] [PATCH 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-22 Thread Boqun Feng
On Thu, Jul 22, 2021 at 12:38:10PM +0200, Daniel Vetter wrote: > On Thu, Jul 22, 2021 at 05:29:27PM +0800, Desmond Cheong Zhi Xi wrote: > > Inside drm_is_current_master, using the outer drm_device.master_mutex > > to protect reads of drm_file.master makes the function prone to creating > > lock

Re: [Intel-gfx] 5.14-rc2 warnings with kvmgvt

2021-07-22 Thread Lucas De Marchi
On Thu, Jul 22, 2021 at 08:20:34AM +0100, Christoph Hellwig wrote: On Thu, Jul 22, 2021 at 01:55:23AM -0400, Lucas De Marchi wrote: humn... PORT_F. KBL doesn't have PORT_F. We decided to keep the handling of DISPLAY_VER == 10 and DISPLAY_VER == 9 together and trust the VBT, but when the VBT is

Re: [Intel-gfx] [PATCH 06/51] drm/i915/guc: Implement GuC context operations for new inteface

2021-07-22 Thread Matthew Brost
On Thu, Jul 22, 2021 at 09:57:00AM +0200, Michal Wajdeczko wrote: > > > On 22.07.2021 01:51, Daniele Ceraolo Spurio wrote: > > > > > > On 7/19/2021 9:04 PM, Matthew Brost wrote: > >> On Mon, Jul 19, 2021 at 05:51:46PM -0700, Daniele Ceraolo Spurio wrote: > >>> > >>> On 7/16/2021 1:16 PM,

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: Fix ports mask (rev2)

2021-07-22 Thread Patchwork
== Series Details == Series: drm/i915/bios: Fix ports mask (rev2) URL : https://patchwork.freedesktop.org/series/92850/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10371 -> Patchwork_20680 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH v2 07/14] vfio/platform: Use open_device() instead of open coding a refcnt scheme

2021-07-22 Thread Cornelia Huck
On Tue, Jul 20 2021, Jason Gunthorpe wrote: > Platform simply wants to run some code when the device is first > opened/last closed. Use the core framework and locking for this. Aside > from removing a bit of code this narrows the locking scope from a global > lock. > > Signed-off-by: Yishai

Re: [Intel-gfx] [PATCH v2 04/14] vfio: Provide better generic support for open/release vfio_device_ops

2021-07-22 Thread Cornelia Huck
On Tue, Jul 20 2021, Jason Gunthorpe wrote: > Currently the driver ops have an open/release pair that is called once > each time a device FD is opened or closed. Add an additional set of > open/close_device() ops which are called when the device FD is opened for > the first time and closed for

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm, drm/vmwgfx: fixes and updates related to drm_master

2021-07-22 Thread Patchwork
== Series Details == Series: drm, drm/vmwgfx: fixes and updates related to drm_master URL : https://patchwork.freedesktop.org/series/92894/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10371 -> Patchwork_20678 Summary

[Intel-gfx] ✗ Fi.CI.BUILD: failure for SG fix together with update to RDMA umem (rev2)

2021-07-22 Thread Patchwork
== Series Details == Series: SG fix together with update to RDMA umem (rev2) URL : https://patchwork.freedesktop.org/series/92682/ State : failure == Summary == Applying: lib/scatterlist: Fix wrong update of orig_nents error: sha1 information is lacking or useless

[Intel-gfx] ✓ Fi.CI.IGT: success for MIPI DSI driver enhancements (rev2)

2021-07-22 Thread Patchwork
== Series Details == Series: MIPI DSI driver enhancements (rev2) URL : https://patchwork.freedesktop.org/series/92695/ State : success == Summary == CI Bug Log - changes from CI_DRM_10369_full -> Patchwork_20676_full Summary ---

Re: [Intel-gfx] [PATCH 2/3] drm: clarify lifetime/locking for drm_master's lease fields

2021-07-22 Thread Daniel Vetter
On Thu, Jul 22, 2021 at 3:03 PM Desmond Cheong Zhi Xi wrote: > > On 22/7/21 6:35 pm, Daniel Vetter wrote: > > On Thu, Jul 22, 2021 at 05:29:28PM +0800, Desmond Cheong Zhi Xi wrote: > >> In particular, we make it clear that _device.mode_config.idr_mutex > >> protects the lease idr and list

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm, drm/vmwgfx: fixes and updates related to drm_master

2021-07-22 Thread Patchwork
== Series Details == Series: drm, drm/vmwgfx: fixes and updates related to drm_master URL : https://patchwork.freedesktop.org/series/92894/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

Re: [Intel-gfx] [PATCH] drm/i915: Ditch i915 globals shrink infrastructure

2021-07-22 Thread Tvrtko Ursulin
On 22/07/2021 14:37, Jason Ekstrand wrote: On Thu, Jul 22, 2021 at 5:34 AM Tvrtko Ursulin wrote: On 22/07/2021 11:16, Daniel Vetter wrote: On Thu, Jul 22, 2021 at 11:02:55AM +0100, Tvrtko Ursulin wrote: On 21/07/2021 19:32, Daniel Vetter wrote: This essentially reverts commit

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,1/2] drm/i915: document caching related bits

2021-07-22 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915: document caching related bits URL : https://patchwork.freedesktop.org/series/92889/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10371 -> Patchwork_20677

Re: [Intel-gfx] [PATCH 24/47] drm/i915/guc: Add several request trace points

2021-07-22 Thread Tvrtko Ursulin
On 20/07/2021 02:59, Matthew Brost wrote: On Tue, Jul 13, 2021 at 10:06:17AM +0100, Tvrtko Ursulin wrote: On 24/06/2021 08:04, Matthew Brost wrote: Add trace points for request dependencies and GuC submit. Extended existing request trace points to include submit fence value,, guc_id, and

[Intel-gfx] [CI] drm/i915/bios: Fix ports mask

2021-07-22 Thread Rodrigo Vivi
PORT_A to PORT_F are regular integers defined in the enum port, while for_each_port_masked requires a bit mask for the ports. Current given mask: 0b111 Desired mask: 0b11 I noticed this while Christoph was reporting a bug found on headless GVT configuration which bisect blamed commit

[Intel-gfx] [PULL] drm-intel-fixes

2021-07-22 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2021-07-22: Couple reverts from Jason getting rid of asynchronous command parsing and fence error propagation and a GVT fix of shadow ppgtt invalidation with proper D3 state tracking from Colin. Thanks, Rodrigo. The following changes since commit

Re: [Intel-gfx] [PATCH] drm/i915: Ditch i915 globals shrink infrastructure

2021-07-22 Thread Jason Ekstrand
On Thu, Jul 22, 2021 at 5:34 AM Tvrtko Ursulin wrote: > On 22/07/2021 11:16, Daniel Vetter wrote: > > On Thu, Jul 22, 2021 at 11:02:55AM +0100, Tvrtko Ursulin wrote: > >> On 21/07/2021 19:32, Daniel Vetter wrote: > >>> This essentially reverts > >>> > >>> commit

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915: document caching related bits

2021-07-22 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915: document caching related bits URL : https://patchwork.freedesktop.org/series/92889/ State : warning == Summary == $ dim checkpatch origin/drm-tip c4aff2fea027 drm/i915: document caching related bits abcea5c46d5f

Re: [Intel-gfx] [PATCH 3/4] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-22 Thread Jason Ekstrand
On Thu, Jul 22, 2021 at 3:44 AM Matthew Auld wrote: > > On Wed, 21 Jul 2021 at 21:28, Jason Ekstrand wrote: > > > > On Thu, Jul 15, 2021 at 5:16 AM Matthew Auld wrote: > > > > > > From: Chris Wilson > > > > > > Jason Ekstrand requested a more efficient method than userptr+set-domain > > > to

  1   2   >