[Intel-gfx] ✓ Fi.CI.IGT: success for Remaining patches for basic GuC submission (rev2)

2021-07-26 Thread Patchwork
== Series Details == Series: Remaining patches for basic GuC submission (rev2) URL : https://patchwork.freedesktop.org/series/92912/ State : success == Summary == CI Bug Log - changes from CI_DRM_10399_full -> Patchwork_20708_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for Increase timeout in i915_gem_contexts selftests

2021-07-26 Thread Patchwork
== Series Details == Series: Increase timeout in i915_gem_contexts selftests URL : https://patchwork.freedesktop.org/series/93049/ State : success == Summary == CI Bug Log - changes from CI_DRM_10399 -> Patchwork_20711 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for querying hw info that UMDs need

2021-07-26 Thread Patchwork
== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/93047/ State : success == Summary == CI Bug Log - changes from CI_DRM_10399 -> Patchwork_20710 Summary ---

[Intel-gfx] [PATCH 0/1] Increase timeout in i915_gem_contexts selftests

2021-07-26 Thread Matthew Brost
Patch says it all. Seeing a failure in CI [1] and locally on certain TGL machines with GuC submission enabled. Let's fix this so we can enable CI on TGL with GuC submission. Signed-off-by: Matthew Brost [1] https://patchwork.freedesktop.org/series/92984/#rev4 Matthew Brost (1):

[Intel-gfx] [PATCH 1/1] drm/i915/selftests: Increase timeout in i915_gem_contexts selftests

2021-07-26 Thread Matthew Brost
Like in the case of several other selftests, generating lots of requests in a loop takes a bit longer with GuC submission. Increase a timeout in i915_gem_contexts selftest to take this into account. Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 2 +- 1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for querying hw info that UMDs need

2021-07-26 Thread Patchwork
== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/93047/ State : warning == Summary == $ dim checkpatch origin/drm-tip 84f2c965ffe1 drm/i915/guc: Add fetch of hwconfig table -:96: WARNING:FILE_PATH_CHANGES: added, moved

[Intel-gfx] [PATCH 2/2] drm/i915/uapi: Add query for hwconfig table

2021-07-26 Thread John . C . Harrison
From: Rodrigo Vivi GuC contains a consolidated table with a bunch of information about the current device. Previously, this information was spread and hardcoded to all the components including GuC, i915 and various UMDs. The goal here is to consolidate the data into GuC in a way that all

[Intel-gfx] [PATCH 0/2] Add support for querying hw info that UMDs need

2021-07-26 Thread John . C . Harrison
From: John Harrison Various UMDs require hardware configuration information about the current platform. A bunch of static information is available in a fixed table that can be retrieved from the GuC. Test-with: 20210727002812.43469-2-john.c.harri...@intel.com UMD:

[Intel-gfx] [PATCH 1/2] drm/i915/guc: Add fetch of hwconfig table

2021-07-26 Thread John . C . Harrison
From: John Harrison Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer. Note that the table is only available on ADL-P and later platforms. Cc:

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Add support for querying hw info that UMDs need

2021-07-26 Thread Patchwork
== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/93044/ State : failure == Summary == Applying: drm/i915/guc: Add fetch of hwconfig table error: sha1 information is lacking or useless (drivers/gpu/drm/i915/Makefile).

[Intel-gfx] [PATCH 0/2] Add support for querying hw info that UMDs need

2021-07-26 Thread John . C . Harrison
From: John Harrison Various UMDs require hardware configuration information about the current platform. A bunch of static information is available in a fixed table that can be retrieved from the GuC. Test-with: 20210727002812.43469-2-john.c.harri...@intel.com UMD:

[Intel-gfx] [PATCH 2/2] drm/i915/uapi: Add query for hwconfig table

2021-07-26 Thread John . C . Harrison
From: Rodrigo Vivi GuC contains a consolidated table with a bunch of information about the current device. Previously, this information was spread and hardcoded to all the components including GuC, i915 and various UMDs. The goal here is to consolidate the data into GuC in a way that all

[Intel-gfx] [PATCH 1/2] drm/i915/guc: Add fetch of hwconfig table

2021-07-26 Thread John . C . Harrison
From: John Harrison Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer. Note that the table is only available on ADL-P and later platforms. Cc:

[Intel-gfx] ✓ Fi.CI.BAT: success for Remaining patches for basic GuC submission (rev2)

2021-07-26 Thread Patchwork
== Series Details == Series: Remaining patches for basic GuC submission (rev2) URL : https://patchwork.freedesktop.org/series/92912/ State : success == Summary == CI Bug Log - changes from CI_DRM_10399 -> Patchwork_20708 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Remaining patches for basic GuC submission (rev2)

2021-07-26 Thread Patchwork
== Series Details == Series: Remaining patches for basic GuC submission (rev2) URL : https://patchwork.freedesktop.org/series/92912/ State : warning == Summary == $ dim checkpatch origin/drm-tip ac863c9f348a drm/i915/guc: GuC virtual engines 9b36b2e16d7c drm/i915/guc: Make hangcheck work with

[Intel-gfx] [PATCH i-g-t 1/1] tests/i915/query: Query, parse and validate the hwconfig table

2021-07-26 Thread John . C . Harrison
From: Rodrigo Vivi Newer platforms have an embedded table giving details about that platform's hardware configuration. This table can be retrieved from the KMD via the query API. So add a test for it as both an example of how to fetch the table and to validate the contents as much as possible.

[Intel-gfx] [PATCH i-g-t 0/1] Add tests for new hw info query

2021-07-26 Thread John . C . Harrison
From: John Harrison Various UMDs require hardware configuration information about the current platform. A new interface has been added to the KMD to return this information. So, add a test for the new interfaces. Signed-off-by: John Harrison Rodrigo Vivi (1): tests/i915/query: Query, parse

[Intel-gfx] [PATCH 33/33] drm/i915/guc: Unblock GuC submission on Gen11+

2021-07-26 Thread Matthew Brost
From: Daniele Ceraolo Spurio Unblock GuC submission on Gen11+ platforms. v2: (Martin Peres / John H) - Delete debug message when GuC is disabled by default on certain platforms Signed-off-by: Michal Wajdeczko Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Matthew Brost

[Intel-gfx] [PATCH 25/33] drm/i915/guc: Support request cancellation

2021-07-26 Thread Matthew Brost
This adds GuC backend support for i915_request_cancel(), which in turn makes CONFIG_DRM_I915_REQUEST_TIMEOUT work. This implementation makes use of fence while there are likely simplier options. A fence was chosen because of another feature coming soon which requires a user to block on a context

Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print

2021-07-26 Thread kernel test robot
Hi Swati, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip v5.14-rc3 next-20210726] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[Intel-gfx] [PATCH 18/33] drm/i915/guc: Capture error state on context reset

2021-07-26 Thread Matthew Brost
We receive notification of an engine reset from GuC at its completion. Meaning GuC has potentially cleared any HW state we may have been interested in capturing. GuC resumes scheduling on the engine post-reset, as the resets are meant to be transparent, further muddling our error state. There is

[Intel-gfx] [PATCH 31/33] drm/i915/selftest: Bump selftest timeouts for hangcheck

2021-07-26 Thread Matthew Brost
From: John Harrison Some testing environments and some heavier tests are slower than previous limits allowed for. For example, it can take multiple seconds for the 'context has been reset' notification handler to reach the 'kill the requests' code in the 'active' version of the 'reset engines'

[Intel-gfx] [PATCH 27/33] drm/i915/selftest: Fix workarounds selftest for GuC submission

2021-07-26 Thread Matthew Brost
From: Rahul Kumar Singh When GuC submission is enabled, the GuC controls engine resets. Rather than explicitly triggering a reset, the driver must submit a hanging context to GuC and wait for the reset to occur. Signed-off-by: Rahul Kumar Singh Signed-off-by: John Harrison Signed-off-by:

[Intel-gfx] [PATCH 29/33] drm/i915/selftest: Increase some timeouts in live_requests

2021-07-26 Thread Matthew Brost
Requests may take slightly longer with GuC submission, let's increase the timeouts in live_requests. Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/selftests/i915_request.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 30/33] drm/i915/selftest: Fix hangcheck self test for GuC submission

2021-07-26 Thread Matthew Brost
From: John Harrison When GuC submission is enabled, the GuC controls engine resets. Rather than explicitly triggering a reset, the driver must submit a hanging context to GuC and wait for the reset to occur. Conversely, one of the tests specifically sends hanging batches to the engines but

[Intel-gfx] [PATCH 13/33] drm/i915/guc: Handle engine reset failure notification

2021-07-26 Thread Matthew Brost
GuC will notify the driver, via G2H, if it fails to reset an engine. We recover by resorting to a full GPU reset. v2: (John Harrison): - s/drm_dbg/drm_err Signed-off-by: Matthew Brost Signed-off-by: Fernando Pacheco Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.h

[Intel-gfx] [PATCH 16/33] drm/i915/guc: Don't complain about reset races

2021-07-26 Thread Matthew Brost
From: John Harrison It is impossible to seal all race conditions of resets occurring concurrent to other operations. At least, not without introducing excesive mutex locking. Instead, don't complain if it occurs. In particular, don't complain if trying to send a H2G during a reset. Whatever the

[Intel-gfx] [PATCH 21/33] drm/i915/guc: Connect reset modparam updates to GuC policy flags

2021-07-26 Thread Matthew Brost
From: John Harrison Changing the reset module parameter has no effect on a running GuC. The corresponding entry in the ADS must be updated and then the GuC informed via a Host2GuC message. The new debugfs interface to module parameters allows this to happen. However, connecting the parameter

[Intel-gfx] [PATCH 32/33] drm/i915/guc: Implement GuC priority management

2021-07-26 Thread Matthew Brost
Implement a simple static mapping algorithm of the i915 priority levels (int, -1k to 1k exposed to user) to the 4 GuC levels. Mapping is as follows: i915 level < 0 -> GuC low level (3) i915 level == 0 -> GuC normal level (2) i915 level < INT_MAX-> GuC high level(1)

[Intel-gfx] [PATCH 23/33] drm/i915/guc: Add golden context to GuC ADS

2021-07-26 Thread Matthew Brost
From: John Harrison The media watchdog mechanism involves GuC doing a silent reset and continue of the hung context. This requires the i915 driver provide a golden context to GuC in the ADS. v2: (Matthew Brost): - Fix memory corruption in shmem_read (John H) - Use locals rather than

[Intel-gfx] [PATCH 17/33] drm/i915/guc: Enable GuC engine reset

2021-07-26 Thread Matthew Brost
From: John Harrison Clear the 'disable resets' flag to allow GuC to reset hung contexts (detected via pre-emption timeout). Signed-off-by: John Harrison Signed-off-by: Matthew Brost Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 3 +-- 1 file changed, 1

[Intel-gfx] [PATCH 28/33] drm/i915/selftest: Fix MOCS selftest for GuC submission

2021-07-26 Thread Matthew Brost
From: Rahul Kumar Singh When GuC submission is enabled, the GuC controls engine resets. Rather than explicitly triggering a reset, the driver must submit a hanging context to GuC and wait for the reset to occur. Signed-off-by: Rahul Kumar Singh Signed-off-by: John Harrison Signed-off-by:

[Intel-gfx] [PATCH 19/33] drm/i915/guc: Fix for error capture after full GPU reset with GuC

2021-07-26 Thread Matthew Brost
From: John Harrison In the case of a full GPU reset (e.g. because GuC has died or because GuC's hang detection has been disabled), the driver can't rely on GuC reporting the guilty context. Instead, the driver needs to scan all active contexts and find one that is currently executing, as per the

[Intel-gfx] [PATCH 26/33] drm/i915/selftest: Better error reporting from hangcheck selftest

2021-07-26 Thread Matthew Brost
From: John Harrison There are many ways in which the hangcheck selftest can fail. Very few of them actually printed an error message to say what happened. So, fill in the missing messages. Signed-off-by: John Harrison Signed-off-by: Matthew Brost Reviewed-by: Matthew Brost Cc: Daniele

[Intel-gfx] [PATCH 09/33] drm/i915: Reset GPU immediately if submission is disabled

2021-07-26 Thread Matthew Brost
If submission is disabled by the backend for any reason, reset the GPU immediately in the heartbeat code as the backend can't be reenabled until the GPU is reset. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- .../gpu/drm/i915/gt/intel_engine_heartbeat.c | 62 +++

[Intel-gfx] [PATCH 14/33] drm/i915/guc: Enable the timer expired interrupt for GuC

2021-07-26 Thread Matthew Brost
The GuC can implement execution qunatums, detect hung contexts and other such things but it requires the timer expired interrupt to do so. Signed-off-by: Matthew Brost CC: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/intel_rps.c | 4 1 file changed, 4

[Intel-gfx] [PATCH 12/33] drm/i915/guc: Handle context reset notification

2021-07-26 Thread Matthew Brost
GuC will issue a reset on detecting an engine hang and will notify the driver via a G2H message. The driver will service the notification by resetting the guilty context to a simple state or banning it completely. v2: (John Harrison) - Move msg[0] lookup after length check v3: (John Harrison)

[Intel-gfx] [PATCH 07/33] drm/i915: Move active request tracking to a vfunc

2021-07-26 Thread Matthew Brost
Move active request tracking to a backend vfunc rather than assuming all backends want to do this in the manner. In the of case execlists / ring submission the tracking is on the physical engine while with GuC submission it is on the context. Signed-off-by: Matthew Brost Reviewed-by: John

[Intel-gfx] [PATCH 20/33] drm/i915/guc: Hook GuC scheduling policies up

2021-07-26 Thread Matthew Brost
From: John Harrison Use the official driver default scheduling policies for configuring the GuC scheduler rather than a bunch of hardcoded values. v2: (Matthew Brost) - Move I915_ENGINE_WANT_FORCED_PREEMPTION to later patch Signed-off-by: John Harrison Signed-off-by: Matthew Brost

[Intel-gfx] [PATCH 24/33] drm/i915/guc: Implement banned contexts for GuC submission

2021-07-26 Thread Matthew Brost
When using GuC submission, if a context gets banned disable scheduling and mark all inflight requests as complete. Cc: John Harrison Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- drivers/gpu/drm/i915/gt/intel_context.h

[Intel-gfx] [PATCH 22/33] drm/i915/guc: Include scheduling policies in the debugfs state dump

2021-07-26 Thread Matthew Brost
From: John Harrison Added the scheduling policy parameters to the 'guc_info' debugfs state dump. Signed-off-by: John Harrison Signed-off-by: Matthew Brost Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 14 ++

[Intel-gfx] [PATCH 04/33] drm/i915/guc: Disable bonding extension with GuC submission

2021-07-26 Thread Matthew Brost
Update the bonding extension to return -ENODEV when using GuC submission as this extension fundamentally will not work with the GuC submission interface. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 + 1 file changed, 5

[Intel-gfx] [PATCH 01/33] drm/i915/guc: GuC virtual engines

2021-07-26 Thread Matthew Brost
Implement GuC virtual engines. Rather simple implementation, basically just allocate an engine, setup context enter / exit function to virtual engine specific functions, set all other variables / functions to guc versions, and set the engine mask to that of all the siblings. v2: Update to work

[Intel-gfx] [PATCH 15/33] drm/i915/guc: Provide mmio list to be saved/restored on engine reset

2021-07-26 Thread Matthew Brost
From: John Harrison The driver must provide GuC with a list of mmio registers that should be saved/restored during a GuC-based engine reset. Unfortunately, the list must be dynamically allocated as its size is variable. That means the driver must generate the list twice - once to work out the

[Intel-gfx] [PATCH 03/33] drm/i915: Hold reference to intel_context over life of i915_request

2021-07-26 Thread Matthew Brost
Hold a reference to the intel_context over life of an i915_request. Without this an i915_request can exist after the context has been destroyed (e.g. request retired, context closed, but user space holds a reference to the request from an out fence). In the case of GuC submission + virtual engine,

[Intel-gfx] [PATCH 06/33] drm/i915: Add i915_sched_engine destroy vfunc

2021-07-26 Thread Matthew Brost
This is required to allow backend specific cleanup v2: (John H) - Rework commit message Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/i915_scheduler.c | 3 ++- drivers/gpu/drm/i915/i915_scheduler.h | 4 +---

[Intel-gfx] [PATCH 10/33] drm/i915/guc: Add disable interrupts to guc sanitize

2021-07-26 Thread Matthew Brost
Add disable GuC interrupts to intel_guc_sanitize(). Part of this requires moving the guc_*_interrupt wrapper function into header file intel_guc.h. Signed-off-by: Matthew Brost Cc: Daniele Ceraolo Spurio Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.h | 16

[Intel-gfx] [PATCH 11/33] drm/i915/guc: Suspend/resume implementation for new interface

2021-07-26 Thread Matthew Brost
The new GuC interface introduces an MMIO H2G command, INTEL_GUC_ACTION_RESET_CLIENT, which is used to implement suspend. This MMIO tears down any active contexts generating a context reset G2H CTB for each. Once that step completes the GuC tears down the CTB channels. It is safe to suspend once

[Intel-gfx] [PATCH 02/33] drm/i915/guc: Make hangcheck work with GuC virtual engines

2021-07-26 Thread Matthew Brost
From: John Harrison The serial number tracking of engines happens at the backend of request submission and was expecting to only be given physical engines. However, in GuC submission mode, the decomposition of virtual to physical engines does not happen in i915. Instead, requests are submitted

[Intel-gfx] [PATCH 08/33] drm/i915/guc: Reset implementation for new GuC interface

2021-07-26 Thread Matthew Brost
Reset implementation for new GuC interface. This is the legacy reset implementation which is called when the i915 owns the engine hang check. Future patches will offload the engine hang check to GuC but we will continue to maintain this legacy path as a fallback and this code path is also required

[Intel-gfx] [PATCH 05/33] drm/i915/guc: Direct all breadcrumbs for a class to single breadcrumbs

2021-07-26 Thread Matthew Brost
With GuC virtual engines the physical engine which a request executes and completes on isn't known to the i915. Therefore we can't attach a request to a physical engines breadcrumbs. To work around this we create a single breadcrumbs per engine class when using GuC submission and direct all

[Intel-gfx] [PATCH 00/33] Remaining patches for basic GuC submission

2021-07-26 Thread Matthew Brost
The remaining patches for basic GuC submission [1]. Need 1 more RB and CI results to get this merged. v2: (Checkpatch) - Fix checkpatch warning (1 remaining overrulled) (Daniele) - Use an outer lock in guc_context_block / unblock Signed-off-by: Matthew Brost [1]

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc/slpc: Enable GuC based power management features

2021-07-26 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Enable GuC based power management features URL : https://patchwork.freedesktop.org/series/93026/ State : success == Summary == CI Bug Log - changes from CI_DRM_10396_full -> Patchwork_20707_full

Re: [Intel-gfx] [PATCH 10/30] drm/i915/display: remove explicit CNL handling from intel_dmc.c

2021-07-26 Thread Matt Roper
On Fri, Jul 23, 2021 at 05:10:54PM -0700, Lucas De Marchi wrote: > Remove DMC firmware for CNL. > > Signed-off-by: Lucas De Marchi Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_dmc.c | 9 - > 1 file changed, 9 deletions(-) > > diff --git

Re: [Intel-gfx] [PATCH 23/30] drm/i915/gt: remove explicit CNL handling from intel_sseu.c

2021-07-26 Thread Matt Roper
On Fri, Jul 23, 2021 at 05:11:07PM -0700, Lucas De Marchi wrote: > CNL is the only platform with GRAPHICS_VER == 10. With its removal we > don't need to handle that version anymore. > > Also we can now reduce the max number of slices: the call to > intel_sseu_set_info() with the highest number of

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915/display: Disable FBC when PSR2 is enabled for xelpd platforms

2021-07-26 Thread Souza, Jose
On Sat, 2021-07-17 at 12:48 +, Patchwork wrote: Patch Details Series: series starting with [1/4] drm/i915/display: Disable FBC when PSR2 is enabled for xelpd platforms URL:https://patchwork.freedesktop.org/series/92667/ State: failure Details:

Re: [Intel-gfx] [PATCH 08/33] drm/i915/guc: Reset implementation for new GuC interface

2021-07-26 Thread John Harrison
On 7/22/2021 16:54, Matthew Brost wrote: Reset implementation for new GuC interface. This is the legacy reset implementation which is called when the i915 owns the engine hang check. Future patches will offload the engine hang check to GuC but we will continue to maintain this legacy path as a

Re: [Intel-gfx] [PATCH 31/47] drm/i915/guc: Reset implementation for new GuC interface

2021-07-26 Thread Matthew Brost
On Thu, Jul 15, 2021 at 10:36:51AM +0100, Tvrtko Ursulin wrote: > > On 24/06/2021 08:05, Matthew Brost wrote: > > Reset implementation for new GuC interface. This is the legacy reset > > implementation which is called when the i915 owns the engine hang check. > > Future patches will offload the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Disable audio, DRRS and PSR before planes

2021-07-26 Thread Patchwork
== Series Details == Series: drm/i915/display: Disable audio, DRRS and PSR before planes URL : https://patchwork.freedesktop.org/series/93024/ State : success == Summary == CI Bug Log - changes from CI_DRM_10396_full -> Patchwork_20705_full

Re: [Intel-gfx] [PATCH 23/51] drm/i915/guc: Direct all breadcrumbs for a class to single breadcrumbs

2021-07-26 Thread Matthew Brost
On Thu, Jul 22, 2021 at 01:46:08PM +0100, Tvrtko Ursulin wrote: > > On 16/07/2021 21:16, Matthew Brost wrote: > > With GuC virtual engines the physical engine which a request executes > > and completes on isn't known to the i915. Therefore we can't attach a > > request to a physical engines

Re: [Intel-gfx] [PATCH 01/10] drm/i915/bios: Allow DSI ports to be parsed by parse_ddi_port()

2021-07-26 Thread Matt Atwood
On Wed, Jul 21, 2021 at 10:43:29PM -0700, José Roberto de Souza wrote: > Allow MIPI DSI ports to be parsed like any other DDI port. > This will be helpful to integrate into just one function the parse of > information about integrated panels(eDP and DSI). > > Allow MIPI DSI ports to be parsed to

Re: [Intel-gfx] [PATCH 04/10] drm/i915/bios: Enable parse of two integrated panels backlight data

2021-07-26 Thread Matt Atwood
On Wed, Jul 21, 2021 at 10:43:32PM -0700, José Roberto de Souza wrote: > Continuing the conversion from single integrated VBT data to two, now > handling backlight data. > > Cc: Ville Syrjälä > Cc: Jani Nikula > Signed-off-by: José Roberto de Souza Reviewed-by: Matt Atwood > --- >

Re: [Intel-gfx] [PATCH 03/10] drm/i915/bios: Enable parse of two integrated panels timing data

2021-07-26 Thread Matt Atwood
On Wed, Jul 21, 2021 at 10:43:31PM -0700, José Roberto de Souza wrote: > Continuing the conversion from single integrated VBT data to two. > > Cc: Ville Syrjälä > Cc: Jani Nikula > Signed-off-by: José Roberto de Souza Review-by: Matt Atwood > --- > drivers/gpu/drm/i915/display/intel_bios.c

Re: [Intel-gfx] [PATCH 02/10] drm/i915/bios: Start to support two integrated panels

2021-07-26 Thread Matt Atwood
On Wed, Jul 21, 2021 at 10:43:30PM -0700, José Roberto de Souza wrote: > VBT has support for up two integrated panels but i915 only supports one. > > So here stating to add the basic support for two integrated panels > and moving the DRRS to ddi_vbt_port_info instead of keeping a global > one. >

Re: [Intel-gfx] [PATCH 4/4] drm/i915/display/psr2: Force a PSR exit in the frontbuffer modification flushes

2021-07-26 Thread Srivatsa, Anusha
> -Original Message- > From: Intel-gfx On Behalf Of José > Roberto de Souza > Sent: Friday, July 16, 2021 6:12 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 4/4] drm/i915/display/psr2: Force a PSR exit in > the frontbuffer modification flushes > > The

Re: [Intel-gfx] [PATCH 01/10] drm/i915/bios: Allow DSI ports to be parsed by parse_ddi_port()

2021-07-26 Thread Matt Atwood
On Wed, Jul 21, 2021 at 10:43:29PM -0700, José Roberto de Souza wrote: > Allow MIPI DSI ports to be parsed like any other DDI port. > This will be helpful to integrate into just one function the parse of > information about integrated panels(eDP and DSI). > > Allow MIPI DSI ports to be parsed to

Re: [Intel-gfx] [PATCH 3/4] drm/i915/display/psr2: Fix cursor updates using legacy apis

2021-07-26 Thread Srivatsa, Anusha
> -Original Message- > From: Intel-gfx On Behalf Of José > Roberto de Souza > Sent: Friday, July 16, 2021 6:12 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 3/4] drm/i915/display/psr2: Fix cursor updates > using legacy apis > > The fast path only updates cursor

Re: [Intel-gfx] [PATCH 2/4] drm/i915/display/psr2: Mark as updated all planes that intersect with pipe_clip

2021-07-26 Thread Srivatsa, Anusha
> -Original Message- > From: Intel-gfx On Behalf Of José > Roberto de Souza > Sent: Friday, July 16, 2021 6:12 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 2/4] drm/i915/display/psr2: Mark as updated all > planes that intersect with pipe_clip > > Without this

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc/slpc: Enable GuC based power management features

2021-07-26 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Enable GuC based power management features URL : https://patchwork.freedesktop.org/series/93026/ State : success == Summary == CI Bug Log - changes from CI_DRM_10396 -> Patchwork_20707

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc/slpc: Enable GuC based power management features

2021-07-26 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Enable GuC based power management features URL : https://patchwork.freedesktop.org/series/93026/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc/slpc: Enable GuC based power management features

2021-07-26 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Enable GuC based power management features URL : https://patchwork.freedesktop.org/series/93026/ State : warning == Summary == $ dim checkpatch origin/drm-tip e739b51dc573 drm/i915/guc: SQUASHED PATCH - DO NOT REVIEW -:54: WARNING:BAD_SIGN_OFF:

[Intel-gfx] [PATCH 15/15] drm/i915/guc/rc: Setup and enable GUCRC feature

2021-07-26 Thread Vinay Belgaumkar
This feature hands over the control of HW RC6 to the GuC. GuC decides when to put HW into RC6 based on it's internal busyness algorithms. GUCRC needs GuC submission to be enabled, and only supported on Gen12+ for now. When GUCRC is enabled, do not set HW RC6. Use a H2G message to tell GuC to

[Intel-gfx] [PATCH 12/15] drm/i915/guc/slpc: Cache platform frequency limits

2021-07-26 Thread Vinay Belgaumkar
Cache rp0, rp1 and rpn platform limits into SLPC structure for range checking while setting min/max frequencies. Also add "soft" limits which keep track of frequency changes made from userland. These are initially set to platform min and max. v2: Address review comments (Michal W) v3: Formatting

[Intel-gfx] [PATCH 13/15] drm/i915/guc/slpc: Sysfs hooks for SLPC

2021-07-26 Thread Vinay Belgaumkar
Update the get/set min/max freq hooks to work for SLPC case as well. Consolidate helpers for requested/min/max frequency get/set to intel_rps where the proper action can be taken depending on whether SLPC is enabled. v2: Add wrappers for getting rp0/1/n frequencies, update softlimits in set

[Intel-gfx] [PATCH 14/15] drm/i915/guc/slpc: Add SLPC selftest

2021-07-26 Thread Vinay Belgaumkar
Tests that exercise the SLPC get/set frequency interfaces. Clamp_max will set max frequency to multiple levels and check that SLPC requests frequency lower than or equal to it. Clamp_min will set min frequency to different levels and check if SLPC requests are higher or equal to those levels.

[Intel-gfx] [PATCH 10/15] drm/i915/guc/slpc: Add debugfs for SLPC info

2021-07-26 Thread Vinay Belgaumkar
This prints out relevant SLPC info from the SLPC shared structure. We will send a h2g message which forces SLPC to update the shared data structure with latest information before reading it. v2: Address review comments (Michal W) v3: Remove unnecessary tasks from slpc_info (Michal W)

[Intel-gfx] [PATCH 11/15] drm/i915/guc/slpc: Enable ARAT timer interrupt

2021-07-26 Thread Vinay Belgaumkar
This interrupt is enabled during RPS initialization, and now needs to be done by SLPC code. It allows ARAT timer expiry interrupts to get forwarded to GuC. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 16

[Intel-gfx] [PATCH 09/15] drm/i915/guc/slpc: Add get max/min freq hooks

2021-07-26 Thread Vinay Belgaumkar
Add helpers to read the min/max frequency being used by SLPC. This is done by send a H2G command which forces SLPC to update the shared data struct which can then be read. These helpers will be used in a sysfs patch later on. v2: Address review comments (Michal W) v3: Return err in case of query

[Intel-gfx] [PATCH 08/15] drm/i915/guc/slpc: Add methods to set min/max frequency

2021-07-26 Thread Vinay Belgaumkar
Add param set h2g helpers to set the min and max frequencies for use by SLPC. v2: Address review comments (Michal W) v3: Check for positive error code (Michal W) Signed-off-by: Sundaresan Sujaritha Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 89

[Intel-gfx] [PATCH 07/15] drm/i915/guc/slpc: Remove BUG_ON in guc_submission_disable

2021-07-26 Thread Vinay Belgaumkar
The assumption when it was added was there would be no wakerefs held. However, if we fail to enable SLPC, we will still be holding a wakeref. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 4 1 file changed, 4 deletions(-) diff --git

[Intel-gfx] [PATCH 06/15] drm/i915/guc/slpc: Enable SLPC and add related H2G events

2021-07-26 Thread Vinay Belgaumkar
Add methods for interacting with GuC for enabling SLPC. Enable SLPC after GuC submission has been established. GuC load will fail if SLPC cannot be successfully initialized. Add various helper methods to set/unset the parameters for SLPC. They can be set using H2G calls or directly setting bits in

[Intel-gfx] [PATCH 05/15] drm/i915/guc/slpc: Allocate, initialize and release SLPC

2021-07-26 Thread Vinay Belgaumkar
Allocate data structures for SLPC and functions for initializing on host side. v2: Address review comments (Michal W) v3: Remove unnecessary header includes (Michal W) Signed-off-by: Vinay Belgaumkar Signed-off-by: Sundaresan Sujaritha --- drivers/gpu/drm/i915/gt/uc/intel_guc.c| 11

[Intel-gfx] [PATCH 04/15] drm/i915/guc/slpc: Adding SLPC communication interfaces

2021-07-26 Thread Vinay Belgaumkar
Add constants and params that are needed to configure SLPC. v2: Add a new abi header for SLPC. Replace bitfields with genmasks. Address other comments from Michal W. v3: Add slpc H2G format in abi, other review commments (Michal W) v4: Update status bits according to latest spec Signed-off-by:

[Intel-gfx] [PATCH 03/15] drm/i915/guc/slpc: Gate Host RPS when SLPC is enabled

2021-07-26 Thread Vinay Belgaumkar
Also ensure uc_init is called before we initialize RPS so that we can check for SLPC support. We do not need to enable up/down interrupts when SLPC is enabled. However, we still need the ARAT interrupt, which will be enabled separately later. Signed-off-by: Vinay Belgaumkar Signed-off-by:

[Intel-gfx] [PATCH 02/15] drm/i915/guc/slpc: Initial definitions for SLPC

2021-07-26 Thread Vinay Belgaumkar
Add macros to check for SLPC support. This feature is currently supported for Gen12+ and enabled whenever GuC submission is enabled/selected. Include templates for SLPC init/fini and enable. v2: Move SLPC helper functions to intel_guc_slpc.c/.h. Define basic template for SLPC structure in

[Intel-gfx] [PATCH v3 00/15] drm/i915/guc/slpc: Enable GuC based power management features

2021-07-26 Thread Vinay Belgaumkar
This series enables Single Loop Power Control (SLPC) feature in GuC. GuC implements various power management algorithms as part of it's operation. These need to be specifically enabled by KMD. They replace the legacy host based management of these features. With this series, we will enable two PM

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Disable audio, DRRS and PSR before planes

2021-07-26 Thread Patchwork
== Series Details == Series: drm/i915/display: Disable audio, DRRS and PSR before planes URL : https://patchwork.freedesktop.org/series/93024/ State : success == Summary == CI Bug Log - changes from CI_DRM_10396 -> Patchwork_20705 Summary

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/display: Drop redundant debug print

2021-07-26 Thread Patchwork
== Series Details == Series: drm/i915/display: Drop redundant debug print URL : https://patchwork.freedesktop.org/series/93025/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h CC

[Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print

2021-07-26 Thread Swati Sharma
drm_dp_dpcd_read/write already has debug error message. Drop redundant error messages which gives false status even if correct value is read in drm_dp_dpcd_read(). Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/display/intel_dp.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Disable audio, DRRS and PSR before planes

2021-07-26 Thread Patchwork
== Series Details == Series: drm/i915/display: Disable audio, DRRS and PSR before planes URL : https://patchwork.freedesktop.org/series/93024/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4b987bbf5ee8 drm/i915/display: Disable audio, DRRS and PSR before planes -:137:

Re: [Intel-gfx] [PATCH 04/10] drm/i915: move intel_context slab to direct module init/exit

2021-07-26 Thread Jason Ekstrand
On Mon, Jul 26, 2021 at 11:31 AM Tvrtko Ursulin wrote: > > > On 26/07/2021 17:20, Jason Ekstrand wrote: > > On Mon, Jul 26, 2021 at 11:08 AM Tvrtko Ursulin > > wrote: > >> On 26/07/2021 16:42, Jason Ekstrand wrote: > >>> On Mon, Jul 26, 2021 at 10:30 AM Jason Ekstrand > >>> wrote: > >

[Intel-gfx] [PATCH] drm/i915/display: Disable audio, DRRS and PSR before planes

2021-07-26 Thread José Roberto de Souza
HDMI and DisplayPort sequences states that audio and PSR should be disabled before planes are disabled. Not following it did not caused any problems up to Alderlake-P but for this platform it causes underruns during the PSR2 disable sequence. Specification don't mention that DRRS should be

Re: [Intel-gfx] [PATCH 25/33] drm/i915/guc: Support request cancellation

2021-07-26 Thread Matthew Brost
On Mon, Jul 26, 2021 at 10:49:37AM -0700, Daniele Ceraolo Spurio wrote: > > > On 7/22/2021 4:54 PM, Matthew Brost wrote: > > This adds GuC backend support for i915_request_cancel(), which in turn > > makes CONFIG_DRM_I915_REQUEST_TIMEOUT work. > > > > This implemenation makes use of fence while

Re: [Intel-gfx] [PATCH 25/33] drm/i915/guc: Support request cancellation

2021-07-26 Thread Daniele Ceraolo Spurio
On 7/22/2021 4:54 PM, Matthew Brost wrote: This adds GuC backend support for i915_request_cancel(), which in turn makes CONFIG_DRM_I915_REQUEST_TIMEOUT work. This implemenation makes use of fence while there is likely simplier options. A fence was choosen because of another feature coming

Re: [Intel-gfx] [PATCH 04/10] drm/i915: move intel_context slab to direct module init/exit

2021-07-26 Thread Tvrtko Ursulin
On 26/07/2021 17:20, Jason Ekstrand wrote: On Mon, Jul 26, 2021 at 11:08 AM Tvrtko Ursulin wrote: On 26/07/2021 16:42, Jason Ekstrand wrote: On Mon, Jul 26, 2021 at 10:30 AM Jason Ekstrand wrote: On Mon, Jul 26, 2021 at 3:35 AM Tvrtko Ursulin wrote: On 23/07/2021 20:29, Daniel Vetter

Re: [Intel-gfx] [PATCH 04/10] drm/i915: move intel_context slab to direct module init/exit

2021-07-26 Thread Jason Ekstrand
On Mon, Jul 26, 2021 at 11:08 AM Tvrtko Ursulin wrote: > On 26/07/2021 16:42, Jason Ekstrand wrote: > > On Mon, Jul 26, 2021 at 10:30 AM Jason Ekstrand > > wrote: > >> > >> On Mon, Jul 26, 2021 at 3:35 AM Tvrtko Ursulin > >> wrote: > >>> > >>> > >>> On 23/07/2021 20:29, Daniel Vetter wrote: >

Re: [Intel-gfx] [PATCH] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-26 Thread Tvrtko Ursulin
On 26/07/2021 16:14, Jason Ekstrand wrote: On Mon, Jul 26, 2021 at 3:31 AM Maarten Lankhorst wrote: Op 23-07-2021 om 13:34 schreef Matthew Auld: From: Chris Wilson Jason Ekstrand requested a more efficient method than userptr+set-domain to determine if the userptr object was backed by a

Re: [Intel-gfx] [PATCH 04/10] drm/i915: move intel_context slab to direct module init/exit

2021-07-26 Thread Tvrtko Ursulin
On 26/07/2021 16:42, Jason Ekstrand wrote: On Mon, Jul 26, 2021 at 10:30 AM Jason Ekstrand wrote: On Mon, Jul 26, 2021 at 3:35 AM Tvrtko Ursulin wrote: On 23/07/2021 20:29, Daniel Vetter wrote: With the global kmem_cache shrink infrastructure gone there's nothing special and we can

Re: [Intel-gfx] [PATCH 01/33] drm/i915/guc: GuC virtual engines

2021-07-26 Thread Daniele Ceraolo Spurio
On 7/24/2021 4:13 PM, Matthew Brost wrote: On Fri, Jul 23, 2021 at 05:47:45PM -0700, Daniele Ceraolo Spurio wrote: On 7/22/2021 4:53 PM, Matthew Brost wrote: Implement GuC virtual engines. Rather simple implementation, basically just allocate an engine, setup context enter / exit function

Re: [Intel-gfx] [PATCH 0/8] drm/i915: Migrate memory to SMEM when imported cross-device (v8)

2021-07-26 Thread Matthew Auld
On Mon, 26 Jul 2021 at 16:32, Jason Ekstrand wrote: > > On Mon, Jul 26, 2021 at 10:29 AM Matthew Auld > wrote: > > > > On Mon, 26 Jul 2021 at 16:11, Jason Ekstrand wrote: > > > > > > On Mon, Jul 26, 2021 at 3:12 AM Matthew Auld > > > wrote: > > > > > > > > On Fri, 23 Jul 2021 at 18:21, Jason

  1   2   >