== Series Details ==
Series: series starting with [1/2] drm: i915: move intel_pch.h to include/drm
URL : https://patchwork.freedesktop.org/series/93987/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10519 -> Patchwork_20884
On Thu, 15 Jul 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> A bunch of cleanups to the DPLL code.
There were a couple of nitpicks to be made, but meh. Overall nice
cleanups.
One of the patches needed git am -C 0 to apply, please double check the
result if you resort to that while applyi
> -Original Message-
> From: Intel-gfx On Behalf Of Rodrigo
> Vivi
> Sent: Tuesday, August 24, 2021 9:15 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Vivi, Rodrigo ; Deak, Imre ;
> Tangudu, Tilak
> Subject: [Intel-gfx] [PATCH 2/2] drm/i915/runtime_pm: Let's avoid the
> undocumented D
On Wed, 25 Aug 2021, Koba Ko wrote:
> Because AMD GPU have a issue on RKL platform,
> driver needs to determine which intel platfomr is and
> if the platform is RKL, disable PCIE_DPM for AMD polaris-series GPUs.
>
> Move intel_pch.h to includ/drm
I don't know what the root cause is, or whether th
On Wed, 25 Aug 2021, Koba Ko wrote:
> AMD polaris GPUs have an issue about audio noise on RKL platform,
> they provide a commit to fix but for SMU7-based GPU still
> need another module parameter,
>
> For avoiding the module parameter, switch PCI_DPM by determining
> intel platform in amd drm driv
On 8/25/21 12:54 AM, Nathan Chancellor wrote:
Clang warns a couple of times:
drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c:63:6: warning:
variable 'import_obj' is used uninitialized whenever 'if' condition is
true [-Wsometimes-uninitialized]
if (import != &obj->base) {
On 8/25/21 12:54 AM, Nathan Chancellor wrote:
Clang warns:
drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c:127:13: warning:
variable 'err' is used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
} else if (PTR_ERR(import) != -EOPNOTSUPP) {
On Wed, Aug 25, 2021 at 5:22 PM Jani Nikula wrote:
>
> On Wed, 25 Aug 2021, Koba Ko wrote:
> > AMD polaris GPUs have an issue about audio noise on RKL platform,
> > they provide a commit to fix but for SMU7-based GPU still
> > need another module parameter,
> >
> > For avoiding the module paramet
On Wed, 25 Aug 2021, Koba Ko wrote:
> On Wed, Aug 25, 2021 at 5:22 PM Jani Nikula
> wrote:
>>
>> On Wed, 25 Aug 2021, Koba Ko wrote:
>> > AMD polaris GPUs have an issue about audio noise on RKL platform,
>> > they provide a commit to fix but for SMU7-based GPU still
>> > need another module par
Hi,
Updated the series again to avoid recursive locking caught by the
Intel-gfx CI. Patch 5 touches a number of files, including the Intel and
VMware drivers, but most changes are simply switching a function call to
the appropriate locked/unlocked version.
Overall, this series fixes races with mo
drm_master_release can be called on a drm_file without a master, which
results in a null ptr dereference of file_priv->master->magic_map. The
three cases are:
1. Error path in drm_open_helper
drm_open():
drm_open_helper():
drm_master_open():
drm_new_set_master(); <--- returns -
drm_device.master_mutex currently protects the following:
- drm_device.master
- drm_file.master
- drm_file.was_master
- drm_file.is_master
- drm_master.unique
- drm_master.unique_len
- drm_master.magic_map
There is a clear separation between functions that read or change
these attributes. Hence, c
In a future patch, a read lock on drm_device.master_rwsem is
held in the ioctl handler before the check for ioctl
permissions. However, this inverts the lock hierarchy of
drm_global_mutex --> master_rwsem.
To avoid this, we do some prep work to grab the drm_global_mutex
before checking for ioctl p
In drm_client_modeset.c and drm_fb_helper.c,
drm_master_internal_{acquire,release} are used to avoid races with DRM
userspace. These functions hold onto drm_device.master_rwsem while
committing, and bail if there's already a master.
However, there are other places where modesetting rights can race
__drm_mode_object_find checks if the given drm file holds the required
lease on a object by calling _drm_lease_held. _drm_lease_held in turn
uses drm_file_get_master to access drm_file.master.
However, in a future patch, the drm_file.master_lookup_lock in
drm_file_get_master will be replaced by dr
drm_lease_held calls drm_file_get_master. However, this function is
sometimes called while holding on to modeset_mutex. Since
drm_device.master_rwsem will replace drm_file.master_lookup_lock in
drm_file_get_master in a future patch, this inverts the master_rwsem
--> modeset_mutex lock hierarchy.
T
Previously, master_lookup_lock was introduced in
commit 0b0860a3cf5e ("drm: serialize drm_file.master with a new
spinlock") to serialize accesses to drm_file.master. This then allowed
us to write drm_file_get_master in commit 56f0729a510f ("drm: protect
drm_master pointers in drm_lease.c").
The ra
On 27/07/2021 01:23, Matthew Brost wrote:
When using GuC submission, if a context gets banned disable scheduling
and mark all inflight requests as complete.
Cc: John Harrison
Signed-off-by: Matthew Brost
Reviewed-by: John Harrison
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +-
== Series Details ==
Series: drm: update locking for modesetting (rev3)
URL : https://patchwork.freedesktop.org/series/93864/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
CALLscripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.h
Kernel:
Extract the backlight code out of intel_panel.c, and rename the panel
and backlight functions according to usual conventions.
Lyude, I haven't seen follow-ups on the DPCD backlight stuff you've
worked on. Is it okay to merge this (and inevitably cause you conflicts)
or shall I wait more?
BR,
Jani
In a long overdue refactoring, split out backlight code to new
intel_backlight.[ch]. Simple code movement, leave renames for follow-up
work. No functional changes.
Cc: Lyude Paul
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile |1 +
drivers/gpu/drm/i915/display/
Follow the usual naming conventions. As a drive-by cleanup, also pass
intel_connector instead of drm_connector to intel_backlight_setup(). No
functional changes.
Cc: Lyude Paul
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/g4x_dp.c | 2 +-
drivers/gpu/drm/i915/display/icl
Follow the usual naming conventions. Also pull HAS_GMCH() check to
intel_panel_fitting(). No functional changes.
Cc: Lyude Paul
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/icl_dsi.c | 4 ++--
drivers/gpu/drm/i915/display/intel_dp.c| 9 +++-
drivers/gpu/drm/i915/dis
On Wed, Aug 25, 2021 at 6:24 PM Jani Nikula wrote:
>
> On Wed, 25 Aug 2021, Koba Ko wrote:
> > On Wed, Aug 25, 2021 at 5:22 PM Jani Nikula
> > wrote:
> >>
> >> On Wed, 25 Aug 2021, Koba Ko wrote:
> >> > AMD polaris GPUs have an issue about audio noise on RKL platform,
> >> > they provide a com
On Mon, 23 Aug 2021, Vandita Kulkarni wrote:
> Enable MIPI DSI support on ADL-P platform.
> The esc clock changes, WA changes are taken care
> in the previous patches.
> As per the Bspec the seq remains to be same as TGL.
>
> Signed-off-by: Vandita Kulkarni
Reviewed-by: Jani Nikula
> ---
> d
== Series Details ==
Series: drm/i915: better backlight & panel abstractions
URL : https://patchwork.freedesktop.org/series/94004/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
46e4b18ff71c drm/i915/backlight: extract backlight code to a separate file
-:58: WARNING:FILE_PATH_CH
i915 enables a wider set of warnings with '-Wall -Wextra' then disables
several with cc-disable-warning. If an unknown flag gets added to
KBUILD_CFLAGS when building with clang, all subsequent calls to
cc-{disable-warning,option} will fail, meaning that all of these
warnings do not get disabled [1]
== Series Details ==
Series: drm/i915: better backlight & panel abstractions
URL : https://patchwork.freedesktop.org/series/94004/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10519 -> Patchwork_20886
Summary
---
**
On Wed, Aug 25, 2021 at 12:49:25AM +, Souza, Jose wrote:
> On Thu, 2021-08-19 at 19:07 +0300, Ville Syrjälä wrote:
> > On Wed, Aug 18, 2021 at 07:48:03PM +, Souza, Jose wrote:
> > > On Wed, 2021-08-18 at 17:55 +0300, Ville Syrjälä wrote:
> > > > On Tue, Aug 17, 2021 at 05:42:15PM -0700, Jos
== Series Details ==
Series: series starting with [1/2] drm: i915: move intel_pch.h to include/drm
URL : https://patchwork.freedesktop.org/series/93987/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10519_full -> Patchwork_20884_full
===
== Series Details ==
Series: drm/i915: Clean up disabled warnings
URL : https://patchwork.freedesktop.org/series/94009/
State : failure
== Summary ==
Applying: drm/i915: Clean up disabled warnings
error: sha1 information is lacking or useless (drivers/gpu/drm/i915/Makefile).
error: could not b
On Wed, Aug 25, 2021 at 03:47:12PM +0300, Ville Syrjälä wrote:
> On Wed, Aug 25, 2021 at 12:49:25AM +, Souza, Jose wrote:
> > On Thu, 2021-08-19 at 19:07 +0300, Ville Syrjälä wrote:
> > > On Wed, Aug 18, 2021 at 07:48:03PM +, Souza, Jose wrote:
> > > > On Wed, 2021-08-18 at 17:55 +0300, Vil
On Mon, 23 Aug 2021, Vandita Kulkarni wrote:
> Wa_16012360555 SW will have to program the "LP to HS Wakeup Guardband"
> field to account for the repeaters on the HS Request/Ready PPI signaling
> between the Display engine and the DPHY.
>
> v2: Fix build issue.
>
> Signed-off-by: Vandita Kulkarni
Sorry for the noise. Sending out a new version because the Intel-gfx CI
caught that __drm_mode_object_find has to be exported for loadable
modules like the Intel and VMware DRM drivers.
Hi,
Updated the series again to avoid recursive locking caught by the
Intel-gfx CI. Patch 5 touches a number of
drm_master_release can be called on a drm_file without a master, which
results in a null ptr dereference of file_priv->master->magic_map. The
three cases are:
1. Error path in drm_open_helper
drm_open():
drm_open_helper():
drm_master_open():
drm_new_set_master(); <--- returns -
drm_device.master_mutex currently protects the following:
- drm_device.master
- drm_file.master
- drm_file.was_master
- drm_file.is_master
- drm_master.unique
- drm_master.unique_len
- drm_master.magic_map
There is a clear separation between functions that read or change
these attributes. Hence, c
In a future patch, a read lock on drm_device.master_rwsem is
held in the ioctl handler before the check for ioctl
permissions. However, this inverts the lock hierarchy of
drm_global_mutex --> master_rwsem.
To avoid this, we do some prep work to grab the drm_global_mutex
before checking for ioctl p
In drm_client_modeset.c and drm_fb_helper.c,
drm_master_internal_{acquire,release} are used to avoid races with DRM
userspace. These functions hold onto drm_device.master_rwsem while
committing, and bail if there's already a master.
However, there are other places where modesetting rights can race
__drm_mode_object_find checks if the given drm file holds the required
lease on a object by calling _drm_lease_held. _drm_lease_held in turn
uses drm_file_get_master to access drm_file.master.
However, in a future patch, the drm_file.master_lookup_lock in
drm_file_get_master will be replaced by dr
drm_lease_held calls drm_file_get_master. However, this function is
sometimes called while holding on to modeset_mutex. Since
drm_device.master_rwsem will replace drm_file.master_lookup_lock in
drm_file_get_master in a future patch, this inverts the master_rwsem
--> modeset_mutex lock hierarchy.
T
Previously, master_lookup_lock was introduced in
commit 0b0860a3cf5e ("drm: serialize drm_file.master with a new
spinlock") to serialize accesses to drm_file.master. This then allowed
us to write drm_file_get_master in commit 56f0729a510f ("drm: protect
drm_master pointers in drm_lease.c").
The ra
Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings")
disabled -Wsometimes-uninitialized as noisy but there have been a few
fixes to clang that make the false positive rate fairly low so it should
be enabled to help catch obvious mistakes. The first two patches fix
revent instances of
From: Changcheng Deng
Clean up the following includecheck warning:
./drivers/gpu/drm/i915/selftests/mock_region.c: drm/ttm/ttm_placement.h
is included more than once.
No functional change.
Reported-by: Zeal Robot
Signed-off-by: Changcheng Deng
---
drivers/gpu/drm/i915/selftests/mock_region.
Clang warns a couple of times:
drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c:63:6: warning:
variable 'import_obj' is used uninitialized whenever 'if' condition is
true [-Wsometimes-uninitialized]
if (import != &obj->base) {
^~~~
drivers/gpu/drm/i915/gem/s
This warning helps catch uninitialized variables. It should have been
enabled at the same time as commit b2423184ac33 ("drm/i915: Enable
-Wuninitialized") but I did not realize they were disabled separately.
Enable it now that i915 is clean so that it stays that way.
Signed-off-by: Nathan Chancell
Clang warns:
drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c:127:13: warning:
variable 'err' is used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
} else if (PTR_ERR(import) != -EOPNOTSUPP) {
^~
drivers/gpu/dr
On Thu, 19 Aug 2021, Ville Syrjälä wrote:
> On Fri, Aug 13, 2021 at 01:43:20PM +0300, Jani Nikula wrote:
>> Extend the use of extended receiver cap at 0x2200 to cover
>> MAIN_LINK_CHANNEL_CODING_CAP in 0x2206, in case an implementation hides
>> the DP 2.0 128b/132b channel encoding cap.
>>
>> Cc:
On Wed, Aug 25, 2021 at 10:22 AM Lazar, Lijo wrote:
>
>
>
> On 8/25/2021 4:46 PM, Koba Ko wrote:
> > On Wed, Aug 25, 2021 at 6:24 PM Jani Nikula
> > wrote:
> >>
> >> On Wed, 25 Aug 2021, Koba Ko wrote:
> >>> On Wed, Aug 25, 2021 at 5:22 PM Jani Nikula
> >>> wrote:
>
> On Wed, 25 Aug
On Tue, 27 Jul 2021, Daniel Vetter wrote:
> +static void __exit i915_exit(void)
> +{
> + int i;
> +
> + for (i = init_progress - 1; i >= 0; i--) {
> + GEM_BUG_ON(i >= ARRAY_SIZE(init_funcs));
Not introduced by you, but it's kind of silly we're using GEM_BUG_ON()
in generic dri
The tables should be const arrays of const pointers, not just arrays of
const pointers.
Cc: Matt Roper
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_snps_phy.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/int
Follow the usual naming conventions. While at it, fix i915_pci.h SPDX
license comment format and add header include guards.
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_module.c | 4 ++--
drivers/gpu/drm/i915/i915_pci.c| 4 ++--
drivers/gpu/drm/i915/i915_pci.
Let's enable runtime pm autosuspend by default everywhere.
But at this time let's not touch the autosuspend_delay time,
what caused some regression on our previous attempt.
Cc: Daniel Vetter
Cc: David Weinehall
Cc: Tilak Tangudu
Cc: Imre Deak
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/
During runtime or s2idle suspend and resume cases on discrete cards,
if D3Cold is really achieved, we will blow everything up and
freeze the machine because we are not yet handling the pci states
properly.
On Integrated it simply doesn't matter because D3hot is the maximum
that we will get anyway,
Let's try to be more aggressive on the power savings, but
not as much as 0.1s that caused us some regression in the
past.
Also let's have this in a separated patch so that can be
bisected and increased back (or reverted) as needed.
Cc: Daniel Vetter
Cc: David Weinehall
Cc: Tilak Tangudu
Signed
No functional changes. Just revamping the functions with
s/dev_priv/i915
and consolidating along with other runtime_pm functions.
v2: avoid the extra redirection (Imre)
Cc: Imre Deak
Cc: Tilak Tangudu
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_drv.c | 145 +-
On Wed, Aug 25, 2021 at 06:06:23PM +0300, Jani Nikula wrote:
> Follow the usual naming conventions. While at it, fix i915_pci.h SPDX
> license comment format and add header include guards.
>
> Cc: Daniel Vetter
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i9
On Wed, Aug 25, 2021 at 09:04:02AM +, Gupta, Anshuman wrote:
>
>
> > -Original Message-
> > From: Intel-gfx On Behalf Of
> > Rodrigo
> > Vivi
> > Sent: Tuesday, August 24, 2021 9:15 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Vivi, Rodrigo ; Deak, Imre
> > ;
> > Tangudu, Til
Axe more stuff from intel_display.c.
Jani Nikula (5):
drm/i915/fdi: move intel_update_fdi_pll_freq to intel_fdi.c
drm/i915/fdi: move fdi bc bifurcation functions to intel_fdi.c
drm/i915/fdi: move more FDI stuff to FDI link train hooks
drm/i915/fdi: move fdi mphy reset and programming to in
Move FDI related functions to intel_fdi.c. Rename to have intel_fdi
prefix while at it.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 18 +-
drivers/gpu/drm/i915/display/intel_fdi.c | 16
drivers/gpu/drm/i915/display/intel_fdi.
Move FDI related functions to intel_fdi.c. Don't bother with renaming as
we'll make the functions static shortly.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 49
drivers/gpu/drm/i915/display/intel_fdi.c | 49
drivers
Accept slight duplication in the fdi link train hooks in exchange for
simplification in ilk_pch_enable(). This lets us make
ivb_update_fdi_bc_bifurcation() static again, now in intel_fdi.c.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 8 ---
drivers/gpu/drm/
This fairly detailed stuff that really has no place in
intel_display.c. Combine the calls into one to avoid exposing both.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 102 +--
drivers/gpu/drm/i915/display/intel_fdi.c | 100 ++
These shouldn't happen, but in the off chance they do, we'll want a
warning rather than panic.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_fdi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c
b/drivers/gpu/
On Tue, Aug 24, 2021 at 05:58:33PM -0700, José Roberto de Souza wrote:
> At this point is sure that HSW and BDW will never have PSR enabled by
> default, so here dropping it from device info and cleaning up code.
>
> v2:
> - enable psr support for display 9
>
> Cc: Gwan-gyeong Mun
> Signed-off-b
On Tue, Aug 24, 2021 at 05:58:34PM -0700, José Roberto de Souza wrote:
> intel_dp.c is a 5k lines monster, so moving DRRS out of it to reduce
> some lines from it.
>
> Cc: Jani Nikula
> Cc: Rodrigo Vivi
> Signed-off-by: José Roberto de Souza
> ---
> Documentation/gpu/i915.rst
On Tue, Aug 24, 2021 at 05:58:35PM -0700, José Roberto de Souza wrote:
> We had a mix of intel_edp_drrs_*(), intel_dp_drrs_*() and
> intel_dp_set_drrs_state(), so properly renaming all functions to
> keep the same pattern.
>
> While at it, also dropping intel_dp_set_drrs_state from the
> documenta
On Wed, 25 Aug 2021, Rodrigo Vivi wrote:
> On Wed, Aug 25, 2021 at 09:04:02AM +, Gupta, Anshuman wrote:
>>
>>
>> > -Original Message-
>> > From: Intel-gfx On Behalf Of
>> > Rodrigo
>> > Vivi
>> > Sent: Tuesday, August 24, 2021 9:15 PM
>> > To: intel-gfx@lists.freedesktop.org
>> > C
On Tue, Aug 24, 2021 at 05:58:32PM -0700, José Roberto de Souza wrote:
> This will break some IGT tests,
> here(https://patchwork.freedesktop.org/series/93764/)
Yeap, it broke. We need to fix that before we can really merge this.
> I fixed the ones part of fast-feedback test list but probably th
On Tue, 2021-08-24 at 18:48 +0200, Hans de Goede wrote:
> Hi,
>
> On 8/24/21 10:45 AM, Jani Nikula wrote:
> > On Fri, 20 Aug 2021, Hans de Goede wrote:
> > > Hello drm-misc and drm-intel maintainers,
> > >
> > > My "Add support for out-of-band hotplug notification" patchset:
> > > https://patchw
On Wed, Aug 25, 2021 at 10:33 PM Alex Deucher wrote:
>
> On Wed, Aug 25, 2021 at 10:22 AM Lazar, Lijo wrote:
> >
> >
> >
> > On 8/25/2021 4:46 PM, Koba Ko wrote:
> > > On Wed, Aug 25, 2021 at 6:24 PM Jani Nikula
> > > wrote:
> > >>
> > >> On Wed, 25 Aug 2021, Koba Ko wrote:
> > >>> On Wed, Aug
Reviewed-by: Lyude Paul (assuming this still applies)
As I mentioned on IRC pretty much all of the DPCD backlight helpers already
made it upstream. There are some changes I'm working on right now for VESA
backlights that use PWM for controlling the brightness level (so we can
hopefully fix https:
On 8/18/2021 11:16 PM, Matthew Brost wrote:
Rework and simplify the locking with GuC subission. Drop
sched_state_no_lock and move all fields under the guc_state.sched_state
and protect all these fields with guc_state.lock . This requires
changing the locking hierarchy from guc_state.lock -> sc
== Series Details ==
Series: drm: update locking for modesetting (rev4)
URL : https://patchwork.freedesktop.org/series/93864/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+drivers/gpu/drm/amd/am
On Wed, Aug 25, 2021 at 05:58:11PM +0300, Jani Nikula wrote:
> The tables should be const arrays of const pointers, not just arrays of
> const pointers.
>
> Cc: Matt Roper
> Signed-off-by: Jani Nikula
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/display/intel_snps_phy.c | 14 +++-
== Series Details ==
Series: drm: update locking for modesetting (rev4)
URL : https://patchwork.freedesktop.org/series/93864/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10520 -> Patchwork_20888
Summary
---
**FAILU
On Wed, 2021-08-25 at 11:55 -0400, Rodrigo Vivi wrote:
> On Tue, Aug 24, 2021 at 05:58:34PM -0700, José Roberto de Souza wrote:
> > intel_dp.c is a 5k lines monster, so moving DRRS out of it to reduce
> > some lines from it.
> >
> > Cc: Jani Nikula
> > Cc: Rodrigo Vivi
> > Signed-off-by: José Ro
On Wed, 25 Aug 2021, Lyude Paul wrote:
> Reviewed-by: Lyude Paul (assuming this still applies)
>
> As I mentioned on IRC pretty much all of the DPCD backlight helpers already
> made it upstream. There are some changes I'm working on right now for VESA
> backlights that use PWM for controlling the
== Series Details ==
Series: drm/i915: better backlight & panel abstractions
URL : https://patchwork.freedesktop.org/series/94004/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10519_full -> Patchwork_20886_full
Summary
---
== Series Details ==
Series: drm/i915: remove duplicate include
URL : https://patchwork.freedesktop.org/series/94016/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10520 -> Patchwork_20889
Summary
---
**SUCCESS**
On 8/24/2021 10:12 PM, Jason Gunthorpe wrote:
On Tue, Aug 24, 2021 at 05:25:30PM +0300, Maor Gottlieb wrote:
@@ -514,11 +531,13 @@ struct scatterlist
*sg_alloc_append_table_from_pages(struct sg_table *sgt,
offset = 0;
cur_page = j;
}
- sgt->nents
On 8/25/2021 4:46 PM, Koba Ko wrote:
On Wed, Aug 25, 2021 at 6:24 PM Jani Nikula wrote:
On Wed, 25 Aug 2021, Koba Ko wrote:
On Wed, Aug 25, 2021 at 5:22 PM Jani Nikula wrote:
On Wed, 25 Aug 2021, Koba Ko wrote:
AMD polaris GPUs have an issue about audio noise on RKL platform,
they pr
On Mon, Aug 23, 2021 at 09:31:37AM -0700, Daniele Ceraolo Spurio wrote:
> The function is only used from within GEM_BUG_ON(), which is causing
> warnings with Wunneeded-internal-declaration in some builds. Since the
> function is a simple wrapper around a CT function, we can just call the
> CT func
On 8/22/21 6:19 PM, Jim Cromie wrote:
> This patchset does 3 main things.
>
> Adds DEFINE_DYNAMIC_DEBUG_CATEGORIES to define bitmap => category
> control of pr_debugs, and to create their sysfs entries.
>
> Uses it in amdgpu, i915 to control existing pr_debugs according to
> their ad-hoc categ
On 8/22/21 6:20 PM, Jim Cromie wrote:
> DEFINE_DYNAMIC_DEBUG_CATEGORIES(name, var, bitmap_desc, @bit_descs)
> allows users to define a drm.debug style (bitmap) sysfs interface, and
> to specify the desired mapping from bits[0-N] to the format-prefix'd
> pr_debug()s to be controlled.
>
> DEFINE_
On 8/22/21 6:19 PM, Jim Cromie wrote:
> Add a const void* data member to the struct, to allow attaching
> private data that will be used soon by a setter method (via kp->data)
> to perform more elaborate actions.
>
> To attach the data at compile time, add new macros:
>
> module_param_cb_data(
On Wed, Aug 25, 2021 at 07:59:27AM +0300, Maor Gottlieb wrote:
>
> On 8/24/2021 10:12 PM, Jason Gunthorpe wrote:
> > On Tue, Aug 24, 2021 at 05:25:30PM +0300, Maor Gottlieb wrote:
> > > @@ -514,11 +531,13 @@ struct scatterlist
> > > *sg_alloc_append_table_from_pages(struct sg_table *sgt,
> > >
On Wed, Aug 25, 2021 at 05:23:35PM +, Souza, Jose wrote:
> On Wed, 2021-08-25 at 11:55 -0400, Rodrigo Vivi wrote:
> > On Tue, Aug 24, 2021 at 05:58:34PM -0700, José Roberto de Souza wrote:
> > > intel_dp.c is a 5k lines monster, so moving DRRS out of it to reduce
> > > some lines from it.
> > >
== Series Details ==
Series: drm/i915: Enable -Wsometimes-uninitialized
URL : https://patchwork.freedesktop.org/series/94015/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10520 -> Patchwork_20890
Summary
---
**SUCCE
On Wed, Aug 25, 2021 at 09:52:06AM -0700, Daniele Ceraolo Spurio wrote:
>
>
> On 8/18/2021 11:16 PM, Matthew Brost wrote:
> > Rework and simplify the locking with GuC subission. Drop
> > sched_state_no_lock and move all fields under the guc_state.sched_state
> > and protect all these fields with
== Series Details ==
Series: drm/i915/snps: constify struct intel_mpllb_state arrays harder
URL : https://patchwork.freedesktop.org/series/94021/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10520 -> Patchwork_20891
Summar
On Tue, Aug 24, 2021 at 05:07:13PM -0700, Daniele Ceraolo Spurio wrote:
>
>
> On 8/18/2021 11:16 PM, Matthew Brost wrote:
> > GuC submission has exposed an existing memory corruption in
> > live_lrc_isolation. We believe that some writes to the watchdog offsets
> > in the LRC (0x178 & 0x17c) can
== Series Details ==
Series: drm/i915/pci: rename functions to have i915_pci prefix
URL : https://patchwork.freedesktop.org/series/94022/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10520 -> Patchwork_20892
Summary
--
== Series Details ==
Series: series starting with [1/4] drm/i915/runtime_pm: Consolidate runtime_pm
functions
URL : https://patchwork.freedesktop.org/series/94023/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be chec
== Series Details ==
Series: series starting with [1/4] drm/i915/runtime_pm: Consolidate runtime_pm
functions
URL : https://patchwork.freedesktop.org/series/94023/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10520 -> Patchwork_20893
=
== Series Details ==
Series: drm/i915/fdi: refactor some fdi code out of intel_display.c
URL : https://patchwork.freedesktop.org/series/94026/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
b573cd162507 drm/i915/fdi: move intel_update_fdi_pll_freq to intel_fdi.c
e2f0b2d220b7 drm
== Series Details ==
Series: drm/i915/fdi: refactor some fdi code out of intel_display.c
URL : https://patchwork.freedesktop.org/series/94026/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10520 -> Patchwork_20894
Summary
-
On 8/18/2021 11:16 PM, Matthew Brost wrote:
Move GuC management fields in context under guc_active struct as this is
where the lock that protects theses fields lives. Also only set guc_prio
field once during context init.
Can you explain what we gain by setting that only on first pin? AFAICS
On Fri, Aug 20, 2021 at 03:57:10PM -0700, Matt Roper wrote:
> The memory latency values returned by pcode on DG2 are in units of "2
> usec" rather than 1 usec on all other platforms. I.e., we need to
> double the value returned by pcode to obtain the true latency value.
>
> The bspec wording here
On Wed, Aug 25, 2021 at 02:51:11PM -0700, Daniele Ceraolo Spurio wrote:
>
>
> On 8/18/2021 11:16 PM, Matthew Brost wrote:
> > Move GuC management fields in context under guc_active struct as this is
> > where the lock that protects theses fields lives. Also only set guc_prio
> > field once during
On Wed, Aug 25, 2021 at 02:51:11PM -0700, Daniele Ceraolo Spurio wrote:
>
>
> On 8/18/2021 11:16 PM, Matthew Brost wrote:
> > Move GuC management fields in context under guc_active struct as this is
> > where the lock that protects theses fields lives. Also only set guc_prio
> > field once during
1 - 100 of 168 matches
Mail list logo
