[Intel-gfx] ✓ Fi.CI.IGT: success for Clean up GuC CI failures, simplify locking, and kernel DOC (rev7)

2021-08-26 Thread Patchwork
== Series Details == Series: Clean up GuC CI failures, simplify locking, and kernel DOC (rev7) URL : https://patchwork.freedesktop.org/series/93704/ State : success == Summary == CI Bug Log - changes from CI_DRM_10526_full -> Patchwork_20907_full

Re: [Intel-gfx] [PATCH v15 10/12] swiotlb: Add restricted DMA pool initialization

2021-08-26 Thread Claire Chang
On Tue, Aug 24, 2021 at 10:26 PM Guenter Roeck wrote: > > Hi Claire, > > On Thu, Jun 24, 2021 at 11:55:24PM +0800, Claire Chang wrote: > > Add the initialization function to create restricted DMA pools from > > matching reserved-memory nodes. > > > > Regardless of swiotlb setting, the restricted

Re: [Intel-gfx] [PATCH 02/27] drm/i915/guc: Fix outstanding G2H accounting

2021-08-26 Thread Matthew Brost
On Thu, Aug 26, 2021 at 04:09:59PM -0700, Daniele Ceraolo Spurio wrote: > > > On 8/25/2021 8:23 PM, Matthew Brost wrote: > > A small race that could result in incorrect accounting of the number > > of outstanding G2H. Basically prior to this patch we did not increment > > the number of

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: remove unused i915->active_pipes

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915: remove unused i915->active_pipes URL : https://patchwork.freedesktop.org/series/94076/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10525_full -> Patchwork_20906_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Ensure wa_init_finish() is called for ctx workaround list (rev2)

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915: Ensure wa_init_finish() is called for ctx workaround list (rev2) URL : https://patchwork.freedesktop.org/series/94053/ State : success == Summary == CI Bug Log - changes from CI_DRM_10525_full -> Patchwork_20905_full

Re: [Intel-gfx] [PATCH 11/27] drm/i915/guc: Copy whole golden context, set engine state size of subset

2021-08-26 Thread John Harrison
On 8/25/2021 20:23, Matthew Brost wrote: When the GuC does a media reset, it copies a golden context state back into the corrupted context's state. The address of the golden context and the size of the engine state restore are passed in via the GuC ADS. The i915 had a bug where it passed in the

Re: [Intel-gfx] [PATCH 23/27] drm/i915/guc: Move GuC priority fields in context under guc_active

2021-08-26 Thread Daniele Ceraolo Spurio
On 8/25/2021 8:23 PM, Matthew Brost wrote: Move GuC management fields in context under guc_active struct as this is where the lock that protects theses fields lives. Also only set guc_prio field once during context init. v2: (Daniele) - set CONTEXT_SET_INIT Signed-off-by: Matthew Brost

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Be more gentle when exiting non-persistent contexts (rev2)

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915: Be more gentle when exiting non-persistent contexts (rev2) URL : https://patchwork.freedesktop.org/series/93420/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10525_full -> Patchwork_20903_full

Re: [Intel-gfx] [PATCH 11/27] drm/i915/guc: Copy whole golden context, set engine state size of subset

2021-08-26 Thread Daniele Ceraolo Spurio
On 8/25/2021 8:23 PM, Matthew Brost wrote: When the GuC does a media reset, it copies a golden context state back into the corrupted context's state. The address of the golden context and the size of the engine state restore are passed in via the GuC ADS. The i915 had a bug where it passed in

Re: [Intel-gfx] [PATCH 06/27] drm/i915/guc: Workaround reset G2H is received after schedule done G2H

2021-08-26 Thread Daniele Ceraolo Spurio
On 8/25/2021 8:23 PM, Matthew Brost wrote: If the context is reset as a result of the request cancellation the context reset G2H is received after schedule disable done G2H which is the wrong order. The schedule disable done G2H release the waiting request cancellation code which resubmits

Re: [Intel-gfx] [PATCH 02/27] drm/i915/guc: Fix outstanding G2H accounting

2021-08-26 Thread Daniele Ceraolo Spurio
On 8/25/2021 8:23 PM, Matthew Brost wrote: A small race that could result in incorrect accounting of the number of outstanding G2H. Basically prior to this patch we did not increment the number of outstanding G2H if we encoutered a GT reset while sending a H2G. This was incorrect as the

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Register the migrate contexts with their engines (rev2)

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Register the migrate contexts with their engines (rev2) URL : https://patchwork.freedesktop.org/series/94058/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10525_full -> Patchwork_20902_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/sched dependency handling and implicit sync fixes (rev5)

2021-08-26 Thread Patchwork
== Series Details == Series: drm/sched dependency handling and implicit sync fixes (rev5) URL : https://patchwork.freedesktop.org/series/93415/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10525_full -> Patchwork_20901_full

[Intel-gfx] ✓ Fi.CI.BAT: success for Clean up GuC CI failures, simplify locking, and kernel DOC (rev7)

2021-08-26 Thread Patchwork
== Series Details == Series: Clean up GuC CI failures, simplify locking, and kernel DOC (rev7) URL : https://patchwork.freedesktop.org/series/93704/ State : success == Summary == CI Bug Log - changes from CI_DRM_10526 -> Patchwork_20907

Re: [Intel-gfx] [PATCH 5/5] drm/i915/fdi: convert BUG()'s to MISSING_CASE()

2021-08-26 Thread Rodrigo Vivi
On Wed, Aug 25, 2021 at 06:47:52PM +0300, Jani Nikula wrote: > These shouldn't happen, but in the off chance they do, we'll want a > warning rather than panic. looks better indeed: Reviewed-by: Rodrigo Vivi > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_fdi.c | 5

Re: [Intel-gfx] [PATCH 4/5] drm/i915/fdi: move fdi mphy reset and programming to intel_fdi.c

2021-08-26 Thread Rodrigo Vivi
On Wed, Aug 25, 2021 at 06:47:51PM +0300, Jani Nikula wrote: > This fairly detailed stuff that really has no place in > intel_display.c. Combine the calls into one to avoid exposing both. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- >

Re: [Intel-gfx] [PATCH 3/5] drm/i915/fdi: move more FDI stuff to FDI link train hooks

2021-08-26 Thread Rodrigo Vivi
On Wed, Aug 25, 2021 at 06:47:50PM +0300, Jani Nikula wrote: > Accept slight duplication in the fdi link train hooks in exchange for > simplification in ilk_pch_enable(). This lets us make > ivb_update_fdi_bc_bifurcation() static again, now in intel_fdi.c. For a moment I thought there were some

Re: [Intel-gfx] [PATCH 2/4] drm/dp: use more of the extended receiver cap

2021-08-26 Thread Lyude Paul
On Thu, 2021-08-26 at 14:11 +0300, Jani Nikula wrote: > On Wed, 25 Aug 2021, Jani Nikula wrote: > > On Thu, 19 Aug 2021, Ville Syrjälä wrote: > > > On Fri, Aug 13, 2021 at 01:43:20PM +0300, Jani Nikula wrote: > > > > Extend the use of extended receiver cap at 0x2200 to cover > > > >

Re: [Intel-gfx] [PATCH 2/5] drm/i915/fdi: move fdi bc bifurcation functions to intel_fdi.c

2021-08-26 Thread Rodrigo Vivi
On Wed, Aug 25, 2021 at 06:47:49PM +0300, Jani Nikula wrote: > Move FDI related functions to intel_fdi.c. Don't bother with renaming as > we'll make the functions static shortly. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_display.c |

Re: [Intel-gfx] [PATCH 1/5] drm/i915/fdi: move intel_update_fdi_pll_freq to intel_fdi.c

2021-08-26 Thread Rodrigo Vivi
On Wed, Aug 25, 2021 at 06:47:48PM +0300, Jani Nikula wrote: > Move FDI related functions to intel_fdi.c. Rename to have intel_fdi > prefix while at it. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_display.c | 18 +- >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Clean up GuC CI failures, simplify locking, and kernel DOC (rev7)

2021-08-26 Thread Patchwork
== Series Details == Series: Clean up GuC CI failures, simplify locking, and kernel DOC (rev7) URL : https://patchwork.freedesktop.org/series/93704/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Clean up GuC CI failures, simplify locking, and kernel DOC (rev7)

2021-08-26 Thread Patchwork
== Series Details == Series: Clean up GuC CI failures, simplify locking, and kernel DOC (rev7) URL : https://patchwork.freedesktop.org/series/93704/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7fe22714f5a9 drm/i915/guc: Fix blocked context accounting 4970f2849625

Re: [Intel-gfx] [BUG - BISECTED] display not detected anymore

2021-08-26 Thread Heiko Carstens
Hi Ville, > > > ef79d62b5ce5 ("drm/i915: Encapsulate dbuf state handling harder") > > > > > > With that commit the display is not detected anymore, one commit > > > before that it still works. So this one seems to be broken. > > > > > > Ville, Stanislav, any idea how to fix this? > > > > > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Fix the mman selftest

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915/gem: Fix the mman selftest URL : https://patchwork.freedesktop.org/series/94062/ State : success == Summary == CI Bug Log - changes from CI_DRM_10524_full -> Patchwork_20900_full Summary ---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Clean up GuC CI failures, simplify locking, and kernel DOC (rev5)

2021-08-26 Thread Matthew Brost
On Thu, Aug 26, 2021 at 10:34:36AM +, Patchwork wrote: > Patch Details > > Series: Clean up GuC CI failures, simplify locking, and kernel DOC (rev5) > URL: https://patchwork.freedesktop.org/series/93704/ > State: failure > Details:

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Clean up GuC CI failures, simplify locking, and kernel DOC (rev6)

2021-08-26 Thread Matthew Brost
On Thu, Aug 26, 2021 at 04:17:07PM +, Patchwork wrote: > Patch Details > > Series: Clean up GuC CI failures, simplify locking, and kernel DOC (rev6) > URL: https://patchwork.freedesktop.org/series/93704/ > State: failure > Details:

[Intel-gfx] [PULL] drm-intel-fixes

2021-08-26 Thread Rodrigo Vivi
Hi Dave and Daniel, I also had other 2 display patches, but I decided to keep them out for now because CI_DIF_604 returned a bunch of link training errors on TGL when compared to CI_DIF_603 which is based on drm/drm-fixes. Those patches are: d7f213c131ad ("drm/i915/dp: Use max params for panels

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: Use max params for panels < eDP 1.4

2021-08-26 Thread Rodrigo Vivi
On Fri, Aug 20, 2021 at 08:26:14PM +0300, Ville Syrjälä wrote: > On Fri, Aug 20, 2021 at 03:52:59PM +0800, Kai-Heng Feng wrote: > > Users reported that after commit 2bbd6dba84d4 ("drm/i915: Try to use > > fast+narrow link on eDP again and fall back to the old max strategy on > > failure"), the

Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result

2021-08-26 Thread Rodrigo Vivi
On Sat, Aug 21, 2021 at 02:02:03AM +0300, Imre Deak wrote: > On Sat, Aug 21, 2021 at 01:20:04AM +0300, Ville Syrjälä wrote: > > On Wed, Aug 18, 2021 at 07:17:12PM +0300, Imre Deak wrote: > > > On Wed, Aug 18, 2021 at 06:09:43PM +0300, Lee, Shawn C wrote: > > > > On Tue, 2021-07-07, Lee Shawn C

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: remove unused i915->active_pipes

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915: remove unused i915->active_pipes URL : https://patchwork.freedesktop.org/series/94076/ State : success == Summary == CI Bug Log - changes from CI_DRM_10525 -> Patchwork_20906 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: remove unused i915->active_pipes

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915: remove unused i915->active_pipes URL : https://patchwork.freedesktop.org/series/94076/ State : warning == Summary == $ dim checkpatch origin/drm-tip e8c9a5aa908f drm/i915: remove unused i915->active_pipes -:10: ERROR:GIT_COMMIT_ID: Please use git commit

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Ensure wa_init_finish() is called for ctx workaround list (rev2)

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915: Ensure wa_init_finish() is called for ctx workaround list (rev2) URL : https://patchwork.freedesktop.org/series/94053/ State : success == Summary == CI Bug Log - changes from CI_DRM_10525 -> Patchwork_20905

Re: [Intel-gfx] [PATCH 16/27] drm/i915: Allocate error capture in nowait context

2021-08-26 Thread Matthew Brost
On Wed, Aug 25, 2021 at 08:23:16PM -0700, Matthew Brost wrote: > Error captures can now be done in a work queue processing G2H messages. > These messages need to be completely done being processed in the reset > path, to avoid races in the missing G2H cleanup, which create a > dependency on memory

Re: [Intel-gfx] [PATCH 16/27] drm/i915: Allocate error capture in nowait context

2021-08-26 Thread Daniel Vetter
On Wed, Aug 25, 2021 at 08:23:16PM -0700, Matthew Brost wrote: > Error captures can now be done in a work queue processing G2H messages. > These messages need to be completely done being processed in the reset > path, to avoid races in the missing G2H cleanup, which create a > dependency on memory

[Intel-gfx] ✗ Fi.CI.BAT: failure for Clean up GuC CI failures, simplify locking, and kernel DOC (rev6)

2021-08-26 Thread Patchwork
== Series Details == Series: Clean up GuC CI failures, simplify locking, and kernel DOC (rev6) URL : https://patchwork.freedesktop.org/series/93704/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10525 -> Patchwork_20904

Re: [Intel-gfx] [PATCH v5 16/20] drm/msm: Don't break exclusive fence ordering

2021-08-26 Thread Rob Clark
On Thu, Aug 5, 2021 at 3:47 AM Daniel Vetter wrote: > > There's only one exclusive slot, and we must not break the ordering. > > Adding a new exclusive fence drops all previous fences from the > dma_resv. To avoid violating the signalling order we err on the side of > over-synchronizing by

Re: [Intel-gfx] [PATCH v5 12/20] drm/msm: Use scheduler dependency handling

2021-08-26 Thread Rob Clark
On Thu, Aug 5, 2021 at 3:47 AM Daniel Vetter wrote: > > drm_sched_job_init is already at the right place, so this boils down > to deleting code. > > Signed-off-by: Daniel Vetter > Cc: Rob Clark > Cc: Sean Paul > Cc: Sumit Semwal > Cc: "Christian König" > Cc: linux-arm-...@vger.kernel.org >

Re: [Intel-gfx] [PATCH] drm/msm: Improve drm/sched point of no return rules

2021-08-26 Thread Rob Clark
On Thu, Aug 26, 2021 at 2:33 AM Daniel Vetter wrote: > > Originally drm_sched_job_init was the point of no return, after which > drivers really should submit a job. I've split that up, which allows > us to fix this issue pretty easily. > > Only thing we have to take care of is to not skip to

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Clean up GuC CI failures, simplify locking, and kernel DOC (rev6)

2021-08-26 Thread Patchwork
== Series Details == Series: Clean up GuC CI failures, simplify locking, and kernel DOC (rev6) URL : https://patchwork.freedesktop.org/series/93704/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Clean up GuC CI failures, simplify locking, and kernel DOC (rev6)

2021-08-26 Thread Patchwork
== Series Details == Series: Clean up GuC CI failures, simplify locking, and kernel DOC (rev6) URL : https://patchwork.freedesktop.org/series/93704/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6b511953d015 drm/i915/guc: Fix blocked context accounting 593f21493fda

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Be more gentle when exiting non-persistent contexts (rev2)

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915: Be more gentle when exiting non-persistent contexts (rev2) URL : https://patchwork.freedesktop.org/series/93420/ State : success == Summary == CI Bug Log - changes from CI_DRM_10525 -> Patchwork_20903

Re: [Intel-gfx] Tracing a "drm_mode_prune_invalid"

2021-08-26 Thread Adam Chasen
Ville, It appears we are receiving some minimal information about the DP to dual-link DVI adapter which may be used to indicate dual-link support. Any chance we can use this information to augment the EDID to not filter out the higher clocks? > EDID can't help us since it would only tell us

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Register the migrate contexts with their engines

2021-08-26 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 03:59:30PM +0200, Thomas Hellström wrote: > On Thu, 2021-08-26 at 14:44 +0200, Daniel Vetter wrote: > > On Thu, Aug 26, 2021 at 12:45:14PM +0200, Thomas Hellström wrote: > > > Pinned contexts, like the migrate contexts need reset after resume > > > since their context image

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Be more gentle when exiting non-persistent contexts (rev2)

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915: Be more gentle when exiting non-persistent contexts (rev2) URL : https://patchwork.freedesktop.org/series/93420/ State : warning == Summary == $ dim checkpatch origin/drm-tip 660ff9cdf697 drm/i915: Be more gentle when exiting non-persistent contexts

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Register the migrate contexts with their engines (rev2)

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Register the migrate contexts with their engines (rev2) URL : https://patchwork.freedesktop.org/series/94058/ State : success == Summary == CI Bug Log - changes from CI_DRM_10525 -> Patchwork_20902

Re: [Intel-gfx] [PATCH 24/33] drm/i915/guc: Implement banned contexts for GuC submission

2021-08-26 Thread Matthew Brost
On Thu, Aug 26, 2021 at 12:27:31PM +0100, Tvrtko Ursulin wrote: > > On 26/08/2021 04:49, Matthew Brost wrote: > > On Wed, Aug 25, 2021 at 11:39:10AM +0100, Tvrtko Ursulin wrote: > > > > > > On 27/07/2021 01:23, Matthew Brost wrote: > > > > When using GuC submission, if a context gets banned

[Intel-gfx] [PATCH] drm/i915: remove unused i915->active_pipes

2021-08-26 Thread Jani Nikula
Apparently the last reader of i915->active_pipes was removed with commit ef79d62b5ce5 ("drm/i915: Encapsulate dbuf state handling harder"), and now it's only ever written to. Remove it completely. Cc: Stanislav Lisovskiy Cc: Ville Syrjälä Signed-off-by: Jani Nikula ---

Re: [Intel-gfx] [PATCH 08/27] drm/i915/selftests: Add a cancel request selftest that triggers a reset

2021-08-26 Thread Matthew Brost
On Thu, Aug 26, 2021 at 10:32:54AM +0100, Tvrtko Ursulin wrote: > > On 26/08/2021 04:23, Matthew Brost wrote: > > Add a cancel request selftest that results in an engine reset to cancel > > the request as it is non-preemptable. Also insert a NOP request after > > the cancelled request and confirm

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Register the migrate contexts with their engines

2021-08-26 Thread Thomas Hellström
On Thu, 2021-08-26 at 14:44 +0200, Daniel Vetter wrote: > On Thu, Aug 26, 2021 at 12:45:14PM +0200, Thomas Hellström wrote: > > Pinned contexts, like the migrate contexts need reset after resume > > since their context image may have been lost. Also the GuC needs to > > register pinned contexts. >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/sched dependency handling and implicit sync fixes (rev5)

2021-08-26 Thread Patchwork
== Series Details == Series: drm/sched dependency handling and implicit sync fixes (rev5) URL : https://patchwork.freedesktop.org/series/93415/ State : success == Summary == CI Bug Log - changes from CI_DRM_10525 -> Patchwork_20901 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Register the migrate contexts with their engines

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Register the migrate contexts with their engines URL : https://patchwork.freedesktop.org/series/94058/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10522_full -> Patchwork_20899_full

Re: [Intel-gfx] [PATCH] drm/i915: Be more gentle when exiting non-persistent contexts

2021-08-26 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 11:52:14AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > When a non-persistent context exits we currently mark it as banned in > order to trigger fast termination of any outstanding GPU jobs it may have > left running. > > In doing so we apply a very strict 1ms

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Register the migrate contexts with their engines

2021-08-26 Thread Thomas Hellström
On Thu, 2021-08-26 at 14:04 +0100, Tvrtko Ursulin wrote: > > On 26/08/2021 11:45, Thomas Hellström wrote: > > Pinned contexts, like the migrate contexts need reset after resume > > since their context image may have been lost. Also the GuC needs to > > register pinned contexts. > > So kernel

Re: [Intel-gfx] [PATCH v8 7/7] drm: remove drm_file.master_lookup_lock

2021-08-26 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 10:01:22AM +0800, Desmond Cheong Zhi Xi wrote: > Previously, master_lookup_lock was introduced in > commit 0b0860a3cf5e ("drm: serialize drm_file.master with a new > spinlock") to serialize accesses to drm_file.master. This then allowed > us to write drm_file_get_master in

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/sched dependency handling and implicit sync fixes (rev5)

2021-08-26 Thread Patchwork
== Series Details == Series: drm/sched dependency handling and implicit sync fixes (rev5) URL : https://patchwork.freedesktop.org/series/93415/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5cdf79bc4298 drm/sched: Split drm_sched_job_init -:240: WARNING:UNSPECIFIED_INT: Prefer

Re: [Intel-gfx] [PATCH v8 5/7] drm: avoid circular locks in drm_mode_object_find

2021-08-26 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 10:01:20AM +0800, Desmond Cheong Zhi Xi wrote: > __drm_mode_object_find checks if the given drm file holds the required > lease on a object by calling _drm_lease_held. _drm_lease_held in turn > uses drm_file_get_master to access drm_file.master. > > However, in a future

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Register the migrate contexts with their engines

2021-08-26 Thread Tvrtko Ursulin
On 26/08/2021 11:45, Thomas Hellström wrote: Pinned contexts, like the migrate contexts need reset after resume since their context image may have been lost. Also the GuC needs to register pinned contexts. So kernel context can get corrupt because we park the GPU with it active. Blitter

Re: [Intel-gfx] [PATCH v8 4/7] drm: avoid races with modesetting rights

2021-08-26 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 10:01:19AM +0800, Desmond Cheong Zhi Xi wrote: > In drm_client_modeset.c and drm_fb_helper.c, > drm_master_internal_{acquire,release} are used to avoid races with DRM > userspace. These functions hold onto drm_device.master_rwsem while > committing, and bail if there's

Re: [Intel-gfx] [PATCH v8 1/7] drm: fix null ptr dereference in drm_master_release

2021-08-26 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 07:53:58PM +0800, Desmond Cheong Zhi Xi wrote: > On 26/8/21 5:53 pm, Daniel Vetter wrote: > > On Thu, Aug 26, 2021 at 10:01:16AM +0800, Desmond Cheong Zhi Xi wrote: > > > drm_master_release can be called on a drm_file without a master, which > > > results in a null ptr

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Register the migrate contexts with their engines

2021-08-26 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 12:45:14PM +0200, Thomas Hellström wrote: > Pinned contexts, like the migrate contexts need reset after resume > since their context image may have been lost. Also the GuC needs to > register pinned contexts. > > Add a list to struct intel_engine_cs where we add all pinned

Re: [Intel-gfx] [PATCH 4/7] drm/i915/bios: use alternate aux channel directly from child data

2021-08-26 Thread Nautiyal, Ankit K
On 8/24/2021 7:04 PM, Jani Nikula wrote: Avoid extra caching of the data. Cc: José Roberto de Souza Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 26 +++ drivers/gpu/drm/i915/i915_drv.h | 1 - 2 files changed, 12 insertions(+),

[Intel-gfx] ✓ Fi.CI.IGT: success for Enable mipi dsi on XELPD (rev3)

2021-08-26 Thread Patchwork
== Series Details == Series: Enable mipi dsi on XELPD (rev3) URL : https://patchwork.freedesktop.org/series/93917/ State : success == Summary == CI Bug Log - changes from CI_DRM_10522_full -> Patchwork_20898_full Summary ---

Re: [Intel-gfx] [PATCH v8 1/7] drm: fix null ptr dereference in drm_master_release

2021-08-26 Thread Desmond Cheong Zhi Xi
On 26/8/21 5:53 pm, Daniel Vetter wrote: On Thu, Aug 26, 2021 at 10:01:16AM +0800, Desmond Cheong Zhi Xi wrote: drm_master_release can be called on a drm_file without a master, which results in a null ptr dereference of file_priv->master->magic_map. The three cases are: 1. Error path in

Re: [Intel-gfx] [GIT PULL] drm-misc + drm-intel: Add support for out-of-band hotplug notification

2021-08-26 Thread Vivi, Rodrigo
On Thu, 2021-08-26 at 10:23 +0200, Maxime Ripard wrote: > On Wed, Aug 25, 2021 at 04:03:43PM +, Vivi, Rodrigo wrote: > > On Tue, 2021-08-24 at 18:48 +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 8/24/21 10:45 AM, Jani Nikula wrote: > > > > On Fri, 20 Aug 2021, Hans de Goede wrote: > >

Re: [Intel-gfx] [PATCH 24/33] drm/i915/guc: Implement banned contexts for GuC submission

2021-08-26 Thread Tvrtko Ursulin
On 26/08/2021 04:49, Matthew Brost wrote: On Wed, Aug 25, 2021 at 11:39:10AM +0100, Tvrtko Ursulin wrote: On 27/07/2021 01:23, Matthew Brost wrote: When using GuC submission, if a context gets banned disable scheduling and mark all inflight requests as complete. Cc: John Harrison

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Fix the mman selftest

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915/gem: Fix the mman selftest URL : https://patchwork.freedesktop.org/series/94062/ State : success == Summary == CI Bug Log - changes from CI_DRM_10524 -> Patchwork_20900 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 2/4] drm/dp: use more of the extended receiver cap

2021-08-26 Thread Jani Nikula
On Wed, 25 Aug 2021, Jani Nikula wrote: > On Thu, 19 Aug 2021, Ville Syrjälä wrote: >> On Fri, Aug 13, 2021 at 01:43:20PM +0300, Jani Nikula wrote: >>> Extend the use of extended receiver cap at 0x2200 to cover >>> MAIN_LINK_CHANNEL_CODING_CAP in 0x2206, in case an implementation hides >>> the

[Intel-gfx] [PATCH] drm/i915: Be more gentle when exiting non-persistent contexts

2021-08-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When a non-persistent context exits we currently mark it as banned in order to trigger fast termination of any outstanding GPU jobs it may have left running. In doing so we apply a very strict 1ms limit in which the left over job has to preempt before we issues an engine

[Intel-gfx] [PATCH v2] drm/i915/gt: Register the migrate contexts with their engines

2021-08-26 Thread Thomas Hellström
Pinned contexts, like the migrate contexts need reset after resume since their context image may have been lost. Also the GuC needs to register pinned contexts. Add a list to struct intel_engine_cs where we add all pinned contexts on creation, and traverse that list at resume time to reset the

Re: [Intel-gfx] [PATCH 2/2] drm/i915/debugfs: hook up ttm_resource_manager_debug

2021-08-26 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 12:03:29PM +0200, Daniel Vetter wrote: > On Thu, Aug 26, 2021 at 11:51:44AM +0200, Thomas Hellström wrote: > > On Thu, 2021-08-26 at 11:16 +0200, Daniel Vetter wrote: > > > On Thu, Aug 19, 2021 at 09:32:20AM +0200, Thomas Hellström wrote: > > > > On Wed, 2021-08-18 at 15:58

[Intel-gfx] ✗ Fi.CI.IGT: failure for Clean up GuC CI failures, simplify locking, and kernel DOC (rev5)

2021-08-26 Thread Patchwork
== Series Details == Series: Clean up GuC CI failures, simplify locking, and kernel DOC (rev5) URL : https://patchwork.freedesktop.org/series/93704/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10522_full -> Patchwork_20896_full

Re: [Intel-gfx] [PATCH 2/2] drm/i915/debugfs: hook up ttm_resource_manager_debug

2021-08-26 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 11:51:44AM +0200, Thomas Hellström wrote: > On Thu, 2021-08-26 at 11:16 +0200, Daniel Vetter wrote: > > On Thu, Aug 19, 2021 at 09:32:20AM +0200, Thomas Hellström wrote: > > > On Wed, 2021-08-18 at 15:58 +0100, Matthew Auld wrote: > > > > This should give a more complete

Re: [Intel-gfx] [PATCH 2/2] drm/i915/debugfs: hook up ttm_resource_manager_debug

2021-08-26 Thread Thomas Hellström
On Thu, 2021-08-26 at 11:51 +0200, Thomas Hellström wrote: > On Thu, 2021-08-26 at 11:16 +0200, Daniel Vetter wrote: > > On Thu, Aug 19, 2021 at 09:32:20AM +0200, Thomas Hellström wrote: > > > On Wed, 2021-08-18 at 15:58 +0100, Matthew Auld wrote: > > > > This should give a more complete view of

Re: [Intel-gfx] [PATCH v8 3/7] drm: lock drm_global_mutex earlier in the ioctl handler

2021-08-26 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 10:01:18AM +0800, Desmond Cheong Zhi Xi wrote: > In a future patch, a read lock on drm_device.master_rwsem is > held in the ioctl handler before the check for ioctl > permissions. However, this inverts the lock hierarchy of > drm_global_mutex --> master_rwsem. > > To avoid

Re: [Intel-gfx] [PATCH v8 2/7] drm: convert drm_device.master_mutex into a rwsem

2021-08-26 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 10:01:17AM +0800, Desmond Cheong Zhi Xi wrote: > drm_device.master_mutex currently protects the following: > - drm_device.master > - drm_file.master > - drm_file.was_master > - drm_file.is_master > - drm_master.unique > - drm_master.unique_len > - drm_master.magic_map > >

Re: [Intel-gfx] [PATCH v8 1/7] drm: fix null ptr dereference in drm_master_release

2021-08-26 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 10:01:16AM +0800, Desmond Cheong Zhi Xi wrote: > drm_master_release can be called on a drm_file without a master, which > results in a null ptr dereference of file_priv->master->magic_map. The > three cases are: > > 1. Error path in drm_open_helper > drm_open(): >

Re: [Intel-gfx] [PATCH 2/2] drm/i915/debugfs: hook up ttm_resource_manager_debug

2021-08-26 Thread Thomas Hellström
On Thu, 2021-08-26 at 11:16 +0200, Daniel Vetter wrote: > On Thu, Aug 19, 2021 at 09:32:20AM +0200, Thomas Hellström wrote: > > On Wed, 2021-08-18 at 15:58 +0100, Matthew Auld wrote: > > > This should give a more complete view of the various bits of > > > internal > > > resource manager state, for

[Intel-gfx] [PATCH] drm/msm: Improve drm/sched point of no return rules

2021-08-26 Thread Daniel Vetter
Originally drm_sched_job_init was the point of no return, after which drivers really should submit a job. I've split that up, which allows us to fix this issue pretty easily. Only thing we have to take care of is to not skip to error paths after that. Other drivers do this the same for out-fence

Re: [Intel-gfx] [PATCH 08/27] drm/i915/selftests: Add a cancel request selftest that triggers a reset

2021-08-26 Thread Tvrtko Ursulin
On 26/08/2021 04:23, Matthew Brost wrote: Add a cancel request selftest that results in an engine reset to cancel the request as it is non-preemptable. Also insert a NOP request after the cancelled request and confirm that it completely successfully. Which patch fixes a problem this exposes

Re: [Intel-gfx] [PATCH] drm/i915/snps: constify struct intel_mpllb_state arrays harder

2021-08-26 Thread Jani Nikula
On Wed, 25 Aug 2021, Matt Roper wrote: > On Wed, Aug 25, 2021 at 05:58:11PM +0300, Jani Nikula wrote: >> The tables should be const arrays of const pointers, not just arrays of >> const pointers. >> >> Cc: Matt Roper >> Signed-off-by: Jani Nikula > > Reviewed-by: Matt Roper Thanks, pushed.

Re: [Intel-gfx] [PATCH 2/2] drm/i915/debugfs: hook up ttm_resource_manager_debug

2021-08-26 Thread Daniel Vetter
On Thu, Aug 19, 2021 at 09:32:20AM +0200, Thomas Hellström wrote: > On Wed, 2021-08-18 at 15:58 +0100, Matthew Auld wrote: > > This should give a more complete view of the various bits of internal > > resource manager state, for device local-memory. > > > > Signed-off-by: Matthew Auld > > Cc:

[Intel-gfx] [PULL] drm-intel-next-fixes

2021-08-26 Thread Jani Nikula
Hi Dave & Daniel - Some pretty straightforward fixes for the merge window. drm-intel-next-fixes-2021-08-26: drm/i915 fixes for v5.15-rc1: - Disable underrun recovery with eDP MSO panels on ADL-P - Use designated initializers for init/exit table - Fix some error pointer usages BR, Jani. The

Re: [Intel-gfx] [PATCH 21/33] drm/i915/guc: Connect reset modparam updates to GuC policy flags

2021-08-26 Thread Jani Nikula
On Mon, 26 Jul 2021, Matthew Brost wrote: > From: John Harrison > > Changing the reset module parameter has no effect on a running GuC. > The corresponding entry in the ADS must be updated and then the GuC > informed via a Host2GuC message. > > The new debugfs interface to module parameters

Re: [Intel-gfx] [PATCH] drm/i915/pci: rename functions to have i915_pci prefix

2021-08-26 Thread Jani Nikula
On Wed, 25 Aug 2021, Rodrigo Vivi wrote: > On Wed, Aug 25, 2021 at 06:06:23PM +0300, Jani Nikula wrote: >> Follow the usual naming conventions. While at it, fix i915_pci.h SPDX >> license comment format and add header include guards. >> >> Cc: Daniel Vetter >> Signed-off-by: Jani Nikula > >

Re: [Intel-gfx] [PATCH] drm/i915: Ensure wa_init_finish() is called for ctx workaround list

2021-08-26 Thread Tvrtko Ursulin
On 26/08/2021 04:35, Matt Roper wrote: A recent restructuring of our context workaround list initialization added an early return for non-render engines; this caused us to potentially miss the wa_init_finish() call at the end of the function. The mistake is pretty harmless --- the only impact

Re: [Intel-gfx] [GIT PULL] drm-misc + drm-intel: Add support for out-of-band hotplug notification

2021-08-26 Thread Maxime Ripard
On Wed, Aug 25, 2021 at 04:03:43PM +, Vivi, Rodrigo wrote: > On Tue, 2021-08-24 at 18:48 +0200, Hans de Goede wrote: > > Hi, > > > > On 8/24/21 10:45 AM, Jani Nikula wrote: > > > On Fri, 20 Aug 2021, Hans de Goede wrote: > > > > Hello drm-misc and drm-intel maintainers, > > > > > > > > My

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Register the migrate contexts with their engines

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Register the migrate contexts with their engines URL : https://patchwork.freedesktop.org/series/94058/ State : success == Summary == CI Bug Log - changes from CI_DRM_10522 -> Patchwork_20899

Re: [Intel-gfx] [PATCH 0/3] drm/i915: better backlight & panel abstractions

2021-08-26 Thread Jani Nikula
On Wed, 25 Aug 2021, Jani Nikula wrote: > On Wed, 25 Aug 2021, Lyude Paul wrote: >> Reviewed-by: Lyude Paul (assuming this still applies) >> >> As I mentioned on IRC pretty much all of the DPCD backlight helpers already >> made it upstream. There are some changes I'm working on right now for

[Intel-gfx] [PATCH] drm/i915/gem: Fix the mman selftest

2021-08-26 Thread Thomas Hellström
Using the I915_MMAP_TYPE_FIXED mmap type requires the TTM backend, so for that mmap type, use __i915_gem_object_create_user() instead of i915_gem_object_create_internal(), as we really want to tests objects mmap-able by user-space. This also means that the out-of-space error happens at object

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable mipi dsi on XELPD (rev3)

2021-08-26 Thread Patchwork
== Series Details == Series: Enable mipi dsi on XELPD (rev3) URL : https://patchwork.freedesktop.org/series/93917/ State : success == Summary == CI Bug Log - changes from CI_DRM_10522 -> Patchwork_20898 Summary --- **SUCCESS** No

[Intel-gfx] [PATCH] drm/i915/gt: Register the migrate contexts with their engines

2021-08-26 Thread Thomas Hellström
Pinned contexts, like the migrate contexts need reset after resume since their context image may have been lost. Also the GuC needs to register pinned contexts. Add a list to struct intel_engine_cs where we add all pinned contexts on creation, and traverse that list at __engine_unpark() time to

Re: [Intel-gfx] refactor the i915 GVT support

2021-08-26 Thread Zhenyu Wang
On 2021.08.20 12:56:34 -0700, Luis Chamberlain wrote: > On Fri, Aug 20, 2021 at 04:17:24PM +0200, Christoph Hellwig wrote: > > On Thu, Aug 19, 2021 at 04:29:29PM +0800, Zhenyu Wang wrote: > > > I'm working on below patch to resolve this. But I met a weird issue in > > > case when building i915 as

Re: [Intel-gfx] refactor the i915 GVT support

2021-08-26 Thread Zhenyu Wang
On 2021.08.20 16:17:24 +0200, Christoph Hellwig wrote: > On Thu, Aug 19, 2021 at 04:29:29PM +0800, Zhenyu Wang wrote: > > I'm working on below patch to resolve this. But I met a weird issue in > > case when building i915 as module and also kvmgt module, it caused > > busy wait on

Re: [Intel-gfx] refactor the i915 GVT support

2021-08-26 Thread Zhenyu Wang
On 2021.08.19 17:43:43 +0300, Joonas Lahtinen wrote: > Quoting Zhenyu Wang (2021-08-19 11:29:29) > > On 2021.08.17 13:22:03 +0800, Zhenyu Wang wrote: > > > > On 2021.08.16 19:34:58 +0200, Christoph Hellwig wrote: > > > > > Any updates on this? I'd really hate to miss this merge window. > > > > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable mipi dsi on XELPD (rev3)

2021-08-26 Thread Patchwork
== Series Details == Series: Enable mipi dsi on XELPD (rev3) URL : https://patchwork.freedesktop.org/series/93917/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Ensure wa_init_finish() is called for ctx workaround list

2021-08-26 Thread Patchwork
== Series Details == Series: drm/i915: Ensure wa_init_finish() is called for ctx workaround list URL : https://patchwork.freedesktop.org/series/94053/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10522 -> Patchwork_20897